[01:05:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Evaluate if we still need our local fork of the jenkins xunit-plugin - https://phabricator.wikimedia.org/T253337 (10Legoktm) As long as that local commit got merged in upstream I think we should be fine. Probably worth... [01:06:55] (03CR) 10DannyS712: [C: 03+2] Add leading empty token test cases for unused "use" sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/597001 (owner: 10Thiemo Kreuz (WMDE)) [01:07:38] (03CR) 10DannyS712: [C: 03+2] Fix UnsortedUseStatements sniff failing with leading backslashes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596997 (owner: 10Thiemo Kreuz (WMDE)) [01:08:21] (03Merged) 10jenkins-bot: Fix UnsortedUseStatements sniff failing with leading backslashes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596997 (owner: 10Thiemo Kreuz (WMDE)) [01:09:59] (03CR) 10DannyS712: [C: 03+1] "LGTM, will +2 next week if there are no objections" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (https://phabricator.wikimedia.org/T252948) (owner: 10Umherirrender) [07:08:12] 10MediaWiki-Codesniffer: Code sniffer expects mismatched syntax for referenced varargs @params - https://phabricator.wikimedia.org/T218797 (10Daimona) 05Open→03Resolved a:03Daimona This is now fixed. The checks for varargs were notably improved last year as part of the PHP7 migration, and `&...$` is now ac... [07:59:03] (03PS1) 10Gilles: Add trusted volunteer and tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597992 [08:04:36] (03PS2) 10Gilles: Add trusted volunteer and tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597992 [08:31:44] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Technical-Debt: Clear /srv/.git on contint1001; move integration.wikimedia.org docroot to new location - https://phabricator.wikimedia.org/T149924 (10Dzahn)... [08:32:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Technical-Debt: Clear /srv/.git on contint1001; move integration.wikimedia.org docroot to new location - https://phabricator.wikimedia.org/T149924 (10Dzahn)... [08:36:38] (03PS1) 10Hashar: Add tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597995 [08:36:40] (03PS1) 10Hashar: Add trusted volunteer [integration/config] - 10https://gerrit.wikimedia.org/r/597996 [08:36:40] gilles: I have split your CI change ;D [08:38:09] (03CR) 10Hashar: [C: 03+2] Add tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597995 (owner: 10Hashar) [08:38:11] (03CR) 10Hashar: [C: 03+2] Add trusted volunteer [integration/config] - 10https://gerrit.wikimedia.org/r/597996 (owner: 10Hashar) [08:38:59] (03Merged) 10jenkins-bot: Add tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597995 (owner: 10Hashar) [08:39:02] (03Merged) 10jenkins-bot: Add trusted volunteer [integration/config] - 10https://gerrit.wikimedia.org/r/597996 (owner: 10Hashar) [09:03:25] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 3 others: Update Doxygen in CI to 1.8.17 or greater - https://phabricator.wikimedia.org/T242155 (10hashar) [09:05:14] 10Phabricator, 10Wikipedia-iOS-App-Backlog: Update Herald (H187) to include project 4661 - https://phabricator.wikimedia.org/T253360 (10Aklapper) Whoops, I missed that MBinder_WMF is assigned to this task, sorry! I added #iOS-app-v6.7-Bonefish-On-A-Bus to H187 in https://phabricator.wikimedia.org/H187#1494 - f... [09:05:18] 10Phabricator, 10Wikipedia-iOS-App-Backlog: Update Herald (H187) to include project 4574 - https://phabricator.wikimedia.org/T253359 (10Aklapper) Whoops, I missed that MBinder_WMF is assigned to this task, sorry! I added #iOS-app-v6.6.1-Penguin-On-A-Luge to H187 in https://phabricator.wikimedia.org/H187#1494 -... [09:13:19] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 3 others: Update Doxygen in CI to 1.8.17 or greater - https://phabricator.wikimedia.org/T242155 (10hashar) The update is https://gerrit.wikimedia... [09:43:23] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: upgrade MediaWiki appservers to Debian 10 (buster) - https://phabricator.wikimedia.org/T245757 (10Aklapper) [09:45:46] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10Aklapper) For the time being this might be superseded by resolved {T249703}. [09:55:53] 10Gerrit: Can't log in into Gerrit — "Cannot assign user name" - https://phabricator.wikimedia.org/T49385 (10Jaimeolloway) Can't log in into gerrit cannot assign user name and get error. Is anyone tell me why i get [[ https://www.bestessayservicereviews.com/essay-writing/essayservice-com-review/ | essayservice ]... [09:58:44] 10Gerrit: Can't log in into Gerrit — "Cannot assign user name" - https://phabricator.wikimedia.org/T49385 (10tomasz) Please could you [[https://www.mediawiki.org/wiki/Special:MyLanguage/How_to_report_a_bug | report a new bug]] as this issue was resolved in the year 2013. [10:02:47] (03CR) 10Daimona Eaytoy: Full rewrite of the UnusedUseStatementSniff, 4x faster (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592415 (owner: 10Thiemo Kreuz (WMDE)) [10:19:03] (03CR) 10Daimona Eaytoy: [C: 04-1] "I'm a bit concerned by the behaviour of this sniff with the following code:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [10:22:29] (03PS1) 10Daimona Eaytoy: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 [10:23:16] (03PS2) 10Daimona Eaytoy: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 [10:23:54] (03PS3) 10Daimona Eaytoy: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 [10:31:15] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:32:53] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [10:41:04] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 52142 bytes in 1.078 second response time [10:42:46] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 95935 bytes in 1.008 second response time [10:42:46] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 95683 bytes in 0.874 second response time [10:42:49] That horizon/hiera inconsistency thing I was hitting is most likely a limit. The data in horizon truncates at exactly 65536 bytes [10:43:24] (03CR) 10DannyS712: Release v31.0.0 (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [10:49:18] (03CR) 10Daimona Eaytoy: "The file was generated using gen-changelog.sh, which is (AFAIK) what is always used to generate changelogs for this repo, and it includes " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [10:49:44] (03PS1) 10Ema: Test prometheus-rdkafka-exporter with debian-glue-backports [integration/config] - 10https://gerrit.wikimedia.org/r/598016 (https://phabricator.wikimedia.org/T253197) [10:53:24] Is `logspam` a bin working only for prod hosts? [10:54:34] hauskatze: yea, only mwlog* afaict [10:54:45] ktnx [10:54:53] that's from the "udp2log" class which is being deprecated [10:54:54] I'll keep using logstash-beta UI then [10:55:24] hauskatze: actually.. [10:55:24] deployment-fluorine02.deployment-prep.eqiad.wmflabs [10:55:29] this one should have it ^ [10:55:46] Makes sense if it had it [10:55:53] fluorine was the log collector iirc [10:55:55] and it should not be called fluorine anymore [10:56:07] per https://openstack-browser.toolforge.org/puppetclass/role::logging::mediawiki::udp2log [10:56:09] "It's Beta" (tm) [10:56:17] role(logging::mediawiki::udp2log) [10:56:34] this is the same role in prod and beta.. that's a good thing [10:57:55] hauskatze: yea, we got it backwards [10:58:07] beta is adjusted to the reality of prod [11:00:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10LarsWirzenius) [11:20:39] 10Release-Engineering-Team, 10Wikimedia-GitHub, 10Developer-Advocacy (Apr-Jun 2020), 10User-Majavah: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 (10Aklapper) @Majavah: I read this entire ticket again wondering which logic identifies (and exclude... [11:21:40] 10Release-Engineering-Team, 10Wikimedia-GitHub, 10Developer-Advocacy (Apr-Jun 2020), 10User-Majavah: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 (10RhinosF1) >>! In T249703#6157956, @Aklapper wrote: > @Majavah: I read this entire ticket again wo... [11:24:57] 10Release-Engineering-Team, 10Wikimedia-GitHub, 10Developer-Advocacy (Apr-Jun 2020), 10User-Majavah: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 (10Majavah) >>! In T249703#6157960, @RhinosF1 wrote: >>>! In T249703#6157956, @Aklapper wrote: >> @M... [11:28:08] 10phan-taint-check-plugin: Make taint-check understand SelectQueryBuilder - https://phabricator.wikimedia.org/T253380 (10Daimona) [11:33:02] 10Release-Engineering-Team, 10Wikimedia-GitHub, 10Developer-Advocacy (Apr-Jun 2020), 10User-Majavah: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 (10Tgr) It would be nice to link to or at least name the Gerrit repository name in the closing messa... [12:02:11] 10Release-Engineering-Team, 10Wikimedia-GitHub, 10Developer-Advocacy (Apr-Jun 2020), 10User-Majavah: Automatically close Pull Requests in repos mirrored on Github - https://phabricator.wikimedia.org/T249703 (10Aklapper) >>! In T249703#6157963, @Majavah wrote: > This tool only looks for `.gitreview` Ah, tha... [12:17:34] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10User-Addshore: Provide a way to import or discover new mw cli commands and docker-compose files from multiple sources - https://phabricator.wikimedia.org/T253315 (10kostajh) Could you please provide some example use case for t... [12:24:57] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) If I could propose a slightly different take on this (although I might be missing c... [12:33:17] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) I agree that it shouldn't be the default setup too, in the v1 branch of mwdd this... [12:46:13] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) >>! In T253313#6158027, @Addshore wrote: > I agree that it shouldn't be the default... [12:48:58] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10User-Addshore: Provide a way to import or discover new mw cli commands and docker-compose files from multiple sources - https://phabricator.wikimedia.org/T253315 (10kostajh) Now that I understand T253313 a bit better, I think... [12:50:09] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10User-Addshore: Provide a way to import or discover new mw cli commands and docker-compose files from multiple sources - https://phabricator.wikimedia.org/T253315 (10Addshore) >>! In T253315#6158095, @kostajh wrote: > Now that... [12:53:09] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) >>! In T253313#6158093, @kostajh wrote: > The proxy and DNS are needed for facilit... [12:53:33] kostajh: I know your not working today, so don't feel the need to look too hard at anything :) [12:53:54] probably, by monday I should have the bulk of the mwdd php branch i wrote ported over to go in some way we could play around with it a bit [12:54:33] It already mostly works, just threading the needle for mw db installs in the same way as mwdd now, then there are just extra bits like the hosts file syncing and making it prettier [12:54:50] and implementing the commands that are not on the critical path, but that are nice [12:57:53] Cool! [12:59:24] and if I get it that far I'm gonna be using my crappy patch as my daily driver, while we can all collectively stare at it and figure some things out :D [13:03:23] 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: https://www.mediawiki.org/keys/keys.html contains keys of people no longer doing releases. - https://phabricator.wikimedia.org/T180615 (10Aklapper) [13:05:10] addshore: do you have access to a windows machine? [13:05:21] yup, its my main machine [13:05:23] :P [13:05:33] ah, perfect [13:05:47] are you using Docker for Windows, or something else? [13:05:54] yeah, docker for windows [13:06:50] any idea if there is a nice go libaray to do https://www.php.net/manual/en/function.passthru.php ? or am I going to need to write it myself? :D [13:08:36] 10MediaWiki-Releasing: Cleanup https://www.mediawiki.org/keys/keys.html and related - https://phabricator.wikimedia.org/T181017 (10Aklapper) 05Open→03Resolved Not sure what's left to do in this task hence boldly resolving. If there are any issues, please file a new ticket under #MediaWiki-Releasing. [13:10:42] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:11:34] 10Project-Admins, 10Math, 10PM: Organize the open tasks for Project Math - https://phabricator.wikimedia.org/T239359 (10Aklapper) @Physikerwelt: Any news / input? :) [13:15:10] addshore: i'm sure there's something, cmd or exec don't have what you need? [13:15:22] i got it :) [13:15:24] command.Stdin = os.Stdin [13:15:24] command.Stdout = os.Stdout [13:15:24] command.Stderr = os.Stderr [13:15:26] :D [13:15:39] im really liking go [13:16:12] addshore: btw https://github.com/drud/ddev might be a useful reference point, same problem space, different framework (Drupal), same language (Go) [13:16:21] nice! [13:19:06] thcipriani https://gerrit-review.googlesource.com/c/plugins/healthcheck/+/268519 [13:24:45] 10Gerrit, 10Goal: Migrate subversion to git - https://phabricator.wikimedia.org/T24596 (10hashar) [13:24:48] 10Gerrit, 10Developer-Advocacy, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497 (10hashar) 05Open→03Declined The canonical place is Gerrit which is where patches should be send. A long concern has been pull requests send to... [13:29:19] (03CR) 10Hashar: [C: 03+2] Test prometheus-rdkafka-exporter with debian-glue-backports [integration/config] - 10https://gerrit.wikimedia.org/r/598016 (https://phabricator.wikimedia.org/T253197) (owner: 10Ema) [13:30:10] (03Merged) 10jenkins-bot: Test prometheus-rdkafka-exporter with debian-glue-backports [integration/config] - 10https://gerrit.wikimedia.org/r/598016 (https://phabricator.wikimedia.org/T253197) (owner: 10Ema) [13:31:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10QChris) >>! In T253263#6154885, @Dzahn wrote: > @QChri... [13:47:38] hashar: Any ideas on the timeout? I can't replicate it locally but I did find numerous other installer bugs :P [13:47:43] timeout/OOM [13:47:56] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) I have just found out that Monday 25th is a no deploy day due an holiday in the US. I will thus push 1.35.0-wmf.32 to all wikis... [13:48:04] 10Beta-Cluster-Infrastructure, 10Operations, 10Traffic, 10User-DannyS712: 502 error on beta commons - https://phabricator.wikimedia.org/T250103 (10Aklapper) [14:01:46] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10hashar) After discussion with @Dzahn we will d... [14:07:04] (03PS1) 10Arlolra: Fix for nullable doc with nullable type and default null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 [14:07:06] (03PS1) 10Arlolra: Fix for nullable type with default null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 [14:19:28] (03CR) 10Daimona Eaytoy: Fix for nullable type with default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 (owner: 10Arlolra) [14:34:28] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) In PS9 of https://gerrit.wikimedia.org/r/c/597864 the bulk of the mwdd v1 system w... [14:36:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) The changes above would... [14:36:38] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) p:05Triage→03High a:... [14:47:26] qchris: thank you ;] [14:47:57] Heya :-D [14:49:55] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd " cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) [14:49:59] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) [14:53:19] Argh. I'm stupid :-D [14:53:26] (03PS1) 10Lars Wirzenius: fix(debian/control): previous change droped S in Source; put it back [tools/scap] - 10https://gerrit.wikimedia.org/r/598064 [14:53:35] It's +1. [14:53:45] Sorry hashar. [14:53:56] qchris: no worries ;] [14:54:09] are you going straight to Gerrit 3.1? [14:54:52] I'd even go straight to Gerrit 3.2 ... we'll see. gr-eg-g has to decide. [14:55:01] 3.2 has Java 11 support. [14:55:08] And is Polymer 3. [14:55:35] would be nice [14:55:39] And going straight to 3.2 (instead of 3.1 and then to 3.2 a week or two later) means only one UI change for users. [14:55:50] ahhh yeah [14:56:11] But let's say "We'll upgrade to at least 3.1" [14:56:22] the new UI is going to break so many users habits [14:56:29] but overall it is an improvement [14:56:34] Yup. [14:56:49] (03CR) 10Arlolra: Fix for nullable type with default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 (owner: 10Arlolra) [14:56:50] and Google apparently has paid staff UX designer working on improving the web ui [14:57:28] They even make the "-1" button red and "+1" green so stupid people like me have a hard time hitting the wrong one :-D [14:57:37] haha [14:57:51] until one from our community come to change the colors toward blue and yellow [14:58:10] :-D [15:05:38] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10hashar) I once ran `scap sync foo/bar/file.php` out of mistake so I welcome this change :] My nitpick i... [15:07:05] Polymer 3 <3 [15:07:10] (03CR) 10Hashar: [C: 03+1] layout: [integration/jenkins] Mark as archived [integration/config] - 10https://gerrit.wikimedia.org/r/597811 (https://phabricator.wikimedia.org/T252466) (owner: 10Jforrester) [15:10:20] 3.2 has file upload suppprt [15:10:23] *support [15:11:04] (03CR) 10Hashar: [C: 03+2] layout: [integration/jenkins] Mark as archived [integration/config] - 10https://gerrit.wikimedia.org/r/597811 (https://phabricator.wikimedia.org/T252466) (owner: 10Jforrester) [15:11:56] (03Merged) 10jenkins-bot: layout: [integration/jenkins] Mark as archived [integration/config] - 10https://gerrit.wikimedia.org/r/597811 (https://phabricator.wikimedia.org/T252466) (owner: 10Jforrester) [15:16:22] (03CR) 10Daimona Eaytoy: "This looks certainly correct, just a question about empty()" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 (owner: 10Arlolra) [15:16:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Technical-Debt: Archive integration/jenkins.git - https://phabricator.wikimedia.org/T252955 (10hashar) Well done :) [15:17:36] hashar: did you see https://phabricator.wikimedia.org/T224591#6103190 ? [15:17:58] unlikely, I only started processing my email spam an hour ago and I am two days late ;D [15:18:35] ah no [15:19:59] (03CR) 10Daimona Eaytoy: Fix for nullable type with default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 (owner: 10Arlolra) [15:20:03] krinkle the entry points are now in /srv/deployment/zuul/venv/bin/ [15:20:09] but maybe we can add symlinks [15:26:29] Krinkle: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/598068/ ;] [15:26:32] thx! [15:28:17] on those good words. I am gone! :] [15:34:02] 10Phabricator, 10Wikipedia-iOS-App-Backlog: Update Herald (H187) to include project 4574 - https://phabricator.wikimedia.org/T253359 (10LGoto) 05Open→03Resolved Thanks! [15:34:12] 10Phabricator, 10Wikipedia-iOS-App-Backlog: Update Herald (H187) to include project 4661 - https://phabricator.wikimedia.org/T253360 (10LGoto) 05Open→03Resolved Thanks! [15:37:07] (03CR) 10Arlolra: Fix for nullable type with default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 (owner: 10Arlolra) [15:38:54] (03CR) 10Arlolra: Fix for nullable doc with nullable type and default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 (owner: 10Arlolra) [15:56:33] (03CR) 10Jforrester: [C: 03+2] fix(debian/control): previous change droped S in Source; put it back [tools/scap] - 10https://gerrit.wikimedia.org/r/598064 (owner: 10Lars Wirzenius) [15:58:31] (03Merged) 10jenkins-bot: fix(debian/control): previous change droped S in Source; put it back [tools/scap] - 10https://gerrit.wikimedia.org/r/598064 (owner: 10Lars Wirzenius) [16:02:07] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Code Health), 10Code-Health-Group, 10Test-Coverage: Migrate https://tools.wmflabs.org/coverage/mediawiki/ to CI infrastructure - https://phabricator.wikimedia.org/T182751 (10Aklapper) [16:08:11] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Patch-For-Review: l10nupdate is still using HHVM - https://phabricator.wikimedia.org/T205313 (10Aklapper) [16:08:13] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10MediaWiki-extensions-LocalisationUpdate, 10Security: Reenable l10update in production - https://phabricator.wikimedia.org/T220481 (10Aklapper) [16:09:53] 10Gerrit: Support OAuth for login onto gerrit.wikimedia.org - https://phabricator.wikimedia.org/T147864 (10Aklapper) [16:10:30] (03PS3) 10Lars Wirzenius: feat: add scap apply-patch for security patches during train [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 [16:11:15] (03CR) 10Lars Wirzenius: "Pushed new version with changes bsed on Tyler's feedback and things I've learnt." (036 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [16:24:44] 10Phabricator (Upstream), 10Upstream: Allow custom URLs for pre-filling certain values in new task - https://phabricator.wikimedia.org/T971 (10Aklapper) [16:24:46] 10Phabricator (Upstream), 10Upstream: Allow for anonymous task logging with special template - https://phabricator.wikimedia.org/T972 (10Aklapper) [16:29:04] (03CR) 10Daimona Eaytoy: [C: 03+1] "Regardless of the empty() thing, I think this can be merged. However, I'd like to give it another read tomorrow or next week, as I'm too t" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 (owner: 10Arlolra) [16:31:13] (03CR) 10Daimona Eaytoy: Fix for nullable type with default null (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 (owner: 10Arlolra) [16:45:30] (03CR) 10Jforrester: "> Patch Set 9: Code-Review-1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [16:47:44] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > Patch Set 9: Code-Review-1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [16:57:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Evaluate if we still need our local fork of the jenkins xunit-plugin - https://phabricator.wikimedia.org/T253337 (10Jdforrester-WMF) That commit wasn't (was it ever pushed as a PR?) but https://github.com/jenkinsci/xun... [17:11:58] (03CR) 10Thiemo Kreuz (WMDE): "> […] that should have its own dedicated sniff" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [17:13:27] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Reedy) >>! In T252463#6156277, @Reedy wrote: >>>! In T252... [17:14:17] (03CR) 10Thcipriani: [C: 04-1] "a few open questions + review inline." (038 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [17:17:38] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Reedy) >>! In T252463#6156889, @thcipriani wrote: > There... [17:32:52] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > […] that should have its own dedicated sniff" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [17:38:57] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Jdforrester-WMF) We're already half-forking the stack wit... [17:44:07] (03CR) 10Thiemo Kreuz (WMDE): "> […] in PHP, objects are passed "almost-by-reference" […]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [18:00:05] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > […] in PHP, objects are passed "almost-by-reference" […]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [18:10:16] (03CR) 10Thiemo Kreuz (WMDE): "> These pieces of code clearly have different intentions behind […]" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [18:13:01] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Reedy) >>! In T252463#6159044, @Jdforrester-WMF wrote: >... [18:17:29] (03CR) 10Jforrester: [V: 03+2 C: 03+2] fabfile: Rely on DNS to point to contint primary, rather than hardcode [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597840 (owner: 10Jforrester) [18:22:03] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10CCicalese_WMF) >>! In T252463#6159044, @Jdforrester-WMF w... [18:22:55] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > These pieces of code clearly have different intentions behind […]" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [18:25:34] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10CCicalese_WMF) >>! In T252463#6156889, @thcipriani wrote:... [18:28:25] (03CR) 10Arlolra: "Will fix" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 (owner: 10Arlolra) [18:32:31] (03PS2) 10Arlolra: Fix for nullable doc with nullable type and default null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 [18:32:33] (03PS2) 10Arlolra: Fix for nullable type with default null [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598054 [18:33:42] PROBLEM - Free space - all mounts on integration-agent-docker-1016 is CRITICAL: CRITICAL: integration.integration-agent-docker-1016.diskspace._srv.byte_percentfree (<11.11%) [18:34:43] (03CR) 10Daimona Eaytoy: [C: 03+1] "(Restoring CR+1 as above)" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598053 (owner: 10Arlolra) [18:38:43] RECOVERY - Free space - all mounts on integration-agent-docker-1016 is OK: OK: All targets OK [18:41:34] (03PS3) 10Jforrester: [stretch-php72] Stop using local fork of composer [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597841 [18:41:36] (03PS1) 10Jforrester: Provide a 'debug-image' short-cut for testing images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598095 [18:42:45] mutante: confirm that `logspam` is recognized on fluorine02 but no error.log or exception.log files do exist there so it prints nix [18:44:42] (03CR) 10Jforrester: [V: 03+2 C: 03+2] Provide a 'debug-image' short-cut for testing images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598095 (owner: 10Jforrester) [18:53:17] (03CR) 10Jforrester: "Installed everywhere now:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597841 (owner: 10Jforrester) [19:22:21] (03PS4) 10Jforrester: [stretch-php72] Stop using local fork of composer [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597841 [19:22:23] (03PS1) 10Jforrester: [WIP] Provide stretch-php73 and stretch php-74 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) [19:23:02] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-Docker, 10dev-images, and 2 others: Create PHP 7.3 and PHP 7.4 variants of docker-registry.wikimedia.org/dev/stretch-php72-fpm-apache2-xdebug - https://phabricator.wikimedia.org/T245444 (10Jdforres... [19:24:34] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-Docker, 10dev-images, and 2 others: Create PHP 7.3 and PHP 7.4 variants of docker-registry.wikimedia.org/dev/stretch-php72-fpm-apache2-xdebug - https://phabricator.wikimedia.org/T245444 (10kostajh... [19:37:13] (03CR) 10Kosta Harlan: [C: 03+1] [stretch-php72] Stop using local fork of composer [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597841 (owner: 10Jforrester) [20:24:32] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): gate-and-submit-wmf might have redundant quibble jobs (Oct 2019) - https://phabricator.wikimedia.org/T234381 (10Krinkle) 05Open→03Resolved a:03Krinkle [20:26:38] (03CR) 10Umherirrender: "gen-changelog gives suggestion for the history, but it was adjust to improve format or text. If you need a commit history, you can use git" (0320 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [20:54:09] o/ James_F [20:54:49] from the dev env stuff I did today, one of the "best" things to have in core would be an installer that would run when a LS.php already existed, and also that wouldnt write an LS.php :P [20:55:53] Eww, installers. [20:55:56] * James_F backs away. [20:55:58] xD [20:56:01] More Reedy's department. [20:56:12] It's the 1 step in getting mediawiki running the the env that is a bit hacky [20:56:39] and that hack is this dance https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/cli/+/597864/9/static/dc/mnts/mediawiki/installdbs.sh [20:56:56] "'I just make zem go up, who knows where zey come down? That's not my department', says Wernher von Braun." [20:57:13] Yeah, that is a tad tedious. [20:57:50] Can we just a --no-overwrite flag to install.php? [20:58:00] Err. +add [20:58:10] yeah, that might be all it needs, but, i think we also need to make it not read LS.php if it exists maybe? or something [20:58:46] Oh, you want it to ignore the local LS, run anyway, but do nothing? [20:59:02] --just-the-tables-maam? [20:59:47] hahhaa, yes, that would do :P [20:59:51] and i love the name [21:00:09] Presumably it'll need to update LS to set new dbuser/pass/server/prefix and lab/user/pass? [21:00:39] Can't you just sniff if LS is present and then run update.php instead of install? [21:00:52] not really, as the script invoking the install knows what they are, so it can just put those in its own LW.php already [21:01:12] well, the point is that LS will exist, but if you have just destroyed your dev env you need to create the tables again [21:01:26] In your use case, yes, but I'm thinking if we're running `install.php --update-if-present` or whatever… [21:01:29] but there is no point in rming your LS with your customizations etc, in order to get the tables, to then put the LS back [21:01:53] mmmm [21:01:59] Doesn't update.php create all tables that are missing, not just "new" ones? [21:02:23] I'm actaully not sure, i dont think you can run update.php without install.php already having been done? [21:02:30] but this could be an untested assumption [21:02:37] * James_F has no idea either. [21:02:48] Maybe we could just make update.php more helpful in this circumstance? [21:03:10] that could also be an idea [21:03:20] update.php --no-really [21:12:53] 10Phabricator (Upstream), 10Project-Admins, 10Upstream: Create new project User-Examknow - https://phabricator.wikimedia.org/T253419 (10Examknow) [21:14:23] 10Project-Admins: Create new project User-Examknow - https://phabricator.wikimedia.org/T253419 (10Peachey88) [21:41:56] (03PS2) 10Umherirrender: Simplify IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596825 [21:42:04] (03CR) 10Umherirrender: Simplify IfElseStructureSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596825 (owner: 10Umherirrender) [21:42:43] (03Abandoned) 10Umherirrender: Set ignoreSpacingBeforeAssignments to false for OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/592751 (https://phabricator.wikimedia.org/T232265) (owner: 10Umherirrender) [21:50:05] 10Project-Admins, 10User-Zoranzoki21: Create new project User-Examknow - https://phabricator.wikimedia.org/T253419 (10Zoranzoki21) a:03Zoranzoki21 Sure, will do. [22:00:26] (03CR) 10Umherirrender: "I am okay with the changes" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [22:00:30] (03PS5) 10Umherirrender: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 [22:04:57] (03CR) 10jerkins-bot: [V: 04-1] Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [22:07:33] (03PS2) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 [22:07:42] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [22:08:32] (03PS6) 10Umherirrender: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 [22:08:38] (03CR) 10Umherirrender: "Fix after rebase" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [22:41:25] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10thcipriani) >>! In T252463#6159156, @CCicalese_WMF wrote:... [22:48:05] (03PS4) 10Jforrester: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [22:50:52] (03CR) 10Jforrester: "I've re-written this to be more in line with the "house style" (as seen in eslint-config, OOUI changelog, etc.), including adding sections" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [22:51:38] (03CR) 10DannyS712: Release v31.0.0 (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [22:54:16] (03CR) 10Jforrester: Release v31.0.0 (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [22:55:23] (03PS5) 10Jforrester: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [23:52:58] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) @Daimona @thiemowmde @Jdforrester-WMF Based on the discussion regarding how to handle `$GLOBALS`, would it make sense add a sniff to...