[02:34:13] (03CR) 10DannyS712: Release v31.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [02:48:41] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Krinkle) I'd recommend option 2 as well. Option 3 would b... [02:51:49] (03CR) 10Krinkle: Add a sniff for `$wg*` variables that aren't globals (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [02:54:27] (03CR) 10Krinkle: "One thing I'd recommend to rule out a big potential source of false negatives is to make sure it starts with wg[A-Z] so e.g. $wgae = 42; i" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [02:56:00] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10Krinkle) @thiemowmde This seems fine at glance. Do you have and/or could you gather some basic data to see whether this has existing violations... [03:32:20] (03PS10) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [03:32:28] (03CR) 10DannyS712: "> One thing I'd recommend to rule out a big potential source of false" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [03:32:30] (03PS11) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) [03:37:59] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) >>! In T251443#6159826, @Krinkle wrote: > @thiemowmde This seems fine at glance. Do you have and/or could you gather some basic data... [03:50:53] 10phan, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) [03:51:25] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) [03:53:37] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [08:01:27] 10Phabricator, 10Wikimedia-GitHub, 10User-Majavah: Automatically create task on Phabricator based on Issues from Github repositories - https://phabricator.wikimedia.org/T253388 (10Majavah) [09:46:41] (03CR) 10DannyS712: [C: 04-2] "Per task - why would this be needed?" [sandbox] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/585913 (https://phabricator.wikimedia.org/T249423) (owner: 10Zoranzoki21) [11:53:05] 10Beta-Cluster-Infrastructure, 10MediaWiki-Special-pages: Changing content model on meta beta impossible - https://phabricator.wikimedia.org/T253445 (10MGChecker) [12:08:16] 10Beta-Cluster-Infrastructure, 10MediaWiki-Special-pages: Changing content model on meta beta impossible - https://phabricator.wikimedia.org/T253445 (10Mainframe98) [12:45:44] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) >>! In T253322#6159404, @CCicalese_WMF wrote: > When I try to run phan locally, I get: > > > ` > AssertionError: record_variable_context_and_scope must be... [12:46:52] Beta seems broken (Cannot access the database: Cannot access the database: Unknown error (172.16.4.147:3306)) [12:49:13] (03CR) 10Daimona Eaytoy: [C: 04-1] "Restoring my previous CR which, to recap, is for line 9 that has to be adjusted a bit, and the issue message which should be changed to th" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [12:51:01] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Pywikibot post-merge job fails to start up - https://phabricator.wikimedia.org/T252310 (10Dvorapa) And again: https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/598157/ [12:53:54] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Reedy) >>! In T252463#6159823, @Krinkle wrote: > Option 3... [12:55:33] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10Daimona) >>! In T251443#6159733, @DannyS712 wrote: > @Daimona @thiemowmde @Jdforrester-WMF Based on the discussion regarding how to handle `$GL... [12:56:05] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Pywikibot: Jenkins can't merge patchsets sometimes - https://phabricator.wikimedia.org/T252310 (10Dvorapa) [13:03:08] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6160117, @Reedy wrote: > Bare minimum `.phan/config.php` probably wants to be: > > `lang=php > return require __DIR__ . '/../vendor/mediawi... [13:07:31] (03CR) 10Daimona Eaytoy: "> I've re-written this to be more in line with the "house style" (as" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [13:14:17] 10phan-taint-check-plugin, 10Upstream: Allow to print taint of variable when using taint-check plugin - https://phabricator.wikimedia.org/T252261 (10Daimona) This will be included in phan 3.0.1. I think I should implement a handler for `@phan-print-var-taintedness` or something like that. [13:16:18] 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check false positive due to propagating EXEC_ESCAPED from method call - https://phabricator.wikimedia.org/T216357 (10Daimona) 05Open→03Resolved a:03Bawolff [13:16:28] 10phan-taint-check-plugin: phan-taint-check false positive due to propagating EXEC_ESCAPED from method call - https://phabricator.wikimedia.org/T216357 (10Daimona) [13:19:05] 10phan-taint-check-plugin: Re-consider value of running phan-taint-check plugin against maintenance scripts - https://phabricator.wikimedia.org/T203340 (10Daimona) >>! In T203340#4551791, @Bawolff wrote: > Maybe another approach is to treat command line input as trusted in a CLI script. Hah, incidentally I did... [13:21:25] 10Continuous-Integration-Infrastructure, 10phan-taint-check-plugin, 10User-Daimona: mwext-php70-phan-seccheck-docker times out for CommonsMetadata extension - https://phabricator.wikimedia.org/T224351 (10Daimona) 05Open→03Resolved a:03Daimona Classes extending themselves are now "working as intended" i... [13:32:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Great you like it! Are you fine with merging this as it is?" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [13:48:07] 10Gerrit: Gerrit description errors meaning submodules get re-added - https://phabricator.wikimedia.org/T253450 (10Reedy) [13:51:48] 10Gerrit: Gerrit description errors meaning submodules get re-added - https://phabricator.wikimedia.org/T253450 (10Reedy) [13:54:54] 10Gerrit: Gerrit description errors meaning submodules get re-added - https://phabricator.wikimedia.org/T253450 (10Reedy) The problem is like this `lang=json "mediawiki/extensions/WikidataEntitySuggester": { "description": "[MIRROR] Mirror of https://github.com/nilesh-c/wikidata-entity-suggester",... [14:12:11] 10Gerrit, 10Patch-For-Review: Gerrit description errors meaning submodules get re-added - https://phabricator.wikimedia.org/T253450 (10Reedy) 05Open→03Resolved a:03Reedy [14:13:09] 10Gerrit: Make sync-with-gerrit.py remove directories - https://phabricator.wikimedia.org/T253451 (10Reedy) [14:20:18] 10Gerrit, 10Patch-For-Review: Make sync-with-gerrit.py remove directories - https://phabricator.wikimedia.org/T253451 (10Reedy) 05Open→03Resolved a:03Reedy [14:49:03] (03CR) 10Umherirrender: [C: 03+1] "Yes, merging is okay" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [15:18:23] (03PS1) 10Reedy: Relax composer/spdx-licenses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598171 [15:19:08] (03PS2) 10Reedy: Relax composer/spdx-licenses to ~1.5.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598171 [15:29:45] (03CR) 10Daimona Eaytoy: [C: 03+1] "I agree with the intent here." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598171 (owner: 10Reedy) [15:45:00] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [18:01:06] Reedy: is Security Team Fusion Center clinic meeting going ahead Monday? [18:01:14] See email to security-help [19:41:58] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) [20:36:09] RhinosF1: No, it's a holiday [20:59:34] Reedy: is the next week after then? [20:59:52] I don't know. It might be later in the week [21:05:17] Ok np [21:27:18] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) I do indeed have the correct contents in `.phan/config` and have confirmed that https://github.com/wikimedia/mediawiki-tools-phan/blob/edf21edb0efdff... [22:10:22] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) Hmmmm this is bad. Sounds like phan is violating the contract of getFileRef in the case with record_... enabled. I need to check where the bug is exactly,... [23:35:03] (03PS3) 10Krinkle: Enable PSR12.Functions.NullableTypeDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [23:35:44] (03CR) 10Krinkle: [C: 03+1] "@Thiemo can you add an example of that unfixable error? Didn't quite understand that one." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [23:37:12] (03CR) 10Krinkle: Fix use of const and function imports in unsorted statement sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [23:44:38] (03CR) 10Krinkle: [C: 03+1] Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (https://phabricator.wikimedia.org/T252948) (owner: 10Umherirrender) [23:57:08] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10Krinkle) The `array_push` construct is very rare in our code, and to my knowledge there is no preference or behavioural preference for it from anyone. Perhaps they are a left-over from a time... [23:58:05] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10Krinkle) p:05Triage→03Low [23:58:14] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for unneeded __construct functions - https://phabricator.wikimedia.org/T242402 (10Krinkle) p:05Triage→03Low