[01:36:40] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10tstarling) >>! In T242218#6160632, @Krinkle wrote: > The `array_push` construct is very rare in our code, and to my knowledge there is no preference or behavioural preference for it from anyon... [02:35:56] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) Is it worth Cindy trying an older version of the phan plugin etc? [05:36:57] (03PS1) 10DannyS712: Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 [05:38:16] (03PS2) 10DannyS712: Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 [08:39:10] (03CR) 10Umherirrender: "When there are comments than the sniff cannot autofix:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [08:43:49] (03CR) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [09:48:20] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6160642, @Reedy wrote: > Is it worth Cindy trying an older version of the phan plugin etc? It's possible. I think this might be due to an o... [11:36:35] 10phan-taint-check-plugin: taint-check does not analyze code with BagOStuff::getWithSetCallback correctly - https://phabricator.wikimedia.org/T253473 (10Umherirrender) [11:59:31] (03PS1) 10RhinosF1: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) [12:00:53] (03PS2) 10RhinosF1: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) [12:48:20] I forgot to mark https://gerrit.wikimedia.org/r/#/c/translatewiki/+/598232/ as ready for review, is there anyway to nudge jenkins to merge? [12:49:05] someone's merged [13:10:40] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:46:38] (03CR) 10MarcoAurelio: "Usually when archiving an extension we move it to a section at the bottom of the file and use the 'archived' template. Given that the repo" [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:49:37] hauskatze: the instructions says remove tests [13:49:48] RhinosF1: yeah, it's a bit of a mess [13:50:00] if you see at the bottom of the file there's a bunch of 'archived' ones [13:50:19] but on the other hand, I'm wondering if it is useful to keep increasing that list [13:54:47] Not sure [13:55:27] Yeah, me neither [13:55:38] For me it'd be easier to just remove the whole thing [14:00:53] What do the archived jobs actually do? [14:01:17] Reedy: makes jenkins fail with a custom message [14:01:36] Reedy: but repos are 'read only' so you'll not be able to submit a patch either [14:01:55] unless the repo is kept in 'active' state [14:02:16] I think most archived repos are being turned to 'read only'; I do that for all the ones I archive [14:04:13] SiteScout is also read only at this moment: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SiteScout [14:04:37] Why is the ‘create change’ button on the (old) UI not disabled for Read only repos? [14:05:13] No idea [14:05:19] It errors anyway [14:05:33] Perhaps to allow changes to refs/meta/config [14:05:46] It does, but it to not be greyed out seems weird to me. [14:05:55] Quite possibly [14:06:19] Nope, refs/meta/config not allowed either [14:06:40] Anyway, that UI is going away soon so I don't think I'd bother filing a ticket upstream [14:07:07] I still use the old UI [14:07:29] Me too [14:07:59] PolyGerrit does support creating and editting patches but I don't think our version of PolyGerrit allows us to do that yet [14:08:05] paladox may know [14:08:53] Ah [14:10:16] cfr. https://phab.wiki/200739 [14:14:52] You can create changes funnily enough in 2.15, but you have to use the old ui to edit! [14:15:17] Yup [14:15:39] Any rumours when our Gerrit will get the upgrade? [14:15:50] 10Project-Admins, 10User-Zoranzoki21: Create new project User-Examknow - https://phabricator.wikimedia.org/T253419 (10Zoranzoki21) 05Open→03Resolved Requested public project #user-examknow has been created: https://phabricator.wikimedia.org/project/view/4787/ Please encourage interested people to visit th... [14:15:55] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555 (10Zoranzoki21) [14:27:54] hauskatze: Dunno if you saw my patches yesterday, but yes, mark shit as readonly as you're doing so the sync script doesn't re-add them :P [14:28:57] Reedy: nope, saw nix; but I always mark the repos as read only AND mark them as archived in zuul - maybe we should stop doing the later unless there's a reason to continue doing so [14:29:13] oh, did you fix sync-with-gerrit? awesome [14:29:18] Yeah [14:29:27] Because [MIRROR] [READONLY] [ARCHIVED] [14:29:31] pint of bear for you [14:29:33] *beer [14:29:34] structured data is much better [14:29:35] lol [14:29:40] For the latter, you'd need to ask James or Antoine why we started doing that [14:29:49] yeah [14:29:53] I keep doing both [14:29:58] until they say otherwise [14:30:32] I think I used that script only once and it kept adding everything, archived and non-archived [14:30:46] glad to know it'll now work as expected [14:31:09] Well, GIGO obviously :) [14:31:45] I also made it delete repos from disk.. Though I'm not 100% sure if that works as expected [14:55:33] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) > Would everyone prefer if I leave that alone for now and alter this patch to in... [15:43:31] (03PS11) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [16:08:21] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) @Daimona, thank you! I was following the instructions at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_exte... [16:45:36] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) >>! In T253322#6160961, @CCicalese_WMF wrote: > The instructions for running phan should be updated to point to the version in vendor/bin. Do you agree? I'm... [16:46:54] 10phan-taint-check-plugin, 10MediaWiki-extensions-Translate, 10Security-Team, 10Patch-For-Review, and 3 others: SpecialLanguageStats.php fails phan tests due to possible XSS - https://phabricator.wikimedia.org/T253383 (10MarcoAurelio) [16:50:33] 10LibUp: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Reedy) [16:50:43] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Reedy) [17:01:40] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) The ` composer require --dev "mediawiki/mediawiki-phan-config: 0.10.2" ` installs phan as a dependency, so a separate require for phan is not neces... [17:11:59] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6160961, @CCicalese_WMF wrote: > @Daimona, thank you! I was following the instructions at https://www.mediawiki.org/wiki/Continuous_integrat... [17:16:40] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) >>! In T253322#6161010, @Daimona wrote: >>>! In T253322#6160961, @CCicalese_WMF wrote: >> But, since the mediawiki/mediawiki-phan-config requirement... [17:19:08] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) >>! In T253322#6160975, @Reedy wrote: > I'm partially wondering why we haven't put a "composer phan" type command into composer.json rather than peop... [17:26:38] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Daimona) For completeness, I believe that the command should be `vendor/bin/phan -d . --long-progress-bar` if the version of mediawiki-phan-config is >=0.9.0, and `vendor/bin/phan -d . -p` otherwise. [17:39:01] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) [18:14:18] Can someone double check SiteScout isn’t on https://doc.wikimedia.org/cover-extensions/? [18:14:53] it isn't based on a very quick ctrl+f [18:16:03] Good then, I can remove it from https://phabricator.wikimedia.org/T253452 [18:51:36] 10phan-taint-check-plugin: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Umherirrender) [19:30:48] 10phan-taint-check-plugin: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Umherirrender) A overview how often it is happen that a explict convert is missing: * * * * * * * * * * * * [22:43:51] Reedy heh https://integration.wikimedia.org/ci/job/scap-beta-deb/82/ has been running for 2 days [22:44:07] https://integration.wikimedia.org/ci/job/beta-publish-deb/ is waiting [22:44:15] oh [22:44:29] it failed now [22:44:39] (I killed the beta-publish-deb task) [22:44:50] thanks! [22:45:12] * Reedy tries a rebuild [22:47:15] looks broken [22:50:36] 17:57:35 ERROR: can't open database: open /srv/packages/db/LOG: permission denied [22:51:39] paladox: I note beta scap is broken too :) [22:51:46] heh [22:52:12] https://integration.wikimedia.org/ci/computer/deployment-deploy01/ is doing shit now though [22:52:18] lets see what fails [22:53:38] hopefully it's pass :) [22:54:29] rofl [22:54:31] look at https://integration.wikimedia.org/ci/job/beta-scap-eqiad/301662/ [22:54:36] Started by timer 427 times [22:55:08] heh [22:58:55] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10Krinkle) [23:00:36] (03CR) 10Krinkle: "CI failing at https://gerrit.wikimedia.org/r/#/c/operations/software/thumbor-plugins/+/597998/" [integration/config] - 10https://gerrit.wikimedia.org/r/597992 (owner: 10Gilles)