[01:11:29] (03CR) 10Krinkle: [C: 03+2] Relax composer/spdx-licenses to ~1.5.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598171 (owner: 10Reedy) [01:12:11] (03Merged) 10jenkins-bot: Relax composer/spdx-licenses to ~1.5.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598171 (owner: 10Reedy) [02:49:18] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) Pull request that adds phan and fixes all but one error: https://github.com/ProfessionalWiki/chameleon/pull/156. The remaining error is: ` src/Compo... [03:09:26] Project beta-scap-eqiad build #301687: 04FAILURE in 4 min 54 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/301687/ [03:18:06] Yippee, build fixed! [03:18:06] Project beta-scap-eqiad build #301688: 09FIXED in 3 min 36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/301688/ [03:53:38] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [07:02:02] Project beta-scap-eqiad build #301710: 04FAILURE in 7 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/301710/ [07:14:13] Yippee, build fixed! [07:14:13] Project beta-scap-eqiad build #301711: 09FIXED in 9 min 41 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/301711/ [07:24:01] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [07:33:59] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [07:52:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10hashar) [07:52:22] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Evaluate if we still need our local fork of the jenkins xunit-plugin - https://phabricator.wikimedia.org/T253337 (10hashar) [07:54:34] (03CR) 10DannyS712: [C: 03+2] Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (https://phabricator.wikimedia.org/T252948) (owner: 10Umherirrender) [07:55:15] (03Merged) 10jenkins-bot: Enable PSR12.Traits.UseDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596771 (https://phabricator.wikimedia.org/T252948) (owner: 10Umherirrender) [07:57:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "The sniff will report any invalid token as well, using the same error message. Examples:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [08:06:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [08:06:39] (03Merged) 10jenkins-bot: Fix unnecessary use statement detection for const in same namespace [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596765 (owner: 10Umherirrender) [08:07:11] 10MediaWiki-Codesniffer: Codesniffer should check the whitespace in use statements for traits - https://phabricator.wikimedia.org/T252948 (10DannyS712) [08:07:45] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) >>! In T253313#6160935, @kostajh wrote: >> Would everyone prefer if I leave tha... [08:11:42] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) > I guess the plan would then be to have some commands other than docker at some... [08:18:38] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10thiemowmde) I'm sorry, but I don't see what we win by disallowing //some// usages of `array_push`, while still allowing others. What's the benefit? It's not like array_push is particularly con... [08:54:10] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10thiemowmde) I would like to veto the idea of allowing the silencing operator again. For a single reason: The `@` prefix is probably the most ugly syntax we have in P... [09:12:26] (03Abandoned) 10Hashar: Add trusted volunteer and tox to thumbor-plugins [integration/config] - 10https://gerrit.wikimedia.org/r/597992 (owner: 10Gilles) [09:24:31] 10Phabricator, 10Wikipedia-Android-App-Backlog: Add project descriptions to Android App Phab projects which have no project description - https://phabricator.wikimedia.org/T253516 (10Aklapper) [09:28:03] 10Continuous-Integration-Infrastructure: Consider if CI images should use Wikimedia production ffmpeg version - https://phabricator.wikimedia.org/T253328 (10hashar) 05Open→03Declined The wmf version debian.tar.xz can be fetched from https://apt.wikimedia.org/wikimedia/pool/component/vp9/f/ffmpeg/ and its cha... [09:52:54] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10Daimona) I can't remember what exactly lead me to open this task, but I don't feel very strongly about this right now. I didn't think about the parallel with array_pop, so thank you for bringi... [09:58:51] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Daimona) One concern I have is that this could potentially be abused. There are cases where using the @ operator is almost the "standard way"™ to do things, e.g. fil... [10:20:55] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Daimona) >>! In T253322#6161361, @CCicalese_WMF wrote: > Pull request that adds phan and fixes all but one error: https://github.com/ProfessionalWiki/chameleon/pull... [10:43:39] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10MaxSem) >>! In T253461#6162104, @Daimona wrote: > However, I fear that if we remove the PHPCS rule, people may start using the operator even when unnecessary, e.g. w... [10:47:42] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10DannyS712) >>! In T253461#6162294, @MaxSem wrote: >>>! In T253461#6162104, @Daimona wrote: >> However, I fear that if we remove the PHPCS rule, people may start usin... [10:56:40] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Demian) >>! In T253461#6162104, @Daimona wrote: > people may start using the operator even when unnecessary, e.g. when accessing array offsets... On a tangent: the ?... [10:59:26] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Daimona) >>! In T253461#6162294, @MaxSem wrote: >>>! In T253461#6162104, @Daimona wrote: >> However, I fear that if we remove the PHPCS rule, people may start using... [11:07:00] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Tgr) [11:13:06] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Mainframe98) Just throwing this idea out here: the default service wiring is set in `$wgServiceWirin... [11:20:07] Project beta-update-databases-eqiad build #42400: 04FAILURE in 6.4 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42400/ [11:46:11] Cannot change session name when headers already sent in /srv/mediawiki-staging/wmf-config/CommonSettings.php [11:47:01] and/or [11:47:04] .RuntimeException from line 4764 of /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php: Could not open "/srv/mediawiki-staging/php-master/maintenance/archives/patch-l10n_cache-lc_lang-35.sql [12:20:06] Project beta-update-databases-eqiad build #42401: 04STILL FAILING in 5.4 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42401/ [12:56:28] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Tgr) Yeah, that came up as an option (this task is the continuation of discussions from [[https://ge... [12:57:49] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10thiemowmde) As argued on Gerrit I'm convinced this sniff should report **all** `$wg…` variables that have not been declared via a `global $wg…`... [13:07:30] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) Thank you so much for the analysis and advice, @Daimona! [13:20:07] Project beta-update-databases-eqiad build #42402: 04STILL FAILING in 6.7 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42402/ [13:49:23] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 3 others: Update Doxygen in CI to 1.8.17 or greater - https://phabricator.wikimedia.org/T242155 (10Joe) The package has been uploaded. [13:51:34] (03PS1) 10Hashar: dockerfiles: rebuild for doxygen 1.8.17 [integration/config] - 10https://gerrit.wikimedia.org/r/598483 (https://phabricator.wikimedia.org/T242155) [13:56:02] (03CR) 10Hashar: [C: 03+2] dockerfiles: rebuild for doxygen 1.8.17 [integration/config] - 10https://gerrit.wikimedia.org/r/598483 (https://phabricator.wikimedia.org/T242155) (owner: 10Hashar) [13:57:01] (03Merged) 10jenkins-bot: dockerfiles: rebuild for doxygen 1.8.17 [integration/config] - 10https://gerrit.wikimedia.org/r/598483 (https://phabricator.wikimedia.org/T242155) (owner: 10Hashar) [13:57:03] 10Release-Engineering-Team (CI & Testing services), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: install playwright dependencies in the CI - https://phabricator.wikimedia.org/T250599 (10zeljkofilipin) a:05hashar→03None [14:09:02] (03PS1) 10Hashar: jjb: switch jobs to use doxygen 1.8.17 [integration/config] - 10https://gerrit.wikimedia.org/r/598489 (https://phabricator.wikimedia.org/T242155) [14:09:14] (03CR) 10Hashar: [C: 03+2] "Jobs updated" [integration/config] - 10https://gerrit.wikimedia.org/r/598489 (https://phabricator.wikimedia.org/T242155) (owner: 10Hashar) [14:09:20] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 3 others: Update Doxygen in CI to 1.8.17 or greater - https://phabricator.wikimedia.org/T242155 (10hashar) 05Open→03Resolved I have updated a... [14:09:25] 10phan, 10doxygen, 10Documentation, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), and 2 others: Doxygen: Ignore `@phan` notation (and more) - https://phabricator.wikimedia.org/T241182 (10hashar) [14:09:53] (03Merged) 10jenkins-bot: jjb: switch jobs to use doxygen 1.8.17 [integration/config] - 10https://gerrit.wikimedia.org/r/598489 (https://phabricator.wikimedia.org/T242155) (owner: 10Hashar) [14:21:32] !log Built image releng/doxygen:0.7.0 for Doxygen 1.8.17 # T242155 [14:21:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:21:36] T242155: Update Doxygen in CI to 1.8.17 or greater - https://phabricator.wikimedia.org/T242155 [14:25:26] Yippee, build fixed! [14:25:26] Project beta-update-databases-eqiad build #42403: 09FIXED in 5 min 25 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42403/ [14:49:25] (03PS1) 10Jcrespo: Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) [14:50:24] (03CR) 10jerkins-bot: [V: 04-1] Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [14:51:49] (03CR) 10Jcrespo: "I am not very familiar with how CI is configured and https://www.mediawiki.org/wiki/Continuous_integration/Documentation_generation is qui" [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [14:58:18] (03PS2) 10Jcrespo: Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) [14:59:16] (03CR) 10jerkins-bot: [V: 04-1] Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [15:00:58] (03CR) 10Hashar: Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [15:10:09] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Operations, 10Epic, 10Performance Issue: [EPIC] Performance testing environment - https://phabricator.wikimedia.org/T67394 (10Aklapper) 05Stalled→03Open The previous comments don't explain what/who exactly this task is stalled on (["If a... [15:10:11] 10Continuous-Integration-Infrastructure, 10Performance Issue: Add a voting YSlow job to Jenkins - https://phabricator.wikimedia.org/T59137 (10Aklapper) [15:11:16] (03CR) 10Hashar: Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [15:20:30] (03PS3) 10Jcrespo: Schedule publishing sphinx documentation for wmfmariadbpy/transfer.py [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) [15:24:25] 10Phabricator, 10Developer-Advocacy, 10Epic: (Semi)automatically close Phabricator tickets with status "stalled" after a while - https://phabricator.wikimedia.org/T252522 (10Aklapper) [15:27:35] (03CR) 10Jcrespo: [C: 04-1] "Aside from Hashar's ok (we should ask ourselves if we want to rebuild docs for every merge or only for each release), this should be block" [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [15:33:15] 10Project-Admins: Replace tracking bug T18456 by new project tag "GIF" - https://phabricator.wikimedia.org/T102501 (10Aklapper) 05Stalled→03Declined I'm going to boldly decline this as no use case has been provided. Plus I'm proposing to close T18456 as invalid. We don't want categorization purely for the s... [15:33:17] 10Project-Admins, 10Epic: Replace all "tracking" tasks with tags/projects (if unbounded), relabel them to outcome tasks (if bounded), or kill them entirely (if pointless) - https://phabricator.wikimedia.org/T192655 (10Aklapper) [16:36:48] 10Phabricator, 10Developer-Advocacy, 10Epic: (Semi)automatically close Phabricator tickets with status "stalled" after a while - https://phabricator.wikimedia.org/T252522 (10Krinkle) I'm slightly fearful of this because I believe for so many projects, the automatic closure would likely not be seen by anyone... [16:39:55] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Tgr) The common concern about `@` is that it encourages misuse because it seems very lightweight but it's actually not cheap (it changes php.ini settings dynamically... [16:41:46] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Tgr) [16:55:57] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) @Tgr I think that would be a good compromise yeah, perhaps even better than we have today as doing it for the sniff is more explicily in the mental context... [16:58:19] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Krinkle) > Some services need to be mocked for browser tests (e.g. because they give nondeterministi... [17:10:08] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Krinkle) >>! In T252463#6160120, @Reedy wrote: >>>! In T2... [17:10:18] 10MediaWiki-Codesniffer: Codesniffer should check the whitespace in use statements for traits - https://phabricator.wikimedia.org/T252948 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium a:03Umherirrender [17:31:58] 10Continuous-Integration-Config, 10MediaWiki-ServiceContainer, 10Dependency injection: Establish a standard way of overriding service wiring for end-to-end tests - https://phabricator.wikimedia.org/T253541 (10Tgr) GrowthExperiments has a recommendation API where result ordering is intentionally randomized. I... [18:01:26] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10MarcoAurelio) I am not sure if this is really a blocker but perhaps train should not "depart" before ensuring that the updateCollation sc... [18:29:17] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic: Caching of https://doc.wikimedia.org/cover/mediawiki-libs-IPUtils/IPUtils.php.html is inconsistent - https://phabricator.wikimedia.org/T252131 (10hashar) doc.wikimedia.org is mostly static files. In the Apache config there is: ` # Lower ca... [18:33:37] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Fix partitions on CI slaves , some are missing /var/lib/docker - https://phabricator.wikimedia.org/T221040 (10hashar) 05Resolved→03Open It is a race condition / improper order som... [18:33:52] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Fix partitions on CI slaves , some are missing /var/lib/docker - https://phabricator.wikimedia.org/T221040 (10hashar) a:05hashar→03None [19:05:46] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic: Caching of https://doc.wikimedia.org/cover/mediawiki-libs-IPUtils/IPUtils.php.html is inconsistent - https://phabricator.wikimedia.org/T252131 (10Krinkle) Did the inconsistency last for over an hour? If not, I think this is expected given muti... [19:34:05] (03CR) 10Hashar: "I would like to revisit the code that got merged recently and maybe just refactor all of it depending on the visit. I haven't caught yet " [integration/quibble] - 10https://gerrit.wikimedia.org/r/594791 (https://phabricator.wikimedia.org/T211702) (owner: 10Awight) [22:24:59] 10VPS-project-codesearch: Add ShoutHow to Codesearch - https://phabricator.wikimedia.org/T253597 (10Krinkle) [22:26:01] 10VPS-project-codesearch: Add ShoutHow to Codesearch - https://phabricator.wikimedia.org/T253597 (10Krinkle) If we don't like seeing results of MW core files itself, I suppose we could add stuff like `includes/` etc to the ignore pattern for that repo. [22:26:57] 10VPS-project-codesearch: Add ShoutHow to Codesearch - https://phabricator.wikimedia.org/T253597 (10Krinkle) [22:53:13] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10hoo) I can see @thiemowmde's concerns, but I also see the trouble with using at-ease. As a compromise, it might be worthwhile changing at-ease to follow a more funct... [22:54:58] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) 05Open→03Resolved p:05Triage→03Medium a:03CCicalese_WMF [22:57:17] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) See https://github.com/ProfessionalWiki/chameleon/pull/156 and https://github.com/ProfessionalW... [23:02:24] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) I just pushed the commits to gerrit, and then rechecked my patch... https://integration.wikimedia.org/... [23:04:34] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team): Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) I guesss I need to add a phan dependancy. Patch incoming [23:05:35] (03PS1) 10Reedy: Add Bootstrap as Chameleon phan dependancy [integration/config] - 10https://gerrit.wikimedia.org/r/598547 (https://phabricator.wikimedia.org/T253322) [23:05:55] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) >>! In T253461#6161850, @thiemowmde wrote: > It says what it does. You don't need to know much about PHP to understand it. This cuts both ways. In general,... [23:06:38] (03CR) 10Reedy: [C: 03+2] Add Bootstrap as Chameleon phan dependancy [integration/config] - 10https://gerrit.wikimedia.org/r/598547 (https://phabricator.wikimedia.org/T253322) (owner: 10Reedy) [23:07:27] (03Merged) 10jenkins-bot: Add Bootstrap as Chameleon phan dependancy [integration/config] - 10https://gerrit.wikimedia.org/r/598547 (https://phabricator.wikimedia.org/T253322) (owner: 10Reedy) [23:08:05] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/598547 [23:08:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:13:02] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) @CCicalese_WMF I think you missed an extra '..' ` 00:09:09 WARNING: Caught excep... [23:18:14] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) Ah, thanks for catching that! (My tests were with MW_INSTALL_PATH set, si... [23:18:37] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Tgr) >>! In T253461#6163975, @hoo wrote: > As a compromise, it might be worthwhile changing at-ease to follow a more functional style There's `AtEase::qiuetCall`. O... [23:19:17] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) I haven't made a PR, but I can. Not fussed either way :) [23:20:09] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) If you create it, I'll merge it :-) [23:23:12] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) >>! In T253322#6164007, @CCicalese_WMF wrote: > If you create it, I'll merge it :... [23:29:17] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10CCicalese_WMF) Merged! [23:35:46] 10phan, 10phan-taint-check-plugin, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable Phan on Chameleon Skin - https://phabricator.wikimedia.org/T253322 (10Reedy) Sweet. https://integration.wikimedia.org/ci/job/mwskin-php72-phan-docker/5479/con...