[01:46:03] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10tstarling) > As of PHP 7, fatal errors and stack traces are no longer hidden by the @ operator. (Example: https://3v4l.org/t8i9q). The PHP manual still says that fa... [03:20:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10tstarling) [06:40:53] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10thiemowmde) > […] PHP is better understood, documented, and known to contributors than obscure things MW invents. How is code that says "suppress warnings" obscure?... [06:54:24] 10Phabricator, 10User-LokalProfil, 10WMSE (IT): Move subproject into a user project - https://phabricator.wikimedia.org/T240710 (10Lokal_Profil) @mmodell Have you got any updates on this task? [06:56:42] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10tstarling) >>! In T253461#6164288, @thiemowmde wrote: >> The issues with AtEase […] are real and significant. > > I never said these issues are not real. My point... [07:44:43] 10Continuous-Integration-Config, 10Operations, 10serviceops: docker-reporter-releng-images failed on deneb - https://phabricator.wikimedia.org/T251918 (10ayounsi) ACKing the alert https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=deneb&service=Check+systemd+state with this task. ` ayounsi@d... [08:07:27] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) >>! In T253313#6161708, @kostajh wrote: >> I guess the plan would then be to ha... [08:12:36] 10Phabricator (Upstream), 10Upstream: Update Phabricator OAuth scopes in documentation - https://phabricator.wikimedia.org/T185447 (10Aklapper) Hmm, might be worth to bring this up in https://discourse.phabricator-community.org/ then, I guess. :-/ [08:12:52] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) > Would you want to keep the cli being able to interact directly with the thiner... [08:15:46] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10Addshore) >>! In T253313#6164456, @kostajh wrote: >> Would you want to keep the cli being... [09:04:01] Who's conducting the MW train today, please? [09:04:08] James_F or twentyafterfour ? [09:05:44] one of those 2, but it's between 2 and 5 am in America now [09:06:31] first there will be the European train [09:06:45] you can see it on https://wikitech.wikimedia.org/wiki/Deployments#Tuesday,_May_26 [09:12:51] Yeah, that one [09:13:00] I got confused by the blocker ticket [09:13:40] hashar then; please note https://phabricator.wikimedia.org/T253022#6163601 just in case that's a blocker [09:13:59] Danke Herr mutante [09:15:02] (03CR) 10Hashar: [C: 04-1] "> Would you be able to assist with the above? In what timeframe? How much effort you reckon would it be?" [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [09:15:26] Ciao Daimona [09:15:33] Hola! [09:16:44] hauskatze: sounds like that nnwiki config change / update collaction is not a train blocker is it ? [09:17:13] hashar: updateCollation usually takes a bit. Is it okay to ride the train while a maintenance script is running? [09:17:25] maybe not ;D [09:17:28] I don't know, that's why I asked, for precaution [09:17:34] then for nnwiki it is probably going to be super fast [09:17:41] anyway, it's not like nnwiki is super big [09:17:58] not sure if 'super' but should not take a week ;-) [09:18:33] ;))) [09:18:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10hashar) @MarcoAurelio reasoning is that we should avoid running long term maintenance script while updating the train and that updateColl... [09:18:45] but I am not going to run it today, I have too many things to do [09:19:02] nono, it's part of SWAT [09:19:03] and this afternoon I will check the last blockers to 1.35.0-wmf.32 and try to push it to rest of wikis [09:19:18] updateCollation is most probably going to be fast [09:19:31] unless nnwiki ended up writing millions of articles / categories over night [09:19:33] ;) [09:19:42] I just wanted to make sure nothing is broken [09:19:45] I am not too worried, but that is indeed worth raising the point [09:19:47] Hope you understand [09:19:49] yeah +1 [09:19:57] Parfait [09:20:00] I would rather have people asking whether it is safe [09:20:09] rather thatn blindly try potentially unsafe things ;D [09:21:06] that was my thinking [09:43:28] (03PS2) 10Hashar: dockerfiles: image for logstash-filter-verifier [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [09:43:30] (03PS1) 10Hashar: Job to run logstash-filter-verifier on puppet.git [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) [09:45:54] (03CR) 10Hashar: "I originally tried to run the logstash-filter-verifier command directly but that caused troubles when passing 'filter-*.conf' to it. The " (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [09:47:19] (03CR) 10Hashar: "Forgot to paste my output of running the example-run.sh script:" [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [09:48:00] be back this afternoon [09:57:33] 10MediaWiki-Codesniffer: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10Daimona) [10:13:53] 10MediaWiki-Codesniffer: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) Some current assertions that would be warned about: https://codesearch.wmflabs.org/search/?q=assert(Not)%3F(True%7CFalse)%5C(%20strpos%5C(&i=nop... [11:12:33] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10daniel) [12:12:56] godog: buongiorno, this morning I have polished the CI change to run logstash-filter-verifier using a standalone container [12:13:05] I am willing to deploy it ;D [12:13:28] and eventually I thought that maybe those docker images might be better defined directly into puppet.git but I digress [12:14:45] hashar: buongiorno! oh sweet, thank you! yeah having the image deployed would be great, what changes (if any) do I need to make on the puppet side ? [12:15:10] well not much [12:15:29] so I made the job to only trigger when a change touches a file that matches */logstash/* [12:15:48] and it just shells out to run make in profiles/logstash/files/ [12:16:09] though until your change get merged, that means that any change touching a logstash file would fail due to lack of a makefile [12:16:24] (side effect: I guess we can use the same mecanism for mtail as well) [12:16:54] tldr: it works for me locally ;D [12:19:02] hashar: awesome! yeah that logic sounds good me (*/logstash/* -> run make) [12:19:18] LMK when deployed and I can merge my change and we can test [12:19:24] it is not very robust though and might trigger the job for some other reasons [12:19:28] but probably good enough [12:20:22] yeah good enough to start I think, we can probably restrict the path if it misfires [12:21:14] cool, I am going to build the container and deploy the jenkins job and zuul config [12:21:19] sorry it took that long [12:21:26] my work schedule is super erratic :/ [12:21:27] (03PS3) 10Hashar: dockerfiles: image for logstash-filter-verifier [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [12:21:29] (03PS2) 10Hashar: Job to run logstash-filter-verifier on puppet.git [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) [12:22:37] (03CR) 10Hashar: [C: 03+2] "Talked with Filippo about it, sounds good enough for a first iteration. We can surely use the same system for mtail and eventually later m" [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [12:22:45] * hashar presses buttons [12:23:28] (03Merged) 10jenkins-bot: dockerfiles: image for logstash-filter-verifier [integration/config] - 10https://gerrit.wikimedia.org/r/597227 (https://phabricator.wikimedia.org/T251869) (owner: 10Filippo Giunchedi) [12:24:44] hashar: no worries! thanks for working on it, appreciate it [12:25:17] one evil side effect is that 'rake test' would not run that test suite [12:25:30] and one would have to learn to run make from that profile/files/logstash directory [12:25:37] then [12:25:47] there is a utils/run_ci_locally.sh which use a docker container to run "rake test" [12:26:00] maybe the make command could have an extra target to use the same container ci is running [12:26:12] but well I might obsess too much [12:26:48] !log Built docker-registry.discovery.wmnet/releng/logstash-filter-verifier:0.0.1 # T251869 [12:26:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:26:50] T251869: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 [12:27:06] yeah that's true utils/run_ci_locally.sh doesn't know about the multiple containers now [12:27:27] we'll have to teach it about them eventually as we break things into their own containers [12:31:42] (03CR) 10Filippo Giunchedi: "LGTM, see comment on restricting to logstash profile only" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) (owner: 10Hashar) [12:37:04] godog: and it ran !! https://integration.wikimedia.org/ci/job/operations-puppet-logstash-filter-verifier/2/console [12:37:38] (03PS3) 10Hashar: Job to run logstash-filter-verifier on puppet.git [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) [12:37:41] (03CR) 10Hashar: Job to run logstash-filter-verifier on puppet.git (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) (owner: 10Hashar) [12:38:33] godog: if you can +1 the update at https://gerrit.wikimedia.org/r/#/c/integration/config/+/598703/2..3/zuul/layout.yaml , I will then deploy the zuul change and we can 'recheck' your puppet patch [12:38:50] (03CR) 10Filippo Giunchedi: [C: 03+1] "LGTM!" [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) (owner: 10Hashar) [12:38:54] ;D [12:38:54] hashar: very nice! LGTM [12:39:11] if only we were all next to each other, those things would be achieved ten time faster hehe [12:39:16] (03CR) 10Hashar: [C: 03+2] Job to run logstash-filter-verifier on puppet.git [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) (owner: 10Hashar) [12:40:09] (03Merged) 10jenkins-bot: Job to run logstash-filter-verifier on puppet.git [integration/config] - 10https://gerrit.wikimedia.org/r/598703 (https://phabricator.wikimedia.org/T251869) (owner: 10Hashar) [12:41:38] 10MediaWiki-Codesniffer: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10thiemowmde) More examples: `lang=php $this->assertIsInt( strpos( … ) ); $this->assertFalse( strstr( … ) ); $this->assertTrue( strstr( … ) === false ); $thi... [12:52:05] hashar: sweet, so I'm ok to merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/594460 now if I understand correctly [12:52:19] yeah sounds good [12:52:28] I have left two nitpicking notes that can be disregarded :] [12:53:58] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Addshore) [12:54:11] 2020/05/26 12:53:32 Logstash path candidate rejected: stat /opt/logstash/bin/logstash: no such file or directory [12:54:12] 2020/05/26 12:53:32 Logstash path candidate accepted: /usr/share/logstash/bin/logstash [12:54:12] hehe [12:54:58] oh ok, yeah I'll change as suggested [12:55:21] yeah the 40s likely it is logstash boot time [12:55:53] yeah :( [12:56:02] ran it with bunch of debug statement enabler: logstash-filter-verifier --loglevel=DEBUG --logstash-output --sockets tests/ filter-*.conf [12:56:10] and it waits on starting logstash indeed [12:57:19] I am super happy to see a testing suite for the logstash rules [12:57:36] maybe folks will be less intimidated in adding new rules and it will surely make it way easier to approve any changes made to them [12:57:38] \o/ [12:58:05] yeah me too! potentially introducing regressions at every change was making my eye twitch [13:03:17] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-Logstash, 10observability, and 2 others: Regression test for Logstash filters - https://phabricator.wikimedia.org/T251869 (10fgiunchedi) [13:06:14] 10MediaWiki-Codesniffer: Sniff to find incorrectly cases classes and function calls - https://phabricator.wikimedia.org/T253625 (10Reedy) [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:39:25] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) No new errors occurring so far \o/ We still got hit by the INSERT rate doubling (T247028) but that is not related to the code be... [14:08:33] 10MediaWiki-Codesniffer, 10Wikidata: LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4 - https://phabricator.wikimedia.org/T253633 (10Addshore) [14:08:39] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore: LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4 - https://phabricator.wikimedia.org/T253633 (10Addshore) a:03Addshore [14:10:54] (03PS1) 10Addshore: LowerCamelFunctionsNameSniff, add __serialize and __unserialize [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598745 (https://phabricator.wikimedia.org/T253633) [14:12:16] 10MediaWiki-Codesniffer, 10Wikidata, 10PHP 7.4 support, 10Patch-For-Review, 10User-Addshore: LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4 - https://phabricator.wikimedia.org/T253633 (10Addshore) [14:14:09] 10Release-Engineering-Team, 10Operations, 10SRE-tools: Support running puppet Beaker on CI - https://phabricator.wikimedia.org/T253635 (10hashar) [14:20:08] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Addshore) An example of how the extra level of indirection creates overhead will be seen in DataModel soon, where: - T253633 will be fixed in mediawiki-codesniffer - A new version o... [14:22:32] (03CR) 10DC Slagel: "Hi Dduvall, Zoranzoki21," [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [14:26:05] (03CR) 10Lars Wirzenius: "Going to make another patch set soon." (038 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [14:32:26] (03CR) 10MaxSem: [C: 03+2] LowerCamelFunctionsNameSniff, add __serialize and __unserialize [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598745 (https://phabricator.wikimedia.org/T253633) (owner: 10Addshore) [14:33:14] (03Merged) 10jenkins-bot: LowerCamelFunctionsNameSniff, add __serialize and __unserialize [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598745 (https://phabricator.wikimedia.org/T253633) (owner: 10Addshore) [14:34:17] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Addshore) [14:42:08] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Mock up the mediawiki-docker-dev "mwdd" v1 cli in go - https://phabricator.wikimedia.org/T253313 (10kostajh) > We should also confirm if, for example, 2.2 files work with 2.3 too, or even... [15:20:45] 10Scap: Scap sync and sync-file are too similar looking yet do very different things - https://phabricator.wikimedia.org/T174369 (10MaxSem) [15:20:48] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10MaxSem) [15:24:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Motivated by https://github.com/wmde/WikibaseDataModel/pull/824#discussion_r430443073. Thanks for the quick fix!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598745 (https://phabricator.wikimedia.org/T253633) (owner: 10Addshore) [15:33:31] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.32 deployment blockers - https://phabricator.wikimedia.org/T249964 (10hashar) 05Open→03Resolved There is barely any new errors. There is a regression with Vector that causes some features to be missing... [15:38:50] 10MediaWiki-Codesniffer, 10phan: Check to find incorrectly cased php classes and function calls - https://phabricator.wikimedia.org/T253625 (10Reedy) [15:39:47] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Ladsgroup) I honestly think we should just drop wikibase codesniffer. We have been maintaining too much codebase. [15:40:19] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10sbassett) On rare occasions, the #security-team has run `scap sync` to get various security patches depl... [15:42:18] 10MediaWiki-Codesniffer, 10phan: Check to find incorrectly cased php classes and function calls - https://phabricator.wikimedia.org/T253625 (10Krinkle) Upstream: * * [15:53:04] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Krinkle) Note that `.phpcs` is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also possible to... [15:58:17] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Jdforrester-WMF) [16:00:21] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Ladsgroup) >>! In T253624#6165674, @Krinkle wrote: > Note that `phpcs` ruleset is controllable per repository. The same way that we disable some rules in repositories not yet ready to... [16:01:45] (03PS4) 10Lars Wirzenius: feat: add scap apply-patch for security patches during train [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 [16:06:17] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review: Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10LarsWirzenius) @hashar, if "scap sync-all" is actually important, we can add that an alias, but I'd rath... [16:12:12] hello! I'm seeing issues running puppet on a few hosts I have in deployment-prep: "Failed to find facts from PuppetDB", looks like the master is having trouble talking to pdb [16:18:49] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10EngProd-Virtual-Hackathon, 10Patch-For-Review, 10Sustainability (Incident Prevention): Rename `scap sync` to `scap sync-world` - https://phabricator.wikimedia.org/T250302 (10Krinkle) [16:39:40] hnowlan: if you're still having trouble, you might want to try #wikimedia-cloud as well [16:40:08] cdanis: ah, cool. thanks! [16:51:19] 10Phabricator: Develop a custom herald condition for maniphest tasks: "projects include any subprojects of ___ " - https://phabricator.wikimedia.org/T144041 (10MBinder_WMF) Bumping to give this some love again, after spending a few weeks with @Aklapper on the Phab Help talk page: https://www.mediawiki.org/w/inde... [17:11:59] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Format Scap source code with black - https://phabricator.wikimedia.org/T252399 (10LarsWirzenius) Did a quick try: black formats the code just fine, but flake8 is unhappy with the result. I think this reformatting will need to wait until we por... [17:37:56] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) [17:43:46] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release Pipeline (Blubber): Blubber policy should be verified after expansion - https://phabricator.wikimedia.org/T248927 (10dduvall) a:05dduvall→03None [17:44:04] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: train-deploy-notes Jenkins job fails in conjunction with branch.py - https://phabricator.wikimedia.org/T243330 (10dduvall) a:05dduvall→03None [18:01:29] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Jdforrester-WMF) [18:20:14] (03CR) 10Gilles: "This only has a commit message?" [performance/debs/prometheus-ebpf-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/597660 (owner: 10Dave Pifke) [18:22:23] (03CR) 10Dave Pifke: [C: 04-2] "This was a remnant of my troubleshooting repository setup (permissions changes were silently failing). Not needed." [performance/debs/prometheus-ebpf-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/597660 (owner: 10Dave Pifke) [18:22:27] (03Abandoned) 10Dave Pifke: Edit Project Config [performance/debs/prometheus-ebpf-exporter] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/597660 (owner: 10Dave Pifke) [18:29:43] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10Sustainability (Incident Followup): Make scap skip restarting php-fpm when using --force - https://phabricator.wikimedia.org/T243009 (10Krinkle) [18:29:58] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team, 10Patch-For-Review: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) [18:30:15] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) 05Open→03Stalled [18:30:22] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) [18:33:13] Where should I create a request to rename a Gerrit repo? [18:34:28] kalle: We don't really rename them... [18:37:41] In fact I don't think they can be renamed in our install [18:37:47] We just create another one [18:38:19] I think there was a plugin to rename a repo but we don't use it [18:38:41] I think it's partially related to our old gerrit version [18:38:50] aye [18:49:13] Ah OK, I'll just request a new one that forks the old then :D [18:49:14] Thanks [19:00:12] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-ShortUrl, 10Code-Stewardship-Reviews: Code Stewardship Review: ShortUrl Extension - https://phabricator.wikimedia.org/T187045 (10Jdlrobson) Note: The lack of stewardship is delaying the desktop improvements project, which has a code review requ... [19:00:48] (03CR) 10Jforrester: [C: 03+2] Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [19:06:34] (03PS6) 10Jforrester: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [19:06:58] (03PS7) 10Jforrester: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [19:08:54] (03CR) 10Jforrester: [C: 03+2] Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [19:11:14] (03Merged) 10jenkins-bot: Release v31.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/598011 (owner: 10Daimona Eaytoy) [19:23:33] (03PS4) 10Umherirrender: Enable PSR12.Functions.NullableTypeDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) [19:23:41] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596772 (https://phabricator.wikimedia.org/T252947) (owner: 10Umherirrender) [19:26:44] (03PS5) 10Umherirrender: UnusedGlobalVariablesSniff should work with closures [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593641 [19:33:44] (03PS3) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 [19:34:22] (03CR) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [19:38:56] 10MediaWiki-Codesniffer, 10Wikidata, 10PHP 7.4 support, 10Patch-For-Review, 10User-Addshore: LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4 - https://phabricator.wikimedia.org/T253633 (10Umherirrender) 05Open→03Resolved [19:42:01] 10MediaWiki-Codesniffer, 10phan: Check to find incorrectly cased php classes and function calls - https://phabricator.wikimedia.org/T253625 (10Umherirrender) Sounds more like a job for phan as phan is knowing the type of the variable and all possible functions available. Lowercase classes are covered by media... [19:53:13] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for method operator followed by newline - https://phabricator.wikimedia.org/T253187 (10Umherirrender) Upstream has two sniffs working with `->` * `Squiz.WhiteSpace.ObjectOperatorSpacing` => already in ruleset.xml * `PEAR.WhiteSpace.ObjectOperatorIndent` =... [19:53:44] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10CCicalese_WMF) So, it sounds like we're converging on: >... [20:27:45] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10Reedy) Are we planning on following master? Or a specific... [20:35:35] 10Beta-Cluster-Infrastructure, 10VPS-project-codesearch, 10MediaWiki-extensions-PerformanceInspector, 10Performance-Team: Undeploy PerformanceInspector from Beta Cluster - https://phabricator.wikimedia.org/T253689 (10Krinkle) [20:53:04] 10MediaWiki-Codesniffer, 10phan: Check to find incorrectly cased php classes and function calls - https://phabricator.wikimedia.org/T253625 (10Reedy) >>! In T253625#6166682, @Umherirrender wrote: > Lowercase classes are covered by mediawiki itself, because tests running without the global set (but that would n... [21:20:33] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10thcipriani) p:05Triage→03Medium a:03Jdforrester-WMF [21:34:12] hi. I wonder if I am missing something or if CI is broken: https://integration.wikimedia.org/ci/job/operations-puppet-tests-buster-docker/3558/console [21:34:21] 17:32:08 + mv '/srv/workspace/puppet/.tox/log/*' /srv/workspace/log/17:32:08 mv: cannot stat '/srv/workspace/puppet/.tox/log/*': No such file or directory [21:41:49] 10MediaWiki-Codesniffer, 10Composer: MediaWiki-Codesniffer test files not complying with PSR-4 - https://phabricator.wikimedia.org/T251913 (10Reedy) >No idea if this has any consequence beyond making the Composer output spammy. I'm presuming not until composer 2.0 is released [21:44:33] that problem shouldn't fail the build...I don't think [21:45:51] It looks like previous jobs have succeeded with the same error sukhe [21:46:12] ha! sorry. that's weird. I think I should just call it a day as I can't find what is wrong :P [21:47:19] ah I know what can be wrong. let me try. [21:47:30] > Could not parse for environment *root*: illegal comma separated argument list (file: /srv/workspace/puppet/modules/dnsdist/manifests/init.pp, line: 18, column: 96) [21:47:40] haha yeah [21:47:47] sorry for the noise [21:47:53] no worries :) [21:48:06] serves me right for pushing patches after 5PM :P [21:48:10] console output is hard to read :) [21:48:33] ctrl-f "error" is my usualy MO, but that got me nothing here. [21:49:10] yeah! and then I was mostly looking at "17:32:08 131 examples, 0 failures" [21:49:58] heh, yep, same [21:50:03] noise is definitely an annoyance with CI logs [22:00:50] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10CPT Initiatives (API Gateway): Determine how to host Chameleon skin and Bootstrap extension in gerrit while primary development happens in github - https://phabricator.wikimedia.org/T252463 (10thcipriani) >>! In T252463#6163471, @Krinkle wrote: >>>!... [22:25:41] (03PS1) 10Jack Phoenix: Whitelist jedipedia.fi domain [integration/config] - 10https://gerrit.wikimedia.org/r/598870 [22:26:33] (03CR) 10jerkins-bot: [V: 04-1] Whitelist jedipedia.fi domain [integration/config] - 10https://gerrit.wikimedia.org/r/598870 (owner: 10Jack Phoenix) [22:29:07] (03PS2) 10Jack Phoenix: Whitelist jedipedia.fi domain [integration/config] - 10https://gerrit.wikimedia.org/r/598870 [22:31:43] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: train-deploy-notes Jenkins job fails in conjunction with branch.py - https://phabricator.wikimedia.org/T243330 (10thcipriani) 05Open→03Resolved a:03thcipriani Works again \o/ htt... [22:52:35] (03CR) 10Thcipriani: [C: 04-1] feat: add scap apply-patch for security patches during train (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [22:56:11] (03CR) 10DannyS712: feat: add scap apply-patch for security patches during train (033 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [23:09:21] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10VPS-project-codesearch, 10MediaWiki-extensions-PerformanceInspector, 10Performance-Team: Undeploy PerformanceInspector from Beta Cluster - https://phabricator.wikimedia.org/T253689 (10Jdforrester-WMF) Ack. Happy t... [23:27:01] ummmmmmm: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/10.0.3.1 [23:27:14] Error: 1176 Key 'usertext_timestamp' doesn't exist in table 'revision' (172.16.4.147:3306) [23:28:04] oh might be https://phabricator.wikimedia.org/T253289 [23:45:26] Krenair: Yeah. :-( [23:53:14] There's mentions of usertext_timestamp all over the place