[01:23:48] James_F: left a commment [01:40:45] 10Deployments, 10Release-Engineering-Team-TODO, 10serviceops: Remove provisioning for 'mwscript', 'foreachwikiindblist' etc from deployment host - https://phabricator.wikimedia.org/T253822 (10Krinkle) [01:57:40] 10Scap, 10Patch-For-Review: Temporarily disable 'scap update-interwiki-cache' - https://phabricator.wikimedia.org/T247107 (10Krinkle) Rephrasing task given its a bit late for "temporary" measures now. [01:58:01] 10Scap, 10Patch-For-Review: Make 'scap update-interwiki-cache' less scary - https://phabricator.wikimedia.org/T247107 (10Krinkle) [02:00:00] 10Deployments, 10Release-Engineering-Team-TODO, 10serviceops, 10Sustainability (Incident Followup): Remove provisioning for 'mwscript', 'foreachwikiindblist' etc from deployment host - https://phabricator.wikimedia.org/T253822 (10Krinkle) [02:15:16] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10MediaWiki-Debug-Logger, 10Patch-For-Review, and 2 others: Ensure flood of hard-deprecations are caught during (train) deployments - https://phabricator.wikimedia.org/T252923 (10Krinkle) a:03Krinkle Will sign over for code review once the patch is i... [02:16:33] 10Continuous-Integration-Config, 10MediaWiki-Configuration, 10Wikidata, 10Sustainability (Incident Prevention): Consider having a linter that could catch config file entries that set unused variables - https://phabricator.wikimedia.org/T248866 (10Krinkle) Does this help? (03CR) 10Thcipriani: [C: 03+2] feat: add scap apply-patch for security patches during train (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [02:25:23] (03Merged) 10jenkins-bot: feat: add scap apply-patch for security patches during train [tools/scap] - 10https://gerrit.wikimedia.org/r/595983 (owner: 10Lars Wirzenius) [02:42:03] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Krinkle) >>! In T223410#5783502, @mmodell wrot... [02:56:05] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Krinkle) >>! In T223410#6171292, @Krinkle wrot... [02:57:14] (03CR) 10Krinkle: [C: 03+1] "Yay :)" [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (owner: 10Jforrester) [03:20:39] 10Deployments, 10Release-Engineering-Team-TODO, 10serviceops, 10Sustainability (Incident Prevention): Remove provisioning for 'mwscript', 'foreachwikiindblist' etc from deployment host - https://phabricator.wikimedia.org/T253822 (10DannyS712) [05:20:05] 10Deployments, 10Release-Engineering-Team-TODO, 10serviceops, 10Sustainability (Incident Prevention): Remove provisioning for 'mwscript', 'foreachwikiindblist' etc from deployment host - https://phabricator.wikimedia.org/T253822 (10Joe) Just out of curiosity, what's the problem with running scripts from th... [07:02:59] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10User-Ladsgroup, and 3 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Ladsgroup) >>! In T246945#6170345, @WDoranWMF wrote: > hey @Ladsgroup thanks again for helping out with t... [07:06:51] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Ladsgroup) I'm slightly concerned by putting W... [07:27:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Operations, and 2 others: Update Doxygen to 1.8.18 - https://phabricator.wikimedia.org/T253793 (10hashar) p:05Triage→03Medium [07:34:09] 10Gerrit: Allow wmf-deployment to remove votes from changes in wmf branches - https://phabricator.wikimedia.org/T229122 (10DannyS712) >>! In T229122#5994505, @Urbanecm wrote: >>>! In T229122#5994309, @hashar wrote: >> I would guess that is done in the `mediawiki` parent project https://gerrit.wikimedia.org/r/#/a... [07:51:42] (03PS1) 10Thiemo Kreuz (WMDE): Recognize used classes even if variable/type in a tag are flipped [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599276 (https://phabricator.wikimedia.org/T253711) [07:55:50] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: civicrm-buildkit doesn't composer update our wikimedia projects correctly - https://phabricator.wikimedia.org/T104031 (10hashar) [07:56:12] 10MediaWiki-Codesniffer, 10Patch-For-Review: Use statement marked as unused when it's used for a type hint - https://phabricator.wikimedia.org/T253711 (10thiemowmde) Just the same way around as in every function header. ;-) `lang=php public function __constructor( Component $instance ) ` @DannyS712, I believ... [07:57:54] (03CR) 10DannyS712: [C: 03+1] "LGTM" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599276 (https://phabricator.wikimedia.org/T253711) (owner: 10Thiemo Kreuz (WMDE)) [08:12:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): releng/operations-puppet failed to fail on a git error - https://phabricator.wikimedia.org/T253731 (10hashar) We use `docker run ... | tee log/rake.log` which has tw... [08:16:27] (03PS1) 10Hashar: jjb: fail docker run command when it is piped [integration/config] - 10https://gerrit.wikimedia.org/r/599281 (https://phabricator.wikimedia.org/T253731) [08:16:43] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: releng/operations-puppet failed to fail on a git error - https://phabricator.wikimedia.org/T253731 (10hashar) p:05Triage→03Medium a:03hash... [08:19:21] PROBLEM - Check systemd state on contint1001 is CRITICAL: CRITICAL - degraded: The system is operational but one or more units failed. https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [08:19:51] PROBLEM - zuul_merger_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [08:21:41] ACKNOWLEDGEMENT - Check systemd state on contint1001 is CRITICAL: CRITICAL - degraded: The system is operational but one or more units failed. daniel_zahn https://gerrit.wikimedia.org/r/c/operations/puppet/+/598057 https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [08:21:41] ACKNOWLEDGEMENT - zuul_merger_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args bin/zuul-merger daniel_zahn https://gerrit.wikimedia.org/r/c/operations/puppet/+/598057 https://www.mediawiki.org/wiki/Continuous_integration/Zuul [08:26:33] RECOVERY - zuul_merger_service_running on contint2001 is OK: PROCS OK: 1 process with regex args bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [08:28:25] RECOVERY - Check systemd state on contint1001 is OK: OK - running: The system is fully operational https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [08:54:12] 10Release-Engineering-Team, 10Operations, 10SRE-tools: Support running puppet Beaker on CI - https://phabricator.wikimedia.org/T253635 (10hashar) [09:11:00] Why Gerrit test instance isn't working? https://gerrit.git.wmflabs.org/ [09:13:17] CptViraj: the "git" project has been deleted and replaced by devtools [09:13:28] paladox: ^ currently we dont have the proxy up [09:15:11] mutante: Gotcha thanks :) [09:16:25] CptViraj: https://phabricator.wikimedia.org/T236569 [09:16:56] CptViraj: what do you want to test? (there is a new instance with gerrit but we don't have the proxy added yet) [09:18:15] mutante: actually I'm trynna learn how to use Gerrit, I want to test submitting patches [09:18:34] we have a sandbox repo [09:18:57] https://gerrit.wikimedia.org/r/#/admin/projects/sandbox [09:19:25] CptViraj: we will bring it back, but also using that sandbox repo is a good idea ^ [09:20:50] nice ty :) I'll use that one. [09:21:20] https://gerrit.wikimedia.org/r/q/project:sandbox [09:21:42] see that page of just test commits :) [09:23:59] cool ◉‿◉ [09:32:54] 10Gerrit, 10Operations, 10Patch-For-Review: gerritro user getting access denied from gerrit1002 - https://phabricator.wikimedia.org/T243800 (10Dzahn) After talking with Manuel i realized finally the ro password was in pwstore, not in the passwords module in the private puppet repo. The one from the pwstore... [09:52:37] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10Dzahn) 05Resolved→03Open Was blocked by T243800 which is now fixed. Though gerrit service does not keep running due to other issues, like file permissions. Reopening [09:52:44] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) [09:52:54] 10Gerrit, 10Operations, 10Patch-For-Review: gerritro user getting access denied from gerrit1002 - https://phabricator.wikimedia.org/T243800 (10Dzahn) 05Open→03Resolved [10:06:20] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10Dzahn) 05Open→03Resolved ` ● gerrit.service - Gerrit code review tool Loaded: loaded (/lib/systemd/system/gerrit.service; enabled; vendor preset: enabled) Active: active (running)... [10:06:25] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) [10:10:36] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10Dzahn) Hashar confirmed things are working now... [10:28:22] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Write script to apply security patches - https://phabricator.wikimedia.org/T247075 (10LarsWirzenius) This has been merged now. [12:10:39] (03PS1) 10Hashar: Upgrade jjb 3.1.0..3.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599312 [12:11:48] (03CR) 10Hashar: "I have to fix up maintenance-disconnect-full-disks independently." [integration/config] - 10https://gerrit.wikimedia.org/r/599312 (owner: 10Hashar) [12:22:38] (03PS1) 10Jack Phoenix: Set up CI for the TwitterTag MediaWiki extension [integration/config] - 10https://gerrit.wikimedia.org/r/599316 [12:40:47] (03CR) 10Hashar: Set up CI for the TwitterTag MediaWiki extension (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/599316 (owner: 10Jack Phoenix) [12:43:33] (03PS1) 10Hashar: Fix maintenance-disconnect-full-disks definition [integration/config] - 10https://gerrit.wikimedia.org/r/599317 [12:43:35] (03PS1) 10Hashar: Upgrade jjb 3.3.0..3.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599318 [12:44:37] (03CR) 10jerkins-bot: [V: 04-1] Fix maintenance-disconnect-full-disks definition [integration/config] - 10https://gerrit.wikimedia.org/r/599317 (owner: 10Hashar) [12:44:45] (03CR) 10jerkins-bot: [V: 04-1] Upgrade jjb 3.3.0..3.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599318 (owner: 10Hashar) [13:07:57] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10WDoranWMF) @Ladsgroup Thanks, I have passed these to @apaskulin and @eprodromou to get answered. [13:10:41] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [13:28:39] (03Abandoned) 10Jack Phoenix: Set up CI for the TwitterTag MediaWiki extension [integration/config] - 10https://gerrit.wikimedia.org/r/599316 (owner: 10Jack Phoenix) [13:29:33] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10hashar) 05Resolved→... [13:30:54] 10MediaWiki-Codesniffer, 10Patch-For-Review: Use statement marked as unused when it's used for a type hint - https://phabricator.wikimedia.org/T253711 (10Reedy) Thanks Thiemo! :) [13:31:24] !log Rolling back Xunit Jenkins plugin # T194096 [13:31:26] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:31:26] T194096: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 [13:35:05] hashar: Bah. It worked for the other jobs. Didn’t look at a Debian-glue one. [13:35:26] James_F: good morning ;) [13:35:27] no worries! [13:35:43] I would guess the junit it generates is handcrafted and somehow wrong [13:35:45] :-\ [13:36:31] will restart jenkins [13:37:09] Yeah. [13:54:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10hashar) I should have... [13:55:34] that fixed it on https://gerrit.wikimedia.org/r/#/c/operations/software/atskafka/+/599322/ [13:58:24] James_F: iirc the junit format does not have any formal spec [13:58:40] Of course not. [13:58:45] * James_F sighs. [13:59:25] twentyafterfour: I should have something ready to backport for before the train for that UBN [14:22:07] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Krinkle) If there are "general" (non-Wikidata)... [14:33:30] 10phan-taint-check-plugin: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) [14:48:27] 10phan-taint-check-plugin: Language::commaList (and friends) causing several taint-check false positives - https://phabricator.wikimedia.org/T253879 (10Daimona) [14:53:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10hashar) The Jenkins xu... [15:10:33] the patch is basically ready i believe, but thinking about some nice tests [15:13:56] 10Project-Admins: itWikiCon 2020 project creation - https://phabricator.wikimedia.org/T253785 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public parent project has been created: https://phabricator.wikimedia.org/project/view/4797/ Requested public subproject has been created: https://phabricator.... [15:14:49] 10Project-Admins: itWikiCon 2020 project creation - https://phabricator.wikimedia.org/T253785 (10Ferdi2005) Thank you Aklapper! [15:20:50] 10Beta-Cluster-Infrastructure, 10Security-Team, 10Wikimedia-Site-requests, 10ContentSecurityPolicy: Change Content Security Policy on betacommons to allow api.flickr.com - https://phabricator.wikimedia.org/T249486 (10TheDJ) >>! In T249486#6038532, @sbassett wrote: >>>! In T249486#6032726, @Bawolff wrote: >... [15:32:03] legoktm: Hmm, is LibUp having issues? http://libraryupgrader2.wmflabs.org/library/composer/mediawiki/mediawiki-codesniffer is out of date by several days (I bumped the canary repos to v31; it's not noticed that, nor the config change). [15:32:09] twentyafterfour: test commons is on group0 right? [15:32:14] addshore: Yes. [15:32:26] addshore: Want me to deploy it now? [15:32:31] nope, not yet :P [15:32:32] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10apaskulin) [15:32:52] its just a shame we dont have some smoke tests [15:32:53] like [15:32:53] https://test-commons.wikimedia.org/w/api.php?action=help&recursivesubmodules=1 [15:33:11] We do. [15:33:23] The selenium tests for Beta Commons broke over the weekend. [15:33:23] they dont ring loud enough alarms? or? [15:33:38] But because no-one believes selenium (boy-who-cried-wolf situation)… [15:33:44] no smoke tests for group0 though? [15:33:47] as noone trusts beta [15:34:00] PHP fatals are triggered by user behaviour. [15:34:13] Most of the non-read fatals we get require writing to the wikis. [15:34:18] We don't do that in production. [15:34:43] We do for test wikis, but test Commons is meant to be deleted at some point. [15:35:07] Of course, in this case it's an non-write API call that makes it fatal. [15:41:45] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Addshore) >>! In T223410#6172852, @Krinkle wro... [15:42:12] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10Jdforrester-WMF) Does... [15:44:51] (03PS1) 10Cicalese: move MediaModeration to production [integration/config] - 10https://gerrit.wikimedia.org/r/599362 [15:45:11] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, 10Patch-For-Review: Migrate contint* hosts to Buster - https://phabricator.wikimedia.org/T224591 (10Jdforrester-WMF) [15:45:38] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10WDoranWMF) @Ladsgroup should be up to date now, thanks @apaskulin [15:46:28] James_F: just waiting for https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/599364/ to be green then its ready for backport [15:48:44] Ack. [15:50:39] (03PS1) 10Cwhite: puppet-tests: update mtail to 3.0.0~rc35 [integration/config] - 10https://gerrit.wikimedia.org/r/599365 (https://phabricator.wikimedia.org/T251466) [15:50:55] (03PS2) 10Cicalese: move MediaModeration to production [integration/config] - 10https://gerrit.wikimedia.org/r/599362 (https://phabricator.wikimedia.org/T247943) [15:51:01] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Jdforrester-WMF) The "Add... [15:52:44] (03PS1) 10Jforrester: Start branching the MediaModeration extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/599366 (https://phabricator.wikimedia.org/T247943) [15:53:04] (03CR) 10Jforrester: [C: 03+2] Start branching the MediaModeration extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/599366 (https://phabricator.wikimedia.org/T247943) (owner: 10Jforrester) [15:53:58] (03Merged) 10jenkins-bot: Start branching the MediaModeration extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/599366 (https://phabricator.wikimedia.org/T247943) (owner: 10Jforrester) [15:54:00] (03CR) 10Ppchelko: [C: 03+1] move MediaModeration to production [integration/config] - 10https://gerrit.wikimedia.org/r/599362 (https://phabricator.wikimedia.org/T247943) (owner: 10Cicalese) [15:54:06] James_F: I'm also reading the code of InterwikiSorting quickly, but Im pretty sure we can kill it [15:54:12] Cool. [15:54:42] James_F: infact, I am very sure we can kill it [15:54:46] * addshore will say so on the ticket [15:55:05] Want to pair with me when I switch it off? :-) [15:55:21] Yes can do, as long as that other extension is everywhere, and always sorts the links? :P [15:56:54] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Jenkins: Switch back to upstream jenkins xunit plugin after PHPUnit fix is released - https://phabricator.wikimedia.org/T194096 (10hashar) A quick and di... [15:57:11] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-InterwikiSorting, 10Patch-For-Review, 10Technical-Debt: Undeploy the InterwikiSorting extension from Wikipedia production - https://phabricator.wikimedia.org/T253764 (10Addshore) I had a quick check through the code and belie... [15:58:06] addshore: ULS is, I think. [15:58:08] * James_F checks. [15:58:27] addshore: Oh, hmm. Not on wikisources or ruwikivoyage [15:58:31] addshore: Acceptable losses? [15:58:50] I'm not the product owner of those projects :P [15:59:01] or for any part of interwikilinks [15:59:27] Sounds like a yes to me. [15:59:41] $wgDefaultUserOptions['compact-language-links'] = 1; [15:59:50] That's on all wikis except loginwiki and votewiki. [16:00:24] wmgUseInterwikiSorting true on wikidataclient only, that does include wikisources [16:00:35] and ruwikivoyage :P [16:00:41] But on wikisources it's a beta feature so that you can disable it. [16:00:57] So the default experience isn't going to change. [16:01:02] Just for a few people that complain about it. [16:01:15] But they probably care, given they've manually disabled it. [16:01:17] just pointing out $wgDefaultUserOptions['compact-language-links'] = 0; is still set on beta [16:01:18] 🤷🏽‍♂️ [16:01:35] Of course it is. [16:01:44] should it be? =o [16:01:48] Probably not. [16:01:49] :D [16:02:06] I should just delete IS-labs and make people manually re-create it. [16:02:10] "But on wikisources it's a beta feature so that you can disable it." > well BFs are not enabled by default by default are they? [16:02:12] Oh, that's in CS-labs, even better. [16:02:19] addshore: This one is. [16:02:28] aaah [16:02:30] okay [16:02:56] Oh, no. [16:02:59] * James_F sighs. [16:03:03] * addshore signs [16:03:06] . [16:03:06] "uls-compact-links" is the beta feature key. [16:03:25] "compact-language-links" is the principal feature key. [16:03:29] * James_F sighs so very much. [16:03:40] well, I'll leave that with you to figure out ;) [16:04:01] sounds like it should be deployed everywhere, but I guess there were some objections from those communities? [16:04:12] Or they just didn't get around to it. [16:04:25] hopfully that [16:04:38] I know ruwv had a single community member complaining about any changes at all; a bunch of features from that time were not rolled out there because of him. [16:04:50] At some point, the answer is "tough". [16:06:38] 10Phabricator: Change AlQaholic007's username - https://phabricator.wikimedia.org/T253889 (10zeljkofilipin) [16:07:04] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Change AlQaholic007's username - https://phabricator.wikimedia.org/T253889 (10zeljkofilipin) p:05Triage→03Medium [16:07:57] (03PS3) 10Jforrester: layout: Move MediaModeration to production section and enforce [integration/config] - 10https://gerrit.wikimedia.org/r/599362 (https://phabricator.wikimedia.org/T247943) (owner: 10Cicalese) [16:08:04] (03CR) 10Jforrester: [C: 03+2] layout: Move MediaModeration to production section and enforce [integration/config] - 10https://gerrit.wikimedia.org/r/599362 (https://phabricator.wikimedia.org/T247943) (owner: 10Cicalese) [16:08:27] (03CR) 10Jforrester: "Oh, nice." [integration/config] - 10https://gerrit.wikimedia.org/r/599281 (https://phabricator.wikimedia.org/T253731) (owner: 10Hashar) [16:08:48] (03CR) 10Jforrester: [C: 04-1] "We just re-enabled using our fork of the plugin, sadly." [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (owner: 10Jforrester) [16:09:10] (03Merged) 10jenkins-bot: layout: Move MediaModeration to production section and enforce [integration/config] - 10https://gerrit.wikimedia.org/r/599362 (https://phabricator.wikimedia.org/T247943) (owner: 10Cicalese) [16:10:09] !log Zuul: Move MediaModeration to production section and enforce T247943 [16:10:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:10:12] T247943: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 [16:12:09] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Jdforrester-WMF) [16:15:57] James_F: im heading to dinner, but that link for the api i linked to can be used to confirm a fix of the backport [16:16:05] addshore: Ack. [16:16:07] if that page loads then train is unblocked from that ticket afaik [16:16:13] addshore: Note selenium failure on the master merge. [16:16:20] o/ im pingable if needed and very near laptop [16:16:22] Looks unrelated, just selenium being selenium, but… [16:16:24] * addshore checks selenium thingy [16:16:32] addshore: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/40975/ [16:17:05] yup, smells totally unrelated [16:17:14] Cool. Will progress. [16:17:42] https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/40975/artifact/log/ChangeFileInfo-page-MediaWiki-core-modules-present.mp4 [16:20:09] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10CCicalese_WMF) >>! In T247... [16:29:23] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Jdforrester-WMF) >>! In T2... [16:37:15] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) [16:37:39] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Request to delete user 'jbolorinos' from system - https://phabricator.wikimedia.org/T253786 (10zeljkofilipin) p:05Triage→03Medium a:03zeljkofilipin [16:40:23] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10CCicalese_WMF) OK, thanks... [16:44:10] (03CR) 10Jcrespo: [C: 04-1] "@Hashar, we have requested a new repo, operations/software/transferpy to split off the module on its own repo not only to simplify this, b" [integration/config] - 10https://gerrit.wikimedia.org/r/598492 (https://phabricator.wikimedia.org/T253219) (owner: 10Jcrespo) [16:51:01] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Request to delete user 'jbolorinos' from system - https://phabricator.wikimedia.org/T253786 (10Aklapper) 05Open→03Resolved a:05zeljkofilipin→03Aklapper I deleted https://phabricator.wikimedia.org/p/jbolorinos/ as the acco... [17:00:33] (03Abandoned) 10Jforrester: jjb: Rename 'slave-scripts' dir to 'ci-agent-scripts' [integration/config] - 10https://gerrit.wikimedia.org/r/565380 (owner: 10Jforrester) [17:11:38] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10MBinder_WMF) [17:13:28] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10MBinder_WMF) FYI, I did search for an existing ticket on this topic via https://phabricator.wikimedia.org/search/query/p.FiDV0MH7Yv/#R... [17:24:10] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10User-brennen: Add branch committers to train task - https://phabricator.wikimedia.org/T203111 (10thcipriani) 05Open→03Declined FWIW, @mmodell and I added the functionality to [[ https://gerrit.wikimedia.... [17:28:58] 10phan-taint-check-plugin: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) p:05Triage→03Lowest I tried implementing this, a few remarks: > - When we find an offset assignment: > -- If we can determine the offset with 100% accuracy, add the taintedness (same... [17:34:11] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Determine purpose of deployment-memc0[67] - https://phabricator.wikimedia.org/T250585 (10thcipriani) > Tyler: It looks like you made these in late November 2018. Any ideas? It looks like I added memc05/06 so that @aaron could test mcroute... [17:36:04] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Determine purpose of deployment-memc0[67] - https://phabricator.wikimedia.org/T250585 (10Krinkle) 05Open→03Resolved [17:36:07] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Krinkle) [17:36:26] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10MBinder_WMF) p:05Low→03Triage [17:37:07] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10MBinder_WMF) Resurrecting this as a feature request for the #phabricator board, since it's still relevant but Phlogiston is basically dead. [17:39:50] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10mmodell) It should be possible to create a custom field class for the start date and apply that field with a trigger attached to a column. [17:42:23] (03PS8) 10Jforrester: layout: [integration/docroot] Switch from php56 to php70 [integration/config] - 10https://gerrit.wikimedia.org/r/516570 [17:42:25] (03PS12) 10Jforrester: jjb: Drop all PHP56 jobs [integration/config] - 10https://gerrit.wikimedia.org/r/514058 (https://phabricator.wikimedia.org/T224906) [17:42:27] (03PS12) 10Jforrester: dockerfiles: Drop all PHP56 containers [integration/config] - 10https://gerrit.wikimedia.org/r/514059 (https://phabricator.wikimedia.org/T224906) [17:42:33] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10WDoranWMF) @Jdforrester-WMF Based on request from @thcipriani I'm adding a heads up note here, the Hooks changes @tstarling and @nnikkhou... [17:43:24] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Jdforrester-WMF) Ack. Thanks for the heads-up. [17:45:35] (03CR) 10Jforrester: [C: 03+2] layout: [integration/docroot] Switch from php56 to php70 [integration/config] - 10https://gerrit.wikimedia.org/r/516570 (owner: 10Jforrester) [17:46:53] (03Merged) 10jenkins-bot: layout: [integration/docroot] Switch from php56 to php70 [integration/config] - 10https://gerrit.wikimedia.org/r/516570 (owner: 10Jforrester) [17:48:32] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10MBinder_WMF) See also {T143348} [17:50:42] (03PS1) 10Jforrester: README: Update PHP hosting requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/599394 [17:51:29] (03CR) 10jerkins-bot: [V: 04-1] README: Update PHP hosting requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/599394 (owner: 10Jforrester) [17:51:33] 10Phabricator (Upstream), 10Upstream: Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. - https://phabricator.wikimedia.org/T120042 (10MBinder_WMF) @mmodell This is something that has come up again a few times this month. I assume the situation is u... [17:52:36] !log Zuul: [integration/docroot] Switch from php56 to php70 [17:52:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:53:07] (03CR) 10Jforrester: "recheck" [integration/docroot] - 10https://gerrit.wikimedia.org/r/599394 (owner: 10Jforrester) [17:54:10] (03PS13) 10Jforrester: jjb: Drop composer-php56-docker, last remaining PHP56 job [integration/config] - 10https://gerrit.wikimedia.org/r/514058 (https://phabricator.wikimedia.org/T224906) [18:01:15] 10Phabricator (Upstream), 10Upstream: Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. - https://phabricator.wikimedia.org/T120042 (10mmodell) @MBinder_WMF This fell off my radar so thanks for bringing it up. As Evan [[ https://secure.phabricator.... [18:05:08] 10Phabricator, 10Release-Engineering-Team-TODO, 10User-brennen: Document a (Wikimedia-specific) Phabricator local install - https://phabricator.wikimedia.org/T253132 (10mmodell) 05Open→03Resolved a:03brennen This now exists: https://www.mediawiki.org/wiki/Phabricator/Local_Dev_Environment [18:32:22] (03PS4) 10Jforrester: build: Upgrade mediawiki-codesniffer to v26.0.0, PHPUnit to 7.x [integration/docroot] - 10https://gerrit.wikimedia.org/r/542175 [18:32:59] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-codesniffer to v26.0.0, PHPUnit to 7.x [integration/docroot] - 10https://gerrit.wikimedia.org/r/542175 (owner: 10Jforrester) [18:34:23] (03PS5) 10Jforrester: build: Upgrade mediawiki-codesniffer to v26.0.0, PHPUnit to 6.x [integration/docroot] - 10https://gerrit.wikimedia.org/r/542175 [19:03:19] 10Phabricator (Upstream), 10Upstream: Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards. - https://phabricator.wikimedia.org/T120042 (10MBinder_WMF) Thanks for picking this up again, @mmodell ! Setting default points seems like a bad idea to me. It'... [19:15:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Krinkle) [19:59:48] 10Deployments, 10Release-Engineering-Team-TODO, 10serviceops, 10Sustainability (Incident Prevention): Remove provisioning for 'mwscript', 'foreachwikiindblist' etc from deployment host - https://phabricator.wikimedia.org/T253822 (10Krinkle) >>! In T253822#6171395, @Joe wrote: > Just out of curiosity, what'... [20:02:50] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Urbanecm) [20:09:06] 10MediaWiki-Codesniffer: Sniff for wrong order of PHPUnit assert parameters - https://phabricator.wikimedia.org/T253910 (10Krinkle) [20:10:08] 10phan-taint-check-plugin: Language::commaList (and friends) causing several taint-check false positives - https://phabricator.wikimedia.org/T253879 (10Umherirrender) For use in messages there is also `Message::listParam( 'comma' )` which can delay the parsing and maybe help (or not). I would expect that the ca... [20:12:24] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [design/blog] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599422 [20:12:26] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [design/blog] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599422 (owner: 10QChris) [20:13:04] (03PS1) 10QChris: Import done. Revoke import grants [design/blog] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599423 [20:13:06] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [design/blog] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599423 (owner: 10QChris) [20:16:17] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [software/transferpy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599427 [20:16:19] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [software/transferpy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599427 (owner: 10QChris) [20:16:59] (03PS1) 10QChris: Import done. Revoke import grants [software/transferpy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599428 [20:17:01] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [software/transferpy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/599428 (owner: 10QChris) [20:17:05] 10MediaWiki-Codesniffer, 10MediaWiki-General: Investigate adopting and enforcing naming convention for RAII variables - https://phabricator.wikimedia.org/T253782 (10Umherirrender) We could also start using `try/finally` to call the code/closure which is in the `ScopedCallback`. Or to add `ScopedCallback::consu... [20:26:01] 10MediaWiki-Codesniffer: Is "@return $this" a valid return type declaration? - https://phabricator.wikimedia.org/T253914 (10Umherirrender) [20:30:30] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10mmodell) So that leaves wednesday for wikidata... [20:30:43] 10MediaWiki-Codesniffer: Is "@return $this" a valid return type declaration? - https://phabricator.wikimedia.org/T253914 (10Krinkle) `@return self` or `@return static` means it will return something that is of the same type. * For example `Foo::newFromX` could use `return self`. Or, if it supports subclassing a... [20:52:57] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Krinkle) [20:54:17] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10Pablo-WMDE) 05Open→03Resolved... [20:54:55] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) [21:12:36] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) [21:15:29] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Jdforrester-WMF) >>! In T223410#6173263, @Adds... [21:27:10] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) [22:38:32] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-DannyS712: 1.35.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T253022 (10Jdforrester-WMF) 05Open→03Resolved Let's declare ourselves done for the week. [23:14:16] James_F: yes, fixing it now [23:14:33] legoktm: Thank you! [23:14:56] legoktm: Also, you may have Thoughts™ on https://gerrit.wikimedia.org/r/c/labs/tools/wikibugs2/+/599452 :-) [23:23:00] (03CR) 10Jforrester: "LGTM. Do you want to deploy or should I?" [integration/config] - 10https://gerrit.wikimedia.org/r/599312 (owner: 10Hashar) [23:45:46] 10LibUp, 10MediaWiki-General: `composer lint` doesn't actually work in libraryupgrader on mw core - https://phabricator.wikimedia.org/T249554 (10Legoktm) 05Resolved→03Open Reverted in https://gerrit.wikimedia.org/r/c/labs/libraryupgrader/+/599471 - we need to limit this change to just MediaWiki core's uniq...