[00:20:32] legoktm: ❤️ for a second time. [00:20:53] Next up https://gerrit.wikimedia.org/r/c/labs/libraryupgrader/+/586401 ? :-) [00:26:19] :) [00:27:00] James_F: I'm going to post some notes on phab in a bit for that patch [00:27:24] 10Beta-Cluster-Infrastructure: [betalabs] Console errors for commonswiki pages - https://phabricator.wikimedia.org/T253939 (10Reedy) [00:28:24] 10Beta-Cluster-Infrastructure: [betalabs] Console errors for commonswiki pages - https://phabricator.wikimedia.org/T253939 (10Reedy) A default enabled Gadget is using a removed JS feature; `AjaxQuickDelete` depends on `mediawiki.RegExp` Disabld the gadget in https://commons.wikimedia.beta.wmflabs.org/w/index.ph... [00:30:31] legoktm: Yay. [00:30:38] Progress is better than nothing. [00:35:42] https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page Y U NO SIDEBAR? [00:36:49] Reedy: That's the new Vector thing, right. [00:36:55] No sidebar? :P [00:37:34] Reedy: Click the menu button to get it. [00:37:40] (Yes.) [00:37:48] So we have lots of pointless whitespace instead? [00:37:53] * Reedy blinks [00:38:06] 5195f5fd67181cc48d9af5a6a2354e0401e76d89 [00:42:54] https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=MediaWiki:ImageAnnotatorConfig.js&action=history [00:43:03] I love that beta hasn't got updates to JS from 2015 [00:43:49] can someone also fix the edit notice on the main page to not be the semiprotection one? [00:43:55] main page of beta commons [00:46:24] >Gadget is not loaded. Please migrate to ResourceLoader. (Learn more) [00:46:27] This is such a mess [00:49:50] DannyS712: What would you prefer it was? [00:50:15] 10Beta-Cluster-Infrastructure: [betalabs] Console errors for commonswiki pages - https://phabricator.wikimedia.org/T253939 (10Reedy) 05Open→03Resolved a:03Reedy I disabled more gadgets, and then updated some site JS from commons [00:50:36] say that it is fully protected, because it is [00:53:46] >Warning: This page has been protected so that only users with administrator privileges can edit it. [00:53:50] WFM? [00:54:43] protection notice for those who cannot edit it - eg open in chrome incognito [00:55:54] (permissionserrorstext-withaction: 1, (action-edit)) [00:55:54] (protectedpagetext: editprotected, edit) [01:01:21] >Import failed: No interwiki prefix was supplied [01:01:41] What import? [01:02:03] I'm stealing the nice templates from commons [01:02:51] Or was trying to [01:03:12] Just delete the wiki and re-import everything? ;-) [01:04:53] https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=edit [01:04:54] So pretty [01:05:11] thanks [01:10:22] legoktm: If only I could actually run tox locally for libup I might be able to work on it more, but it's missing a setup.py… [01:10:50] heh [01:10:58] yeah... running it locally seemed vaguely impossible [01:11:06] James_F: You probably need to upgrade your tox [01:11:55] I'm running 3.0? [01:11:56] I tried to use some more bleeding-edge Python stuff with pyproject.toml and poetry but idk if it was actually worth it all [01:12:59] Right. [01:13:28] 3.0 is two years old [01:13:34] How did you install it? [01:13:39] No idea. [01:14:02] Try $ pip install -U tox [01:14:41] Aha. [01:14:55] Now 3.15.1 [01:16:03] Woot. It should work now, hopefully [01:16:13] Aha, and yeah, it installs. [01:18:18] 10phan, 10MediaWiki-extensions-LiquidThreads: Echoing expression that was not html escaped - https://phabricator.wikimedia.org/T253944 (10Reedy) [01:56:25] legoktm: Umm. http://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/VisualEditor says "there are no updates"; did I need to set a flag on the php-parallel-lint switch to say this was a real change (or is it a good thing that we don't do that until a real change comes along)? [02:16:20] James_F: I think it's a good thing [02:33:50] (03PS1) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [02:39:31] (03PS2) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [02:41:59] (03PS3) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [02:49:54] 10MediaWiki-Codesniffer, 10User-DannyS712: Sniff for wrong order of PHPUnit assert parameters - https://phabricator.wikimedia.org/T253910 (10DannyS712) a:03DannyS712 Should be fairly straightforward for the majority of cases Given that this would be adding a fifth phpunit sniff, I've submitted https://gerrit... [03:18:49] OK. [03:53:36] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [06:32:41] 10Beta-Cluster-Infrastructure: [betalabs] Console errors for commonswiki pages (due to AjaxQuickDelete gadget depending on mediawiki.RegExp) - https://phabricator.wikimedia.org/T253939 (10Aklapper) [06:58:19] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Aklapper) [07:09:43] 10MediaWiki-Codesniffer, 10MediaWiki-General: Investigate adopting and enforcing naming convention for RAII variables - https://phabricator.wikimedia.org/T253782 (10thiemowmde) [07:12:15] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Change AlQaholic007's username in Phabricator - https://phabricator.wikimedia.org/T253889 (10Aklapper) [07:13:48] 10Project-Admins: Project creation: Minipedia - https://phabricator.wikimedia.org/T253960 (10valerio.bozzolan) [07:18:01] !log Deleted last php5.6 job hurrah and thanks James ! https://integration.wikimedia.org/ci/job/composer-php56-docker/ [07:18:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:18:11] !log Deleted last php5.6 job hurrah and thanks James ! https://integration.wikimedia.org/ci/job/composer-php56-docker/ # T224906 [07:18:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:18:14] T224906: Drop php56 testing support - https://phabricator.wikimedia.org/T224906 [07:19:04] (03CR) 10Hashar: [C: 03+2] "The -2 was for integration/docroot which got moved to Buster and the job removed by https://gerrit.wikimedia.org/r/#/c/integration/config/" [integration/config] - 10https://gerrit.wikimedia.org/r/514058 (https://phabricator.wikimedia.org/T224906) (owner: 10Jforrester) [07:19:22] (03Merged) 10jenkins-bot: jjb: Drop composer-php56-docker, last remaining PHP56 job [integration/config] - 10https://gerrit.wikimedia.org/r/514058 (https://phabricator.wikimedia.org/T224906) (owner: 10Jforrester) [07:20:58] (03CR) 10Hashar: [C: 03+2] "CR-2 was for integration/docroot which has been migrated." [integration/config] - 10https://gerrit.wikimedia.org/r/514059 (https://phabricator.wikimedia.org/T224906) (owner: 10Jforrester) [07:21:55] (03Merged) 10jenkins-bot: dockerfiles: Drop all PHP56 containers [integration/config] - 10https://gerrit.wikimedia.org/r/514059 (https://phabricator.wikimedia.org/T224906) (owner: 10Jforrester) [07:23:07] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review: Drop php56 testing support - https://phabricator.wikimedia.org/T224906 (10hashar) 05Open→03Resolved a:03Jdforrester-WMF The last use was for `integration/d... [07:23:09] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop jessie testing support - https://phabricator.wikimedia.org/T224908 (10hashar) [07:23:31] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop jessie testing support - https://phabricator.wikimedia.org/T224908 (10hashar) [07:24:27] 10Continuous-Integration-Infrastructure, 10User-Addshore: un blacklist https://integration.wikimedia.org/ci/computer/XXXX/builds - https://phabricator.wikimedia.org/T178458 (10Dzahn) @Addshore Is this resolved? [07:34:48] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish fails: corrupted size vs. prev_size - https://phabricator.wikimedia.org/T253723 (10hashar) That could be the subject... [07:36:15] (03CR) 10Hashar: "I guess I was just waiting for the jjb diff output to confirm my local run and then went side tracked to fix something else :]" [integration/config] - 10https://gerrit.wikimedia.org/r/599312 (owner: 10Hashar) [07:36:20] (03PS2) 10Hashar: Upgrade jjb 3.1.0..3.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599312 [07:41:34] 10Project-Admins: Project creation: Minipedia - https://phabricator.wikimedia.org/T253960 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #Minipedia has been created: https://phabricator.wikimedia.org/project/view/4799/ Please encourage interested people to visit the project and to jo... [07:42:33] (03CR) 10Hashar: [C: 03+2] "It is a noop!" [integration/config] - 10https://gerrit.wikimedia.org/r/599312 (owner: 10Hashar) [07:43:36] (03Merged) 10jenkins-bot: Upgrade jjb 3.1.0..3.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599312 (owner: 10Hashar) [07:58:39] phabricator is broken due to PhabricatorRepositoryMirrorEngine.php using all the CPU [07:58:47] did somebody start something? [08:04:05] PROBLEM - PHD should be running on phab1001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args php ./phd-daemon, UID = 497 (phd) https://wikitech.wikimedia.org/wiki/Phabricator [08:04:32] ^ yea, i stopped that [08:04:48] PROBLEM - PHD should be supervising processes on phab1001 is CRITICAL: PROCS CRITICAL: 0 processes with UID = 497 (phd) https://wikitech.wikimedia.org/wiki/Phabricator [08:05:55] RECOVERY - PHD should be running on phab1001 is OK: PROCS OK: 1 process with regex args php ./phd-daemon, UID = 497 (phd) https://wikitech.wikimedia.org/wiki/Phabricator [08:06:37] RECOVERY - PHD should be supervising processes on phab1001 is OK: PROCS OK: 23 processes with UID = 497 (phd) https://wikitech.wikimedia.org/wiki/Phabricator [08:07:11] and it will break again' [08:11:45] (03PS2) 10Hashar: Fix maintenance-disconnect-full-disks definition [integration/config] - 10https://gerrit.wikimedia.org/r/599317 [08:11:47] (03PS1) 10Hashar: tests: jjb job name is the directory not the file [integration/config] - 10https://gerrit.wikimedia.org/r/599706 [08:17:45] (03CR) 10Hashar: [C: 03+2] tests: jjb job name is the directory not the file [integration/config] - 10https://gerrit.wikimedia.org/r/599706 (owner: 10Hashar) [08:18:50] (03Merged) 10jenkins-bot: tests: jjb job name is the directory not the file [integration/config] - 10https://gerrit.wikimedia.org/r/599706 (owner: 10Hashar) [08:20:07] (03CR) 10Hashar: [C: 03+2] Fix maintenance-disconnect-full-disks definition [integration/config] - 10https://gerrit.wikimedia.org/r/599317 (owner: 10Hashar) [08:21:13] (03Merged) 10jenkins-bot: Fix maintenance-disconnect-full-disks definition [integration/config] - 10https://gerrit.wikimedia.org/r/599317 (owner: 10Hashar) [08:21:27] (03PS2) 10Hashar: Upgrade jjb 3.3.0..3.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599318 [08:25:36] 10Project-Admins, 10Minipedia: Project creation: Minipedia - https://phabricator.wikimedia.org/T253960 (10valerio.bozzolan) That fast? {icon rocket} Thank you! [08:50:55] Has there been a gerrit update? [08:50:59] mutante: ^ [08:52:34] RhinosF1: why are you asking? [08:52:49] mutante: the font looks different in places [08:52:59] on old skin [08:53:59] RhinosF1: I am not aware of an upgrade. The upgrade to 2.16 is planned but has not happened yet. [08:54:38] mutante: something's changed. [08:55:22] create change used to be lighter and the description box white and & smaller text https://usercontent.irccloud-cdn.com/file/Vdpz8umz/Screenshot%202020-05-29%20at%2009.54.51.png [08:57:42] RhinosF1: is it a problem? [08:57:46] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) We are today on 2.15.14-16-g855b179b5f. Can this be closed? [08:57:51] ^ heh [08:57:52] mutante: no, just confused [08:58:36] ignore my ticket comment above [09:00:49] RhinosF1: maybe ask on https://phabricator.wikimedia.org/T225369 [09:01:01] that is the one that brought us to current 2.15.14. i dont know beyond that [09:01:59] and that is not public.. so yea.. ask Tyler and Paladox [09:07:19] (03CR) 10Hashar: [C: 03+2] Upgrade jjb 3.3.0..3.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599318 (owner: 10Hashar) [09:08:17] (03Merged) 10jenkins-bot: Upgrade jjb 3.3.0..3.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/599318 (owner: 10Hashar) [09:09:13] mutante: is there anyway to add a comment and move 4 tasks between columns on 2 workboards quicklu [09:09:41] !log Updating all Jenkins jobs: tox -e jenkins-jobs -- --flush-cache --conf jenkins_jobs.ini update --workers 2 ./jjb [09:09:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:10:49] RhinosF1: https://phabricator.wikimedia.org/T1284 https://phabricator.wikimedia.org/T78826 [09:12:29] mutante: That does all tasks in a column, I'd want to take 4 task ids and perform a column move for just them & add a comment [09:12:53] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Ladsgroup) I need the DNS patch and the puppet patch be merged and deployed before I can continue. SRE... [09:17:44] RhinosF1: ok, please comment on one of those tickets then [09:18:39] mutante: To get access or have the feature? I was asking because if so I want to use it. [09:18:54] it doesn't allow moving between columns [09:19:23] ok [09:20:15] manual time then [09:20:28] RhinosF1: i have no idea [09:20:37] ok [09:20:41] * RhinosF1 do it manually [09:22:18] your options are not limited to asking me or doing it manually. andre will now for sure [09:22:22] know [09:22:57] I've nearly done it. 4 tasks don't take that long. [09:38:24] 10phan, 10MediaWiki-extensions-LiquidThreads, 10Patch-For-Review: Echoing expression that was not html escaped - https://phabricator.wikimedia.org/T253944 (10Daimona) I agree with Thiemo's solution; besides, a few things I'd like to mention: - XSS false positives in maintenance scripts are, unfortunately, a... [09:49:50] 10phan, 10MediaWiki-extensions-LiquidThreads: Echoing expression that was not html escaped - https://phabricator.wikimedia.org/T253944 (10DannyS712) 05Open→03Resolved a:03thiemowmde [10:48:22] 10MediaWiki-Codesniffer: Is "@return $this" a valid return type declaration? - https://phabricator.wikimedia.org/T253914 (10thiemowmde) I agree with Krinkle. `@return $this` is rare. Personally I don't use it, but prefer `@return self` instead – which is correct as well. However, I don't think there is anything... [10:53:17] 10phan-taint-check-plugin, 10MediaWiki-extensions-LiquidThreads: Echoing expression that was not html escaped - https://phabricator.wikimedia.org/T253944 (10Daimona) [11:21:04] 10MediaWiki-Codesniffer, 10User-DannyS712: Sniff for wrong order of PHPUnit assert parameters - https://phabricator.wikimedia.org/T253910 (10thiemowmde) A while ago I did a few manual cleanups and tried to find flipped "expected" and "actual" parameters. * If the second parameter of an `assertEquals` or `asser... [11:24:25] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10Aklapper) > Right now, this process means batch-editing the tasks (ideally silently), importing columns from the old board to the new b... [11:31:35] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: 5 of the 15 prioritized repositories have at least 1 end-to-end test - https://phabricator.wikimedia.org/T206621 (10Aklapper) [11:54:45] (03CR) 10Thiemo Kreuz (WMDE): Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [11:58:56] (03PS4) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [11:59:03] (03CR) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [12:02:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:02:13] (03PS5) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [12:03:56] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:04:52] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:14:46] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Prepare Scap release 1.15.0 with current changes - https://phabricator.wikimedia.org/T253996 (10LarsWirzenius) [12:20:16] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Make a proof of concept set of nested VMs for train dev/test - https://phabricator.wikimedia.org/T253997 (10LarsWirzenius) [12:20:43] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Make a proof of concept set of nested VMs for train dev/test - https://phabricator.wikimedia.org/T253997 (10LarsWirzenius) [12:20:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Prepare Scap release 1.15.0 with current changes - https://phabricator.wikimedia.org/T253996 (10LarsWirzenius) p:05Triage→03High [12:20:53] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Make a proof of concept set of nested VMs for train dev/test - https://phabricator.wikimedia.org/T253997 (10LarsWirzenius) p:05Triage→03High [12:23:06] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Document that "scap test-patches" may fail, when "scap apply-patches" would work - https://phabricator.wikimedia.org/T253999 (10LarsWirzenius) [12:23:21] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Make a proof of concept set of nested VMs for train dev/test - https://phabricator.wikimedia.org/T253997 (10LarsWirzenius) a:03LarsWirzenius [12:23:51] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 96429 bytes in 2.060 second response time [12:24:20] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Change AlQaholic007's username in Phabricator - https://phabricator.wikimedia.org/T253889 (10AlQaholic007) Soham [12:24:44] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 96718 bytes in 1.193 second response time [12:24:47] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Add tests to Scap cdb generation - https://phabricator.wikimedia.org/T254000 (10LarsWirzenius) [12:24:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Document that "scap test-patches" may fail, when "scap apply-patches" would work - https://phabricator.wikimedia.org/T253999 (10LarsWirzenius) p:05Triage→03High [12:24:53] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Add tests to Scap cdb generation - https://phabricator.wikimedia.org/T254000 (10LarsWirzenius) p:05Triage→03High [12:26:33] (03PS2) 10Hashar: Archive integration/jenkinsci/postbuildscript-plugin [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (https://phabricator.wikimedia.org/T253335) (owner: 10Jforrester) [12:27:03] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 56302 bytes in 0.964 second response time [12:28:41] (03Abandoned) 10Hashar: jjb: Drop jenkins-plugin-postbuildscript-maven-java8-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/599131 (owner: 10Jforrester) [12:29:32] (03CR) 10Hashar: [C: 03+2] "We have reenabled the xunit plugin while this change is about the postbuildscript plugin ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (https://phabricator.wikimedia.org/T253335) (owner: 10Jforrester) [12:30:32] (03Merged) 10jenkins-bot: Archive integration/jenkinsci/postbuildscript-plugin [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (https://phabricator.wikimedia.org/T253335) (owner: 10Jforrester) [12:41:44] (03CR) 10Hashar: [C: 03+2] README: Update PHP hosting requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/599394 (owner: 10Jforrester) [12:42:02] (03CR) 10Hashar: [C: 03+2] build: Upgrade mediawiki-codesniffer to v26.0.0, PHPUnit to 6.x [integration/docroot] - 10https://gerrit.wikimedia.org/r/542175 (owner: 10Jforrester) [12:42:55] (03Merged) 10jenkins-bot: README: Update PHP hosting requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/599394 (owner: 10Jforrester) [12:42:57] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-codesniffer to v26.0.0, PHPUnit to 6.x [integration/docroot] - 10https://gerrit.wikimedia.org/r/542175 (owner: 10Jforrester) [12:43:31] phunit 6.x? [12:43:34] so new [12:43:36] much updates [12:43:37] wow [12:45:20] (03PS3) 10Hashar: Add extension TwitterTag [integration/config] - 10https://gerrit.wikimedia.org/r/599128 (owner: 1001miki10) [12:45:52] (03CR) 10Hashar: Add extension TwitterTag (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/599128 (owner: 1001miki10) [12:46:01] (03CR) 10Hashar: [C: 03+2] Add extension TwitterTag [integration/config] - 10https://gerrit.wikimedia.org/r/599128 (owner: 1001miki10) [12:46:59] (03Merged) 10jenkins-bot: Add extension TwitterTag [integration/config] - 10https://gerrit.wikimedia.org/r/599128 (owner: 1001miki10) [12:52:44] 10phan, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Reedy) [12:58:02] (03PS3) 10Hashar: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [12:58:27] Ty hashar [12:58:28] (03CR) 10Hashar: [C: 03+2] "I have added the "archived" template ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [12:59:26] (03Merged) 10jenkins-bot: Archive SiteScout [integration/config] - 10https://gerrit.wikimedia.org/r/598233 (https://phabricator.wikimedia.org/T253452) (owner: 10RhinosF1) [13:04:14] (03CR) 10Hashar: [C: 03+1] jjb: [beta-scap-eqiad]: scap sync -> scap sync-world [integration/config] - 10https://gerrit.wikimedia.org/r/597832 (https://phabricator.wikimedia.org/T250302) (owner: 10Thcipriani) [13:09:04] 10phan-taint-check-plugin, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Daimona) a:03Daimona I'm investigating. [13:15:04] (03PS1) 10Lars Wirzenius: fix(targets.py): patterns with both ! and [] [tools/scap] - 10https://gerrit.wikimedia.org/r/599849 [13:18:54] (03CR) 10Lars Wirzenius: "I found a bug in scap, see commit message for information." [tools/scap] - 10https://gerrit.wikimedia.org/r/599849 (owner: 10Lars Wirzenius) [13:42:28] 10Phabricator, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Change AlQaholic007's username in Phabricator - https://phabricator.wikimedia.org/T253889 (10Aklapper) 05Open→03Resolved a:05zeljkofilipin→03Aklapper Done. [13:57:18] 10phan-taint-check-plugin, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Daimona) So, here is the path that I've reconstructed. - Collaborati... [14:03:22] 10MediaWiki-Codesniffer, 10MediaWiki-General: Investigate adopting and enforcing naming convention for RAII variables - https://phabricator.wikimedia.org/T253782 (10Daimona) >>! In T253782#6174256, @Umherirrender wrote: > We could also start using `try/finally` to call the code/closure which is in the `ScopedC... [14:04:06] (03CR) 10Hashar: [C: 03+2] Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 (owner: 10DannyS712) [14:04:18] (03CR) 10Lars Wirzenius: "I'll +2 this after my question about keeping --compress is answered." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:05:10] (03Merged) 10jenkins-bot: Whitelist: Add Shirayuki [integration/config] - 10https://gerrit.wikimedia.org/r/598221 (owner: 10DannyS712) [14:05:57] (03CR) 10Hashar: [C: 03+2] "Deployed! :]" [integration/config] - 10https://gerrit.wikimedia.org/r/598221 (owner: 10DannyS712) [14:06:41] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10daniel) >>! In T253023#6173804, @WDoranWMF wrote: > @Jdforrester-WMF Based on request from @thcipriani I'm adding a heads up note here, t... [14:09:07] (03CR) 10Hashar: [C: 03+2] "Looks correct ;] It can always be polished up later." [integration/config] - 10https://gerrit.wikimedia.org/r/596407 (owner: 10Awight) [14:10:04] (03Merged) 10jenkins-bot: Docker image for testing Scala repos [integration/config] - 10https://gerrit.wikimedia.org/r/596407 (owner: 10Awight) [14:15:21] (03CR) 10Hashar: [C: 03+2] "Successfully tagged docker-registry.discovery.wmnet/releng/java8-scala-spark:0.1.0" [integration/config] - 10https://gerrit.wikimedia.org/r/596407 (owner: 10Awight) [14:15:50] (03CR) 10Lars Wirzenius: [C: 03+2] "> Patch Set 2:" (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:17:48] (03Merged) 10jenkins-bot: Make rsync use new compress algorithm [tools/scap] - 10https://gerrit.wikimedia.org/r/595942 (https://phabricator.wikimedia.org/T252540) (owner: 10Hashar) [14:21:44] (03CR) 10Hashar: "Good catch ;) We would need an entry in debian/changelog and a version bump in order to be able to build the image." [integration/config] - 10https://gerrit.wikimedia.org/r/596403 (owner: 10Awight) [14:24:21] (03PS2) 10Awight: Remove package files to minimize build stage and image [integration/config] - 10https://gerrit.wikimedia.org/r/596403 [14:26:16] liw: thx for rsync --new-compress , though I can not tell whether it will make any change [14:27:23] awight: well done :] [14:27:58] hashar, in my informal tests it does, rsync of a gigabyte of zeros went from 110 MB/s to 230 MB/s over gigabit ethernet [14:28:49] (03PS3) 10Hashar: Remove package files to minimize build stage and image [integration/config] - 10https://gerrit.wikimedia.org/r/596403 (owner: 10Awight) [14:29:16] (03CR) 10Hashar: [C: 03+2] "rebased and a tiny fix" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/596403 (owner: 10Awight) [14:29:50] hashar: Looking forward to figuring out the zuul/layout to use that image :-) [14:30:13] (03Merged) 10jenkins-bot: Remove package files to minimize build stage and image [integration/config] - 10https://gerrit.wikimedia.org/r/596403 (owner: 10Awight) [14:33:28] awight_: ideally we would have rebuild all child images of releng/java8 to get rid of the /tmp/ files [14:33:29] BUT [14:33:40] that also mean apt upgrade everything which might cause havoc ;] [14:33:51] the next rebuilds will benefit from it. That is good enough [14:34:35] (03PS1) 10Lars Wirzenius: doc(scap.md): document when test-patches may fail surprisingly [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 [14:35:07] (03PS2) 10Lars Wirzenius: doc(scap.md): document when test-patches may fail surprisingly [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 (https://phabricator.wikimedia.org/T253999) [14:35:35] (03CR) 10Lars Wirzenius: "Document a minor blemish in scap test-patches" [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 (https://phabricator.wikimedia.org/T253999) (owner: 10Lars Wirzenius) [14:36:16] !log Built Successfully tagged docker-registry.discovery.wmnet/releng/java8:0.6.4 [14:36:18] hashar: Ah I was confusing the two patches--yeah I'll wire up the scala job. I'm not relying on getting rid of the /tmp files, of course. [14:36:18] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:36:27] Thanks for the review! [14:36:53] awight_: yeah and sorry for the large delay. I am lagging in my review [14:37:00] still haven't looked at the quibble patches bah :-\ [14:39:10] 10phan-taint-check-plugin, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Umherirrender) The problem is more that the function allows to create... [14:43:08] I can imagine your overall situation is as hectic as mine, it's a wonder either of us can get anything done at all! [14:47:21] 10MediaWiki-Codesniffer: Is "@return $this" a valid return type declaration? - https://phabricator.wikimedia.org/T253914 (10Umherirrender) But mw/HTMLForm does not use this style. ` * @return HTMLForm $this for chaining calls (since 1.20) public function prepareForm() { +38 more cases * @return $this p... [15:00:04] awight_: yeah :] [15:00:10] speaking of that. I am done for this week [15:00:16] going to clean the house after 5 days of mess [15:00:32] house work magic! [15:00:55] good week end every one [15:09:53] 10phan-taint-check-plugin, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Daimona) Ah, note that I didn't really analyze the code itself. I just... [15:17:13] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Add tests to Scap cdb generation - https://phabricator.wikimedia.org/T254000 (10LarsWirzenius) scap/tasks.py has update_l10n_cdb function, which reads JSON files and writes CDB files. I think we need to do the following: [ ] extract the actual... [15:34:44] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10MBinder_WMF) Interesting. Is this feature reliable? For instance, this recent conversation about the Move Tasks to Column feature: {T24... [15:48:15] 10MediaWiki-Codesniffer: Is "@return $this" a valid return type declaration? - https://phabricator.wikimedia.org/T253914 (10thiemowmde) I don't think it needs to. `@return self` is certainly correct. Code that does `return $this;` at the end just does not return //some// instance of itself, but the //same// inst... [16:03:38] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10Aklapper) >>! In T253897#6177344, @MBinder_WMF wrote: > Interesting. Is this feature reliable? For instance, this recent conversation a... [16:13:04] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10MBinder_WMF) >>! In T253897#6177400, @Aklapper wrote: >>>! In T253897#6177344, @MBinder_WMF wrote: >> Interesting. Is this feature reli... [16:14:16] 10Release-Engineering-Team, 10Recommendation-API, 10Services, 10serviceops, 10Patch-For-Review: Migrate recommendation-api to kubernetes - https://phabricator.wikimedia.org/T241230 (10akosiaris) [16:36:21] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor, 10PHP 7.4 support, and 2 others: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Umherirrender) It seems there is no bump of the version for parellel-lint nee... [16:39:00] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor, 10PHP 7.4 support, and 2 others: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Jdforrester-WMF) >>! In T247827#6177520, @Umherirrender wrote: > It seems the... [16:43:48] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor, 10PHP 7.4 support, and 2 others: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Jdforrester-WMF) 05Stalled→03Resolved a:03Jdforrester-WMF OK, this shou... [16:48:06] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop jessie testing support - https://phabricator.wikimedia.org/T224908 (10Jdforrester-WMF) [16:48:20] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop jessie testing support - https://phabricator.wikimedia.org/T224908 (10Jdforrester-WMF) [16:48:23] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10JavaScript: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10Jdforrester-WMF) [16:51:14] 10LibUp, 10MediaWiki-General, 10MediaWiki-Vendor, 10PHP 7.4 support, and 2 others: jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead - https://phabricator.wikimedia.org/T247827 (10Umherirrender) >>! In T247827#6177552, @Jdforrester-WMF wrote: > OK, this sho... [17:05:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10JavaScript: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10Jdforrester-WMF) [17:21:53] 10phan-taint-check-plugin, 10MediaWiki-extensions-CollaborationKit: Calling method OutputPage::prependHTML() in CollaborationKitHooks::onOutputPageBeforeHTML that outputs using tainted argument - https://phabricator.wikimedia.org/T254005 (10Daimona) a:05Daimona→03None Having done some initial investigation... [18:12:49] hauskatze: thanks! [18:12:59] np :) [18:13:07] catching with backlogs [18:13:16] I'll be doing the diffusion/github part next [18:14:03] hauskatze: great! [18:14:10] * RhinosF1 loves how helpful everyone is [18:17:03] !log GitHub: Deleted mirror wikimedia/mediawiki-extensions-PopupPages refs. T251000 [18:17:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:17:06] T251000: Archive the PopupPages extension - https://phabricator.wikimedia.org/T251000 [18:32:51] hauskatze: just layout.yaml now [18:32:58] And we are using the archived template [18:33:39] Yup, saw hashar prefers to continue using it so be it [18:33:52] Yep [18:34:05] cannot merge on that repo so feel free to propose a patch for integration/config and let contint people do it [18:34:17] hauskatze: will do [18:34:23] Thanks for the help! [18:38:33] 10Phabricator (Upstream), 10Upstream: Time zones on Phabricator events are confusing - https://phabricator.wikimedia.org/T158910 (10EddieGP) https://secure.phabricator.com/T11816#218816 referred a seperate task for this problem, which is why I replied to the follow-up question there (https://secure.phabricator... [18:42:58] !log gerrit: replication start mediawiki/extensions/WikiShare --wait refs. T250400 [18:43:00] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:43:00] T250400: Unarchive mediawiki/extensions/WikiShare - https://phabricator.wikimedia.org/T250400 [18:48:01] Time to water some plants in the garden [18:51:49] (03PS1) 10Physikerwelt: Enable API tests for extension Math [integration/config] - 10https://gerrit.wikimedia.org/r/599963 (https://phabricator.wikimedia.org/T254031) [18:58:25] (03CR) 10Ppchelko: [C: 03+1] Enable API tests for extension Math [integration/config] - 10https://gerrit.wikimedia.org/r/599963 (https://phabricator.wikimedia.org/T254031) (owner: 10Physikerwelt) [18:59:51] 10Continuous-Integration-Config, 10Math, 10Patch-For-Review: Enable mediawiki-quibble-apitests-vendor-docker for extension Math - https://phabricator.wikimedia.org/T254031 (10RhinosF1) [19:11:25] 10Continuous-Integration-Config, 10Discovery-Search, 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Query-Service: Can we scrap the `wikidata/query/gui-deploy` repo, or is it being used? - https://phabricator.wikimedia.org/T254027 (10Jdforrester-WMF) [19:25:53] (03PS3) 10Jforrester: doc(scap.md): document when test-patches may fail surprisingly [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 (https://phabricator.wikimedia.org/T253999) (owner: 10Lars Wirzenius) [19:28:24] (03CR) 10Jforrester: [C: 03+2] doc(scap.md): document when test-patches may fail surprisingly [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 (https://phabricator.wikimedia.org/T253999) (owner: 10Lars Wirzenius) [19:29:55] (03CR) 10Jforrester: [C: 03+1] fix(targets.py): patterns with both ! and [] [tools/scap] - 10https://gerrit.wikimedia.org/r/599849 (owner: 10Lars Wirzenius) [19:30:22] (03Merged) 10jenkins-bot: doc(scap.md): document when test-patches may fail surprisingly [tools/scap] - 10https://gerrit.wikimedia.org/r/599884 (https://phabricator.wikimedia.org/T253999) (owner: 10Lars Wirzenius) [19:31:28] (03PS1) 10Jforrester: layout: [wikidata/query/gui-deploy] Drop unused experimental node 6 CI [integration/config] - 10https://gerrit.wikimedia.org/r/599971 (https://phabricator.wikimedia.org/T254027) [19:40:16] (03PS1) 10Jforrester: Move scap plugins from mediawiki-config into this repo [tools/scap] - 10https://gerrit.wikimedia.org/r/599973 (https://phabricator.wikimedia.org/T248490) [19:50:57] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-CollaborationKit: Undeploy the CollaborationKit extension from Wikipedia production - https://phabricator.wikimedia.org/T254036 (10Jdforrester-WMF) [20:52:26] (03CR) 10Thcipriani: [C: 03+2] "Nice bug find!" [tools/scap] - 10https://gerrit.wikimedia.org/r/599849 (owner: 10Lars Wirzenius) [20:54:36] (03Merged) 10jenkins-bot: fix(targets.py): patterns with both ! and [] [tools/scap] - 10https://gerrit.wikimedia.org/r/599849 (owner: 10Lars Wirzenius) [21:11:18] (03CR) 10Jforrester: "Ha." [integration/config] - 10https://gerrit.wikimedia.org/r/599130 (https://phabricator.wikimedia.org/T253335) (owner: 10Jforrester) [21:35:24] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] [stretch-php72] Stop using local fork of composer [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597841 (owner: 10Jforrester) [21:36:19] (03PS7) 10Brennen Bearnes: add stretch-php72-jobrunner for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) [21:47:06] (03PS1) 10RhinosF1: Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 [21:49:49] (03PS2) 10RhinosF1: Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 [21:50:04] can someone ^ [21:50:41] (03CR) 10jerkins-bot: [V: 04-1] Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (owner: 10RhinosF1) [21:51:05] (03PS3) 10RhinosF1: Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (https://phabricator.wikimedia.org/T251000) [21:52:05] I don't know why jerkins is moaning [21:52:09] (03CR) 10jerkins-bot: [V: 04-1] Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (https://phabricator.wikimedia.org/T251000) (owner: 10RhinosF1) [21:53:56] (03PS4) 10RhinosF1: Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (https://phabricator.wikimedia.org/T251000) [21:54:04] sneaky = sign [22:20:54] (03PS8) 10Brennen Bearnes: add stretch-php72-jobrunner for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) [22:36:08] (03CR) 10Jforrester: [C: 03+1] add stretch-php72-jobrunner for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) (owner: 10Brennen Bearnes) [22:36:28] (03CR) 10Jforrester: "Thoughts on this as a strategy? :-)" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) (owner: 10Jforrester) [22:36:40] (03PS1) 10Brennen Bearnes: mediawiki-xdebug: s/stretch-php72-apache2/mediawiki-xdebug/ in changelog [releng/dev-images] - 10https://gerrit.wikimedia.org/r/600031 [22:37:57] (03CR) 10Shirayuki: "Thank you!" [integration/config] - 10https://gerrit.wikimedia.org/r/598221 (owner: 10DannyS712) [22:43:55] (03CR) 10Jforrester: [C: 03+2] "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (https://phabricator.wikimedia.org/T251000) (owner: 10RhinosF1) [22:44:50] (03Merged) 10jenkins-bot: Archive PopupPages [integration/config] - 10https://gerrit.wikimedia.org/r/600005 (https://phabricator.wikimedia.org/T251000) (owner: 10RhinosF1) [22:46:31] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] "Self-merging this since it's extremely low-stakes and would otherwise have been a patch on the original changes here." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/600031 (owner: 10Brennen Bearnes) [22:46:36] !log Zuul: Archive mediawiki/extensions/PopupPages T251000 [22:46:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:46:39] T251000: Archive the PopupPages extension - https://phabricator.wikimedia.org/T251000 [22:46:51] (03CR) 10Jforrester: [C: 03+2] "Oops." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/600031 (owner: 10Brennen Bearnes) [22:46:57] James_F: ty [23:00:20] James_F: what was commit 600 000? [23:02:04] you can easily find that your self out! [23:02:08] change 31 -> 00 [23:03:31] paladox: i don’t have a clue what change 31 -> 00 means [23:03:40] in the url [23:05:04] found it [23:19:51] It's also linked in the blog post. [23:20:00] Not to be fussy or anything. ;-) [23:20:39] what blog post? [23:20:51] oh, found it [23:20:55] https://phabricator.wikimedia.org/phame/post/view/197/celebrating_600_000_commits_for_wikimedia/ [23:26:37] thanks [23:49:27] (03CR) 10Krinkle: "Does this mean the public ID used for the sniff in phpcs.xml files and phpcs:ignore rules will require changing?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [23:55:11] (03CR) 10DannyS712: "> Does this mean the public ID used for the sniff in phpcs.xml files" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712)