[00:15:59] Project mediawiki-core-doxygen-docker build #16255: 04FAILURE in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16255/ [01:00:51] 10phan, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10DannyS712) Occurs on WMF-deployed extensions [01:16:25] Yippee, build fixed! [01:16:25] Project mediawiki-core-doxygen-docker build #16256: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16256/ [01:32:04] 10phan, 10phan-taint-check-plugin: Argument 1 passed to PreTaintednessVisitor::linkParamAndFunc() must be an instance of Phan\Language\Element\Variable, instance of Phan\Language\Element\Property given - https://phabricator.wikimedia.org/T254085 (10Reedy) [01:32:37] 10phan, 10phan-taint-check-plugin: Argument 1 passed to PreTaintednessVisitor::linkParamAndFunc() must be an instance of Phan\Language\Element\Variable, instance of Phan\Language\Element\Property given - https://phabricator.wikimedia.org/T254085 (10DannyS712) [01:32:39] 10phan, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10DannyS712) [01:33:20] 10LibUp: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Reedy) [01:35:22] 10LibUp: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Reedy) [01:37:30] 10LibUp, 10Patch-For-Review: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Reedy) braces > indenting [01:43:30] 10phan, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Reedy) p:05Triage→03High [01:43:46] 10phan, 10phan-taint-check-plugin, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Reedy) [01:46:42] 10LibUp, 10Patch-For-Review: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Reedy) Just needs deploying now... But probably too late for this run anyway? [03:53:37] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [04:25:14] 10Continuous-Integration-Config, 10Vue.js (Vue.js-Search): Install Jest for unit tests for Vue.js search - https://phabricator.wikimedia.org/T249301 (10Niedzielski) [06:51:08] 10LibUp, 10Patch-For-Review: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Legoktm) Thanks for fixing :) >>! In T254086#6179546, @Reedy wrote: > Just needs deploying now... But probably too late for this run anyway? Done. Any repo processed after now-ish will... [06:51:44] 10LibUp, 10Patch-For-Review: Library upgrader says it did something it didn't - https://phabricator.wikimedia.org/T254086 (10Legoktm) 05Open→03Resolved a:03Reedy [07:05:21] (03CR) 10Legoktm: [C: 04-2] "See Ibd77c99d1d345a2c4611cc52a0a8b5de05c194da and my comment on the bug." [integration/config] - 10https://gerrit.wikimedia.org/r/600403 (https://phabricator.wikimedia.org/T254070) (owner: 10DannyS712) [07:07:50] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Legoktm) We disabled libup from the "test" queue because most patches automatically get +2'd, causing a duplicate test run in both test and gate-and-submit, unnecessarily... [07:09:15] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10DannyS712) >>! In T254070#6179618, @Legoktm wrote: > We disabled libup from the "test" queue because most patches automatically get +2'd, causing a duplicate test run in b... [07:10:12] 10LibUp: Unhandled rejection Error: EACCES: permission denied, mkdir '/cache' - https://phabricator.wikimedia.org/T249552 (10Legoktm) You have to add `/cache` as a volume, sometimes I do something like `~/.cache:/cache` so it shares my host's composer/npm caches. But even a throwaway directory like `/tmp/cache:/... [07:23:38] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Legoktm) >>! In T254070#6179620, @DannyS712 wrote: > Is there a way for it to run test only when it doesn't get a +2 automatically? Something like adding a custom trigger... [07:53:30] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10DannyS712) >>! In T254070#6179634, @Legoktm wrote: >>>! In T254070#6179620, @DannyS712 wrote: >> Is there a way for it to run test only when it doesn't get a +2 automatica... [09:42:19] 10phan-taint-check-plugin, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) a:03Daimona I have seen this sometimes locally. Note that this issue was already fixed in taint-check 3.0.x ([[ https://gerrit.wikimedia... [09:58:53] 10phan-taint-check-plugin, 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) It took me a long time to set up taint-check 2.0.1, fix incompatibilities etc., but I finally got it. The faulty method is HookRunner::onG... [11:03:49] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10DannyS712) [11:05:34] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Reedy) >>! In T254070#6179618, @Legoktm wrote: > We disabled libup from the "test" queue because most patches automatically get +2'd, causing a duplicate test run in both... [11:17:46] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) 05Open→03Resolved [11:18:25] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) I'm calling this resolved, but this issue may arise again. Upgrading taint-check is the onl... [11:23:34] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10DannyS712) So I poked Jenkins to retry some of the ones that failed. Some now pass and have merged:... [11:26:49] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) 05Resolved→03Open ...QED [11:37:09] 10Continuous-Integration-Config, 10LibUp, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan, and 3 others: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin - https://phabricator.wikimedia.org/T248630 (10Reedy) [11:37:11] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Reedy) [11:38:22] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10Daimona) >>! In T254079#6179830, @DannyS712 wrote: > * https://gerrit.wikimedia.org/r/#/c/mediawiki/... [11:49:42] 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), 10User-DannyS712, 10ci-test-error (WMF-deployed Build Failure): phan-seccheck typeerror - https://phabricator.wikimedia.org/T254079 (10DannyS712) Found some others as well [16:30:12] 10phan: mwext-php72-phan-docker should fail when warnings are printed - https://phabricator.wikimedia.org/T254103 (10Aklapper) [17:00:43] 10Phabricator, 10I18n: Translation of phabricator iwas not deployed correctly in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Eduaddad)