[00:01:49] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10Zoranzoki21) Mobile view no works per default, but there is option... [01:14:48] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Reedy) ^ What's the expection of mobile browsing of this site? [01:19:40] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10Reedy) >>! In T254185#6187194, @Zoranzoki21 wrote: > Mobile view n... [03:07:59] (03PS1) 10Jforrester: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 [03:08:01] (03PS1) 10Jforrester: layout: Expand node10-browser-docker and apply liberally [integration/config] - 10https://gerrit.wikimedia.org/r/601931 [03:08:03] (03PS1) 10Jforrester: jjb: Drop {visualeditor,unicodejs,oojs-{core,router}}-node10-browser-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601932 [03:09:05] (03CR) 10jerkins-bot: [V: 04-1] layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [03:09:08] (03CR) 10jerkins-bot: [V: 04-1] layout: Expand node10-browser-docker and apply liberally [integration/config] - 10https://gerrit.wikimedia.org/r/601931 (owner: 10Jforrester) [03:09:10] (03CR) 10jerkins-bot: [V: 04-1] jjb: Drop {visualeditor,unicodejs,oojs-{core,router}}-node10-browser-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601932 (owner: 10Jforrester) [03:14:44] (03PS2) 10Jforrester: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 [03:14:46] (03PS2) 10Jforrester: layout: Expand node10-browser-docker and apply liberally [integration/config] - 10https://gerrit.wikimedia.org/r/601931 [03:14:48] (03PS2) 10Jforrester: jjb: Drop {visualeditor,unicodejs,oojs-{core,router}}-node10-browser-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601932 [03:16:08] (03CR) 10jerkins-bot: [V: 04-1] layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [05:50:48] 10Continuous-Integration-Config, 10Core Platform Team, 10Math: Enable mediawiki-quibble-apitests-vendor-docker for extension Math - https://phabricator.wikimedia.org/T254031 (10Physikerwelt) a:05Physikerwelt→03None >>! In T254031#6186517, @eprodromou wrote: > We think this is big enough that it should be... [06:21:01] 10Project-Admins, 10Math, 10PM: Organize the open tasks for Project Math - https://phabricator.wikimedia.org/T239359 (10Physikerwelt) @Aklapper sorry for the long silence. Could you please remove the columns you mentioned? I could not find a button for that. Looking at all the columns I think labels are suff... [07:58:08] 10Project-Admins, 10Math, 10PM: Organize the open tasks for Project Math - https://phabricator.wikimedia.org/T239359 (10Aklapper) >>! In T239359#6187580, @Physikerwelt wrote: > Could you please remove the columns you mentioned? I could not find a button for that. No problem. :) @Physikerwelt: [You can hide... [08:42:16] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10jcrespo) a:05jcrespo→03QChris Recovery took 20 minutes, I chose the full one we took for testing yesterday, but remember we have hourly backups: https://grafana.wikimedia.org/d/413r2vbWk/bacula?org... [09:40:29] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10Dzahn) >>! In T254162#6184536, @jcrespo wrote: > Bacula has its own consistency model that may not be compatible with git consistency model, I want to put that to the test/enquire if lvm snapshoting wo... [10:05:43] 10Project-Admins, 10User-Zoranzoki21: Project Creation request: Cronos (WMCH) - https://phabricator.wikimedia.org/T252768 (10Nicolas_NALLET) yes done sorry cheers [10:32:45] 10Project-Admins, 10User-DannyS712: Archive #Room-101 - https://phabricator.wikimedia.org/T254336 (10DannyS712) [10:46:02] 10Release-Engineering-Team: Add pycurl dependencies to tox-docker - https://phabricator.wikimedia.org/T254338 (10Gilles) [10:47:03] 10Release-Engineering-Team: Add pycurl dependencies to tox-docker - https://phabricator.wikimedia.org/T254338 (10Gilles) [11:04:31] 10Release-Engineering-Team: Add pycurl dependencies to tox-docker - https://phabricator.wikimedia.org/T254338 (10Gilles) [11:05:00] 10Project-Admins, 10User-DannyS712: Archive #Room-101 - https://phabricator.wikimedia.org/T254336 (10Aklapper) Right. And nobody knows why this would be a "room" [called "101", except for a few cultures](https://en.wikipedia.org/wiki/101_(topic)) out there. Hence only insiders would ever be able find this tag.... [11:08:18] 10Project-Admins, 10User-DannyS712: Archive #Room-101 - https://phabricator.wikimedia.org/T254336 (10DannyS712) >>! In T254336#6188294, @Aklapper wrote: > Right. And nobody knows why this would be a "room" [called "101", except for a few cultures](https://en.wikipedia.org/wiki/101_(topic)) out there. Hence onl... [11:12:24] 10Release-Engineering-Team: Add pycurl dependencies to tox-docker - https://phabricator.wikimedia.org/T254338 (10Aklapper) (Should this be tagged #Continuous-Integration-Config or which code area is this under?) [11:42:42] 10Continuous-Integration-Infrastructure, 10Bridge Technical Improvements: Authenticate github API requests in CI - https://phabricator.wikimedia.org/T254319 (10hashar) I have no idea how the token has been generated for T248387 Presumably we could have CI to expose it the same token as `GITHUB_OAUTHTOKEN`? [11:43:40] 10LibUp, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Legoktm) 05Open→03Resolved Worked perfectly: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceFoundation/+/601928 Thank you @DannyS712 :) [11:48:24] 10LibUp, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10DannyS712) >>! In T254070#6188406, @Legoktm wrote: > Worked perfectly: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceFoundation/+/601928 > > Thank you @DannyS712 :) Happy to... [12:35:15] some random(?) selenium tests are failing with timeout [12:41:02] I don't see anything obviously wrong [12:46:55] there are 7 jobs running, it doesn't appear to be overloaded [12:47:07] https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/ [12:47:45] example 1: https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/42370/console [12:47:46] the ones that failed didn't make it very far [12:49:21] example 2: https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/12768/console [12:49:47] seems quite intermittent [12:49:59] yeah but it's failing in the exact same place [12:50:18] or no not exact [12:52:20] maybe 60 seconds is too short of a timeout [12:53:03] there is a lot of "ffmpeg exited with code 255 " but that seems to be happening even with successful runs? [12:53:04] weird [12:58:01] hey guys, any reason for the docker registry URL is returning 404? cc/ thcipriani James_F [12:58:19] Is that only me? here is the link https://docker-registry.wikimedia.org/wikimedia/mediawiki-services-push-notifications:latest [12:58:59] eh.. i can confirm there is the nginx default page on the index [12:59:03] i will ping somebody [12:59:08] in a minute [12:59:08] I'm trying to get the images for the push-notifications service to run local deployment-charts setup [12:59:15] mutante: thanks [13:00:06] doesn't look like there's a latest tag for that image: https://tools.wmflabs.org/dockerregistry/wikimedia/mediawiki-services-push-notifications/tags/ [13:00:14] we don't usually tag one through the pipeline [13:00:47] this works for me, FWIW: docker pull docker-registry.wikimedia.org/wikimedia/mediawiki-services-push-notifications:2020-06-02-143205-publish [13:03:33] mateusbs17: in a meeting. i hear it's a blubber problem [13:03:37] see what thcipriani said above [13:03:54] thanks mutante and thcipriani [13:03:58] mateusbs17: also see https://meet.google.com/linkredirect?authuser=0&dest=https%3A%2F%2Fdocker-registry.wikimedia.org%2Fv2%2Fwikimedia%2Fmediawiki-services-push-notifications%2Ftags%2Flist [13:04:22] mateusbs17: eh, i mean https://docker-registry.wikimedia.org/v2/wikimedia/mediawiki-services-push-notifications/tags/list [13:04:27] there is no latest tag [13:04:53] Setting specific tags works for now, although the default charts expect a latest version but I lack knowledge here [13:09:40] (03PS2) 10Hashar: layout: [VisualEditor/VisualEditor] Drop visualeditor-rake-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601862 (owner: 10Jforrester) [13:10:09] (03CR) 10Hashar: [C: 03+2] "Amended the commit message to give some detail. I am dropping right now since the job hasn't triggered since at least Jan 12, 2018" [integration/config] - 10https://gerrit.wikimedia.org/r/601862 (owner: 10Jforrester) [13:10:21] (03PS2) 10Hashar: jjb: Drop visualeditor-rake-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/601863 (owner: 10Jforrester) [13:10:23] (03CR) 10Hashar: [C: 03+2] jjb: Drop visualeditor-rake-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/601863 (owner: 10Jforrester) [13:11:05] (03Merged) 10jenkins-bot: layout: [VisualEditor/VisualEditor] Drop visualeditor-rake-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601862 (owner: 10Jforrester) [13:11:26] (03Merged) 10jenkins-bot: jjb: Drop visualeditor-rake-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/601863 (owner: 10Jforrester) [14:05:21] 10Continuous-Integration-Infrastructure, 10Bridge Technical Improvements: Authenticate github API requests in CI - https://phabricator.wikimedia.org/T254319 (10Pablo-WMDE) > Presumably we could have CI to expose it the same token as GITHUB_OAUTHTOKEN? No objection. We could remove the purpose from the name (a... [14:11:22] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Toolforge, 10Kubernetes, 10cloud-services-team (Kanban): Change to admission controller readme.md failed to pass gate-and-submit jobs - https://phabricator.wikimedia.org/T254293 (10thcipriani) The path to the actual er... [14:20:55] 10Continuous-Integration-Infrastructure, 10Bridge Technical Improvements: Authenticate github API requests in CI - https://phabricator.wikimedia.org/T254319 (10Lucas_Werkmeister_WMDE) To me a general `GITHUB_OAUTHTOKEN` sounds good, as long as it doesn’t have any sensitive permissions (we probably don’t want t... [14:57:04] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10apaskulin) > And relatedly... Yes, the developed skin is going to be the default.. But do we want to al... [14:58:58] 10Beta-Cluster-Infrastructure, 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green), 10Patch-For-Review, and 2 others: Create new wiki on the beta cluster to test API Portal - https://phabricator.wikimedia.org/T254185 (10apaskulin) Per my comment on T246945, the mobile view in the scree... [15:02:54] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: (Service Check Timed Out) [15:07:48] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 95970 bytes in 1.208 second response time [15:43:54] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) p:05Triage→03Medium [15:44:07] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10QChris) >>! In T254162#6187911, @jcrespo wrote: > Recovery took 20 minutes, [...] Nice! > **Content of everything backed up on `gerrit1001` was restored into `gerrit2001:/srv/T254162_restore`.** I w... [15:50:24] (03PS1) 10Pablo Grass (WMDE): doc: wikibase: add dist-size for bridge & tainted ref [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) [15:52:20] hashar: Hey. Is there any chance you could look at Quibble reviews? You abandonned all my reverts, and until we can get to a post-41 Quibble we're wasting a lot of CPU time on double-running @standalone tests. :-( Or should I just do a branch/backport and create a 0.0.41a? [15:52:40] (03CR) 10Pablo Grass (WMDE): "This change is ready for review." [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [15:52:50] James_F: yeah by end of tihs weeks [15:53:04] my kids are at school tomorrow and the day after so I will get plenty of hacking time ;) [15:53:11] Ha. Cool. :-) [15:53:13] most probably I will revert bunch of stuff [15:53:19] Ack. [15:53:33] I can un-abandon my reverts if you want. :-) [15:55:06] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Create buster-based images for quibble - https://phabricator.wikimedia.org/T250514 (10Jdforrester-WMF) [15:55:08] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: upgrade MediaWiki appservers to Debian 10 (buster) - https://phabricator.wikimedia.org/T245757 (10Jdforrester-WMF) [15:55:27] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] doc: wikibase: add dist-size for bridge & tainted ref [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [15:57:17] (03CR) 10Tonina Zhelyazkova: [C: 03+1] doc: wikibase: add dist-size for bridge & tainted ref [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [15:58:06] Gah. Not only does buster insist on it being called Chromium, not Chrome, in chromedriver, but instead of being chromiumdriver it's chromium-driver. [15:58:13] Yay for special snowflakes. [16:02:41] inb4 iceweaseldriver [16:02:59] No thank you. I want to run a performant browser stack in CI. ;-P [16:03:32] Also knowing Debian it'd be weasel_ice-driver-pkg aliased to something else. ;-) [16:03:50] Woohoo, finally: [16:03:50] Successfully tagged docker-registry.wikimedia.org/releng/quibble-buster-php72:0.0.44 (image.py:179) [16:04:01] James_F: I have first have to review awight changes [16:04:08] hashar: SUre. [16:04:15] I mean the ones that got merged [16:04:32] then either I approve the fix he proposed, or I revert the faulty changes and we come with a nicer solution ;] [16:04:51] * James_F nods. [16:05:14] Lucas_WMDE: it is geckodriver https://github.com/mozilla/geckodriver/releases :) [16:05:20] written in rust iirc [16:05:55] I’m just glad that Mozilla/Debian rebranding issue was buried a few years ago :D [16:05:58] Naturlich. 🙄 [16:06:10] definitely! [16:11:28] (03PS2) 10Jforrester: dockerfiles: Provide quibble-buster-php72, based on Sury not Wikimedia PHP [integration/config] - 10https://gerrit.wikimedia.org/r/589673 (https://phabricator.wikimedia.org/T250514) [16:11:46] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Provide quibble-buster-php72, based on Sury not Wikimedia PHP [integration/config] - 10https://gerrit.wikimedia.org/r/589673 (https://phabricator.wikimedia.org/T250514) (owner: 10Jforrester) [16:11:58] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10jcrespo) > There were a few inconsistencies between the currently live data on gerrit1001 and the restored data, but those are expected. Of course, there is a 24 hours gap. My question is if there wou... [16:12:49] (03Merged) 10jenkins-bot: dockerfiles: Provide quibble-buster-php72, based on Sury not Wikimedia PHP [integration/config] - 10https://gerrit.wikimedia.org/r/589673 (https://phabricator.wikimedia.org/T250514) (owner: 10Jforrester) [16:13:11] argh [16:13:15] ? [16:13:23] James_F: i kind of wanted to drop our dependency upon sury.org [16:13:48] hashar: OK, but SRE said to use Sury (and that's what they use). [16:14:02] the repo also provides a bunch of more updated libraries (such as libpcre iirc) which do not match what is in Debian [16:14:05] Getting PHP 7.2 on buster is hard. Buster really, really wants you to use 7.3. [16:15:11] then it would be nice to check with them what is the .plan for php or OS upgrade [16:15:26] They said they weren't looking at the buster migration for a long while. [16:15:28] like either we do stretch > buster and we gotta port 7.2 to buster [16:15:39] or we upgrade to 7.3 on stretch and then move to buster [16:16:09] 🤷🏽‍♂️ [16:16:24] seems Stretch is EOL in two years so yeah [16:16:50] I can imagine Buster get skipped entirely ;D [16:16:53] Theoretically https://wikitech.wikimedia.org/wiki/Operating_system_upgrade_policy means we should have all stretch removed by June 2021. [16:17:09] Most of the non-app servers have already made it to buster. [16:18:14] !log Updating dev-images docker-pkg files on primary contint [16:18:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:18:34] I hate those version issues bah :-\ [16:18:38] Yeah. :-( [16:19:02] anyway what is the use case for Quibble to run under Buster? [16:19:15] Did you forget the meeting where we agreed to do this? :-) [16:19:42] Mostly, a not-ancient version of Chromium, so we can run all the selenium jobs on that (but everything else still on stretch). [16:19:50] OH true [16:19:57] Then in the future when production is getting close to buster, we will run both in parallel. [16:20:03] yeah yeah [16:20:06] And then drop stretch CI ASAP when production switches. [16:20:15] OK, publishing. [16:20:19] so a Quibble on Buster would bring us latest chromium and we can move the selenium tests and qunit tests to that [16:20:26] Yeah. [16:20:27] Well. [16:20:31] dockerfiles/quibble-buster/Dockerfile.template: && pip3 install git+https://gerrit.wikimedia.org/r/p/integration/quibble.git@"${LATEST_TAG}"#egg=quibble \ [16:20:31] Probably not qunit. [16:20:36] They're not sensitive. [16:20:45] !log Docker: Publishing docker-registry.discovery.wmnet/releng/quibble-buster-php72 [16:20:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:21:17] Meh, I should have normalised that to a pinned version. [16:21:19] Next time. [16:21:45] yeah possibly [16:21:57] The probably with patches from two months ago. [16:21:57] all jobs are pinned to 0.0.41 for now [16:22:19] Yes, but I won't be using these in reality until 0.0.44 comes out anyway. [16:22:32] ;D [16:22:40] Which is hopefully soon… ;-P [16:23:19] well I will check those quibble changes tomorrow [16:23:25] Thank you. [16:23:31] But it's important you don't burn out. [16:23:33] hopefully make sense of those and come out with a plan [16:23:42] And also that we make the right decision, not just the fast one. :-) [16:23:49] well worse thing, I just rollback the 3 or 4 patches and we can back to last good state [16:24:11] Yeah, that was my plan. [16:26:17] speaking of Qunit, I think we always run it [16:26:31] maybe we can move them to the selenium job to avoid running them once per php version [16:26:41] Maybe. [16:26:47] ;D [16:26:54] But I'm reworking all the quibble job names and groups anyway. [16:27:11] we can drop the -docker suffix while at it [16:27:12] Balance between the number of jobs and the length of jobs. [16:27:47] hashar: Preview of the new jobs at 596668 ;-) [16:28:00] !g 596668 [16:28:05] bah [16:28:47] http://gerrit.wikimedia.org/r/c/596668 [16:43:51] (03CR) 10Hashar: [C: 03+2] "Looks nice, that is worth a nice blog post somewhere :]" [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [16:44:41] (03Merged) 10jenkins-bot: doc: wikibase: add dist-size for bridge & tainted ref [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [16:47:38] (03CR) 10Hashar: [C: 03+2] "Deployed. https://doc.wikimedia.org/ might still serve an old cached version though but it will expire after at most 30 minutes." [integration/docroot] - 10https://gerrit.wikimedia.org/r/602109 (https://phabricator.wikimedia.org/T253204) (owner: 10Pablo Grass (WMDE)) [17:12:50] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-Release-Tools, 10EngProd-Virtual-Hackathon: Automate weekly branch cut - https://phabricator.wikimedia.org/T196517 (10mmodell) 05Open→03Resolved [17:12:52] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Epic, 10Goal: Automate the Train - https://phabricator.wikimedia.org/T196515 (10mmodell) [17:48:51] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Create buster-based images for quibble - https://phabricator.wikimedia.org/T250514 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [17:48:53] 10Continuous-Integration-Infrastructure, 10Browser-Tests: Split out all selenium test runs into a buster-based job that runs newer Chromium - https://phabricator.wikimedia.org/T250513 (10Jdforrester-WMF) [17:48:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Quibble: Test MW code in buster as well as stretch - https://phabricator.wikimedia.org/T252434 (10Jdforrester-WMF) [18:25:08] 10Gerrit: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T254384 (10MarcoAurelio) [18:26:29] 10Gerrit: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T254384 (10MarcoAurelio) Service: https://gerrit.wikimedia.org/r/#/admin/groups/1597,members (wmde-mediawiki members) [18:28:32] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T254384 (10WMDE-leszek) [18:29:02] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T254384 (10WMDE-leszek) [18:34:04] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [18:36:12] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-ShortUrl, 10Code-Stewardship-Reviews: Code Stewardship Review: ShortUrl Extension - https://phabricator.wikimedia.org/T187045 (10kaldari) [18:36:59] Is there any chance merge without review could be turned off for labs/tools/zppixbot [18:37:40] You mean, only allow CI merging? [18:37:52] Or direct pushes? [18:38:01] *Or disable direct pushes? [18:39:02] Only allow merge if there’s a CR+2,V+2 [18:39:32] Well, if you let users grant V+2, it does nothing [18:39:39] True [18:39:45] At least CR+2 [18:44:01] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [18:50:19] (03PS1) 10MarcoAurelio: [AzharAuth] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/602129 (https://phabricator.wikimedia.org/T198601) [18:53:42] Reedy: i want it so https://gerrit.wikimedia.org/r/#/q/dbf0fa54da35f3e58e411397accce9f45896d713 doesnt happen again where our new dev used git push instead of git-review and merged the change uploading the patchset accidently [18:54:19] https://gerrit.wikimedia.org/r/#/admin/projects/labs/tools/ZppixBot,access [18:54:26] I guess remove submit from everyone but CI [18:54:45] well, as long as CI does gate and submit for you [18:56:09] Reedy: is there a gate-and-submit for html+css [18:57:27] !log GitHub: Mirror deleted: mediawiki-extensions-AzharAuth | refs. T198601 [18:57:29] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:57:29] T198601: Archive the AzharAuth extension - https://phabricator.wikimedia.org/T198601 [18:59:43] sounds like you should revoke pushing? [19:00:24] paladox: that’s my plan, I need something that can push via CI first [19:00:33] That runs on html+css [19:01:36] you can probably do some basic linting [19:02:05] How? [19:02:16] * RhinosF1 finds CI mind-boggling [19:21:54] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Jdforrester-WMF) [19:29:25] (03PS2) 10Kosta Harlan: [codehealth] Add MachineVision to pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/596059 [19:30:32] James_F: would it be possible to deploy ^ sometime, I'm curious especially to see if the JS code coverage report goes cleanly into SonarQube [19:31:02] Sure. [19:31:07] (03CR) 10Jforrester: [C: 03+2] [codehealth] Add MachineVision to pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/596059 (owner: 10Kosta Harlan) [19:32:04] Any idea about html+css linting checks via ci [19:32:10] (03Merged) 10jenkins-bot: [codehealth] Add MachineVision to pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/596059 (owner: 10Kosta Harlan) [19:35:52] RhinosF1: as far as CI is involved, I guess it would just run "npm test" or "composer test" ;D [19:36:19] hashar: if they can check html+css is sane, yes? [19:36:37] that would depend on some library to do the task, and I don't know any unfortunately :-\ [19:36:44] might be worth asking on wikitech-l [19:36:47] Ah [19:37:26] * RhinosF1 wonders why people can’t just be trusted with submit access to not blow anything up [19:37:39] it is not much about trustiness [19:37:49] but humans do make mistakes :] [19:38:07] True [19:38:26] once upon a time, we had people manually reviewing html/css/code to make sure no issues occured [19:38:36] They forgot git-review existed [19:38:39] and it is now more or less automated which let human focus on the bigger picture [19:38:42] ;) [19:38:53] I’m manually testing now on our test instance [19:39:16] Got one bug somewhere with the font awesome left [19:40:34] for css, mediawiki/core seems to use https://www.npmjs.com/package/postcss [19:41:28] that refers some linters [19:41:47] That could work if we can check html [19:42:06] ahh [19:42:13] npm package stylelint :] [19:42:33] How would we get it to run? [19:43:21] apparently: https://github.com/stylelint/stylelint/blob/HEAD/docs/user-guide/get-started.md [19:43:42] then: npm run stylelint "**/*.css" [19:45:24] Via jenkins though? [19:45:28] for html i have no clue. Mediawiki used tidy at some point [19:45:38] but that got removed in favor of our own HTML parser: https://packagist.org/packages/wikimedia/remex-html [19:45:58] for jenkins, gotta add a job that runs npm test and/or a job that runs composer test [19:46:24] I’ll create a phab task [19:46:30] yeah :] [19:46:42] against #continuous-integration-config [19:46:50] Coming up [19:47:25] kostajh: Oops, sorry, didn't deploy. [19:47:41] !log Zuul: [mediawiki/extensions/MachineVision] Add codehealth. [19:47:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:47:48] Done now. [19:50:50] 10Continuous-Integration-Config, 10Tool-Zppixbot: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) [19:51:14] 10Continuous-Integration-Config, 10Tool-Zppixbot: Add CI tests for labs/tools/zppixbot - https://phabricator.wikimedia.org/T254393 (10RhinosF1) Once this is added, please revoke submit for non-CI. [19:51:23] hashar: ^ [19:55:18] James_F: thanks! [20:08:34] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10QChris) 05Open→03Resolved >>! In T254162#6189550, @jcrespo wrote: > My question is if there would be issues with seting up the service from that dump, if they would be internally consistent, even i... [20:08:36] 10Gerrit: Make sure we backup Gerrit's LFS data - https://phabricator.wikimedia.org/T254155 (10QChris) [20:08:58] 10Gerrit: Make sure we backup Gerrit's LFS data - https://phabricator.wikimedia.org/T254155 (10QChris) 05Open→03Resolved a:03QChris [20:09:00] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [20:31:59] (03CR) 10Hashar: [C: 03+2] "Thank you!" [integration/config] - 10https://gerrit.wikimedia.org/r/602129 (https://phabricator.wikimedia.org/T198601) (owner: 10MarcoAurelio) [20:32:58] (03Merged) 10jenkins-bot: [AzharAuth] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/602129 (https://phabricator.wikimedia.org/T198601) (owner: 10MarcoAurelio) [20:51:51] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10CPT Initiatives (API Integration Tests), 10Code-Health, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): Enable API integration tests in CI for MediaWiki core - https://phabricator.wikimedia.org/T236680 (10nnikkhoui) [21:53:11] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Jdforrester-WMF) [21:59:30] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Developer Productivity: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10Krinkle) [21:59:50] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Jdforrester-WMF) I thought we were doing T200739 and then this one. Is that not the case any more [22:02:21] 10Phabricator: Limit mass-adding subscribers on Phabricator - https://phabricator.wikimedia.org/T254409 (10Yair_rand) [22:04:19] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) @Jdforrester-WMF from what i understand we're going straight to 3.1. [22:31:05] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T254384 (10Legoktm) 05Open→03Resolved a:03Legoktm Done. > In T237101#5710802 I was advised to preferably contact Gerrit admins directly instead of using Phabricator. As there is... [22:45:59] (03CR) 10Jforrester: "> Patch Set 3:" [integration/config] - 10https://gerrit.wikimedia.org/r/599963 (https://phabricator.wikimedia.org/T254031) (owner: 10Physikerwelt) [23:04:18] hey folks, I'm struggling to get CI running on a handful of patches in a chain starting with this one https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/593316/ I've tried readding jenkins and "recheck" but not seeing anything in Zuul [23:04:56] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Developer Productivity: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10mmodell) Maybe caused by [[ https://github.com/jenkinsci/ansicolor-plugin/issues/186 | jenkinsci/ansicolor-plugi... [23:19:14] 10Gerrit, 10MediaWiki-General: Add pre-commit hook that does basic checks like php -l - https://phabricator.wikimedia.org/T201778 (10bd808) >>! In T201778#5152398, @Simetrical wrote: > > It might make sense as a repo that's installed by composer, which could then be used by other projects that use composer al... [23:20:12] Project beta-update-databases-eqiad build #42618: 04FAILURE in 10 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42618/ [23:31:59] jgleeson: I wonder if Zuul is confused because you have a dependency loop. That patch has a Depends-On header in the commit message that points to its next sibling in the chain. [23:33:35] jgleeson: I think you may need to rebase your chain so that https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/594330/ comes before https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/593316/ [23:33:49] ahhhhh [23:33:56] thanks bd808 I'll give it a go [23:34:03] I missed that Depends-On tag [23:42:38] bd808: thanks man! [23:42:53] all better? [23:43:17] yep it looks like CI is running as expected :) [23:43:32] awesome :)