[00:13:00] Yippee, build fixed! [00:13:01] Project mediawiki-core-doxygen-docker build #16376: 09FIXED in 8 min 29 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16376/ [04:19:05] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) Filed at https://github... [07:35:59] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [07:38:17] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10hashar) p:05Triage→03Medium [07:40:14] (03CR) 10Hashar: [C: 03+2] layout: Add extension-CatTalk to zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602505 (owner: 10MarcoAurelio) [07:41:43] (03Merged) 10jenkins-bot: layout: Add extension-CatTalk to zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602505 (owner: 10MarcoAurelio) [07:45:34] !log jenkins: upgrading ansicolor plugin 0.6.3 > 0.7.0 # T254408 [07:45:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:45:36] T254408: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 [07:46:01] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [07:51:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, 10Jenkins: ASCI escape codes shown literally in Jenkins build output - https://phabricator.wikimedia.org/T254408 (10hashar) 05... [08:27:13] 10Project-Admins, 10Bengali-Sites: Create a generic "Bengal-Wikisource" tag in Phabricator - https://phabricator.wikimedia.org/T254555 (10Jony) [08:27:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Python3-Porting: Upgrade integration/config to use Fabric 2.x / python3 - https://phabricator.wikimedia.org/T236689 (10hashar) >>! In T236689#5846956, @Legok... [08:34:43] 10Project-Admins, 10Bengali-Sites: Create a generic "Bengal-Wikisource" tag in Phabricator - https://phabricator.wikimedia.org/T254555 (10MarcoAurelio) I am against creating edition-specific tags or we risk having 700+ of those, further fragmenting and complicating Phabricator project maintenance. A workboard... [08:37:32] 10Project-Admins, 10User-DannyS712: Create #mediawiki-namespaces - https://phabricator.wikimedia.org/T249998 (10MarcoAurelio) Rather than a tag I think a component project of the type listed at https://phabricator.wikimedia.org/project/view/135/ would better align with the current schema. [08:38:42] 10Project-Admins, 10User-DannyS712: Create #mediawiki-namespaces - https://phabricator.wikimedia.org/T249998 (10DannyS712) >>! In T249998#6195413, @MarcoAurelio wrote: > Rather than a tag I think a component project of the type listed at https://phabricator.wikimedia.org/project/view/135/ would better align wi... [08:39:30] (03PS3) 10Hashar: [WIP] Port fabfile.py to fabric 2 / Python 3 [integration/config] - 10https://gerrit.wikimedia.org/r/569703 (https://phabricator.wikimedia.org/T236689) (owner: 10Legoktm) [08:39:51] (03CR) 10Hashar: "Rebased to fix conflicts due to:" [integration/config] - 10https://gerrit.wikimedia.org/r/569703 (https://phabricator.wikimedia.org/T236689) (owner: 10Legoktm) [08:40:07] 10Project-Admins: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10MarcoAurelio) Docs on mediawiki and development already happening on Gerrit, so done: #mediawiki-extensions-cattalk created. [08:40:16] 10Project-Admins, 10User-MarcoAurelio: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10MarcoAurelio) 05Open→03Resolved a:03MarcoAurelio [08:54:10] 10Project-Admins, 10Bengali-Sites: Create a generic "Bengal-Wikisource" tag in Phabricator - https://phabricator.wikimedia.org/T254555 (10Aklapper) 05Open→03Declined This task lacks a use case and a scope. The "project description" does not make sense either as it is as generic. See also T154549, T40994,... [09:10:41] (03CR) 10Hashar: "> Trying this out throws "sudo: cd: command not found"…" [integration/config] - 10https://gerrit.wikimedia.org/r/569703 (https://phabricator.wikimedia.org/T236689) (owner: 10Legoktm) [09:40:26] (03PS1) 10MarcoAurelio: layout: Whitelist Naypta on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602628 [09:49:39] (03CR) 10Hashar: [C: 03+2] layout: Whitelist Naypta on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602628 (owner: 10MarcoAurelio) [09:50:34] (03Merged) 10jenkins-bot: layout: Whitelist Naypta on zuul [integration/config] - 10https://gerrit.wikimedia.org/r/602628 (owner: 10MarcoAurelio) [10:03:57] 10Continuous-Integration-Config, 10Vue.js (Vue.js-Search): Install Jest for unit tests for Vue.js search - https://phabricator.wikimedia.org/T249301 (10Anribolon) a:03Anribolon [10:25:40] 10Continuous-Integration-Config: JsonConfig needs Scribunto for extension-gate - https://phabricator.wikimedia.org/T153160 (10hashar) 05Open→03Resolved a:03hashar I am not sure what the task was about. JsonConfig is in the gate since 2014 and Scribunto got added recently. I have confirmed that the tests a... [10:27:54] 10Continuous-Integration-Config, 10phan-taint-check-plugin: Drop taint-check jobs for CI once migration to mediawiki-tools-phan is complete - https://phabricator.wikimedia.org/T254152 (10Daimona) a:03Jdforrester-WMF Something was already done with: - https://gerrit.wikimedia.org/r/#/c/integration/config/+/6... [10:33:47] 10Continuous-Integration-Config: Jenkins didn't pickup failure in library - https://phabricator.wikimedia.org/T185260 (10hashar) 05Open→03Resolved a:03hashar The typo is in `RelPath\\joinPath` The test got changed to invoke `\Wikimedia\RelPath::joinPath`. Or to say it otherwise, there was not test to co... [10:36:53] 10Continuous-Integration-Config: Add test to verify that a extension is running composer tests when the dependency is also running composer test - https://phabricator.wikimedia.org/T189310 (10hashar) 05Open→03Resolved a:03hashar All BlueSpice repositories are now using the composer flavor of jobs (via `ext... [10:38:53] 10Continuous-Integration-Config: Add test to verify that a extension is running composer tests when the dependency is also running composer test - https://phabricator.wikimedia.org/T189310 (10hashar) And we have a test to ensure that they use composer: cef9feb370f62118b7e8cc9460e3e98e877e2520 [10:43:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: zuul-merger /var/log/git-daemon/syslog.log is not log rotated - https://phabricator.wikimedia.org/T188107 (10hashar) 05Open→03Declined We have plenty of disk space. [11:23:46] 10Project-Admins, 10User-MarcoAurelio: Create project CatTalk - https://phabricator.wikimedia.org/T254497 (10Aklapper) Requested public project has been created: https://phabricator.wikimedia.org/project/profile/4813/ Please encourage interested people to visit the project and to join the project as {icon use... [11:25:18] (03CR) 10Daimona Eaytoy: [C: 03+1] "This also mirrors what --require-config-exists already does for new-style phan." [integration/config] - 10https://gerrit.wikimedia.org/r/602485 (owner: 10Jforrester) [11:27:00] (03PS3) 10Daimona Eaytoy: dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [11:27:14] (03PS3) 10Daimona Eaytoy: jjb: Drop mwextphp72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [11:27:58] (03PS3) 10Daimona Eaytoy: layout: Replace extension-seccheck with extension-phan where used [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [11:29:16] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10MarcoAurelio) [11:35:58] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phan-taint-check-plugin, 10MediaWiki-Vendor, and 2 others: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/abstrac... - https://phabricator.wikimedia.org/T248306 [11:38:37] 10Continuous-Integration-Config, 10phan: Phan-docker output (at least) triple-escapes HTML - https://phabricator.wikimedia.org/T224821 (10Daimona) >>! In T224821#5229782, @hashar wrote: > When Phan is recent enough (most case), we should be able to pass it a file to write to: `-m checkstyle -o phan-issues`. A... [11:46:12] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10Dzahn) 05Resolved→03Open a:05QChris→03Dzahn As Chris points out this VM only has 1 vcpu. But requested were 8 and he needs 8. That was my mistake it seems. Reopening. [11:46:19] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) [11:48:41] 10Phabricator: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Bugreporter) [11:57:01] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10QChris) [11:57:09] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:00:55] 10Phabricator, 10Security-Team: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Dzahn) [12:13:41] 10Project-Admins: Create a generic "Bengal-Wikisource" tag in Phabricator - https://phabricator.wikimedia.org/T254555 (10Jony) [12:28:05] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Daimona) [12:41:40] 10Phabricator, 10Security-Team: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Fae) Backing this up, an hour later, without changing browser, Phabricator did appear rather than the error 500 and this session for this added comment is via Tor & OAuth. I have no idea what the diff... [12:43:40] 10Phabricator, 10Operations, 10Security-Team, 10Traffic: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Reedy) [12:50:59] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10Dzahn) ` [gerrit1002:~] $ lscpu ... CPU(s): 8 On-line CPU(s) list: 0-7 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 8 ... CPU MHz: 2499.998 Bog... [12:51:14] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Dzahn) [12:51:17] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10Dzahn) 05Open→03Resolved @QChris ^ fixed [12:51:22] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Dzahn) [12:55:51] 10Phabricator, 10Operations, 10Security-Team, 10Traffic: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Dzahn) This could be related to T229620. [13:04:19] 10Gerrit, 10Operations, 10vm-requests: Gerrit VM to test data migration - https://phabricator.wikimedia.org/T239151 (10QChris) Wooohooo \o/ Thanks! [13:05:33] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Re-design process for pgp-public-keys repository around Gerrit - https://phabricator.wikimedia.org/T254575 (10LarsWirzenius) [13:08:16] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Re-design process for pgp-public-keys repository around Gerrit - https://phabricator.wikimedia.org/T254575 (10LarsWirzenius) p:05Triage→03Medium [13:17:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Doxygen, and 2 others: mwext-doxygen-publish Doxygen 1.8.18 fails for Wikibase.git - https://phabricator.wikimedia.org/T254465 (10Pablo-WMDE) >>>! In T254465#619... [13:30:41] 10Beta-Cluster-Infrastructure, 10Parsoid, 10Core Platform Team Workboards (Clinic Duty Team), 10User-Ryasmeen: Parsoid-PHP should be publicly accessible in beta - https://phabricator.wikimedia.org/T247589 (10Naike) 05Resolved→03Stalled [13:30:43] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Parsoid: Replace deployment-mediawiki-parsoid10 with a "purer" deployment-parsoid11 box - https://phabricator.wikimedia.org/T246854 (10Naike) [13:30:47] 10Beta-Cluster-Infrastructure, 10Core Platform Team, 10Parsoid, 10User-Ryasmeen: Parsoid/RESTbase seems to be unavailable in Beta - https://phabricator.wikimedia.org/T246833 (10Naike) [13:38:39] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Parsoid: Replace deployment-mediawiki-parsoid10 with a "purer" deployment-parsoid11 box - https://phabricator.wikimedia.org/T246854 (10Pchelolo) [13:38:41] 10Beta-Cluster-Infrastructure, 10Parsoid, 10Core Platform Team Workboards (Clinic Duty Team), 10User-Ryasmeen: Parsoid-PHP should be publicly accessible in beta - https://phabricator.wikimedia.org/T247589 (10Pchelolo) 05Stalled→03Resolved Why was this reopened? It has been completed and everyone involv... [13:38:44] 10Beta-Cluster-Infrastructure, 10Core Platform Team, 10Parsoid, 10User-Ryasmeen: Parsoid/RESTbase seems to be unavailable in Beta - https://phabricator.wikimedia.org/T246833 (10Pchelolo) [13:46:20] 10phan-taint-check-plugin: Understand what's going on with ChangeTags::modifyDisplayQuery - https://phabricator.wikimedia.org/T250689 (10Daimona) 05Open→03Resolved [13:47:14] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10Ottomata) @mpopov [13:52:22] (03CR) 10Alexandros Kosiaris: "@hashar: https://integration.wikimedia.org/ci/job/helm-lint/1616/console, triggered just a few secs ago still references helm-linter:0.2.2" [integration/config] - 10https://gerrit.wikimedia.org/r/601707 (owner: 10Alexandros Kosiaris) [14:46:25] 10VPS-project-codesearch, 10Analytics: Add analytics/* gerrit repos to code search - https://phabricator.wikimedia.org/T249318 (10Milimetric) poke @Ladsgroup / @Legoktm: any guidance here before I start a refactor? [14:47:56] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10jcrespo) Thanks for the ticket, otherwise we would surely forget about the request with so many things going on. I can take care fully of this, but @Marostegui should be on the loop becaus... [14:51:01] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10jcrespo) p:05Triage→03Medium [14:55:37] Reedy: around ? ;) [14:55:43] (03PS1) 10Jbond: operations-puppet: add shellcheck to docker image [integration/config] - 10https://gerrit.wikimedia.org/r/602710 (https://phabricator.wikimedia.org/T254480) [14:55:59] hashar: Ja [14:56:45] Reedy: yesterday i found out a Gerrit permission change for mediawiki/skins/chameleon [14:56:54] Cindy's task? [14:57:14] na https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/chameleon/+/602305/ [14:57:25] which is to make the skins to inherit permission from other skins [14:57:28] Yeah [14:57:36] So basically we don't want random people merging stuff into that repo [14:57:59] so what is the point of that repo ? [14:58:08] It's a mirror for WMF deployment purposes [14:58:12] Cause we can't deploy from github [14:58:13] https://phabricator.wikimedia.org/T252463 [14:58:18] oh fuck [14:58:21] again [14:58:24] Indeed [14:58:40] Timo has been working to make changes so we hopefully don't need that [14:58:48] and that is going to go through the train? [14:58:59] I mean we are going to deploy that to production / wikimedi acluster? [14:59:05] That is the intention, yes [14:59:11] Or, was. See my comment about TImo's changes [14:59:26] But in the interest of keeping things moving, I reopend the gerrit repo to get things in sync, and so we could test under WMF CI [14:59:34] ahhh that is the same thing that brings in twitter bootstrap bah [14:59:44] Yeah, the Bootstrap extension is basically the same too [15:01:45] It's certainly not idea [15:01:57] But ending up with a fork of something actively maintained elsewhere is painful too [15:02:18] Like I say, hopefully i the end we don't need to do this. We can make the repo readonly again and tidy up [15:06:38] Reedy: yeah maybe hopefully [15:07:13] Reedy: that remembers me about the epic of https://wikimediafoundation.org/ [15:07:43] https://phabricator.wikimedia.org/T252462#6192900 if you want to read more [15:15:57] Reedy: perfect thank you :] [15:17:36] Project mediawiki-core-doxygen-docker build #16393: 04FAILURE in 13 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16393/ [15:25:55] 10Project-Admins: InstantReply - https://phabricator.wikimedia.org/T254237 (10FNDE) Hi @Aklapper - thanks for your hint. It's the first time I've tried to create a project. The repository is located here: https://gitlab.com/FNDE/instantreply Many thanks, FNDE [15:31:04] 10Continuous-Integration-Config, 10Operations, 10SRE-tools, 10Patch-For-Review: Add shell scripts CI validations - https://phabricator.wikimedia.org/T148494 (10hashar) [15:31:53] 10Continuous-Integration-Config, 10Operations, 10SRE-tools, 10Patch-For-Review: Add shell scripts CI validations - https://phabricator.wikimedia.org/T148494 (10hashar) A few years later, this an effort to run shell scripts validation via T254480 including scripts generated through .erb templates. [15:39:47] (03CR) 10Hashar: [C: 03+2] "Super trivial since this container is merely just shipping the environment and the puppet Rakefile take care of the rest." [integration/config] - 10https://gerrit.wikimedia.org/r/602710 (https://phabricator.wikimedia.org/T254480) (owner: 10Jbond) [15:40:58] (03Merged) 10jenkins-bot: operations-puppet: add shellcheck to docker image [integration/config] - 10https://gerrit.wikimedia.org/r/602710 (https://phabricator.wikimedia.org/T254480) (owner: 10Jbond) [15:43:43] !log Building image docker-registry.discovery.wmnet/releng/operations-puppet:0.7.2 https://gerrit.wikimedia.org/r/#/c/integration/config/+/602710/ [15:43:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:11:45] !log manually stopped stuck jobs quibble-vendor-selenium-docker #13325 and wmf-quibble-selenium-php72-docker #42961 [16:12:14] stashbot_: u there? [16:13:15] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: automated linting/analysis/other CI of Python/shell scripts generated by ERB - https://phabricator.wikimedia.org/T254480 (10hashar) [16:16:17] (03PS1) 10Cwhite: add filter_scripts volume mount to logstash-filter-verifier job [integration/config] - 10https://gerrit.wikimedia.org/r/602730 (https://phabricator.wikimedia.org/T222826) [16:16:23] Yippee, build fixed! [16:16:24] Project mediawiki-core-doxygen-docker build #16394: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16394/ [16:16:26] (stashbot issue now being discussed in -operations, ftr) [16:16:40] (03PS2) 10Cwhite: add filter_scripts volume mount to logstash-filter-verifier job [integration/config] - 10https://gerrit.wikimedia.org/r/602730 (https://phabricator.wikimedia.org/T222826) [16:17:17] Lucas_WMDE: those stuck jobs, looks like something odd is happening with npm ci :-\\ [16:17:39] or maybe after it [16:17:50] yeah [16:17:55] they both stopped at the exact same point, at least [16:17:58] lemme dig up a successful build [16:18:00] see what comes next [16:18:54] in https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/13337/consoleFull, “added 2995 packages” is immediately followed by “added 1418 packages” [16:19:21] and then selenium/wdio [16:19:34] and both happen in the step "Running webdriver test in /workspace/src/extensions/Wikibase" [16:20:05] oh wait [16:20:14] both of those builds are for a change that adds an NPM package [16:20:27] which, because it’s a WIP change, is downloaded from a GitHub branch, rather than npmjs [16:20:41] (03CR) 10Cwhite: "I13be8f3ada11f791d9bdf402d3c9b7dba317fc85 should come first" [integration/config] - 10https://gerrit.wikimedia.org/r/602730 (https://phabricator.wikimedia.org/T222826) (owner: 10Cwhite) [16:20:48] so Github crashes our CI? ;]] [16:21:28] it might be due to that [16:21:28] maybe github.com isn’t accessible or something [16:21:28] yeah, for a later change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/602725) the builds worked [16:21:55] so it’s probably my fault for trying to get that package from github ^^ [16:22:00] I suppose it would be better to fail in some way rather than hang forever [16:22:30] then [16:22:40] npm ci should be able to fetch from github just fine [16:22:56] but maybe there is some kind of infinite loop being introduced somehow [16:25:51] I’ll create a Phabricator task [16:25:59] oh [16:25:59] 00:02:30.711 [16:26:00] but this probably isn’t as important as some of the other things you’re multitasking ^^ [16:26:09] > npm --prefix client/data-bridge ci [16:26:14] Unhandled rejection Error: Command failed: /usr/bin/git checkout fec07b3c5c0dd43406441afb45901247d48f2ccc [16:26:23] fatal: reference is not a tree: fec07b3c5c0dd43406441afb45901247d48f2ccc [16:26:32] oh [16:26:44] and from a goodl build, we see two occurences of "added X packages in YY seconds" [16:26:45] maybe I force-pushed the branch and didn’t update the git hash in the package-lock [16:26:53] so could you be running npm ci in parallel? [16:27:04] and somehow not cathing one of the command failing? [16:28:03] possible [16:28:06] "test": "npm-run-all -p test-fast:*", [16:28:21] we use `npm-run-all -p install:*` in the postinstall [16:28:24] maybe that command fails to notice the issue [16:28:26] I think the -p is parallel [16:28:30] not sure how npm-run-all handles the failure [16:28:45] but maybe it is reproducible locally [16:29:34] I’m checking that now [16:29:49] 10phan-taint-check-plugin, 10Patch-For-Review, 10Upstream: Allow to print taint of variable when using taint-check plugin - https://phabricator.wikimedia.org/T252261 (10Daimona) a:03Daimona [16:30:52] Lucas_WMDE: I mentioned the wrong script, quibble runs the webdriver tests via: "selenium-test": "npm-run-all --continue-on-error selenium-test:*", [16:34:08] so I pushed a new version of the change that fixes the commit hash in the package lockfile, and for that one the install apparently worked https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/13355/console [16:34:32] but also, with the wrong commit hash in the package lockfile, I was still able to do the install locally, and it looks like the commit hasn’t been garbage collected on GitHub yet [16:34:36] so I’m not sure why it failed in CI [16:35:05] aha, but it fails after `nvm use 10`! [16:35:14] so I guess older npm fetched commit refs in lockfiles differently [16:36:07] ahhh [16:36:38] but even then, I can’t reproduce the problem that the overall install (with npm-run-all) hangs forever [16:36:38] locally, it fails and exits quickly [16:37:07] maybe because packages are installed slightly differnetly [16:37:17] or due to slightly different nodejs/npm version [16:37:54] yeah [16:38:05] but at this point, I’m inclined to leave this alone [16:38:15] do you think it still should have a phabricator task, or be investigated further? [16:38:42] ideally yeah, but is unlikely we will ever figure it out [16:38:56] so I am tempted to skip the task and just pretend it is fixed ;] [16:39:09] ok ^^ [16:39:29] fun that installs oojs@3.0.1 ;] [16:40:06] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Pchelolo) Something to be cautious about: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/602737 got merged, and it's completely chan... [16:43:50] Lucas_WMDE: locally I am stuck when doing doing npm install. using: cd Wikibase && git-review -d 599902,3 && npm install [16:44:02] [ ] | extractTree: sill extractTree oojs@3.0.1 -> /home/hashar/projects/mediawiki/extensions/Wikibase/client/data-bridge/node_modules/oojs [16:44:04] that is where it blocks [16:44:34] huh [16:44:38] let me try [16:44:40] which node/npm version? [16:44:44] or I am not patient enough [16:45:11] trying again without the -p in the "postinstall" script: "postinstall": "npm-run-all install:*", [16:45:27] npm 6.5.0 [16:45:30] nodejs v10.19.0 [16:46:05] so at least I can reproduce it ;] [16:48:32] for me it stops running, strange [16:50:09] who knows :/ [16:50:18] looks like the git checkout error is not properly handled [16:50:48] yeah, “unhandled promise rejection” is something you don’t want to see [16:51:10] sill extractTree delegate@3.2.0 -> /home/hashar/projects/mediawiki/extensions/Wikibase/client/data-bridge/node_modules/delegate [16:51:19] after some tweaking it stop there bah [16:51:24] so yeah who knows ;\ [16:52:16] wait, `nvm use v10.19.0` gave me npm 6.13.0, not 6.5.0 [16:52:17] weird [16:52:19] anyways [16:52:23] I’ll create the phab task [16:52:26] probably insta-reject it [16:52:34] (just so there’s some record of it) [16:52:40] and then leave it be? [16:53:01] Lucas_WMDE: sounds good yeah [16:53:12] I have npm 6.5.0 cause I manually installed it I guess [16:53:18] the nodejs package from debian does not provide npm [16:54:28] ah ok [16:55:37] Lucas_WMDE: yeah I get it from integration/npm.git [16:55:50] which is what we use for the quibble CI containers [16:58:13] cd client/data-bridge [16:58:14] npm ci [16:58:18] and that freeze there [16:58:44] Lucas_WMDE: so yeah some magic issue somewhere in the stack :] I am leaving it there [17:00:45] https://phabricator.wikimedia.org/T254609 [17:03:30] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Jdforrester-WMF) Thanks for the heads-up. [17:04:27] 10Phabricator, 10Research-Backlog: Fix Research component tags to make them non-mutually-exclusive - https://phabricator.wikimedia.org/T238258 (10Aklapper) p:05High→03Low Assuming this is not high priority. Please let us know if you need any help with organizing the #Research board(s) (which is why this ta... [17:07:36] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble: Migrate Quibble from nose to pytest - https://phabricator.wikimedia.org/T254610 (10hashar) [17:12:26] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan-taint-check-plugin, 10Patch-For-Review: Drop taint-check jobs for CI once migration to mediawiki-tools-phan is complete - https://phabricator.wikimedia.org/T254152 (10Jdforrester-WMF) [17:17:32] (03PS1) 10Hashar: tests: no more need to ignore test.py [integration/quibble] - 10https://gerrit.wikimedia.org/r/602743 (https://phabricator.wikimedia.org/T254610) [17:24:25] Hey all, is this channel a good place to ask questions about using the new MediaWiki-Docker dev environment? [17:24:59] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Product-Analytics: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10mpopov) @Ottomata @MarcoAurelio: I can't access that logstash site so I have no idea which o... [17:36:41] (03PS1) 10Hashar: Migrate from nose to pytest [integration/quibble] - 10https://gerrit.wikimedia.org/r/602746 (https://phabricator.wikimedia.org/T254610) [17:37:04] (03CR) 10Hashar: [C: 04-2] "Need some other preliminary steps ;D" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602746 (https://phabricator.wikimedia.org/T254610) (owner: 10Hashar) [17:42:30] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Patch-For-Review, 10Technical-Debt: Migrate Quibble from nose to pytest - https://phabricator.wikimedia.org/T254610 (10hashar) [17:43:04] (03PS1) 10Hashar: tests: pluralize assertEqual to avoid warning [integration/quibble] - 10https://gerrit.wikimedia.org/r/602747 (https://phabricator.wikimedia.org/T254610) [17:57:22] (03PS1) 10Hashar: tests: use coverage instead of nose coverage plugin [integration/quibble] - 10https://gerrit.wikimedia.org/r/602752 (https://phabricator.wikimedia.org/T254610) [17:57:45] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Product-Analytics: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10Ottomata) `lang=json { "_index": "logstash-2020.06.05", "_type": "eventlogging", "_id"... [18:00:59] (03CR) 10Hashar: [C: 04-1] "That is the other way around bah..." [integration/quibble] - 10https://gerrit.wikimedia.org/r/602747 (https://phabricator.wikimedia.org/T254610) (owner: 10Hashar) [18:06:14] (03PS2) 10Hashar: tests: singularize assertEquals to avoid warning [integration/quibble] - 10https://gerrit.wikimedia.org/r/602747 (https://phabricator.wikimedia.org/T254610) [18:06:16] (03PS2) 10Hashar: tests: use coverage instead of nose coverage plugin [integration/quibble] - 10https://gerrit.wikimedia.org/r/602752 (https://phabricator.wikimedia.org/T254610) [18:06:18] (03PS2) 10Hashar: Migrate from nose to pytest [integration/quibble] - 10https://gerrit.wikimedia.org/r/602746 (https://phabricator.wikimedia.org/T254610) [18:06:48] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Patch-For-Review, 10Technical-Debt: Migrate Quibble from nose to pytest - https://phabricator.wikimedia.org/T254610 (10hashar) p:05Triage→03Medium [18:11:40] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quibble, 10Patch-For-Review, 10Technical-Debt: Migrate Quibble from nose to pytest - https://phabricator.wikimedia.org/T254610 (10hashar) A little bit more than one hour to do the conversion.... [18:11:41] (03PS3) 10Hashar: Migrate from nose to pytest [integration/quibble] - 10https://gerrit.wikimedia.org/r/602746 (https://phabricator.wikimedia.org/T254610) [18:11:56] merry week-end [18:12:34] [ bells sound ] [18:16:07] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Product-Analytics: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10mpopov) @Dbrant: The app version doesn't look right to me, does it look right to you? This... [18:16:16] hauskatze: this one, right https://www.youtube.com/watch?v=etAIpkdhU9Q [18:17:21] ugh, no [18:35:40] (03PS4) 10Jforrester: jjb: Switch quibble jobs to 0.0.44 images [integration/config] - 10https://gerrit.wikimedia.org/r/594522 [18:55:33] (I'm carefully deploying the quibble jjb updates, in case anyone spots something.) [19:03:25] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10QChris) >>! In T254516#6196583, @jcrespo wrote: > I can take care fully of this, but @Marostegui should be on the loop because of new db and grants will be needed and he should be aware of... [19:03:28] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-CollaborationKit: Undeploy the CollaborationKit extension from Wikipedia production - https://phabricator.wikimedia.org/T254036 (10Isarra) Makes sense to me, given this never go... [19:38:13] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/594522 (owner: 10Jforrester) [19:38:24] (03PS6) 10Jforrester: jjb: [parsoidsvc-parsertests-docker] Update path to parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/588026 (https://phabricator.wikimedia.org/T248726) (owner: 10C. Scott Ananian) [19:39:16] (03Merged) 10jenkins-bot: jjb: Switch quibble jobs to 0.0.44 images [integration/config] - 10https://gerrit.wikimedia.org/r/594522 (owner: 10Jforrester) [19:42:01] (03CR) 10Jforrester: [C: 03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/588026 (https://phabricator.wikimedia.org/T248726) (owner: 10C. Scott Ananian) [19:43:08] (03Merged) 10jenkins-bot: jjb: [parsoidsvc-parsertests-docker] Update path to parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/588026 (https://phabricator.wikimedia.org/T248726) (owner: 10C. Scott Ananian) [19:46:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: automated linting/analysis/other CI of Python/shell scripts generated by ERB - https://phabricator.wikimedia.org/T254480 (10Volans) Sorry I'm late to this party, just noticed... [19:49:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: automated linting/analysis/other CI of Python/shell scripts generated by ERB - https://phabricator.wikimedia.org/T254480 (10CDanis) @Volans >>! In T254480#6196820, @jbond w... [19:58:14] James_F: thanks for the quibble tagging / deployment! [20:00:26] hashar: Happy to do it. All looks well so far. [20:00:50] 10phan-taint-check-plugin, 10MediaWiki-extensions-Translate, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), and 4 others: SpecialLanguageStats.php fails phan tests due to possible XSS - https://phabricator.wikimedia.org/T253383 (10sbassett) 05Open→03Resolved [20:00:52] hashar: Am currently trying to work out how to do the new structure of quibble jobs nicely in JJB; I worry that there isn't a nice way. :-( [20:01:23] 10phan-taint-check-plugin, 10MediaWiki-extensions-Translate, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), and 3 others: SpecialLanguageStats.php fails phan tests due to possible XSS - https://phabricator.wikimedia.org/T253383 (10sbassett) [20:01:29] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10CDanis) [20:02:13] RECOVERY - Free space - all mounts on deployment-cache-text06 is OK: OK: All targets OK [20:02:25] James_F: yeah I tried to find good naming scheme when I started deploying quibble, but went with some craziness [20:03:18] :-) [20:03:32] The hard bit is passing the "what jobs do we want?" bit cleanly. [20:03:39] would you mind dropping a quick note to wikitech-l about the quibble 0.0.41 .. 0.0.44 upgrade? [20:03:45] Oh, sure. [20:03:55] seems the outstanding change is the introduction of @group Standalone [20:04:04] Well, that deployed in 0.0.41. [20:04:11] This is just a performance fix, effectively. [20:04:19] ah [20:04:34] ah yeah 0.0.42 is Exclude phpunit group Standalone from the Database run [20:04:42] Yup. [20:04:57] Output mysql/mariadb and postgresql version [20:04:59] and that is about it [20:05:15] rest are either code enhancement or reverts ;D [20:05:19] Indeed. [20:05:27] Still worth e-mailing just in case things break? [20:05:35] yeah at least to raise awareness [20:05:51] and point folk at filing a task in case something goes south [20:06:45] meanwhile, I have send a serie to migrate the test runner from nose to pytest [20:07:01] I saw. [20:07:03] Looks nice. [20:07:06] and will add some acceptance tests for the build plan [20:07:37] eg: when I invoke quibble with --skip-deps and env has ZUUL_PROJECT=mediawiki/skins/Foobar then X, Y, Z commands are in the plan [20:07:45] I though of expressing that in some basic yaml [20:07:52] env: ZUUL_PROJECT=mediawiki/skins/Foobar [20:08:06] params: [skip-deps] [20:08:22] plan: [ the expected plan ] [20:12:27] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10Volans) @CDan... [20:13:13] PROBLEM - Free space - all mounts on deployment-cache-text06 is CRITICAL: CRITICAL: deployment-prep.deployment-cache-text06.diskspace.root.byte_percentfree (<33.33%) [20:22:35] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10ArielGlenn) I... [20:23:55] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Product-Analytics, 10Wikipedia-Android-App-Backlog: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10Dbrant) @mpopov You are correct -- this is likely some e... [20:31:04] pytest options are fun: disable_test_id_escaping_and_forfeit_all_rights_to_community_support = True [20:38:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10jbond) >>! In... [21:05:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10jbond) >>! In... [21:07:22] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Product-Analytics, 10Wikipedia-Android-App-Backlog: MobileWikiAppProtectedEditAttempt: 'protectionStatus' is a required property - https://phabricator.wikimedia.org/T254567 (10mpopov) Thanks, Dmitry! [21:18:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10ArielGlenn) @... [21:36:42] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Legoktm) If we're going to redo how we configure phan, can we adopt a machine-readable format like JSON/yaml/TOML? (JSON is my pick, but people like their comments...). Long-term I think i... [22:06:29] (03PS1) 10Hashar: High level testing for the execution plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602776 (https://phabricator.wikimedia.org/T211702) [22:07:06] and here are the acceptance tests for the Quibble plan building ; [22:07:14] in just 2 hours! :D [22:07:17] (03CR) 10jerkins-bot: [V: 04-1] High level testing for the execution plan [integration/quibble] - 10https://gerrit.wikimedia.org/r/602776 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [22:07:22] and it fails hehe [22:11:07] (03CR) 10Hashar: "When checking a list / dict nosetest had a per test option to ensure the full diff is shown:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602746 (https://phabricator.wikimedia.org/T254610) (owner: 10Hashar) [22:13:40] (03CR) 10Hashar: "Seems I have to mock the working directory as well. The test fails with:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/602776 (https://phabricator.wikimedia.org/T211702) (owner: 10Hashar) [22:19:26] James_F: thank for the wikitech-l message. Very nice ;] [22:20:01] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Daimona) >>! In T254571#6198110, @Legoktm wrote: > If we're going to redo how we configure phan, can we adopt a machine-readable format like JSON/yaml/TOML? In theory, yes, but would ther... [22:23:13] RECOVERY - Free space - all mounts on deployment-cache-text06 is OK: OK: All targets OK [22:30:00] PROBLEM - Free space - all mounts on deployment-cache-upload06 is CRITICAL: CRITICAL: deployment-prep.deployment-cache-upload06.diskspace.root.byte_percentfree (<30.00%) [22:34:12] PROBLEM - Free space - all mounts on deployment-cache-text06 is CRITICAL: CRITICAL: deployment-prep.deployment-cache-text06.diskspace.root.byte_percentfree (<11.11%) [22:49:12] RECOVERY - Free space - all mounts on deployment-cache-text06 is OK: OK: All targets OK [22:49:59] RECOVERY - Free space - all mounts on deployment-cache-upload06 is OK: OK: All targets OK [22:55:30] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Legoktm) >>! In T254571#6198193, @Daimona wrote: >>>! In T254571#6198110, @Legoktm wrote: >> If we're going to redo how we configure phan, can we adopt a machine-readable format like JSON/... [23:34:13] 10LibUp: LibUp gives Internal Server Error for Wikibase - https://phabricator.wikimedia.org/T254633 (10Addshore)