[01:18:28] 10LibUp, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10DannyS712) 05Resolved→03Open >>! In T254070#6188406, @Legoktm wrote: > Worked perfectly: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceFoundation/+/601928 > > Thank you @D... [02:48:16] thcipriani: I don't suppose you are for some reason working at 8PM on a Friday? [02:49:04] * andrewbogott has keyholder questions [03:16:26] 10Phabricator: Change Phabricator Username - https://phabricator.wikimedia.org/T254635 (10R9H9) [03:23:37] nm, sorted [03:46:33] 10Continuous-Integration-Config, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Install Jest for unit tests for Vue.js search - https://phabricator.wikimedia.org/T249301 (10Niedzielski) @ovasileva, I'm adding this to the Web board for tracking and visibility purposes. Anri is working... [03:53:36] PROBLEM - Free space - all mounts on deployment-logstash2 is CRITICAL: CRITICAL: deployment-prep.deployment-logstash2.diskspace._mnt.byte_percentfree (No valid datapoints found) deployment-prep.deployment-logstash2.diskspace._var_lib_elasticsearch.byte_percentfree (No valid datapoints found)deployment-prep.deployment-logstash2.diskspace.root.byte_percentfree (<100.00%) [06:31:38] 10Phabricator: Change Phabricator Username - https://phabricator.wikimedia.org/T254635 (10Aklapper) 05Open→03Resolved a:03Aklapper [08:10:29] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit Document on the User Interface (for 3.1) - https://phabricator.wikimedia.org/T227562 (10Aklapper) This must be connected to T254158 - please also add new parent tasks when removing old parent tasks. [08:10:36] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Aklapper) [08:10:38] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit Document on the User Interface (for 3.1) - https://phabricator.wikimedia.org/T227562 (10Aklapper) [08:11:02] 10Gerrit, 10Release-Engineering-Team-TODO, 10Documentation: Update Gerrit documentation on user interface (for 3.1) on mediawiki.org - https://phabricator.wikimedia.org/T227562 (10Aklapper) [08:13:25] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Aklapper) @Paladox: You removed the 2.16 subtask. How is this task connected to the task about upgrading to 3.1? Still relevant, or not? Tasks should be connected so they can be found if they are relevant for... [08:28:27] 10Project-Admins: Create new Project: #WMF-Internal-Tech - https://phabricator.wikimedia.org/T139994 (10Aklapper) FYI I have archived the project tag #WMF-Internal-Tech as it seems to be unused. [08:34:46] 10MediaWiki-Codesniffer, 10phan, 10Upstream: Check to find incorrectly cased php classes and function calls - https://phabricator.wikimedia.org/T253625 (10Aklapper) [08:38:41] 10Beta-Cluster-Infrastructure, 10SDC General, 10Wikimedia-Extension-setup, 10FileAnnotations (Beta Cluster Release), and 2 others: Release FileAnnotations on the Beta Cluster - https://phabricator.wikimedia.org/T144302 (10Aklapper) >>! In T144302#3666472, @Ramsey-WMF wrote: > Stalled because of wait for Wi... [08:47:24] 10Phabricator, 10EngProd-Virtual-Hackathon: Extract data for burn down charts - https://phabricator.wikimedia.org/T253109 (10Aklapper) >>! In T253109#6154890, @dom_walden wrote: > so I will probably not be able to get involved in the Phab hacking session. Happy to close this task. @dom_walden: Feel free to do... [08:53:52] 10Phabricator, 10Release-Engineering-Team-TODO, 10User-brennen: Document a (Wikimedia-specific) Phabricator local install - https://phabricator.wikimedia.org/T253132 (10Aklapper) Appreciated. However nobody can find that page as https://www.mediawiki.org/wiki/Special:WhatLinksHere/Phabricator/Local_Dev_Envir... [09:48:08] (03PS1) 10Umherirrender: build: Updating composer dependencies [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/602801 [12:10:22] 10LibUp: LibUp gives Internal Server Error for Wikibase - https://phabricator.wikimedia.org/T254633 (10Umherirrender) Possible the same issue as in T243718 [12:21:01] is there any chance I could get access to batch edit tasks if you can change story points and priority from it? [12:21:14] * RhinosF1 needs to move stuff on a workboard around [12:36:28] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Test backup and restore of Gerrit on the ganeti test instance - https://phabricator.wikimedia.org/T243982 (10QChris) 05Open→03Resolved a:03QChris We verified restore of repo+LFS data... [12:36:36] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10QChris) [12:36:42] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Test backup and restore of Gerrit data - https://phabricator.wikimedia.org/T243982 (10QChris) [12:37:04] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Test backup and restore of Gerrit data - https://phabricator.wikimedia.org/T243982 (10QChris) [12:37:06] 10Gerrit, 10Operations: Initial backup run for Gerrit LFS data - https://phabricator.wikimedia.org/T254162 (10QChris) [12:37:27] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Test backup and restore of Gerrit data - https://phabricator.wikimedia.org/T243982 (10QChris) [12:37:29] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:41:03] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Test upgrade of Gerrit to 2.16.13 on the ganeti test instance - https://phabricator.wikimedia.org/T243981 (10QChris) 05Open→03Resolved a:03QChris Tested upgrade to 2.16.20 as part of... [12:41:08] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10QChris) [12:42:30] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10QChris) [12:43:06] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10QChris) [12:43:08] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:44:55] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10QChris) Upgrade to 3.2 mostly worked with a read-only DB. The git repo related parts went through just fine, just as the NoteDB conversion did. The only part where the upgrade threw errors, was when... [12:45:29] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10QChris) [12:45:31] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10QChris) [12:45:34] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:47:13] 10Gerrit: Set up test instance for the community to test new version - https://phabricator.wikimedia.org/T254644 (10QChris) [12:47:33] 10Gerrit: Set up test instance for the community to test new version - https://phabricator.wikimedia.org/T254644 (10QChris) [12:47:35] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:49:04] 10Gerrit, 10Release-Engineering-Team (Development services), 10Patch-For-Review: Prepare for Polymer 2.x - https://phabricator.wikimedia.org/T227509 (10QChris) [12:49:06] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [12:49:59] 10Gerrit, 10Release-Engineering-Team (Development services), 10Patch-For-Review: Prepare Gerrit site template for upcoming Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T227509 (10QChris) [13:06:32] (03CR) 10DannyS712: [C: 03+2] build: Updating composer dependencies [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/602801 (owner: 10Umherirrender) [13:07:28] (03Merged) 10jenkins-bot: build: Updating composer dependencies [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/602801 (owner: 10Umherirrender) [13:16:20] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10Paladox) p:05Triage→03Medium [13:43:00] 10Gerrit: Double check that `Code of Conduct` and `Privacy` links are in place after site update for Gerrit 3.x - https://phabricator.wikimedia.org/T254648 (10QChris) [13:43:14] 10Gerrit: Double check that `Code of Conduct` and `Privacy` links are in place after site update for Gerrit 3.x - https://phabricator.wikimedia.org/T254648 (10QChris) [13:43:18] 10Gerrit, 10Release-Engineering-Team (Development services), 10Patch-For-Review: Prepare Gerrit site template for upcoming Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T227509 (10QChris) [13:44:54] (03PS2) 10Umherirrender: Recognize used classes even if variable/type in a tag are flipped [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599276 (https://phabricator.wikimedia.org/T253711) (owner: 10Thiemo Kreuz (WMDE)) [13:44:58] (03CR) 10Umherirrender: [C: 03+2] Recognize used classes even if variable/type in a tag are flipped [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599276 (https://phabricator.wikimedia.org/T253711) (owner: 10Thiemo Kreuz (WMDE)) [13:45:48] (03Merged) 10jenkins-bot: Recognize used classes even if variable/type in a tag are flipped [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599276 (https://phabricator.wikimedia.org/T253711) (owner: 10Thiemo Kreuz (WMDE)) [13:59:11] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) a:03QChris [14:06:07] 10LibUp, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Reedy) >>! In T254070#6198359, @DannyS712 wrote: >>>! In T254070#6188406, @Legoktm wrote: >> Worked perfectly: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/BlueSpiceFoundation/+/601928... [14:12:08] 10Gerrit: Make sure currently used barricade functionality is available in our used Gerrit 3.x build - https://phabricator.wikimedia.org/T254651 (10QChris) [14:12:45] 10Gerrit: Make sure currently used barricade functionality is available in our used Gerrit 3.x build - https://phabricator.wikimedia.org/T254651 (10QChris) [14:13:03] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [14:13:05] 10Gerrit: Make sure currently used barricade functionality is available in our used Gerrit 3.x build - https://phabricator.wikimedia.org/T254651 (10QChris) [14:13:38] 10Gerrit: Make sure currently used barricade functionality is available in our used Gerrit 3.x build - https://phabricator.wikimedia.org/T254651 (10QChris) [14:23:32] 10Gerrit: Provide an easy way to see which plugin is used in which version and API on a gerrit server. - https://phabricator.wikimedia.org/T254652 (10QChris) a:03QChris [14:24:10] 10Gerrit: Provide an easy way to see which plugin is used in which version and API on a gerrit server. - https://phabricator.wikimedia.org/T254652 (10QChris) [14:24:13] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [14:25:47] 10MediaWiki-Codesniffer: Use statement marked as unused when it's used for a type hint - https://phabricator.wikimedia.org/T253711 (10DannyS712) 05Open→03Resolved a:03DannyS712 [14:26:06] 10MediaWiki-Codesniffer: Use statement marked as unused when it's used for a type hint - https://phabricator.wikimedia.org/T253711 (10DannyS712) a:05DannyS712→03thiemowmde [14:27:34] 10Gerrit: Allow to see API version of used in Gerrit - https://phabricator.wikimedia.org/T254654 (10QChris) [14:27:53] 10Gerrit: Allow to see API version of used in Gerrit - https://phabricator.wikimedia.org/T254654 (10QChris) [14:27:55] 10Gerrit: Provide an easy way to see which plugin is used in which version and API on a gerrit server. - https://phabricator.wikimedia.org/T254652 (10QChris) [14:30:09] 10Gerrit: Bring API version number into Gerrit plugins - https://phabricator.wikimedia.org/T254655 (10QChris) [14:30:16] 10Gerrit: Bring API version number into Gerrit plugins - https://phabricator.wikimedia.org/T254655 (10QChris) 05Open→03Resolved [14:30:30] 10Gerrit: Bring API version number into Gerrit plugins - https://phabricator.wikimedia.org/T254655 (10QChris) [14:30:32] 10Gerrit: Allow to see API version of used in Gerrit - https://phabricator.wikimedia.org/T254654 (10QChris) [14:35:28] 10VPS-project-codesearch, 10Analytics: Add analytics/* gerrit repos to code search - https://phabricator.wikimedia.org/T249318 (10Ladsgroup) Your idea seems good and sensible to me. I don't see anything wrong with it. Maybe write tests to make sure things work? That's a standard guidance in every refactor :P [14:37:48] 10Gerrit: Switch Gerrit plugin version numbers from plain hashes to more descriptive variants - https://phabricator.wikimedia.org/T254656 (10QChris) [14:38:19] 10Gerrit: Switch Gerrit plugin version numbers from plain hashes to more descriptive variants - https://phabricator.wikimedia.org/T254656 (10QChris) [14:38:21] 10Gerrit: Provide an easy way to see which plugin is used in which version and API on a gerrit server. - https://phabricator.wikimedia.org/T254652 (10QChris) [14:40:44] 10Gerrit: Switch Gerrit plugin version numbers from plain hashes to more descriptive variants - https://phabricator.wikimedia.org/T254656 (10QChris) [14:42:54] 10Gerrit: Make sure `its-phabricator` exposes the `its-base` version that got used for building - https://phabricator.wikimedia.org/T254657 (10QChris) [14:43:13] 10Gerrit: Make sure `its-phabricator` exposes the `its-base` version that got used for building - https://phabricator.wikimedia.org/T254657 (10QChris) [14:43:15] 10Gerrit: Provide an easy way to see which plugin is used in which version and API on a gerrit server. - https://phabricator.wikimedia.org/T254652 (10QChris) [14:45:49] 10phan: Load pcntl stub in base phan-config to make phan pass on windows - https://phabricator.wikimedia.org/T254658 (10Umherirrender) [14:48:09] 10Gerrit: Update `its-phabricator` to Gerrit 3.x - https://phabricator.wikimedia.org/T254659 (10QChris) [14:48:28] 10phan: Load pcntl stub in base phan-config to make phan pass on windows - https://phabricator.wikimedia.org/T254658 (10Daimona) (FTR: This was discussed [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/602821/ | here ]], and the following patches should be reverted once upgrading:... [14:48:30] 10Gerrit: Update `its-phabricator` to Gerrit 3.x - https://phabricator.wikimedia.org/T254659 (10QChris) [14:48:32] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [14:50:58] 10Gerrit: Update `its-phabricator` to Gerrit 3.x - https://phabricator.wikimedia.org/T254659 (10QChris) After ~40 commits, `its-phabricator` is again in good shape. It now has * up-to-date documentation, * tests that compile, work, and pass, * works in Gerrit 3.1 and Gerrit 3.2 against Phabricator (Big thanks t... [14:55:36] 10Gerrit: Make `its-base` fit for Gerrit 3.x - https://phabricator.wikimedia.org/T254660 (10QChris) [14:55:59] 10Gerrit: Make `its-base` fit for Gerrit 3.x - https://phabricator.wikimedia.org/T254660 (10QChris) [14:56:01] 10Gerrit: Update `its-phabricator` to Gerrit 3.x - https://phabricator.wikimedia.org/T254659 (10QChris) [15:04:02] (03PS1) 10Umherirrender: [AdminLinks] Run phan job [integration/config] - 10https://gerrit.wikimedia.org/r/602830 [15:11:16] 10Gerrit: Make `its-base` fit for Gerrit 3.x - https://phabricator.wikimedia.org/T254660 (10QChris) [15:19:54] !log created deployment-mailman01 in beta cluster for testing upgrade to mailmain 3.1 (T52864 and T130554) [15:19:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:19:58] T130554: Official support for upgrade from existing Mailman 2.1 lists to Mailman 3 - https://phabricator.wikimedia.org/T130554 [15:19:58] T52864: Have a conversation about migrating from GNU Mailman 2.1 to GNU Mailman 3.0 - https://phabricator.wikimedia.org/T52864 [15:21:31] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Daimona) >>! In T254571#6198224, @Legoktm wrote: > Migrations are usually 100% possible to do automatically, like all the composer.json manipulations we've done. Compare that with us tryin... [16:08:43] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Umherirrender) I would not see a false positive here, when looking at Patch Set 1 - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LocalisationUpdate/+... [16:13:25] 10phan, 10MediaWiki-General, 10User-DannyS712: redundant_condition_detection is still suppressed - https://phabricator.wikimedia.org/T248438 (10Umherirrender) The most issues are coming from hooks where argument are passed by ref and after the hook checked if non-empty/changed. Phan seems to assume that the... [16:48:08] 10phan, 10MediaWiki-General, 10User-DannyS712: redundant_condition_detection is still suppressed - https://phabricator.wikimedia.org/T248438 (10Daimona) >>! In T248438#6199176, @Umherirrender wrote: > The most issues are coming from hooks where argument are passed by ref and after the hook checked if non-emp... [17:34:25] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Daimona) 05Open→03Invalid >>! In T207835#6199164, @Umherirrender wrote: > The $removePath is in the try block and that means the variable could be undefined... [18:11:25] 10Gerrit: Set up test instance for the community to test new version - https://phabricator.wikimedia.org/T254644 (10QChris) a:03QChris [18:11:28] 10Gerrit: Double check that `Code of Conduct` and `Privacy` links are in place after site update for Gerrit 3.x - https://phabricator.wikimedia.org/T254648 (10QChris) a:03QChris [18:19:25] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Ammarpad) >>! In T207835#6199164, @Umherirrender wrote: > I would not see a false positive here, when looking at Patch Set 1 - https://gerrit.wikimedia.org/r/#/... [19:07:42] (03PS4) 10DC Slagel: Blubber/Blubberoid: mv expansion before verifying [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) [19:10:37] (03CR) 10DC Slagel: "Hi Jeena, Tyler," (037 comments) [blubber] - 10https://gerrit.wikimedia.org/r/593315 (https://phabricator.wikimedia.org/T248927) (owner: 10DC Slagel) [20:19:35] (03CR) 10DC Slagel: [C: 03+1] "Hi Jeena," [blubber] - 10https://gerrit.wikimedia.org/r/602517 (owner: 10Jeena Huneidi) [20:41:33] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Daimona) >>! In T207835#6199362, @Ammarpad wrote: > This is wrong. The exception is thrown (by fetchFiles() method ) //after $removePath has already been defin... [21:14:06] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Ammarpad) >>! In T207835#6199482, @Daimona wrote: >>>! In T207835#6199362, @Ammarpad wrote: >> This is wrong. The exception is thrown (by fetchFiles() method )... [22:50:56] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Daimona) >>! In T207835#6199508, @Ammarpad wrote: > You closed this task as "invalid" with "you're very right." But he was not. 'actual code execution' or 'sta... [23:16:19] 10phan: mwext-php72-phan-docker should fail when warnings are printed - https://phabricator.wikimedia.org/T254103 (10Daimona) I quickly looked at this a few days ago but forgot to post the result. IIRC, phan doesn't have an option to do this natively (for it just prints the warnings to STDERR, like anything else...