[00:12:03] 10phan: mwext-php72-phan-docker should fail when warnings are printed - https://phabricator.wikimedia.org/T254103 (10Umherirrender) I would prefer to do it in ourer CI, if it is possible to raise the error level without problems for phan [00:21:04] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Umherirrender) I do not thing that upstream could be fixed here, as it is a hint from phan that the code flow may result in an undeclared variable if the return... [01:39:46] 10phan: Create phan plugin to ensure __METHOD__ is passed to function needs the caller information - https://phabricator.wikimedia.org/T225836 (10Umherirrender) If you need a reference on how often it is happen, see https://gerrit.wikimedia.org/r/#/q/topic:method+(status:open+OR+status:merged)+owner:%22Umherirre... [02:41:22] 10Phabricator: Disable Personal Herald rules H66, H236, H313 as the user currently cannot access Phab - https://phabricator.wikimedia.org/T248662 (10Sau226) According to https://discourse.phabricator-community.org/t/herald-policy-setting-to-allow-users-to-view-but-only-admin-to-create-edit/2841/3, Herald rules c... [03:12:50] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for unneeded __construct functions - https://phabricator.wikimedia.org/T242402 (10DannyS712) Same applied to tests' setup and teardown ` lang=php protected function setUp() : void { parent::setUp(); } protected function tearDown() : void { parent::tea... [05:15:21] 10LibUp, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10DannyS712) >>! In T254070#6198906, @Reedy wrote: >>>! In T254070#6198359, @DannyS712 wrote: >>>>! In T254070#6188406, @Legoktm wrote: >>> Worked perfectly: https://gerrit.wikimedia.org/r/c/medi... [07:03:07] 10Phabricator: Disable Personal Herald rules H66, H236, H313 as the user currently cannot access Phab - https://phabricator.wikimedia.org/T248662 (10Aklapper) @Sau226: Uh, thanks a lot for finding this! Added to https://wikitech.wikimedia.org/w/index.php?title=Phabricator&type=revision&diff=1868640&oldid=1860242 [07:10:27] 10Phabricator: Disable Personal Herald rules H66, H236, H313 as the user currently cannot access Phab - https://phabricator.wikimedia.org/T248662 (10Aklapper) (Created https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/602951 to get permissions via CLI) [11:22:46] 10phan: Create phan plugin to ensure __METHOD__ is passed to function needs the caller information - https://phabricator.wikimedia.org/T225836 (10Daimona) > There should be a phan plugin to look on all function signature of all classes and get a list out of that. This list must include the class/function name an... [11:24:24] 10phan: mwext-php72-phan-docker should fail when warnings are printed - https://phabricator.wikimedia.org/T254103 (10Daimona) >>! In T254103#6199652, @Umherirrender wrote: > I would prefer to do it in ourer CI, if it is possible to raise the error level without problems for phan I think we'd only have to grep t... [11:35:05] 10Continuous-Integration-Config, 10phan, 10TestMe: False positive PhanUndeclaredVariable in try-catch - https://phabricator.wikimedia.org/T207835 (10Daimona) 05Invalid→03Resolved >>! In T207835#6199653, @Umherirrender wrote: > When the function cannot throw or it is not indented to throw, than it is a si... [14:31:24] 10Diffusion, 10Gerrit: rPHAB to gerrit mirror stuck at 447032e1d - https://phabricator.wikimedia.org/T213512 (10MarcoAurelio) @bd808 Can you check if this is still an issue? Thanks. [17:15:47] 10phan: Create phan plugin to ensure __METHOD__ is passed to function needs the caller information - https://phabricator.wikimedia.org/T225836 (10Krinkle) [19:53:53] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602995 [19:53:55] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602995 (owner: 10QChris) [19:54:06] (03PS1) 10QChris: Import done. Revoke import grants [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602996 [19:54:08] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602996 (owner: 10QChris) [20:15:16] (03PS1) 10Jack who built the house: Edit Project Config [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602997 [20:15:18] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602997 (owner: 10Jack who built the house) [21:58:28] (03Abandoned) 10Jack who built the house: Edit Project Config [gadgets/ConvenientDiscussions] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/602997 (owner: 10Jack who built the house) [23:03:04] 10Beta-Cluster-Infrastructure, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban: [beta] EventLogging trying to fetch wrong Schema title - https://phabricator.wikimedia.org/T254058 (10Krinkle) [23:08:47] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Krinkle)