[01:01:21] PROBLEM - Free space - all mounts on deployment-mdb01 is CRITICAL: CRITICAL: deployment-prep.deployment-mdb01.diskspace._srv.byte_percentfree (<100.00%) [01:20:45] PROBLEM - Host deployment-mdb01 is DOWN: CRITICAL - Host Unreachable (172.16.1.180) [01:30:43] 10LibUp: libup web ui returns sometimes 500 Internal Server Error - https://phabricator.wikimedia.org/T243718 (10Legoktm) 05Open→03Resolved a:03Legoktm [01:30:53] 10LibUp: LibUp gives Internal Server Error for Wikibase - https://phabricator.wikimedia.org/T254633 (10Legoktm) [01:30:55] 10LibUp: libup web ui returns sometimes 500 Internal Server Error - https://phabricator.wikimedia.org/T243718 (10Legoktm) [01:31:32] 10LibUp, 10Patch-For-Review, 10User-DannyS712: Library upgrader tests not always being run - https://phabricator.wikimedia.org/T254070 (10Legoktm) 05Open→03Resolved [01:32:02] 10LibUp: Use packaged composer - https://phabricator.wikimedia.org/T249525 (10Legoktm) 05Open→03Stalled [01:32:04] 10Continuous-Integration-Infrastructure: Stop using integration/composer and then archive the repo - https://phabricator.wikimedia.org/T249949 (10Legoktm) [01:46:13] 10LibUp: libup: Kill running docker containers after some wall clock timeout - https://phabricator.wikimedia.org/T240749 (10Legoktm) 05Open→03Resolved a:03Legoktm [01:54:46] PROBLEM - Host deployment-mdb02 is DOWN: CRITICAL - Host Unreachable (172.16.0.161) [01:57:11] 10LibUp: implement php security scanning in libup - https://phabricator.wikimedia.org/T228108 (10Legoktm) 05Open→03Stalled This is stalled on having a case study that I can test with. [02:58:26] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) The same should also apply to function parameters with `$wg*` names - the actual object passed may be the same as the global object,... [04:28:31] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10CptViraj) [04:36:28] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10jeena) @DannyS712 I haven't noticed any so far [05:03:43] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10DannyS712) Patch going out with the train: https://gerrit.wikimedia.org/r/604237 - {T254960}, {T251853} As noted on th... [05:57:20] (03CR) 10Jforrester: [C: 03+2] [ChessBrowser] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604133 (owner: 10Umherirrender) [05:58:24] (03Merged) 10jenkins-bot: [ChessBrowser] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604133 (owner: 10Umherirrender) [05:59:00] !log Zuul: [mediawiki/extensions/ChessBrowser] Replace seccheck with phan [05:59:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [05:59:59] (03CR) 10Jforrester: [C: 03+2] [Sudo] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604120 (owner: 10Umherirrender) [06:01:02] (03Merged) 10jenkins-bot: [Sudo] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604120 (owner: 10Umherirrender) [06:01:09] !log Zuul: [mediawiki/extensions/Sudo] Replace seccheck with phan [06:01:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:04:12] (03CR) 10Jforrester: [C: 03+2] [TEI] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604126 (owner: 10Umherirrender) [06:04:30] (03CR) 10Jforrester: [C: 03+2] [Petition] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604129 (owner: 10Umherirrender) [06:05:23] (03Merged) 10jenkins-bot: [TEI] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604126 (owner: 10Umherirrender) [06:05:31] (03Merged) 10jenkins-bot: [Petition] Replace seccheck by phan job [integration/config] - 10https://gerrit.wikimedia.org/r/604129 (owner: 10Umherirrender) [06:05:57] !log Zuul: [mediawiki/extensions/TEI] Replace seccheck with phan [06:05:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:06:02] !log Zuul: [mediawiki/extensions/Petition] Replace seccheck with phan [06:06:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:06:08] (03PS6) 10Jforrester: layout: Remove extension-seccheck, all uses switched to extension-phan [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (https://phabricator.wikimedia.org/T254152) [06:06:25] (03PS7) 10Jforrester: layout: Remove extension-seccheck, all uses switched to extension-phan [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (https://phabricator.wikimedia.org/T254152) [06:06:40] (03CR) 10Jforrester: [C: 03+2] layout: Remove extension-seccheck, all uses switched to extension-phan [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:07:20] (03CR) 10DannyS712: Add RedundantVarNameSniff from WikibaseCodeSniffer (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603493 (owner: 10Thiemo Kreuz (WMDE)) [06:07:53] (03Merged) 10jenkins-bot: layout: Remove extension-seccheck, all uses switched to extension-phan [integration/config] - 10https://gerrit.wikimedia.org/r/602482 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:08:44] !log Zuul: Drop extension-seccheck template, unused [06:08:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:08:50] (03PS4) 10Jforrester: jjb: Drop mwextphp72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 (https://phabricator.wikimedia.org/T254152) [06:09:10] (03PS5) 10Jforrester: jjb: Drop mwext-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 (https://phabricator.wikimedia.org/T254152) [06:14:15] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/602483 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:15:27] (03Merged) 10jenkins-bot: jjb: Drop mwext-php72-phan-seccheck-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602483 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:17:01] (03PS4) 10Jforrester: dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 (https://phabricator.wikimedia.org/T254152) [06:17:10] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:17:30] Project mediawiki-core-doxygen-docker build #16504: 04FAILURE in 13 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16504/ [06:18:20] (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan-seccheck] Drop, unused [integration/config] - 10https://gerrit.wikimedia.org/r/602484 (https://phabricator.wikimedia.org/T254152) (owner: 10Jforrester) [06:18:54] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10phan-taint-check-plugin, 10Patch-For-Review: Drop taint-check jobs for CI once migration to mediawiki-tools-phan is complete - https://phabricator.wikimedia.org/T254152 (10Jdforrester-WMF) 05Open→03Resolved [06:19:08] (03PS3) 10Jforrester: dockerfiles: [mediawiki-phan] Make jobs fail if repo is unconfigured [integration/config] - 10https://gerrit.wikimedia.org/r/602485 [06:21:06] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10Aklapper) Hi! Could you please elaborate who plans to use that tag and how, and who plans to spend time to constantly look at new incoming tickets and add this tag? Thanks. [06:21:06] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [mediawiki-phan] Make jobs fail if repo is unconfigured [integration/config] - 10https://gerrit.wikimedia.org/r/602485 (owner: 10Jforrester) [06:22:01] (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan] Make jobs fail if repo is unconfigured [integration/config] - 10https://gerrit.wikimedia.org/r/602485 (owner: 10Jforrester) [06:23:07] !log Docker: Publishing mediawiki-phan:0.6.0 [06:23:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:27:33] (03PS1) 10Jforrester: jjb: Switch phan jobs to image 0.6.0 [integration/config] - 10https://gerrit.wikimedia.org/r/604252 [06:32:59] (03CR) 10Jforrester: [C: 03+2] jjb: Switch phan jobs to image 0.6.0 [integration/config] - 10https://gerrit.wikimedia.org/r/604252 (owner: 10Jforrester) [06:34:01] (03Merged) 10jenkins-bot: jjb: Switch phan jobs to image 0.6.0 [integration/config] - 10https://gerrit.wikimedia.org/r/604252 (owner: 10Jforrester) [06:46:24] 10Project-Admins: create subproject? (or tag?) for Analytics-Radar - https://phabricator.wikimedia.org/T254806 (10Aklapper) 05Open→03Resolved a:03Aklapper * Created #Analytics-Radar: https://phabricator.wikimedia.org/project/view/4824/ ** I hope the project desc is fine - if not please edit via "Manage > E... [06:47:35] 10Project-Admins: Create Analytics subproject called Analytics-Radar - https://phabricator.wikimedia.org/T254806 (10Aklapper) [07:18:55] Yippee, build fixed! [07:18:55] Project mediawiki-core-doxygen-docker build #16505: 09FIXED in 14 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16505/ [07:42:13] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Catrope) >>! In T253461#6191082, @Legoktm wrote: >>>! In T253461#6163439, @Tgr wrote: >> Maybe we could keep the PHPCS rule against `@` and require peop... [07:46:21] (03PS1) 10Hashar: dockerfiles: add libcurl4-openssl-dev to tox [integration/config] - 10https://gerrit.wikimedia.org/r/604291 (https://phabricator.wikimedia.org/T254338) [07:46:23] (03PS1) 10Hashar: jjb: update tox jobs for libcurl4-openssl-dev [integration/config] - 10https://gerrit.wikimedia.org/r/604292 (https://phabricator.wikimedia.org/T254338) [07:46:48] (03CR) 10Hashar: [C: 03+2] dockerfiles: add libcurl4-openssl-dev to tox [integration/config] - 10https://gerrit.wikimedia.org/r/604291 (https://phabricator.wikimedia.org/T254338) (owner: 10Hashar) [07:47:52] (03Merged) 10jenkins-bot: dockerfiles: add libcurl4-openssl-dev to tox [integration/config] - 10https://gerrit.wikimedia.org/r/604291 (https://phabricator.wikimedia.org/T254338) (owner: 10Hashar) [08:02:22] (03CR) 10Hashar: [C: 03+2] jjb: update tox jobs for libcurl4-openssl-dev [integration/config] - 10https://gerrit.wikimedia.org/r/604292 (https://phabricator.wikimedia.org/T254338) (owner: 10Hashar) [08:03:46] (03Merged) 10jenkins-bot: jjb: update tox jobs for libcurl4-openssl-dev [integration/config] - 10https://gerrit.wikimedia.org/r/604292 (https://phabricator.wikimedia.org/T254338) (owner: 10Hashar) [08:05:32] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review: Fork tox-docker for thumbor with extra dependencies - https://phabricator.wikimedia.org/T254338 (10hashar) 05Open→03Resolved I have added libcurl4-openssl-dev to the base releng/tox image. I have send a dummy change to the... [08:05:49] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Fork tox-docker for thumbor with extra dependencies - https://phabricator.wikimedia.org/T254338 (10hashar) [08:13:47] (03Abandoned) 10Hashar: DonationInterface job should not use composer update [integration/config] - 10https://gerrit.wikimedia.org/r/504917 (owner: 10Hashar) [08:14:30] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/589336 (owner: 10Hashar) [08:19:51] (03CR) 10Hashar: [C: 04-2] "When repositories share the same job, they are put in the same gate-and-submit queue and get serialized one behind each other." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/601931 (owner: 10Jforrester) [08:26:19] (03CR) 10Hashar: [C: 04-1] "That makes VisualEditor/VisualEditor and unicodejs to share the same queue:" [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [08:37:28] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10CptViraj) >>! In T254963#6208772, @Aklapper wrote: > Hi! Could you please elaborate who plans to use that tag and how, and who plans to spend time to constantly look at new incoming tickets and add this ta... [08:50:37] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10Aklapper) @CptViraj: Could you maybe provide two example tasks "related to Gujarati sites" and please be more specific what "related" means exactly? I'm reluctant to have such project tags because nearly e... [09:11:54] (03CR) 10Hashar: "I don't see the advantage over a list and it is consumed entirely when we iterate over all of it for the log.debug(). I am also not a huge" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588092 (owner: 10Awight) [09:14:47] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10CptViraj) >>! In T254963#6209839, @Aklapper wrote: > @CptViraj: Could you maybe provide two example tasks "related to Gujarati sites" and please be more specific what "related" means exactly? > I'm relucta... [09:17:01] Project mediawiki-core-doxygen-docker build #16507: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16507/ [09:33:57] (03CR) 10Jforrester: "> Patch Set 2: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [09:37:34] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10LarsWirzenius) Reported https://phabricator.wikimedia.org/T254985, but didn't make it a blocker. [09:38:05] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10observability: Logstash-Beta cannot be accessed: 504 Gateway Time-out - https://phabricator.wikimedia.org/T254801 (10MarcoAurelio) [09:38:41] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10observability: Logstash-Beta cannot be accessed: 504 Gateway Time-out - https://phabricator.wikimedia.org/T254801 (10MarcoAurelio) [09:53:50] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-CollaborationKit: Undeploy the CollaborationKit extension from Wikipedia production - https://phabricator.wikimedia.org/T254036 (10Jdforrester-WMF) Sorry to hear that. :-( [10:04:09] (03PS1) 10Jforrester: Stop branching the CollaborationKit extension [tools/release] - 10https://gerrit.wikimedia.org/r/604325 (https://phabricator.wikimedia.org/T254036) [10:07:30] 10Project-Admins: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10Aklapper) 05Open→03Resolved a:03Aklapper Thanks, that's helpful. Requested public project #gujarati-sites has been created: https://phabricator.wikimedia.org/project/view/4825/ Please encourage int... [10:17:11] Yippee, build fixed! [10:17:12] Project mediawiki-core-doxygen-docker build #16508: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16508/ [10:20:48] (03CR) 10Jforrester: [C: 03+2] Stop branching the CollaborationKit extension [tools/release] - 10https://gerrit.wikimedia.org/r/604325 (https://phabricator.wikimedia.org/T254036) (owner: 10Jforrester) [10:24:14] (03CR) 10Jforrester: [C: 03+2] "…" [tools/release] - 10https://gerrit.wikimedia.org/r/604325 (https://phabricator.wikimedia.org/T254036) (owner: 10Jforrester) [10:25:05] (03Merged) 10jenkins-bot: Stop branching the CollaborationKit extension [tools/release] - 10https://gerrit.wikimedia.org/r/604325 (https://phabricator.wikimedia.org/T254036) (owner: 10Jforrester) [10:26:42] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-CollaborationKit, 10Patch-For-Review: Undeploy the CollaborationKit extension from Wikipedia production - https://phabricator.wikimedia.org/T254036 (10Jdforrester-WMF) 05Open... [10:27:00] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [10:30:13] (03PS12) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [10:32:01] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [10:37:59] (03PS1) 10Daimona Eaytoy: dockerfiles: [mediawiki-phan] Remove back-compat code [integration/config] - 10https://gerrit.wikimedia.org/r/604335 [10:39:14] (03CR) 10Jforrester: "Thanks for doing this; was on my list for follow-up. :-)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/604335 (owner: 10Daimona Eaytoy) [10:39:33] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10jcrespo) 05Open→03Resolved A reviewdb dump from `2020-06-09 00:00:01` has been loaded into m2, under the reviewdb-test database name. A separate pair of user & password has been created... [10:39:36] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10jcrespo) [10:45:06] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10Marostegui) Thank you for handling this. Is it worth adding that user to the .sql files we have in puppet to track users? [10:45:54] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10jcrespo) > Is it worth adding that user to the .sql files we have in puppet to track users? I intended not to do that as I was told this would only need a week. [10:48:00] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10Marostegui) Sounds good! [10:48:45] (03Abandoned) 10Awight: Rewrite main pipeline as a generator [integration/quibble] - 10https://gerrit.wikimedia.org/r/588092 (owner: 10Awight) [10:51:10] 10Project-Admins, 10Gujarati-Sites: Create tracking project for Gujarati sites - https://phabricator.wikimedia.org/T254963 (10CptViraj) [11:03:39] (03PS6) 10Thiemo Kreuz (WMDE): Add RedundantVarNameSniff from WikibaseCodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603493 [11:07:55] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10Dzahn) This also needs a puppet change to allow changing the database name in Hiera and the password needs to be added to the private repo. Otherwise @QChris would have to have puppet disa... [11:15:16] (03CR) 10Daimona Eaytoy: dockerfiles: [mediawiki-phan] Remove back-compat code (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/604335 (owner: 10Daimona Eaytoy) [11:16:18] (03CR) 10Dzahn: [C: 03+1] "This was still needed but if we really don't need mysql at all anymore as soon as we are on 3.1... we can abandon this I guess." [software/gerrit] (deploy/wmf/stable-2.15) - 10https://gerrit.wikimedia.org/r/548549 (owner: 10Paladox) [11:16:36] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Daimona) [11:17:21] 10Continuous-Integration-Config, 10phan-taint-check-plugin: PHP Warning: Module 'ast' already loaded in Unknown on line 0 for seccheck72 job - https://phabricator.wikimedia.org/T227864 (10Daimona) 05Open→03Declined The job was killed as part of T254152 [11:27:37] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Daimona) [11:29:47] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Daimona) > We need to check whether taint-check supports it before moving on. Local tests say that it does. Also, the changelog only seems to mention changes that... [11:40:33] (03CR) 10DannyS712: [C: 03+1] "LGTM, will wait a few days before giving +2 to allow others to review" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603493 (owner: 10Thiemo Kreuz (WMDE)) [13:12:03] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10LarsWirzenius) Reported https://phabricator.wikimedia.org/T255016, but didn't make it a blocker. [13:16:02] (03PS1) 10Hashar: Fix database dumping [integration/quibble] - 10https://gerrit.wikimedia.org/r/604380 (https://phabricator.wikimedia.org/T239396) [13:19:20] (03CR) 10Hashar: "The tone of my comment was a bit negative, I apologize. Just to clarify, I am fine switching to a generator and Kosta / James seems to lik" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588092 (owner: 10Awight) [13:26:43] https://phabricator.wikimedia.org/T158186 apologize, can someone please fix, I'm unable to [13:31:13] CptViraj: that task is marked resolved, what's wrong? [13:31:43] RhinosF1: projects see history [13:32:13] 10phan, 10Dependency injection: Create an annotation tag to warn about global state in tagged classes - https://phabricator.wikimedia.org/T254936 (10Daimona) It shouldn't be complicated. For the static call part, one would need to implement visitStaticCall, and check the docblock of the current class. For the... [13:32:53] CptViraj: I think that's intended now. It's not supposed to have 2 deploy tags on [13:33:38] Ah [13:34:06] left a comment [13:34:57] ty :) [13:37:27] (03CR) 10Awight: "> The tone of my comment was a bit negative, I apologize. Just to" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588092 (owner: 10Awight) [13:46:43] 10Continuous-Integration-Config, 10phan-taint-check-plugin: PHP Warning: Module 'ast' already loaded in Unknown on line 0 for seccheck72 job - https://phabricator.wikimedia.org/T227864 (10Jdforrester-WMF) Aha, neat. Thanks! [13:56:33] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Jdforrester-WMF) Do you remember why we use v1.0.0 for php70 but v1.0.1 for everything else? Is 1.0.1 incompatible with 70? Also it looks like 0.1.2 is never used... [14:00:05] (03PS1) 10Jforrester: [DNM] dockerfiles: [php-ast] Upgrade to 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604394 (https://phabricator.wikimedia.org/T255004) [14:00:32] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Daimona) >>! In T255004#6211053, @Jdforrester-WMF wrote: > Do you remember why we use v1.0.0 for php70 but v1.0.1 for everything else? Unfor... [14:02:10] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Jdforrester-WMF) OK, let's try doing 1.0.6 for everyone. [14:16:09] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Jdforrester-WMF) Note that we don't currently use the php-ast image for the mediawiki-phan image, which is a special snowflake. *sighs* [14:17:05] Project mediawiki-core-doxygen-docker build #16512: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16512/ [14:19:14] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Daimona) >>! In T255004#6211109, @Jdforrester-WMF wrote: > Note that we don't currently use the php-ast image for the mediawiki-phan image, w... [14:26:22] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Jdforrester-WMF) Yeah, working on it. [14:28:01] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: CI should run composer test/npm test BEFORE running Quibble - https://phabricator.wikimedia.org/T211703 (10hashar) That is not for #Quibble but something to be figured out in Zuul layout.yaml... [14:30:57] (03PS2) 10Jforrester: dockerfiles: [php-ast] Upgrade to 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604394 (https://phabricator.wikimedia.org/T255004) [14:30:59] (03PS1) 10Jforrester: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) [14:31:42] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [php-ast] Upgrade to 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604394 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [14:33:21] (03Merged) 10jenkins-bot: dockerfiles: [php-ast] Upgrade to 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604394 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [14:37:34] !log Docker: Publishing php-ast:1.0.6 and related images T255004 [14:37:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:37:37] T255004: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 [14:45:18] (03CR) 10Jforrester: [C: 04-1] "Don't think this quite works yet." [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [14:53:49] (03PS7) 10Thiemo Kreuz (WMDE): Add RedundantVarNameSniff from WikibaseCodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603493 (https://phabricator.wikimedia.org/T164653) [14:58:51] (03PS1) 10Edward Tadros: Delete Ruby jobs for QuickSurveys [integration/config] - 10https://gerrit.wikimedia.org/r/604414 (https://phabricator.wikimedia.org/T177261) [15:02:48] (03PS2) 10Jforrester: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) [15:02:50] (03PS1) 10Jforrester: jjb: Upgrade jobs using the php-ast image to AST 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604417 [15:17:05] (03CR) 10Jforrester: [C: 03+2] Delete Ruby jobs for QuickSurveys [integration/config] - 10https://gerrit.wikimedia.org/r/604414 (https://phabricator.wikimedia.org/T177261) (owner: 10Edward Tadros) [15:18:26] (03Merged) 10jenkins-bot: Delete Ruby jobs for QuickSurveys [integration/config] - 10https://gerrit.wikimedia.org/r/604414 (https://phabricator.wikimedia.org/T177261) (owner: 10Edward Tadros) [15:18:41] !log Zuul: [mediawiki/extensions/QuickSurveys] Stop running ruby jobs T177261 [15:18:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:18:43] T177261: Rewrite QuickSurveys browser tests in Node.js - https://phabricator.wikimedia.org/T177261 [15:20:23] Yippee, build fixed! [15:20:24] Project mediawiki-core-doxygen-docker build #16513: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16513/ [15:21:58] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [15:36:29] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Fork tox-docker for thumbor with extra dependencies - https://phabricator.wikimedia.org/T254338 (10Gilles) Thanks! [15:43:03] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T253023 (10Tgr) [15:43:06] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release Pipeline (Blubber): Blubber policy should be verified after expansion - https://phabricator.wikimedia.org/T248927 (10DC_Slagel) Great, Thanks :-) [16:02:03] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Aklapper) [16:08:21] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Majavah) [16:30:44] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10CPT Initiatives (API Integration Tests), 10Code-Health, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): Enable API integration tests in CI for MediaWiki core - https://phabricator.wikimedia.org/T236680 (10nnikkhoui) [16:31:31] 10Phabricator, 10Operations, 10Peek, 10Security-Team, 10Patch-For-Review: peek is incorrectly configured to run every minute every 1st of the month, creating large amounts of cronspam - https://phabricator.wikimedia.org/T254127 (10chasemp) `sudo -u peek crontab -l # HEADER: This file was autogenerated at... [16:31:37] 10Phabricator, 10Operations, 10Peek, 10Security-Team, 10Patch-For-Review: peek is incorrectly configured to run every minute every 1st of the month, creating large amounts of cronspam - https://phabricator.wikimedia.org/T254127 (10chasemp) 05Open→03Resolved [16:59:37] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10observability: Logstash-Beta cannot be accessed: 504 Gateway Time-out - https://phabricator.wikimedia.org/T254801 (10thcipriani) Looks like the kibana role was removed Mar 4 3224079cf0f53711bea07163a666531f2475897a Attempted to update to use `prof... [17:01:13] 10Project-Admins: Create Analytics subproject called Analytics-Radar - https://phabricator.wikimedia.org/T254806 (10Nuria) super thanks for the fast response, closing. [17:03:28] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10observability: Logstash-Beta cannot be accessed: 504 Gateway Time-out - https://phabricator.wikimedia.org/T254801 (10Krenair) Can I suggest that efforts may be better placed on getting logstash03 into operation rather than continuing to resurrect o... [17:04:25] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Demo Packer for train development environment group - https://phabricator.wikimedia.org/T253775 (10jeena) 05Open→03Resolved Done! [17:22:52] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: On CI Jenkins, audit worker labels and remove unused ones - https://phabricator.wikimedia.org/T225031 (10Jdlrobson) [17:24:23] (03PS2) 10Jforrester: jjb: Upgrade jobs using the php-ast image to AST 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604417 [17:24:25] (03PS3) 10Jforrester: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) [17:24:28] (03PS1) 10Jforrester: Add VisualEditor and Linter to DiscussionTools's phan deps too [integration/config] - 10https://gerrit.wikimedia.org/r/604456 [17:24:34] (03CR) 10Jforrester: [C: 03+2] Add VisualEditor and Linter to DiscussionTools's phan deps too [integration/config] - 10https://gerrit.wikimedia.org/r/604456 (owner: 10Jforrester) [17:26:07] (03Merged) 10jenkins-bot: Add VisualEditor and Linter to DiscussionTools's phan deps too [integration/config] - 10https://gerrit.wikimedia.org/r/604456 (owner: 10Jforrester) [19:59:50] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10matmarex) [20:00:35] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10matmarex) I don't think T255069 or T255073 require rolling back the train, but they should be fixed before continuing further. [20:15:05] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Xover) T255073 potentially breaks tons of tools, gadgets, user scripts, etc. My call would be to hold until this is pinned down before ro... [21:19:55] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Jdlrobson) [21:30:04] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): Fork tox-docker for thumbor with extra dependencies - https://phabricator.wikimedia.org/T254338 (10AntiCompositeNumber) [21:30:16] 10phan, 10MediaWiki-extensions-CodeReview, 10Patch-For-Review: CodeReview should run phan if it's going to remain in production - https://phabricator.wikimedia.org/T250421 (10Umherirrender) Some work was done in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CodeReview/+/513189/ [22:18:13] 10Beta-Cluster-Infrastructure, 10Product-Infrastructure-Team-Backlog, 10Push-Notification-Service: [BETA] Two push notification request jobs are executed for a single event - https://phabricator.wikimedia.org/T255068 (10Mholloway) [22:26:47] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Addshore) [22:26:58] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Jdlrobson) T255069 was already a bug before this train, but am working to fix T255073 in today's BACON window. [23:08:25] 10Beta-Cluster-Infrastructure, 10Product-Infrastructure-Team-Backlog, 10Push-Notification-Service: [BETA] Two push notification request jobs are executed for a single event - https://phabricator.wikimedia.org/T255068 (10Krinkle) What indicates that these are the "same" job? If we know they are the same, do... [23:57:40] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10Jdlrobson)