[00:01:59] Great, re-checking the MW patch that'll deinstall it on payments-wiki [00:06:33] Reedy: does this failure look like I have to clear out the workspace? https://integration.wikimedia.org/ci/job/mwgate-composer-php70-docker/4428/console [00:06:54] "00:01:56 fatal: No url found for submodule path 'extensions/ContributionTracking' in .gitmodules" [00:07:22] I did remove the ContributionTracking section from .gitmodules as a part of the patch tested there [00:08:58] ejegg: Remove the extensions/ContributionTracking dir too [00:09:12] I dunno if it'll fix it, but it's needed [00:11:27] Otherwise it's in a weird limbo [00:12:15] * Reedy tests [00:14:23] ejegg: Yeah, looks to have sorted the issue [00:16:31] thanks again reedy [00:30:30] 01:24:33 [Symfony\Component\Process\Exception\ProcessTimedOutException] [00:30:30] 01:24:33 The process "'/usr/bin/php7.0' -d allow_url_fopen='1' -d disable_functions='' -d memory_limit='-1' '/usr/bin/composer' phpcs" exceeded the timeout of 300 seconds. [00:30:31] sigh [00:32:14] :P [00:33:57] does that happen a lot? [00:35:22] 10Diffusion, 10MediaWiki-extensions-UploadsLink: UploadsLink revision link form special:version points to 404 error page on Phabricator - https://phabricator.wikimedia.org/T134891 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson Looks fixed to me. [00:37:31] I see that timeout every few days [00:37:48] I wonder if it's related to your extra code.. [00:37:55] or just a mix of old phpcs, old php 7.0 etc [00:42:40] it shouldn't be THAT much extra code compared to mediawiki [00:43:05] fortunately we'll be updating to php 7.3 and MW 1.35 once the new LTS branch is cut [00:44:06] I've not seen it on vanilla REL1_31 [00:44:10] But yeah.. That's what I was thinking [00:44:27] It's not worth wasting much time on trying to fix it, especially if it's not breaking on every run [00:52:24] worked that time! [00:52:45] silly things :) [07:04:43] 10Continuous-Integration-Infrastructure, 10Operations, 10serviceops: replace backends for releases.wikimedia.org with buster VMs - https://phabricator.wikimedia.org/T247652 (10Dzahn) a:03Dzahn [08:07:05] addshore: hi again [08:07:27] had to fight with some water leakage at my place this morning bah [08:29:28] hiiiii! [08:29:32] 10Phabricator: Project Dashboards don't load since today - https://phabricator.wikimedia.org/T255244 (10Dvorapa) [08:30:08] hashar: so I think that daily browser test thingy is the perfect thing to copy right? [08:30:13] 10Gerrit: Project Dashboards don't load since today - https://phabricator.wikimedia.org/T255244 (10Dvorapa) [08:30:22] it allows you to define the job multiple times with a few options and use a job template? [08:30:40] 10Gerrit: Project Dashboards don't load since today - https://phabricator.wikimedia.org/T255244 (10RhinosF1) Should this be tagged with #gerrit not #phabricator [08:31:09] 10Gerrit: Project Dashboards don't load since today - https://phabricator.wikimedia.org/T255244 (10RhinosF1) >>! In T255244#6218431, @RhinosF1 wrote: > Should this be tagged with #gerrit not #phabricator Conflicted, :) [08:31:30] 10Gerrit, 10Regression: Project Dashboards show a 404 since today - https://phabricator.wikimedia.org/T255244 (10Aklapper) p:05Triage→03High [08:32:05] 10Gerrit, 10Regression: Project Dashboards show a 404 since today - https://phabricator.wikimedia.org/T255244 (10RhinosF1) I can only reproduce this for pywikibot [08:33:52] water leak from the tomato watering system? [08:33:59] I wish [08:34:04] 10Gerrit, 10Regression: Project Dashboards show a 404 since today - https://phabricator.wikimedia.org/T255244 (10Aklapper) I see a 404 (using Polygerrit UI). ` delete-project install failed: TypeError: self.onAction is not a function gr-app.js:1500:374 lfs install failed: TypeError: self.panel is not a functi... [08:34:08] a faulty pipe in the bathroom upstair [08:34:17] 10Gerrit, 10Regression: Project Dashboard for Pywikibot show a 404 since today (Plugin not being loaded from /plugins base path) - https://phabricator.wikimedia.org/T255244 (10Aklapper) [08:34:27] the main room ceiling is more or less ruined; Hopefully wood hasn't been affected [08:35:14] :( [08:35:16] oh no :(( [08:35:22] legoktm: !!!!!!! [08:35:26] o///////// [08:37:18] hi addshore :D [08:37:30] can i steal 2 mins of your time? how well does libup work with wikibase? [08:37:34] and how can i make it better? [08:37:35] :D [08:37:42] and, can it do things on github yet? [08:39:24] it works alright with Wikibase, I think there's a bug with wikibase codesniffer right now that I need to track down [08:39:42] https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/WikibaseMediaInfo needs someone to look at it [08:40:05] https://phabricator.wikimedia.org/T243787 is the task for that [08:40:07] 10Gerrit, 10Regression: Project Dashboard for Pywikibot show a 404 since today (Plugin not being loaded from /plugins base path) - https://phabricator.wikimedia.org/T255244 (10Dzahn) https://gerrit.wikimedia.org/r/#/projects/pywikibot,dashboards/default:recent ? [08:43:11] github - no, it's gerrit specific for now. [08:43:17] https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/WikibaseMediaInfo looks like it needs wikibase extension loaded too [08:43:40] it can't run "npm install && npm test" standalone? [08:44:10] as for how to help in general, the most helpful thing right now is to just go through https://libraryupgrader2.wmflabs.org/errors and triage/debug/file issues [08:44:25] awesome [08:44:27] thannkss [08:44:37] 10Gerrit, 10Regression: Project Dashboard for Pywikibot show a 404 since today (Plugin not being loaded from /plugins base path) - https://phabricator.wikimedia.org/T255244 (10Dvorapa) [08:45:59] 10LibUp, 10WikibaseMediaInfo: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies - https://phabricator.wikimedia.org/T243787 (10Addshore) [08:49:27] PROBLEM - Gerrit JSON on gerrit.wikimedia.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds https://wikitech.wikimedia.org/wiki/Gerrit%23Monitoring [08:53:51] RECOVERY - Gerrit JSON on gerrit.wikimedia.org is OK: HTTP OK: HTTP/1.1 200 OK - 27995 bytes in 0.118 second response time https://wikitech.wikimedia.org/wiki/Gerrit%23Monitoring [08:54:31] Project beta-code-update-eqiad build #300097: 04FAILURE in 1 min 29 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/300097/ [09:04:32] Yippee, build fixed! [09:04:33] Project beta-code-update-eqiad build #300098: 09FIXED in 1 min 32 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/300098/ [09:09:38] legoktm: if your still here 1 more question, is libup only automated / daily or something? or can i trigger it to update certain things everywhere? [09:10:25] addshore: it automatically runs daily [09:11:07] https://www.mediawiki.org/wiki/Libraryupgrader/2.0 is slightly outdated, but explains the general procedure [09:11:59] okay, and right, i need to fix the error in https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/Wikibase before it starts running for wikibase again [09:12:00] gotcha [09:12:10] the list of stuff to upgrade is in https://gerrit.wikimedia.org/g/labs/libraryupgrader/config but because of the canary process, it takes a few days to rollout (for emergency/high prio fixes, we can move it faster of course) [09:13:17] right gotcha, I think that might have been one of the steps I was missing [09:16:53] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release, 10Train Deployments: 1.35.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T254173 (10akosiaris) [09:26:58] 10Gerrit, 10DBA, 10Patch-For-Review: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10Dzahn) After the merge above: on gerrit1002: ` - database = reviewdb - username = gerritro + database = reviewdb-test + username = gerrittest ` no change... [09:48:03] 10Release-Engineering-Team-TODO, 10Scap, 10Operations, 10Sustainability (Incident Prevention), 10User-brennen: scap's logstash_checker.py is blissfully unaware of any logstash indexing latency - https://phabricator.wikimedia.org/T255197 (10jbond) p:05Triage→03Medium [09:48:13] (03PS2) 10Hashar: Integration job for Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/604785 (https://phabricator.wikimedia.org/T235118) [09:53:39] (03CR) 10Hashar: "What a rabbit hole, assert_called came with python 3.6, I use 3.7 locally and CI uses 3.5 :(" [integration/quibble] - 10https://gerrit.wikimedia.org/r/604781 (owner: 10Hashar) [10:27:12] (03PS3) 10Hashar: Fix --dry-run due to lack of self.args [integration/quibble] - 10https://gerrit.wikimedia.org/r/604781 [10:30:59] Hi Daimona [10:31:11] Hole [10:31:16] *hOLA [10:31:20] *Hola [10:31:28] Geez I can't type today :D [10:32:27] I think I'll share my espresso with you Daimona :P [10:33:14] I've already had mine, but it's never enough [10:34:19] 10LibUp, 10Wikidata: LibUp Wikibase error semver.exceptions.ParseVersionError: Unable to parse "dev-master#ba6fcfd823d623ba73c2faba5a208067281c4c38" - https://phabricator.wikimedia.org/T255248 (10Addshore) [10:34:56] 10LibUp, 10Wikidata: LibUp Wikibase error semver.exceptions.ParseVersionError: Unable to parse "dev-master#ba6fcfd823d623ba73c2faba5a208067281c4c38" - https://phabricator.wikimedia.org/T255248 (10Addshore) [10:35:33] 10LibUp, 10Wikidata: LibUp Wikibase error semver.exceptions.ParseVersionError: Unable to parse "dev-master#ba6fcfd823d623ba73c2faba5a208067281c4c38" - https://phabricator.wikimedia.org/T255248 (10Addshore) [11:06:19] 10Gerrit: Gerrit upload-pack send ALL references causing massive network I/O on common operations - https://phabricator.wikimedia.org/T103990 (10hashar) Git protocol v2 is enabled by default in Gerrit 3.1, which fixed refs permissions. https://www.gerritcodereview.com/3.1.html#git-protocol-v2 https://gitenterpr... [11:15:04] (03PS3) 10Hashar: Integration job for Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/604785 (https://phabricator.wikimedia.org/T235118) [11:16:16] (03CR) 10Hashar: "Got it running at:" [integration/config] - 10https://gerrit.wikimedia.org/r/604785 (https://phabricator.wikimedia.org/T235118) (owner: 10Hashar) [11:18:27] (03CR) 10Hashar: "I went with a different approach that reuses the existing container and without virtualenv:" [integration/config] - 10https://gerrit.wikimedia.org/r/589438 (https://phabricator.wikimedia.org/T235118) (owner: 10Awight) [11:40:17] 10LibUp, 10Wikidata: libup wikibase Error from chokidar, Error: ENOSPC: System limit for number of file watchers reached - https://phabricator.wikimedia.org/T255247 (10matej_suchanek) [12:05:05] 10LibUp, 10WikibaseMediaInfo: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies - https://phabricator.wikimedia.org/T243787 (10Addshore) > cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock... [12:25:11] 10Phabricator, 10Discourse, 10MediaWiki-extension-requests: Support diagrams on Phabricator and mediawiki.org - https://phabricator.wikimedia.org/T183689 (10Aklapper) The fact that this task says "on Phabricator and mediawiki.org" makes me want to close this as non-actionable. Two totally different and unrel... [13:36:35] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Developer Productivity, 10User-zeljkofilipin: PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) - https://phabricator.wikimedia.org/T220801 (10Paladox) [13:36:37] 10Gerrit, 10Regression: Project Dashboard for Pywikibot show a 404 since today (Plugin not being loaded from /plugins base path) - https://phabricator.wikimedia.org/T255244 (10Paladox) [14:01:30] 10Project-Admins: Create an #WMCH-Infrastructure Tag - https://phabricator.wikimedia.org/T255268 (10valerio.bozzolan) [14:08:38] this jjb stuff confuses me sometimes [14:29:17] Only sometimes? [14:31:46] (03PS1) 10Zfilipin: zuul: Delete Google Summer of Code applicants from trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605244 (https://phabricator.wikimedia.org/T249417) [14:33:20] (03PS2) 10Zfilipin: zuul: Delete Google Summer of Code applicants from trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605244 (https://phabricator.wikimedia.org/T249417) [14:41:46] (03PS1) 10Zfilipin: zuul: Add Jared G. Blumer to trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605247 (https://phabricator.wikimedia.org/T254495) [14:42:08] James_F: do we want {name}-phpmetrics-docker or phpmetrics-docker-{name} in reality? [14:43:24] Generally we go with {name}-first. [14:43:32] is that desired though? :P [14:43:50] Eh. [14:43:50] Also, WikibaseLexeme-phpmetrics-docker or something extra? [14:43:56] Conformancy is helpful. [14:44:09] Is it actually bespoke to that extension? [14:44:41] it wont be with my next patch [14:44:48] well, wait, yes, its a templated job [14:45:01] so I think in terms of that question it is bespoke to the extension [14:45:37] Then mwext-{name}-phpmetrics-docker maybbe? [14:45:50] mhhhm, then I need 2 different templates for core vs extensions though [14:46:14] I think I'll stick to {name}- only for now, as {name} is also the place on doc.wm.o that it ends up, so is alrady unique, i guess [14:46:41] OK. [14:48:38] 10Gerrit, 10Regression: Project Dashboard for Pywikibot show a 404 since today (Plugin not being loaded from /plugins base path) - https://phabricator.wikimedia.org/T255244 (10Dvorapa) 05duplicate→03Resolved Seems resolved now. [14:54:28] selenium-daily-beta-RelatedArticles << maybe I'll follow that pattern [14:54:42] Please don't. [14:54:51] Those jobs need fixing to be named the normal way. [14:55:26] D: okay [14:55:40] how do we feel about Cognate-phpmetrics-docker (note the capitalization? [14:56:28] Sure. [14:56:54] * addshore generates jobs [15:08:09] (03CR) 10Jforrester: [C: 03+2] zuul: Delete Google Summer of Code applicants from trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605244 (https://phabricator.wikimedia.org/T249417) (owner: 10Zfilipin) [15:09:09] https://doc.wikimedia.org/Cognate/master/phpmetrics/ [15:09:21] Fancy. [15:09:23] (03Merged) 10jenkins-bot: zuul: Delete Google Summer of Code applicants from trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605244 (https://phabricator.wikimedia.org/T249417) (owner: 10Zfilipin) [15:10:04] I love that it links to https://en.wikipedia.org/wiki/Halstead_complexity_measures [15:10:46] (03PS2) 10Jforrester: zuul: Add Jared G. Blumer to trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605247 (https://phabricator.wikimedia.org/T254495) (owner: 10Zfilipin) [15:10:52] (03CR) 10Jforrester: [C: 03+2] zuul: Add Jared G. Blumer to trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605247 (https://phabricator.wikimedia.org/T254495) (owner: 10Zfilipin) [15:11:11] (03PS1) 10Addshore: phpmetrics job template and more extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605251 [15:11:19] (03CR) 10jerkins-bot: [V: 04-1] phpmetrics job template and more extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605251 (owner: 10Addshore) [15:11:52] (03Merged) 10jenkins-bot: zuul: Add Jared G. Blumer to trusted users [integration/config] - 10https://gerrit.wikimedia.org/r/605247 (https://phabricator.wikimedia.org/T254495) (owner: 10Zfilipin) [15:13:26] !log Zuul: Update trusted user list per zeljkof [15:13:27] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:13:52] :+1+ [15:13:58] 👍 [15:18:04] (03PS3) 10Jforrester: jjb: Upgrade jobs using the php-ast image to AST 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604417 [15:18:14] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/604417 (owner: 10Jforrester) [15:18:30] (03PS4) 10Jforrester: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) [15:18:56] (03PS2) 10Addshore: phpmetrics job template and more extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605251 [15:19:18] (03Merged) 10jenkins-bot: jjb: Upgrade jobs using the php-ast image to AST 1.0.6 [integration/config] - 10https://gerrit.wikimedia.org/r/604417 (owner: 10Jforrester) [15:21:59] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [15:23:25] (03CR) 10Addshore: [V: 03+2 C: 03+2] "already deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/605251 (owner: 10Addshore) [15:23:34] addshore: No need to V+2. [15:23:51] true, I should have just +1v :P [15:24:11] (03CR) 10Addshore: [V: 03+1 C: 03+2] phpmetrics job template and more extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605251 (owner: 10Addshore) [15:24:15] It's implied when we grant C+2 in this repo that you know to test things. ;-) [15:24:31] (03Merged) 10jenkins-bot: phpmetrics job template and more extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605251 (owner: 10Addshore) [15:28:36] (03PS1) 10Addshore: phpmetrics for most WMDE Wikibase extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605260 [15:33:29] (03PS5) 10Jforrester: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) [15:33:31] (03PS2) 10Jforrester: dockerfiles: [mediawiki-phan] Remove back-compat code [integration/config] - 10https://gerrit.wikimedia.org/r/604335 (owner: 10Daimona Eaytoy) [15:34:14] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [15:35:13] (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan] Switch to php-ast's module [integration/config] - 10https://gerrit.wikimedia.org/r/604407 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [15:37:59] Project WikibaseCirrusSearch-phpmetrics-docker build #1: 04FAILURE in 0.51 sec: https://integration.wikimedia.org/ci/job/WikibaseCirrusSearch-phpmetrics-docker/1/ [15:38:08] Project WikibaseQualityConstaints-phpmetrics-docker build #1: 04FAILURE in 0.5 sec: https://integration.wikimedia.org/ci/job/WikibaseQualityConstaints-phpmetrics-docker/1/ [15:38:16] Project WikbiaseLexemeCirrusSearch-phpmetrics-docker build #1: 04FAILURE in 0.49 sec: https://integration.wikimedia.org/ci/job/WikbiaseLexemeCirrusSearch-phpmetrics-docker/1/ [15:39:16] thats me ^^ [15:39:24] looks like they are not ready for the magic [15:44:30] Boo. [15:47:52] (03PS2) 10Addshore: phpmetrics for most WMDE Wikibase extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605260 [15:48:59] * addshore rebuilds [15:49:41] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [mediawiki-phan] Remove back-compat code [integration/config] - 10https://gerrit.wikimedia.org/r/604335 (owner: 10Daimona Eaytoy) [15:50:42] (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan] Remove back-compat code [integration/config] - 10https://gerrit.wikimedia.org/r/604335 (owner: 10Daimona Eaytoy) [15:53:10] addshore: you know one of those says "Wikbiase" instead of "Wikibase" right? [15:53:30] Wikibias [15:53:34] It's a new project [15:54:15] https://en.wikipedia.org/wiki/Wikipedia:Systemic_bias has existed as a standalone page since 2009, wouldn't exactly call that new [15:54:50] (03PS1) 10Jforrester: dockerfiles: [mediawiki-phan] Base off composer-package-php72 for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/605265 [15:54:53] I think you missed the sarcasm tags [15:55:06] James_F: "Base off" great english there [15:55:26] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [mediawiki-phan] Base off composer-package-php72 for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/605265 (owner: 10Jforrester) [15:55:27] Only slightly better than "Based off of" [15:56:36] Reedy: Terseness is the winning justification. [15:56:39] (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan] Base off composer-package-php72 for simplicity [integration/config] - 10https://gerrit.wikimedia.org/r/605265 (owner: 10Jforrester) [15:57:10] :D [15:57:18] !log Docker: Publishing new mediawiki-phan helper image version [15:57:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:01:51] (03PS3) 10Addshore: phpmetrics for most WMDE Wikibase extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605260 [16:02:58] (03PS1) 10Jforrester: jjb: Switch phan jobs to new helper image [integration/config] - 10https://gerrit.wikimedia.org/r/605268 (https://phabricator.wikimedia.org/T255004) [16:04:47] (03CR) 10Addshore: [C: 03+2] phpmetrics for most WMDE Wikibase extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605260 (owner: 10Addshore) [16:04:52] (03CR) 10Addshore: [V: 03+1 C: 03+2] "all deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/605260 (owner: 10Addshore) [16:05:11] Majavah: Reedy yup, that was my typo :P [16:05:22] I copied the names from some other list, but apparently that list was full of typos [16:06:06] (03Merged) 10jenkins-bot: phpmetrics for most WMDE Wikibase extensions [integration/config] - 10https://gerrit.wikimedia.org/r/605260 (owner: 10Addshore) [16:08:29] (03CR) 10Awight: [C: 03+2] Fix --dry-run due to lack of self.args (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/604781 (owner: 10Hashar) [16:08:35] 10Gerrit, 10VPS-project-codesearch, 10User-DannyS712: gerrit-replica 502/OOM again - https://phabricator.wikimedia.org/T255094 (10thcipriani) >>! In T255094#6217402, @Legoktm wrote: >>>! In T255094#6214940, @hashar wrote: >> We could also have codesearch crawls from local copy of the repositories by replicat... [16:09:39] (03Merged) 10jenkins-bot: Fix --dry-run due to lack of self.args [integration/quibble] - 10https://gerrit.wikimedia.org/r/604781 (owner: 10Hashar) [16:11:46] (03PS2) 10Jforrester: jjb: Switch phan jobs to new helper image [integration/config] - 10https://gerrit.wikimedia.org/r/605268 (https://phabricator.wikimedia.org/T255004) [16:11:59] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/605268 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [16:15:33] (03PS3) 10Jforrester: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 [16:15:44] (03CR) 10Jforrester: [C: 03+2] layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [16:16:30] (03CR) 10Jforrester: "> Patch Set 2: Code-Review-2" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/601931 (owner: 10Jforrester) [16:16:32] (03CR) 10jerkins-bot: [V: 04-1] layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [16:17:37] (03PS4) 10Jforrester: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 [16:18:04] (03Merged) 10jenkins-bot: jjb: Switch phan jobs to new helper image [integration/config] - 10https://gerrit.wikimedia.org/r/605268 (https://phabricator.wikimedia.org/T255004) (owner: 10Jforrester) [16:18:20] (03PS5) 10Jforrester: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 [16:22:23] (03CR) 10Jforrester: [C: 03+2] layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [16:23:23] (03Merged) 10jenkins-bot: layout: Factor out generic-node10-rundoc-docker into node10-rundoc-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601930 (owner: 10Jforrester) [16:23:54] !log Zuul: Factor out generic-node10-rundoc-docker into node10-rundoc-docker template [16:23:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:28:20] (03CR) 10Awight: Define python deps in setup.cfg (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/604702 (https://phabricator.wikimedia.org/T235118) (owner: 10Hashar) [16:31:30] (03PS3) 10Jforrester: layout: Use node10-browser-docker rather than bespoke jobs for several projects [integration/config] - 10https://gerrit.wikimedia.org/r/601931 [16:32:15] (03PS3) 10Jforrester: jjb: Drop {visualeditor,unicodejs,oojs-{core,router}}-node10-browser-docker [integration/config] - 10https://gerrit.wikimedia.org/r/601932 [16:32:36] 10Continuous-Integration-Config, 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to php-ast 1.0.6 in CI - https://phabricator.wikimedia.org/T255004 (10Jdforrester-WMF) 05Open→03Resolved All done. [16:35:30] (03CR) 10Awight: [C: 03+2] "This is a neat wrapper around `atexit`, but not quite ideal. I don't think we'll capture any output or errors during destruction." [integration/quibble] - 10https://gerrit.wikimedia.org/r/604380 (https://phabricator.wikimedia.org/T239396) (owner: 10Hashar) [16:36:30] (03Merged) 10jenkins-bot: Fix database dumping [integration/quibble] - 10https://gerrit.wikimedia.org/r/604380 (https://phabricator.wikimedia.org/T239396) (owner: 10Hashar) [16:46:27] (03PS1) 10Addshore: phpmetrics: fix recipients for emails [integration/config] - 10https://gerrit.wikimedia.org/r/605280 [16:46:47] (03PS2) 10Addshore: phpmetrics: fix recipients for emails [integration/config] - 10https://gerrit.wikimedia.org/r/605280 [16:46:51] (03CR) 10Addshore: [V: 03+1 C: 03+2] phpmetrics: fix recipients for emails [integration/config] - 10https://gerrit.wikimedia.org/r/605280 (owner: 10Addshore) [16:47:19] !log deployed a bunch of phpmetric jobs to jenkins [16:47:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:47:23] (03Abandoned) 10Awight: Don't force remove additional repos [integration/quibble] - 10https://gerrit.wikimedia.org/r/594791 (https://phabricator.wikimedia.org/T211702) (owner: 10Awight) [16:47:57] (03Merged) 10jenkins-bot: phpmetrics: fix recipients for emails [integration/config] - 10https://gerrit.wikimedia.org/r/605280 (owner: 10Addshore) [17:38:13] 10Phabricator, 10Discourse, 10MediaWiki-extension-requests: Support diagrams on Phabricator and mediawiki.org - https://phabricator.wikimedia.org/T183689 (10Tgr) How is that non-actionable? The action is trivially described by the title. Less manageable, maybe; OTOH it wouldn't be very useful to end up with... [18:06:42] 10Continuous-Integration-Config, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Install Jest for unit tests for Vue.js search - https://phabricator.wikimedia.org/T249301 (10Niedzielski) a:05Anribolon→03None [18:27:01] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [18:32:01] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [18:43:20] 10Phabricator, 10Discourse, 10MediaWiki-extension-requests: Support diagrams on Phabricator and mediawiki.org - https://phabricator.wikimedia.org/T183689 (10Demian) >>! In T183689#6218959, @Aklapper wrote: > ... makes me want to close this as non-actionable. Two totally different and unrelated systems... :-/... [19:04:48] !log Fiddling on deployment-deploy01 to investigate T230245 [19:04:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:04:51] T230245: GenerateFancyCaptchas.php crashes with "FormatJson.php: File not found in" after 1000 iterations - https://phabricator.wikimedia.org/T230245 [19:17:45] Project mediawiki-core-doxygen-docker build #16565: 04FAILURE in 13 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16565/ [19:44:28] (03PS10) 10Brennen Bearnes: add jobrunner & tweak settings for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) [20:16:05] Project mediawiki-core-doxygen-docker build #16566: 04STILL FAILING in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16566/ [20:17:21] (03CR) 10Umherirrender: Add RedundantVarNameSniff from WikibaseCodeSniffer (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603493 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [20:29:05] (03PS1) 10Umherirrender: FunctionCommentSniff: Skip type checks for empty type [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/605312 (https://phabricator.wikimedia.org/T254054) [20:46:14] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for method operator followed by newline - https://phabricator.wikimedia.org/T253187 (10Umherirrender) Upstream https://github.com/squizlabs/PHP_CodeSniffer/issues/2987 [20:49:35] 10MediaWiki-Codesniffer: Add sniff to remove semicolon after class declaration - https://phabricator.wikimedia.org/T202922 (10Umherirrender) 05Open→03Resolved a:03Umherirrender Now detected by `Generic.CodeAnalysis.EmptyPHPStatement.SemicolonWithoutCodeDetected` [21:00:16] addshore: so uh, looks like it worked for Wikibase just fine [21:00:32] which? :P [21:07:38] libup! [21:08:04] addshore: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/605191 [21:10:26] oh awesome! [21:10:44] legoktm, next question then, we have multiple package.jsons in the rpo, how hard would it be to make it work for all of them? [21:10:47] :D [21:11:06] that's https://phabricator.wikimedia.org/T228527 [21:11:33] aaaah yes [21:11:46] and also it does npm audit at some stage right? reporting that in the UI? [21:12:25] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Operations, and 2 others: scap's logstash_checker.py is blissfully unaware of any logstash indexing latency - https://phabricator.wikimedia.org/T255197 (10greg) [21:12:35] also, in case your interesting, I made the "phpmetrics" thing a generic job in jjb now, so it can be enabled for extensions! [21:12:41] *interested [21:12:59] https://libraryupgrader2.wmflabs.org/vulns/npm is the aggregated `npm audit` output [21:13:04] but only for the main package.json [21:13:12] ack! [21:13:18] I was kind of waiting for more repos to have multiple package.jsons before investing time into it [21:13:19] https://codesearch.wmflabs.org/search/?q=%5BA-z%5D&i=nope&files=%2Fpackage.json%24&repos= [21:15:48] we would owe you much love if it worked :P [21:16:04] Yippee, build fixed! [21:16:04] Project mediawiki-core-doxygen-docker build #16567: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/16567/ [21:16:25] legoktm: for reference I'm looking at and thinking about https://phabricator.wikimedia.org/T244001 [23:01:13] !log Done fiddling on deployment-deploy01 [23:01:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL