[05:04:24] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10DannyS712) Note for the deployment of the fix for {T255608}: There are two patches, and the core... [07:08:31] 10Project-Admins: Create a Phabricator task board for Soham and Vidhi - https://phabricator.wikimedia.org/T255647 (10DannyS712) [07:32:03] 10Project-Admins: Create a Phabricator task board for Soham and Vidhi - https://phabricator.wikimedia.org/T255647 (10Aklapper) Hi, is this a request for two personal projects, like in https://phabricator.wikimedia.org/T555 ? (One project can have one [workboard](https://www.mediawiki.org/wiki/Phabricator/Project... [07:32:27] 10Project-Admins: Create personal Phabricator project tags for Soham and Vidhi-Mody - https://phabricator.wikimedia.org/T255647 (10Aklapper) [07:55:07] (03PS1) 10Thiemo Kreuz (WMDE): Fix ValidGlobalNameSniff possibly running in an endless loop [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606119 [08:10:13] (03PS1) 10Thiemo Kreuz (WMDE): Fix possible index error in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606120 [08:16:22] (03CR) 10jerkins-bot: [V: 04-1] Fix possible index error in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606120 (owner: 10Thiemo Kreuz (WMDE)) [08:19:34] (03PS1) 10Thiemo Kreuz (WMDE): Fix possible index error in SpaceyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606123 [08:29:15] 10phan, 10MediaWiki-Vagrant, 10Operations: It should be possible to install php-ast using apt-get on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Lokal_Profil) @Mainframe98 Many thanks ! [08:29:18] 10Project-Admins: Create personal Phabricator project tags for Soham and Vidhi-Mody - https://phabricator.wikimedia.org/T255647 (10Soham) @Aklapper I actually meant the user Workboards...my bad. Also uhm two separate dashboards would be lovely, though we dont mind even if we get one since our projects are similar [08:30:20] 10Project-Admins, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Create personal Phabricator project tags for Soham and Vidhi-Mody - https://phabricator.wikimedia.org/T255647 (10zeljkofilipin) [08:33:29] 10Project-Admins, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Create personal Phabricator project tags for Soham and Vidhi-Mody - https://phabricator.wikimedia.org/T255647 (10Majavah) [08:33:29] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555 (10Majavah) [08:38:10] (03PS1) 10Thiemo Kreuz (WMDE): Fix possible index error in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606126 [08:43:33] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10Jdforrester-WMF) [08:47:15] (03PS1) 10Thiemo Kreuz (WMDE): Fix possibl index error in SpaceAfterControlStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606128 [08:48:29] (03PS2) 10Thiemo Kreuz (WMDE): Fix possible index error in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606120 [08:49:03] (03PS2) 10Thiemo Kreuz (WMDE): Fix possible index error in SpaceAfterControlStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606128 [08:57:08] I'm looking at https://integration.wikimedia.org/ci/job/operations-mw-config-php72-composer-test-docker/5883/console and does that mean I should drop it from commonsuploads.dblist [08:58:45] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Jdforrester-WMF) [09:00:09] James_F: ^ [09:00:49] RhinosF1: I'm deploying right now. [09:00:59] James_F: ok [09:01:00] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)): publish-to-doc job is close to its timeout, with some builds lost - https://phabricator.wikimedia.org/T255371 (10hashar) 05Open→03Resolved Solved by raising the... [09:05:51] * RhinosF1 tries it [09:17:05] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10Jdforrester-WMF) [09:34:00] 10phan-taint-check-plugin, 10MediaWiki-extensions-Translate: Phan blocks merge of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/603471 - https://phabricator.wikimedia.org/T255561 (10Nikerabbit) Using Xml class instead of Html did not seem to have any effect. [09:36:36] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, 10Quibble, and 2 others: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty - https://phabricator.wikimedia.org/T246358 (10Lucas_Werkmeister_WMDE) [10:26:21] 10phan-taint-check-plugin, 10MediaWiki-extensions-Translate: Phan blocks merge of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/603471 - https://phabricator.wikimedia.org/T255561 (10Nikerabbit) 05Open→03Resolved a:03Nikerabbit Suppression works, went with that. [10:35:25] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10LarsWirzenius) Promoted group1 just now, outside a normal deployment window, to have more time on... [10:43:15] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10LarsWirzenius) Reported https://phabricator.wikimedia.org/T255658 but not as a train blocker. [10:46:48] (03PS1) 10Thiemo Kreuz (WMDE): Add test for index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 [10:48:57] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: Stop using jsonlint and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Jdforrester-WMF) [10:51:45] (03CR) 10jerkins-bot: [V: 04-1] Add test for index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [11:35:00] (03CR) 10Hashar: Replace fabfile.py with a shell script (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/605434 (https://phabricator.wikimedia.org/T236689) (owner: 10Krinkle) [11:35:25] (03PS4) 10Hashar: Replace fabfile.py with a shell script [integration/config] - 10https://gerrit.wikimedia.org/r/605434 (https://phabricator.wikimedia.org/T236689) (owner: 10Krinkle) [12:06:09] (03CR) 10Brennen Bearnes: "This should actually be good to go, I believe." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) (owner: 10Brennen Bearnes) [12:43:10] 10Phabricator, 10Wikipedia-iOS-App-Backlog (Administrative), 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10Ferdi2005) [12:43:24] 10Phabricator, 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10Ferdi2005) [12:43:56] (03Abandoned) 10Karl Wettin (WMSE): Edit Project Config [services/wikispeech/wikispeech_mockup] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/604763 (owner: 10Karl Wettin (WMSE)) [12:44:37] 10Phabricator, 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10Ferdi2005) [12:45:00] 10Phabricator, 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10Ferdi2005) [12:56:52] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10LarsWirzenius) Reported https://phabricator.wikimedia.org/T255669 but not as a train blocker. [13:14:32] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Phatality: Phatality can't report bugs from very long messages - https://phabricator.wikimedia.org/T255671 (10LarsWirzenius) [13:18:33] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10akosiaris) [13:18:42] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10akosiaris) p:05Triage→03Medium [13:19:09] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Operations, 10Release Pipeline, and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10akosiaris) [13:19:23] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10akosiaris) [13:19:26] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Operations, 10Release Pipeline, and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10akosiaris) [13:21:28] Project beta-update-databases-eqiad build #42911: 04FAILURE in 1 min 27 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42911/ [13:28:16] Project beta-mediawiki-config-update-eqiad build #17439: 04FAILURE in 1.3 sec: https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update-eqiad/17439/ [13:29:45] Yippee, build fixed! [13:29:46] Project beta-mediawiki-config-update-eqiad build #17440: 09FIXED in 3 sec: https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update-eqiad/17440/ [13:33:24] (03CR) 10Jforrester: [C: 03+2] add jobrunner & tweak settings for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) (owner: 10Brennen Bearnes) [13:33:29] (03CR) 10Jforrester: [V: 03+2 C: 03+2] add jobrunner & tweak settings for TimedMediaHandler [releng/dev-images] - 10https://gerrit.wikimedia.org/r/597826 (https://phabricator.wikimedia.org/T247153) (owner: 10Brennen Bearnes) [13:34:13] I just spent an hour building https://github.com/RhinosF1/wmfconfigreader/tree/master simply because I was bored. [13:34:20] * RhinosF1 wonders if it's even useful [13:35:49] (03PS2) 10Jforrester: [WIP] Provide stretch-php73 and stretch php-74 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) [13:35:54] (03CR) 10Jforrester: "Ping. ;-)" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) (owner: 10Jforrester) [13:45:24] beta cluster loginwiki seems to have broken, known? [13:45:51] 403 for /, 500 for any wikipage [13:47:19] Majavah: whole cluster [13:47:23] If you try login [13:47:35] PHP fatal error: [13:47:35] Uncaught ExtensionDependencyError: DiscussionTools requires VisualEditor to be installed. DiscussionTools requires Linter to be installed. in /srv/mediawiki/php-master/includes/registration/ExtensionRegistry.php:404 [13:48:11] Majavah: impossible to login anywhere because of CentralAuth [13:48:28] RhinosF1: that's exactly what I'm complaining about [13:48:31] * Majavah files a phab task [13:49:28] that's not related to the train, is it? [13:49:38] liw: depends [13:49:50] * RhinosF1 checks [13:50:10] liw: prod seems fine [13:50:18] *phew* [13:50:54] RhinosF1, thanks for checking [13:51:25] 10Beta-Cluster-Infrastructure: Loginwiki on beta cluster is broken, causing failures - https://phabricator.wikimedia.org/T255675 (10Majavah) [13:52:22] liw: discussion tools isn't on loginwiki prod [13:52:37] I was testing something else but then this came and now I can't remember what I was trying to test... :/ [13:53:31] 10Beta-Cluster-Infrastructure, 10DiscussionTools: Loginwiki on beta cluster is broken, causing failures - https://phabricator.wikimedia.org/T255675 (10RhinosF1) The most sane thing would probably be to turn off DiscussionTools on loginwiki. It's not going to be used. [13:53:58] * RhinosF1 goes to -2 the patch to turn it on for prod [13:54:49] -1 even [13:57:51] https://gerrit.wikimedia.org/r/#/c/606188/ should fix it, just needs someone to deploy [13:57:53] 10Beta-Cluster-Infrastructure, 10DiscussionTools, 10Patch-For-Review: Loginwiki on beta cluster is broken, causing failures when logging in anywhere on Beta Cluster - https://phabricator.wikimedia.org/T255675 (10Majavah) [13:58:54] (03CR) 10Hashar: Replace fabfile.py with a shell script (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/605434 (https://phabricator.wikimedia.org/T236689) (owner: 10Krinkle) [13:59:00] (03CR) 10Hashar: [C: 03+1] Replace fabfile.py with a shell script [integration/config] - 10https://gerrit.wikimedia.org/r/605434 (https://phabricator.wikimedia.org/T236689) (owner: 10Krinkle) [13:59:21] Majavah: and the setting below as well? [13:59:51] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10LarsWirzenius) https://phabricator.wikimedia.org/T255675#6231642 was mentioned by @RhinosF1 as ha... [13:59:59] RhinosF1: replied on gerrit [14:00:25] (03Abandoned) 10Hashar: [WIP] Port fabfile.py to fabric 2 / Python 3 [integration/config] - 10https://gerrit.wikimedia.org/r/569703 (https://phabricator.wikimedia.org/T236689) (owner: 10Legoktm) [14:01:23] Majavah: hmm [14:01:34] It should be good then [14:04:54] (03Abandoned) 10Hashar: Create a test that deploy's jjb changes without needing to ssh in and deploy your self [integration/config] - 10https://gerrit.wikimedia.org/r/323198 (owner: 10Paladox) [14:05:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Scap (Scap3-Adoption-Phase2), 10Technical-Debt: Migrate deployment of integration/config for zuul / jjb to scap deploy - https://phabricator.wikimedia.org/T129357 (10hashar) [14:05:22] just need someone with deployment access on beta cluster [14:05:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Migrate deployment of integration/config for zuul / jjb to scap deploy - https://phabricator.wikimedia.org/T129357 (10hashar) [14:05:36] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10RhinosF1) >>! In T254174#6231672, @LarsWirzenius wrote: > https://phabricator.wikimedia.org/T2556... [14:08:14] (03Abandoned) 10Hashar: Create an image for building php packages [integration/config] - 10https://gerrit.wikimedia.org/r/500381 (https://phabricator.wikimedia.org/T216712) (owner: 10Giuseppe Lavagetto) [14:09:06] liw: do you have access to deploy the beta config patch? [14:09:53] (03PS1) 10QChris: layout: Enable tox for test/gerrit-ping [integration/config] - 10https://gerrit.wikimedia.org/r/606191 [14:09:55] (03PS1) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:10:42] (03CR) 10jerkins-bot: [V: 04-1] layout: Enable tox for test/gerrit-ping [integration/config] - 10https://gerrit.wikimedia.org/r/606191 (owner: 10QChris) [14:10:47] 10Continuous-Integration-Config, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Install Jest for unit tests for Vue.js search - https://phabricator.wikimedia.org/T249301 (10Niedzielski) a:03Jdrewniak I think @jdrewniak said he'd sign this one off so I'm putting his face on it. Plea... [14:10:48] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:10:52] RhinosF1, I'd be the wrong person to do that, I'm afraid [14:11:06] no problem [14:11:37] (03Abandoned) 10Hashar: layout: Add extension-production and skin-production short-cut templates [integration/config] - 10https://gerrit.wikimedia.org/r/547355 (owner: 10Jforrester) [14:13:21] someone needs to just merge and apply the config patch on production and it should update automatically on beta cluster [14:15:51] (03PS2) 10QChris: layout: Enable tox for test/gerrit-ping [integration/config] - 10https://gerrit.wikimedia.org/r/606191 [14:15:53] (03PS2) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:16:36] (03CR) 10Hashar: "It might easier to just remove the git repository from the container." [integration/config] - 10https://gerrit.wikimedia.org/r/568147 (owner: 10Jforrester) [14:16:50] (03CR) 10Hashar: [C: 04-1] Dockerfiles: [operations/puppet] Limit clone of puppet [integration/config] - 10https://gerrit.wikimedia.org/r/568147 (owner: 10Jforrester) [14:17:06] * RhinosF1 is here but mobile if it does get deployed [14:17:17] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:18:17] (03CR) 10QChris: "This is of course not yet for gerrit-test.wikimedia.org, but" [integration/config] - 10https://gerrit.wikimedia.org/r/606191 (owner: 10QChris) [14:20:00] (03PS5) 10Hashar: Fail when repository lacks gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/594507 [14:20:04] (03PS3) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:20:24] qchris: ;)) [14:20:32] Heya :-) [14:20:59] I think it's time to let Jenkins/Zuul do some work for gerrit-test.wikimedia.org :-) [14:21:18] The patches I pushed are really rough. No clue if that would work or not. [14:21:21] qchris: definitely yeah ;] [14:21:25] I don't either [14:21:27] but well [14:21:33] they use yaml aliases, so that must be fine [14:21:34] Project beta-update-databases-eqiad build #42912: 04STILL FAILING in 1 min 33 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42912/ [14:22:02] It would be nice to re-use everthing from gerrit.wikimedia.org. And it would allow multiple triggers, if I read the docs correctly. [14:22:07] But reporting is the issue. [14:22:26] We cannot simply say "report on the same gerrit that the event came from" :-( [14:24:28] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:24:39] (03CR) 10jerkins-bot: [V: 04-1] Fail when repository lacks gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/594507 (owner: 10Hashar) [14:25:42] Mhmm. Seems my YAML is still broken :-( [14:26:50] (03PS4) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:27:57] 10Phabricator, 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10Aklapper) a:05Aklapper→03None Please don't assign a task to an individual if an individual has not explicitly agreed on working on a task. See https://www.mediawiki.org/wiki... [14:27:59] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:29:02] (03PS5) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:30:39] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:31:18] qchris: assuming you have python2.7 / tox locally. You should be able to run the tests using ./utils/zuul-layout-validate.sh [14:31:26] which would set up the virtualenv with zuul installed [14:31:38] and ask it to load and validate the config file [14:32:15] That would work? (I only saw "$ZUUL_SERVER_BIN" and did not think further to run that script) [14:32:18] Will try. [14:33:04] * qchris tries to close the door to the abyss, which automatically flung open when "Python 2.7" was mentioned. [14:33:58] hehe [14:39:24] I've got Python 2.7 now. But running the script gives me a few pages of pip warnings about TLS issues and fatal one is where it tries to clone 'https://gerrit.wikimedia.org/r/integration/zuul.git#egg=zuul' and obviously chokes on the '#egg=zuul' part. [14:39:44] I guess I'll keep debugging through Gerrit (unless that's too much noise for the others) [14:40:34] argh [14:40:41] maybe I can polish up the patch [14:41:09] Meh. Not worth it. [14:41:36] (03CR) 10Hashar: [C: 03+2] layout: Enable tox for test/gerrit-ping [integration/config] - 10https://gerrit.wikimedia.org/r/606191 (owner: 10QChris) [14:41:37] I mean... the YAML is causing issues. And I see the problem. Just my YAML foo is too weak to see the obvious solution. [14:42:21] ./utils/zuul-layout-tester.sh zuul/layout.yaml [14:42:26] will check [14:43:01] (03Merged) 10jenkins-bot: layout: Enable tox for test/gerrit-ping [integration/config] - 10https://gerrit.wikimedia.org/r/606191 (owner: 10QChris) [14:43:08] Still the same: [14:43:10] ERROR: Command errored out with exit status 128: git clone -q 'https://gerrit.wikimedia.org/r/integration/zuul.git#egg=zuul' /tmp/pip-install-csc7i0/zuul Check the logs for full command output. [14:43:56] But I'm sure I can fix the YAML without getting zuul set up locally :-) [14:48:30] (03PS6) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:49:00] qchris: so hmm the syntax is probably valid; But the layout validation does not support a gerrit_test driver apparently [14:49:13] or maybe not [14:49:16] well I gotta dig into the code [14:49:28] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:49:59] I read the error message as "The merge already provided a key. And you added a second one. We do not want that" [14:51:34] OH [14:51:39] tests/fixtures/zuul-dummy.conf [14:51:47] that is the fake zuul.conf for the tests [14:51:55] so I guess we "just" have to define the gerrit_test ocnnection there [14:52:13] Oh! [14:53:28] (03PS7) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:53:29] !log Reloading Zuul for I5f10c7438a1514d705d1b0b8569c325305982366 [14:53:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:54:17] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:54:23] qchris: https://phabricator.wikimedia.org/P11570 [14:54:25] sorry :( [14:54:43] I completely forgot about that fixutre config file when I have updated the production ones [14:55:22] that moves me to another error related to one of the pipeline having some faulty "description" field: voluptuous.error.MultipleInvalid: extra keys not allowed @ data['pipelines'][21]['description description'] [14:55:42] I tried adding gerrit_test in the latest PS. Now it complains about "MultipleInvalid: extra keys not allowed @ data['pipelines'][1]['success']['gerrit_test']" [14:55:54] is there another place in the fixtures where gerrit_test should be added? [14:56:48] voluptuous is a pain :( [14:57:56] (03PS8) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [14:58:33] qchris: [gerrit] is a legacy sectio nname [14:58:38] the real one should be instead: [14:58:41] [connection gerrit] [14:58:44] driver = gerrit [14:58:47] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [14:58:51] so for gerrit_test the fixture config should have two lines: [14:58:55] [connection gerrit_test] [14:58:57] driver = gerrit [14:59:01] I'll try adding https://gerrit.wikimedia.org/r/#/c/integration/config/+/606192/8/tests/fixtures/zuul-dummy.conf [14:59:15] Grrr. Copy/paste buffer was wrong. [14:59:20] https://gerrit.wikimedia.org/r/#/c/integration/config/+/606192/8/tests/fixtures/zuul-dummy.conf [14:59:28] ^ is what I'm currently trying. [14:59:49] Yup. That matches what you suggested. [14:59:59] yeah [15:00:01] sorry :( [15:00:06] which leads to voluptuous.error.MultipleInvalid: extra keys not allowed @ data['pipelines'][21]['description description'] [15:00:15] That is great! [15:00:25] Because that means the first of the two pipelines worked. [15:00:31] Now only the second is causing errors. [15:00:39] I'll remove the !!merge from there too. [15:00:51] \o/ [15:00:53] 774 description description: Jobs for after a commit is successfully merged on gerrit-tes t. [15:01:05] cause well "description description" is not a valid key ;]]) [15:02:13] (03PS9) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [15:02:57] Huh? :-) [15:03:20] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [15:03:38] bah [15:04:46] * hashar digs in https://integration.wikimedia.org/ci/job/integration-config-tox-docker/3261/console [15:04:49] The recent error is again for the first of the two new pipelines. [15:04:57] 00:00:44.094 MultipleInvalid: extra keys not allowed @ data['pipelines'][1]['failure']['gerrit_test'] [15:05:18] 10Beta-Cluster-Infrastructure, 10DiscussionTools, 10Patch-For-Review, 10User-Majavah: Loginwiki on beta cluster is broken, causing failures when logging in anywhere on Beta Cluster - https://phabricator.wikimedia.org/T255675 (10Majavah) 05Open→03Resolved a:03Majavah Fix deployed [15:05:40] but it works locally [15:05:43] !log Private config for MediaModeration extension added on Beta Cluster for T247943 [15:05:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:05:46] T247943: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 [15:06:56] Let me try the very zuul-dummy.conf that you pasted. [15:07:46] (03PS10) 10QChris: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 [15:08:32] You had driver before server, I had it the other way round. And I had the driver line without spaces around the '='. Let's find out if that helps. [15:08:40] (03CR) 10jerkins-bot: [V: 04-1] layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [15:08:44] Nope :-( [15:09:22] ah [15:09:23] I can reproduce [15:09:26] tox -e zuul_tests -- tests.test_zuul_scheduler.TestZuulScheduler [15:10:17] cause evidently that test class crafts its own config file bah [15:10:56] Oh! :-( [15:11:25] easy [15:11:38] I'll just patch up that config in the test :-) [15:11:54] qchris: I am amending [15:11:54] f [15:11:55] (03PS11) 10Hashar: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [15:12:04] Ok. Thanks. [15:12:09] https://gerrit.wikimedia.org/r/#/c/integration/config/+/606192/11/tests/test_zuul_scheduler.py [15:12:28] that is cause that test suite actually runs the zuul scheduler [15:12:37] and surely we dont want to try to connect to whatever.example.org ;] [15:12:48] True. True. [15:13:25] when utils/zuul-layout-tester just validate the layout (the scheduler is not started) [15:13:43] (it is not like I knew about anything above before!!) [15:14:31] Hahaha. You are wise. I still have no clue about anything :-D [15:14:57] It worked! [15:15:11] You sir, are a true scholar and gentlemen, hashar! [15:15:19] Thank you so much! [15:15:50] I guess that's now the perfect time to go to dinner :-) I'll fix this all up later and push something working for review tomorrow. [15:15:51] meanwhile I have just learned about singer Beyoncé : https://en.wikipedia.org/wiki/Beyonc%C3%A9 [15:15:58] Would that be ok? [15:15:58] never heard of her before ... I am old [15:16:09] dinner at 5pm? [15:16:33] Yes. The kids go to bed at 7pm :-) [15:16:38] ahhhh [15:17:09] yeah you are further to the east than me. in France we are just shifted/permanently jetlagged by an hour (dinner at 7pm, kids bed is 8pm) [15:17:21] I will look at the layout change that you have introduced and deploy it in a few minutes [15:17:41] Ok. Thanks. I'll get the rest in shape today in the evening. [15:17:47] Thanks again! [15:18:02] See you. [15:18:03] * qchris heads off to dinner. [15:18:57] 00:00:47.243 +INFO:zuul.IndependentPipelineManager: Source: [15:19:08] (03CR) 10Hashar: [C: 03+2] "Excellent, thank you!" [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [15:21:44] (03Merged) 10jenkins-bot: layout: Add basic pipelines for gerrit-test.wikimedia.org [integration/config] - 10https://gerrit.wikimedia.org/r/606192 (owner: 10QChris) [15:22:06] Yippee, build fixed! [15:22:06] Project beta-update-databases-eqiad build #42913: 09FIXED in 2 min 5 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/42913/ [15:22:13] !log Reloading zuul for gerrit-test.wikimedia.org Iaaa7e8797d779578a6a42f735bb7c809e29f415a [15:22:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:22:35] Jun 17 15:22:27 contint2001 zuul-server[22093]: 2020-06-17 15:22:27,030 WARNING zuul.Scheduler: No old pipeline matching test-gerrit-test found when reconfiguring [15:22:35] Jun 17 15:22:27 contint2001 zuul-server[22093]: 2020-06-17 15:22:27,031 WARNING zuul.Scheduler: No old pipeline matching postmerge-gerrit-test found when reconfiguring [15:22:38] which is fine [15:23:02] and the new pipelines show up on https://integration.wikimedia.org/zuul/ [15:26:41] cmdline: git fetch -v origin refs/changes/08/605608/1 [15:26:41] stderr: 'fatal: Couldn't find remote ref refs/changes/08/605608/1' [15:26:42] :( [15:27:56] (03CR) 10Krinkle: [C: 04-1] Replace fabfile.py with a shell script (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/605434 (https://phabricator.wikimedia.org/T236689) (owner: 10Krinkle) [15:29:49] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10Jdforrester-WMF) [15:30:40] qchris: so yeah zuul fetches from origin, not the url :-\\ [15:38:02] I will need to backport a patch for Zuul [15:38:19] and puppetize the gerrit-test ssh (29418) host key [15:38:27] not the end of the world, will look at it later this evening [15:38:38] kids time [15:41:09] (03CR) 10Jforrester: "Ha, forgot about this, clearly." [integration/config] - 10https://gerrit.wikimedia.org/r/547355 (owner: 10Jforrester) [15:42:16] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Python3-Porting: Upgrade integration/config to use Fabric 2.x / python3 - https://phabricator.wikimedia.org/T236689 (10Jdforrester-WMF) 05Open→03Declined... [15:42:38] 10Phabricator, 10Operations, 10Traffic: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10sbassett) Removing #security-team as this is now managed by #operations. [15:48:24] 10Phabricator (Upstream), 10Phragile, 10Upstream: [Phabricator] Expose a project's removed tasks through Conduit - https://phabricator.wikimedia.org/T100657 (10Aklapper) 05Open→03Declined Declining this task as Phragile is not under development or maintained anymore - see T240308#6164990 [15:49:03] 10Phabricator, 10Operations, 10Traffic: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10Dzahn) @sbassett Where can Operations find information on where and how these blocks are configured? (also: T229620#5386233 , T218589) [16:02:46] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Configure ESLint and stylelint for Vue.js search development ahead of it being done for all repos - https://phabricator.wikimedia.org/T249304 (10Anribolon) a:03Anribolon [16:05:55] 10Phabricator, 10Operations, 10Traffic: Accessing Phabricator from Tor - https://phabricator.wikimedia.org/T254568 (10sbassett) @Dzahn - @herron and @chasemp would have the most domain knowledge about this right now, as they initially worked on T218784. @JBennett should also be able provide any broad securi... [16:09:14] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Configure ESLint and stylelint for Vue.js search development ahead of it being done for all repos - https://phabricator.wikimedia.org/T249304 (10Jdforrester-WMF) I believe this is no long... [16:23:15] (03CR) 10Brennen Bearnes: [C: 03+2] "> Patch Set 2:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) (owner: 10Jforrester) [16:23:28] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] [WIP] Provide stretch-php73 and stretch php-74 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) (owner: 10Jforrester) [16:24:33] (03PS2) 10Thiemo Kreuz (WMDE): Add test for index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 [16:25:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] FunctionCommentSniff: Handle empty type when adding null default [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/605312 (https://phabricator.wikimedia.org/T254054) (owner: 10Umherirrender) [16:26:54] (03Merged) 10jenkins-bot: FunctionCommentSniff: Handle empty type when adding null default [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/605312 (https://phabricator.wikimedia.org/T254054) (owner: 10Umherirrender) [16:30:51] (03CR) 10jerkins-bot: [V: 04-1] Add test for index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [16:33:52] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Nullable autofix has issues if no type is given - https://phabricator.wikimedia.org/T254054 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium a:03Umherirrender [16:43:50] (03CR) 10Umherirrender: Fix ValidGlobalNameSniff possibly running in an endless loop (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606119 (owner: 10Thiemo Kreuz (WMDE)) [16:48:45] (03CR) 10Umherirrender: [C: 03+1] Fix possible index error in SpaceyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606123 (owner: 10Thiemo Kreuz (WMDE)) [16:49:52] (03CR) 10Umherirrender: [C: 03+1] Fix possible index error in SpaceAfterControlStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606128 (owner: 10Thiemo Kreuz (WMDE)) [16:51:36] (03CR) 10Umherirrender: [C: 03+1] Fix possible index error in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606126 (owner: 10Thiemo Kreuz (WMDE)) [16:53:52] (03CR) 10Umherirrender: Fix possible index error in ParenthesesAroundKeywordSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606120 (owner: 10Thiemo Kreuz (WMDE)) [16:57:55] (03Abandoned) 10EBernhardson: Edit Project Config [wikidata/query/rdf] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/606208 (owner: 10EBernhardson) [16:59:26] (03CR) 10Umherirrender: "Your test case finds problems with upstream code. Needs a upstream issue/fix" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [17:04:13] 10Continuous-Integration-Config, 10Code-Health, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): Configure ESLint and stylelint for Vue.js search development ahead of it being done for all repos - https://phabricator.wikimedia.org/T249304 (10Niedzielski) @Jdforrester-WMF, we don't ha... [17:21:32] (03PS1) 10Hashar: WMF: backport Set remote url on every getRepo in merger [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/606226 [17:25:11] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) 05Resolved→03Open Once deployed, the zuul-... [17:25:19] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10hashar) [17:25:29] (03PS2) 10Hashar: WMF: backport Set remote url on every getRepo in merger [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/606226 (https://phabricator.wikimedia.org/T253263) [17:36:36] (03CR) 10Thiemo Kreuz (WMDE): "Indeed. ;-) I already did that, see https://github.com/squizlabs/PHP_CodeSniffer/pull/2990." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [17:38:54] 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10WikimediaMessages, 10EngProd-Virtual-Hackathon: Put "shim" code for namespaces, logs, and log i18n into WikimediaMessages so we can undeploy extensions - https://phabricator.wikimedia.org/T222918 (10Jdforrester-WMF) [17:40:49] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10TimedMediaHandler, 10local-charts, 10User-brennen: Add Timed media handler to local-charts - https://phabricator.wikimedia.org/T253773 (10brennen) [17:41:20] (03CR) 10Umherirrender: "I have only looked for issues, not pull requests ;-)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [17:43:14] (03CR) 10Thiemo Kreuz (WMDE): Fix ValidGlobalNameSniff possibly running in an endless loop (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606119 (owner: 10Thiemo Kreuz (WMDE)) [17:43:27] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10Developer Productivity, 10Train Deployments: Create a development & testing environment for scap + train deployments - https://phabricator.wikimedia.org/T255695 (10mmodell) [17:45:49] (03PS4) 10Jforrester: Switch example image from old node6 image to current node10 one [blubber] - 10https://gerrit.wikimedia.org/r/580167 [17:46:45] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10Developer Productivity, 10Train Deployments: Create a development & testing environment for scap + train deployments - https://phabricator.wikimedia.org/T255695 (10mmodell) a:03mmodell @LarsWirzenius and I are working on this [17:46:53] (03CR) 10Umherirrender: Fix ValidGlobalNameSniff possibly running in an endless loop (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606119 (owner: 10Thiemo Kreuz (WMDE)) [17:46:59] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Addshore) >>! In T253624#6165716, @Ladsgroup wrote: >>>! In T253624#6165674, @Krinkle wrote: >> Note that `phpcs` ruleset is controllable per repository. The same way that we disable... [17:47:47] (03PS3) 10Hashar: WMF: backport Set remote url on every getRepo in merger [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/606226 (https://phabricator.wikimedia.org/T253263) [17:47:50] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap, 10Developer Productivity, 10Train Deployments, 10User-brennen: Create a development & testing environment for scap + train deployments - https://phabricator.wikimedia.org/T255695 (10brennen) [17:57:22] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Addshore) >>! In T223410#6174639, @Jdforrester... [17:59:36] 10Continuous-Integration-Infrastructure, 10User-Addshore: un blacklist https://integration.wikimedia.org/ci/computer/XXXX/builds - https://phabricator.wikimedia.org/T178458 (10Addshore) Nope https://integration.wikimedia.org/ci/computer/contint1001/builds [18:00:21] (03PS1) 10Thiemo Kreuz (WMDE): Fix one more index error in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606228 [18:02:00] (03CR) 10Thiemo Kreuz (WMDE): Fix possible index error in ParenthesesAroundKeywordSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606120 (owner: 10Thiemo Kreuz (WMDE)) [18:07:17] (03CR) 10Thiemo Kreuz (WMDE): Fix ValidGlobalNameSniff possibly running in an endless loop (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606119 (owner: 10Thiemo Kreuz (WMDE)) [18:16:11] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Jdforrester-WMF) [18:18:48] 10Release-Engineering-Team-TODO, 10Growth-Team, 10MediaWiki-extensions-GettingStarted, 10User-notice: Deprecate/undeploy the GettingStarted extension - https://phabricator.wikimedia.org/T235752 (10Jdforrester-WMF) a:05Jdforrester-WMF→03None [18:19:56] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics, 10good first task: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Jdforrester-WMF) Possible #good_first_... [18:20:22] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review: Rename all our quibble jobs to make some sense - https://phabricator.wikimedia.org/T254814 (10Jdforre... [18:26:34] 10Phabricator, 10Developer Productivity: Enhance phabricator project progress reporting - https://phabricator.wikimedia.org/T255703 (10mmodell) [18:30:28] (03CR) 10Jforrester: [C: 04-2] "OK, will re-do this so we have the whole cascade." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/598103 (https://phabricator.wikimedia.org/T245444) (owner: 10Jforrester) [18:30:38] 10Phabricator, 10Release-Engineering-Team-TODO, 10Developer Productivity: Enhance phabricator project progress reporting - https://phabricator.wikimedia.org/T255703 (10mmodell) [18:31:25] (03CR) 10Hashar: [V: 03+2 C: 03+2] WMF: backport Set remote url on every getRepo in merger [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/606226 (https://phabricator.wikimedia.org/T253263) (owner: 10Hashar) [18:31:53] hashar: \o/ Yay! [18:32:55] ;D [18:33:34] I just need to cherry pick some docker container of doom ( https://gerrit.wikimedia.org/r/#/c/operations/docker-images/production-images/+/605653/ ) [18:33:35] bah [18:33:38] rabbit hole [18:33:53] Harr. [18:38:41] and of course our build uses a Makefile bah [18:40:50] I'm pretty much lost at how WMF builds them. If there is anything I can do to help, please just let me know. [18:45:49] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.35.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T254174 (10brennen) a:05LarsWirzenius→03brennen Currently on all wikis, but we're keeping an eye on T255... [18:50:14] I am such a hacker [18:50:17] * hashar brags [18:50:23] You tha best! [18:50:26] qchris: how I am entirely lost as well [18:50:36] but I am a big fan of the movie "Inception" [18:50:41] that accurately describe my work [18:50:51] in short [18:50:57] * qchris puts Inception on his "to watch" list. [18:51:02] we use an outdated fork of a python project [18:51:16] to deploy it we use our own custom deployment system "scap" [18:51:32] the python projects has dependencies we don't want to install from the internet [18:51:40] nor do we want to suffer the pain of building debian packages [18:51:51] luckily python has a packaging system of some sort known as wheels [18:52:02] so in our deployment repo, we use a docker container to build those packaged dependencies [18:52:04] Oh. I feel the pain already. [18:52:10] the container being a Buster image just like the contint machines [18:52:25] and that container is build with yet another homemade software: docker-pkg [18:52:54] so when any rookie would just ask their favorite cloud system to just boot the random crappy image from dockerhub [18:53:02] we do it all the hard way ;] [18:53:05] but [18:53:18] our way is safer ! [18:53:26] so yeah there is hmm a long chain of stuff [18:53:29] (03PS1) 10MSantos: Add run-node.sh script to allow node projects... [integration/config] - 10https://gerrit.wikimedia.org/r/606241 (https://phabricator.wikimedia.org/T240989) [18:53:46] The "safer" part comes on the "good" side of the list :-) [18:54:34] (03CR) 10jerkins-bot: [V: 04-1] Add run-node.sh script to allow node projects... [integration/config] - 10https://gerrit.wikimedia.org/r/606241 (https://phabricator.wikimedia.org/T240989) (owner: 10MSantos) [18:55:07] (03PS1) 10Hashar: Reuse previous artifacts as a wheel cache [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606242 [18:57:53] 10Release-Engineering-Team, 10Operations, 10serviceops, 10Developer Productivity, and 2 others: All debug hosts give (likely spurious) message: PHP Fatal error: The UdpSocket to 127.0.0.1:10514 has been closed (from Monolog/SyslogUdp) - https://phabricator.wikimedia.org/T214734 (10Krinkle) Debug-only, not... [19:00:03] qchris: so anyway to the topic [19:00:16] zuul does create a ssh script wrapper for each of the gerrit connections [19:00:17] (03PS2) 10Hashar: Reuse previous artifacts as a wheel cache [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606242 [19:00:18] (03PS1) 10Hashar: backport Set remote url on every getRepo in merger [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606243 (https://phabricator.wikimedia.org/T253263) [19:00:21] so I assumed it would work just fine [19:00:37] but ... it does not update the remote and always fetch using 'origin' [19:00:49] the patch I borrowed from upstream sets the remote url whenever needed [19:00:52] tis magic [19:01:01] * qchris likes magic. [19:01:19] kids discussion: "dad why don't we have a planet president"? [19:01:28] me: whenever that happens alien will pay us a visit! [19:02:35] :-D Your kids are older. Good to see things get easier, when they get older. [19:02:38] I had to explain today how live and everything started. [19:02:51] "How did the first cell get created?" [19:04:19] oh that is easy [19:04:22] there is a book for it [19:04:31] The Old Testament [19:04:35] Hahahaha. [19:04:50] Not sure killing etc is a good topic for 5 and 3 year olds. [19:04:53] it explains everything in super easy terms [19:05:10] joke aside, there are bible versions appropriate for young kids [19:05:24] without the epic blockbuster violent drama [19:05:29] But New Testament mostly :-) [19:06:22] (03CR) 10Kosta Harlan: [C: 04-1] "Thanks for taking this up!" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/606241 (https://phabricator.wikimedia.org/T240989) (owner: 10MSantos) [19:06:26] (03CR) 10Hashar: [V: 03+2 C: 03+2] "I have build it with the follow up change https://gerrit.wikimedia.org/r/#/c/integration/zuul/deploy/+/606242/2 to avoid rebuilding every" [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606243 (https://phabricator.wikimedia.org/T253263) (owner: 10Hashar) [19:06:47] I hate force merging stuff [19:07:19] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Catrope) What's the rationale behind doing the... [19:07:23] so potentially I could now update the faulty process (zuul-merger) [19:07:36] and leave the zuul scheduler running with the old code [19:07:39] but that sounds scary [19:16:27] qchris: deploying / testing [19:16:32] Wohooo! \o/ [19:16:59] (03PS1) 10QChris: layout: De-duplicate gerrit-test pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/606246 [19:17:01] (03PS1) 10QChris: layout: Rename the gerrit-test pipelines to start in gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606247 [19:17:54] (03CR) 10jerkins-bot: [V: 04-1] layout: De-duplicate gerrit-test pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/606246 (owner: 10QChris) [19:18:00] (03CR) 10jerkins-bot: [V: 04-1] layout: Rename the gerrit-test pipelines to start in gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606247 (owner: 10QChris) [19:19:19] (03PS2) 10QChris: layout: De-duplicate gerrit-test pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/606246 [19:20:17] Mhmmm. I see the recheck on https://gerrit-test.wikimedia.org/r/c/test/gerrit-ping/+/605608 Mhmmm [19:20:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) I have deployed the change to `contint1001` wh... [19:21:00] qchris: the patch works \o/ [19:21:05] but I gotta file in the ssh key now [19:21:19] Yippie!!! [19:24:18] so yeah hmm [19:24:21] now I need to write a test [19:27:53] qchris: meanwhile, gerrit-test web interface seems a bit more reactive ;] [19:28:15] Yup. We still have to port our WMF theme over. [19:28:37] But I like it a lot more than the "New UI" of our current production gerrit. [19:29:09] yeah it is aged [19:29:31] oh and I can't even use the "New UI" from Gerrit 2.15 cause it lacks a bunch of the view I need as an admin of Gerrit [19:30:00] + Gerrit 3.1 come with git protocol v2 which will make everything so much faster [19:30:01] (03PS2) 10QChris: layout: Rename the gerrit-test pipelines to start in gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606247 [19:30:03] (03PS1) 10QChris: layout: Add gate-and-submit job for gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606250 [19:30:39] They added v2. Then turned it off again. Then on again. We'll see how usable it is for WMF. [19:32:21] one needs a recent enough cgit [19:32:29] and it might behind a feature flag [19:32:52] Yes for sure. And Gerrit supports v1 still :-) [19:33:07] So no one is forced to upgrade. [19:33:50] as I understood it, some folks at Google eventually got fed up of waiting [19:34:00] and went enhancing git in a back compatible maneer [19:34:14] but yeah that is great [19:35:44] brennen: is the jobrunner image built? I see `ERROR: manifest for docker-registry.wikimedia.org/dev/stretch-php72-jobrunner:0.0.1 not found: manifest unknown: manifest unknown` when I try to pull [19:40:26] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10kostajh) Here's what the robot comments look like in Gerrit 3.2 (click the Findings tab): https://gerrit-test.wikimedia.org/r/c/mediawiki/extens... [19:40:58] qchris: i poked SRE about the puppet patch i have made ;) [19:41:14] Cool. I'm just double-checking the RSA key. [19:43:46] kostajh: gah, my bad - a deploy incoming [19:44:08] i had "get this merged and deployed" on my checklist and managed to lose track of the "and deployed" part between meetings and train log triage. [19:46:02] !log Updating dev-images docker-pkg files on primary contint for jobrunner changes (T246935) [19:46:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:46:53] T246935: Job queue runners for MediaWiki-Docker - https://phabricator.wikimedia.org/T246935 [19:53:00] brennen: no worries :) thanks! [19:57:03] sure thing, thanks for the heads up. build should finish... eventually. [19:57:47] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) ` 2020-06-17 19:56:22,55... [19:58:46] ^ :-( [19:59:30] yeah [19:59:35] qchris: so i am terrible :( [19:59:49] No you're not. You're awesome! [20:00:33] * qchris hands over a bowl of cherries to hashar for being awesome. [20:00:40] * andre__ hugs all of you terribly awesome people [20:01:02] * qchris hugs andre__ back. [20:01:20] That's better than the thing with the trouts :-D [20:02:14] qchris: and I guess I broke CI entirely [20:02:19] I will rollback to be safe [20:02:26] Whoops. Sure. [20:03:43] (03PS1) 10Hashar: Revert "backport Set remote url on every getRepo in merger" [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606252 (https://phabricator.wikimedia.org/T253263) [20:04:59] (03PS1) 10Kosta Harlan: WIP: Codehealth pipeline NodeJS configuration [integration/config] - 10https://gerrit.wikimedia.org/r/606253 (https://phabricator.wikimedia.org/T240989) [20:06:38] 2020-06-17 19:56:07,968 DEBUG zuul.Repo: Set remote url to ssh://jenkins-bot@gerrit-test.wikimedia.org:29418/mediawiki/extensions/EventBus [20:06:47] (03CR) 10jerkins-bot: [V: 04-1] WIP: Codehealth pipeline NodeJS configuration [integration/config] - 10https://gerrit.wikimedia.org/r/606253 (https://phabricator.wikimedia.org/T240989) (owner: 10Kosta Harlan) [20:06:55] so that it tries to change the remte for an event that happened on gerrit.wikimedia.org bah [20:07:24] Mhmm. [20:09:24] (03CR) 10Hashar: [V: 03+2 C: 03+2] Revert "backport Set remote url on every getRepo in merger" [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606252 (https://phabricator.wikimedia.org/T253263) (owner: 10Hashar) [20:14:00] RECOVERY - zuul_merger_service_running on contint1001 is OK: PROCS OK: 1 process with regex args bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [20:22:21] qchris: yeah well I am sorry I don't get the issue :-\ [20:22:28] No worries. [20:22:54] To be honest, I do not expect much issues between Zuul and Gerrit 3.x. [20:23:01] Things did not change on that end. [20:23:19] So I guess we'll have the test instance without CI. [20:23:29] What do you think? [20:24:01] * qchris has looked a bit at the code, but I'm not much use with Zuul :-( [20:25:25] hashar hi, operations/puppet seems to get "This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset." [20:25:29] I guess I will dig into it tomorrow [20:25:30] see https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/606255/ [20:25:52] hashar: Cool, thanks! [20:25:59] paladox: yeah I guess some repos are broken :/ [20:27:14] that will teach me to be too ambitious fiddling with zuul bah [20:27:19] I though my test was enough [20:28:49] paladox: trying to fix it but waiting for upload... [20:29:54] PROBLEM - zuul_merger_service_running on contint1001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [20:31:42] RECOVERY - zuul_merger_service_running on contint1001 is OK: PROCS OK: 1 process with regex args bin/zuul-merger https://www.mediawiki.org/wiki/Continuous_integration/Zuul [20:33:43] paladox: should be good now [20:36:48] (03PS1) 10Hashar: Revert "WMF: backport Set remote url on every getRepo in merger" [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/606259 (https://phabricator.wikimedia.org/T253263) [20:43:05] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10Dvorapa) [20:50:20] 10Gerrit, 10DBA: Make sure `reviewdb-test` database (used forgerrit upgrade testing) gets torn down - https://phabricator.wikimedia.org/T255715 (10QChris) [20:50:47] 10Gerrit, 10DBA: Make sure `reviewdb-test` database (used forgerrit upgrade testing) gets torn down - https://phabricator.wikimedia.org/T255715 (10QChris) [20:50:49] 10Gerrit, 10DBA: Get a writable reviewdb clone to test Gerrit upgrade with - https://phabricator.wikimedia.org/T254516 (10QChris) [20:51:21] (03PS2) 10Kosta Harlan: WIP: Codehealth pipeline NodeJS configuration [integration/config] - 10https://gerrit.wikimedia.org/r/606253 (https://phabricator.wikimedia.org/T240989) [20:52:17] (03CR) 10jerkins-bot: [V: 04-1] WIP: Codehealth pipeline NodeJS configuration [integration/config] - 10https://gerrit.wikimedia.org/r/606253 (https://phabricator.wikimedia.org/T240989) (owner: 10Kosta Harlan) [20:53:01] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) So for a change the sche... [20:53:30] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Product-Infrastructure-Team-Backlog, 10Services, 10Patch-For-Review: Enable codehealth pipeline for node services - https://phabricator.wikimedia.org/T240989 (10kostajh) @Jdforrester-WMF I started working on a patch for this but have realized that... [21:00:14] 10Gerrit: Verify upgrade to Gerrit 3.x will work on test hardware. - https://phabricator.wikimedia.org/T254642 (10QChris) 05Open→03Resolved The upgrade itself went well. But it was unnecessarily slow. For the last part it failed to take advantage of available CPUs due to the way the reindexing was implement... [21:00:16] 10Gerrit: Gerrit 3.x upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [21:04:18] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Ladsgroup) >>! In T223410#6233012, @Catrope wr... [21:10:57] (03Abandoned) 10QChris: layout: De-duplicate gerrit-test pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/606246 (owner: 10QChris) [21:11:09] (03Abandoned) 10QChris: layout: Rename the gerrit-test pipelines to start in gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606247 (owner: 10QChris) [21:11:23] (03Abandoned) 10QChris: layout: Add gate-and-submit job for gerrit-test [integration/config] - 10https://gerrit.wikimedia.org/r/606250 (owner: 10QChris) [21:23:41] (03PS1) 10Hashar: Revert "layout: Add basic pipelines for gerrit-test.wikimedia.org" [integration/config] - 10https://gerrit.wikimedia.org/r/606269 (https://phabricator.wikimedia.org/T253263) [21:24:20] (03CR) 10Hashar: [C: 03+2] Revert "layout: Add basic pipelines for gerrit-test.wikimedia.org" [integration/config] - 10https://gerrit.wikimedia.org/r/606269 (https://phabricator.wikimedia.org/T253263) (owner: 10Hashar) [21:25:26] (03Merged) 10jenkins-bot: Revert "layout: Add basic pipelines for gerrit-test.wikimedia.org" [integration/config] - 10https://gerrit.wikimedia.org/r/606269 (https://phabricator.wikimedia.org/T253263) (owner: 10Hashar) [21:27:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, 10Patch-For-Review: Add a second Gerrit connection in Zuul config - https://phabricator.wikimedia.org/T253263 (10hashar) 05Open→03Declined Ye... [21:27:23] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10hashar) [21:40:01] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Core Platform Team, 10Quibble, and 2 others: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty - https://phabricator.wikimedia.org/T246358 (10Krinkle) [22:14:41] (03CR) 10Jeena Huneidi: [C: 03+2] "LGTM" [blubber] - 10https://gerrit.wikimedia.org/r/580167 (owner: 10Jforrester) [22:17:54] (03Merged) 10jenkins-bot: Switch example image from old node6 image to current node10 one [blubber] - 10https://gerrit.wikimedia.org/r/580167 (owner: 10Jforrester) [22:18:05] 10Phabricator, 10itWikiCon-2020: Create a countdown for itWikiCon 2020 call for papers - https://phabricator.wikimedia.org/T255668 (10valerio.bozzolan) >>! In T255668#6231794, @Aklapper wrote: > What is a "countdown" and how to create one? :) Well, I think @Ferdi2005 literally means the Phabricator's //Countd... [22:39:37] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Commons, 10Wikidata, and 2 others: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets - https://phabricator.wikimedia.org/T223410 (10Krinkle) >>! In T223410#6233012, @Catrope wrot... [22:42:48] 10MediaWiki-Codesniffer, 10Wikidata: Evaluate the future of wikibase-codesniffer - https://phabricator.wikimedia.org/T253624 (10Legoktm) Related: {T164653} I've suggested this elsewhere, but as a start, I think we can move the `Wikibase` ruleset into the `mediawiki-codesniffer` package, so we no longer need t...