[04:53:51] <wikibugs>	 10Continuous-Integration-Infrastructure: Have a way to kill jobs from the zuul queue before they start - https://phabricator.wikimedia.org/T225233 (10hashar) What I was saying is that we should filter out those jobs before they get put in the queue. Once they are in the queue, surely we want to have them running.
[05:09:28] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Consider having a top-level jenkins CI job for each commit, so they can be manually killed swiftly rather than one-by-one - https://phabricator.wikimedia.org/T225231 (10Legoktm) For t...
[05:19:41] <wikibugs>	 10Gerrit: Gerrit commit message body wrapped near 80 characters instead 100 - https://phabricator.wikimedia.org/T256588 (10santhosh)
[05:20:30] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Legoktm) Where is the source code for this?
[06:13:58] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) I had a tried a few things towards fixing that, but could not find a simple working solution.  First...
[07:07:34] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10Legoktm) Maybe this is too different, but is it possible to move the Jenkins output to a separate "checks" ta...
[07:14:44] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) I dug a bit futher, and I think it's currently genuinely not possible to match across URLs in comment...
[07:18:36] <wikibugs>	 10Gerrit: Since Gerrit 3.2, gitiles monospaced text is bold - https://phabricator.wikimedia.org/T256571 (10Aklapper)
[07:19:49] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) >>! In T256575#6263128, @Legoktm wrote: > Maybe this is too different, but is it possible to move the...
[07:38:27] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) >>! In T256575#6263171, @QChris wrote: > I dug a bit futher, and I think it's currently genuinely not...
[07:45:45] <wikibugs>	 10Gerrit: Hide the "Monitoring" tab? - https://phabricator.wikimedia.org/T256601 (10MoritzMuehlenhoff)
[07:45:57] <wikibugs>	 10Gerrit: Hide the "Monitoring" tab? - https://phabricator.wikimedia.org/T256601 (10MoritzMuehlenhoff) p:05Triage→03Lowest
[07:46:38] <wikibugs>	 10Gerrit: Hide the "Monitoring" tab? - https://phabricator.wikimedia.org/T256601 (10MoritzMuehlenhoff)
[07:46:41] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10MoritzMuehlenhoff)
[07:47:04] <wikibugs>	 10Gerrit: Since Gerrit 3.2, gitiles monospaced text is bold - https://phabricator.wikimedia.org/T256571 (10QChris)
[08:21:06] <wikibugs>	 10Gerrit: Since Gerrit 3.2, gitiles monospaced text is bold - https://phabricator.wikimedia.org/T256571 (10QChris) I uploaded a fix for this #upstream https://gerrit-review.googlesource.com/c/gitiles/+/273661
[08:21:34] <wikibugs>	 10Gerrit, 10Upstream: Since Gerrit 3.2, gitiles monospaced text is bold - https://phabricator.wikimedia.org/T256571 (10QChris)
[08:41:05] <wikibugs>	 10Gerrit: Hide the "Monitoring" tab? - https://phabricator.wikimedia.org/T256601 (10QChris) 05Open→03Invalid The Monitoring tab is hidden by default (see below). It's only visible to users who can administrate the server (or who explicitly got access to JavaMelody).  You are in the `ops` LDAP group, which ar...
[08:41:09] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[09:03:11] <wikibugs>	 10Gerrit: Hide the "Monitoring" tab? - https://phabricator.wikimedia.org/T256601 (10MoritzMuehlenhoff) Ah, that explains, thanks!
[09:08:45] <wikibugs>	 10Gerrit, 10Accessibility: "CR" and "V" columns are not colorblind-friendly - https://phabricator.wikimedia.org/T256615 (10Daimona)
[09:08:59] <wikibugs>	 10Gerrit, 10Accessibility: "CR" and "V" columns are not colorblind-friendly - https://phabricator.wikimedia.org/T256615 (10Daimona)
[09:09:01] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Daimona)
[09:18:12] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10jcrespo) I have a volunteer @Privacybatm that after the upgrade he cannot send patches anymore to gerrit (cloning through SSH works for him). Could any permission have changed after the upgrade, preventing him so? H...
[09:20:57] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Majavah) >>! In T254158#6263581, @jcrespo wrote: > I have a volunteer @Privacybatm that after the upgrade he cannot send patches anymore to gerrit (cloning through SSH works for him). Could any permission have chang...
[09:35:39] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Privacybatm) Thank you @jcrespo @Majavah I was using 1.26, Just now updated and everything is working fine, Thank you for your help!
[09:45:41] <wikibugs>	 10Release-Engineering-Team-TODO, 10Quality-and-Test-Engineering-Team (QTE), 10User-Soham, 10User-Vidhi-Mody, and 2 others: Create MediaWiki-Docker documentation for all repositories with Selenium tests - https://phabricator.wikimedia.org/T256239 (10zeljkofilipin)
[09:46:36] <wikibugs>	 (03PS1) 10Karl Wettin (WMSE): Review access change [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608234
[09:47:33] <wikibugs>	 (03CR) 10Karl Wettin (WMSE): "Still require FORGE_SERVER" [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608234 (owner: 10Karl Wettin (WMSE))
[09:49:49] <qchris>	 Things still look good after the upgrade. /me heads to lunch.
[10:30:24] <Krinkle>	 qchris: I'm not worried about older comments. We only keep them for working for 7 days anyway
[10:30:37] <qchris>	 Oh! :-D
[10:31:32] <qchris>	 I heard talking that moving to the Checks part is on the agenda anyways. Maybe we can then ignore the commentlink issues and raise priority on moving to Checks?
[10:32:11] <Krinkle>	 Is there perhaps a bigger / different change we can make to how the comments are sent to Gerrit that can do some HTML?
[10:32:25] <Krinkle>	 Might not need any comment link post-fix
[10:32:28] <wikibugs>	 10Gerrit, 10Accessibility: "CR" and "V" columns are not colorblind-friendly - https://phabricator.wikimedia.org/T256615 (10hashar) > The font in the "CR" (code review) and "V" (verified) columns is too small, and its weight is too light, resulting in poor readability for color-blind people.  My browser picks t...
[10:32:37] <wikibugs>	 10Gerrit, 10Accessibility: "CR" and "V" columns are not colorblind-friendly - https://phabricator.wikimedia.org/T256615 (10hashar) p:05Triage→03Low
[10:33:19] <qchris>	 I'll leave that part for the releng team :-)
[10:33:29] <Krinkle>	 Right. Okay :(
[10:33:32] <Krinkle>	 :)
[10:33:37] <Krinkle>	 *
[10:35:22] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) >>! In T256575#6263187, @QChris wrote: > But it only helps us with future CI results, not with all CI...
[10:49:31] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10kostajh) Should we switch robot comments on for all projects and see what feedback we get, or enable incrementally? Right now it's just on for `m...
[10:57:03] <wikibugs>	 10Gerrit, 10translatewiki.net: Unable to automerge exported i18n patched - https://phabricator.wikimedia.org/T256624 (10Raymond)
[10:57:33] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, and 2 others: Display Zuul status of jobs for a change on Gerrit UI - https://phabricator.wikimedia.org/T214068 (10Lucas_Werkmeister_WMDE)
[10:57:57] <wikibugs>	 10Gerrit, 10translatewiki.net: Unable to automerge exported i18n patched - https://phabricator.wikimedia.org/T256624 (10Raymond)
[11:00:44] <wikibugs>	 10Gerrit: Gerrit commit message body wrapped near 80 characters instead 100 - https://phabricator.wikimedia.org/T256588 (10hashar) p:05Triage→03Low The example at the top of the guide has the longest line at 65 characters. It used to state `More details, wrap lines around 76 characters.` ([[ https://www.medi...
[11:01:22] <wikibugs>	 10Gerrit, 10translatewiki.net, 10Language-Team (Language-2020-Focus-Sprint): Unable to automerge exported i18n patched - https://phabricator.wikimedia.org/T256624 (10Nikerabbit) p:05Triage→03High
[11:04:06] <Majavah>	 Krinkle: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/608249 should probably get deployed at some point?
[11:17:27] <wikibugs>	 10Gerrit, 10Accessibility: "CR" and "V" columns are not colorblind-friendly - https://phabricator.wikimedia.org/T256615 (10Daimona) >>! In T256615#6263730, @hashar wrote: > My browser picks the font family Roboto with a size of 14 pixels and a default weight.  Same for me. However, IMHO it's too small. A font-...
[11:50:41] <hashar>	 qchris: looks like Gerrit is well behaving and the new UI seems appreciated :]
[11:52:36] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Patch-For-Review: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10hashar) @Qchris nice detailed report. So the issue is that it is now done in chunks whe...
[11:55:12] <qchris>	 hashar: Yup :-)
[11:56:19] <RhinosF1>	 qchris: well done on the upgrade
[11:56:21] <hashar>	 meanwhile I have proposed a change to stop Zuul from reporting the job name  https://gerrit.wikimedia.org/r/c/operations/puppet/ /608296
[11:56:45] <hashar>	 that is a feature hack to saves one the trouble of extreacting the job name from the url
[11:57:11] <qchris>	 RhinosF1: Thanks. That was not just me. Count in m-utante, paladox, hashar, t-hcipriani and many more ;-)
[11:57:47] <hashar>	 notably when ones receives report from multiple Zuul each having entirely different URL that no one controls 
[11:58:03] <hashar>	 but on our system, there is only one zuul/jenkins so we tightly control the url
[11:58:11] <hashar>	 bah I should write on the task
[11:58:29] <qchris>	 hashar: The other thing that we could do is to avoid the detection as an URL. Then everything is a single string that we can match against. Like swapping https:// for jenkins://
[11:58:38] <qchris>	 Agreed. Let's discuss on the task.
[11:58:53] <hashar>	 or we can talk here and summarize on the  task hehe
[11:59:18] <hashar>	 cause surely if we have something like  https://integration.wikimedia.org/ci/foobar/XXX/console ,  it should not be too hard to extract the job
[11:59:46] <qchris>	 We cannot match against urls at all.
[11:59:59] <qchris>	 I tried matching "console" and event that failed.
[12:00:06] <qchris>	 So the whole URL is unmatchable.
[12:00:10] <hashar>	 AH
[12:00:17] <hashar>	 nice feature :]
[12:00:24] <qchris>	 :-D
[12:01:04] <qchris>	 Making Gerrit not detect it as an URL would make everything matchable again.
[12:01:47] <qchris>	 If you say that swapping out the 'https://' for something else is easy on the zuul side, then I'll give that a test in the afternoon.
[12:03:17] <hashar>	 we already override the reported build URL to always add  /console
[12:03:25] <hashar>	 but I am willing to remove that override
[12:04:30] <hashar>	 looking at Gerrit code, whenever it matches http / https / mailto,  it crafts the link and early return :-\
[12:05:16] <qchris>	 I'll have to run in a bit, but I can try to cook something up when I'm back in ~1-2 hours.
[12:05:20] <Daimona>	 Since we're here, I'd have a couple of questions about new gerrit... First one is: is it possible to customize my own stylesheet somehow? I tried with stylus, but polymer uses shadow DOM which I'm unsure how to handle...
[12:05:42] <hashar>	 qchris: don't worry. I will get the job name prefix to be dropped. That will at least make the report slightly more readable
[12:06:03] <qchris>	 Ok, hashar .
[12:06:36] <qchris>	 Daimona: I'm totally not sure about the personalized stylesheet. paladox, do you know a good answer to Daimona's question 3 lines up?
[12:07:13] <Daimona>	 Second one is: where can I find links to project dashboards? All projects have a default dashboard of "recent" (see https://gerrit.wikimedia.org/r/p/mediawiki/core/+/dashboard/default:recent) but apparently it's never linked to? All links in the "Repo" column link to a search with "project:xxx status:open" (unlike old gerrit)
[12:07:51] <Daimona>	 Ah, thank you anyway. Let's see :)
[12:09:23] <qchris>	 You're right about the dashboards. They get used less in the new UI. Not sure why this is the case.
[12:09:32] <paladox>	 Hashar qchris there is a plug in that brings back the table for displaying jobs.
[12:09:33] <paladox>	 https://github.com/dburm/pg-test-result-plugin
[12:09:34] <paladox>	 Daimona yes using the css vars.
[12:09:38] <paladox>	 Though I haven’t tried to change the style locally for me :)
[12:09:53] <qchris>	 At any rate, you'll find the dashboards on the project pages. E.g.: https://gerrit.wikimedia.org/r/admin/repos/mediawiki/core,dashboards
[12:10:13] <paladox>	 ^ (it should show on the sidebar)
[12:10:13] <RhinosF1>	 qchris: If paladox drinked, I'd owe them a whole bar.
[12:10:20] <qchris>	 :-D
[12:10:23] <hashar>	 paladox: in pure html/js nice :)
[12:10:29] <paladox>	 Yeh
[12:10:34] <paladox>	 And works too!
[12:11:37] <RhinosF1>	 qchris: probably the same for many others in that list. You're a helpful bunch.
[12:11:43] <hashar>	 paladox: excellent finding ;]
[12:12:04] <paladox>	 I believe someone commented on a groups post which is how I found it :)
[12:12:05] <Daimona>	 paladox: interesting, what vars? Do you have a guide to point me to?
[12:13:25] <Daimona>	 qchris: Yeah, that's where I found the dashboard link above :) I was just wondering about why they were removed from the default view. Not so important anyway
[12:13:45] <qchris>	 Sorry Daimona. I don't have a good answer to that.
[12:13:55] <qchris>	 That's probably worth filing upstream.
[12:14:06] <qchris>	 So they see that there is demand for that functionality
[12:15:40] <Daimona>	 Thanks, I'll consider that. Normally I would just write a hacky script to replace all links, but I really have no idea how to work with shadow dom :-/
[12:15:43] <paladox>	 Daimona: if you know the css class, you could search for it using https://github.com/GerritCodeReview/gerrit or a local checkout.
[12:15:44] <paladox>	 https://polymer-library.polymer-project.org/3.0/docs/devguide/custom-css-properties
[12:15:45] <paladox>	 Daimona what was the default view?
[12:15:48] <qchris>	 I'll have to run. I'm back in ~1 hour.
[12:16:33] <Daimona>	 paladox: Yeah, I know the class. The problem is, applying a style to the whole document won't work. There are several layers of isolation created by polymer
[12:17:41] <Daimona>	 Re default view: in old gerrit, clicking on the repo name would usually bring you to https://gerrit.wikimedia.org/r/#/projects/[PROJECT NAME],dashboards/default i.e. the "recent" dashboard
[12:17:49] <paladox>	 The css var works all the way
[12:18:11] <paladox>	 Oh
[12:19:03] <wikibugs>	 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Patch-For-Review: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10hashar) The links found by ba-linkify are indeed not processed at all. There is a short...
[12:20:33] <Daimona>	 Depends on how you apply it. I really have no idea :O Perhaps I should look up Polymer API
[12:21:55] <paladox>	 —<var>: <....>
[12:25:41] <Daimona>	 Hah, now I see! Thank you!
[12:26:55] <paladox>	 hashar plug-in is also designed for Jenkins :)
[12:40:41] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10hashar) >>! In T217008#6263767, @kostajh wrote: > Should we switch robot comments on for all projects and see what feedback we get, or enable inc...
[12:48:43] <hashar>	 !log Updating Jenkins jobs for releng/ci-src-setup-simple:0.3.0  # https://gerrit.wikimedia.org/r/c/integration/config/+/608069 | T256462
[12:48:45] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[12:48:45] <stashbot>	 T256462: Abstract out git commands for CI Docker containers - https://phabricator.wikimedia.org/T256462
[12:52:07] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/608069 (https://phabricator.wikimedia.org/T256462) (owner: 10Hashar)
[12:53:14] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: use ci-src-setup-simple:0.3.0 [integration/config] - 10https://gerrit.wikimedia.org/r/608069 (https://phabricator.wikimedia.org/T256462) (owner: 10Hashar)
[12:53:16] <wikibugs>	 (03PS3) 10Umherirrender: Sort arrays with new @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606799 (https://phabricator.wikimedia.org/T247813)
[12:53:45] <wikibugs>	 (03CR) 10Umherirrender: Sort arrays with new @phpcs-require-sorted-array (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606799 (https://phabricator.wikimedia.org/T247813) (owner: 10Umherirrender)
[13:14:01] <wikibugs>	 10Gerrit: Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js - https://phabricator.wikimedia.org/T256631 (10Mholloway)
[13:16:14] <wikibugs>	 10Gerrit: Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js - https://phabricator.wikimedia.org/T256631 (10Mainframe98)
[13:16:16] <wikibugs>	 10Gerrit: Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`) - https://phabricator.wikimedia.org/T256560 (10Mainframe98)
[13:38:40] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Sonarqubebot, 10Patch-For-Review: Run phpunit tests for sonarqubebot in CI - https://phabricator.wikimedia.org/T242852 (10Jdforrester-WMF) a:03Jdforrester-WMF
[13:40:21] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10JavaScript: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10Mholloway)
[13:45:42] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+2] Significant simplification of UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596010 (owner: 10Thiemo Kreuz (WMDE))
[13:46:45] <wikibugs>	 (03Merged) 10jenkins-bot: Significant simplification of UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596010 (owner: 10Thiemo Kreuz (WMDE))
[13:54:21] <wikibugs>	 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10Umherirrender)
[14:02:14] <wikibugs>	 10LibUp: libraryupgrader web ui should mark libs also as "Wikimedia-deployed" - https://phabricator.wikimedia.org/T256635 (10Umherirrender)
[14:06:44] <wikibugs>	 (03CR) 10Jforrester: [C: 04-1] "Still deployed in production on scb. :-(" [integration/config] - 10https://gerrit.wikimedia.org/r/607746 (https://phabricator.wikimedia.org/T217114) (owner: 10Jforrester)
[14:08:33] <wikibugs>	 10Beta-Cluster-Infrastructure: Close es.wikibooks beta - https://phabricator.wikimedia.org/T202665 (10Jdforrester-WMF)
[14:08:35] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Patch-For-Review: closed-labs.dblist no longer read as 'closed' tag - https://phabricator.wikimedia.org/T115584 (10Jdforrester-WMF) 05Open→03Resolved
[14:09:37] <wikibugs>	 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, and 3 others: Remove deployment.wikimedia.beta.wmflabs.org wiki (deploymentwiki) - https://phabricator.wikimedia.org/T198673 (10Krinkle)
[14:13:25] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Jdforrester-WMF) >>! In T255701#6261192, @Aklapper wrote: >...
[14:13:58] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Jdforrester-WMF) >>! In T255701#6262992, @Legoktm wrote: >...
[14:22:06] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10hashar) Alternative is to have a regular Jenkins job to gen...
[14:22:34] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10hashar) (else ye...
[14:24:45] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Aklapper) [OT] @...
[14:24:58] <wikibugs>	 10Gerrit: Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews - https://phabricator.wikimedia.org/T131968 (10Jdforrester-WMF)
[14:25:01] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Developer Productivity, and 2 others: Upgrade to Gerrit 2.16.13 - https://phabricator.wikimedia.org/T200739 (10Jdforrester-WMF)
[14:27:08] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Code-Health-Metrics: Move Dan's CI metrics cron script / HTML output from people.wikimedia.org to doc.wikimedia.org - https://phabricator.wikimedia.org/T255701 (10Jdforrester-WMF)...
[14:29:44] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Sonarqubebot, 10Patch-For-Review: Run phpunit tests for sonarqubebot in CI - https://phabricator.wikimedia.org/T242852 (10Jdforrester-WMF) 05Open→03Resolved
[14:37:34] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Zuul: Allow hiding of non-discussion comments in Gerrit - https://phabricator.wikimedia.org/T48148 (10Aklapper) @hashar: A #good_first_task is a s...
[14:37:45] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap: Better error message than "Scap failed!: Call to mwscript eval.php returned: None" - https://phabricator.wikimedia.org/T225109 (10Aklapper) @thcipriani: A #good_first_task is a self-contained, non-controversial task wi...
[14:37:47] <wikibugs>	 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikibugs: jerkins-bot should not post on IRC for Gerrit changes marked 'WIP' - https://phabricator.wikimedia.org/T239928 (10Aklapper) @thcipriani: A #good_first_task is a self-contained, non-controversial task with a clear...
[14:37:51] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap: Scap should abort early when Keyholder is not armed - https://phabricator.wikimedia.org/T111062 (10Aklapper) @thcipriani: A #good_first_task is a self-contained, non-controversial task with a clear approach and links t...
[14:37:53] <wikibugs>	 10Release-Engineering-Team-TODO, 10Scap, 10observability, 10Developer Productivity, 10Regression: Scap should set 'level' in Logstash messages - https://phabricator.wikimedia.org/T246793 (10Aklapper) @thcipriani: A #good_first_task is a self-contained, non-controversial task with a clear approach and lin...
[14:37:55] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Operations, and 2 others: scap's logstash_checker.py is blissfully unaware of any logstash indexing latency - https://phabricator.wikimedia.org/T255197 (10Aklapper) @thcipriani: A #good_first_task is a self-contain...
[14:58:06] <wikibugs>	 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10drochford) >>! In T247943#...
[15:08:08] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10kostajh) >>! In T217008#6264038, @hashar wrote: >>>! In T217008#6263767, @kostajh wrote: >> Should we switch robot comments on for all projects a...
[15:10:20] <wikibugs>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Technical-Debt: Move integration/docroot.git deployment to scap - https://phabricator.wikimedia.org/T256005 (10hashar)
[15:15:29] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10hashar) Do you still need:  > [ ] Add SonarQubeBot user to Gerrit `stream-events` group  Or is that solely triggered via CI/Zuul?
[15:18:49] <wikibugs>	 10Release-Engineering-Team-TODO, 10User-brennen: Onboard Ahmon - https://phabricator.wikimedia.org/T256074 (10thcipriani)
[15:32:34] <wikibugs>	 10Gerrit: Gerrit: "Only comments" switch should have an adjustable default - https://phabricator.wikimedia.org/T256648 (10Tgr)
[15:32:44] <wikibugs>	 10Gerrit: Gerrit "Only comments" switch should have an adjustable default - https://phabricator.wikimedia.org/T256648 (10Tgr)
[15:36:18] <wikibugs>	 10Gerrit: Gerrit Findings tab should indicate when there are findings - https://phabricator.wikimedia.org/T256650 (10Tgr)
[15:47:24] <wikibugs>	 10Gerrit: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10Xqt)
[15:50:53] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10kostajh) >>! In T217008#6264543, @hashar wrote: > Do you still need: >  >> [ ] Add SonarQubeBot user to Gerrit `stream-events` group >  > Or is t...
[15:51:06] <wikibugs>	 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Patch-For-Review: Report results from SonarCloud to Gerrit - https://phabricator.wikimedia.org/T217008 (10kostajh)
[15:59:35] <hashar>	 bah creating a topic is broken ?! https://phabricator.wikimedia.org/T256653
[15:59:49] <hashar>	 which is gerrit rejecting: git push gerrit HEAD:refs/for/master/myawesometopic
[16:02:49] <thcipriani>	 :\
[16:02:59] <shinken-wm_>	 PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds
[16:15:09] <wikibugs>	 10Continuous-Integration-Config, 10Product-Infrastructure-Team-Backlog: mobileapps-periodic-test CI job is failing since 2020-06-29 13:03 UTC - https://phabricator.wikimedia.org/T256657 (10Mholloway)
[16:17:06] <wikibugs>	 10Gerrit: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10hashar) 05Open→03Resolved a:03hashar ---  **In short: to delimit the branch and the topic, please use `%` instead of `/`.**  ---  The relevant doc https://gerrit.wikimedia.org/r/Docum...
[16:17:32] <wikibugs>	 10Gerrit, 10Upstream: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10hashar)
[16:17:47] <shinken-wm_>	 RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 97808 bytes in 1.182 second response time
[16:19:11] <hashar>	 thcipriani: working as intended.  Pushing with  /topic got deprecated in 2.16 and dropped in 3.2 :]
[16:19:20] <hashar>	 gotta push to refs/for/master%topic instead
[16:19:25] <hashar>	 git-review got patched
[16:19:30] <thcipriani>	 TIL
[16:20:20] <hashar>	 next twist: move us to git protocol v2 :]]
[16:22:10] <James_F>	 Not today, perhaps. :-P
[16:22:50] <hashar>	 I will do it on friday since there is no train
[16:24:17] <James_F>	 hashar: Please don't.
[16:24:43] <James_F>	 hashar: It's a no-deploy day for a reason. Very little coverage. Let's not burn SREs with out-of-hours pages if things go wrong.
[16:24:49] <hashar>	 I mean
[16:25:02] <hashar>	 I already did it on a few jobs earlier today and they seem to behave properly
[16:25:09] <hashar>	 then yeah of course I am not going to touch anything this friday
[16:25:12] <James_F>	 Oh, inside CI?
[16:25:27] <James_F>	 That's probably safe enough to scale out more, yes.
[16:25:30] <hashar>	 and for scap, that is definitely worth looking into it,  would need some dedicated task for it
[16:25:36] <hashar>	 but I want to first gather experience with ci
[16:25:36] <James_F>	 Totally.
[16:25:45] <hashar>	 and how git v2 works on the various git versions we have
[16:25:45] <James_F>	 It'd be nice to speed these things up.
[16:25:59] <James_F>	 Yeah, jgit !== git.
[16:26:14] <hashar>	 ;D
[16:26:26] <hashar>	 that will make the fetch of Quibble jobs way faster for sure
[16:26:33] <James_F>	 🤞🏽
[16:30:22] <wikibugs>	 10Gerrit, 10Upstream: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10Lucas_Werkmeister_WMDE) I updated the “Create a dependency” section of the mw.org page linked in the task description. The “Submitting a change to a branch for review ("backpo...
[16:32:31] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon - https://phabricator.wikimedia.org/T256074 (10thcipriani)
[16:32:52] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon - https://phabricator.wikimedia.org/T256074 (10thcipriani) p:05Triage→03Medium
[17:00:51] <wikibugs>	 10Gerrit, 10Upstream: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10hashar) 05Resolved→03Open Reopening cause surely there must be various stuff we have to fix here and there.
[17:05:11] <wikibugs>	 (03PS1) 10Hashar: deploy-promote: fix review push with topic [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653)
[17:06:21] <wikibugs>	 (03CR) 10Hashar: "There is apparently no other occurrences of pushing to a topic in this repo ;)" [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar)
[17:18:56] <wikibugs>	 10phan-taint-check-plugin: Expand taintedness data for builtin functions - https://phabricator.wikimedia.org/T256660 (10Daimona)
[17:23:45] <wikibugs>	 10phan-taint-check-plugin: Implement ReDoS detection - https://phabricator.wikimedia.org/T256661 (10Daimona)
[17:23:49] <wikibugs>	 10phan-taint-check-plugin: Implement ReDoS detection - https://phabricator.wikimedia.org/T256661 (10Daimona) p:05Triage→03Low
[17:30:18] <wikibugs>	 10Release-Engineering-Team-TODO, 10Documentation: Consolidate / write "runbooks" for Release Engineering into our centralised list - https://phabricator.wikimedia.org/T240483 (10Jdforrester-WMF) @thcipriani Is this "done" enough to mark as Resolved? Obs. we can keep adding to it over time, but it'd be nice to...
[17:31:59] <wikibugs>	 10Release-Engineering-Team-TODO, 10Documentation: Consolidate / write "runbooks" for Release Engineering into our centralised list - https://phabricator.wikimedia.org/T240483 (10thcipriani) 05Open→03Resolved a:03Jdforrester-WMF >>! In T240483#6265048, @Jdforrester-WMF wrote: > @thcipriani Is this "done"...
[17:37:44] <wikibugs>	 10phan-taint-check-plugin: Better reporting for tainted parameters - https://phabricator.wikimedia.org/T256662 (10Daimona)
[17:39:00] <wikibugs>	 10phan-taint-check-plugin: Use string formatting in issue messages - https://phabricator.wikimedia.org/T256664 (10Daimona)
[18:14:19] <wikibugs>	 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Permission error with gerrit after version update - https://phabricator.wikimedia.org/T256671 (10MSantos)
[18:14:52] <icinga-wm>	 PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[18:17:02] <wikibugs>	 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) a:03Daimona Time to focus on this for real. I'm unsure about the patch above, especially because it would need some tweaks upstream for it to work. Other ideas I'm going to e...
[18:19:41] <wikibugs>	 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Permission error with gerrit after version update - https://phabricator.wikimedia.org/T256671 (10Paladox) You need to update git-review to at least 1.27. git-review 1.26 or lower is not supported.
[18:20:02] <wikibugs>	 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Permission error with gerrit after version update - https://phabricator.wikimedia.org/T256671 (10Paladox) 05Open→03Invalid
[18:21:33] <wikibugs>	 10Gerrit: Gerrit commit message body wrapped near 80 characters instead 100 - https://phabricator.wikimedia.org/T256588 (10QChris)
[18:21:35] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[18:22:39] <wikibugs>	 10phan-taint-check-plugin: Implement ReDoS detection - https://phabricator.wikimedia.org/T256661 (10sbassett) > I don't think there's a proper way to sanitize user input in regexps, so probably a new type that cannot be cleared.  From what I know, there are filtering and allow-lists which can be somewhat effecti...
[18:25:20] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[18:26:05] <wikibugs>	 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10QChris)
[18:26:08] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[18:27:51] <wikibugs>	 10Gerrit, 10Patch-For-Review, 10Upstream: gerrit: submitting a topic is no longer functional with new gerrit - https://phabricator.wikimedia.org/T256653 (10QChris)
[18:27:52] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[18:28:46] <wikibugs>	 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Permission error with gerrit after version update - https://phabricator.wikimedia.org/T256671 (10QChris)
[18:28:48] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris)
[18:29:22] <wikibugs>	 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Nikerabbit)
[18:31:11] <wikibugs>	 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: gerrit: Permission error with gerrit after version update - https://phabricator.wikimedia.org/T256671 (10MSantos)
[19:05:39] <wikibugs>	 10Gerrit: Gerrit: Permission error "use a SHA1 visible to you, or get update permission on the ref" when using git-review ≤1.26 - https://phabricator.wikimedia.org/T256671 (10Aklapper)
[19:05:40] <icinga-wm>	 RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1
[19:16:29] <wikibugs>	 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10thcipriani) p:05Triage→03Medium a:03mmodell
[19:17:06] <wikibugs>	 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.41 deployment blockers - https://phabricator.wikimedia.org/T256669 (10thcipriani)
[19:17:18] <wikibugs>	 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.41 deployment blockers - https://phabricator.wikimedia.org/T256669 (10thcipriani) p:05Triage→03Medium
[19:41:36] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - software engineer in releng - https://phabricator.wikimedia.org/T256074 (10Dzahn)
[19:43:00] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - software engineer in releng - https://phabricator.wikimedia.org/T256074 (10ssingh)
[19:51:53] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10greg)
[19:54:59] <hashar>	 twentyafterfour: thcipriani: would you be able to monitor the automatic branch cutter later today?
[19:55:09] <hashar>	 I guess it will pass just fine but who knows really :]
[19:55:24] <thcipriani>	 :)
[19:55:37] <thcipriani>	 sure, I can check it
[19:55:55] <hashar>	 and I could use a fix for the  deploy-promote script at https://gerrit.wikimedia.org/r/c/mediawiki/tools/release/+/608431 :D
[19:55:58] <thcipriani>	 it's scheduled at ~4am for you if I'm doing my math right
[19:56:08] <hashar>	 2am utc is that it?
[19:56:26] <thcipriani>	 ah, nice
[19:56:30] <thcipriani>	 yep, 2am UTC
[19:56:44] <wikibugs>	 (03CR) 10Thcipriani: [C: 03+2] "Good catch!" [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar)
[19:56:46] <wikibugs>	 (03CR) 1020after4: [C: 03+2] "lgtm" [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar)
[19:57:10] <thcipriani>	 jinx
[19:57:11] <hashar>	 hehe double +2!
[19:57:22] <hashar>	 and I couldn't find whether the branch cutter magic does push anything with a topic
[19:57:29] <wikibugs>	 (03Merged) 10jenkins-bot: deploy-promote: fix review push with topic [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar)
[19:57:42] <twentyafterfour>	 I don't think it uses topic
[19:58:19] <thcipriani>	 nah, doesn't push with a topic: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/607158
[19:58:55] <hashar>	 cool!
[19:59:58] <qchris>	 hashar: I could use your help a bit with T256633. Could I steal you some 15 minutes?
[19:59:58] <stashbot>	 T256633: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633
[20:00:32] <hashar>	 qchris: ah yeah
[20:00:33] <qchris>	 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/604347
[20:00:37] <qchris>	 It's about that ^ change.
[20:00:40] <hashar>	 i looked at a couple of them but each got force merged
[20:00:45] <hashar>	 and ig ave up;)
[20:00:48] <qchris>	 Same here.
[20:00:55] <qchris>	 But the above change looks skew.
[20:01:04] <qchris>	 Basically: PS1 got uploaded.
[20:01:09] <qchris>	 Then. CR+2
[20:01:12] <hashar>	 guess we gotta dig in the change metadata and the review notes
[20:01:19] <qchris>	 Did that already.
[20:01:28] <qchris>	 From both before and after the upgrade.
[20:01:43] <qchris>	 They agree, and there should not have been a CR+2 on PS2.
[20:01:52] <qchris>	 Yet, it got merged.
[20:02:03] <qchris>	 But the comment list from Jenkins looks a bit off.
[20:02:21] <qchris>	 So the the change linked above has a parent.
[20:02:32] <qchris>	 Both of them got rebased and then merged.
[20:02:52] <qchris>	 But the thing is: The linked change only had CR+2 on PS1. Not on PS2.
[20:03:15] <hashar>	 OHHH
[20:03:18] <qchris>	 And the commit message changed between PS1 and PS2
[20:03:24] <hashar>	 we carry the max vote on trivial rebases
[20:03:27] <qchris>	 So no copied CR+2
[20:03:29] <hashar>	 or commit message updates
[20:03:32] <hashar>	 that might it
[20:04:35] <qchris>	 We copy votes if the commit message changes, or if it's a trivial rebase.
[20:04:41] <qchris>	 But it's different here.
[20:04:49] <qchris>	 It's a rebase with a changed commit message.
[20:05:09] <qchris>	 So neither of the 2 label-copying rules become active.
[20:05:20] <qchris>	 Even if: Gerrit shows no CR+2 for PS2.
[20:05:32] <qchris>	 If the vote got copied, it would show a CR+2.
[20:05:36] <qchris>	 But the thing is:
[20:05:50] <qchris>	 The last 3 lines of comments look off.
[20:06:08] <qchris>	 The change got merged. And only then the "Main test build succeeded"
[20:06:17] <qchris>	 And finally the Post-merge build succeed.
[20:06:28] <qchris>	 The "Main test build succeeded" should come before the merging.
[20:06:45] <qchris>	 And that's not a race by a few seconds.
[20:06:54] <qchris>	 (Because if it would, I'd say meh)
[20:06:58] <qchris>	 It's half a minute.
[20:06:59] <hashar>	 hmm
[20:07:14] <qchris>	 Could it be that:
[20:07:45] <qchris>	 Since PS1 had CR+2 and V+2 but jenkins could not submit due to the parent not being ok.
[20:08:35] <qchris>	 That jenkins got confused what to do with which patch set?
[20:08:45] <hashar>	 not really
[20:08:55] <hashar>	 cause Zuul will retrieve the change
[20:09:03] <hashar>	 figure out that it is missing a parent
[20:09:15] <hashar>	 and if the parent had a +2, then Zuul would know about that parent change
[20:09:23] <hashar>	 and assumes that eventually the parent will be submitted/merged
[20:09:29] <hashar>	 so it would process the child one just fine
[20:09:35] <hashar>	 then eventually submit the parent
[20:09:47] <hashar>	 and submit the child after parent got submitted
[20:10:21] <hashar>	 if the parent fails the tests, it is not submitted and thus Zuul dequeue anychange ahead of it. Or should at least ;]
[20:10:24] <hashar>	 the thing is
[20:10:33] <hashar>	 it managed to submit the change, so PS2 must had the proper votes
[20:10:51] <thcipriani>	 interestingly, for that change, git notes shows a CR+2 but the the git meta ref does not
[20:10:59] <hashar>	 zuul  justs   gerrit review --submit --message "whatever nice message"
[20:11:27] <qchris>	 thcipriani: Yup.
[20:12:00] <qchris>	 But even if PS had CR+2 and it later got lost ... The sequence of jenkins-bot messages does not make sense to me.
[20:12:12] <qchris>	 But then I do not know too much about Jenkins. Hence I'm asking.
[20:12:34] <hashar>	 and if I look at  refs/changes/47/604347/meta  26c2b607f7f66469226ddf8114ee6801c83f7ed6  shows that jenkins-bot submitted with a CR+2 from Jforrester
[20:13:25] <qchris>	 I mean, we could explain it away by saying: We used NoteDB on 2.15 and we know that was a bit broken on the edges. But that is like a lame excuse for "We do not know"
[20:13:38] <hashar>	 and that specific approval comes frmo the rebase change cb27d8a425e85994490c1655b4c4f1831ad92451
[20:13:46] <qchris>	 I checked the DB, but there are of course to patch set approvals since mid 2018 in there.
[20:14:06] <hashar>	 so I assume that ps2 has never been formally CR+2 ed and it just carried the vote from the previous patch
[20:14:27] <hashar>	 we might have some of the gerrit events in the zuul debug log
[20:14:34] <qchris>	 I looked through the changelogs 2.15 -> 3.2 and could not find a note about that in there.
[20:15:12] <qchris>	 (And the vote was not in NoteDB before the migration. So it for sure did not get lost in the 2.15 -> 3.2 migration)
[20:15:25] <qchris>	 (I checked the backup from before the migration)
[20:15:38] <qchris>	 And the migration logs did not flag that change as being broken either.
[20:17:21] <hashar>	 qchris: https://phabricator.wikimedia.org/P11700
[20:17:32] <hashar>	 that is from thz uul debug logs
[20:17:43] <hashar>	 TriggerEvent  is an object representing an event coming over stream-events
[20:17:48] <hashar>	 which thus include the comment-added
[20:17:57] <hashar>	 we can see 604347,1 Verified:0, Code-Review:2>
[20:18:05] <qchris>	 You rock hashar!
[20:18:11] <qchris>	 But no CR+2 on PS2.
[20:18:12] <hashar>	 the patchset being created
[20:18:22] <hashar>	 and all other comments had not any CR+2
[20:18:23] <hashar>	 so
[20:18:54] <hashar>	 either patchset 2 had no CR+2  , but the meta data for the change show that PS2 got indeed submitted with a CR+2
[20:19:03] <hashar>	 CR+2 that got granted by the rebase change
[20:19:13] <hashar>	 so it must be that the max vote got carried over the rebase
[20:19:22] <hashar>	 and polygerrit has a bug not showing that
[20:19:23] <hashar>	 ?
[20:19:51] <hashar>	 if I was adventurous, I would try loading the old repo in Gerrit 2.15 and check what the old old ui would have shown 
[20:20:01] <qchris>	 I thought about that.
[20:20:12] <qchris>	 But that would need quite some messing around with things.
[20:20:16] <hashar>	 and if not, maybe that was a bug in the old one as well ;D
[20:20:38] <qchris>	 We don't have enough disk space to do that on gerrit1002.
[20:20:41] <hashar>	 one sure thing. Zuul does not CR+2
[20:20:46] <hashar>	 it just  --submit
[20:20:50] <qchris>	 And I do not want to make such experiments on gerrit1001.
[20:20:59] <qchris>	 OK. Thanks for confirming hashar.
[20:21:20] <hashar>	 so either there is a bad bug in Gerrit but surely we would have noticed it eventually after all those years
[20:21:25] <hashar>	 or there is a glitch in polygerrit 
[20:21:57] <hashar>	 s/glitch/a corner use case that has not been properly taken in account due to lack of a test scenario for a feature written ten years ago oh damn I hate software development lets grow tomatoes/
[20:22:02] <hashar>	 glitch is arguably faster to write
[20:22:17] <qchris>	 :-D
[20:22:30] <hashar>	 not that I am on a witchcraft hunt after polygerrit
[20:22:34] * twentyafterfour likes growing tomatoes
[20:22:37] <hashar>	 but that sounds like the most likely case
[20:23:06] <qchris>	 My worry was that the vote itself got lost. You zuul logs debunked that. That helps a lot.
[20:23:33] <hashar>	 also
[20:23:42] <hashar>	 kudos for the nice upgrade report you wrote on the upstream list \o/
[20:24:09] <qchris>	 Hahaha. I thought we owed the Gerrit community an update :)
[20:24:34] <qchris>	 Thanks.
[20:24:42] <hashar>	 qchris: for reference: https://gerrit.wikimedia.org/r/c/All-Projects/+/124891
[20:25:16] <hashar>	 so code-review label has both copyAllScoresOnTrivialRebase and copyAllScoresIfNoCodeChange
[20:25:24] <qchris>	 Yup. I had checked that.
[20:25:34] <qchris>	 And it was not altered recently.
[20:25:49] <hashar>	 I would assume the backend side is fine
[20:26:03] <hashar>	 cause surely they have tests covering the feature
[20:26:11] <qchris>	 Hahahaha :-D
[20:26:19] <qchris>	 They have the best and greatest tests for everything!
[20:26:37] <hashar>	 well there are even release notes for integration tests!
[20:26:50] <hashar>	 so what is possible 
[20:27:02] <hashar>	 if I assume polygerrit is 100% driven by the rest api
[20:27:08] <qchris>	 Yup.
[20:27:11] <hashar>	 maybe the rest api does not expose the CR+2 score
[20:27:54] <qchris>	 If Gerrit thinks there is a CR+2, the REST API would show it.
[20:28:14] <qchris>	 I'll poke around a bit more and try out a few things. We'll see.
[20:28:39] <hashar>	 gerrit query --all-approvals --current-patch-set 604347
[20:28:54] <hashar>	 well that is the ssh one ... :/ Cause curl/json etc are too modern for me
[20:29:09] <paladox>	 i used /detail
[20:29:30] <paladox>	 which showed no plus 2 but it did show James_F in the score (for 0)
[20:30:08] <qchris>	 That shows the CR+2 for PS1, 
[20:30:54] <qchris>	 I'll try re-creating that setup in a local Gerrit 2.15.14. I've stolen enough of your time :)
[20:31:22] <qchris>	 Thanks!
[20:31:29] <hashar>	 well
[20:31:39] <hashar>	 releng literally has Gerrit on its front door
[20:32:01] <hashar>	 and I guess I am one of the few familiar with gerrit internal beside you two and tyler
[20:32:08] <hashar>	 so I guess it makes sense to help? :]]]
[20:32:16] <qchris>	 Totally!
[20:32:19] <hashar>	 + I find those quite challenging
[20:32:22] <qchris>	 And you helped a lot already.
[20:32:33] <hashar>	 and extremely rewarding when they are figured out since that helps a bunch of end users eventually
[20:32:45] <qchris>	 But I think the only thing that can explain what happened is seeing tho whole setup on Gerrit v2.15.
[20:32:52] <hashar>	 today I have learned about /detail (thanks paladox) https://gerrit.wikimedia.org/r/changes/mediawiki%2Fextensions%2FVisualEditor~604347/detail
[20:33:02] <paladox>	 yw :)
[20:33:50] <hashar>	 qchris: you can probably  a dummy gerrit  with just the VisualEditor repo and copyscore things applied to code-review label
[20:33:52] <hashar>	 might be sufficient
[20:34:00] <qchris>	 I hope so.
[20:34:48] <qchris>	 The details URL from above even says:
[20:34:52] <qchris>	     "Code-Review": {
[20:34:58] <qchris>	           "value": 0,
[20:35:06] <hashar>	 yeah
[20:35:09] <qchris>	           "display_name": "Jdf..."
[20:35:31] <qchris>	 Meh. Me pulls the repo and shoehorns it into my local 2.15 Gerrit.
[20:35:40] <qchris>	 Enough talking. On to action :-D
[20:36:11] <hashar>	 cause the last comment was the patchset creation and had no explicit code review associated with it
[20:36:32] <hashar>	 but that is just the comment
[20:37:01] <hashar>	 the change has the CR+2 from the previous patchset but that is not properly exposed in the /detail api 
[20:37:21] <hashar>	 guess we can repro it by sending a dummy patch, cr+2 it.  Rebase
[20:39:02] <hashar>	 tries on https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/608458 ;D
[20:39:34] <qchris>	 :-)
[20:43:46] <hashar>	 hmm
[20:44:55] <hashar>	 or maybe it has to be merged
[20:48:42] <hashar>	 qchris: https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/608458  shows the same behavior
[20:48:46] <hashar>	 as the visualeditor change
[20:48:50] <hashar>	 aka ps2 does not have a CR+2
[20:48:58] <hashar>	 yet i submitted it just fine with zuul
[20:49:00] <hashar>	 BUT 
[20:49:18] <hashar>	 it does not show up in the list of merged change that lack a cr+2 
[20:49:20] <hashar>	 as intended
[20:49:25] <qchris>	 It does show CR+2 from you for me.
[20:49:35] <hashar>	 yeah
[20:52:19] <qchris>	 And if you do https://gerrit.wikimedia.org/r/changes/test%2Fgerrit-ping~608458/detail
[20:52:24] <qchris>	 you also see:
[20:52:36] <qchris>	     "Code-Review": {
[20:52:45] <hashar>	 though mine was a NO_CHANGE
[20:52:45] <qchris>	           "value": 2,
[20:52:48] <wikibugs>	 10Phabricator, 10Developer-Advocacy (Jul-Sep 2020): Review the default options in Phab's Favorites menu; offer dedicated forms for bug reports vs feature requests? - https://phabricator.wikimedia.org/T253744 (10Aklapper)
[20:52:51] <qchris>	           "name": "Hashar",
[20:52:53] <hashar>	 and the VisualEditor one is a REWORK
[20:53:19] <qchris>	 Exactly. That's why I called out in the beginning that I'm not sure the vote got carried over.
[20:54:28] <qchris>	 Hahaha. I asked for 15 minutes of your time. Now it's almost an hour already :)
[20:54:43] <qchris>	 I'll never dare to ask you again :-D
[20:55:00] <qchris>	 Beware: qchris is a time sink :-(
[20:55:29] <hashar>	 yeah ;-\
[20:55:30] <hashar>	 :D
[20:58:06] <hashar>	 and https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/603493  does not even show a comment with CR+2 
[20:58:32] <hashar>	 err it has
[20:59:39] <qchris>	 But it clearly has a non-empty diff between PS10 and PS12 (and no CR+2 afterwards)
[21:00:06] <qchris>	 (And there also the jenkins-bot comments at the bottow look off)
[21:00:24] <qchris>	 (First the merge, then the post merge, then the main test build)
[21:00:35] <qchris>	 (while it should be main test build, merge, then post merge.
[21:02:27] <hashar>	 both /meta for the change and the review notes agreed that change got submitted with a CR+2 made by Umherirrender
[21:02:36] <hashar>	 which comes from an older patchset
[21:03:08] <hashar>	 the main test build can complete after
[21:03:17] <hashar>	 cause it runs with a lower precedence than gate and submit
[21:04:23] <qchris>	 PS8 (the one with the CR+2) and PS16 (the last one) have an empty diff.
[21:04:28] <hashar>	 though in this case, the main build has a non voting job that takes 5 minutes
[21:04:35] <hashar>	 while gate only has sub minutes jobs
[21:04:41] <qchris>	 Ah. Ok. good to know. thanks.
[21:05:03] <hashar>	 so at least
[21:05:12] <hashar>	 the change metadata and review notes are correct
[21:05:31] <hashar>	 and polygerrit miss displaying the label
[21:05:35] <hashar>	 cause it does not get it from the api
[21:05:48] <hashar>	 the search function does not show the change has having a cR+2
[21:06:07] <hashar>	 if I emit the hypothesis that  the api and the search ends up using the secondary index backed up by lucene
[21:06:21] <hashar>	 maybe the metadata are incorrect in the change index
[21:06:48] <hashar>	 or at least the record in the secondary index miss carrying the CR+2 for those few changes for whatever reason
[21:06:51] <hashar>	 :-\
[21:07:20] <hashar>	 I don't feel very helpful sorry
[21:08:25] <qchris>	 You are very helpful :-)
[21:09:28] <qchris>	 But we both don't know what exactly is going on, I guess.
[21:09:44] <qchris>	 But you said it cannot be that bad, otherwise others would have complained too.
[21:09:50] <qchris>	 I agree with that.
[21:09:58] <qchris>	 Still it bugs me what's going on here :-)
[21:10:56] <wikibugs>	 (03CR) 10Hashar: "Yup more ruby ;D" [integration/config] - 10https://gerrit.wikimedia.org/r/604556 (owner: 10Hashar)
[21:14:14] <hashar>	 qchris: maybe compare the /details for two changes (one good the other being bad)
[21:14:38] <hashar>	 or inspect the change index :-\
[21:14:44] <hashar>	 no clue how that is doable thoug
[21:14:59] <qchris>	 It's lucene, so there are plain tools for that.
[21:15:36] <hashar>	 I guess :]
[21:28:05] <wikibugs>	 10Release-Engineering-Team-TODO, 10Operations, 10Projects-Cleanup, 10Traffic, and 2 others: Retire fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T238803 (10Legoktm) >>! In T238803#5680344, @CCicalese_WMF wrote: > As noted in the second last bullet, it is desired that we not archive the ext...
[21:34:02] <shinken-wm_>	 PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%)
[21:34:09] <wikibugs>	 10Release-Engineering-Team-TODO, 10Operations, 10Projects-Cleanup, 10Traffic, and 2 others: Retire fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T238803 (10CCicalese_WMF) Makes sense. At this point, I think it makes sense to archive EUCopyrightCampaign and EUCopyrightCampaignSkin.
[21:44:00] <shinken-wm_>	 RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)
[21:55:24] <wikibugs>	 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10thcipriani)
[22:12:49] <wikibugs>	 10Release-Engineering-Team-TODO, 10Operations, 10Projects-Cleanup, 10Traffic, and 2 others: Retire fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T238803 (10Legoktm) I filed {T256690} and {T256691}.
[22:17:18] <wikibugs>	 10Release-Engineering-Team-TODO, 10Operations, 10Projects-Cleanup, 10Traffic, and 2 others: Retire fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T238803 (10CCicalese_WMF) Thank you, @Legoktm!
[22:45:45] <wikibugs>	 10phan-taint-check-plugin: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) p:05Lowest→03Medium Given the recent improvements of conditional branches and a few other things still under review, I'd like to retry this one. I think this is currently the biggest l...
[23:43:25] <wikibugs>	 10VPS-project-codesearch, 10Analytics, 10Patch-For-Review: Add analytics/* gerrit repos to code search - https://phabricator.wikimedia.org/T249318 (10Legoktm) https://codesearch.wmflabs.org/analytics/ is live now, except... uBlock Origin blocks `analytics/js` by default, so it doesn't work unless you disable...