[00:28:29] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10thcipriani) [01:59:45] 10Gerrit: Gerrit shows lots of apparently unchanged lines in the diff - https://phabricator.wikimedia.org/T256702 (10Huji) [02:50:08] (03PS1) 10Jeena Huneidi: Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) [02:51:17] (03CR) 10jerkins-bot: [V: 04-1] Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) (owner: 10Jeena Huneidi) [03:22:08] (03PS2) 10Jeena Huneidi: Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) [03:23:02] (03CR) 10jerkins-bot: [V: 04-1] Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) (owner: 10Jeena Huneidi) [03:29:50] (03PS3) 10Jeena Huneidi: Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) [07:21:16] 10Gerrit: Gerrit shows lots of apparently unchanged lines in the diff (due to line ending change from LF to CRLF) - https://phabricator.wikimedia.org/T256702 (10Aklapper) [07:26:08] 10Gerrit: Gerrit shows lots of apparently unchanged lines in the diff (due to line ending change from LF to CRLF) - https://phabricator.wikimedia.org/T256702 (10Aklapper) Also see {T53754}. I cannot find any potential setting on https://gerrit.wikimedia.org/r/settings/#DiffPreferences Also note that [Gerrit's di... [07:31:03] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Stop using integration/composer and then archive the repo - https://phabricator.wikimedia.org/T249949 (10hashar) I have cleaned the releases* hosts. [07:32:38] !log contint2001: rm -fR /srv/deployment/integration/slave-scripts # T252955 [07:32:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:32:41] T252955: Archive integration/jenkins.git - https://phabricator.wikimedia.org/T252955 [07:38:09] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [07:48:09] ACKNOWLEDGEMENT - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] amusso spike of mediawiki/core changes https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [07:58:59] (03PS2) 10Lokal Profil: Add FORGE_SERVER during initial import [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608234 (owner: 10Karl Wettin (WMSE)) [07:59:16] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash, 10User-DannyS712: Logstash-beta doesn't include any deprecation notices - https://phabricator.wikimedia.org/T256722 (10DannyS712) [08:00:11] (03CR) 10Lokal Profil: [V: 03+2 C: 03+2] Add FORGE_SERVER during initial import [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608234 (owner: 10Karl Wettin (WMSE)) [08:00:20] 10Beta-Cluster-Infrastructure, 10Wikimedia-Logstash, 10User-DannyS712: Logstash-beta doesn't include any deprecation notices - https://phabricator.wikimedia.org/T256722 (10DannyS712) [08:17:54] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [08:18:14] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: (Service Check Timed Out) [08:18:57] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [08:23:06] 10Gerrit, 10Upstream: Gerrit shows lots of apparently unchanged lines in the diff (due to line ending change from LF to CRLF) - https://phabricator.wikimedia.org/T256702 (10hashar) If you head to the diff at https://gerrit.wikimedia.org/r/c/mediawiki/libs/Equivset/+/604545/8/data/equivset.in you can change th... [08:24:23] 10Gerrit, 10Upstream: Gerrit shows lots of apparently unchanged lines in the diff (due to line ending change from LF to CRLF) - https://phabricator.wikimedia.org/T256702 (10hashar) [08:30:18] Zuul appears to be clogged by the commits of https://gerrit.wikimedia.org/r/q/owner:soham.parekh1998%2540gmail.com - see https://integration.wikimedia.org/zuul/ [08:32:45] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 97632 bytes in 1.496 second response time [08:33:09] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 61350 bytes in 2.514 second response time [08:33:48] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 97327 bytes in 1.176 second response time [08:36:38] 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10hashar) @Qchris and I chatted about it last night and we could not find any obvious reason for the lack of CR+2. The change metadata or review notes do show the change got submitt... [09:22:12] hashar: did we have a guide for moving repos to gerrit somewhere? [09:22:26] we dont move them :( [09:22:33] that might change with 3.2 though [09:22:40] since afaik there is no more database conncetion [09:22:50] hashar: no, importing from another source [09:23:00] so all the state is solely in the git repo. It might just be about moving the repo on disk and reindex it [09:23:00] ah [09:23:09] RhinosF1: https://www.mediawiki.org/wiki/Git/Creating_new_repositories#Importing_from_an_existing_repository [09:23:37] thanks [09:55:55] 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Lucas_Werkmeister_WMDE) [09:56:38] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [10:18:35] (03PS1) 10Lokal Profil: Review access change [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608480 [10:19:02] (03PS2) 10Lokal Profil: Enable force push for initial import [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608480 [10:24:13] 10Gerrit, 10Developer Productivity, 10User-DannyS712: Feature request: Resolving merge conflicts from web interface - https://phabricator.wikimedia.org/T256731 (10DannyS712) [10:24:25] 10Gerrit, 10Developer Productivity, 10User-DannyS712: Feature request: Resolving merge conflicts from web interface - https://phabricator.wikimedia.org/T256731 (10DannyS712) [10:52:28] 10Project-Admins: create tag and a group for wikinews (any language) for bug tracking at phabricator - https://phabricator.wikimedia.org/T256735 (10Majavah) [10:54:27] 10Project-Admins: create tag and a group for wikinews (any language) for bug tracking at phabricator - https://phabricator.wikimedia.org/T256735 (10DannyS712) Scripts and gadgets are generally out of the scope of phabricator. See also {T154549} [11:15:07] 10Phabricator, 10User-DannyS712: Unable to set final story points for bug subtype - https://phabricator.wikimedia.org/T256346 (10mmodell) 05Open→03Resolved a:03mmodell [11:20:15] 10Phabricator, 10User-DannyS712: Unable to set final story points for Production error subtype - https://phabricator.wikimedia.org/T256739 (10DannyS712) [11:20:31] 10Phabricator, 10User-DannyS712: Unable to set final story points for Production error subtype - https://phabricator.wikimedia.org/T256739 (10DannyS712) [11:20:33] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:20:45] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:20:47] 10Phabricator, 10User-DannyS712: Unable to set final story points for Production error subtype - https://phabricator.wikimedia.org/T256739 (10DannyS712) [11:22:24] 10Phabricator, 10User-DannyS712: Unable to set final story points for feature request subtype - https://phabricator.wikimedia.org/T256740 (10DannyS712) [11:22:39] 10Phabricator, 10User-DannyS712: Unable to set final story points for feature request subtype - https://phabricator.wikimedia.org/T256740 (10DannyS712) [11:24:15] 10Phabricator, 10User-DannyS712: Unable to set final story points for deadline subtype - https://phabricator.wikimedia.org/T256741 (10DannyS712) [11:24:25] 10Phabricator, 10User-DannyS712: Unable to set final story points for deadline subtype - https://phabricator.wikimedia.org/T256741 (10DannyS712) [11:24:27] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:25:41] 10Phabricator, 10User-DannyS712: Unable to set final story points for security issue subtype - https://phabricator.wikimedia.org/T256742 (10DannyS712) [11:25:52] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:25:54] 10Phabricator, 10User-DannyS712: Unable to set final story points for security issue subtype - https://phabricator.wikimedia.org/T256742 (10DannyS712) [11:27:04] 10Phabricator, 10User-DannyS712: Unable to set final story points for design subtype - https://phabricator.wikimedia.org/T256743 (10DannyS712) [11:27:13] 10Phabricator, 10User-DannyS712: Unable to set final story points for design subtype - https://phabricator.wikimedia.org/T256743 (10DannyS712) [11:27:15] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:28:06] 10Phabricator, 10User-DannyS712: Unable to set final story points for goal subtype - https://phabricator.wikimedia.org/T256744 (10DannyS712) [11:28:16] 10Phabricator, 10User-DannyS712: Unable to set final story points for goal subtype - https://phabricator.wikimedia.org/T256744 (10DannyS712) [11:28:18] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) [11:28:46] 10Phabricator, 10Core Platform Team: Provide field for Actual Story Points to be captured - https://phabricator.wikimedia.org/T239870 (10DannyS712) I've filed tasks for the other subtypes that currently include an estimated points field but no final points field [11:34:06] 10Release-Engineering-Team-TODO, 10User-zeljkofilipin: CI failures unrelated to patch - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [11:34:30] 10Release-Engineering-Team-TODO, 10User-zeljkofilipin: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [11:36:27] 10Release-Engineering-Team-TODO, 10User-zeljkofilipin: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [11:38:16] 10Release-Engineering-Team-TODO, 10User-zeljkofilipin: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [12:14:55] 10Project-Admins: create tag and a group for wikinews (any language) for bug tracking at phabricator - https://phabricator.wikimedia.org/T256735 (10Aklapper) 05Open→03Stalled @Gryllida: If people listed these tasks here, which underlying problem would be solved and by whom? I'd like to avoid that people spen... [12:19:26] 10Phabricator, 10User-DannyS712: Unable to set final story points for Production error subtype - https://phabricator.wikimedia.org/T256739 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy Done [12:20:06] 10Phabricator, 10User-DannyS712: Unable to set final story points for feature request subtype - https://phabricator.wikimedia.org/T256740 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy Done [12:20:54] 10Phabricator, 10User-DannyS712: Unable to set final story points for deadline subtype - https://phabricator.wikimedia.org/T256741 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy Done [12:21:34] 10Phabricator, 10User-DannyS712: Unable to set final story points for security issue subtype - https://phabricator.wikimedia.org/T256742 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy [12:22:16] 10Phabricator, 10User-DannyS712: Unable to set final story points for design subtype - https://phabricator.wikimedia.org/T256743 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy Done [12:23:04] 10Phabricator, 10User-DannyS712: Unable to set final story points for goal subtype - https://phabricator.wikimedia.org/T256744 (10Reedy) 05Open→03Resolved a:05mmodell→03Reedy Done [12:26:27] 10Gerrit, 10Developer Productivity, 10Upstream, 10User-DannyS712: Feature request: Resolving merge conflicts from web interface - https://phabricator.wikimedia.org/T256731 (10hashar) That is a feature for #upstream to implement. Interestingly such request just 3 months ago asking // to perform the conflict... [12:26:40] 10Gerrit, 10Developer Productivity, 10Upstream, 10User-DannyS712: Feature request: Resolving merge conflicts from web interface - https://phabricator.wikimedia.org/T256731 (10hashar) [13:05:18] 10Release-Engineering-Team-TODO, 10User-zeljkofilipin: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [13:18:39] (03CR) 10Karl Wettin (WMSE): [V: 03+2 C: 03+2] Enable force push for initial import [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608480 (owner: 10Lokal Profil) [13:29:57] 10Release-Engineering-Team-TODO, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-betacommons-MediaWiki fails with `fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository` - https://phabricator.wikimedia.org/T256759 (10zeljkofilipin) [13:30:06] 10Release-Engineering-Team-TODO, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-betacommons-MediaWiki fails with `fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository` - https://phabricator.wikimedia.org/T256759 (10zeljkofilipin) p:05Triage→... [13:33:20] 10Release-Engineering-Team-TODO, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-(beta)commons-MediaWiki fails with `fatal: Refusing to fetch into current branch refs/heads/master of non-bare repository` - https://phabricator.wikimedia.org/T256759 (10zeljkofilipin) [13:33:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-(beta)commons-MediaWiki fails w... - https://phabricator.wikimedia.org/T256759 [13:35:26] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-* Jenkins jobs fail with `fatal... - https://phabricator.wikimedia.org/T256759 [13:44:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-* Jenkins jobs fail with `fatal... - https://phabricator.wikimedia.org/T256759 [13:44:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: CI fetching tags should also create the local tag references - https://phabricator.wikimedia.org/T186496 (10hashar) [13:44:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-* Jenkins jobs fail with `fatal... - https://phabricator.wikimedia.org/T256759 [13:52:51] 10Beta-Cluster-Infrastructure, 10Analytics-EventLogging, 10Analytics-Radar, 10Product-Analytics, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.31x-P-Pryanik): Remove MobileWikiAppProtectedEditAttempt schema from Android app - https://phabricator.wikimedia.org/T254567 (10Dbrant) 05Open→03Re... [13:56:21] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-zeljkofilipin: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [14:03:38] (03PS1) 10Hashar: dockerfiles: allow fetch when ZUUL_REF=master [integration/config] - 10https://gerrit.wikimedia.org/r/608626 (https://phabricator.wikimedia.org/T256759) [14:05:06] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10WikibaseMediaInfo, 10User-zeljkofilipin, 10ci-test-error: CI fails to install fibers@4.0.3 - https://phabricator.wikimedia.org/T256460 (10hashar) I have no idea what is happening in the reposi... [14:09:58] (03CR) 10Hashar: [C: 03+2] dockerfiles: allow fetch when ZUUL_REF=master [integration/config] - 10https://gerrit.wikimedia.org/r/608626 (https://phabricator.wikimedia.org/T256759) (owner: 10Hashar) [14:09:59] 10Gerrit, 10DBA, 10Patch-For-Review: Make sure both `reviewdb-test` (used forgerrit upgrade testing) and `reviewdb` (formerly production) databases get torn down - https://phabricator.wikimedia.org/T255715 (10jcrespo) @Dzahn @QChris Can this start happening? Database backups will be available for some time a... [14:10:09] (03PS1) 10Hashar: jjb: use ci-src-setup-simple:0.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/608627 (https://phabricator.wikimedia.org/T256759) [14:11:02] (03Merged) 10jenkins-bot: dockerfiles: allow fetch when ZUUL_REF=master [integration/config] - 10https://gerrit.wikimedia.org/r/608626 (https://phabricator.wikimedia.org/T256759) (owner: 10Hashar) [14:11:31] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10hashar) 1.35.0-wmf.39 is now on testwiki: https://test.wikipedia.org/wiki/Special:Version [14:15:25] !log Updating docker-pkg files for https://gerrit.wikimedia.org/r/608626 [14:15:26] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:22:03] Grr new gerrit interface [14:22:15] I somehow ended up editing an old PS and re-introduced something I'd already fixed [14:23:04] :-/ [14:23:31] Not quite sure how I managed to do that [14:23:35] Probably user error [14:23:42] * hashar drops #gerrit tag from reedy issue (human error) [14:23:44] ;D [14:24:01] that is via the web editor isn't it ? [14:25:29] Yeah [14:25:35] I thought it would "easier" [14:25:38] * Reedy coughs, loudly [14:25:47] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10hashar) 1.35.0-wmf.39 is now on group0 wikis. [14:26:28] https://gerrit.wikimedia.org/r/c/mediawiki/skins/WikimediaApiPortal/+/605825 [14:26:29] Hmm [14:26:37] It does say I edited each PS in order... So god knows what happened [14:35:13] 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop jessie testing support - https://phabricator.wikimedia.org/T224908 (10hashar) [14:35:17] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10JavaScript: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects - https://phabricator.wikimedia.org/T211784 (10hashar) [14:38:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), and 2 others: selenium-daily-* Jenkins jobs fail with `fatal: Refusing... - https://phabricator.wikimedia.org/T256759 [14:48:52] Reedy oh, were you viewing an old diff and clicked "edit"? [14:49:14] Possibly [14:49:21] But the changelog wouldn't say so [14:49:38] It reckons I pushlished a patch on the last PS. Or so it outputs [14:49:47] oh, yeh [14:49:57] you can edit old patchsets and it'll act like a new patchset [14:51:00] Which is fine.. but it should log that I edited an older PS [14:51:12] https://gerrit.wikimedia.org/r/605825 [14:51:42] Instead of [14:51:43] Published edit on patch set 10. [14:51:44] Published edit on patch set 11. [14:51:46] Published edit on patch set 12. [14:51:48] Published edit on patch set 13. [14:51:49] etc [14:52:22] I mean yeh, it should tell you if your editing an old patchset [15:09:19] (03PS3) 10Thiemo Kreuz (WMDE): Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) [15:21:35] for gerrit repo archive requests do i file that under releng or repo admins? [15:21:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), and 2 others: selenium-daily-* Jenkins jobs fail with `fatal: Refusing... - https://phabricator.wikimedia.org/T256759 [15:21:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: CI fetching tags should also create the local tag references - https://phabricator.wikimedia.org/T186496 (10hashar) [15:22:00] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [15:23:43] Zppix: repo-admins [15:26:31] thanks greg [15:42:06] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10WikibaseMediaInfo, 10User-zeljkofilipin, 10ci-test-error: fibers@4.0.3 fails to install in WikibaseMediaInfo - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [15:44:28] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10WikibaseMediaInfo, 10User-zeljkofilipin, 10ci-test-error: fibers@4.0.3 fails to install in WikibaseMediaInfo - https://phabricator.wikimedia.org/T256460 (10zeljkofilipin) [15:57:11] paladox: How do you create a new change through the UI now? It's not on the project page... [15:57:31] Reedy it should be on the project page at the bottom [15:57:41] oh [15:57:45] Reedy ,commands [15:57:55] That's... not obvious :) [15:58:23] :P [15:58:33] maybe we should stick "Go to commands" at the bottom [15:59:48] we can create a plugin actually [15:59:49] using repo-config [16:02:07] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10dancy) [16:03:38] 10LibUp, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), 10Patch-For-Review, and 3 others: wikibase bridge test:storybook causes Error from chokidar, Error: ENOSPC: System limit for number of file watchers reached in CI - https://phabricator.wikimedia.org/T255247 (10Addshore) 05Open→03Resolved [16:22:03] hello! joal and I are experiencing a weird gerrit problem [16:22:07] https://gerrit.wikimedia.org/r/c/analytics/refinery/source/+/608662/ [16:22:28] jenkins is failling due to merge rebase error [16:22:28] but [16:22:36] the patch is totally rebased and on top of everything [16:24:38] paladox: are we doing somethi8ing wrong there? [16:25:43] joal: i'm going to remove jenkins -1 and see what happens [16:25:57] ottomata: try "recheck" comment [16:26:07] joal tried that before, will try again [16:27:30] nopers same thing [16:27:51] i merged without jenkins verify...will see if it fails actual merge [16:28:17] seems to have worked ok [16:32:29] ya dunno why jenkins was unhappy there, the merge was fine [16:45:44] looks like new gerrit has slightly misformatted gerritbot output in phab? https://phabricator.wikimedia.org/T252605#6268337 [16:45:52] note the space in the URL (which winds up getting rewritten and being harmless, but) [16:46:32] cdanis: there's a task open. [16:46:36] ack ty [16:47:11] (03PS1) 10Cicalese: Start branching WikimediaApiPortal skin and WikimediaApiPortalOAuth extension [tools/release] - 10https://gerrit.wikimedia.org/r/608687 (https://phabricator.wikimedia.org/T251279) [16:56:09] (03CR) 10Reedy: [C: 03+2] Start branching WikimediaApiPortal skin and WikimediaApiPortalOAuth extension [tools/release] - 10https://gerrit.wikimedia.org/r/608687 (https://phabricator.wikimedia.org/T251279) (owner: 10Cicalese) [16:56:30] PROBLEM - Host deployment-cpjobqueue is DOWN: CRITICAL - Host Unreachable (172.16.4.124) [16:56:30] PROBLEM - Host deployment-changeprop is DOWN: CRITICAL - Host Unreachable (172.16.5.21) [16:57:18] (03Merged) 10jenkins-bot: Start branching WikimediaApiPortal skin and WikimediaApiPortalOAuth extension [tools/release] - 10https://gerrit.wikimedia.org/r/608687 (https://phabricator.wikimedia.org/T251279) (owner: 10Cicalese) [16:59:56] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10WDoranWMF) @Ladsgroup Are there blockers on this that CPT should resolve? [17:18:25] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): Write a proposal to stop central management of mediawiki dependencies in CI - https://phabricator.wikimedia.org/T256781 (10hashar) [17:32:54] 10Gerrit, 10git-protocol-v2: Gerrit upload-pack send ALL references causing massive network I/O on common operations - https://phabricator.wikimedia.org/T103990 (10hashar) 05Stalled→03Resolved a:03hashar This has been solved by Google proposing a new version of the git protocol. https://opensource.google... [17:35:18] 10Continuous-Integration-Config, 10Product-Infrastructure-Team-Backlog: mobileapps-periodic-test CI job is failing since 2020-06-29 13:03 UTC - https://phabricator.wikimedia.org/T256657 (10Mholloway) 05Open→03Resolved a:03Mholloway Fixed as of 16:03 UTC today. [17:36:57] 10Release-Engineering-Team (Deployment services), 10Scap: Build MediaWiki l10n cache when preparing a new version - https://phabricator.wikimedia.org/T256784 (10hashar) [17:37:28] 10Release-Engineering-Team (Deployment services), 10Scap: Build MediaWiki l10n cache when preparing a new version - https://phabricator.wikimedia.org/T256784 (10hashar) [17:38:55] Calling method \OutputPage::addHTML() in \Wikibase\Repo\FederatedProperties\SpecialListFederatedProperties::execute that outputs using tainted argument $[arg #1]. (Caused by: Builtin-\OutputPage::addHTML) (Caused by: repo/includes/FederatedProperties/SpecialListFederatedProperties.php +40)" source="SecurityCheck-XSS" [17:39:00] what exactly does that mean? O_o [17:41:18] Reedy: ^^? :D [17:41:27] shits broken [17:41:33] "
" . $this->htmlNotice() . "
" [17:42:23] I was hoping to find some docs looking for SecurityCheck-XSS on mw.org, but didnt find anything [17:44:04] where did you find that? :D [17:44:42] the error? on my patch! :P [17:45:16] interestingly, it was green earlier and i basically didnt change anyhting [17:46:32] the line with the error is line 35 of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/607539/6..11/repo/includes/FederatedProperties/SpecialListFederatedProperties.php (was 31 and was green in that state) [17:48:12] I mean, I changed the method name, added a return type, and removed a param.... but it was getting a string, and is still getting a string, and now I have this odd warning [17:49:06] hmmm, probably it does not realize you're just calling wfMessage() and gets scared [17:49:12] or something like that [17:49:32] *quietly rages* let me try removing the return type [17:50:04] but wait, that can't be it..... as the result of htmlNotice() is just concated with some other strings [17:50:16] any static analysis should still just think it is a string, same as before :/ [17:50:43] what does "that outputs using tainted argument" exactly mean? [17:50:48] no idea [17:51:24] https://github.com/wikimedia/phan-taint-check-plugin/blob/d5a011d02aa34f5764e34435a57466a55f8b22b9/src/TaintednessBaseVisitor.php#L2040-L2041 [17:51:30] that sounds like the concept of tainted variables in perl? like where inputs are considered tainted until validated... [17:57:15] who owns the phan taint check plugin? the sec team? [17:57:56] based on the name you can probably complain to them [17:58:16] addshore: yeah [17:58:38] * addshore will try to run it locally and figure it out for 15 mins before writing a ticket and "complaining" :P [18:01:02] Daimona owns it much more than we do... [18:08:34] im guessing maybe it is because the method being used in the middle of the string is partly made up of something passed into the class constructor, perhaps [18:10:46] Yeah I'm probably the one to ask to about taint-check [18:10:51] :D [18:11:04] The plugin is still beta, so expect some fuzziness [18:11:07] If you have any ideas what im doing wrong I'd love to know / if i should just be turning the check off for that line :) [18:11:21] * addshore still isn't sure about the intention of the check even [18:11:52] The work left to do is huge, so it's going to take some time. Which, BTW leads to the question (for Reedy): can the secteam be somehow considered owner of this tool? [18:12:22] I'm giving it a look [18:12:27] ty :) [18:12:30] But a quick one, I cannot really debug it properly right now [18:12:49] yup, if you dont spot anything I'll just add an ignore comment for now [18:13:19] Ah yes this is a true positive [18:13:29] You're outputting Message::text() [18:13:35] Which is not HTML-safe [18:14:00] aah, i should be using parse! [18:14:11] Or escaped(), yes [18:16:55] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10Patch-For-Review, and 4 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Ladsgroup) >>! In T246945#6268461, @WDoranWMF wrote: > @Ladsgroup Are there blockers on this that CPT s... [18:18:57] Ty Daimona! :) [18:23:39] Yw :) [18:24:35] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10Ammarpad) [18:55:49] oh a ping [19:11:35] Reedy: did you strike up the deal that we have with jetbrains? [19:11:49] addshore: Yes [19:11:52] if so, want to strike up the same deal with another org? (or would that be bad press? xD) [19:11:53] https://www.devsense.com/en/purchase/faq/open-source#php-tools-licenses-are-free-for-open-source-projects [19:12:11] PHP in VS? [19:12:14] yup [19:12:17] >This list is more accurate and exhaustive: https://phabricator.wikimedia.org/T254628 [19:12:21] wrong copy [19:12:23] >release updated builds regularly [19:12:25] We don't release builds [19:12:29] You can't have a license [19:12:31] meh, we kind of do? [19:12:40] >not be paid to work on the project [19:12:50] Didn't jetbrains have a line like "not be paid to work on the project" too though? [19:12:55] Not originally [19:12:59] aaah [19:13:00] They give us an exemption now though [19:13:04] Because of who we are [19:13:55] fancy sending them an email anyway seeing? :P if not I might! [19:14:18] cdanis strange [19:14:18] It's not clear from that page whether it's per developer to apply, or a project to apply [19:14:33] >The project must not receive any funding from commercial organizations or any form of paid sponsorship. [19:14:40] Their rules seem even more strict [19:15:27] * addshore drafts an email [19:23:19] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Remove unused `scap swat` command - https://phabricator.wikimedia.org/T254787 (10thcipriani) a:05LarsWirzenius→03None [19:39:11] Reedy: my correspondence so far feel promising :) [20:00:20] 10Project-Admins: Create component 'wmf-sre-laptop' - https://phabricator.wikimedia.org/T256803 (10CDanis) [20:06:52] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), and 5 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10WDoranWMF) @Ladsgroup Who should be a reviewer for the DNS patch? [20:23:25] 10Project-Admins, 10cloud-services-team (Kanban): Create #acl*wmcs-team - https://phabricator.wikimedia.org/T255731 (10bd808) Nobody complained, and 2 folks gave thumbs up tokens, so I'll make this. [20:26:22] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Write and send release announcements for MediaWiki 1.35.0 - https://phabricator.wikimedia.org/T256380 (10eprodromou) a:03eprodromou As PM for PET, I'll take on the task for doing this. @CCicales... [20:27:37] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Announce 1.35 "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T256378 (10eprodromou) a:03eprodromou As PM of PET, I should probably take this on. @CCica... [20:30:30] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Announce 1.35 "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T256378 (10CCicalese_WMF) 👍 [20:30:59] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Write and send release announcements for MediaWiki 1.35.0 - https://phabricator.wikimedia.org/T256380 (10CCicalese_WMF) 👍 [20:31:58] oh [20:32:01] i see the issue [20:32:12] cdanis [20:32:26] It's because we escape the url which now has a plus in it [20:33:27] oh [20:34:37] actually i got that mixed up with the subject... [20:35:09] 10Project-Admins, 10cloud-services-team (Kanban): Create #acl*wmcs-team - https://phabricator.wikimedia.org/T255731 (10bd808) 05Open→03Resolved a:03bd808 #acl_wmcs-team [20:40:48] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), and 5 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Ladsgroup) There's three. The one you mentioned, https://gerrit.wikimedia.org/... [20:46:01] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [20:56:00] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [21:01:57] 10Project-Admins, 10cloud-services-team (Kanban): Create #acl*wmcs-team - https://phabricator.wikimedia.org/T255731 (10Peachey88) 05Resolved→03Open you need to change the join settings, aka I can still become a member [21:02:18] 10Release-Engineering-Team-TODO, 10Core Platform Team, 10CPT Initiatives (API Gateway), 10MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), and 5 others: New Public Wiki for the API Portal - https://phabricator.wikimedia.org/T246945 (10Reedy) [21:04:22] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10git-protocol-v2: Find the minimal git version to use for protocol v2 - https://phabricator.wikimedia.org/T256810 (10hashar) [21:06:47] 10Project-Admins, 10cloud-services-team (Kanban): Create #acl*wmcs-team - https://phabricator.wikimedia.org/T255731 (10bd808) 05Open→03Resolved >>! In T255731#6269516, @Peachey88 wrote: > you need to change the join settings, aka I can still become a member Oops! Thanks for catching that. I has set the ed... [21:09:40] (03CR) 10Hashar: [C: 03+2] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/608627 (https://phabricator.wikimedia.org/T256759) (owner: 10Hashar) [21:10:43] (03Merged) 10jenkins-bot: jjb: use ci-src-setup-simple:0.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/608627 (https://phabricator.wikimedia.org/T256759) (owner: 10Hashar) [21:30:31] * Reedy stabs Phabs lack of conflict resolution [21:30:51] why yes, last person to save wins, that makes perfect sense [21:37:11] to save what? [21:41:06] the princess [22:24:44] 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10QChris) 05Open→03Declined @Umherirrender: What a great find. Thanks! I went through the first 50 patch sets of [[https://gerrit.wikimedia.org/r/q/status:merged+-label:Code-Rev... [22:24:49] 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [23:20:07] !log Clean up bogus empty captchas from beta presumably caused by testing of T230245 [23:20:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:20:10] T230245: GenerateFancyCaptchas.php crashes with "FormatJson.php: File not found in" after 1000 iterations - https://phabricator.wikimedia.org/T230245 [23:55:59] 10Continuous-Integration-Config: Support Rust repositories in CI - https://phabricator.wikimedia.org/T256827 (10Legoktm)