[00:12:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wiki-Loves-Monuments-Database, 10User-JeanFred: Automate deployment of heritage on Gerrit post-merge - https://phabricator.wikimedia.org/T157893 (10Legoktm) @hashar and I discus... [01:24:56] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), and 2 others: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10CCicalese_WMF) [03:38:11] (03PS1) 10Krinkle: doc: Set 'lang' and 'tagline' for Purtle [integration/docroot] - 10https://gerrit.wikimedia.org/r/608751 [03:38:20] (03CR) 10Krinkle: [C: 03+2] doc: Set 'lang' and 'tagline' for Purtle [integration/docroot] - 10https://gerrit.wikimedia.org/r/608751 (owner: 10Krinkle) [03:39:05] Reedy: oops :) thanks for that [03:39:09] (03Merged) 10jenkins-bot: doc: Set 'lang' and 'tagline' for Purtle [integration/docroot] - 10https://gerrit.wikimedia.org/r/608751 (owner: 10Krinkle) [03:42:51] qchris: awesome research on T256633, thank you. [03:42:51] T256633: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 [07:25:34] 10Beta-Cluster-Infrastructure, 10Operations, 10observability, 10serviceops, 10Patch-For-Review: Stream a subset of mediawiki apache logs to logstash - https://phabricator.wikimedia.org/T244472 (10hashar) Just a note the Apache logs are still emitted to logstash for mw1262 and mw1276 ` name=hieradata/host... [08:00:42] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10git-protocol-v2: Find the minimal git version to use for protocol v2 - https://phabricator.wikimedia.org/T256810 (10hashar) From git changelog 2.18.0 * A new version of the transport protocol is being worked on... [08:03:52] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10git-protocol-v2: Find the minimal git version to use for protocol v2 - https://phabricator.wikimedia.org/T256810 (10hashar) 05Open→03Resolved a:03hashar I have already switched releng/ci-src-setup to Buster... [08:09:00] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10git-protocol-v2: Update Stretch CI containers to use a git that supports ... - https://phabricator.wikimedia.org/T256844 [08:34:18] (03PS3) 10Jforrester: layout: Stop ascribing stuff to REL1_33 pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607736 (https://phabricator.wikimedia.org/T256087) [08:34:29] (03CR) 10Jforrester: [C: 03+2] "It's now July." [integration/config] - 10https://gerrit.wikimedia.org/r/607736 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:35:48] (03Merged) 10jenkins-bot: layout: Stop ascribing stuff to REL1_33 pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607736 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:37:01] !log Zuul: Stop ascribing stuff to REL1_33 pipelines T256087 [08:37:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:37:03] T256087: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 [08:37:16] (03PS2) 10Jforrester: layout: Stop defining the REL1_33 pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607737 (https://phabricator.wikimedia.org/T256087) [08:37:29] (03CR) 10Jforrester: [C: 03+2] layout: Stop defining the REL1_33 pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607737 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:38:32] (03Merged) 10jenkins-bot: layout: Stop defining the REL1_33 pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607737 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:38:56] !log Zuul: Stop defining the REL1_33 pipelines at all T256087 [08:38:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:39:18] (03PS2) 10Jforrester: layout: Stop referencing REL1_33 pipeline, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/607738 [08:39:25] (03CR) 10Jforrester: [C: 03+2] layout: Stop referencing REL1_33 pipeline, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/607738 (owner: 10Jforrester) [08:39:33] (03PS2) 10Jforrester: jjb: Drop REL1_33 jjb jobs, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/607739 (https://phabricator.wikimedia.org/T256087) [08:40:25] (03Merged) 10jenkins-bot: layout: Stop referencing REL1_33 pipeline, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/607738 (owner: 10Jforrester) [08:42:55] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/607739 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:43:43] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-General, and 2 others: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 (10Jdforrester-WMF) 05Open→03Resolved Done. [08:43:45] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.8/1.33.4/1.34.2 - https://phabricator.wikimedia.org/T248534 (10Jdforrester-WMF) [08:43:52] (03Merged) 10jenkins-bot: jjb: Drop REL1_33 jjb jobs, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/607739 (https://phabricator.wikimedia.org/T256087) (owner: 10Jforrester) [08:44:00] (03PS2) 10Jforrester: jjb: Configure REL1_35 for quibble-integration and mediawiki-php-security [integration/config] - 10https://gerrit.wikimedia.org/r/607815 [08:44:17] (03PS3) 10Jforrester: Zuul: Configure the REL1_35 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607816 (https://phabricator.wikimedia.org/T256377) [08:45:16] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/607815 (owner: 10Jforrester) [08:46:10] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Patch-For-Review: Rename all our quibble jobs to make some sense - https://phabricator.wikimedia.org/T254814 (10Jdforrester-WMF) p:05High→03Low a:05Jdforrester-WMF→03None... [08:46:17] (03Merged) 10jenkins-bot: jjb: Configure REL1_35 for quibble-integration and mediawiki-php-security [integration/config] - 10https://gerrit.wikimedia.org/r/607815 (owner: 10Jforrester) [08:46:46] (03CR) 10Jforrester: [C: 03+2] Zuul: Configure the REL1_35 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607816 (https://phabricator.wikimedia.org/T256377) (owner: 10Jforrester) [08:47:42] (03Merged) 10jenkins-bot: Zuul: Configure the REL1_35 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/607816 (https://phabricator.wikimedia.org/T256377) (owner: 10Jforrester) [08:47:56] !log Zuul: Configure the REL1_35 test and gate pipelines T256377 [08:47:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:47:58] T256377: Configure CI to support REL1_35 - https://phabricator.wikimedia.org/T256377 [08:48:30] 10Continuous-Integration-Config, 10MediaWiki-Releasing, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), and 3 others: Configure CI to support REL1_35 - https://phabricator.wikimedia.org/T256377 (10Jdforreste... [08:48:31] 10MediaWiki-Releasing, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10MW-1.35-notes, 10MW-1.35-release: Branch REL1_35 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T256376 (10Jdforrester-WMF) [08:50:57] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-General, and 2 others: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 (10Aklapper) I see zero recent edits on https://www.mediawiki.o... [08:51:01] 10phan-taint-check-plugin: Implement ReDoS detection - https://phabricator.wikimedia.org/T256661 (10Daimona) >>! In T256661#6265248, @sbassett wrote: >> I don't think there's a proper way to sanitize user input in regexps, so probably a new type that cannot be cleared. > > Such solutions (and more elaborate on... [09:17:03] 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10hashar) @QChris that is awesome! Thank you for the very detailed explanation as to why some CR+2 are no more showing when in Gerrit 2.15 they definitely had it. Well done! (thank... [09:22:20] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Jdforrester-WMF) p:05Triage→03Medium [09:22:39] 10MediaWiki-Releasing, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10MW-1.35-notes, 10MW-1.35-release: Branch REL1_35 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T256376 (10Jdforrester-WMF) p:05Triage→03High [09:32:27] 10phan-taint-check-plugin: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) a:03Daimona [10:04:47] 10Project-Admins, 10Developer-Advocacy, 10User-notice: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802 (10Aklapper) In hindsight I think this was a bad idea and should not have been done. See {T196740}. [10:24:36] wmf-quibble-selenium-php72-docker (executing on integration-agent-docker-1005) just got a “no space left on device” error after installing MediaWiki https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/48181/console [10:25:21] Could I have triagers access to batch edit ~12 tasks in a day or soo? [10:34:25] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-General, and 2 others: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 (10Jdforrester-WMF) It's done. See: >>! In T256087#6256185, @J... [10:45:06] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): Write a proposal to stop central management of mediawiki dependencies in CI - https://phabricator.wikimedia.org/T256781 (10Jdforrester-WMF) Eh. I felt that {T1857... [11:09:57] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): Write a proposal to stop central management of mediawiki dependencies in CI - https://phabricator.wikimedia.org/T256781 (10hashar) Kind of, they are proposed tech... [11:14:22] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-General, and 2 others: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 (10Aklapper) @Jdforrester-WMF: Thanks. Where on https://www.med... [11:17:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-General, and 2 others: Formally EOL REL1_33 - https://phabricator.wikimedia.org/T256087 (10Jdforrester-WMF) >>! In T256087#6270933, @Aklapper wrote: >... [11:38:58] 10Project-Admins: Create personal Phabricator project tags for jbolorinos-ctr - https://phabricator.wikimedia.org/T256434 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #user-jbolorinos-ctr has been created: https://phabricator.wikimedia.org/project/view/4860/ Interested people are w... [11:41:04] 10Project-Admins: Create component 'wmf-sre-laptop' - https://phabricator.wikimedia.org/T256803 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #wmf-sre-laptop has been created: https://phabricator.wikimedia.org/project/manage/4861/ Interested people are welcome to join the project as... [12:27:48] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10git-protocol-v2: Find the minimal git version to use for protocol v2 - https://phabricator.wikimedia.org/T256810 (10hashar) On a second inspection, we might want fetch-pack to support v2 which got released in 2.2... [13:06:22] (03PS1) 10Hashar: deploy-promote: fix review push with topic and label vote [tools/release] - 10https://gerrit.wikimedia.org/r/608873 (https://phabricator.wikimedia.org/T256653) [13:08:11] (03CR) 10Hashar: deploy-promote: fix review push with topic (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/608431 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar) [13:13:43] 10Gerrit, 10Documentation: Documentation for Gerrit on mediawikiwiki should be checked - https://phabricator.wikimedia.org/T256867 (10Aklapper) This was already mostly covered by {T227562}. However https://www.mediawiki.org/wiki/Gerrit/Navigation and https://www.mediawiki.org/wiki/Gerrit/watched_projects and... [13:14:06] 10Gerrit, 10Documentation: Update three Gerrit documentation pages on mediawiki.org after Gerrit 3.2 update - https://phabricator.wikimedia.org/T256867 (10Aklapper) [13:16:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Zuul, and 2 others: pywikibot get merge rejections due to zuul-merger not being able to update tags - https://phabricator.wikimedia.org/T252310 (10hashar... [14:01:36] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10hashar) 1.35.0-wmf.39 is on group 1 wikis: ` lang=irc 13:16 Synchronized php: group1 wikis to... [14:06:44] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10serviceops, 10User-brennen: Remove obsoleted docker images - https://phabricator.wikimedia.org/T242604 (10JMeybohm) Unfortunately removing all tags of an image (e.g. repository) does not remove the repository itself from the registry[1][2].... [14:41:48] 10Release-Engineering-Team, 10Operations, 10Release Pipeline, 10serviceops, 10User-brennen: Remove obsoleted docker images - https://phabricator.wikimedia.org/T242604 (10JMeybohm) [14:59:28] PROBLEM - Free space - all mounts on integration-agent-docker-1011 is CRITICAL: CRITICAL: integration.integration-agent-docker-1011.diskspace._srv.byte_percentfree (<22.22%) [15:02:39] 10Gerrit, 10DBA, 10Patch-For-Review: Make sure both `reviewdb-test` (used forgerrit upgrade testing) and `reviewdb` (formerly production) databases get torn down - https://phabricator.wikimedia.org/T255715 (10Dzahn) @jcrespo Chris has asked to keep it for a couple more days. [15:04:50] 10Gerrit, 10DBA, 10Patch-For-Review: Make sure both `reviewdb-test` (used forgerrit upgrade testing) and `reviewdb` (formerly production) databases get torn down - https://phabricator.wikimedia.org/T255715 (10jcrespo) Perfect, no problem. [15:09:29] RECOVERY - Free space - all mounts on integration-agent-docker-1011 is OK: OK: All targets OK [15:16:58] (03CR) 10Legoktm: Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [15:21:53] (03CR) 10Legoktm: "Added some suggestions, but I don't consider them blocking since the primary purpose is to import this from WikibaseCodeSniffer." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [15:25:28] (03Abandoned) 10Karl Wettin (WMSE): Required for importing from (renaming project from) wikispeech_mockup [services/wikispeech/wikispeech-server] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/608021 (owner: 10Karl Wettin (WMSE)) [15:41:10] hashar: I'm still not able to push --mirror from wikispeech_mockup to wikispeech-server. Now having problems with "missing" Change-Ids. This is more or less why we have the upstream branch in the old repo. And we can't create an upstream branch in the new project due to the repo being empty. [15:41:16] I'm lost in git! :D [15:41:25] Let me pastebin what's up now [15:42:42] https://pastebin.com/M8UDava4 [15:43:38] We really don't want to add Change-Ids and mess up compatibility with the github repo that's our upstream. [15:44:21] Any help would be really appreciated. Perhaps any of you guys could help? Maybe we should ask to delete the new repo and create it again, cloning from wikispeech_mockup? [15:46:19] https://gerrit.wikimedia.org/g/mediawiki/services/wikispeech/wikispeech-server/+/refs/heads/upstream [15:46:22] https://gerrit.wikimedia.org/g/mediawiki/services/wikispeech/wikispeech-server/+/refs/heads/master [15:46:27] The new repo isn't empty? [15:47:10] Hmm this is werd. Did it mange to mirror but gave me some warings in the console? [15:47:37] You might be the first people to test this since the gerrit upgrade [15:47:53] A direct push with force didn't require change-ids before [15:48:31] All attempts have resulted in a reject-message. Unless someone else managed to push it in and didn't tell anyone. [15:48:52] Need to investigate with the rest of the people here :) [15:48:59] This is good news though :D [15:49:09] Are those branches up to date? [15:49:33] it might be easier to remove your local checkout and then re-clone from gerrit if your local is in a bit of a weird state [15:50:21] change-id shouldn't be required for direct push (that'd be weird) [15:50:57] * thcipriani checks perms on repo [15:53:39] hrm, push with force is there, but not forge committer (which I think is needed...). Also I see pushing up refs/meta/config; which might result in some strange behavior [15:54:03] I think mirror pushes all of the things? [15:54:08] so if it's moving one gerrit repo to another... [15:55:05] thcipriani: Forge committer is inherited from https://gerrit.wikimedia.org/r/admin/repos/mediawiki/services/wikispeech,access [15:55:08] ah [15:56:42] Is it possible to find some timestamp when the data was pushed to the repo? [15:56:59] hrm, a lot of these errors are related to notedb updates; i.e., refs/changes/xx/yyyxx/meta -- have we ever done that before? I would think it would cause some strangeness in the UI [15:58:12] maybe --all and --tags rather than --mirror would be better [15:59:04] Aye [16:04:48] PROBLEM - Free space - all mounts on integration-agent-docker-1003 is CRITICAL: CRITICAL: integration.integration-agent-docker-1003.diskspace._srv.byte_percentfree (<11.11%) [16:05:21] maintenance-disconnect-full-disks build 191058 integration-agent-docker-1003 (/srv: 95%): OFFLINE due to disk space [16:09:05] 10Gerrit, 10TechCom-RFC, 10Wikimedia-GitHub: RFC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547 (10Krinkle) [16:10:09] (03PS3) 10Thiemo Kreuz (WMDE): Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603496 (https://phabricator.wikimedia.org/T164653) [16:15:29] maintenance-disconnect-full-disks build 191060 integration-agent-docker-1003: OFFLINE due to disk space [16:15:39] (03CR) 10jerkins-bot: [V: 04-1] Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603496 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [16:16:21] omg [16:16:27] doc.wikimedia.org is super different now [16:19:45] RECOVERY - Free space - all mounts on integration-agent-docker-1003 is OK: OK: All targets OK [16:23:09] (03PS1) 10Legoktm: doc: Add Services PHP library [integration/docroot] - 10https://gerrit.wikimedia.org/r/608910 (https://phabricator.wikimedia.org/T211608) [16:37:36] legoktm: when did that happen? [16:38:52] legoktm: K.rinkle did it. Nice, right? [16:39:19] * RhinosF1 likes it [16:39:36] !log Manually re-set zuul's checkout of labs/libraryupgrader's git repo on contint2001 so we can merge things again [16:39:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:40:10] legoktm: Finally. Sorry it was so borked. Probably a glitch from the switch-over. [16:40:18] maintenance-disconnect-full-disks build 191065 integration-agent-docker-1003: OFFLINE due to disk space [16:58:24] James_F: I love it. And thanks [16:58:33] now I can review your change! [17:05:18] maintenance-disconnect-full-disks build 191070 integration-agent-docker-1003: OFFLINE due to disk space [17:09:54] legoktm: And Sam's! ;-) [17:23:03] hm.. wikibugs has left the building? [17:26:45] yea, netsplit [17:26:58] not just the bot, some human users too [17:30:17] maintenance-disconnect-full-disks build 191075 integration-agent-docker-1003: OFFLINE due to disk space [17:32:26] 10Gerrit: Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3 - https://phabricator.wikimedia.org/T256633 (10Umherirrender) Thanks too for looking that deep into it. [17:51:28] (03PS1) 10Jforrester: Zuul: Add CI for mediawiki/extensions/WikiLambda [integration/config] - 10https://gerrit.wikimedia.org/r/608917 [17:55:22] maintenance-disconnect-full-disks build 191080 integration-agent-docker-1003: OFFLINE due to disk space [17:55:39] (03CR) 10Jforrester: [C: 03+2] Zuul: Add CI for mediawiki/extensions/WikiLambda [integration/config] - 10https://gerrit.wikimedia.org/r/608917 (owner: 10Jforrester) [17:56:43] (03Merged) 10jenkins-bot: Zuul: Add CI for mediawiki/extensions/WikiLambda [integration/config] - 10https://gerrit.wikimedia.org/r/608917 (owner: 10Jforrester) [17:57:40] !log Zuul: Add CI for mediawiki/extensions/WikiLambda [17:57:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:18:14] I am having trouble pushing a patch the design blog - https://phabricator.wikimedia.org/P11721. Any clue what I might be doing wrong? [18:18:56] prtksxna: most likely you have an outdated version of git-review [18:20:18] maintenance-disconnect-full-disks build 191085 integration-agent-docker-1003: OFFLINE due to disk space [18:20:48] Hmm… it used to work till 2 weeks ago. Do I update it using brew? (I'm on MacOS0 [18:20:54] prtksxna: the new version of gerrit that we switched to over the past weekend needs git-review 1.28 [18:21:20] I think brew should be able to update it, yes if that is how you got the version you are using [18:22:57] bd808: while you're here, see https://phabricator.wikimedia.org/D1184 [18:23:13] mentioning it as I'm not sure if you get notifications for Differential things [18:23:30] Thanks Majavah bd808. I'll try to update :) [18:23:50] Majavah: I got the email, but the follow up ping is also appreciated [18:28:18] (03CR) 10Thiemo Kreuz (WMDE): Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [18:28:25] That worked. Thanks again :) [18:45:16] maintenance-disconnect-full-disks build 191090 integration-agent-docker-1003: OFFLINE due to disk space [18:54:31] mdholloway: Could you look into/escalate this one in your team? https://phabricator.wikimedia.org/T239878 Looks like it has fallen of the radar :) [18:55:33] Krinkle: sure, thanks for the heads-up. That one definitely is off the radar currently. [18:56:04] 10phan-taint-check-plugin: Implement ReDoS detection - https://phabricator.wikimedia.org/T256661 (10sbassett) >>! In T256661#6270514, @Daimona wrote: > Yeah, I also remember some releated discussions at T187669 and T240884. In addition to some of the external research mentioned on these tasks, I feel like @Bawo... [18:59:53] (03CR) 10Krinkle: [C: 03+2] doc: Add Services PHP library [integration/docroot] - 10https://gerrit.wikimedia.org/r/608910 (https://phabricator.wikimedia.org/T211608) (owner: 10Legoktm) [19:00:02] (03PS2) 10Krinkle: doc: fix missing tag [integration/docroot] - 10https://gerrit.wikimedia.org/r/608914 [19:00:04] (03CR) 10Krinkle: [C: 03+2] doc: fix missing tag [integration/docroot] - 10https://gerrit.wikimedia.org/r/608914 (owner: 10Krinkle) [19:00:46] (03Merged) 10jenkins-bot: doc: Add Services PHP library [integration/docroot] - 10https://gerrit.wikimedia.org/r/608910 (https://phabricator.wikimedia.org/T211608) (owner: 10Legoktm) [19:01:19] (03Merged) 10jenkins-bot: doc: fix missing tag [integration/docroot] - 10https://gerrit.wikimedia.org/r/608914 (owner: 10Krinkle) [19:03:58] is it possible to turn off hotkeys in the new gerrit? Poked around the config but not finding anything, it's a bit tedious when my palm grazes the touchpad and then gerrit changes pages multiple times [19:06:59] (03CR) 1020after4: [C: 03+2] deploy-promote: fix review push with topic and label vote [tools/release] - 10https://gerrit.wikimedia.org/r/608873 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar) [19:07:44] (03Merged) 10jenkins-bot: deploy-promote: fix review push with topic and label vote [tools/release] - 10https://gerrit.wikimedia.org/r/608873 (https://phabricator.wikimedia.org/T256653) (owner: 10Hashar) [19:08:36] ebernhardson hi, nope you cannot turn off hotkeys. [19:08:49] :( ok well at least it's confirmed [19:08:55] paladox: thanks! [19:09:03] ebernhardson: "screw it, I'm moving to gitlab" [19:09:15] Reedy: i wont even start on that:P [19:09:25] You might be able to do it with a greasemonkey type script though [19:09:37] yea i started poking at globals in console to see what i can find [19:09:55] bd808 might have some ideas after digging around a lot since the upgrade [19:10:19] maintenance-disconnect-full-disks build 191095 integration-agent-docker-1003: OFFLINE due to disk space [19:12:15] !bash < Reedy > ebernhardson: "screw it, I'm moving to gitlab" [19:12:15] Amir1: Stored quip at https://bash.toolforge.org/quip/LwHLC3MBLkHzneNNO6pd [19:13:47] 10Gerrit, 10fundraising-tech-ops: move main fundraising puppet repo to gerrit - https://phabricator.wikimedia.org/T222840 (10Jgreen) a:05Jgreen→03None [19:13:58] bah integration-agent-docker-1003 has plenty of space [19:14:34] (03PS1) 1020after4: Automatically mention train blocker task in deploy-promote [tools/release] - 10https://gerrit.wikimedia.org/r/608936 [19:14:36] !log Pooling back integration-agent-docker-1003 , got disconnected by maintenance-disconnect-full-disks # 191095 [19:14:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:14:42] (/srv: 95%) [19:14:43] but it is not [19:17:31] it may be that a container running a test was using space that was reclaimed once the test is done. That job records the disk size in the "offline reason" and then keeps yelling here. [19:17:36] could be smarter :\ [19:21:16] (03PS1) 10Legoktm: shared: Consistently use "Test coverage" [integration/docroot] - 10https://gerrit.wikimedia.org/r/608942 [19:25:02] solution: run `window.addEventListener('keydown', function (e) { e.stopPropagation(); }, true)` on all gerrit pages [19:25:53] (may have unknown knock-on effects) [19:29:38] ebernhardson: maybe we can have hotkeys disabled via a preference. I guess upstream might be willing to implement such a feature [19:30:01] they have some google UX folks working on the gerrit ui and looking at improviing it. Maybe that will interest them [19:30:58] hashar: i found requests going back to 2010, with the most recent comment in 2016. I think upstream isn't interested :) [19:32:23] * bd808 looks at backscroll, sees that ebernhardson found a hack [19:33:15] the fun thing about the new UI is its use of web components which are neat from the technical implementation POV and horrible for user customization. [19:33:53] If I was a better FOSS contributor I would start working on support for shadow DOM manipulation upstream in GreaseMonkey [19:36:11] ebernhardson the UI team accept alot of customisation :) [19:36:35] i guess window.addEventListener('keydown', function (e) { e.stopPropagation(); }, true) would have to be done in gr-app [19:38:50] i put it in a tampermonkey script with a 2s delay after the page is interactive, seems to work [19:39:19] the more appropriate way is probably switching out the set of possible hotkeys, with disabled being "no hotkeys defined". Maybe [19:42:51] ebernhardson https://gerrit-review.googlesource.com/c/gerrit/+/274032 [19:45:49] paladox: thanks! I'm of course not familiar with this code, but it's quite possible aborting all keydown events does more than disabling hotkeys. There is also a potential order-of-operations, browsers run event listeners in the order registered afaik, so that has to be the final thing listening to keydown [19:47:55] https://github.com/GerritCodeReview/gerrit/blob/9a8951ddc778863e1585d9295f3d04c7ace173ea/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js [19:49:01] i think we should disable it here https://github.com/GerritCodeReview/gerrit/blob/9a8951ddc778863e1585d9295f3d04c7ace173ea/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js#L629 [19:50:47] paladox: a little earlier i see a function called shouldSuppressKeyboardShortcut(e), sounds promising [19:51:34] oh [19:51:37] * paladox tries [20:00:01] ebernhardson updated change https://gerrit-review.googlesource.com/c/gerrit/+/274032 [20:02:20] (03CR) 10Majavah: "If you want I can throw an API for train-blockers.toolforge.org so this can be used without a conduit api key" [tools/release] - 10https://gerrit.wikimedia.org/r/608936 (owner: 1020after4) [20:04:44] paladox: looks promising, thanks! I suspect renaming _onTapDarkToggle to _onTapToggle in gr-settings-view.js is unintended [20:05:58] (03PS4) 10Jeena Huneidi: Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) [20:06:21] well yes kind of, i needed to rename it just so i didn't have to use _onTapDarkToggle for disable-hotkeys. [20:06:28] by that i mean the name wouldn't match [20:06:34] ahh [20:09:50] (03CR) 10Hashar: [C: 03+2] Add Cassandra image (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) (owner: 10Jeena Huneidi) [20:11:52] (03Merged) 10jenkins-bot: Add Cassandra image [integration/config] - 10https://gerrit.wikimedia.org/r/608500 (https://phabricator.wikimedia.org/T256281) (owner: 10Jeena Huneidi) [20:14:20] ebernhardson: paladox: you both rock ! :] [20:16:11] works :D [20:16:14] ebernhardson hashar ^ [20:17:54] !log Updating docker-pkg files on contint primary for https://gerrit.wikimedia.org/r/c/integration/config/+/608500 [20:17:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:24:56] Hey folks! I'm stoked about the work you guys are doing re. GitLab. I think it's a good call and I look forward to working with y'all on it (mostly asking for help I'm sure) :) [20:25:18] Evaluating changes like this is important. [20:27:56] I believe gitlab was diclined [20:27:59] *declined [20:28:32] paladox: Welcome to 2020 [20:28:45] heh [20:28:49] https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/GitLab [20:29:13] ohh ci [20:29:46] Not just CI [20:31:28] oh [20:43:59] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [20:44:00] Yeah. Still under discussion. I'm just very excited about it. [20:45:10] 10Continuous-Integration-Config, 10Jenkins: mediawiki-fresnel-patch-docker should set jenkins as reviewer - https://phabricator.wikimedia.org/T256919 (10Umherirrender) [20:54:01] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [20:55:41] 10Phabricator, 10Editing-Team-Request, 10Editing-team (Tracking): Custom task form for #Editing-team-request - https://phabricator.wikimedia.org/T256123 (10JTannerWMF) Hey there hope you are well @mmodell and @Aklapper. Just wanted to ask if its possible to get an ETA on this? [21:00:07] halfak: Is that really "Still under discussion"? I read the GitLab page as a done deal. After all it has OKRs for FY20-21 attached with "Continuous Integrationg and Review systems" ;-) [21:01:21] Aha. may be a done deal. I'm not 100% on that. [21:01:40] Neither am I. Just judging from https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/GitLab [21:04:26] Surely you don't want Fedora and the others to be the only one enjoying some forge migration drama! [21:11:23] halfak: do you know where that discussion is happening [21:11:46] https://www.mediawiki.org/wiki/Talk:Wikimedia_Release_Engineering_Team/GitLab I assume? [21:12:12] I see some posts there about features and pricing. [21:13:08] halfak: thanks, i wanted to comment basically what i see lego wrote a couple hours ago [21:13:28] * qchris scrolls back. [21:13:38] (on that wiki page) [21:15:01] Ah. Ok :-) [21:17:43] 10Gerrit, 10TechCom-RFC, 10Wikimedia-GitHub: RFC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547 (10Nemo_bis) Because it was not mentioned clearly in the task linked above: there is some ongoing useful work at FSF, for instance https://libreplanet.org/wiki/Fsf_2019_forge_eval... [21:21:07] so... can the RFC from 2017 be reopened ? [21:22:15] mutante: no dont touch anything yet ;) [21:23:18] that 2017 task is from an entirely different context. It is no more relevant to today project [21:23:23] in short :] [21:23:53] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Scap: Remove unused `scap swat` command - https://phabricator.wikimedia.org/T254787 (10dancy) a:03dancy [21:24:57] hashar: so which is the relevant ticket today then? [21:25:23] a ticket for what? [21:25:49] the project page got created 2 days ago [21:26:21] it is going to take months and a significant workforce. It is too early for tasks in Phabricator. But that will come for sure ;] [21:28:07] So we finally upgrade gerrit to migrate to yet another service? [21:29:59] that is unrelated [21:30:07] I mean [21:30:11] let me rephrase that [21:30:26] Gerrit has releases every so often and eventually will entirely stop supporting some version [21:30:47] we've been on an unsupported version for a while :P [21:30:54] ^ [21:30:55] the Gerrit version we had was reaching end of life (or already did) so we really needed a more recent version [21:31:07] !log delete performance-beta.wmflabs.org web proxy (handled by performance.wikimedia.beta.wmflabs.org instead via puppetised handling) [21:31:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:31:23] (03PS1) 10Ahmon Dancy: Remove unused `scap swat` command [tools/scap] - 10https://gerrit.wikimedia.org/r/608963 (https://phabricator.wikimedia.org/T254787) [21:31:29] well i mean it EOD last november [21:31:31] cause that fixes issues that affected us and let us speak with upstream on the same code base [21:31:33] *EOL [21:32:00] that also bring in new features such as git protocol v2 and a workable UI. So it is a good thing we did it :] [21:32:22] yet another service is well... another service. Doesn't mean we should stop supporting the current one [21:32:35] even if we eventually end up replacing it [21:34:08] in short as usual: keep cool, write code! :-] [21:34:10] well i mean that users have to learn a new UI only to be forced to learn another UI in a years time? [21:34:11] i don't understand "too early for tasks". where else do we follow projects? [21:34:55] ^ [21:36:29] to conclude [21:36:45] the project hasn't started so there are no tasks to write for it [21:37:23] but that will start eventually. So just wait a bit I guess [21:37:50] anyway it is late for me. But in short don't worry and just wait a bit more [21:38:30] thanks hashar - personally I'd stick with gerrit; but it's not my call [21:38:38] and probably won't affect me either [21:38:52] bonne nuite [21:38:55] soyez bien [21:41:58] * paladox personally likes gerrit and found gitlab hard to use [21:43:49] hauskatze: merci :] [21:48:09] !log Un-cherry-picking change 603550 (now merged), cherry-picking 608962 in beta. [21:48:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:52:34] Hey I'm just wondering if this is a permission issue that's hopefully a quick fix? https://phabricator.wikimedia.org/P11722 [21:53:05] it's an error one of the GSoC students is experiencing when trying to submit a patch on gerrit [21:54:41] they need to update git-review eljohnny [21:59:39] sweet, thanks so much for the help! [22:02:37] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Release Pipeline: Create WMF Cassandra image - https://phabricator.wikimedia.org/T256281 (10jeena) 05Open→03Resolved [22:02:40] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Core Platform Team, 10Operations, and 5 others: Kask functional testing with Cassandra via the Deployment Pipeline - https://phabricator.wikimedia.org/T224041 (10jeena) [22:03:08] The gerrit-review update bites many :-( [22:03:17] It was in the original announcement email. [22:03:25] But I guess that was just not visible enough. [22:03:30] *sigh* [22:04:01] s/gerrit-review/git-review/ [22:04:16] qchris: making that sort of thing visible to everyone it will affect around here is just difficult. [22:04:24] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10Krinkle) [22:04:30] there are lots of e-mails and only so much attention to go around. [22:04:38] Sure :-) [22:07:47] qchris: so we need to update git-review then? [22:07:54] Haven't submitted a patch in a while [22:08:00] Taking a little vacation :-) [22:08:03] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10Krinkle) [22:10:58] hauskatze: :-) Haha. Yup. [22:11:30] qchris: found the email. I unsub from wikitech-l, but browsing the archives works as well :) [22:11:50] qchris: can we tweak the Gerrit error message to poke people to update git-review? [22:12:25] legoktm: That's a good idea actually. Not sure how easy that would be. I'll have a look at the code. [22:12:29] we could use the banner endpoint [22:12:37] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Core Platform Team, 10Operations, and 5 others: Kask functional testing with Cassandra via the Deployment Pipeline - https://phabricator.wikimedia.org/T224041 (10jeena) We've published a cassandra image to docker-registry.wikimedia.o... [22:12:38] to give users a notification - cc qchris [22:12:53] You mean on the UI? [22:13:05] yup [22:13:27] I think people should see the reminder when the command fails. [22:14:07] :) without knowing Gerrit's codebase, I'm hoping it's just a message string somewhere that is straightforward to patch/hack [22:14:45] Patches welcome :-D [22:14:50] "You need 'Create' rights to create new references. You may be running into this error if you haven't upgraded to git-review XX" [22:15:08] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Core Platform Team, 10Operations, and 5 others: Kask functional testing with Cassandra via the Deployment Pipeline - https://phabricator.wikimedia.org/T224041 (10jeena) [22:16:00] you're asking for a patch to patch management software so people can submit patches? [22:16:42] oof [22:16:59] Yes. And eventually, we want to apply that patch to WMF (current) patch management software so the patch writers get better clues about why the patch management software refuses their patches. [22:17:24] so that they can submit their patches to the patch management software in the future [22:17:44] To patch the patched system? [22:18:01] * qchris tries to find an eye patch, just to take it to the next level. Arrrr! [22:18:18] qchris: https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/server/permissions/RefControl.java#501 [22:18:19] qchris: maybe in the krankenhaus [22:19:21] legoktm: Yup. Hook that up with a check on refName. And you've got something to upload to upstream \o/ [22:19:41] And tests. They like them a lot. [22:19:43] - pde.setAdvice("You need 'Create' rights to create new references."); [22:19:43] + pde.setAdvice("You need 'Create' rights to create new references. You may be running into this error if you haven't upgraded to git-review 1.27."); [22:19:47] So add these. [22:19:51] there's my patch :) [22:20:12] But that would fire on each ref creation failure. [22:20:21] Regardless of whether it's git-review or not. [22:20:53] To get to my home town you have drive across Patchen Pass and past the ghost town of Patchen, CA. I added the issue above to an FAQ section on the Gerrit wikitech page and later the mediawiki.org page [22:21:16] :-) [22:21:46] I'll try to find a patch where I can sleep for a few hours :-) [22:21:50] Good night everyone. [22:21:56] qchris: java isn't my forte. can I just do if(refName) { ... } else { original message } ? [22:22:00] oh, good night! [22:22:22] legoktm: I'll try to take your patch upstream. [22:22:39] you're awesome qchris :) [22:23:00] Naw. Just tired :-D [22:23:44] * RhinosF1 thinks anyone who can understand gerrit as well as qchris and paladox is awesome [22:24:15] It took me 3 attempts to find where create change now was! [22:27:52] qchris legoktm there is a plugin that allows both a UI and a command line mssage. [22:27:55] https://gerrit-review.googlesource.com/admin/repos/plugins/motd [22:28:20] oh that's command only [23:21:15] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.35.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T254176 (10Krinkle) [23:32:46] DannyS712: https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?orgId=1&var-wiki=enwiki&var-component=MassMessage&var-component=WebAuthn&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki [23:32:52] two more modules gone [23:45:56] Which patch was that one? The styles one hasn't merged yet [23:47:10] it was merged 47 seconds before your reply [23:47:39] hmm, I stand corrected, though it shouldn't have reached production yet [23:48:45] For https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?panelId=61&fullscreen&orgId=1&var-wiki=enwiki&var-component=MassMessage&var-component=WebAuthn&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki - Krinkle can you review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/607921 ? The patch [23:48:45] reduces the ContentTranslation's modules by merging 7 of them [23:50:23] DannyS712: you made another MassMessage patch last week for autocomplete.js stuff [23:50:26] that one went out this week [23:50:36] oh yeah [23:50:57] DannyS712: I can't, it's too complicated to review statically. I need LangEng to review that. [23:51:12] Santhosh is on it I see but will likely deprioritise for now until CX1 is removed entirely [23:51:19] which I believe is meant to happen in July? [23:51:24] I don't remember when those drafts expire [23:51:27] maybe Reedy knows :) [23:51:37] he tends to like removing old crap :D [23:51:43] * Krinkle does as well [23:51:53] It's July [23:53:00] * DannyS712 Does as well - looking forward to removing Revision once 1.35 is cut [23:54:48] Also, Krinkle we discussed using package files for MassMessage as a follow-up to the autocomplete work - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/608474 is my attempt at switching to pack files [23:57:46] DannyS712: I'll try to squeeze that in, but it's lower priority at the moment given it's in maintenance-only mode.