[00:39:07] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: mediawiki-1.34.2.tar.gz and mediawiki-core-1.34.2.tar.gz have different root files - https://phabricator.wikimedia.org/T257088 (10Reedy) [01:54:13] (03PS1) 10Reedy: Append to .gitattributes [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) [01:57:59] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools, 10Patch-For-Review: mediawiki-1.34.2.tar.gz and mediawiki-core-1.34.2.tar.gz have different root files - https://phabricator.wikimedia.org/T257088 (10Reedy) `open('filename', 'w')` overwrites the file ` $ cat write.py #!/usr/bin/env python3 with open('.... [02:01:00] (03PS2) 10Reedy: Append to .gitattributes rather than replacing it [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) [03:31:24] (03CR) 10DannyS712: [C: 03+1] "LGTM" [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) (owner: 10Reedy) [05:22:31] 10Release-Engineering-Team, 10Security-Team: php-composer-security-docker failing due to git fetch of non-existent REL1_35 ref - https://phabricator.wikimedia.org/T257080 (10DannyS712) [05:39:03] Crossposting from #wikimedia-operations - might need an emergency deployment for https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/609304 (T257076) - per https://wikitech.wikimedia.org/wiki/Deployments/Emergencies needs positive confirmation from RelEng that it can be carried out [05:39:04] T257076: Unable access to frwiki page "Spore : Aventures_galactiques" - https://phabricator.wikimedia.org/T257076 [05:50:56] (03PS1) 10JJMC89: Edit Repo Config [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/609305 [06:51:25] (03CR) 10Legoktm: "What are you trying to adjust?" [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/609305 (owner: 10JJMC89) [06:52:55] (03PS3) 10Legoktm: make-release: Append to .gitattributes rather than replacing it [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) (owner: 10Reedy) [06:53:06] (03CR) 10Legoktm: [C: 03+2] make-release: Append to .gitattributes rather than replacing it [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) (owner: 10Reedy) [06:53:49] (03Merged) 10jenkins-bot: make-release: Append to .gitattributes rather than replacing it [tools/release] - 10https://gerrit.wikimedia.org/r/609504 (https://phabricator.wikimedia.org/T257088) (owner: 10Reedy) [08:05:57] 10Project-Admins, 10Analytics-Clusters: Rename Analytics-Cluster to Analytics-Clusters (plural) and make it a subproject of Analytics - https://phabricator.wikimedia.org/T257059 (10Aklapper) 05Open→03Resolved I'm sorry for the repeated comments above; the Phab DB connection was quite flaky yesterday. Alrig... [08:11:31] 10Project-Admins, 10Analytics-Clusters: Rename Analytics-Cluster to Analytics-Clusters (plural) and make it a subproject of Analytics - https://phabricator.wikimedia.org/T257059 (10elukey) thanks a lot @Aklapper! [08:52:17] 10phan-taint-check-plugin, 10Patch-For-Review: ERROR: Error: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T251346 (10Nikerabbit) I am also seeing this locally. Is there going to be a new release of `mediawiki/mediawiki-phan-config` that fixes this? [08:56:19] !log Fixed Jenkins collapsible section parsing for Quibble. A logger changed from quibble.cmd to quibble.commands. # T220586 [08:56:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:56:22] T220586: Quibble to output markers for processing its output - https://phabricator.wikimedia.org/T220586 [08:57:43] @hashar are you available for an emergency deployment? [08:57:56] hmm what is up? [08:58:05] T257076 [08:58:06] T257076: Unable access to frwiki page "Spore : Aventures_galactiques" - https://phabricator.wikimedia.org/T257076 [08:58:21] let me finish a task and I will look at it ;] [08:58:37] Need to sync a hotfix for the interwiki map until the next normal update comes around - I already removed it from the map on meta [09:00:50] oh no [09:00:54] not the interwikis :\ [09:01:34] Should we be coordinating here or in operations? Approval from RelEng and SRE is needed for emergency deployments per https://wikitech.wikimedia.org/wiki/Deployments/Emergencies [09:02:13] 10phan-taint-check-plugin, 10Patch-For-Review: ERROR: Error: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T251346 (10Daimona) >>! In T251346#6278627, @Nikerabbit wrote: > I am also seeing this locally. Is there going to be a new release of `mediawiki/mediawiki-phan-config` that fixes t... [09:03:39] 10MediaWiki-Releasing: Mediawiki 1.34.2 tarball incompatibe with 7zip on windows due to Pax format - https://phabricator.wikimedia.org/T257102 (10Bawolff) [09:03:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10phan, 10Jenkins: Create a jenkins section for phan - https://phabricator.wikimedia.org/T240748 (10hashar) Phan is... [09:03:55] DannyS712: ok looking [09:04:29] DannyS712: lets move to -operations [09:04:36] and I guess if it is too bad I will make calls [09:04:37] ;) [09:19:58] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10phan, 10Jenkins: Create a jenkins section for phan - https://phabricator.wikimedia.org/T240748 (10Daimona) >>! In... [09:35:42] (03Abandoned) 10Umherirrender: Fix use of const and function imports in unsorted statement sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/596819 (owner: 10Umherirrender) [11:18:35] 10MediaWiki-Releasing: Mediawiki 1.34.2 tarball incompatibe with 7zip on windows due to Pax format - https://phabricator.wikimedia.org/T257102 (10Mainframe98) Can confirm. When unpacking the tar, I get prompted if I want to overwrite the `@PaxHeader` file, apparently for every file in the tarball. [11:23:26] (03PS4) 10Umherirrender: Full rewrite of the UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/607862 (owner: 10Thiemo Kreuz (WMDE)) [11:23:31] (03CR) 10Umherirrender: [C: 03+2] Full rewrite of the UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/607862 (owner: 10Thiemo Kreuz (WMDE)) [11:23:55] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: mediawiki-1.34.2.tar.gz and mediawiki-core-1.34.2.tar.gz have different root files - https://phabricator.wikimedia.org/T257088 (10Reedy) 05Open→03Resolved a:03Reedy [11:24:31] (03Merged) 10jenkins-bot: Full rewrite of the UnsortedUseStatementsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/607862 (owner: 10Thiemo Kreuz (WMDE)) [11:24:45] (03Abandoned) 10Umherirrender: More resource friendly UnsortedUseStatements implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/597000 (owner: 10Thiemo Kreuz (WMDE)) [11:26:10] 10Gerrit: Can't remove reviewers with long names - https://phabricator.wikimedia.org/T257105 (10Reedy) [11:32:09] 10MediaWiki-Releasing: Mediawiki 1.34.2 tarball incompatibe with 7zip on windows due to Pax format - https://phabricator.wikimedia.org/T257102 (10Reedy) Most obvious answer I can see is due to an upgrade to Ubuntu 20.04, and the subsequent upgrade of python... or other libraries? I know I did it with python3, w... [11:44:43] 10MediaWiki-Releasing: Mediawiki 1.34.2 tarball incompatibe with 7zip on windows due to Pax format - https://phabricator.wikimedia.org/T257102 (10Reedy) Though, a bit of googling does make it look like more of a 7-zip (or possibly 7-zip and windows?) issue - https://sourceforge.net/p/sevenzip/bugs/2116/ and http... [11:45:10] 10MediaWiki-Releasing: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format - https://phabricator.wikimedia.org/T257102 (10Reedy) [11:51:22] 10commit-message-validator: commit-message-validator prints a weird error message - https://phabricator.wikimedia.org/T257107 (10Xqt) [11:58:15] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to phan/phan 3.0.5 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Umherirrender) [12:35:19] hashar: You by chance still online? [12:35:33] If so, would something like https://i.imgur.com/mkK48cD.png work? [12:35:52] Fancy [12:36:28] So I take that as "I'd rather have that than what we currently have?" [12:36:39] yes [12:36:47] Thanks. [12:36:47] Oh that looks nice! [12:36:59] Then I'll try to get that to our Gerrit. [12:37:43] Does it look nice on mobile too? [12:37:43] Mhmm. Weekend ... but everyone's stalking the releng channel :-D [12:38:00] paladox: No clue. [12:38:07] I've already been working 4 or 5 hours today [12:38:11] I'll try. [12:38:18] And I only got up less than an hour ago [12:38:19] Reedy: Pffffff :-P [12:38:23] Hahahaha. [12:38:44] (I was still up doing stuff at 5am) [12:38:48] hey reedy - any chance you want to do an emergency deployment for the interwiki cache? T257076 [12:38:49] T257076: Unable access to frwiki page "Spore : Aventures_galactiques" - https://phabricator.wikimedia.org/T257076 [12:39:09] 5am ... Argh! [12:39:23] Yeah... For something I started working on... 13 hours before [12:39:23] I was up at 5am [12:39:36] *too [12:39:43] DannyS712: It's probably better to just run the script and fix any other updates [12:39:44] * Reedy looks [12:39:45] 5am is so early, my brain doesn't parse it as time, but as Sam. [12:40:33] its borderline on whether an emergency deployment is needed [12:41:10] ...but I guess you can do a full update instead :) [12:41:17] I deployed at 02:30 this morning my time [12:42:05] I assume that was about the Score issue? (I'm guessing that's an RCE or something similar based on public commits and tasks) [12:42:14] RCE? [12:42:22] remote code execution [12:42:28] There's... numerous issues. let's put it that way [12:42:39] ... that sounds fun [12:43:41] 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Patch-For-Review: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) I hacked a bit on the above pg-test-result-plugin and got something like {F3191... [12:48:05] paladox: you always seem to be awake funny hours. [12:48:35] Reedy: I'm watching that task carefully [13:34:38] Reedy https://phabricator.wikimedia.org/T257105 this is interesting heh [13:38:05] * Majavah creates multiple accounts with long usernames and requests their review everywhere [13:40:33] Reedy does it work now? [13:45:25] Does what work now? [13:45:41] It still displays exactly the same [13:49:12] Ah ok [13:54:10] Reedy workaround: You can remove hidden from the gr-button element (with id remove) [14:03:20] The issue isn't due to large names, unless the issue is fixed on master since i cannot reproduce. [14:22:53] 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team-TODO, 10Developer Productivity, 10Patch-For-Review: Jenkins comments no longer formatted on Gerrit 3 - https://phabricator.wikimedia.org/T256575 (10QChris) I've put this change live on gerrit-test.wikimedia.org to allow reviewing: * [... [14:24:22] @reedy still around? [14:26:20] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10DannyS712) [14:26:48] Aye [14:39:57] qchris i think you need some padding/margin at the top [14:40:11] and also this is what it looks like on mobile: [14:40:39] I checked on mobile, and it looked ok for me. [14:42:57] qchris https://imgur.com/a/nGejYU0 [14:43:24] That's ok, ain't it? [14:44:00] And if someone wants to re-style ... Patches more than welcome! :-) [14:44:18] I critical part was to get it working and roughly usable. [14:44:24] s/I/The/ [14:59:06] So it appears under mobile it cannot find the date [14:59:52] and also it appears changing the patchset doesn't trigger a refresh of it. [15:00:00] (both desktop and mobile) [15:06:27] i think that's because of "var current_patchset = this.getPatchSetNum(his.change.current_revision);" [15:09:16] I thought that's intentional. [15:09:32] It only shows results for the latest patch set. [15:10:10] Let's do code-review in Gerrit. Then we can later on re-collect our steps :-) [15:10:30] https://gerrit.wikimedia.org/r/q/topic:%22gerrit-ci-table%22+(status:open%20OR%20status:merged) [15:17:15] qchris we could use the revision attribute i guess. [15:17:15] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) [15:17:23] which should provide the selected revision [15:17:50] though then i think we may want an observer on it? [15:19:10] qchris does this https://gerrit.wikimedia.org/r/c/operations/puppet/+/609520 work for you? [15:22:00] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [15:30:45] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) List of instances: |Instance Name|VCPUs|RAM (MB)|Disk (GB)|Usage (Hours)|Age (Seconds)|State |deployment-acme-chief03|1|2048|20|39.46|40926995|Active |deployment-acme-chief04|1|2048|20|39.4... [16:56:31] PROBLEM - Host deployment-cpjobqueue is DOWN: CRITICAL - Host Unreachable (172.16.4.124) [16:56:31] PROBLEM - Host deployment-changeprop is DOWN: CRITICAL - Host Unreachable (172.16.5.21) [17:02:58] Heh [17:02:58] Err that was to “ paladox: you always seem to be awake funny hours.” [17:11:17] paladox: :) [17:12:08] (03Abandoned) 10JJMC89: Edit Repo Config [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/609305 (owner: 10JJMC89) [17:13:16] paladox: I've woke up before you're asleep before and we live in the same country [17:15:30] Heh [17:53:29] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) We have two appservers but five memcached nodes, that seems off. [18:30:54] paladox: Yes, works for me. Here's a screenshot https://imgur.com/a/dKfKmPD [18:30:57] What do you get? [18:39:20] I was only making sure :) [18:39:20] i hadn't tried it. [18:43:19] :-D [18:43:46] The changes come with links you can click on. You can easily try if you want to. [18:44:23] (I hope that once (if?) they are merged, someone with an eye for design comes around and makes them pretty :-) ) [19:17:33] (03PS1) 10QChris: Bump gitiles plugin to v3.2.2-1-g00c5ca0-with-0e3b533 [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/609547 (https://phabricator.wikimedia.org/T256571) [19:21:55] bazel caused the load on my mac to go >300 :( [19:21:59] (03CR) 10QChris: [V: 03+2 C: 03+2] Bump gitiles plugin to v3.2.2-1-g00c5ca0-with-0e3b533 [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/609547 (https://phabricator.wikimedia.org/T256571) (owner: 10QChris) [23:51:27] !log deleted deployment-sentry01 (T106915) [23:51:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:51:30] T106915: Use Sentry in production - https://phabricator.wikimedia.org/T106915 [23:53:26] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) Deleted deployment-sentry01 according to T106915#6279270 [23:54:19] PROBLEM - Host deployment-sentry01 is DOWN: CRITICAL - Host Unreachable (172.16.5.16)