[03:29:23] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10Dsharpe) [07:02:22] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10Legoktm) [07:07:20] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10DannyS712) [07:08:29] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10DannyS712) What defines a "structure test"? Also, is GPL v3 or later compatible with 2 or later, or is it the other way around? [07:37:30] 10phan-taint-check-plugin, 10Patch-For-Review: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) >>! In T253875#6265949, @Daimona wrote: > Given the recent improvements of conditional branches and a few other things still under review, I'd like to retry this one.... [07:53:54] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10Legoktm) The checklist has been ad-hoc for a while now, so I took this opportunity to explicitly document it: https://www.mediawiki.... [07:55:24] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.35-release: Expand the set of bundled extensions and skins in MediaWiki 1.35 - https://phabricator.wikimedia.org/T232854 (10Legoktm) [07:55:56] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Legoktm) [08:28:33] 10phan-taint-check-plugin, 10User-Daimona: make phan-taint-check handle array_map - https://phabricator.wikimedia.org/T204911 (10Daimona) So, phan does this with an ad-hoc internal plugin (ArrayReturnTypeOverridePlugin, [[https://github.com/phan/phan/blob/630a862f36c9637fa3803e394647d0cb65b768ce/src/Phan/Plugi... [08:52:19] 10Gerrit, 10Browser-Support-Microsoft-Edge, 10Regression: Microsoft Edge does not display review details - https://phabricator.wikimedia.org/T257186 (10Xqt) [08:52:52] 10Gerrit, 10Browser-Support-Microsoft-Edge, 10Regression: Microsoft Edge does not display review details - https://phabricator.wikimedia.org/T257186 (10Xqt) [08:52:54] 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10Xqt) [08:59:20] 10phan-taint-check-plugin, 10Patch-For-Review: Better reporting for tainted parameters - https://phabricator.wikimedia.org/T256662 (10Daimona) a:03Daimona [09:07:18] 10Gerrit, 10Browser-Support-Microsoft-Edge, 10Regression: Microsoft Edge does not display review details - https://phabricator.wikimedia.org/T257186 (10Xqt) Additional Information from development tools console ` 2HTML1300: Navigation wurde ausgeführt. www.phabricator.org (1,1) CSS3121: Die Medienabfrage -... [09:29:21] 10Gerrit, 10Upstream: gerrit: submitting a topic requires push option (.../master%topic=my-topic), appending to branch (.../master/my-topic) is no supported in Gerrit 3.2 - https://phabricator.wikimedia.org/T256653 (10QChris) [09:34:58] 10phan-taint-check-plugin: Add a convenient way to represent taintedness of variadic params - https://phabricator.wikimedia.org/T257191 (10Daimona) [09:42:36] 10Gerrit, 10MediaWiki-extensions-LifeWeb: Mark Extension:LifeWeb inactive, possibly unused - https://phabricator.wikimedia.org/T257193 (10Lucas_Werkmeister_WMDE) [09:45:42] 10Gerrit, 10MediaWiki-extensions-LifeWeb: Mark Extension:LifeWeb inactive, possibly unused - https://phabricator.wikimedia.org/T257193 (10Lucas_Werkmeister_WMDE) [09:54:20] 10phan-taint-check-plugin, 10Patch-For-Review: Expand taintedness data for builtin functions - https://phabricator.wikimedia.org/T256660 (10Daimona) a:03Daimona [10:11:32] 10phan: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin - https://phabricator.wikimedia.org/T252946 (10Daimona) I think it should be possible to catch this with a phan plugin, not taint-check though. We'd likely have to write one ad-hoc and put it in mediawiki-phan-config.... [10:19:19] 10Gerrit, 10MediaWiki-extensions-LifeWeb: Mark Extension:LifeWeb inactive, possibly unused - https://phabricator.wikimedia.org/T257193 (10Lucas_Werkmeister_WMDE) LivingShadow has confirmed via email that the extension is currently inactive. [10:28:41] 10Gerrit, 10MediaWiki-extensions-LifeWeb: Mark Extension:LifeWeb inactive, possibly unused - https://phabricator.wikimedia.org/T257193 (10Ammarpad) [10:29:36] 10Gerrit, 10MediaWiki-extensions-LifeWeb: Mark Extension:LifeWeb inactive, possibly unused - https://phabricator.wikimedia.org/T257193 (10Ammarpad) I have added some boilerplate text to the description [11:03:41] 10Gerrit: Gerrit: `Depends on` and `Needed by` show `ChangeId`s, while other related changes show subject - https://phabricator.wikimedia.org/T257198 (10QChris) [11:03:57] 10Gerrit: Gerrit: `Depends on` and `Needed by` show `ChangeId`s, while other related changes show subject - https://phabricator.wikimedia.org/T257198 (10QChris) [11:03:59] 10Gerrit, 10Patch-For-Review: Gerrit 3.2 upgrade - https://phabricator.wikimedia.org/T254158 (10QChris) [11:23:47] Hi. We have recently migrated the project gdrive-to-commons from github to gerrit. Previously we used travis ci. We have configured CI using tox-docker for the project. What should be the best approach for deploying it at toolforge? [11:26:42] We previously used https://github.com/tonythomas01/gdrive-to-commons/blob/master/.travis.yml to deploy [11:41:49] 10phan-taint-check-plugin, 10Patch-For-Review: Use string formatting in issue messages - https://phabricator.wikimedia.org/T256664 (10Daimona) a:03Daimona [11:41:54] 10Beta-Cluster-Infrastructure, 10observability, 10Graphite, 10Performance-Team (Radar): Graphite function sortByTotal() undefined in graphite-labs - https://phabricator.wikimedia.org/T234134 (10fgiunchedi) 05Open→03Invalid Graphite version on wmcs has catched up and `sortByTotal` is available (tested o... [11:46:58] 10phan-taint-check-plugin: Re-consider value of running phan-taint-check plugin against maintenance scripts - https://phabricator.wikimedia.org/T203340 (10Daimona) 05Open→03Resolved a:03Daimona I'm calling this resolved, given that https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/589891/ was merged, and... [11:49:52] 10phan-taint-check-plugin, 10User-Daimona: Using multi dimensions array in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Daimona) Closing as duplicate -- the initial support for array keys should be more than enough to catch getQueryInfo-like methods... [11:50:03] 10phan-taint-check-plugin, 10User-Daimona: Using multi dimensions array in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Daimona) [11:50:06] 10phan-taint-check-plugin, 10Patch-For-Review: Make taint-check understand array offsets - https://phabricator.wikimedia.org/T253875 (10Daimona) [12:26:52] 10Gerrit, 10Browser-Support-Microsoft-Edge, 10Regression: Microsoft Edge does not display review details - https://phabricator.wikimedia.org/T257186 (10hashar) ` Reporting: Page: _handleChangeRoute SCRIPT5007: SCRIPT5007: Unable to get property 'children' of undefined or null reference gr-app.js (262,186) Ty... [13:13:02] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [13:23:04] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [13:34:27] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10Pchelolo) ### A little risky patch! 🚂🔥 * **Change**: https://gerrit.wikimedia.org/r/c/mediawiki/... [13:39:59] 10Beta-Cluster-Infrastructure, 10Scap: beta-publish-deb failure do to "/srv/packages/db/LOG: permission denied" - https://phabricator.wikimedia.org/T250157 (10LarsWirzenius) I think it's an anti-pattern that the package repository is ever changed by more than one user. The Debian approach seems simpler: * hav... [14:05:01] 10Gerrit: Use WMF Gerrit's logo as favicon - https://phabricator.wikimedia.org/T257218 (10QChris) [14:10:20] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10Reedy) >It would be straightforward to have the bot update it in supported MW branches on a monthly or other schedule. In any case,... [14:11:08] 10MediaWiki-Releasing, 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-release: Bundle SecureLinkFixer extension with MediaWiki - https://phabricator.wikimedia.org/T257180 (10Reedy) [14:18:32] Project beta-scap-eqiad build #307608: 04FAILURE in 3 min 54 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/307608/ [14:23:53] >15:18:25 ImportError: /usr/lib/python2.7/lib-dynload/resource.x86_64-linux-gnu.so: failed to map segment from shared object [14:23:54] nice [14:28:27] Yippee, build fixed! [14:28:27] Project beta-scap-eqiad build #307609: 09FIXED in 3 min 55 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/307609/ [15:22:00] PROBLEM - Parsoid on deployment-parsoid11 is CRITICAL: connect to address 172.16.1.115 and port 8000: Connection refused [15:28:13] 10Release-Engineering-Team, 10Security-Team, 10user-sbassett: php-composer-security-docker failing due to git fetch of non-existent REL1_35 ref - https://phabricator.wikimedia.org/T257080 (10sbassett) 05Open→03Stalled p:05Triage→03Low a:03sbassett [15:29:08] 10Release-Engineering-Team, 10Security-Team, 10user-sbassett: php-composer-security-docker failing due to git fetch of non-existent REL1_35 ref - https://phabricator.wikimedia.org/T257080 (10sbassett) @Reedy is telling me 1_35 should get cut next week, so I'll plan to follow up and resolve this. Stalling un... [15:29:17] 10Release-Engineering-Team (Onboarding), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10User-brennen: Onboard Ahmon Dancy - Software Engineer in RelEng - https://phabricator.wikimedia.org/T256074 (10jcrespo) [15:44:56] 10Release-Engineering-Team, 10Security-Team, 10user-sbassett: php-composer-security-docker failing due to git fetch of non-existent REL1_35 ref - https://phabricator.wikimedia.org/T257080 (10Jdforrester-WMF) Oops, yes, sorry, added it at the end of last week in prep for the cut early next week. [15:55:30] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10MediaWiki-extensions-MediaModeration, 10Wikimedia-Extension-setup, 10CPT Initiatives (Hash Checking), 10Wikimedia-extension-review-queue: Deploy MediaModeration Extension to Wikimedia Production - https://phabricator.wikimedia.org/T247943 (10CCi... [16:07:04] 10phan-taint-check-plugin, 10User-Daimona: make phan-taint-check handle array_map - https://phabricator.wikimedia.org/T204911 (10Daimona) (POC at https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/SecurityCheckPlugin/+/609803, it doesn't really handle array_map though). [16:56:30] PROBLEM - Host deployment-changeprop is DOWN: CRITICAL - Host Unreachable (172.16.5.21) [16:56:30] PROBLEM - Host deployment-cpjobqueue is DOWN: CRITICAL - Host Unreachable (172.16.4.124) [17:03:04] Amir1: it is kind of sweet that you think that folks on ops-l have built or maintain any instances in the deployment-prep project [17:05:04] is deployment-prep maintained at all? :P [17:07:46] bd808: haha, Everyone with production access should be subscribed to that mailing list, I hope it reaches broader audience :D [17:08:51] hauskatze: T215217 -- I have asked this question [17:08:51] T215217: deployment-prep: Code stewardship request - https://phabricator.wikimedia.org/T215217 [17:16:51] Amir1: just use a different project than deployment-prep. the instances in there are meant to stay permanently and not for one-time tasks. so the "clean up your instances" thing might not apply [17:18:21] and you get out of the quota issue that way.. and there might otherwise be questions why something should be in beta when it's not in prod.. etc [17:19:23] mutante: yes but 1- I don't have access to any other project that remotely would fit in the work of upgrading mailman (I probably should request creating a new project) 2- lots of projects supposed to be there and then dropped like sentry [17:20:52] Amir1: yea.. i'd say request one, use it, and then remove it again. projects based on a specific project are better than generic or personal test projects anyways [17:24:28] what mutante said re new project, unblock yourself that way. [17:53:58] qchris: where does the sentence " Test results for Patchset 13 (Only main test build and SonarQube) " come from? [17:54:11] not finding the patch :) [17:54:29] Krinkle: https://gerrit.wikimedia.org/r/c/operations/puppet/+/609745 [17:54:50] qchris: perfect, thanks [17:55:01] yw [17:55:59] If you want to change something ... I see the tip of the topic is getting merged already. [17:56:31] yep, left a suggestion. anyway, no big deal [17:56:41] looks great :) [17:57:17] Hehe. Great. [18:15:28] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10DannyS712) [18:21:22] It seems the changes merged by mutante are already live on our production Gerrit. We have a CI table \o/ Wooohoo :-D [18:21:27] Thanks mutante! [18:25:45] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Announce 1.35 "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T256378 (10eprodromou) We've got a thread on wikitech-l, mediawiki-l and mediawiki-announce... [18:25:54] 10MediaWiki-Releasing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes, 10MW-1.35-release: Announce 1.35 "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T256378 (10eprodromou) 05Open→03Resolved [18:25:56] 10MediaWiki-Releasing, 10Core Platform Team, 10MW-1.35-notes, 10MW-1.35-release: Release MW 1.35 - https://phabricator.wikimedia.org/T256375 (10eprodromou) [19:23:30] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release, 10Train Deployments: 1.35.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T256668 (10Krinkle) [19:44:52] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [19:45:13] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [19:45:35] 10Release-Engineering-Team (Development services), 10Developer Productivity, 10Proposal, 10User-Demian: Draft: RFC: Evaluate alternative Node package managers for improved package security - https://phabricator.wikimedia.org/T257068 (10Milimetric) Hi! Thanks for this draft and for untangling the parent RF... [19:45:58] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [19:49:41] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 98104 bytes in 1.226 second response time [19:50:05] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 61388 bytes in 1.179 second response time [19:50:46] RECOVERY - App Server Main HTTP Response on deployment-mediawiki-07 is OK: HTTP OK: HTTP/1.1 200 OK - 97794 bytes in 1.075 second response time [19:55:21] (03Abandoned) 10Paladox: Remove 4 plugins [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/593852 (owner: 10Paladox) [19:55:45] (03Abandoned) 10Paladox: WIP: Update gerrit to 2.16.13 [software/gerrit] (deploy/wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/495012 (owner: 10Paladox) [19:59:19] 10Release-Engineering-Team (Development services), 10Developer Productivity, 10Proposal, 10User-Demian: Draft: RFC: Evaluate alternative Node package managers for improved package security - https://phabricator.wikimedia.org/T257068 (10Demian) [19:59:31] 10Release-Engineering-Team (Development services), 10Developer Productivity, 10Proposal, 10User-Demian: Draft: RFC: Evaluate alternative Node package managers for improved package security - https://phabricator.wikimedia.org/T257068 (10Demian) [20:01:02] 10Release-Engineering-Team (Development services), 10TechCom-RFC, 10Developer Productivity, 10Proposal, 10User-Demian: Draft: RFC: Evaluate alternative Node package managers for improved package security - https://phabricator.wikimedia.org/T257068 (10Demian) Thank you, @Milimetric! Time to get it rolling... [20:48:49] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10raja_wmde) Hi, I'm UX & Design lead at Wikimedia Germany and need to be able to create (sub)projects and milestones for our sprints. Thanks a lot for giving me the respective rights.... [21:50:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Jenkins: Upgrade Jenkins instances to 2.235.1 - https://phabricator.wikimedia.org/T256978 (10hashar) [21:53:33] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Jenkins: Upgrade Jenkins instances to 2.235.1 - https://phabricator.wikimedia.org/T256978 (10hashar) [21:54:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Jenkins: Upgrade Jenkins instances to 2.235.1 - https://phabricator.wikimedia.org/T256978 (10hashar) I will upgrade... [22:20:01] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Aklapper) @raja_wmde: I've added you. (Usual default disclaimer: Please follow [guidelines](https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_projects) an... [23:44:26] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) [23:47:33] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10dpifke) [23:54:20] PROBLEM - Host deployment-sentry01 is DOWN: CRITICAL - Host Unreachable (172.16.5.16)