[00:00:09] there are quite a few little things that have surprised me in that they're implemented client side rather than server-side because i've needed to reimplement them [00:00:41] also the fact that JS and go (server-side) regexes are different, so what matches client side isn't necessarily the same as what matched server side [00:02:03] 10VPS-project-codesearch: Codesearch beta: Preset buttons missing correct cursor - https://phabricator.wikimedia.org/T260204 (10Krinkle) [00:02:21] legoktm: right, yeah. [00:02:36] iirc, elastic gives a bit of data about this, but not that much either. [00:02:45] so currently the backend gives you file and line number? [00:02:53] also the line content, or is that fetched afterward? [00:04:25] for each result it gives line number, the matched line, the two preceding lines and the two post lines. [00:04:43] which means when there are results that are back to back, the frontend has to merge the results together [00:05:09] https://gerrit.wikimedia.org/r/plugins/gitiles/labs/codesearch/+/refs/heads/master/frontend/src/codesearch.rs#189 [01:14:18] (03CR) 10Dzahn: [C: 03+1] Stop autodeployment of integration/docroot [integration/config] - 10https://gerrit.wikimedia.org/r/607041 (https://phabricator.wikimedia.org/T256005) (owner: 10Hashar) [01:22:19] (03PS3) 10Krinkle: Stop autodeployment of integration/docroot [integration/config] - 10https://gerrit.wikimedia.org/r/607041 (https://phabricator.wikimedia.org/T256005) (owner: 10Hashar) [03:25:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10VisualEditor, 10Editing-team (Tracking): Firefox CI tests keep failing in VE with Firefox 68 - https://phabricator.wikimedia.org/T240955 (10Krinkle) This seems to be affecting jquery-cl... [03:35:30] (03CR) 10Krinkle: [V: 03+2] wmf-config-wg-vars.js: Use the '/deployed' preset for Code search [tools/code-utils] - 10https://gerrit.wikimedia.org/r/616643 (https://phabricator.wikimedia.org/T248866) (owner: 10Krinkle) [03:40:22] 10Beta-Cluster-Infrastructure, 10Discovery, 10Wikimedia-Portals, 10Discovery-Portal-Sprint, 10Performance-Team (Radar): Wikimedia.org portal broken in Beta Cluster (Domain unavailable) - https://phabricator.wikimedia.org/T173887 (10Krinkle) [04:09:30] PROBLEM - Host deployment-maps05 is DOWN: CRITICAL - Host Unreachable (172.16.4.168) [04:09:30] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-09 is CRITICAL: HTTP CRITICAL: HTTP/1.1 302 Found - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 716 bytes in 0.532 second response time [04:46:50] question for someone more familiar with npm. Does a repo need to require both `babel-core` and `@babel/core`? [05:18:36] DannyS712: if I remember correctly `babel-core` is for an older version of babel and `@babel/core` is used for newer versions [05:19:00] Yeah, thats what I read, but I came across at least one extension that uses both? [05:19:20] uhhh that sounds interesting [05:20:08] what other babel packages does it have? `babel-*` or `@babel/*`? [05:23:26] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MachineVision/+/refs/heads/master/package-lock.json - "babel-core" at 6.26.3, "@babel/core" at 7.9.0 [05:28:28] * Majavah can't figure out why that includes babel-core [05:29:25] that might be a leftover from an old babel version or something [06:18:52] 10VPS-project-codesearch: Codesearch beta: Options are not loaded in same time with footer - https://phabricator.wikimedia.org/T260221 (10Zoranzoki21) [06:20:41] 10VPS-project-codesearch: Codesearch beta: Options are not loaded in same time with footer - https://phabricator.wikimedia.org/T260221 (10Zoranzoki21) 05Open→03Invalid I've tried this on phone, and somehow this works now. Before few days, it wasn't case. [06:31:59] 10Phabricator, 10DBA, 10Operations: replace phabricator db passwords with longer passwords - https://phabricator.wikimedia.org/T250361 (10jcrespo) Maybe this can be scheduled before or after the maintenance for T259589? [06:57:02] 10Phabricator, 10DBA, 10Operations: replace phabricator db passwords with longer passwords - https://phabricator.wikimedia.org/T250361 (10Marostegui) I don't have the bandwidth to prepare this change before Tuesday - @jcrespo if you happen to have some room to prepare this before Tuesday (or after), please t... [07:20:15] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10DBA, and 3 others: Improve privilege separation for phabricator's config files and mysql credentials - https://phabricator.wikimedia.org/T146055 (10mmodell) The next step here is to create a `$passwords::my... [07:22:42] 10Phabricator, 10DBA, 10Operations: replace phabricator db passwords with longer passwords - https://phabricator.wikimedia.org/T250361 (10mmodell) I made a note about how we go about setting a separate password for PHD daemons in a comment at T146055#6378825. Essentially we just need to define a new passwor... [07:25:36] 10Phabricator: Searching for "gerrit" in global Phabricator search leads to upstream request timeout - https://phabricator.wikimedia.org/T258803 (10mmodell) p:05Triage→03Medium [07:32:07] 10Phabricator: Searching for "gerrit" in global Phabricator search leads to upstream request timeout - https://phabricator.wikimedia.org/T258803 (10mmodell) medium because it works when logged in. The performance isn't great but it does return results before timing out. With a single common keyword such as "ger... [07:33:20] 10Phabricator: Searching for "gerrit" in global Phabricator search leads to upstream request timeout - https://phabricator.wikimedia.org/T258803 (10RhinosF1) > With a single common keyword such as "gerrit" we match a ton of documents and the result set is huge, probably not very useful. I don't think there is a... [07:35:01] 10Phabricator, 10Accessibility: Production Error task subtype symbol appearing on tasks, indicating something urgent, but is non-interactive - https://phabricator.wikimedia.org/T256995 (10mmodell) I agree it should be interactive and perhaps it's not the best choice of icon, however, I believe it is helpful to... [07:38:55] 10Phabricator: Searching for "gerrit" in global Phabricator search leads to upstream request timeout - https://phabricator.wikimedia.org/T258803 (10Bugreporter) We lt least need to make the result displayed, so that it will be possible to filter results by project. Usually, I only wants results from only one pro... [07:49:20] 10VPS-project-codesearch, 10Maps (Kartotherian), 10User-Ladsgroup: Missing Kartotherian service in codesearch - https://phabricator.wikimedia.org/T260124 (10TheDJ) Thank you Amir. You do soo much for all of us, it really is appreciated ! [08:37:39] (03PS1) 10Giuseppe Lavagetto: helm-linter: also install helmfile, init the helm config [integration/config] - 10https://gerrit.wikimedia.org/r/619702 [08:37:41] (03PS1) 10Giuseppe Lavagetto: jjb: use the new helm-linter image [integration/config] - 10https://gerrit.wikimedia.org/r/619703 [08:47:11] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10DBA, and 3 others: Improve privilege separation for phabricator's config files and mysql credentials - https://phabricator.wikimedia.org/T146055 (10jcrespo) I've created `$passwords::mysql::phabricator::phd... [09:20:23] 10VPS-project-codesearch: Codesearch beta: Preset buttons missing correct cursor - https://phabricator.wikimedia.org/T260204 (10Legoktm) Err, how did you get the second screenshot? The link text says "Extensions & things" instead of "Extensions & skins" and somehow it's not a link even though "Wikimedia Operatio... [09:22:41] 10VPS-project-codesearch: Codesearch beta: Preset buttons missing correct cursor - https://phabricator.wikimedia.org/T260204 (10Legoktm) Ignore the first half of that, the label being wrong is my screw up (have a simple patch locally rn), but I'm not sure how you were able to get it to be plain text instead of a... [09:29:37] 10VPS-project-codesearch: Codesearch beta: Options are not loaded in same time with footer - https://phabricator.wikimedia.org/T260221 (10Legoktm) Sorry, I didn't get a chance to respond to your email yet. In short, the initial performance of the beta is way worse than the current version, I'm slowly working on... [09:31:28] (03CR) 10Hashar: [C: 03+2] "Lets fly!" [integration/config] - 10https://gerrit.wikimedia.org/r/619702 (owner: 10Giuseppe Lavagetto) [09:32:23] (03Merged) 10jenkins-bot: helm-linter: also install helmfile, init the helm config [integration/config] - 10https://gerrit.wikimedia.org/r/619702 (owner: 10Giuseppe Lavagetto) [09:33:41] (03CR) 10Hashar: [C: 03+2] "Jobs created:" [integration/config] - 10https://gerrit.wikimedia.org/r/619579 (https://phabricator.wikimedia.org/T259911) (owner: 10Karl Wettin (WMSE)) [09:33:54] 10Phabricator: Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) - https://phabricator.wikimedia.org/T258803 (10Aklapper) [09:34:49] (03Merged) 10jenkins-bot: Fixed typo in Wikispeech service Mishkal [integration/config] - 10https://gerrit.wikimedia.org/r/619579 (https://phabricator.wikimedia.org/T259911) (owner: 10Karl Wettin (WMSE)) [09:36:37] (03CR) 10Hashar: "I have deployed the Zuul configuration change and deleted the incorrect Jenkins jobs :)" [integration/config] - 10https://gerrit.wikimedia.org/r/619579 (https://phabricator.wikimedia.org/T259911) (owner: 10Karl Wettin (WMSE)) [09:38:23] (03CR) 10Hashar: [C: 03+2] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/619703 (owner: 10Giuseppe Lavagetto) [09:39:15] _joe_: the new helm-lint is deployed on ci ;) [09:39:26] (03Merged) 10jenkins-bot: jjb: use the new helm-linter image [integration/config] - 10https://gerrit.wikimedia.org/r/619703 (owner: 10Giuseppe Lavagetto) [09:39:34] <_joe_> hashar: argh, not now :P [09:39:43] <_joe_> well it's not a problem though [09:39:48] ;D [09:39:49] <_joe_> so thanks [09:40:06] it is easy to rollback though, just have to revert to the previous image ;] [09:54:48] (03CR) 10Jforrester: Run CiviCRM tests on PHP 7.3 only (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [09:55:36] (03CR) 10Jforrester: Run CiviCRM tests on PHP 7.3 only (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [09:59:06] (03CR) 10Jforrester: "> Patch Set 2:" [integration/config] - 10https://gerrit.wikimedia.org/r/610295 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [10:42:16] 10Phabricator: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10Aklapper) [10:42:21] 10Phabricator: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10Aklapper) It already fails without searching at all, by going to https://phabricator.wikimedia.org/search/ [10:43:25] 10Phabricator: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10Aklapper) @MusikAnimal: Unrelated side note / workaround: I'd never use the global search anyway, https://phabricator.wikimedia.org/man... [10:46:56] 10Phabricator: Change my Phabricator username to GeneralNotability - https://phabricator.wikimedia.org/T260135 (10Aklapper) 05Open→03Resolved a:03Aklapper Done :) [10:50:43] 10Phabricator: Change my Phabricator username to xSavitar - https://phabricator.wikimedia.org/T260233 (10D3r1ck01) [10:55:50] 10Phabricator, 10Regression: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10Aklapper) p:05Triage→03High Not reproducible in upstream; https://secure.phabricator.com/search/ can be accessed. [11:10:29] 10Phabricator: Change my Phabricator username to xSavitar - https://phabricator.wikimedia.org/T260233 (10Aklapper) 05Open→03Resolved a:03Aklapper Sure! :) Done; also renamed https://phabricator.wikimedia.org/project/profile/3525/ [11:14:00] 10Phabricator: Change my Phabricator username to xSavitar - https://phabricator.wikimedia.org/T260233 (10D3r1ck01) Wow, thanks so much @Aklapper! Much appreciated :) [11:15:00] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [11:25:02] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [11:36:03] (03CR) 10Lars Wirzenius: [C: 03+2] scap prep: Fix version_parser (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/619538 (https://phabricator.wikimedia.org/T259706) (owner: 10Ahmon Dancy) [11:36:34] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] scap prep: Fix version_parser [tools/scap] - 10https://gerrit.wikimedia.org/r/619538 (https://phabricator.wikimedia.org/T259706) (owner: 10Ahmon Dancy) [11:45:03] 10MediaWiki-Releasing, 10Documentation, 10Release: Filenames truncated in 1.34.2 tarball release (The Unarchiver bug!) - https://phabricator.wikimedia.org/T258716 (10Andru) My edit to the DownloadMediaWiki template was accepted, so perhaps this can be closed. [12:51:17] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10Ammarpad) [13:00:12] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10Ammarpad) [13:09:53] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T257972 (10hashar) Blocked on MediaWiki application servers going out of memory. Private... [13:19:11] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10Aklapper) @Ammarpad: Do you have anything listed under https://gerrit.wikimedia.org/r/settings/#Notifications ? [13:20:07] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T257972 (10hashar) Went with `sysctl -w vm/compact_memory=1` which should workaround the... [13:21:10] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10Ammarpad) >>! In T260235#6379342, @Aklapper wrote: > @Ammarpad: Do you have anything listed under https://gerrit.wikimedia.org/r/settings/#Notifications ? No, [13:31:44] (03PS3) 10Ejegg: Run CiviCRM tests on PHP 7.3 only [integration/config] - 10https://gerrit.wikimedia.org/r/619583 [13:46:43] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T257972 (10hashar) ` lang=irc [13:27:13] !log hashar@deploy1001 Synchronized... [14:14:02] 10VPS-project-codesearch, 10Maps (Kartotherian), 10User-Ladsgroup: Missing Kartotherian service in codesearch - https://phabricator.wikimedia.org/T260124 (10Ladsgroup) No worries. I wish I could do more :( [15:06:01] PROBLEM - Free space - all mounts on deployment-snapshot01 is CRITICAL: CRITICAL: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found)deployment-prep.deployment-snapshot01.diskspace.root.byte_percentfree (<10.00%) [15:16:03] RECOVERY - Free space - all mounts on deployment-snapshot01 is OK: OK: deployment-prep.deployment-snapshot01.diskspace._data.byte_percentfree (No valid datapoints found) [15:19:22] (03CR) 10Xqt: "Sorry folks, I am not very familar with this settings stuff, probably you can overtake this issue; that would be great." [integration/config] - 10https://gerrit.wikimedia.org/r/610295 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [15:40:41] (03CR) 10Ahmon Dancy: [C: 03+1] "I also notice that this fixes a bug in existing blubber where if you don't specify a 'base', you end up with an invalid Dockerfile. Nice " [blubber] - 10https://gerrit.wikimedia.org/r/619072 (owner: 10Dduvall) [15:43:45] 10Release-Engineering-Team (Logspam), 10Product-Infrastructure-Team-Backlog, 10Reading List Service, 10User-brennen, 10Wikimedia-production-error: ReadingListRepository::deleteListEntryQuery: BIGINT UNSIGNED value is out of range in '`wikishared`.`reading_list`.`... - https://phabricator.wikimedia.org/T259740 [15:44:48] 10Phabricator, 10Accessibility: Production Error task subtype symbol appearing on tasks, indicating something urgent, but is non-interactive - https://phabricator.wikimedia.org/T256995 (10MBinder_WMF) Is it a challenge to add a title text when hovering over the icon? E.g. {F32078152} [16:18:57] (03PS1) 10Lars Wirzenius: fix: scap.md trailing newline in embedded file [tools/scap] - 10https://gerrit.wikimedia.org/r/619782 [16:19:38] (03CR) 10Lars Wirzenius: [C: 03+2] "Self-approving this since it's an obvious fix in the testing part of Scap that presumably basically only I use." [tools/scap] - 10https://gerrit.wikimedia.org/r/619782 (owner: 10Lars Wirzenius) [16:24:51] (03Merged) 10jenkins-bot: fix: scap.md trailing newline in embedded file [tools/scap] - 10https://gerrit.wikimedia.org/r/619782 (owner: 10Lars Wirzenius) [16:26:57] (03PS1) 10Umherirrender: Archive AuthenticatedKeyValueStore [integration/config] - 10https://gerrit.wikimedia.org/r/619786 (https://phabricator.wikimedia.org/T252864) [16:47:08] (03CR) 10Ejegg: Run CiviCRM tests on PHP 7.3 only (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [16:56:23] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10MediaWiki Train Development Environment: train-dev has no acceptance criteria or verification thereof - https://phabricator.wikimedia.org/T259907 (10LarsWirzenius) p:05Triage→03High [16:56:39] (03CR) 10Hashar: [C: 03+2] "I got the job created, lets give it a try :)" [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [16:56:47] ejegg: dpeloying deploying ^ ;) [16:57:31] (03CR) 10Jforrester: [C: 03+2] layout: [pywikibot/core] Add fasttest-py37 as voting [integration/config] - 10https://gerrit.wikimedia.org/r/611257 (https://phabricator.wikimedia.org/T213287) (owner: 10Jforrester) [16:57:35] (03CR) 10Jforrester: [C: 03+2] layout: [pywikibot/core] Drop fasttest-py27 [integration/config] - 10https://gerrit.wikimedia.org/r/610295 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [16:58:03] (03Merged) 10jenkins-bot: Run CiviCRM tests on PHP 7.3 only [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [16:58:27] (03Merged) 10jenkins-bot: layout: [pywikibot/core] Add fasttest-py37 as voting [integration/config] - 10https://gerrit.wikimedia.org/r/611257 (https://phabricator.wikimedia.org/T213287) (owner: 10Jforrester) [16:58:33] (03Merged) 10jenkins-bot: layout: [pywikibot/core] Drop fasttest-py27 [integration/config] - 10https://gerrit.wikimedia.org/r/610295 (https://phabricator.wikimedia.org/T213287) (owner: 10Xqt) [16:58:55] hashar: Ah, we're going to conflict. :-) [16:59:12] hashar: OK for my to sling it out? [17:00:07] !log [pywikibot/core] Add fasttest-py37; drop fasttest-py27 T213287 [17:00:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:00:12] T213287: Drop support of Python 2.7 - https://phabricator.wikimedia.org/T213287 [17:00:29] !log Run CiviCRM tests on PHP 7.3 only [17:00:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:00:44] James_F: to sling it ? [17:00:45] oh [17:00:47] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Jenkins, and 2 others: maintenance-disconnect-full-disks: Agent nodes seem to be accumulating workspace c... - https://phabricator.wikimedia.org/T258448 [17:00:56] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php73-docker/1/console ;] [17:00:58] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Jenkins, and 2 others: maintenance-disconnect-full-disks: Agent nodes seem to be accumulating workspace c... - https://phabricator.wikimedia.org/T258448 [17:01:00] tis running there [17:01:20] and fails .. [17:01:20] Hmm, failure. :-( [17:04:30] (03PS1) 10Hashar: jjb: fix Docker image for fundraising crm [integration/config] - 10https://gerrit.wikimedia.org/r/619797 [17:04:30] yeah easy [17:04:33] James_F: ^^ :) [17:04:46] Oh, hah. [17:04:48] Tsk. [17:04:56] (03CR) 10Jforrester: [C: 03+2] jjb: fix Docker image for fundraising crm [integration/config] - 10https://gerrit.wikimedia.org/r/619797 (owner: 10Hashar) [17:05:21] good to see pywikibot is dropping py27 ;) [17:05:33] (03PS2) 10Jforrester: jjb: Drop pywikibot-core-tox-fasttest-py27-docker, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/611258 (https://phabricator.wikimedia.org/T213287) [17:05:57] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/611258 (https://phabricator.wikimedia.org/T213287) (owner: 10Jforrester) [17:05:59] (03Merged) 10jenkins-bot: jjb: fix Docker image for fundraising crm [integration/config] - 10https://gerrit.wikimedia.org/r/619797 (owner: 10Hashar) [17:06:40] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10User-brennen: Write a "what you need to know about PHP" lunch & learn - https://phabricator.wikimedia.org/T260265 (10brennen) [17:06:56] (03Merged) 10jenkins-bot: jjb: Drop pywikibot-core-tox-fasttest-py27-docker, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/611258 (https://phabricator.wikimedia.org/T213287) (owner: 10Jforrester) [17:08:43] James_F: the job passed !! ejegg : https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php73-docker/2/ \o/// [17:09:12] Excellent. Well done, all. [17:09:44] 10Gerrit, 10Phabricator, 10Code-Review-Workgroup: Make a commit-message hook for gerrit patches that creates a phab task at the same time as assigning the change-id - https://phabricator.wikimedia.org/T239720 (10mmodell) 05Open→03Declined [17:11:06] 10Phabricator, 10Release-Engineering-Team-TODO: Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) - https://phabricator.wikimedia.org/T258803 (10mmodell) [17:11:33] (03CR) 10Hashar: "Note that the other job ( https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/ ) is apparently still using php7." [integration/config] - 10https://gerrit.wikimedia.org/r/619583 (owner: 10Ejegg) [17:12:49] 10Phabricator, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) - https://phabricator.wikimedia.org/T258803 (10mmodell) [17:13:22] thanks hashar ! [17:13:34] 10Phabricator, 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): Searching for "gerrit" in global Phabricator search leads to upstream request timeout (too many results?) - https://phabricator.wikimedia.org/T258803 (10mmodell) a:03mmodell [17:14:50] James_F and hashar - so I guess in order to get the other job using 7.3 we need to update the civicrm docker image? [17:15:13] I'll file a phab task for that, since I'm not sure how to do it myself [17:15:34] ejegg: Yes; I think I looked at doing that before, but it wasn't passing on 7.2 at the time (months ago?). [17:15:47] ejegg: Trivial to re-build onto 7.3 if you want me to take it for a quick spin? [17:15:58] yeah, that would be great James_F ! [17:16:41] Kk. [17:16:45] :] [17:19:47] (03PS1) 10Jforrester: dockerfiles: [civicrm] Migrate from PHP 7.0 to 7.3 [integration/config] - 10https://gerrit.wikimedia.org/r/619801 [17:20:53] If there's still any failure there, we've got another point release of CiviCRM up for review that might clear it up: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/619576 [17:22:09] Let's just try the naïve approach first. Often it works, and it's lots less work. :-) [17:22:20] (03CR) 10Hashar: "Gotchat: that will ill use whatever php 7.3 is provided by sury and the image is based on Stretch, not Buster. So that does not really " [integration/config] - 10https://gerrit.wikimedia.org/r/619801 (owner: 10Jforrester) [17:22:39] maybe we want th ephp version from Buster instead of the one from sury? [17:22:54] hashar: Eh. The Sury one is good enough. [17:23:12] Given there's still no official Wikimedia 7.3 version. [17:23:15] potentially we can just use ci-buster [17:23:29] Hmm. Maybe, but we need other fiddles I think? [17:24:00] might end up needing to add a few more php* packages [17:24:08] Yeah [17:24:12] oh yeah, we updated production civicrm to buster, so that would be fine to use in CI too [17:24:17] dockerfiles/php73/Dockerfile.template has a few [17:24:32] hashar: Want to give this one a try? [17:24:34] php7.3-mbstring for example [17:24:35] Hey all is there a gerrit admin here that could do the necessaries for +2 access? https://phabricator.wikimedia.org/T258986 [17:24:51] but we can do your change first, and look at switching to a Buster image after [17:24:55] Kk. [17:27:25] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [civicrm] Migrate from PHP 7.0 to 7.3 [integration/config] - 10https://gerrit.wikimedia.org/r/619801 (owner: 10Jforrester) [17:27:47] Jdlrobson: will do [17:28:17] (03Merged) 10jenkins-bot: dockerfiles: [civicrm] Migrate from PHP 7.0 to 7.3 [integration/config] - 10https://gerrit.wikimedia.org/r/619801 (owner: 10Jforrester) [17:29:07] !log Docker: Publishing civicrm 0.2.0 image [17:29:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:29:23] Jdlrobson: should be good, I have left the task opened [17:29:51] thanks hashar ! should i close it or should ammarpad? Am not sure what the procedure is here. [17:30:04] ejegg: so yeah hmm Buster / php7.3 will be nice. The only devil is figuring out the list of php packages that are actually needed. [17:30:07] usually i just see a congratulatory note ? [17:30:26] Jdlrobson: I have no idea :] I guess I can mark it as resolved myself [17:30:41] done [17:31:01] hashar I think we list the extensions needed in our composer.json, one sec [17:31:41] hmm, it only shows ext-intl and ext-json [17:33:08] guess one way is to have the civicrm container based on php7.3 [17:33:10] add intl [17:33:25] build it locally and run the same sequence of commands we use on ci [17:33:34] add missing packages, rinse repeat ;) [17:33:48] anyway, I can't do it this week and will surely forget [17:34:01] so I guess we can file a task for later [17:34:46] 10Phabricator, 10Regression: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10mmodell) a:03mmodell [17:40:49] 10Project-Admins, 10User-greg: Request to create #User-ANEUN personal project - https://phabricator.wikimedia.org/T243720 (10A-NEUN) @Aklapper Yes, just had some personal matters preventing me from doing so. [17:41:34] 10Phabricator: Change my Phabricator username to GeneralNotability - https://phabricator.wikimedia.org/T260135 (10GeneralNotability) @Aklapper thank you! [17:43:46] PROBLEM - App Server Main HTTP Response on deployment-mediawiki-07 is CRITICAL: HTTP CRITICAL: HTTP/1.1 302 Found - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 715 bytes in 0.055 second response time [17:49:57] (03PS1) 10Jforrester: jjb: [wikimedia-fundraising-civicrm-docker] Switch to php73 image version [integration/config] - 10https://gerrit.wikimedia.org/r/619808 [17:58:46] Aha, it passed: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/3158/console [17:59:32] ejegg: Congratulations, you're php73-only now. [17:59:33] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/619808 (owner: 10Jforrester) [18:00:11] 10Phabricator: Spaces request for ...Tech Sr Leadership - https://phabricator.wikimedia.org/T259156 (10debt) Thanks, @Aklapper - I'll get working on cleaning up those boards! [18:00:41] (03Merged) 10jenkins-bot: jjb: [wikimedia-fundraising-civicrm-docker] Switch to php73 image version [integration/config] - 10https://gerrit.wikimedia.org/r/619808 (owner: 10Jforrester) [18:01:23] 10Project-Admins, 10User-greg: Request to create #User-ANEUN personal project - https://phabricator.wikimedia.org/T243720 (10Aklapper) Ah, I'm sorry to hear that and I apologize (I did not mean to sound pushy). [18:05:56] 10Project-Admins, 10User-greg: Request to create #User-ANEUN personal project - https://phabricator.wikimedia.org/T243720 (10A-NEUN) Thanks, and it's fine. [18:06:17] (03CR) 10Jforrester: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/618333 (owner: 10Jforrester) [18:06:24] (03PS2) 10Jforrester: dockerfiles: Provide mediawiki-phan-php73 [integration/config] - 10https://gerrit.wikimedia.org/r/618333 [18:08:37] woohoo, thanks again James_F and hashar ! [18:08:56] Happy to help. [18:09:02] (03PS2) 10Jforrester: jjb: Provide mediawiki-core-php73-phan-docker [integration/config] - 10https://gerrit.wikimedia.org/r/618334 [18:09:10] (03PS2) 10Jforrester: jjb: Provide mwext-php73-phan-docker and mwskin-php73-phan-docker [integration/config] - 10https://gerrit.wikimedia.org/r/618335 [18:09:15] (03PS3) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879) [18:12:53] 10Release-Engineering-Team (Logspam), 10Growth-Team, 10StructuredDiscussions, 10User-brennen, 10Wikimedia-production-error: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10thcipriani) [18:16:51] Is WMF running it's own python requirements.txt dependency repository too? There seems to be a diff between my localhost and the Jenkins Blubber build. [18:17:09] https://integration.wikimedia.org/ci/job/wikispeech-mishkal-pipeline-test/1/console (see end) [18:22:19] 10Release-Engineering-Team (Logspam), 10TimedMediaHandler, 10User-brennen, 10Wikimedia-production-error: PHP Warning: unpack(): Type H: not enough input, need 4, have 0 - https://phabricator.wikimedia.org/T259592 (10thcipriani) [18:24:29] 10Release-Engineering-Team (Logspam), 10TimedMediaHandler, 10User-brennen, 10Wikimedia-production-error: PHP Warning: unpack(): Type H: not enough input, need 4, have 0 - https://phabricator.wikimedia.org/T259592 (10hashar) Picked one that happened and filtering on reqId=517afa8d-a805-4346-9cae-aa6bf934d55... [18:26:45] 10Release-Engineering-Team (Logspam), 10Structured Data Engineering, 10Structured-Data-Backlog, 10TimedMediaHandler, and 2 others: PHP Warning: unpack(): Type H: not enough input, need 4, have 0 - https://phabricator.wikimedia.org/T259592 (10Krinkle) [18:30:10] 10Release-Engineering-Team (Logspam), 10Structured Data Engineering, 10Structured-Data-Backlog, 10TimedMediaHandler, and 2 others: PHP Warning: unpack(): Type H: not enough input, need 4, have 0 - https://phabricator.wikimedia.org/T259592 (10hashar) Those are files being uploaded. I would assume they get r... [18:31:30] 10Phabricator, 10Regression: Global search inaccessible, fails with PhutilAggregateException: Unknown column 'ft_rank.rawCorpus' in 'field list' - https://phabricator.wikimedia.org/T260197 (10mmodell) Introduced by {e95157e39bf532b695624a65b242ce0043e74e7f} [18:39:06] 10Release-Engineering-Team (Logspam), 10Discovery-Search, 10GeoData, 10Wikimedia-production-error: Elastica\Exception\ResponseException from line 56 of /srv/mediawiki/php-1.35.0-wmf.41/extensions/GeoData/includes/Searcher.php: - https://phabricator.wikimedia.org/T258641 (10thcipriani) [18:44:38] 10Release-Engineering-Team (Logspam), 10Growth-Team, 10StructuredDiscussions, 10User-brennen, and 2 others: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10kostajh) [18:54:43] (Sorry i couldnt make the train log triage today thcipriani ) [18:55:37] Im not seeing anything from the client error side however :) [19:01:54] Jdlrobson: no worries -- is this meeting at a bad time today or generally? [19:20:17] 10Release-Engineering-Team (Logspam), 10Growth-Team, 10MediaWiki-Blocks, 10StructuredDiscussions, and 3 others: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10Bugreporter) [19:26:37] PROBLEM - jenkins_service_running on releases2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args .*/bin/java .*-jar /usr/share/jenkins/jenkins.war https://wikitech.wikimedia.org/wiki/Jenkins [19:28:07] PROBLEM - jenkins_service_running on releases1002 is CRITICAL: PROCS CRITICAL: 0 processes with regex args .*/bin/java .*-jar /usr/share/jenkins/jenkins.war https://wikitech.wikimedia.org/wiki/Jenkins [19:28:19] those jenkins icinga alarms are known [19:28:25] been upgrading jjenkins on them [19:29:11] ACKNOWLEDGEMENT - jenkins_service_running on releases1002 is CRITICAL: PROCS CRITICAL: 0 processes with regex args .*/bin/java .*-jar /usr/share/jenkins/jenkins.war daniel_zahn jenkins is supposed to run only on the active server https://wikitech.wikimedia.org/wiki/Jenkins [19:29:11] ACKNOWLEDGEMENT - jenkins_service_running on releases2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args .*/bin/java .*-jar /usr/share/jenkins/jenkins.war daniel_zahn jenkins is supposed to run only on the active server https://wikitech.wikimedia.org/wiki/Jenkins [19:29:12] ACKNOWLEDGEMENT - jenkins_service_running on releases2002 is CRITICAL: PROCS CRITICAL: 0 processes with regex args .*/bin/java .*-jar /usr/share/jenkins/jenkins.war daniel_zahn jenkins is supposed to run only on the active server https://wikitech.wikimedia.org/wiki/Jenkins [19:31:41] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10QChris) According to Gerrit's backend storage, the above mentioned changes are both [[https://gerrit.wikimedia.org/r/Documentation/config-accounts.html#starred-changes|starred]... [19:43:03] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Analytics, 10Event-Platform, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Deploy EventStreamConfig extension - https://phabricator.wikimedia.org/T242122 (10Ottomata) 05Open→03Resolved [19:57:58] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T257972 (10hashar) 05Open→03Resolved Looks like it is a success ! :] [20:14:44] 10Gerrit: Getting Gerrit emails for changes I have not interacted with/not subscribed to. - https://phabricator.wikimedia.org/T260235 (10Ammarpad) > Do you recall starring them? (Either through the API or by clicking the star icon (see red arrow on ) on the change pages? No. I can clearly recall that the first t... [20:19:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10Jenkins: Review process to fetch Jenkins Debian package from upstream - https://phabricator.wikimedia.org/T260282 (10hashar) [20:19:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10Jenkins: Review process to fetch Jenkins Debian package from upstream - https://phabricator.wikimedia.org/T260282 (10hashar) p:05Triage→03Medium No hurry. I filed it cause we ended up importing the non LTS version... [20:50:11] thcipriani: hopefully will be fine generally, just got quite a few things going on right now and need to adjust my schedule :) [21:01:49] hey all, I want to add a few wfDebug lines on mwdebug1001 to figure out an issue I'm unable to reproduce locally. I've been told this is ok but I'm unable to make any changes on the server due to file permissions error. Is this something I should be able to do and I'm missing a step or do I need special permissions? [21:27:08] dmaza: `sudo -u mwdeploy vim ...` [21:27:22] if you are live hacking [21:27:33] thank you.. and yes, we can call it that [21:28:00] sometimes that's the right thing to do :) [21:28:57] :) [21:29:57] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), 10Release Pipeline, 10Patch-For-Review: Make pipelinelib able to update deployment chart image tags - https://phabricator.wikimedia.org/T255835 (10jeena) We decided to add... [21:36:52] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): deployment-charts: Deploy script failing - kube_env: command not found - https://phabricator.wikimedia.org/T259684 (10jeena) a:03jeena [21:39:42] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))): deployment-charts: Deploy script failing - kube_env: command not found - https://phabricator.wikimedia.org/T259684 (10jeena) Failing because kube_env is located in /etc/profile.d, so only loaded for interactive shell. [21:46:01] bd808: is it still live hacking if I use `nano` instead? [21:46:14] * Krinkle 's old habbits die hard [21:46:36] I probably use vim 1/10 times nowdays, getting there. [21:47:08] Krinkle: heh. I remember making the jump from Notepad++ to vim. It took me a while, but turned out well I think. [22:03:00] PROBLEM - Host deployment-chromium01 is DOWN: CRITICAL - Host Unreachable (172.16.4.108) [22:09:18] i went from DOS edit -> emacs -> vim [22:09:59] i tried to revisit DOS edit not that long ago and it's not surprisingly not bad except i am no longer capable of working in an editor without an undo. [22:11:31] for me it was once https://en.wikipedia.org/wiki/UltraEdit [22:11:35] (there's an extra "not" in that sentence.) [22:21:06] live hacking session completed and changes discarded. Thanks again bd808 [22:29:13] 10Release-Engineering-Team (Logspam), 10Reading List Service, 10Product-Infrastructure-Team-Backlog (Kanban), 10User-brennen, 10Wikimedia-production-error: ReadingListRepository::deleteListEntryQuery: BIGINT UNSIGNED value is out of range in '`wikishared`.`readin... - https://phabricator.wikimedia.org/T259740 [22:30:47] (03CR) 10C. Scott Ananian: "> Patch Set 2: Code-Review+2" [integration/quibble] - 10https://gerrit.wikimedia.org/r/612937 (https://phabricator.wikimedia.org/T227352) (owner: 10C. Scott Ananian) [23:22:16] (03PS1) 10Krinkle: Allow `@beforeClass` and `@afterClass` in FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/619871 [23:25:41] (03CR) 10Krinkle: "I'm struggling with the updating of the fixture." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/619871 (owner: 10Krinkle) [23:25:47] (03CR) 10jerkins-bot: [V: 04-1] Allow `@beforeClass` and `@afterClass` in FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/619871 (owner: 10Krinkle)