[00:06:03] <wikibugs>	 (03CR) 10DannyS712: [C: 03+2] Add PSR2.ControlStructures.SwitchDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/613734 (https://phabricator.wikimedia.org/T182546) (owner: 10Esanders)
[00:06:49] <wikibugs>	 (03CR) 10DannyS712: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE))
[00:06:55] <wikibugs>	 (03Merged) 10jenkins-bot: Add PSR2.ControlStructures.SwitchDeclaration [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/613734 (https://phabricator.wikimedia.org/T182546) (owner: 10Esanders)
[00:11:40] <wikibugs>	 (03PS14) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958)
[00:14:37] <wikibugs>	 (03PS17) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:14:40] <wikibugs>	 (03PS18) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:16:42] <wikibugs>	 (03PS19) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:18:04] <wikibugs>	 (03PS20) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:22:06] <wikibugs>	 (03CR) 10DannyS712: "LGTM. LibUp will likely break some things with the autofix though, and those will need to be cleaned up manually (either before or at the " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE))
[00:23:25] <wikibugs>	 (03PS6) 10DannyS712: Expand ExtendClassUsageSniff with subclasses of ContextSource [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/611222 (https://phabricator.wikimedia.org/T257710)
[00:24:29] <wikibugs>	 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to disallow new global variable imports in functions (using global keyword) - https://phabricator.wikimedia.org/T257710 (10DannyS712) @Krinkle you marked this as an accepted rule change - would you mind taking a look at the patch?
[00:30:01] <wikibugs>	 (03PS12) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443)
[00:30:25] <wikibugs>	 (03CR) 10DannyS712: "> Patch Set 11: Code-Review-1" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712)
[00:31:31] <wikibugs>	 (03PS13) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443)
[00:33:23] <wikibugs>	 (03PS14) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443)
[00:35:33] <wikibugs>	 (03PS15) 10DannyS712: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443)
[02:34:40] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] Expand ExtendClassUsageSniff with subclasses of ContextSource [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/611222 (https://phabricator.wikimedia.org/T257710) (owner: 10DannyS712)
[02:35:29] <wikibugs>	 (03Merged) 10jenkins-bot: Expand ExtendClassUsageSniff with subclasses of ContextSource [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/611222 (https://phabricator.wikimedia.org/T257710) (owner: 10DannyS712)
[02:41:55] <wikibugs>	 10MediaWiki-Codesniffer: Add sniff to disallow new global variable imports in functions (using global keyword) - https://phabricator.wikimedia.org/T257710 (10DannyS712)
[03:11:44] <keenan>	 Hi, I successfully jumped through all the hoops for my PR to show up for this wikidata unit conversion: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/623094
[03:12:04] <keenan>	 but now I have no idea who to add as a reviewer... that file hadn't been touched for 3 years apparently
[03:44:01] <Krinkle>	 keenan: Hi!
[03:44:11] <Krinkle>	 keenan: was this change requested or discussed somewhere on Phabricator?
[04:36:08] <keenan>	 not at all, I just noticed it when I was using sparql to make lists of stuff
[04:36:46] <keenan>	 the list of largest lakes by volume was missing a bunch of lakes, and I traced it to the "cubic hectometre" unit not being converted
[04:37:03] <keenan>	 should I open a ticket or something?
[09:52:34] <wikibugs>	 10Release-Engineering-Team, 10MediaWiki-General, 10MediaWiki-Stakeholders-Group, 10serviceops, and 4 others: Drop official PHP 7.2 support in MediaWiki 1.35 - https://phabricator.wikimedia.org/T257879 (10Jdforrester-WMF) 7.3.19 then? OK, patch coming up.
[10:08:41] <wikibugs>	 (03PS4) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879)
[10:49:12] <wikibugs>	 (03PS5) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879)
[10:49:14] <wikibugs>	 (03PS1) 10Jforrester: jjb: Provide all the variants of the selenium-only quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623100
[10:49:17] <wikibugs>	 (03PS1) 10Jforrester: layout: Migrate use of selenium-only jobs to explicit versions [integration/config] - 10https://gerrit.wikimedia.org/r/623101
[10:49:19] <wikibugs>	 (03PS1) 10Jforrester: jjb: Drop old non-variant selenium-only jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623102
[10:49:22] <James_F>	 Reedy: OK, are we definitely doing this? :-)
[10:49:24] <wikibugs>	 (03PS1) 10Jforrester: jjb: Provide PHP 7.3 variants of Wikimedia quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623103
[10:50:31] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879) (owner: 10Jforrester)
[10:50:33] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] jjb: Drop old non-variant selenium-only jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623102 (owner: 10Jforrester)
[10:50:37] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] jjb: Provide PHP 7.3 variants of Wikimedia quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623103 (owner: 10Jforrester)
[10:50:39] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] layout: Migrate use of selenium-only jobs to explicit versions [integration/config] - 10https://gerrit.wikimedia.org/r/623101 (owner: 10Jforrester)
[10:51:55] <wikibugs>	 (03PS2) 10Jforrester: layout: Migrate use of selenium-only jobs to explicit versions [integration/config] - 10https://gerrit.wikimedia.org/r/623101
[10:51:57] <wikibugs>	 (03PS2) 10Jforrester: jjb: Drop old non-variant selenium-only jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623102
[10:51:59] <wikibugs>	 (03PS6) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879)
[10:52:01] <wikibugs>	 (03PS2) 10Jforrester: jjb: Provide PHP 7.3 variants of Wikimedia quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623103
[10:57:54] <wikibugs>	 (03CR) 10Jforrester: "(This isn't needed until we start thinking about PHP 7.3 for production, I just noticed it whilst I was working on the REL1_35 stuff.)" [integration/config] - 10https://gerrit.wikimedia.org/r/623103 (owner: 10Jforrester)
[11:13:06] <Reedy>	 James_F: I think so (NB patches not reviewed). Seems cleaner, more explicit etc
[11:14:07] <James_F>	 Kk. Will do the fiddly bit for CI, other than the removal, until you give me the 'go'.
[11:14:15] <Reedy>	 cheers
[11:14:19] <Reedy>	 will have a look in a bit
[11:20:48] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/623100 (owner: 10Jforrester)
[11:21:46] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: Provide all the variants of the selenium-only quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623100 (owner: 10Jforrester)
[11:21:57] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] layout: Migrate use of selenium-only jobs to explicit versions [integration/config] - 10https://gerrit.wikimedia.org/r/623101 (owner: 10Jforrester)
[11:23:02] <wikibugs>	 (03Merged) 10jenkins-bot: layout: Migrate use of selenium-only jobs to explicit versions [integration/config] - 10https://gerrit.wikimedia.org/r/623101 (owner: 10Jforrester)
[11:24:25] <James_F>	 !log layout: Migrate use of selenium-only jobs to explicit versions
[11:24:27] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[11:32:27] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/623102 (owner: 10Jforrester)
[11:33:42] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: Drop old non-variant selenium-only jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623102 (owner: 10Jforrester)
[11:35:44] <wikibugs>	 (03PS7) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879)
[11:35:46] <wikibugs>	 (03PS3) 10Jforrester: jjb: Provide PHP 7.3 variants of Wikimedia quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623103
[11:35:48] <wikibugs>	 (03PS1) 10Jforrester: layout: Migrate REL1_35 branches to use PHP 7.3 by default [integration/config] - 10https://gerrit.wikimedia.org/r/623105
[11:42:00] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] layout: Migrate REL1_35 branches to use PHP 7.3 by default [integration/config] - 10https://gerrit.wikimedia.org/r/623105 (owner: 10Jforrester)
[11:42:58] <wikibugs>	 (03Merged) 10jenkins-bot: layout: Migrate REL1_35 branches to use PHP 7.3 by default [integration/config] - 10https://gerrit.wikimedia.org/r/623105 (owner: 10Jforrester)
[11:43:30] <James_F>	 !log layout: Migrate REL1_35 branches to use PHP 7.3 by default
[11:43:32] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[11:57:30] <wikibugs>	 (03PS8) 10Jforrester: Drop PHP 7.2 testing for REL1_35 branches [integration/config] - 10https://gerrit.wikimedia.org/r/618336 (https://phabricator.wikimedia.org/T257879)
[11:57:32] <wikibugs>	 (03PS4) 10Jforrester: jjb: Provide PHP 7.3 variants of Wikimedia quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/623103
[11:57:34] <wikibugs>	 (03PS1) 10Jforrester: dockerfiles: [mediawiki-phan-php73] Add executable permission to scripts [integration/config] - 10https://gerrit.wikimedia.org/r/623106
[11:57:36] <wikibugs>	 (03PS1) 10Jforrester: jjb: Switch mediawiki-phan-php73 use to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/623107
[11:57:49] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Oops." [integration/config] - 10https://gerrit.wikimedia.org/r/623106 (owner: 10Jforrester)
[11:58:53] <wikibugs>	 (03Merged) 10jenkins-bot: dockerfiles: [mediawiki-phan-php73] Add executable permission to scripts [integration/config] - 10https://gerrit.wikimedia.org/r/623106 (owner: 10Jforrester)
[12:01:17] <James_F>	 !log dockerfiles: [mediawiki-phan-php73] Publishing 0.1.1
[12:01:19] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[12:07:43] <wikibugs>	 10Phabricator, 10Developer Productivity: Introduce new task statuses in Phabricator. - https://phabricator.wikimedia.org/T261493 (10Aklapper) Right. And I mentioned that I think it's by far the worst implementation, so I'm confused why this task named "Introduce new task statuses in Phabricator" was created, I...
[12:09:14] <wikibugs>	 (03PS2) 10Jforrester: jjb: Switch mediawiki-phan-php73 use to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/623107
[12:09:24] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/623107 (owner: 10Jforrester)
[12:10:27] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: Switch mediawiki-phan-php73 use to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/623107 (owner: 10Jforrester)
[14:12:08] <wikibugs>	 10LibUp: libup fails to update eslint-config-wikimedia to 0.17.0 due to old eslint - https://phabricator.wikimedia.org/T261520 (10Jdforrester-WMF) Ah, joy. I guess we can wait for that release of grunt-eslint, but…
[20:04:41] <wikibugs>	 10Continuous-Integration-Config, 10Anti-Harassment, 10IP Info: Update CI config for new IP Info extension - https://phabricator.wikimedia.org/T261553 (10Reedy)
[20:34:31] <wikibugs>	 10LibUp: libup fails to update eslint-config-wikimedia to 0.17.0 due to old eslint - https://phabricator.wikimedia.org/T261520 (10Umherirrender) Needs a `npm update eslint -depth 1` or similar  `npm outdated -depth 1` shows it in red.  Maybe libup can run update for all red lines reports from npm outdated.  Or i...