[01:50:12] 10Release-Engineering-Team, 10Operations, 10Wikimedia Design Style Guide: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10Dzahn) I checked the git status on both backends, miscweb1002 and miscweb2002 and they are both at commit e3fda... [01:51:41] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Wikimedia Design Style Guide, 10Wikimedia-GitHub: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10Dzahn) [01:59:58] 10Release-Engineering-Team, 10Cosmos, 10Wikimedia-GitHub: Add Discord webhook to wikimedia GitHub for tracking repository changes. - https://phabricator.wikimedia.org/T264559 (10Universal_Omega) Any updates on this? Also is it possible to delete the existing tags and releases from the GitHub that go imported... [02:02:01] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Wikimedia Design Style Guide, 10Wikimedia-GitHub: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10Dzahn) The `deploy-style-guide.sh` script git pulls from https://gerrit.wikim... [02:51:08] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10MediaWiki-Configuration, 10Patch-For-Review, 10Services (watching): Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730 (10Ladsgroup) [02:53:44] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10MediaWiki-Configuration, 10Patch-For-Review, 10Services (watching): Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730 (10Ladsgroup) An update from the subtask which might of interest here: So with [[https://github.com/La... [02:57:05] 10Continuous-Integration-Config, 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Scap, and 4 others: Define variant Wikimedia production config in compiled, static files - https://phabricator.wikimedia.org/T223602 (10Ladsgroup) [02:57:30] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10MediaWiki-Configuration, 10Patch-For-Review, 10Services (watching): Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730 (10Ladsgroup) [06:07:03] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Scap, 10Sustainability (Incident Followup): Make scap skip restarting php-fpm when using --force - https://phabricator.wikimedia.org/T243009 (10Joe) >>! In T243009#6519176, @Krinkle wrote:... [07:34:44] 10Gerrit, 10Cosmos, 10translatewiki.net, 10Patch-For-Review: Add mediawiki/skins/Cosmos to translatewiki.net - https://phabricator.wikimedia.org/T264695 (10Raymond) 05Open→03Resolved Deployed on translatewiki.net [07:58:19] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10ArielGlenn) I will be deleting snapshot01 in a week and a half, per https://phabricator.wikimedia.org/T245402#6514449 [08:50:29] maintenance-disconnect-full-disks build 218816 integration-agent-docker-1016 (/: 17%, /srv: 96%, /var/lib/docker: 26%): OFFLINE due to disk space [09:00:28] maintenance-disconnect-full-disks build 218818 integration-agent-docker-1016 (/: 17%, /srv: 5%, /var/lib/docker: 26%): RECOVERY disk space OK [09:05:30] maintenance-disconnect-full-disks build 218819 integration-agent-docker-1013 (/: 17%, /srv: 96%, /var/lib/docker: 46%): OFFLINE due to disk space [09:10:28] maintenance-disconnect-full-disks build 218820 integration-agent-docker-1013 (/: 17%, /srv: 6%, /var/lib/docker: 46%): RECOVERY disk space OK [09:15:22] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] Remove misleading comments about puppet [tools/train-dev] - 10https://gerrit.wikimedia.org/r/632826 (owner: 10Ahmon Dancy) [09:44:37] (03CR) 10Hashar: [C: 03+2] Enables CI for ExternalLinkConfirm extension [integration/config] - 10https://gerrit.wikimedia.org/r/632764 (owner: 10Vedmaka Wakalaka) [09:45:34] (03CR) 10Hashar: [C: 03+2] "Sorry for the delay!" [integration/config] - 10https://gerrit.wikimedia.org/r/631228 (https://phabricator.wikimedia.org/T235286) (owner: 10HitomiAkane) [09:46:02] (03CR) 10Hashar: [C: 03+2] operations-puppet: bump version to update Gem file [integration/config] - 10https://gerrit.wikimedia.org/r/632689 (owner: 10Jbond) [09:47:08] (03Merged) 10jenkins-bot: Enables CI for ExternalLinkConfirm extension [integration/config] - 10https://gerrit.wikimedia.org/r/632764 (owner: 10Vedmaka Wakalaka) [09:47:10] (03Merged) 10jenkins-bot: layout.yaml: Add HitomiAkane to Jenkins whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/631228 (https://phabricator.wikimedia.org/T235286) (owner: 10HitomiAkane) [09:47:15] (03Merged) 10jenkins-bot: operations-puppet: bump version to update Gem file [integration/config] - 10https://gerrit.wikimedia.org/r/632689 (owner: 10Jbond) [10:06:57] !log Successfully tagged docker-registry.discovery.wmnet/releng/operations-puppet:0.7.8 [10:06:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:19:04] (03PS1) 10Hashar: jjb: update to releng/puppet:0.7.8 [integration/config] - 10https://gerrit.wikimedia.org/r/632900 [10:19:28] (03CR) 10Hashar: [C: 03+2] "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/632900 (owner: 10Hashar) [10:20:42] (03Merged) 10jenkins-bot: jjb: update to releng/puppet:0.7.8 [integration/config] - 10https://gerrit.wikimedia.org/r/632900 (owner: 10Hashar) [10:30:11] 10Project-Admins, 10Platform Engineering, 10User-Kizule: Request for Product Feature tag to aid differentiation of initiatives and roadmap management - https://phabricator.wikimedia.org/T263884 (10Aklapper) 05Open→03Resolved Thanks everyone. Let's leave it like this; we could still rename/clarify if prob... [11:29:29] (03CR) 10Jbond: "thanks <3" [integration/config] - 10https://gerrit.wikimedia.org/r/632900 (owner: 10Hashar) [11:46:14] 10Release-Engineering-Team, 10MediaWiki-Core-Testing, 10ci-test-error: parser tests running under phpunit are broken in extensions - https://phabricator.wikimedia.org/T248180 (10kostajh) I think this is due to the HTTP change in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626348. For some reason Growth... [11:50:02] 10Release-Engineering-Team, 10MediaWiki-Core-Testing, 10ci-test-error: parser tests running under phpunit are broken in extensions - https://phabricator.wikimedia.org/T248180 (10kostajh) And yeah, this is different issue than what was reported here. Sorry for the noise. I made T265024 for this one. [11:54:04] (03PS1) 10Urbanecm: Add Wikispeech to brancher [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) [13:02:15] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Security: Jenkins plugins security advisory - 2020-10-08 - https://phabricator.wikimedia.org/T265038 (10MoritzMuehlenhoff) [13:33:23] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Security: Jenkins plugins security advisory - 2020-10-08 - https://phabricator.wikimedia.org/T265038 (10hashar) 05Open→03Resolved a:03MoritzMuehlenhoff Looks like I have missed the pre advisory announcement. I have checked the CI and release Jenkin... [14:01:58] (03CR) 10DannyS712: [C: 03+1] Add Wikispeech to brancher [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [14:42:02] twentyafterfour: hello, you there? [14:46:55] (03CR) 10MarcoAurelio: [C: 03+2] Add Wikispeech to brancher [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [14:47:43] (03Merged) 10jenkins-bot: Add Wikispeech to brancher [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [15:00:42] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10Maps, 10Product-Infrastructure-Team-Backlog, 10Patch-For-Review: [Bug] Puppet is failing for maps beta cluster - could not find group maps-admins - https://phabricator.wikimedia.org/T263726 (10MSantos) >>! In T263726#6526231, @hnowlan wrote: > This issue is c... [15:21:42] 10Release-Engineering-Team, 10Cosmos, 10Wikimedia-GitHub: Add Discord webhook to wikimedia GitHub for tracking repository changes. - https://phabricator.wikimedia.org/T264559 (10MarcoAurelio) I can try to delete the previous releases/tags, but I feel installing and approving the webhook should be 'okayed' by... [16:13:56] Hi release engineers! [16:14:30] I'm preparing to merge the MW 1.35-related fixes for the DonationInterface into its master branch [16:15:03] and to that end I'd like to start making its tests run on the fundraising/REL1_35 branch of MW core [16:15:17] I'll take a stab at the jjb yaml changes in a sec [16:15:34] based on the experimental job you set up for us a few weeks ago [16:16:17] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Wikimedia Design Style Guide, 10Wikimedia-GitHub: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10hashar) The repository on deploy1001 points at master and does fetch from Ger... [16:16:35] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Operations, and 2 others: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10hashar) [16:19:03] !log Restarting CI Jenkins [16:19:05] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:21:45] hashar: oh, restart? [16:21:58] ok cool, that donationinterface-fundraising-branches project looks like it'll be useful for the next LTS upgrade too, so I'll just prune out the 1.31 bits [16:22:02] !log CI Jenkins: upgraded a few plugins [16:22:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:23:16] ejegg: there were a few issues last time I tried: https://phabricator.wikimedia.org/T261777#6486610 ;) [16:23:53] and I think there is some issues with the various branches [16:24:08] ah yeah the comment above https://phabricator.wikimedia.org/T261777#6486527 [16:24:36] probably we would want all the repositories to have the same branch "fundraising/REL1_35" which would simplify things [16:25:09] so I guess the devil is finding out whether the job fetches the proper branch for each repository [16:25:41] but I can't look into it this week :-\ [16:29:39] ah, ok [16:30:12] actually I hope it will simplify things to get all the fixes merged into master on the extension repos [17:06:50] 10Release-Engineering-Team, 10Wikimedia-Site-requests: get_realm_specific_filename doesn't handle datacenter correctly - https://phabricator.wikimedia.org/T265060 (10Jdforrester-WMF) [17:24:29] 10LibUp, 10JSDoc WMF theme, 10MinusX: js docs generated files by libup are created with executable bits - https://phabricator.wikimedia.org/T264143 (10Jdforrester-WMF) OK, now waiting for {T264949} so that we can publish the new version and then upgrade the few repos that use it. [17:28:40] 10Release-Engineering-Team, 10Cosmos, 10Wikimedia-GitHub: Add Discord webhook to wikimedia GitHub for tracking repository changes. - https://phabricator.wikimedia.org/T264559 (10Universal_Omega) >>! In T264559#6529586, @MarcoAurelio wrote: > I can try to delete the previous releases/tags, but I feel installi... [17:32:30] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10observability: "MediaWiki exceptions and fatals per minute" alarm is too slow (half an hour delay!) - https://phabricator.wikimedia.org/T141520 (10colewhite) Indeed, there is a bit of delay due to retries and... [17:32:38] (03PS1) 10Ahmon Dancy: get_realm_specific_filename doesn't handle datacenter correctly [tools/scap] - 10https://gerrit.wikimedia.org/r/632968 (https://phabricator.wikimedia.org/T265060) [17:33:49] (03CR) 10Ahmon Dancy: [C: 04-1] "holding for testing in train-dev environment." [tools/scap] - 10https://gerrit.wikimedia.org/r/632968 (https://phabricator.wikimedia.org/T265060) (owner: 10Ahmon Dancy) [17:33:56] (03CR) 10Jforrester: "Did this go through security review? Performance review? Product review? You can't just merge into this repo…" [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [17:36:19] (03CR) 10Urbanecm: "> Patch Set 1:" [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [17:43:14] (03CR) 10Jforrester: "> Patch Set 1:" [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [17:44:19] (03CR) 10Urbanecm: "> Patch Set 1:" [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [17:45:06] (03CR) 10MarcoAurelio: "> Merges to this repo cause code to go to production. Automatically. It is exceedingly not OK to just merge into this repo." [tools/release] - 10https://gerrit.wikimedia.org/r/632903 (https://phabricator.wikimedia.org/T265021) (owner: 10Urbanecm) [17:45:19] (03PS1) 10MarcoAurelio: Revert "Add Wikispeech to brancher" [tools/release] - 10https://gerrit.wikimedia.org/r/632821 [17:45:29] (03CR) 10MarcoAurelio: [C: 03+2] "revert" [tools/release] - 10https://gerrit.wikimedia.org/r/632821 (owner: 10MarcoAurelio) [17:45:41] (03CR) 10Urbanecm: "Mind adding a reason/comment to the commit message?" [tools/release] - 10https://gerrit.wikimedia.org/r/632821 (owner: 10MarcoAurelio) [17:45:49] hauskatze: I guess I'm late ^^ [17:45:58] answer is no :P [17:46:11] good, always good when someone doesn't mind :P [17:46:16] We can fix the docs while at it [17:47:00] hauskatze: Thanks. Sorry about this; really, the repo should be locked down so that only RelEng can merge there or whatever. [17:47:32] I read the docs before merging and took a look at the tickets before +2ing [17:47:47] (03PS1) 10Jforrester: Review access change [tools/release] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/632822 [17:47:58] If the code was unused then I assumed it'd just start branching the repo w/o more effects [17:48:08] and simply creating wmf/ branchs [17:48:19] (03Merged) 10jenkins-bot: Revert "Add Wikispeech to brancher" [tools/release] - 10https://gerrit.wikimedia.org/r/632821 (owner: 10MarcoAurelio) [17:48:22] It will create the wmf/ branches and pull them into production. [17:48:35] wait - doesn't merely adding it to mediawiki/extensions master-repo cause it to be deployed somewhere? I guess to beta [17:48:37] (unused) [17:48:39] Theoretically that's "safe", but that's Release Engineering's call. [17:48:42] Urbanecm: Yes. [17:48:55] Urbanecm: But we don't care about data integrity of the Beta Cluster. [17:49:05] (Maybe we should, but we don't.) [17:49:16] ack, apologies for any issues [17:49:24] sure - beta is to be breaked again and again [17:49:44] It'd be nice if Beta Cluster didn't break. :-) [17:49:47] was beta not broken at some stage? [17:49:54] Every stage. [17:50:31] James_F: while you're here, would you mind looking at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632820 as the merger of the reverted commit? I'm inclined to +2 it, as it apparently causes a production repo (GrowthExperiments) to have unit tests failed, but since you're around... :-) [17:50:52] Urbanecm: It's being discussed with Daniel. [17:50:56] cool, thx :) [17:50:58] Urbanecm: I was leaving to him to decide. [17:51:10] But if it's still broken in a few hours' time, I'll merge. [17:51:24] James_F: where is that discussion? Didn't see it anywhere [17:51:31] and thanks :) [17:53:04] Urbanecm: Core team channel, at least. [17:53:56] ah, #mediawiki-core - I tend to forget we have that :) [17:53:59] thanks [17:54:03] No worries. [18:59:58] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Operations, and 2 others: Deployment of latest Design Style Guide Gerrit clone doesn't seem to succeed - https://phabricator.wikimedia.org/T264894 (10Volker_E) 05Open→03Invalid... [19:50:04] What happened with https://shinken.wmflabs.org/ ? [19:51:36] Ah, T236547 [19:51:37] T236547: "shinken" Cloud VPS project jessie deprecation - https://phabricator.wikimedia.org/T236547 [20:00:54] (03PS1) 10MarcoAurelio: Reinstate "Add Wikispeech to brancher" [tools/release] - 10https://gerrit.wikimedia.org/r/632989 (https://phabricator.wikimedia.org/T265021) [20:38:10] (03CR) 10Ahmon Dancy: [C: 03+1] "train-dev tests passed." [tools/scap] - 10https://gerrit.wikimedia.org/r/632968 (https://phabricator.wikimedia.org/T265060) (owner: 10Ahmon Dancy) [20:38:26] 10MediaWiki-Codesniffer: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Umherirrender) Sounds good, I would also say that autofix seems bad here, because it is not always clear that object and stdClass are the same here [20:55:46] 10Continuous-Integration-Config, 10Math, 10Platform Engineering, 10Platform Engineering Roadmap Decision Making: Enable mediawiki-quibble-apitests-vendor-docker for extension Math - https://phabricator.wikimedia.org/T254031 (10Naike) [21:16:07] 10MediaWiki-Codesniffer: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Daimona) >>! In T264948#6530715, @Umherirrender wrote: > Sounds good, I would also say that autofix seems bad here, because it is not always clear that object and stdClass are the same here Ah,... [21:20:21] 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.12 deployment blockers - https://phabricator.wikimedia.org/T263178 (10hashar) [21:20:23] 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T263177 (10hashar) [21:21:43] 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.12 deployment blockers - https://phabricator.wikimedia.org/T263178 (10hashar) 05Open→03Declined wmf.12 is cancelled since wmf.11 hasn't been rolled yet. See https://lists.wikimedia.org/pipermail/wikitech-l/2... [21:22:36] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments: 1.36.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T263179 (10hashar) [21:22:40] 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T263177 (10hashar) [21:23:10] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments: 1.36.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T263179 (10hashar) 1.36.0-wmf.12 is cancelled. We will do wmf.11 and then wmf.13. See https://lists.wikimedia.org/pipermail/wikitech-l/2020-October/093944.html [21:38:41] 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T263177 (10hashar) [21:45:37] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:54:02] hashar: James_F I've been creating a couple of the mw1.36 milestones for releasetaggerbot to keep working (last week it stopeed due to missing wmf.12) -- given that .12 is cancelled, shall any of those tags be renamed or deleted? [21:54:35] (03PS1) 10Daimona Eaytoy: Write HISTORY for 32.0.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 [21:54:45] hauskatze: I have no idea ;) [21:55:01] I guess they can be moved to wmf.13 yes [21:55:12] Maybe James would know [21:55:14] I never use those wmf tags myself [21:55:26] I only rely on the subtasks system [21:55:27] Me neither, but ReleaseTaggerBot does [22:01:01] hauskatze: No just leave them please. [22:01:15] wmf.14 is happening but wmf.15 maybe isn't. [22:01:27] I've lost track of when the data centre switch is happening. [22:01:54] (03CR) 10Daimona Eaytoy: [C: 03+1] "I agree with the intent here, especially for strchr (as you mentioned) and ini_alter (which I didn't even know existed, and seem completel" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/630080 (owner: 10Thiemo Kreuz (WMDE)) [22:03:10] James_F: okay, it was to unbreak forrestbot last week only [22:03:24] Yes, I know. [22:03:34] I get the "this went wrong" e-mails. [22:03:40] Went to fix, and you'd created. :-) [22:03:44] OTOH would it be possible to `truncate` the logs a bit? [22:04:02] I leave the coding side to Merlijn. [22:04:07] Unless you want them that way in which case I'll just s.t.f.u. [22:04:32] They are rather noisy, aren't they? [22:05:31] I don't hear them from my place :-) [22:06:25] If logrotate works in Toolforge (?) Merjlin could try to setup a rotation or truncate so the pages ain't that large [22:06:50] Pages? [22:06:58] forrestbot.err/out [22:06:59] Oh, I guess the logs are on the Web? [22:07:04] I just read them from the filesystem. [22:07:09] And the e-mails. [22:07:13] https://forrestbot.toolforge.org [22:07:15] So. Many. E-mails. [22:08:03] at least the output log has timestamps which makes it easy to search [22:11:30] (03CR) 10Daimona Eaytoy: [C: 04-1] "I should note that this approach is not really scalable (as opposed to e.g. a generic method checking a list of forbidden types), but give" (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [22:21:06] (03CR) 10HitomiAkane: "> Patch Set 8: Code-Review+2" [integration/config] - 10https://gerrit.wikimedia.org/r/631228 (https://phabricator.wikimedia.org/T235286) (owner: 10HitomiAkane) [22:23:52] (03CR) 10Daimona Eaytoy: "I'm a bit concerned about the performance of this sniff, if considering:" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [22:35:35] hauskatze: can you file a bug for log truncation/rotation? [22:52:56] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [22:56:50] (03PS6) 10DannyS712: Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) [22:56:52] (03CR) 10DannyS712: Expand FunctionCommentSniff to error on `object` typehints (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [22:59:23] (03CR) 10jerkins-bot: [V: 04-1] Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [23:01:31] (03PS7) 10DannyS712: Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) [23:04:50] (03CR) 10Daimona Eaytoy: Detect problems with @codingStandardsIgnore(Start|End) tags (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:06:33] (03CR) 10Daimona Eaytoy: [C: 03+1] "Looks fine, let's wait for some other thoughts before moving on though" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [23:09:31] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:12:56] (03PS8) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) [23:16:10] (03CR) 10jerkins-bot: [V: 04-1] Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:18:02] (03CR) 10Daimona Eaytoy: [C: 03+1] "On second thought, should we also include @var comments as per task description (I mistakenly wrote @property there)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [23:18:31] (03CR) 10DannyS712: Write HISTORY for 32.0.0 release (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:19:27] (03CR) 10Daimona Eaytoy: "Please feel free to amend my patch, I just went with a lame copypaste from git log" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:19:50] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:20:14] (03PS9) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) [23:23:36] (03CR) 10jerkins-bot: [V: 04-1] Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:27:26] (03CR) 10Daimona Eaytoy: Detect problems with @codingStandardsIgnore(Start|End) tags (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:30:39] (03PS2) 10DannyS712: Write HISTORY for 32.0.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:30:50] (03CR) 10DannyS712: Write HISTORY for 32.0.0 release (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:31:07] (03CR) 10DannyS712: "> Patch Set 1:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:34:57] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:39:43] (03CR) 10Daimona Eaytoy: Detect problems with @codingStandardsIgnore(Start|End) tags (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [23:40:26] (03CR) 10DannyS712: [C: 03+1] Add some more function aliases to ForbiddenFunctions sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/630080 (owner: 10Thiemo Kreuz (WMDE)) [23:40:57] (03CR) 10Daimona Eaytoy: [C: 03+1] "Changes look good" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [23:45:23] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712)