[07:09:02] 10MediaWiki-Codesniffer, 10Patch-For-Review: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10thiemowmde) To be honest I can't fully follow the arguments given in the task description. I have seen examples like the mentioned `TypeA|TypeB` several times, even wrote th... [07:16:25] (03CR) 10Thiemo Kreuz (WMDE): "I believe I understand the motivation, but I'm afraid I can't support this addition for the reasons explained in T264948#6531623. `object`" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [07:52:49] Yippee, build fixed! [07:52:50] Project mwcore-phpunit-coverage-master build #959: 09FIXED in 4 hr 52 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/959/ [09:15:31] maintenance-disconnect-full-disks build 219109 integration-agent-docker-1012 (/: 17%, /srv: 98%, /var/lib/docker: 43%): OFFLINE due to disk space [09:20:28] maintenance-disconnect-full-disks build 219110 integration-agent-docker-1012 (/: 17%, /srv: 96%, /var/lib/docker: 37%): still OFFLINE due to disk space [09:25:29] maintenance-disconnect-full-disks build 219111 integration-agent-docker-1012 (/: 17%, /srv: 5%, /var/lib/docker: 37%): RECOVERY disk space OK [10:55:15] 10MediaWiki-Codesniffer, 10Patch-For-Review: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Daimona) >>! In T264948#6531623, @thiemowmde wrote: > To be honest I can't fully follow the arguments given in the task description. I have seen examples like the mentioned... [11:00:22] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10Maps, 10Product-Infrastructure-Team-Backlog, 10Patch-For-Review: [Bug] Puppet is failing for maps beta cluster - could not find group maps-admins - https://phabricator.wikimedia.org/T263726 (10hnowlan) Hard to say what happened before - It might have been man... [11:10:26] (03CR) 10Daimona Eaytoy: "I should also note that I got confused with @codeCoverageIgnore annotations. Most arguments are still valid (the fact that people will che" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [11:39:07] (03CR) 10Lars Wirzenius: [C: 03+1] "Only voting CR+2 to let Bryan and Tyler have their say." [tools/scap] - 10https://gerrit.wikimedia.org/r/632968 (https://phabricator.wikimedia.org/T265060) (owner: 10Ahmon Dancy) [11:43:42] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10hnowlan) [11:48:03] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10hnowlan) [11:48:40] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10hnowlan) I suspect some or all of the Kafka hosts (it's required for changeprop to behave normally) need to be kept but I don't know which. [12:20:16] (03PS1) 10Lars Wirzenius: refactor: add some quotes to guard against bad shell expansions [tools/train-dev] - 10https://gerrit.wikimedia.org/r/633171 [15:11:35] 10MediaWiki-Codesniffer, 10Patch-For-Review: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10thiemowmde) I realized I misunderstood this task. This is not about disallowing `object` as a strict type hint in code, but only about PHPDoc blocks. This makes a lot of wha... [15:17:22] (03CR) 10Thiemo Kreuz (WMDE): "Correction: I misunderstood the task. This is not about "blocking people from using object as a type hint". Sorry. See T264948#6532700." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [15:30:59] (03CR) 10Ahmon Dancy: refactor: add some quotes to guard against bad shell expansions (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/633171 (owner: 10Lars Wirzenius) [15:41:30] (03CR) 10Lars Wirzenius: refactor: add some quotes to guard against bad shell expansions (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/633171 (owner: 10Lars Wirzenius) [15:50:23] (03CR) 10Ahmon Dancy: [C: 03+2] refactor: add some quotes to guard against bad shell expansions (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/633171 (owner: 10Lars Wirzenius) [15:50:26] (03CR) 10Ahmon Dancy: [V: 03+2 C: 03+2] refactor: add some quotes to guard against bad shell expansions [tools/train-dev] - 10https://gerrit.wikimedia.org/r/633171 (owner: 10Lars Wirzenius) [16:09:29] 10Gerrit: Cannot see my own changesets - https://phabricator.wikimedia.org/T264657 (10Amd989) Sorry about not following the established process to report a bug, I was just quickly jotting down what I was experiencing. I'm using a range of different browsers and incognito sessions in each (Edge, Chrome, Firefox)... [16:13:12] (03PS1) 10Lars Wirzenius: fix: find plugins again [tools/scap] - 10https://gerrit.wikimedia.org/r/633205 (https://phabricator.wikimedia.org/T248490) [16:14:53] (03CR) 10Lars Wirzenius: "This fixes the Scap can't-find-plugins problem. Once this is merged and included in a Scap release, we can drop the plugins from mediawiki" [tools/scap] - 10https://gerrit.wikimedia.org/r/633205 (https://phabricator.wikimedia.org/T248490) (owner: 10Lars Wirzenius) [16:15:24] (03CR) 10jerkins-bot: [V: 04-1] fix: find plugins again [tools/scap] - 10https://gerrit.wikimedia.org/r/633205 (https://phabricator.wikimedia.org/T248490) (owner: 10Lars Wirzenius) [16:30:46] (03CR) 10Jforrester: "> Patch Set 1:" [tools/scap] - 10https://gerrit.wikimedia.org/r/633205 (https://phabricator.wikimedia.org/T248490) (owner: 10Lars Wirzenius) [16:38:51] 10MediaWiki-Codesniffer, 10Patch-For-Review: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Daimona) >>! In T264948#6532700, @thiemowmde wrote: > I realized I misunderstood this task. This is not about disallowing `object` as a strict type hint in code, but only ab... [17:10:31] (03PS2) 10Lars Wirzenius: fix: find plugins again [tools/scap] - 10https://gerrit.wikimedia.org/r/633205 (https://phabricator.wikimedia.org/T248490) [17:49:55] greg-g: thcipriani: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/632984 needs to be live by the time the train is deployed, and it could use a gradual rollout (I'm not sure about the log volume, and it might also cause some extra session store traffic). Is it OK to deploy it today? [17:54:55] also, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/633209 is a trivial followup to that patch that could use a +2 (not that urgent, it just changes what data is blocked) [17:56:29] +2'd the latter [18:00:46] twentyafterfour: I made a slowvote poll at https://phabricator.wikimedia.org/V24 and some folks are telling me that they get an "Access Denied: Restricted Application" when they follow the link. Do you remember if there is some trick needed to make a slowvote visible to everyone? [18:24:01] tgr_: re the deployment of that logging change today: I'd want to get feedback from SRE/those who care about logging infrastructure since it's Friday and this has been touchy. I'm conceptually fine with it. [18:24:03] cc thcipriani ^ [18:24:48] twentyafterfour: I figured it out. :) [18:25:07] @everyone: I'm running a poll on MediaWiki-Vagrant adoption at T265164. Your participation would be appreciated! [18:25:08] T265164: Evaluate usage of MediaWiki-Vagrant by technical contributors - https://phabricator.wikimedia.org/T265164 [18:47:55] tgr_: sorry, I was afk for a few, +1 to what greg-g said (which seems to be in discussion now) [19:00:58] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10nnikkhoui) @Jdforrester-WMF I came across this ticket as I was facing a similar issue in Vector when working on T257582. Vector has hard coded the version of node to 10.... [19:08:11] what ddid you have in mind tgr_ by a gradual rollout? (feel free to answer in the other channel, I'm just repeating the q here because I see you're in here now) [19:40:39] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 (10Andrew) *bump* I would love to see this VM deleted since it confuses cumin (T222480) [19:45:42] bd808: In case you want to compare results with the dev satisfaction survery, there are graphs here on which environments people have tried and which they regularly use: https://www.mediawiki.org/wiki/Developer_Satisfaction_Survey/2020#Local_Development_Environment [19:47:05] thanks longma [19:53:36] (03PS10) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) [19:53:54] (03CR) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) (owner: 10DannyS712) [20:19:40] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): Set up experimental Docker registry in integration project - https://phabricator.wikimedia.org/T262453 (10dduvall) 05Open→03Resolved [20:19:42] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10dduvall) [20:25:54] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Refactor PipelineLib to allow for alternate docker image pusher - https://phabricator.wikimedia.org/T265177 (10dduvall) [20:26:57] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Refactor PipelineLib to allow for alternate docker image pusher - https://phabricator.wikimedia.org/T265177 (10dduvall) [20:26:59] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): Configure Zuul to trigger PipelineLib based pipelines during gate-and-submit for a few MW components - https://phabricator.wikimedia.org/T262460 (10dduvall) [20:27:01] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10dduvall) [20:42:41] 10Release-Engineering-Team, 10Vue.js (Vue.js-Search): Work with RelEng to add PipelineBot to Vector - https://phabricator.wikimedia.org/T257582 (10nnikkhoui) @dduvall In looking at the jobs [[ https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L2375 | currently configured ]] to run in... [20:46:03] Why is sonarcloud failing this (initial gerrit) patch? The link is a 404. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikispeechSpeechDataCollector/+/609518 [20:46:20] https://sonarcloud.io/dashboard?id=mediawiki-extensions-WikispeechSpeechDataCollector&branch=609518-36&resolved=false [20:46:28] Do I need to set something up somewhere? [20:54:31] I think the project needs to be added in SonarCloud? [20:58:19] maybe someone from QTE can help [21:10:10] 10Release-Engineering-Team, 10Vue.js (Vue.js-Search): Work with RelEng to add PipelineBot to Vector - https://phabricator.wikimedia.org/T257582 (10dduvall) >>! In T257582#6533702, @nnikkhoui wrote: > To get Vector using PipelineLib, I'm adding a blubber.yaml with a test variant. But would you suggest removing... [22:31:58] (03CR) 10BryanDavis: get_realm_specific_filename doesn't handle datacenter correctly (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/632968 (https://phabricator.wikimedia.org/T265060) (owner: 10Ahmon Dancy) [23:11:34] (03PS7) 10Brennen Bearnes: Split php-fpm and apache2 containers [releng/dev-images] - 10https://gerrit.wikimedia.org/r/622575 (https://phabricator.wikimedia.org/T245444) [23:25:08] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: upgrade MediaWiki appservers to Debian 10 (buster) - https://phabricator.wikimedia.org/T245757 (10Dzahn) A new ticket for this has been created at T264991.