[07:13:47] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T263182 (10Nikerabbit) [13:11:18] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments: 1.36.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T263180 (10LarsWirzenius) Reported {T266234} but not as a blocker. [14:43:12] (03CR) 10Ahmon Dancy: [C: 03+1] Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [16:15:44] helloo! would anyone be around to help me out with adding a new credential to jenkins? [16:34:51] (03PS2) 10Dduvall: Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) [16:38:52] (03CR) 10Ahmon Dancy: [C: 03+1] Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [17:02:19] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Patch-For-Review, 10Sustainability (Incident Followup): Add option in Scap to skip restarting php-fpm for emergency deployments - https://phabricator.wikimedia.org/T243009 (10jijiki... [17:43:10] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Patch-For-Review, 10Sustainability (Incident Followup): Add option in Scap to restart php-fpm for emergency deployments, and skip depoolin... - https://phabricator.wikimedia.org/T243009 [17:47:43] (03PS3) 10Dduvall: Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) [17:47:45] (03PS1) 10Dduvall: Changed node label for configuration parsing to "pipelinelib" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635873 [17:51:39] nikkinikk: did you get the help you needed? [17:52:07] i did! longma helped me out [17:52:37] Thanks for checkin [17:54:28] (03CR) 10Ahmon Dancy: [C: 04-1] Accept runner overrides when constructing a PipelineBuilder (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [17:56:55] (03CR) 10Dduvall: Accept runner overrides when constructing a PipelineBuilder (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [17:58:11] (03CR) 10Dduvall: Accept runner overrides when constructing a PipelineBuilder (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:07:14] (03CR) 10Ahmon Dancy: [C: 03+1] Accept runner overrides when constructing a PipelineBuilder (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:07:16] (03CR) 10Dduvall: Accept runner overrides when constructing a PipelineBuilder (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:17:00] (03CR) 10Ahmon Dancy: [C: 03+2] Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:17:46] (03CR) 10Ahmon Dancy: [C: 03+2] Allow for standard docker pushes with authentication [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/634336 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:18:18] (03Merged) 10jenkins-bot: Allow for standard docker pushes with authentication [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/634336 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:18:21] (03Merged) 10jenkins-bot: Accept runner overrides when constructing a PipelineBuilder [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635629 (https://phabricator.wikimedia.org/T265177) (owner: 10Dduvall) [18:19:12] (03CR) 10Ahmon Dancy: [C: 03+1] Changed node label for configuration parsing to "pipelinelib" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635873 (owner: 10Dduvall) [18:20:02] (03CR) 10Ahmon Dancy: [C: 03+2] Changed node label for configuration parsing to "pipelinelib" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635873 (owner: 10Dduvall) [18:21:14] (03Merged) 10jenkins-bot: Changed node label for configuration parsing to "pipelinelib" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635873 (owner: 10Dduvall) [18:26:38] (03CR) 10Jeena Huneidi: Fix openapi spec and include variant schema (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/634666 (owner: 10Dduvall) [18:30:02] (03CR) 10Dduvall: Fix openapi spec and include variant schema (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/634666 (owner: 10Dduvall) [18:32:17] 10Release-Engineering-Team (Logspam), 10CologneBlue, 10Wikimedia-production-error: Argument 1 passed to LinkRenderer::makeKnownLink() must implement interface LinkTarget, null given, called in CologneBlueTemplate.php - https://phabricator.wikimedia.org/T266181 (10matmarex) Caused by c9a1a6f233cb2512949d77011... [18:36:17] 10Release-Engineering-Team (Logspam), 10CologneBlue, 10Wikimedia-production-error: Argument 1 passed to LinkRenderer::makeKnownLink() must implement interface LinkTarget, null given, called in CologneBlueTemplate.php - https://phabricator.wikimedia.org/T266181 (10matmarex) a:03matmarex [19:04:41] 10Release-Engineering-Team (Logspam), 10MassMessage, 10Wikimedia-production-error: Cannot diff content types other than MassMessageListContent - https://phabricator.wikimedia.org/T265524 (10Umherirrender) See also T231084 where also two different contens are diffed (but one is not text), but it shows the sam... [19:06:05] 10Release-Engineering-Team (Logspam), 10CologneBlue, 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), 10Patch-For-Review, 10Wikimedia-production-error: Argument 1 passed to LinkRenderer::makeKnownLink() must implement interface LinkTarget, null given, called in Colog... - https://phabricator.wikimedia.org/T266181 [19:06:45] 10Release-Engineering-Team (Logspam), 10CologneBlue, 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), 10Patch-For-Review, 10Wikimedia-production-error: Argument 1 passed to LinkRenderer::makeKnownLink() must implement interface LinkTarget, null given, called in Colog... - https://phabricator.wikimedia.org/T266181 [19:54:25] (03PS1) 10Dduvall: Skip submodules during internal configure stage [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 [20:02:05] (03CR) 10Dduvall: [C: 04-1] "Doesn't avoid updating first level of submodules, only recursive ones. I'll need to refactor." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 (owner: 10Dduvall) [20:12:40] (03PS2) 10Dduvall: Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 [20:13:28] (03CR) 10jerkins-bot: [V: 04-1] Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 (owner: 10Dduvall) [20:14:56] (03PS3) 10Dduvall: Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 [20:15:19] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Patch-For-Review, 10Sustainability (Incident Followup): Add option in Scap to restart php-fpm for emergency deployments, and skip depoolin... - https://phabricator.wikimedia.org/T243009 [20:40:22] 10Project-Admins, 10Design-Research: Archive Design-Research's "Prototyping Labs"? - https://phabricator.wikimedia.org/T263257 (10Aklapper) a:03Aklapper [20:41:44] 10Project-Admins, 10Design-Research: Archive Design-Research's "Prototyping Labs"? - https://phabricator.wikimedia.org/T263257 (10Aklapper) 05Open→03Resolved Project tag archived as per message from Ka Yun, and page updated in https://www.mediawiki.org/w/index.php?title=Wikimedia_Research/Design_Research/P... [20:56:17] 10Project-Admins, 10PM: Mass-migrate project tags for parsing team - https://phabricator.wikimedia.org/T245868 (10ssastry) 05Open→03Resolved We archived the parsing-team tag. [22:03:40] (03PS1) 10Ahmon Dancy: scap/php_fpm.py: Clarify some code [tools/scap] - 10https://gerrit.wikimedia.org/r/635896 [22:05:29] (03PS1) 10Ahmon Dancy: scap: Add support for ungraceful php-fpm restart during --force sync [tools/scap] - 10https://gerrit.wikimedia.org/r/635897 (https://phabricator.wikimedia.org/T243009) [22:06:32] There is a bootstrap issue when adding a new deployment server. puppet will try to run a bunch of "scap deploy --init" commands but they all fail because ""Not the active deployment server" but also we don't want to switch the deployment server before the repos are initialized [22:08:49] mutante: Hmm. Did train-dev run into that issue, dancy? [22:10:14] No, but I haven't actually tried running `scap deploy`. [22:10:59] I don't remember if it happened when we did "tin -> deploy1001". [22:11:15] But we have to schedule a window to switch deployment server anyways. [22:11:27] so I guess then we can as well just switch and init [22:11:50] currently debating if I should already open firewall on appservers for it or wait.. [22:12:06] maybe all at once [22:12:59] also .. .you could say a week without deployments is either the best or the worst time to do it :) [22:14:12] (03CR) 10Ahmon Dancy: [C: 03+1] Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 (owner: 10Dduvall) [22:16:44] (03CR) 10Dduvall: [C: 04-2] "I'm getting 500s from Diffusion when I try to do shallow submodule updates on Wikibase, and I'll have to look into it before getting this " [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 (owner: 10Dduvall) [22:17:20] 10Diffusion, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Developer Productivity: Reduce task notification noise/frequency of changes to associated open patchsets - https://phabricator.wikimedia.org/T143162 (10Krinkle) This task is about the Phabricator's Diffusion... [22:17:46] mutante: Switching on Monday and not finding out it broke the world for eight days isn't ideal, certainly. ;-) [22:19:22] James_F: yea.. that's right. not "surprise for the the first regular deployment after a break".. I should send an email because it's "meta deployment window" [22:19:29] * James_F nods. [22:19:35] Though next week is a no-deploy-week. [22:20:18] does "deploy deployment_server" count as deploy? guess so :) [22:20:34] SRE are always exempt. :-) [22:21:42] heh, but having a scap specialist around helps [22:21:53] All of RelEng are out next week. [22:21:59] (Virtual offsite.) [22:22:23] alright, alright, this will be on hold for a while. not pushing this through as a surprise [22:22:28] * James_F nods. [22:22:32] just happening because i got the hardware [22:22:45] it crossed the treshold for refresh [22:22:46] Is this deploy2001 or deploy1002? [22:23:00] (Do we have codfw deploy servers? Have we ever used them?) [22:23:14] deploy1002 [22:23:17] yes, we do [22:23:25] deploy2001 will be replaced with deploy2002 as well [22:23:29] Right. [22:23:43] both.. just the eqiad one is here already and the other is about to be ordered [22:23:52] * James_F nods. [22:23:58] unlike before they will have SSDs, btw [22:24:04] half a terabyte [22:24:15] currently we just use 10% of 1TB HDD [22:24:29] Will they be buster machines, or still stretch? [22:24:47] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Parsoid, 10Patch-For-Review, 10User-brennen: mediawiki-vendor submodule doesn't get automatically bumped on release branches - https://phabricator.wikimedia.org/T259832 (10cscott) This is... [22:25:01] stretch for this quarter because "mediawiki to buster" is WIP and a deployment_server also include MW appserver code [22:25:16] will be upgraded together with appservers or right after [22:25:32] * James_F nods. [22:25:50] I was a bit apprehensive about the deployment server having a different OS to the rest of the appserver cluster, yeah. [22:25:53] fwiw, I did add it to "mediawiki-installation" "dsh" group.. and scap pulled.. so it can pop up during deployment [22:26:10] Ack. [22:26:13] but just like any other appserver .. and it won't do anything [22:27:17] yea, it's also because the puppet role for a deployment_server does "include profile::mediawiki::common" [22:27:36] but making that work on buster is an OKR [22:28:37] * James_F nods. [22:45:20] Having ssd on the deploy server should make scap faster. The i18n build step is very much iops constrained. [22:46:29] +1 - and this one is about the age of hardware and warranty [23:19:19] 10Gerrit: Please create operations/ecs Gerrit repository - https://phabricator.wikimedia.org/T266296 (10colewhite) [23:28:15] 10Gerrit: Please create operations/ecs Gerrit repository - https://phabricator.wikimedia.org/T266296 (10Dzahn) Could you hit the request button on https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests ? It usually gets done within the same day or next day.