[01:12:54] (03PS4) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [01:17:44] (03PS2) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [01:37:14] (03PS5) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [01:42:05] (03PS3) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [02:40:41] 10Continuous-Integration-Config, 10Security-Team: Add ci to wikimedia/security/tooling/peek - https://phabricator.wikimedia.org/T266424 (10Reedy) [02:47:14] (03PS1) 10Reedy: Add tox-docker to wikimedia/security/tooling/peek [integration/config] - 10https://gerrit.wikimedia.org/r/636229 (https://phabricator.wikimedia.org/T266424) [02:53:12] (03CR) 10Reedy: [C: 03+2] Add tox-docker to wikimedia/security/tooling/peek [integration/config] - 10https://gerrit.wikimedia.org/r/636229 (https://phabricator.wikimedia.org/T266424) (owner: 10Reedy) [02:54:18] (03Merged) 10jenkins-bot: Add tox-docker to wikimedia/security/tooling/peek [integration/config] - 10https://gerrit.wikimedia.org/r/636229 (https://phabricator.wikimedia.org/T266424) (owner: 10Reedy) [02:54:52] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/636229 T266424 [02:54:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:54:56] T266424: Add ci to wikimedia/security/tooling/peek - https://phabricator.wikimedia.org/T266424 [02:55:46] 10Continuous-Integration-Config, 10Security-Team, 10Patch-For-Review: Add ci to wikimedia/security/tooling/peek - https://phabricator.wikimedia.org/T266424 (10Reedy) 05Open→03Resolved a:03Reedy [03:09:54] (03PS6) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [03:11:13] (03PS4) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [08:11:29] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations: Increase on database writes and deletes activity on Commonswiki lead to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) [08:11:39] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations: Increase on database writes and deletes activity on Commonswiki lead to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) p:05Triage→03Medium [08:12:08] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations: Increase on database writes and deletes activity on Commonswiki lead to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) p:05Medium→03High Setting to high as this might be causing cross dc lag [08:12:29] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) [08:53:25] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) [09:01:56] (03PS7) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [09:02:32] (03PS5) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [09:28:11] PipelineBot reports that a Docker image was built, but where does it go? :D [09:28:14] https://gerrit.wikimedia.org/r/c/mediawiki/services/wikispeech/mishkal/+/635506 [09:58:02] it's there [09:59:04] docker pull docker-registry.wikimedia.org/wikimedia/mediawiki-services-wikispeech-mishkal:2020-10-21-115532-production on my laptop produces a pile of output, happily downloading away [09:59:07] kalle: [10:05:48] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10Daimona) Note, as I wrote in the other task: interestingly, codehealth jobs are not affected, in that these tests fail corre... [10:26:33] apergos: Aha, I was expecting it to show up at https://dockerregistry.toolforge.org/ [10:26:53] I don't know how often that gets updated [10:27:12] But it's supposed to show up there sooner or later? [10:28:15] you could ask thcipriani about the tool [10:28:32] wrong tz now I think, but when he's around [10:28:49] and I think it should show up on the list but that's only my theory :- [10:28:50] D [10:28:53] Cool, thanks :) [10:50:02] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10jcrespo) Adding #Wikimedia-production-error as it seems to coincide with a... [10:55:56] 10Phabricator: Delete junk portals - https://phabricator.wikimedia.org/T266414 (10Bugreporter) At least the right to create portal should be restricted. [10:56:58] !log Upgrading containerd.io from 1.2.10 to 1.2.13-2 on integration-agent-docker-1001, integration-agent-docker-1002, integration-agent-docker-1003, integration-agent-docker-1004 # T265615 [10:57:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:57:02] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 [11:03:32] !log Bring back integration-agent-docker-1020 . It is not the only one affected by T265615 which probably rules out Ceph as the slowness root cause (T260916) [11:03:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:03:36] T260916: Move CI instances to use ceph in WMCS - https://phabricator.wikimedia.org/T260916 [11:03:36] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 [11:12:09] !log Upgrading containerd.io from 1.2.10 to 1.2.13-2 on integration-agent-docker-1005, integration-agent-docker-1006, integration-agent-docker-1007, integration-agent-docker-1008 # T265615 [11:12:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:12:13] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 [11:23:49] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) >>! In T266441#6577664, @Daimona wrote: > Note, as I wrote in the other task: interestingly, codehealth jobs are no... [11:28:52] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) For la... [11:34:58] hi! I'm not sure if that's the correct place to ask this question, but I'd like to base a blubber enabled project on a 3rd party docker image, provided on docker hub - can I do that? we are currently adding blubber to the project (https://gerrit.wikimedia.org/r/c/wikidata/query/rdf/+/635074) but I was wondering if we have to replicate original dockerfile here (I'd rather base of their image to reduce future maintenance) [11:35:13] 10Project-Admins, 10cloud-services-team (Kanban): Update VPS subproject list - https://phabricator.wikimedia.org/T266461 (10PerfektesChaos) [11:48:44] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) Hmm, so: `vendor/bin/phpunit --testsuite=core:unit,extensions:unit` -- no errors `vendor/bin/phpunit --testsuite=... [11:50:16] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) I have... [11:55:36] 10Release-Engineering-Team, 10Wikimedia-Site-requests, 10User-Nikerabbit: Need an easy way to get list of wikis using Translate - https://phabricator.wikimedia.org/T266097 (10Urbanecm) This would be done automagically once once the YAML migration is done - the releng's aim is to have configuration stored sta... [12:00:00] !log Upgrading docker-ce to 19.03.13 and containerd to 1.3.7 on integration-agent-docker-1001, integration-agent-docker-1002, integration-agent-docker-1003 and integration-agent-docker-1004 # T265615 [12:00:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:00:04] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 [12:13:11] 10Project-Admins, 10cloud-services-team (Kanban): Update VPS subproject list - https://phabricator.wikimedia.org/T266461 (10Nintendofan885) [12:24:25] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) >>! In T266432#6577770, @jcrespo wrote: > Adding #Wikimedia-pr... [13:24:04] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) OK, it looks like if you remove `tests/phpunit/unit/includes/language/SpecialPageAliasTest.php` then the AbuseFilte... [13:25:06] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) One idea is to adjust quibble so that LocalSettings.php is moved out of the way before the unit tests run. [14:18:41] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10jcrespo) I am getting strange, inconsistent results every time I check, no... [14:19:04] 10Release-Engineering-Team, 10Growth-Structured-Tasks, 10Growth-Team, 10serviceops: Move dedcode/mwaddlink from github to gerrit - https://phabricator.wikimedia.org/T261403 (10kostajh) 05Open→03Resolved [14:36:06] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10thcipriani) > Was something released that 22nd Oct? Commonswiki was updat... [14:45:07] (03PS1) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) [14:46:58] (03CR) 10jerkins-bot: [V: 04-1] Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [14:48:09] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble, 10Patch-For-Review: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10Daimona) >>! In T266441#6578243, @kostajh wrote: > OK, it looks like if you remove `tests/phpunit/unit... [14:52:53] (03PS2) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) [14:54:17] (03CR) 10jerkins-bot: [V: 04-1] Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [14:56:32] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer v32.0.0 - https://phabricator.wikimedia.org/T266476 (10Reedy) [14:57:09] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble, 10Patch-For-Review: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) >>! In T266441#6578491, @Daimona wrote: >>>! In T266441#6578243, @kostajh wrote: >> OK, it lo... [14:59:28] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10thcipriani) Adding @LarsWirzenius in-case he remembers anything deploying... [15:01:41] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer v32.0.0 - https://phabricator.wikimedia.org/T266476 (10Reedy) p:05Triage→03High Marking this high, as I think it's probably overdue at this point :) Any known blockers/stuff still to be done? [15:02:32] 10MediaWiki-Codesniffer, 10User-DannyS712: Please support dealerdirect/phpcodesniffer-composer-installer - https://phabricator.wikimedia.org/T265735 (10Reedy) 05Open→03Resolved a:03DannyS712 [15:09:20] 10Phabricator-Bot-Requests, 10Release-Engineering-Team, 10Security-Team: Reclaim @security_team_bot - https://phabricator.wikimedia.org/T265923 (10Reedy) 05Open→03Resolved a:03Reedy [15:11:53] (03PS3) 10DannyS712: Write HISTORY for 32.0.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (owner: 10Daimona Eaytoy) [15:14:54] (03PS4) 10DannyS712: Write HISTORY for 32.0.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:15:22] (03CR) 10DannyS712: "I rebased and updated for the latest changes, as well as tagging T266476" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:16:25] (03CR) 10Daimona Eaytoy: [C: 03+1] "Leaving to someone else for the final review" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:20:51] (03PS5) 10Reedy: Write HISTORY for 32.0.0 release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:20:53] (03CR) 10Legoktm: [C: 03+2] Use new T_NULLSAFE_OBJECT_OPERATOR (?->) to prepare for php8 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636126 (owner: 10Umherirrender) [15:21:05] (03CR) 10Reedy: [C: 03+2] "WFM" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:21:07] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Release: Release mediawiki-codesniffer v32.0.0 - https://phabricator.wikimedia.org/T266476 (10DannyS712) [15:21:49] (03CR) 10Legoktm: [C: 03+2] handle backslash-prefixed is_null usage [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/631989 (owner: 10MMoll) [15:21:51] (03Merged) 10jenkins-bot: Use new T_NULLSAFE_OBJECT_OPERATOR (?->) to prepare for php8 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636126 (owner: 10Umherirrender) [15:22:08] (03CR) 10Reedy: "RM +2 due to [15:20:53] (CR) Legoktm: [C: +2] Use new T_NULLSAFE_OBJECT_OPERATOR (?->) to prepare for php8 [tools/codesniffer] " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:22:13] Reedy: oh wait, I just merged a bit more [15:22:18] sorry [15:22:23] legoktm: Heh, yeah, I saw :) [15:22:23] I'll regenerate the changelog [15:22:42] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636372 (https://phabricator.wikimedia.org/T266476) (owner: 10DannyS712) [15:23:35] (03CR) 10Daimona Eaytoy: "> Patch Set 5:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:24:37] wasn't sure if it should be done as part of the HISTORY update, so sent a separate patch - https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/636372 updates the readme to reflect the new version, and should probably be merged before 32 is tagged [15:24:57] (03CR) 10Daimona Eaytoy: [C: 03+2] Update README for version 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636372 (https://phabricator.wikimedia.org/T266476) (owner: 10DannyS712) [15:25:25] (03PS8) 10Legoktm: Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [15:25:32] (03CR) 10Legoktm: [C: 03+2] Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [15:25:34] Reedy / DannyS712: will you tag the release once the race condition thing is resolved? Or shall I? [15:26:11] (03CR) 10Legoktm: [C: 04-2] "Let's just squash this in with the parent" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636372 (https://phabricator.wikimedia.org/T266476) (owner: 10DannyS712) [15:26:21] I have no idea how to tag things, and would rather not break it, but if you or Reedy can document what you do for next time I'll be able to help [15:27:41] git tag -s 32.0.0 && git push --tags [15:28:02] I don't have it checked out locally - I do (almost) everything using the gerrit web interface [15:28:27] (03Merged) 10jenkins-bot: Expand FunctionCommentSniff to error on `object` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632993 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [15:28:38] (03CR) 10Legoktm: [C: 03+2] Add PropertyDocumentationSniff to validate @var on class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/619304 (owner: 10Umherirrender) [15:29:10] 10MediaWiki-Codesniffer, 10User-DannyS712: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10DannyS712) 05Open→03Resolved a:03DannyS712 [15:30:22] (03PS16) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [15:30:30] (03Merged) 10jenkins-bot: Add PropertyDocumentationSniff to validate @var on class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/619304 (owner: 10Umherirrender) [15:31:16] (03CR) 10Legoktm: [C: 03+2] "This seems a little obscure but I'm assuming you only wrote this because you actually ran into it in the wild." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [15:32:07] (03Merged) 10jenkins-bot: Report particularly confusing assertNotEquals( false ) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [15:32:22] (03CR) 10Legoktm: [C: 03+2] "Would be nice to have tests for this in the future." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603496 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [15:33:04] legoktm can you take a look at including https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/593980/ in the patches you're merging before the release? [15:33:10] (03Merged) 10jenkins-bot: Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603496 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [15:33:14] yes [15:33:42] thanks [15:34:14] (03PS11) 10DannyS712: Detect problems with @codingStandardsIgnore(Start|End) tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/632011 (https://phabricator.wikimedia.org/T127241) [15:34:25] (03CR) 10Legoktm: [C: 04-1] Move FunctionCommentSniff EmptySees check to new EmptyTagSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [15:36:21] (03PS17) 10Legoktm: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [15:36:26] (03CR) 10Legoktm: [C: 03+2] Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [15:36:45] (03PS5) 10Legoktm: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [15:37:16] (03Merged) 10jenkins-bot: Add a sniff for `$wg*` variables that aren't globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593617 (https://phabricator.wikimedia.org/T251443) (owner: 10DannyS712) [15:37:19] (03PS17) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) [15:37:21] (03CR) 10DannyS712: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [15:38:22] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) 05Open→03Resolved [15:40:16] (03CR) 10Legoktm: [C: 03+2] Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [15:40:49] (03CR) 10Legoktm: [C: 03+2] Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [15:40:51] (03CR) 10DannyS712: "Realized I forgot to include a license in the file" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [15:41:16] (03PS6) 10DannyS712: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) [15:41:42] (03CR) 10DannyS712: [C: 03+2] "restore +2 following comment-only change to add missing license" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [15:42:20] (03Merged) 10jenkins-bot: Move FunctionCommentSniff EmptySees check to new EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/593980 (https://phabricator.wikimedia.org/T250958) (owner: 10DannyS712) [15:42:34] (03Merged) 10jenkins-bot: Add UnaryMinusSpacing sniff to remove spaces after unary minus [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591425 (https://phabricator.wikimedia.org/T155627) (owner: 10DannyS712) [15:45:29] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636373 (owner: 10DannyS712) [15:45:31] any easy open stuff that I missed? [15:45:46] ^ forgot to include some license comments if you can merge that [15:46:14] I remembered to add it to the UnaryMinusSpacing sniff in time (before it merged) but for the others I didn't [15:46:17] (03CR) 10Legoktm: [C: 03+2] Add missing licenses to recent sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636373 (owner: 10DannyS712) [15:47:19] (03PS3) 10DannyS712: Add missing licenses to recent sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636373 [15:47:36] ^ also fixed a wrong word, sorry for the hassle - can you +2 again? [15:48:41] DannyS712: +2 it yourself :) that's fine [15:48:54] (03CR) 10DannyS712: [C: 03+2] "restore +2 after fixing a word" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636373 (owner: 10DannyS712) [15:48:59] I wasn't sure :) [15:49:43] (03PS4) 10DannyS712: handle backslash-prefixed is_null usage [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/631989 (owner: 10MMoll) [15:49:59] (03CR) 10DannyS712: [C: 03+2] "Poke - Jenkins couldn't handle the merge conflict, but gerrit could" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/631989 (owner: 10MMoll) [15:51:00] (03Merged) 10jenkins-bot: Add missing licenses to recent sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636373 (owner: 10DannyS712) [15:52:39] 10MediaWiki-Codesniffer, 10User-DannyS712: Add phpcs rule againt a space after unary minus operator - https://phabricator.wikimedia.org/T155627 (10DannyS712) 05Open→03Resolved [15:52:53] I'm doing the changelog now [15:53:18] https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/631989 is still merging, but other than that I think v.32 should be ready [15:53:41] though https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/628209 should be fairly simple to review if you have an extra minute or two [15:54:15] ^ add sniff for `final` and `private` on the same method [15:54:49] (03Merged) 10jenkins-bot: handle backslash-prefixed is_null usage [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/631989 (owner: 10MMoll) [15:56:02] legoktm just want to make sure you saw ^ regarding FinalPrivateSniff before its too late [15:56:34] I skimmed it, I'll leave it for the next time [15:56:40] (03PS6) 10Legoktm: Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:56:42] okay [15:56:42] (03CR) 10Legoktm: [C: 03+2] Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:57:06] (03Abandoned) 10Legoktm: Update README for version 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636372 (https://phabricator.wikimedia.org/T266476) (owner: 10DannyS712) [15:58:00] (03PS7) 10DannyS712: Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:58:11] hm? [15:58:34] oh [15:58:36] missing a word - "add to" -> "add sniff to" + reorder since I had put all of the new sniffs together [15:58:38] (03CR) 10DannyS712: [C: 03+1] Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [15:58:46] hope it was okay [15:59:21] I would have left a comment, but you already +2'ed it [15:59:46] LGTM in current form, will leave to legoktm for final merging [15:59:49] (and tagging) [16:07:01] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) We just had another huge spike of DELETEs {F32414787} [16:08:41] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: phpcs should error on unclosed @codingStandardsIgnoreStart annotations - https://phabricator.wikimedia.org/T127241 (10Umherirrender) This task was created before the new phpcs tags was there, so would be nice to have it for @phpcs / phpcs as well. [16:10:20] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: phpcs should error on unclosed @codingStandardsIgnoreStart annotations - https://phabricator.wikimedia.org/T127241 (10DannyS712) >>! In T127241#6578877, @Umherirrender wrote: > This task was created before the new phpcs tags was there, so would b... [16:21:06] (03PS10) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [16:21:22] (03PS11) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [16:27:45] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Operations, 10serviceops: Make a way to build Scap .deb in Docker - https://phabricator.wikimedia.org/T265501 (10jijiki) p:05High→03Low [16:29:33] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, 10Wikimedia-production-error: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10LarsWirzenius) @thcipriani Sorry, I have no recollection that anything tha... [16:37:45] (03CR) 10Jforrester: [C: 03+2] Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [16:38:46] (03Merged) 10jenkins-bot: Release 32.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/633028 (https://phabricator.wikimedia.org/T266476) (owner: 10Daimona Eaytoy) [16:42:30] James_F for ^ how does the new version get tagged? Is that something Daimona does? [16:47:15] DannyS712: Normally I do it or Daimona does it, yeah. Still slugging through my e-mails. [16:48:29] okay, thanks. Just wanted to make sure it didn't slip through the cracks - thanks [16:48:31] DannyS712: Done. [16:48:51] Yup, thank you [16:48:54] yay [16:49:06] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/codesniffer/+/refs/tags/v32.0.0 [16:49:10] now the only thing left I think is updating libup: https://gerrit.wikimedia.org/r/c/labs/libraryupgrader/config/+/636374 [16:49:35] also, is there a standard schedule for releases / should there be? [16:49:35] BTW, it's as easy as git tag -s "32.0.0" && git push --follow-tags :-) [16:49:41] DannyS712: Tsk. [16:50:20] DannyS712: We should do a manual update on at least one or two repos first to make sure it works, to avoid wasting too much LibUp time. [16:50:26] Daimona: `git tag -s v32.0.0 -m 'Signed v32.0.0 release'` please. ;-) [16:50:38] And -m, right :-) [16:50:42] I thought I was missing something [16:50:47] > I don't have it checked out locally - I do (almost) everything using the gerrit web interface [16:50:47] So I can't really use `git tag` [16:51:13] Yeah, and it should be signed, so you'll need GPG locally and a known key, ideally. [16:51:50] (and also -a. So it wasn't easy after all :-D) [16:52:06] -s implies -a AFAIK [16:54:28] does using the gerrit web interface to tag a new version not allow signing and adding a message? See tagged v32.0.0 of the sandbox repo - https://gerrit.wikimedia.org/r/plugins/gitiles/sandbox/ [16:54:43] Yeah, you don't need -a. [16:58:29] oh wait, it is possible to sign and add a message, you put it under the "annotations" for the tag - see https://gerrit.wikimedia.org/r/plugins/gitiles/sandbox/+/refs/tags/v32.0.1 - good to know, though I don't know how to sign stuff :) [17:00:57] Ah, thank you. [17:02:30] Re web interface: no idea. I've always used git-tag [17:10:39] legoktm thanks for merging the libup patch. I'm now added to all patches that change phpcs by reviewer-bot, so I should be able to review the changes that require manual +2 [17:11:38] :o that seems like a lot of notifications but alright [17:11:54] also watching changes to composer.json :) [17:11:58] re: schedule, I used to try to do them monthly, as long as ther were some changes [17:12:05] I spend why too much time on wiki stuff [17:12:06] there* [17:12:38] 09:50:20 DannyS712: We should do a manual update on at least one or two repos first to make sure it works, to avoid wasting too much LibUp time. <-- that's what the canary repos are for? [17:13:25] legoktm: Sure, but save the planet etc. ;-) [17:14:50] libup runs on every repo every day anyways, verifying that `composer test` etc still passes so :p [17:23:36] 10MediaWiki-Codesniffer, 10Release: Release mediawiki-codesniffer v32.0.0 - https://phabricator.wikimedia.org/T266476 (10DannyS712) 05Open→03Resolved [17:34:04] 10Release-Engineering-Team, 10Wikimedia-Site-requests, 10User-Nikerabbit: Need an easy way to get list of wikis using Translate - https://phabricator.wikimedia.org/T266097 (10Jdforrester-WMF) Yeah, right now every dblist you add slows down production, so there's a general ban on adding them unless they're cr... [17:46:37] longma: I'v basically had no time for the dev env / mwcli stuff at all in the last months. Where can I go to get the best overview of intended direction? [17:47:04] As expressed before I really think we should aim for what I was aiming for in the prototype port patches, but not sure what is actually going to end up happening? [17:47:15] you may also have an email in your inbox from someone else on this topic [17:48:11] addshore: I'm in a team "offiste" meeting but I will get back to you [17:48:18] ty :) [17:48:23] enjoy! [17:51:09] haha thanks [18:07:47] addshore: Sorry I'm not sure which patches you mean - can you point me to that? As far as general direction, I want to get the cli packaged for the various OSs so I'm planning to work on adding more basic features to that, which you can see on the workboard. I'm also planning to send an email to the local-dev list to get some help prioritizing other stuff on the board by awarding a token if people have interest [18:07:57] happy to chat more in a hangout if you want [18:10:04] There's also some docker image work being done here: https://gerrit.wikimedia.org/r/c/releng/dev-images/+/622575 [18:10:13] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) Same f... [18:11:09] So I guess the bulk of my question can be represented by looking at https://gerrit.wikimedia.org/r/c/mediawiki/tools/cli/+/615580 and basically knowing if we are aiming for the route of just facilitating having a docker-compose file in mediawiki.git, that this cli thing works with, or more like a bunch of docker-compose snippets that are controlled by and "operated" by mw-cli [18:11:52] if it's not that simple, then happy to jump in a call too to chat [18:19:16] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, and 2 others: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10thcipriani) Here is the changelog of all patchsets that went out last week: https://www.me... [18:21:25] addshore: https://meet.google.com/jhp-rqdy-sme [18:22:25] (03CR) 10Krinkle: "Unsubbing as I likely won't have time for this in the near future." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [18:22:33] (03CR) 10Krinkle: "Unsubbing as I likely won't have time for this in the near future." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [18:22:54] (03PS1) 10MtMNC: Add MtMNC to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/636472 [18:28:26] 10Project-Admins, 10Discovery-Search (Current work): Do not dump WikibaseCirrusSearch codebase tasks into some #Discovery-Search team project tag only - https://phabricator.wikimedia.org/T263725 (10CBogen) [18:29:39] (03PS2) 10MtMNC: Add MtMNC to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/636472 [18:38:16] 10Release-Engineering-Team (Logspam), 10Readers-Web-Backlog, 10JavaScript, 10MediaWiki-Interface (jQuery-Tablesorter), 10Wikimedia-production-error: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting) - https://phabricator.wikimedia.org/T265503 (10Jdlrobson) [18:38:36] 10Release-Engineering-Team (Logspam), 10Readers-Web-Backlog, 10JavaScript, 10MediaWiki-Interface (jQuery-Tablesorter), 10Wikimedia-production-error: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting) - https://phabricator.wikimedia.org/T265503 (10Jdlrobson) a:03ovasileva [18:38:40] 10Release-Engineering-Team (Logspam), 10Readers-Web-Backlog, 10JavaScript, 10MediaWiki-Interface (jQuery-Tablesorter), 10Wikimedia-production-error: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting) - https://phabricator.wikimedia.org/T265503 (10Jdlrobson) p:05Triage→... [18:42:43] longma: sorry, totally missed the ping D: [18:49:28] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Parsoid, 10Patch-For-Review, 10User-brennen: mediawiki-vendor submodule doesn't get automatically bumped on release branches - https://phabricator.wikimedia.org/T259832 (10Catrope) It work... [20:35:46] (03PS8) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [20:37:34] (03PS9) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [20:37:38] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Look into whether GitLab time tracking can be disabled - https://phabricator.wikimedia.org/T264230 (10brennen) [20:37:55] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Experiment with package publishing workflows on GitLab - https://phabricator.wikimedia.org/T264131 (10brennen) [20:39:01] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Investigate whether issues, operations, wikis, etc. can be disabled globally on GitLab - https://phabricator.wikimedia.org/T264231 (10brennen) It seems likely we'll use a scheduled job to check all rep... [20:46:45] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Document GitLab code review workflows - https://phabricator.wikimedia.org/T263668 (10brennen) A slightly better start: https://www.mediawiki.org/wiki/GitLab/Workflows/Code_review [20:47:39] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Experiment with GitLab-Phabricator integration - https://phabricator.wikimedia.org/T265617 (10brennen) [20:48:23] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Experiment with marge-bot on gitlab-test - https://phabricator.wikimedia.org/T262619 (10brennen) [20:48:31] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Proof of concept for cross-repo dependencies - https://phabricator.wikimedia.org/T262618 (10brennen) [20:50:06] hi releng! [20:50:24] more fr-tech CI fun... this time on the CiviCRM side [20:50:29] so Composer 2.0 is out [20:50:51] and we're seeing this error: require.squizlabs/PHP_CodeSniffer is invalid [20:51:05] though we can't find that casing ANYWHERE in our repos [20:51:42] not in the fundraising/crm repo or its submodules, nor in the civicrm-buildkit repo which is being run at the point of failure [20:52:12] there's a similar issue filed against composer, which was resolved pointing to a global require file: https://github.com/composer/composer/issues/8553 [20:52:48] so that's got us wondering if the docker images used for CI have a global ~/.composer/composer.json which might have the wrong case [20:53:37] ah, here's a link to sample jenkins output: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/3727/console [20:54:42] we're currently planning to mess with civicrm-buildkit to make it install composer 1.x [20:54:45] ejegg: you could try running composer why squizlabs/PHP_CodeSniffer [20:55:01] tgr can you remind me how to shell into the CI image? [20:55:11] I can't reproduce this locally [20:57:25] I think that's https://www.mediawiki.org/wiki/Continuous_integration/Docker#Debug_an_image_locally ? [20:57:31] never actually tried it though [20:59:11] oh cool, thanks! [20:59:19] PHP_CodeSniffer is part of mediawiki-codesniffer.. [20:59:38] Reedy: hmm, I'm pretty sure we're not using that on the civicrm codebase [20:59:43] https://github.com/wikimedia/mediawiki/blob/fundraising/REL1_35/composer.json#L75 [21:00:00] Which repo is that? [21:00:15] fundraising/crm [21:02:02] At least wikimedia/composer-merge-plugin does [21:02:22] So if it's installing dev dependancies... I think it does it all the way down the tree [21:02:23] ahh, we do use that merge plugin [21:02:35] let's see what the casing is like there [21:02:56] composer-merge-plugin doesn't work with composer 2.0 [21:03:04] so you should force composer 1.x [21:03:26] hmm, composer-merge-plugin has this in its composer.json: "squizlabs/php_codesniffer": "~2.1.0" [21:03:50] so yeah, we ARE going to have to force 1.0 to keep the handy merging [21:04:22] I just wish I could understand what's making composer complain about the invalid squizlabs/PHP_CodeSniffer casing [21:09:46] ejegg: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/civicrm-buildkit/+/refs/heads/master/composer.json#23 [21:09:52] :) [21:09:55] * Reedy makes a PR [21:11:23] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm-buildkit/+/636381 [21:11:40] I'm guessing that's some change in 2.0 to complain about the casing [21:16:09] oho.... [21:16:29] we thought we were using the upstream buildkit now, but I guess we ARE still using our fork [21:17:04] Yeah [21:17:04] well, that'll need a bunch of updating! [21:17:04] 17:16:31 DEBUG:zuul.CloneMapper:Using wikimedia/fundraising/crm/civicrm-buildkit as destination (unmatched) [21:18:22] thanks! [21:18:42] ok, that'll also make it easier to force composer v1 for now [21:19:01] though at some point we'll want to go back to using the upstream buildkit [21:23:38] errr, ok, so to push all the 500+ commits from upstream, I need 'forge committer' permission [21:24:10] is there a better way to update a gerrit repo that's basically supposed to be a mirror of upstream? [21:25:50] ehh, I guess we can put a no-op commit on the stack, then do a big merge commit? [21:27:25] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm-buildkit/+/636382 forces composer 1.x [21:28:20] https://github.com/civicrm/civicrm-buildkit/blob/master/bin/civi-download-tools#L611-L614 [21:28:25] They just use "newest" [21:28:29] Nice! We just also want a couple thousand missing commits from the last two years of github.com:civicrm/civicrm-buildkit.git [21:28:32] :) [21:28:45] Amusingly... https://gerrit.wikimedia.org/r/admin/repos/wikimedia/fundraising/crm,access [21:28:56] platform-engineering have Forge Committer Identity [21:29:01] but fr don't? lol [21:29:07] oho [21:29:14] I'm guessing that's not supposed to be like htat [21:29:57] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/0fb530ff85e88d9aa95d7a53d6a78ed4e3f39726 should've fixed the rights [21:30:00] Try to push again :) [21:30:39] thanks! [21:31:09] Looks like Chad added it in https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/1cc8ce759e2d4aa21f1318551a26abe3cce3dd62 [21:31:18] Wonder if it was so someone could do an import [21:31:27] maybe! [21:31:43] anyway... it didn't make any sense semantically :D [21:32:37] heh, the fix for casing is https://github.com/civicrm/civicrm-buildkit/commit/97508d1054ec61d75d621707c39a40f5c7d1a858 [21:32:42] > eileenmcnaughton committed on 6 Feb 2019 [21:32:47] You can blame your own team ;) [21:33:37] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [21:35:09] hah, so we thought CI was pulling buildkit from github all this time [21:35:18] that's why we let our fork get out of date [21:35:35] I think maybe it WAS pulling from github back before docker? [21:36:50] so we were going to have to point it back to the fork anyway, to force composer v1 [21:40:29] certainly the sort of thing that might've got broken in a migration like that [21:59:40] ok, got it updated & installing Composer 1.x, now working through other issues with the last 2 yrs of upstream updates. Thanks for the pointers! [22:03:25] 10Release-Engineering-Team (Deployment services), 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate), 10Structured-Data-Backlog (Current Work), 10Wikimedia-extension-review-queue: Split MediaSearch out into its own extension - https://phabricator.wikimedia.org/T265939 (10AnneT) [22:18:57] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dep. [integration/config] - 10https://gerrit.wikimedia.org/r/636506 (https://phabricator.wikimedia.org/T265939) [22:19:21] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dep. [integration/config] - 10https://gerrit.wikimedia.org/r/636506 (https://phabricator.wikimedia.org/T265939) (owner: 10Jforrester) [22:20:35] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dep. [integration/config] - 10https://gerrit.wikimedia.org/r/636506 (https://phabricator.wikimedia.org/T265939) (owner: 10Jforrester) [22:21:16] !log Zuul: [mediawiki/extensions/MediaSearch] Add WikibaseCirrus dependency T265939 [22:21:19] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:21:19] T265939: Split MediaSearch out into its own extension - https://phabricator.wikimedia.org/T265939 [23:53:03] libup is running now, needed some manual poking