[00:22:21] legoktm: should it have started pushing commits? [00:23:24] Reedy: the first canary is Linter and it's going in alpha order so it might take a while [00:25:19] we're in the Bs right now [02:32:16] (03PS5) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [02:35:04] (03CR) 10jerkins-bot: [V: 04-1] FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [02:35:35] (03PS6) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [02:36:05] (03PS7) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [02:38:19] (03PS5) 10DannyS712: Add SpaceBeforeBracketSniff for spaces between variable and array offset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591486 (https://phabricator.wikimedia.org/T154103) [03:05:00] 10Project-Admins, 10XTools, 10PM, 10User-Matthewrbowker: Proposal: Separate Phabricator project for semi-automated edit requests in XTools - https://phabricator.wikimedia.org/T262721 (10DannyS712) a:05DannyS712→03None [04:38:21] ok but now there's an issue [04:38:30] https://libraryupgrader2.wmcloud.org/r/mediawiki/extensions/Linter [04:38:36] the auto-disable failing rules isn't working hm [04:45:01] did something change? [05:01:56] that code is always super fragile, it's trying to write XML using regexes [07:31:04] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, and 2 others: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) Another spike yesterday on DELETEs {F32415982} Checking binlogs from 22:17 to 2... [08:26:35] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, and 2 others: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10Marostegui) Another spike from 08:05 to 08:06 and this is what the binlog shows (number of s... [08:45:11] (03PS3) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) [08:46:27] (03CR) 10jerkins-bot: [V: 04-1] Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:38:25] (03PS1) 10Hashar: jjb: disable workspace size collection [integration/config] - 10https://gerrit.wikimedia.org/r/636621 (https://phabricator.wikimedia.org/T265615) [09:40:01] (03CR) 10Hashar: [C: 03+2] "I have no clue why the Docker shell takes a while to complete. That disables https://integration.wikimedia.org/ci/job/maintenance-sample-w" [integration/config] - 10https://gerrit.wikimedia.org/r/636621 (https://phabricator.wikimedia.org/T265615) (owner: 10Hashar) [09:41:25] (03Merged) 10jenkins-bot: jjb: disable workspace size collection [integration/config] - 10https://gerrit.wikimedia.org/r/636621 (https://phabricator.wikimedia.org/T265615) (owner: 10Hashar) [10:05:12] 10Release-Engineering-Team (CI & Testing services), 10DNS, 10Operations, 10Traffic, 10Patch-For-Review: Create redirect to integration.wikimedia.org/zuul - https://phabricator.wikimedia.org/T207008 (10hashar) 05Open→03Declined The canonical URL is https://integration.wikimedia.org/zuul/ which one ca... [10:05:26] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10DNS, and 3 others: Create redirect to integration.wikimedia.org/zuul - https://phabricator.wikimedia.org/T207008 (10hashar) [10:10:36] (03CR) 10Hashar: [C: 03+2] "For sure :)" [integration/config] - 10https://gerrit.wikimedia.org/r/636472 (owner: 10MtMNC) [10:11:38] (03Merged) 10jenkins-bot: Add MtMNC to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/636472 (owner: 10MtMNC) [10:11:58] (03PS4) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) [10:17:40] (03CR) 10Hashar: "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/636472 (owner: 10MtMNC) [10:43:22] (03CR) 10Thiemo Kreuz (WMDE): "Thanks for the final review! These cases are certainly rare, but worth it in my opinion. They have straightforward fixes, and the existing" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/576276 (owner: 10Thiemo Kreuz (WMDE)) [10:46:54] (03CR) 10Thiemo Kreuz (WMDE): "Sure, I would love to be able to write test cases that use different .phpcs.xml configurations. I will definitely keep this in mind and in" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603496 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [11:09:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I don't see a problem with having this sniff. It doesn't find anything in the test run." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [11:13:43] (03CR) 10Daimona Eaytoy: [C: 03+1] "> If you do `private final function` that will be disallowed by the sniff that enforces the order, so I think double enforcement will be j" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [11:17:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I like it! It looks like there are currently no violations in the test run. This is probably because we fixed them already." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [11:23:02] (03CR) 10DannyS712: Add AssertionOrderSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [11:24:39] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, and 2 others: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10matthiasmullie) At first sight, these DB operations seem to make sense: bots are in the proc... [11:25:30] (03CR) 10Hashar: Move LocalSettings.php out of the way before running unit tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [11:25:49] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10DBA, 10Data-Persistence, and 2 others: Create integration test env for wmfmariadbpy - https://phabricator.wikimedia.org/T265266 (10Kormat) I just came across this: https://github.com/openark/orchestrator/blob/master/docs/ci-env.md#run-orch... [11:27:22] 10Release-Engineering-Team, 10Commons, 10DBA, 10Operations, and 2 others: Increase on database writes and deletes activity on Commonswiki leads to some replication lag - https://phabricator.wikimedia.org/T266432 (10jcrespo) Independently of the source of the issue, could these regenerations be throttled/ra... [11:30:15] (03CR) 10Thiemo Kreuz (WMDE): "My personal opinion is that tabs or extra spaces in `function example()` are not that much of an issue to be worth a sniff. However, I se" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [11:32:15] (03PS12) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [11:32:18] (03CR) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [11:33:47] (03PS13) 10DannyS712: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) [11:35:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add AssertionOrderSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [11:39:05] (03CR) 10DannyS712: Add AssertionOrderSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [11:39:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [11:57:15] awight: I think hashar is out today, for an offsite [11:57:28] kostajh: awight well I am here during the day ;) [11:57:37] the offsite is virtual and happens in our evening [11:57:38] ah ok [11:57:38] then [11:57:49] I have merely spend all the past few days trying to find out a docker issue :-\ [11:58:02] well, in any case, I wanted to say that I'm going to skip the meeting today and rest, I've been sick the last few days [11:58:03] "docker run" process stays around for a while after quibble has completed bah :-\ [11:58:06] yeah that's been amazing to watch from the outside [11:58:16] kostajh: ohhh [11:58:18] kostajh: Gute besserung! [11:58:28] then do rest Bitte! [11:58:45] (I should learn German again really) [11:58:56] I do think I'm unblocked on reviewing awight's apache patches, I didn't think to use --user=root with docker run. which of course is "wrong" but sorts out all the permissions issues in my local setup [11:59:06] my quick checkin is roughly that I want to play test the Apache config change to give some feedbacks to it [11:59:42] if you get a repro case for the user permission, do paste it in a task and surely I can dig into it [11:59:56] but I want to fix up that production issue first (long delay after docker run) [12:00:40] kostajh: Interesting! [12:01:06] so skip and try again next week? ; [12:01:40] kostajh: hashar: My only burning question was, whether I can switch to using docker-compose for the quibble local dev container? [12:01:52] oh [12:02:03] essentially no [12:02:06] :-\ [12:02:31] the devi is that we have nowhere to run docker composer [12:02:58] hashar: couldn't that be an acceptable binary to have in CI? [12:03:05] https://phabricator.wikimedia.org/T266081#6568142 [12:03:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Uh, good point! Ok, let's leave such cases untouched then." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [12:03:12] But the only use case for quibble/Dockerfile is local dev, I thought? [12:03:22] in short, I rather not run abitrary containers on the CI instances [12:03:29] cause the stae is shared between jobs [12:03:33] and it will be a mess [12:03:48] For sure, this isn't the integration-config containers, it's the one inside the quibble repo [12:03:54] we have a few other use cases such as running docker-pkg [12:04:10] ah. hashar and I were talking about it in the context of CI [12:04:18] and that task is about running a tool named "buildpack" which I understand it is about building images [12:04:40] all those are more or less related and boils down to: how do we run a workload with a fresh Docker [12:04:42] +1 I'm clear about not rocking the boat in integration-config... [12:04:53] tentatively using a Kubernetes pod might do it [12:05:02] Is there a CI use case for quibble/Dockerfile that I'm not aware of? [12:05:07] though that would still not give access to a docker daemon [12:05:31] so I am leaning toward adding some infrastructure that has a virtual machine spawned specially for those cases which would have an empty / isolated docker daemon [12:05:50] and yeah that would allow us to run "docker build" for the quibble.git /Dockerfile [12:05:57] or whatever repository has a Dockerfile [12:06:01] or a docker compose [12:06:26] or we come up with a different system [12:06:28] Okay I see, so we should stay future-compatible with a use case that doesn't happen quite yet. [12:06:34] That's fine and good to know! [12:07:01] meanwhile, I guess we want Quibble to drive the backends [12:09:32] going to lunch [12:09:44] will try to enable some docker/containerd debugging this afternoon :\ [12:10:19] /o\ best of luck [12:32:28] 10Project-Admins, 10cloud-services-team (Kanban): Update VPS subproject list - https://phabricator.wikimedia.org/T266461 (10Aklapper) > To improve structure and communication the very frequently used PetScan might be created but the maintainer @Magnus needs to be notified. The maintainer decided to track stuff... [12:36:56] (03PS1) 10Awight: Drop unused FROM [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 [12:37:18] (03PS2) 10Awight: Collapse docker steps to minimize intermediate product [integration/quibble] - 10https://gerrit.wikimedia.org/r/630842 [12:38:37] (03PS3) 10Awight: Explicit registry for backends [integration/quibble] - 10https://gerrit.wikimedia.org/r/629086 [12:39:12] (03CR) 10Awight: "This was uncontroversial, I think?" [integration/quibble] - 10https://gerrit.wikimedia.org/r/629086 (owner: 10Awight) [12:41:55] 10Project-Admins, 10cloud-services-team (Kanban): Update VPS subproject list - https://phabricator.wikimedia.org/T266461 (10Aklapper) 05Open→03Resolved a:03Aklapper I made #VPS-project-codesearch a subproject of #VPS-Projects. For Petscan see my previous comment. #Quarry is already discussed in {T177787... [13:19:54] !log Enabling puppet again on CI agent (that also causes Docker/containerd to be rolled back) # T265615 [13:19:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:19:57] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 [13:20:30] !log Enable Docker daemon debug mode on integration-agent-docker-1001 via Horizon https://horizon.wikimedia.org/project/instances/837fff63-ed52-4c2f-823d-936801056fd2/ # T265615 [13:20:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:16:32] 10Phabricator, 10Cloud-Services, 10cloud-services-team (Kanban): Organize additional projects as #cloud-services subprojects - https://phabricator.wikimedia.org/T177787 (10PerfektesChaos) When I discovered [[ https://phabricator.wikimedia.org/project/subprojects/525/ | VPS subproject list ]] my expectation h... [15:41:55] (03CR) 10Ahmon Dancy: [C: 04-1] "Holding for some tweaks." [tools/scap] - 10https://gerrit.wikimedia.org/r/635897 (https://phabricator.wikimedia.org/T243009) (owner: 10Ahmon Dancy) [15:49:00] (03CR) 10Awight: Move LocalSettings.php out of the way before running unit tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [16:14:13] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) I have... [16:19:15] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble, 10Patch-For-Review: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10Krinkle) I think we may want to avoid having to move the file in CI, so that out-of–the-box things are... [17:05:25] (03PS8) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [17:05:46] (03PS6) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [17:30:45] 10Phabricator, 10Cloud-Services, 10cloud-services-team (Kanban): Organize additional projects as #cloud-services subprojects - https://phabricator.wikimedia.org/T177787 (10bd808) >>! In T177787#6581535, @PerfektesChaos wrote: > * #wikidata-query-service is a VPS as well but not yet under any umbrella. This... [18:18:16] 10Phabricator, 10Cloud-Services, 10cloud-services-team (Kanban): Organize additional projects as #cloud-services subprojects - https://phabricator.wikimedia.org/T177787 (10PerfektesChaos) Maybe; one reason more to avoid confusion and attempt clear structures. [19:34:56] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Convert static mediawiki configuration to form more suitable for containers - https://phabricator.wikimedia.org/T263166 (10jeena) I thought of some more guidelines we could use to help migrate... [20:04:11] 10Phabricator: Addition to Wikimedia-NDA group? - https://phabricator.wikimedia.org/T266598 (10Varnent) [20:06:30] 10Phabricator: Addition to Wikimedia-NDA group? - https://phabricator.wikimedia.org/T266598 (10Heather) Approved. Thanks! [20:11:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10ExtensionDistributor, and 2 others: Phase out https://gerrit.wikimedia.org/mediawiki-extensions.txt - https://phabricator.wikimedia.org/T266024 (10Dzahn) 17:22 < mutante> !log ger... [20:15:21] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10ExtensionDistributor, and 2 others: Phase out https://gerrit.wikimedia.org/mediawiki-extensions.txt - https://phabricator.wikimedia.org/T266024 (10Dzahn) cleaned up. ^ https:/... [20:30:27] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10ExtensionDistributor, and 2 others: Phase out https://gerrit.wikimedia.org/mediawiki-extensions.txt - https://phabricator.wikimedia.org/T266024 (10Dzahn) 05Open→03Resolved a:... [20:31:01] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10ExtensionDistributor, and 2 others: Phase out https://gerrit.wikimedia.org/mediawiki-extensions.txt - https://phabricator.wikimedia.org/T266024 (10Dzahn) p:05Triage→03Low [20:31:30] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10ExtensionDistributor, and 2 others: Phase out https://gerrit.wikimedia.org/mediawiki-extensions.txt - https://phabricator.wikimedia.org/T266024 (10Dzahn) 05Resolved→03Open reo... [21:03:21] (03PS8) 10Brennen Bearnes: Split php-fpm and apache2 containers [releng/dev-images] - 10https://gerrit.wikimedia.org/r/622575 (https://phabricator.wikimedia.org/T245444) [21:10:07] (03CR) 10Brennen Bearnes: "> Patch Set 7:" (032 comments) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/622575 (https://phabricator.wikimedia.org/T245444) (owner: 10Brennen Bearnes) [22:23:19] (03PS9) 10Brennen Bearnes: Split php-fpm and apache2 containers [releng/dev-images] - 10https://gerrit.wikimedia.org/r/622575 (https://phabricator.wikimedia.org/T245444) [22:46:08] !log Cherry-picking https://gerrit.wikimedia.org/r/c/operations/puppet/+/636759 in beta puppet. Should only affect deployment-webperf12. [22:46:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL