[00:13:56] (03CR) 10DannyS712: "why drop support for 1.5.1?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy) [00:14:54] (03CR) 10Reedy: "1.5.2 fixes bugs in 1.5.1 - https://github.com/composer/semver/releases/tag/1.5.2" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy) [02:52:45] 10Gerrit, 10Security: Gerrit login page should print the same message when the username doesn't exist and when the username exists - https://phabricator.wikimedia.org/T266628 (10rafidaslam) [02:58:06] (03CR) 10DannyS712: "> Patch Set 3:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy) [02:59:56] 10commit-message-validator: commit-message-validator prints a strange 'true' and 'false' in the middle of the message - https://phabricator.wikimedia.org/T195078 (10rafidaslam) 05Open→03Resolved [03:05:05] 10MediaWiki-Codesniffer, 10User-DannyS712, 10User-thiemowmde: Expand PHPUnitAssertEqualsSniff to better auto-fix comparisons with count() - https://phabricator.wikimedia.org/T242762 (10DannyS712) a:03DannyS712 Will do, given that this will add yet another PHPUnit sniff should probably go after >>! In T253... [03:42:54] 10commit-message-validator: Make rules and MessageValidator configurable - https://phabricator.wikimedia.org/T195060 (10rafidaslam) a:05rafidaslam→03None [04:16:25] (03PS9) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [04:18:48] (03PS7) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [07:27:55] (03PS10) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [07:28:42] (03PS8) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [08:44:08] (03Abandoned) 10Hashar: (DO NOT SUBMIT) full run against Wikibase - Selenium [integration/quibble] - 10https://gerrit.wikimedia.org/r/635257 (owner: 10Hashar) [08:44:11] (03Abandoned) 10Hashar: (DO NOT SUBMIT) Full run against Wikibase [integration/quibble] - 10https://gerrit.wikimedia.org/r/635256 (owner: 10Hashar) [08:44:46] (03Abandoned) 10Hashar: (DO NOT SUBMIT) test dummy full run [integration/quibble] - 10https://gerrit.wikimedia.org/r/634481 (https://phabricator.wikimedia.org/T265615) (owner: 10Hashar) [08:48:56] (03CR) 10Hashar: [C: 03+2] Drop unused FROM [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 (owner: 10Awight) [08:59:12] (03CR) 10jerkins-bot: [V: 04-1] Drop unused FROM [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 (owner: 10Awight) [09:02:59] (03CR) 10Awight: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 (owner: 10Awight) [09:06:03] 10Release-Engineering-Team-TODO, 10Front-end-Standards-Group, 10Product-Infrastructure-Team-Backlog, 10TechCom, and 2 others: Should npm packages maintained by Wikimedia be scoped or unscoped? - https://phabricator.wikimedia.org/T239742 (10Joe) I second @Mholloway as well. The reasons are both what @Demian... [09:14:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) With `... [09:21:08] (03CR) 10Hashar: [C: 03+2] "My fault, I killed the wrong build while investigating something else ;)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 (owner: 10Awight) [09:22:09] pff [09:22:17] so I went to read about futex() system call [09:22:23] and end up at https://en.wikipedia.org/wiki/Google_Fuchsia [09:22:25] really [09:22:42] I should blacklist wikipedia.org entirely, it is an infinite knowledge well [09:32:48] (03PS1) 10JMeybohm: helm-linter: Update kubeyaml [integration/config] - 10https://gerrit.wikimedia.org/r/636878 (https://phabricator.wikimedia.org/T266032) [09:32:50] (03PS1) 10JMeybohm: jjb: update job to releng/helm-linter:0.2.10 [integration/config] - 10https://gerrit.wikimedia.org/r/636879 (https://phabricator.wikimedia.org/T266032) [09:43:31] jayme: hi, have you uploaded the package to apt / can i build the image? [09:43:52] hashar: Hi, yes please! <3 [09:43:55] (03Merged) 10jenkins-bot: Drop unused FROM [integration/quibble] - 10https://gerrit.wikimedia.org/r/636649 (owner: 10Awight) [09:44:02] (03CR) 10Hashar: [C: 03+2] helm-linter: Update kubeyaml [integration/config] - 10https://gerrit.wikimedia.org/r/636878 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [09:44:08] I should really move that to scap [09:44:25] eheh, sorry for continously bugging you with that :) [09:47:16] (03CR) 10jerkins-bot: [V: 04-1] helm-linter: Update kubeyaml [integration/config] - 10https://gerrit.wikimedia.org/r/636878 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [09:48:17] 09:47:10 Build timed out (after 3 minutes). Marking the build as failed. [09:48:17] grr [09:49:50] (03CR) 10Hashar: [C: 03+2] "Unrelated build failure" [integration/config] - 10https://gerrit.wikimedia.org/r/636878 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [09:50:50] (03CR) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:50:54] (03Merged) 10jenkins-bot: helm-linter: Update kubeyaml [integration/config] - 10https://gerrit.wikimedia.org/r/636878 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [09:56:24] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing, 10Quibble, 10Patch-For-Review: Some unit tests are not executed with composer phpunit:unit - https://phabricator.wikimedia.org/T266441 (10kostajh) >>! In T266441#6581966, @Krinkle wrote: > I think we may want to avoid having to move the fil... [10:00:02] !log Successfully tagged docker-registry.discovery.wmnet/releng/helm-linter:0.2.10 # T266032 [10:00:05] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:00:06] T266032: Test deployment-charts for kubernetes 1.19 compatibility - https://phabricator.wikimedia.org/T266032 [10:01:18] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 1" [integration/config] - 10https://gerrit.wikimedia.org/r/636879 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [10:01:24] jayme: done! [10:01:31] hashar: thanks [10:02:35] (03Merged) 10jenkins-bot: jjb: update job to releng/helm-linter:0.2.10 [integration/config] - 10https://gerrit.wikimedia.org/r/636879 (https://phabricator.wikimedia.org/T266032) (owner: 10JMeybohm) [10:33:33] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) No wit... [10:58:16] (03PS1) 10Hashar: Revert "jjb: disable workspace size collection" [integration/config] - 10https://gerrit.wikimedia.org/r/636793 [10:59:08] (03CR) 10Hashar: [C: 03+2] Revert "jjb: disable workspace size collection" [integration/config] - 10https://gerrit.wikimedia.org/r/636793 (owner: 10Hashar) [11:00:03] (03CR) 10Hashar: [C: 03+2] "Deployed and enabled again https://integration.wikimedia.org/ci/job/maintenance-sample-workspace-sizes/" [integration/config] - 10https://gerrit.wikimedia.org/r/636793 (owner: 10Hashar) [11:00:19] (03Merged) 10jenkins-bot: Revert "jjb: disable workspace size collection" [integration/config] - 10https://gerrit.wikimedia.org/r/636793 (owner: 10Hashar) [12:03:16] 10Beta-Cluster-Infrastructure: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10CptViraj) [12:48:08] (03PS5) 10Awight: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) [12:48:10] (03PS2) 10Awight: Different default ports for each backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 [13:04:37] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10DannyS712) a:03DannyS712 [13:27:57] 10Project-Admins, 10Discovery-Search (Current work): Do not dump WikibaseCirrusSearch codebase tasks into some #Discovery-Search team project tag only - https://phabricator.wikimedia.org/T263725 (10Gehel) p:05Triage→03High [13:30:57] 10Project-Admins, 10Discovery-Search (Current work): Do not dump WikibaseCirrusSearch codebase tasks into some #Discovery-Search team project tag only - https://phabricator.wikimedia.org/T263725 (10Gehel) p:05High→03Low [14:05:25] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10DBA, 10Operations, 10User-Kormat: Create integration test env for wmfmariadbpy - https://phabricator.wikimedia.org/T265266 (10LSobanski) [14:14:42] !log arm keyholder on beta cluster to fix beta-scap-eqiad [14:14:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:27:14] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10DannyS712) @CptViraj can you confirm that `CptViraj` is also your name on the beta cluster? [14:32:37] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Make a Scap release - https://phabricator.wikimedia.org/T266676 (10LarsWirzenius) [14:52:35] I'm having some weird issues with access to gerrit. I haven't used it in some time, but nothing on my end should have changed. [14:52:51] Did I miss a migration of some kind in say the last 6 months? [14:53:06] Some configuration I should have checked/updated? [14:53:21] In my preferences I found my key listed as "invalid" [14:54:09] I reuploaded it though and it's listed as valid now, but I cannot push to a repo that I am the owner of. I'm also a member of the one group with rights [14:54:38] https://www.irccloud.com/pastebin/UpO3Glxb/ [14:54:49] I'm probably missing something dumb. [14:59:41] urandom: you either need to use git review.. [14:59:55] or git push origin HEAD:refs/for/master [15:00:23] Reedy: I've created a branch (through the UI, because it didn't work from git) [15:00:35] do i just use the corresponding ref for the branch then? [15:00:59] `git push origin HEAD:refs/for/buster` should work, I think [15:01:08] I dunno if you need push rights to use other branches too [15:01:23] but refs/for/foo will result in gerrit changesets [15:02:22] Reedy: yeah, that doesn't work either [15:02:34] https://www.irccloud.com/pastebin/flKr2HZe/ [15:03:49] Reedy: oohh..."for" was literal [15:03:51] wow. [15:03:58] yeah, that works! [15:05:29] Reedy: thanks! [15:06:21] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) Looks... [15:09:32] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10CptViraj) @DannyS712 I confirm that 'CptViraj' is my account on the beta cluster. [15:12:28] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10DannyS712) 05Open→03Resolved Granted sysop and interface admin for a year, see https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special%3ALog&logid=54562 [15:23:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) So my... [15:26:06] DannyS712: File importing isn't available on the beta cluster? [15:26:51] no idea [15:27:20] I don't see XML import section at Special:Import [15:28:02] oh, thats because you don't have importupload [15:29:04] Ah looks like it's not in the beta cluster's default sysop group rights [15:29:37] WMF revokes it from default sysop globally, in both prod and beta [15:29:52] do you want import rights too? [15:30:25] Yeah if possible, that will make my work easier [15:31:41] done [15:31:42] 10Beta-Cluster-Infrastructure, 10User-DannyS712: Request for rights on hiwikipedia of beta cluster - https://phabricator.wikimedia.org/T266660 (10DannyS712) Also granted importer for a year, per IRC - see https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special%3ALog&logid=54565 [15:32:27] Many thanks :) [15:38:59] 10Release-Engineering-Team, 10Cloud-VPS (Project-requests): Request creation of pipelinelib-experimental VPS project - https://phabricator.wikimedia.org/T266174 (10Andrew) a:03nskaggs This request was approved in today's meeting; assigning to @nskaggs to create this week. [15:39:31] 10Release-Engineering-Team, 10Cloud-VPS (Project-requests), 10cloud-services-team (Kanban): Request creation of pipelinelib-experimental VPS project - https://phabricator.wikimedia.org/T266174 (10bd808) [15:39:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) 05Stalled→03Open p:05Triage→03Medium [15:39:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop MediaWiki testing in stretch and instead test only in buster - https://phabricator.wikimedia.org/T252432 (10jijiki) [15:39:39] 10Release-Engineering-Team, 10serviceops, 10PHP 7.2 support, 10Patch-For-Review: Drop PHP 7.2 support from MediaWiki master branch, once Wikimedia production is on 7.3 - https://phabricator.wikimedia.org/T261872 (10jijiki) [15:47:56] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T263182 (10Jdforrester-WMF) [15:50:36] (03PS21) 10Awight: [WIP] Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [16:48:04] (03PS22) 10Awight: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [16:50:05] (03CR) 10Awight: "Note that there's nothing left of the "apache" option, this patch is purely provisioning and from quibble's perspective is simply using an" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [16:51:20] hashar: kostajh: I think apache support is finally ready, using quibble's "external" web backend. [16:52:07] awight: \o/ [16:52:24] awight: and I probably found the cause of the Docker containers slowness on completion ;) [16:52:37] so hopefully I will be able to resume on quibble reviews soonish [16:52:39] Aww, I just made more popcorn! [17:00:19] hashar: Just caught up with the container remove comments. Wow, nice find! Good to know about this being an issue with other containers as well... [17:00:35] tldr, probably gotta createa a workspace directory on the host [17:00:39] and -v it in the container [17:00:46] will have to check the impact [17:01:03] cause on the agent that would mean the code lands on different partitions [17:01:17] ( /srv/jenkins/workspace instead of /var/lib/docker or something like that) [17:01:18] ;) [17:01:24] and [17:01:28] have to verify my assumption [17:01:33] but that seems like a strong lead [17:04:42] If we can really gain a minute per job, it seems like a big deal... [17:17:32] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) [17:36:08] 10Release-Engineering-Team, 10MediaWiki-Docker, 10Developer Productivity, 10User-brennen, 10User-kostajh: mediawiki-docker test feature - https://phabricator.wikimedia.org/T262369 (10Addshore) I think quibble is a nice to have, but should be pushed further down the line. I like the layout of the commands... [17:39:00] 10Release-Engineering-Team, 10MediaWiki-Docker, 10Developer Productivity, 10User-brennen, 10User-kostajh: mediawiki-docker destroy feature - https://phabricator.wikimedia.org/T262365 (10Addshore) Description could be slightly improved, is this `mw docker destroy`? > other to be determined... I guess on... [17:41:25] 10Release-Engineering-Team, 10MediaWiki-Docker, 10Developer Productivity, 10User-brennen, 10User-kostajh: Add .env file creation to docker start command - https://phabricator.wikimedia.org/T262362 (10Addshore) I agree that some of these things should live in .env and be used an env vars. I think any furt... [17:50:38] 10Gerrit, 10Release-Engineering-Team: Could not perform action: Lock failure. Updating a ref failed with LOCK_FAILURE. - https://phabricator.wikimedia.org/T266693 (10Reedy) [17:51:48] 10Gerrit, 10Release-Engineering-Team: Could not perform action: Lock failure. Updating a ref failed with LOCK_FAILURE. - https://phabricator.wikimedia.org/T266693 (10Reedy) Rebasing of a newer patch, in this case https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/589841 seems to be fine [17:52:55] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Could not perform action: Lock failure. Updating a ref failed with LOCK_FAILURE. - https://phabricator.wikimedia.org/T266693 (10thcipriani) p:05Triage→03Medium a:03thcipriani [17:56:49] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Could not perform action: Lock failure. Updating a ref failed with LOCK_FAILURE. - https://phabricator.wikimedia.org/T266693 (10thcipriani) Seeing errors in logs about lock exceptions. The important part, I think, is: ` Caused by: com.... [17:59:15] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Continuous delivery for kubernetes services - https://phabricator.wikimedia.org/T266694 (10jeena) [17:59:24] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Continuous delivery for kubernetes services - https://phabricator.wikimedia.org/T266694 (10jeena) Related task: T214158 [18:21:53] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer not vendor quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/636998 [18:23:09] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer not vendor quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/636998 (owner: 10Jforrester) [18:27:01] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/636998 [18:28:17] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble job [integration/config] - 10https://gerrit.wikimedia.org/r/636998 (owner: 10Jforrester) [18:33:35] (03PS3) 10Jforrester: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble [integration/config] - 10https://gerrit.wikimedia.org/r/636998 [18:34:22] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble [integration/config] - 10https://gerrit.wikimedia.org/r/636998 (owner: 10Jforrester) [18:35:38] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble [integration/config] - 10https://gerrit.wikimedia.org/r/636998 (owner: 10Jforrester) [18:38:57] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Could not perform action: Lock failure. Updating a ref failed with LOCK_FAILURE. - https://phabricator.wikimedia.org/T266693 (10thcipriani) 05Open→03Resolved Those refs do exist, but the patchsets point to the first changeset intent... [18:40:03] !log Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Use composer quibble [18:40:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:53:49] (03PS4) 10Ahmon Dancy: scap: Add support for ungraceful php-fpm restart [tools/scap] - 10https://gerrit.wikimedia.org/r/635897 (https://phabricator.wikimedia.org/T243009) [18:57:57] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Skip phan [integration/config] - 10https://gerrit.wikimedia.org/r/637006 [19:00:54] I just fixed puppet on 6 deployment-prep instances, which leaves 9 of them broken [19:01:16] In theory these breakages send emails to project admins notifying them… is that emailing broken, or has everyone assigned those emails to spam? [19:01:23] andrewbogott: Hurrah. Or Boo. [19:01:41] I've never seen such an e-mail. Where are they sent to? [19:02:06] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Skip phan [integration/config] - 10https://gerrit.wikimedia.org/r/637006 (owner: 10Jforrester) [19:02:20] hmmmm in theory all project admins [19:02:24] but maybe it's disabled for that project or something [19:02:31] for instance deployment-memc08 has has broken puppet for 50 days [19:02:36] Fun. [19:02:37] I'll see what's up with the email nags [19:02:53] Thanks! [19:03:34] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Skip phan [integration/config] - 10https://gerrit.wikimedia.org/r/637006 (owner: 10Jforrester) [19:03:41] !log Zuul: [mediawiki/extensions/FundraisingEmailUnsubscribe] Skip phan [19:03:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:24:05] libup is starting the full PHPCS run now [19:29:12] (03CR) 10Ammarpad: [C: 04-1] "Needs comment for removal per Thiemo" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [19:46:59] 10Continuous-Integration-Infrastructure (Slipway), 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 2 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) [19:47:30] (03PS11) 10DannyS712: Add FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) [19:47:35] legoktm: Hurrah. [19:47:38] (03CR) 10DannyS712: "> Patch Set 10: Code-Review-1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [19:47:43] (03PS12) 10DannyS712: Add FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) [19:57:57] Hi legoktm ! :D [19:58:15] How much work do you tihnk it would be to make libup work for npm in sub directories? (I think I asked you before but I didnt write it down) [19:58:35] File a phab task. ;-) [19:58:43] I think there is one somewhere :P [19:59:06] I'm more curious about how much work it might be (as I havn't looked at the insides) than pressuring anyone to get it done :P [19:59:44] addshore: properly, probably a few days. hackily, a few hours [20:00:08] let me find the task [20:00:22] https://phabricator.wikimedia.org/T228527 [20:03:44] 10MediaWiki-Codesniffer, 10User-DannyS712: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Umherirrender) Should the same apply to `object[]`? [20:07:56] 10LibUp, 10Wikidata, 10Wikidata-Bridge, 10wdwb-tech-focus: Support nested package.json files - https://phabricator.wikimedia.org/T228527 (10Legoktm) So first, I note that ContentTranslation has seemed to gotten this working without any libup intervention, see e.g. https://gerrit.wikimedia.org/r/plugins/git... [20:08:16] addshore: ^ commented explaining ContentTranslation's hack as well as what it would take for libup support [20:37:12] 10MediaWiki-Codesniffer, 10User-DannyS712: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10DannyS712) >>! In T264948#6586134, @Umherirrender wrote: > Should the same apply to `object[]`? Probably [20:38:16] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:03:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Expand FunctionCommentSniff to error on `object[]` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:16:53] hey $someone (maybe greg-g), would you be willing to update the Outcomes section of the Gitlab consultation page to indicate "self-hosted Gitlab" just for people who won't read all the fine print and get to the "What" section to find that out? [21:17:18] and yeah this is because of the HN thread but then when I went to look at the page it was not at all obvious [21:22:32] apergos: better? [21:22:54] that is effing perfect, thank you a bunch!! [21:42:43] (03CR) 10Umherirrender: [C: 03+1] Expand FunctionCommentSniff to error on `object[]` typehints (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:44:40] (03CR) 10DannyS712: Expand FunctionCommentSniff to error on `object[]` typehints (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:47:04] (03CR) 10Umherirrender: [C: 03+2] Expand FunctionCommentSniff to error on `object[]` typehints (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [21:48:09] (03Merged) 10jenkins-bot: Expand FunctionCommentSniff to error on `object[]` typehints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636964 (https://phabricator.wikimedia.org/T264948) (owner: 10DannyS712) [22:03:40] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Prohibit use of 'object' as type in docblocks - https://phabricator.wikimedia.org/T264948 (10Daimona) >>! In T264948#6586134, @Umherirrender wrote: > Should the same apply to `object[]`? Huh. Perhaps it would be a good idea to adopt some kind of... [22:06:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) I have... [22:13:54] 10LibUp, 10Wikidata, 10Wikidata-Bridge, 10wdwb-tech-focus: Support nested package.json files - https://phabricator.wikimedia.org/T228527 (10Pablo-WMDE) >>! In T228527#6586172, @Legoktm wrote: > So first, I note that ContentTranslation has seemed to gotten this working without any libup intervention, see e.... [22:16:09] 10Phabricator, 10Wikibase-Containers, 10Wikidata, 10Regression: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10mmodell) [22:21:19] legoktm: ooooo [22:21:26] :) [22:23:57] awesome that pablo already responded to you too :D [22:24:01] I was watching a film ;) [22:25:42] (03CR) 10Thcipriani: [C: 03+2] scap: Add support for ungraceful php-fpm restart [tools/scap] - 10https://gerrit.wikimedia.org/r/635897 (https://phabricator.wikimedia.org/T243009) (owner: 10Ahmon Dancy) [22:27:54] (03Merged) 10jenkins-bot: scap: Add support for ungraceful php-fpm restart [tools/scap] - 10https://gerrit.wikimedia.org/r/635897 (https://phabricator.wikimedia.org/T243009) (owner: 10Ahmon Dancy) [22:35:37] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) I have... [22:52:39] !log integration: make sure docker daemon no more has debug enabled by reloading it fleet wide: sudo cumin --force 'name:docker' 'systemctl reload docker' [22:52:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:57:25] 10Phabricator, 10Wikibase-Containers, 10Wikidata, 10Regression: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10mmodell) 620fa0816bfc0fa0738dfc65ff46affd686c681b is now ready to deploy.