[00:29:54] 10phan, 10phan-taint-check-plugin: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Reedy) [02:08:32] 10Phabricator, 10Release-Engineering-Team, 10Operations: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10Dzahn) [02:09:09] 10Phabricator, 10Release-Engineering-Team, 10Operations: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10Dzahn) [02:10:10] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10Dzahn) [02:12:22] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10DannyS712) Wasn't this meant to be done yesterday at {T266598}? [02:12:30] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10Dzahn) @Varnent Created this per our meeting and when I checked during it and you confirmed you could not see the ticket I also did not see y... [02:13:21] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10Dzahn) 05Open→03Invalid >>! In T266731#6586868, @DannyS712 wrote: > Wasn't this meant to be done yesterday at {T266598}? I did not see t... [02:13:42] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10DannyS712) >>! In T266731#6586870, @Dzahn wrote: > @Varnent Created this per our meeting and when I checked during it and you confirmed you c... [02:14:02] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10WMF-NDA-Requests: add Greg Varnum to WMF/NDA in Phabricator - https://phabricator.wikimedia.org/T266731 (10DannyS712) [02:38:31] 10Phabricator (Upstream), 10Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370 (10gh87) Shall this task be reopened, or must I create a new task? I didn't think until moments ago that this task has existed. I still don't kn... [03:05:44] 10LibUp, 10Patch-For-Review: libup could add wikimedia/mediawiki to .eslintrc.json when globals contains mw/OO - https://phabricator.wikimedia.org/T262222 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [06:50:33] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10DannyS712) [06:50:45] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10DannyS712) [06:55:59] libup is now up to extensions begining with `Ch*` - I'm logging off for the day but will review the new patches tomorrow if there are any still open [07:08:43] 10MediaWiki-Codesniffer: Please teach PropertyDocumentation sniff about @inheritDoc - https://phabricator.wikimedia.org/T266741 (10thiemowmde) [08:44:06] awight: still stuck with all kinds of permissions issues [08:44:20] not specific to your patch, but it's preventing me from making much progress [10:20:19] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (1050019062) Hi @Aklapper, please I'd like to request access to create projects as I want to use Wikimedia phabricator to manager our affiliate (Igbo Wikimedians User Group) projects.... [10:35:00] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10Lucas_Werkmeist... [10:39:49] 10LibUp, 10Wikidata, 10Wikidata-Bridge, 10wdwb-tech-focus: Support nested package.json files - https://phabricator.wikimedia.org/T228527 (10Legoktm) a:03Legoktm [10:44:03] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Consider phasing out maintenance-sample-workspace-sizes - https://phabricator.wikimedia.org/T266769 (10hashar) [10:44:21] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Consider phasing out maintenance-sample-workspace-sizes - https://phabricator.wikimedia.org/T266769 (10hashar) [10:44:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10User-dancy: Collect samples of workspace sizes on integration-agent-docker-* nodes - https://phabricator.wikimedia.org/T258626 (10hashar) [11:06:45] kostajh: I ran into some, too, about being unable to create mysql system tables, or write to composer.json, depending on whether I tried the --user=root argument to docker or not. [11:07:16] kostajh: I never found the problem, but chown -R nobody on all the mounted folders finally did the trick. [11:19:49] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Consider phasing out maintenance-sample-workspace-sizes - https://phabricator.wikimedia.org/T266769 (10hashar) The task follow up a quick chat I had with @dancy. I really really like that feature, I am afraid might n... [11:20:43] kostajh: If other dockerfiles are working for you, then IMO it makes sense to paste the errors you get to the phabricator task, maybe I can help debug. [11:48:21] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Aklapper) @50019062: Hi, if you only need a project, then please follow https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Creating_new_projects - thanks! [11:59:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10hashar) [11:59:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10hashar) p:05Triage→03Unbreak! [12:00:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) [12:00:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10hashar) [12:05:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) @Lucas... [12:06:58] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Move CI instances to use ceph in WMCS - https://phabricator.wikimedia.org/T260916 (10hashar) Turns out Ceph adds a lot of latency and affects the CI jobs. Filed T266777 I guess we ca... [12:30:10] awight: ok, let me try those things [12:34:59] 10Project-Admins: Igbo Wiki UG - https://phabricator.wikimedia.org/T266781 (1050019062) [14:18:45] 10Phabricator (Upstream), 10Upstream: Cannot move cards to workboards on mobile devices without drag and drop functionality - https://phabricator.wikimedia.org/T85370 (10Aklapper) You can move a task to a different workboard column via the "Add Action..." dropdown in the single-task view. [14:26:56] !log restarted Jenkins on releases1002 (java upgrade) [14:26:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:40:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10Andrew) If you have specific iops or throughput numbers that... [14:54:30] (03PS1) 10Lars Wirzenius: perf: add timestamps to check, train-dev output [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 [15:08:02] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10Jdforrester-WMF) Shall we revert the switch indent fixer for now and do a new release? Or can it be fixed quickly? [15:16:52] (03PS1) 10Ottomata: Add CI for node-rdkafka-factory [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) [15:18:19] (03CR) 10Ppchelko: [C: 03+1] Add CI for node-rdkafka-factory [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [15:19:25] 10Phabricator: Herald_rule_for_adding the Discovery-Search team tag to any task tagged with #CirrusSearch - https://phabricator.wikimedia.org/T266795 (10CBogen) [15:22:29] 10Project-Admins, 10Discovery-Search (Current work): Do not dump WikibaseCirrusSearch codebase tasks into some #Discovery-Search team project tag only - https://phabricator.wikimedia.org/T263725 (10CBogen) > That's also an option. In that case, all existing WikibaseCirrusSearch tasks should be tagged with #ci... [15:45:41] (03PS2) 10Lars Wirzenius: perf: add timestamps to check, train-dev output [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 [15:48:24] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10DannyS712) [15:58:15] 10Project-Admins: #IgboWiki-UG-Projects - https://phabricator.wikimedia.org/T266781 (1050019062) [16:06:32] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10thiemowmde) I vote for disabling it. It appears like we might need to rewrite the entire sniff. Let's not rush but take our time to do this right. [16:08:38] 10Project-Admins: #IgboWiki-UG-Projects - https://phabricator.wikimedia.org/T266781 (1050019062) Hello @Aklapper, Sorry for the disturbance, the process is not as easy as creating a board in Trello. I have followed the process in the link you sent me. So, I am to just wait for the project to be created? Also, I... [16:16:05] (03PS1) 10Jforrester: Revert "Add PSR2.ControlStructures.SwitchDeclaration" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637062 (https://phabricator.wikimedia.org/T266739) [16:16:54] 10MediaWiki-Codesniffer, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21): Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Jdforrester-WMF) Probably going to have to revert this. {T266739}. [16:18:35] James_F: I fixed some things with the broken-puppet nag emails; did you just got a couple? [16:18:54] Of course systems that already have broken puppet won't get this feature fixed because puppet is broken so they won't be able to tell you that puppet is broken :) [16:19:03] andrewbogott: Yes! Thank you. [16:19:08] cool [16:19:58] James_F: I also removed jkroll from the project because their emails were bouncing; I assume they've moved on from wmde [16:21:26] * James_F doesn't know, but sounds plausible. [16:25:46] andrewbogott: … and of course people are getting these e-mails for the first time ever and freaking out. :-) [16:25:56] good! [16:26:21] that feature must've been broken for a good long time [16:26:28] Definitely years. [16:26:48] Aha, yes. [16:27:02] Last deployment-prep puppet failure warning I got was on 25 January 2019. [16:55:54] (03CR) 10Jforrester: [C: 03+2] "These repo names are really out of control. But oh well." [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [16:57:23] (03Merged) 10jenkins-bot: Add CI for node-rdkafka-factory [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [16:57:29] (03PS2) 10DannyS712: Revert "Add PSR2.ControlStructures.SwitchDeclaration" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637062 (https://phabricator.wikimedia.org/T266739) (owner: 10Jforrester) [16:57:33] (03CR) 10DannyS712: [C: 03+2] Revert "Add PSR2.ControlStructures.SwitchDeclaration" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637062 (https://phabricator.wikimedia.org/T266739) (owner: 10Jforrester) [16:57:39] !log Zuul: Add CI for node-rdkafka-factory T266058 [16:57:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:57:41] T266058: Make node-rdkafka an optional dependency of EventGate - https://phabricator.wikimedia.org/T266058 [16:58:05] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10DannyS712) Gave a +2 for the revert Does this warrant releasing 32.0.1 (or 32.1.0)? [16:58:29] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10hashar) [[ https://wm-bot.wmflabs.org/logs/%23wikimedia-rele... [16:58:57] (03Merged) 10jenkins-bot: Revert "Add PSR2.ControlStructures.SwitchDeclaration" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637062 (https://phabricator.wikimedia.org/T266739) (owner: 10Jforrester) [17:05:10] James_F for codesniffer should we release 32.0.1 (or 32.1.0)? If so, would you mind doing the honors when you have a chance? [17:14:01] (03CR) 10Ottomata: "> Patch Set 1: Code-Review+2" [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [17:14:07] (03CR) 10Ottomata: "TY btw!" [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [17:53:14] (03PS4) 10Addshore: Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [17:55:12] (03PS5) 10Addshore: Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [17:55:17] (03CR) 10Addshore: [C: 03+2] Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [17:57:00] how easy is it to backport things into codensiffer? :P [17:57:10] (03Merged) 10jenkins-bot: Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/603495 (https://phabricator.wikimedia.org/T164653) (owner: 10Thiemo Kreuz (WMDE)) [17:57:21] Or rather, could be make a 32.1.0 with ^^ that patch included? It is disabled by default :P [17:57:39] oh DannyS712 you were just talking about making a new release....? [17:58:31] cc James_F (just incase your making the release right now) [18:10:05] I made https://phabricator.wikimedia.org/T266823 which will be fun (but needs the next release) [18:39:52] (03CR) 10Jforrester: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [18:56:23] (03CR) 10Ottomata: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/637514 (https://phabricator.wikimedia.org/T266058) (owner: 10Ottomata) [19:05:40] (03CR) 10Ahmon Dancy: [C: 03+1] "Just a typo in the commit message. Looks okay to me otherwise so I'll +1." (032 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 (owner: 10Lars Wirzenius) [19:06:19] addshore: What rules have not yet been moved? [19:06:31] addshore: (And can their tasks be added as sub-tasks?) [19:07:20] James_F: all the needed rules have now been moved from wikibase-codensiffer to mediawiki codesniffer [19:07:28] https://gerrit.wikimedia.org/r/603495 was the last one [19:07:29] Ah, so it's done? [19:07:47] yes, but that missed the 32 cutoff :P [19:08:12] `Expand FunctionCommentSniff to error on `object[]` typehints`? [19:25:38] ClassLevelLicenseSniff [19:25:58] * addshore looks at the diff [19:27:33] https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/v32.0.0...master yes I only care about ClassLevelLicenseSniff [19:43:45] (03CR) 10Hashar: [C: 03+1] "I guess it conflict with the removal of php-compile-php70-docker." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/634626 (owner: 10Jforrester) [21:12:09] if we have to push a revert out, probably doing a 33 is easiest [21:29:38] (03PS1) 10Cwhite: Add ECS build and automated documentation publishing. [integration/config] - 10https://gerrit.wikimedia.org/r/637569 (https://phabricator.wikimedia.org/T234565) [22:01:48] I don't think this would qualify as a *major* version change in semver, suggest 32.1.0 [22:51:51] yeah, I just realized the sniff is optional [22:51:52] okay