[04:59:02] (03PS1) 10Jforrester: Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 [05:02:49] DannyS712: The change to FunctionCommentSniff is a breaking change, regardless of other changes, right? [05:04:22] (03PS2) 10Jforrester: Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 [11:11:09] (03CR) 10Awight: [C: 03+2] "Thanks for cleaning up this logic, I think I introduced several slight regressions with that patch..." [integration/quibble] - 10https://gerrit.wikimedia.org/r/629057 (https://phabricator.wikimedia.org/T263500) (owner: 10Hashar) [11:26:56] awight: thanks ;) [11:33:11] (03Merged) 10jenkins-bot: Only run linters for extensions/skins [integration/quibble] - 10https://gerrit.wikimedia.org/r/629057 (https://phabricator.wikimedia.org/T263500) (owner: 10Hashar) [13:22:11] James_F I guess so - it adds an error where there wasn't one previously [13:22:26] Yup. [13:23:37] (03CR) 10DannyS712: Release v33.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [14:00:17] (03CR) 10Lars Wirzenius: "Thanks for the feedback, pushing new patch set soon." (032 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 (owner: 10Lars Wirzenius) [14:00:32] (03PS3) 10Lars Wirzenius: perf: add timestamps to check, train-dev output [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 [15:13:21] (03CR) 10Ahmon Dancy: [C: 03+2] perf: add timestamps to check, train-dev output [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 (owner: 10Lars Wirzenius) [15:13:30] (03Merged) 10jenkins-bot: perf: add timestamps to check, train-dev output [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637506 (owner: 10Lars Wirzenius) [15:40:44] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Make a Scap release - https://phabricator.wikimedia.org/T266676 (10LarsWirzenius) p:05Triage→03High [15:44:55] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, and 2 others: Create some automation for management of gerrit/phabricator/github mirrors - https://phabricator.wikimedia.org/T235874 (10greg) a:05releng-list→03None [15:45:27] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, and 2 others: Create some automation for management of gerrit/phabricator/github mirrors - https://phabricator.wikimedia.org/T235874 (10greg) [15:45:31] (03PS1) 10Lars Wirzenius: perf: set Qemu cache mode to unsafe in ./check, for speed [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637716 [15:48:27] (03CR) 10Ahmon Dancy: [C: 04-1] perf: set Qemu cache mode to unsafe in ./check, for speed (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637716 (owner: 10Lars Wirzenius) [15:50:06] (03PS3) 10Addshore: Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [15:50:09] (03CR) 10Addshore: [C: 03+1] Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [15:50:12] (03PS2) 10Lars Wirzenius: perf: set Qemu cache mode to unsafe in ./check, for speed [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637716 [15:51:03] (03CR) 10Jforrester: Release v33.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [15:51:19] (03CR) 10Jforrester: [C: 04-1] Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [15:51:37] addshore: You made it wrong. :-P [15:51:46] >.> [15:52:37] (03CR) 10Lars Wirzenius: perf: set Qemu cache mode to unsafe in ./check, for speed (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/637716 (owner: 10Lars Wirzenius) [15:53:08] (03CR) 10Addshore: [C: 03+1] Release v33.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (owner: 10Jforrester) [15:53:39] addshore: The previous state is it being disabled? [15:53:42] * James_F is lost. [15:55:05] hmm, I dont mine either way, re-disable sounds weird though [15:55:24] it leaves me with questions, whereas "disable" does not [15:55:33] You should indeed have questions. [15:55:38] This is an emergency release. [15:55:42] Questions are appropriate. :-) [15:56:02] yeah, Re-disabled to me implies it was explicitely disabled at some point earlier, but there is no history entry that it was disabled, just enabled the first time [15:56:09] I'd expect something like "Disable foo because bar (was enabled in 123) [15:56:31] Yeah, that's in the changelog but not the commit message. [15:57:13] If you want me to explicitly say "enabled yesterday, whoops!" we can, but… [15:57:41] James_F I have to run, whatever you two decide is okay with me (important thing is getting the release out) but can I suggest tagging T266739 in the commit message so that its clear what task is associated with the need to release? [15:57:42] T266739: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 [15:58:04] DannyS712: We don't normally tag the affected tasks, but we could start? [15:58:48] I was thinking about filing a task for regularizing the release process, and could only find tasks for a few releases, so I think starting to tag them might be a good idea, but its not that important [15:58:57] I'll be back in an hour and can help if there is anything left to do [15:59:03] Ack. [16:04:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10Andrew) I've resized integration-agent-docker-1020 to a flav... [16:04:28] (03PS4) 10Jforrester: Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (https://phabricator.wikimedia.org/T164653) [16:04:35] addshore: How's that? [16:05:02] (03CR) 10Addshore: [C: 03+1] Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (https://phabricator.wikimedia.org/T164653) (owner: 10Jforrester) [16:05:21] (03CR) 10Jforrester: [C: 03+2] Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (https://phabricator.wikimedia.org/T164653) (owner: 10Jforrester) [16:05:27] Thanks. :-) [16:06:55] (03Merged) 10jenkins-bot: Release v33.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637591 (https://phabricator.wikimedia.org/T164653) (owner: 10Jforrester) [16:18:32] (03PS11) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) [16:18:59] (03PS9) 10AndyRussG: Create buster-rsyslog image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/635361 (https://phabricator.wikimedia.org/T262976) [16:22:08] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: replace production deployment servers - https://phabricator.wikimedia.org/T265963 (10Cmjohnson) [16:59:32] * DannyS712 is back [17:00:21] James_F for tagging the task I meant the specific one for the bad autofix, or a general one for releasing a new version (like there was for 32) not each of the specific tasks that had a sniff being release, though I guess it doesn't matter now [17:13:45] (03CR) 10Ammarpad: [C: 03+2] Add FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [17:14:47] DannyS712: Ah, sorry. For OOUI, we tag each of the fixes in the release, so… [17:15:44] No problem [17:16:52] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Operations, and 3 others: Scap is checking canary servers in dormant instead of active-dc - https://phabricator.wikimedia.org/T204907 (10akosiaris) 05Open→03Resolved This was done, resolving. [17:17:40] 10MediaWiki-Codesniffer, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10DannyS712) [17:18:15] ^ James_F which of your phab accounts should I subscribe to that task? [17:18:37] 10MediaWiki-Codesniffer, 10PM, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10DannyS712) [17:20:11] 10MediaWiki-Codesniffer, 10PM, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10DannyS712) [17:24:14] DannyS712: Work-me. :-) [17:24:38] (03Merged) 10jenkins-bot: Add FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/628209 (https://phabricator.wikimedia.org/T263188) (owner: 10DannyS712) [17:25:59] I wasn't sure - you are `James_F` here, `Jforrester` on gerrit, and either `Jdforrester-WMF` or personal on phab - too many names :) [17:26:36] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10User-DannyS712: Create sniff to find combination of final and private modifier on php functions - deprecated with php8 - https://phabricator.wikimedia.org/T263188 (10DannyS712) 05Open→03Resolved [17:27:00] I'm sure I'll find a way to make it more confusing with GitLab. ;-) [17:28:23] 10MediaWiki-Codesniffer, 10PM, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10DannyS712) Also, would it be possible to have @ReleaseTaggerBot comment on the underlying bug tasks, so that it can be clear when new patches or changes when be... [17:28:54] oh no *sarcasm* [17:29:11] (03CR) 10Hashar: [C: 04-1] "I am building it locally to verify it." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/637569 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [17:29:24] also would you mind looking at https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/599482 ? its blocking some other phpunit sniffs [17:31:30] (03PS2) 10Hashar: Add ECS build and automated documentation publishing. [integration/config] - 10https://gerrit.wikimedia.org/r/637569 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [17:34:05] (03CR) 10Hashar: [C: 03+2] "Built and works!" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/637569 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [17:35:32] (03Merged) 10jenkins-bot: Add ECS build and automated documentation publishing. [integration/config] - 10https://gerrit.wikimedia.org/r/637569 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [17:48:07] shdubsh: I am building the image for ecs and will deploy the job. Will report back on the task ;) [17:48:22] \o/ Thanks! [17:48:35] !log Successfully tagged docker-registry.discovery.wmnet/releng/ecs:0.0.1-1 # T234565 [17:48:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:48:38] T234565: Standardize the logging format - https://phabricator.wikimedia.org/T234565 [17:48:45] shdubsh: your patch was an excellent start! [17:49:01] (03PS1) 10Hashar: Add jobs for operations/software/ecs [integration/config] - 10https://gerrit.wikimedia.org/r/637743 (https://phabricator.wikimedia.org/T234565) [17:49:29] shdubsh: and that patch ^^ slightly enhance the thing you did for jenkins [17:49:40] we dont want to publish the doc after each patchset uploaded [17:50:47] yeah, ideally we want to publish only after every update to the changelog [17:51:08] https://integration.wikimedia.org/ci/job/ecs/1/console :] [17:51:23] so at least the job works [17:52:04] essentially I have crafted a second job that does the publishing [17:52:10] named 'ecs-publish' [17:52:19] and at https://gerrit.wikimedia.org/r/c/integration/config/+/637743/1/zuul/layout.yaml I have added a filter to only trigger it for the master branch [17:52:40] shdubsh: and we can add a filter to only run it when a merged change touched the changelog file [17:52:47] or just not bother and always run it ;) [17:54:23] Either way works for me. Maybe start simple and enhance as need arises? [17:54:43] (03PS2) 10Hashar: Add jobs for operations/software/ecs [integration/config] - 10https://gerrit.wikimedia.org/r/637743 (https://phabricator.wikimedia.org/T234565) [17:55:00] yeah [17:55:02] shdubsh: https://doc.wikimedia.org/ecs/ ;) [17:55:04] from my test run [17:55:10] the console log is https://integration.wikimedia.org/ci/job/ecs-publish/1/console [17:55:17] /bin/sh: 1: source-highlight: not found [17:55:43] guess we want that package in the image [17:55:57] source-highlight: /usr/bin/source-highlight [17:55:57] source-highlight: /usr/bin/source-highlight-esc.sh [17:56:42] heh, that might be why some of the preformatted blocks aren't rendered [17:57:18] guess you can add it to dockerfiles/ecs/Dockerfile.template and bump the changelog entry [17:57:22] we then rebuild a new image [17:57:28] and I rebase the change to make use of that new image [18:02:27] (03PS1) 10Cwhite: Add source-highlight dependency to ecs build container. Bump ecs to 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/637746 [18:02:29] (03CR) 10jerkins-bot: [V: 04-1] Add source-highlight dependency to ecs build container. Bump ecs to 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/637746 (owner: 10Cwhite) [18:03:15] (03PS2) 10Cwhite: Add source-highlight dependency to ecs build container. Bump ecs to 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/637746 [18:04:12] (03CR) 10jerkins-bot: [V: 04-1] Add source-highlight dependency to ecs build container. Bump ecs to 0.0.2 [integration/config] - 10https://gerrit.wikimedia.org/r/637746 (owner: 10Cwhite) [18:05:59] (03PS3) 10Cwhite: Add source-highlight dependency to ecs build container. [integration/config] - 10https://gerrit.wikimedia.org/r/637746 [18:06:10] (03CR) 10jerkins-bot: [V: 04-1] Add source-highlight dependency to ecs build container. [integration/config] - 10https://gerrit.wikimedia.org/r/637746 (owner: 10Cwhite) [18:06:11] :D [18:06:20] (03PS4) 10Cwhite: Add source-highlight dependency to ecs build container. [integration/config] - 10https://gerrit.wikimedia.org/r/637746 [18:07:38] (03CR) 10Hashar: [C: 03+2] Add source-highlight dependency to ecs build container. [integration/config] - 10https://gerrit.wikimedia.org/r/637746 (owner: 10Cwhite) [18:08:57] (03Merged) 10jenkins-bot: Add source-highlight dependency to ecs build container. [integration/config] - 10https://gerrit.wikimedia.org/r/637746 (owner: 10Cwhite) [18:09:54] (03PS3) 10Hashar: Add jobs for operations/software/ecs [integration/config] - 10https://gerrit.wikimedia.org/r/637743 (https://phabricator.wikimedia.org/T234565) [18:16:11] !log Successfully tagged docker-registry.discovery.wmnet/releng/ecs:0.0.2-1 # T234565 [18:16:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:16:14] T234565: Standardize the logging format - https://phabricator.wikimedia.org/T234565 [18:16:38] https://integration.wikimedia.org/ci/job/ecs-publish/2/console [18:16:52] 18:16:41 asciidoc: WARNING: index.asciidoc: line 5: include file not found: /usr/bin/../../shared/versions/stack/current.asciidoc [18:16:52] 18:16:41 asciidoc: WARNING: index.asciidoc: line 6: include file not found: /usr/bin/../../shared/attributes.asciidoc [18:16:57] probably less of an issue [18:17:08] https://doc.wikimedia.org/ecs/ ! [18:18:02] (03CR) 10Hashar: [C: 03+2] "Works!" [integration/config] - 10https://gerrit.wikimedia.org/r/637743 (https://phabricator.wikimedia.org/T234565) (owner: 10Hashar) [18:18:22] shdubsh: the last thing we want is an entry at doc.wikimedia.org which can be done via integration/docroot [18:19:23] (03Merged) 10jenkins-bot: Add jobs for operations/software/ecs [integration/config] - 10https://gerrit.wikimedia.org/r/637743 (https://phabricator.wikimedia.org/T234565) (owner: 10Hashar) [18:21:33] (03PS1) 10Hashar: Add entry for operations/software/ecs [integration/docroot] - 10https://gerrit.wikimedia.org/r/637749 (https://phabricator.wikimedia.org/T234565) [18:22:14] shdubsh: https://gerrit.wikimedia.org/r/c/integration/docroot/+/637749/1/org/wikimedia/doc/opensource.yaml that should do it ;) [18:24:26] (03PS1) 10Cwhite: add ECS to doc.wm.o index [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) [18:25:16] (03Abandoned) 10Hashar: Add entry for operations/software/ecs [integration/docroot] - 10https://gerrit.wikimedia.org/r/637749 (https://phabricator.wikimedia.org/T234565) (owner: 10Hashar) [18:25:28] I think I got it: https://gerrit.wikimedia.org/r/c/integration/docroot/+/637750 [18:25:41] yeah [18:25:53] (03CR) 10Hashar: [C: 03+2] add ECS to doc.wm.o index [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [18:26:23] Thanks! [18:26:53] remembers me I have a migration to finish for doc.wm.o :/ [18:27:12] (03Merged) 10jenkins-bot: add ECS to doc.wm.o index [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [18:29:17] shdubsh: deployed. That will show up on doc.wikimedia.org eventually [18:29:47] Great! Thank you for the help! :) [18:31:07] shdubsh: thanks for taking care of the initial setup! [18:32:09] shdubsh: it is week end time for me. My best wishes to the ECS project! [18:32:23] Have a good one :) [18:40:05] 10MediaWiki-Codesniffer, 10PM, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10Jdforrester-WMF) >>! In T266890#6592043, @DannyS712 wrote: > Also, would it be possible to have @ReleaseTaggerBot comment on the underlying bug tasks, so that it... [19:08:22] James_F nitpick too small to warrant leaving a comment on the patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/637762 uses v before the version numbers, but the other patches in that chain don't :( [19:19:18] Danny: Yup, that’s “traditional” [19:19:41] No idea why we have different tag numbers for different CI tools, but oh well. [19:19:48] then its missing from the other patches... it really doesn't matter, just bugs me [19:51:08] (03CR) 10Jeena Huneidi: [C: 03+2] WVUI pipeline update [integration/config] - 10https://gerrit.wikimedia.org/r/631864 (https://phabricator.wikimedia.org/T264244) (owner: 10Nikki Nikkhoui) [19:52:04] * DannyS712 is live debugging on the beta cluster [19:54:59] (03CR) 10jerkins-bot: [V: 04-1] WVUI pipeline update [integration/config] - 10https://gerrit.wikimedia.org/r/631864 (https://phabricator.wikimedia.org/T264244) (owner: 10Nikki Nikkhoui) [19:56:19] 10MediaWiki-Codesniffer, 10PM, 10User-DannyS712: Establish a regular release process for codesniffer - https://phabricator.wikimedia.org/T266890 (10Legoktm) When I was the primary maintainer, I would aim to do a release roughly every month, as long as there were substantial changes. Often times we'd use PHPC... [19:57:16] (03CR) 10Jeena Huneidi: [C: 03+2] "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/631864 (https://phabricator.wikimedia.org/T264244) (owner: 10Nikki Nikkhoui) [19:59:55] (03Merged) 10jenkins-bot: WVUI pipeline update [integration/config] - 10https://gerrit.wikimedia.org/r/631864 (https://phabricator.wikimedia.org/T264244) (owner: 10Nikki Nikkhoui) [20:07:53] !log reloading Zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/631864 [20:07:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:12:10] composer treats the "v" prefix as optional, IMO it's really annoying and I wish it didn't but too late now... [20:12:24] I think it's mostly historical in that if the first person tagged it with a v, then later people tend to follow [20:38:00] sorry, forgot to say, done debugging on the beta cluster [20:39:45] woops, no I'm not, haven't synced the revert [21:15:56] finally managed to start the sync, so main conflicts with Jenkins [21:17:42] okay, actually done [21:31:59] 10MediaWiki-Codesniffer: Suggestion to add rule for sniffing phpDoc ref tags - https://phabricator.wikimedia.org/T208448 (10DannyS712) Should be covered by {35f0b718fe28d4a28a2cc4e9787f096102bcee7a} by @Umherirrender suggest closing as resolved [21:37:01] (03PS8) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [21:49:31] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/637786 (https://phabricator.wikimedia.org/T265228) (owner: 10DannyS712) [22:27:14] 10VPS-project-codesearch: Codesearch doesn't index operations/deployment-charts - https://phabricator.wikimedia.org/T266909 (10Tgr) [22:56:19] 10VPS-project-codesearch, 10Patch-For-Review, 10User-Ladsgroup: Codesearch doesn't index operations/deployment-charts - https://phabricator.wikimedia.org/T266909 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup This is done now: https://codesearch.wmcloud.org/operations/?q=termbox [23:00:22] 10VPS-project-codesearch, 10User-Ladsgroup: Codesearch doesn't index operations/deployment-charts - https://phabricator.wikimedia.org/T266909 (10Nintendofan885)