[00:28:19] (03PS4) 10Dduvall: Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 [00:46:54] 10Phabricator, 10Developer-Advocacy, 10Epic, 10Patch-For-Review: (Semi)automatically close Phabricator tickets with status "stalled" after a while - https://phabricator.wikimedia.org/T252522 (10Dzahn) {P13130} [01:21:17] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [01:23:51] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [01:24:45] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10serviceops: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) >>! In T245757#6533938, @Dzahn wrote: > A new ticket for this has been created at T264991. Ignore m... [02:29:27] (03PS1) 10Jeena Huneidi: Restrict credentials use in pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/638244 [02:31:46] (03CR) 10Jeena Huneidi: [C: 03+2] Restrict credentials use in pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/638244 (owner: 10Jeena Huneidi) [02:31:47] (03Merged) 10jenkins-bot: Restrict credentials use in pipeline [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/638244 (owner: 10Jeena Huneidi) [02:41:03] (03PS9) 10Jeena Huneidi: [DNM] This is a test [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/612410 [02:41:05] (03CR) 10jerkins-bot: [V: 04-1] [DNM] This is a test [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/612410 (owner: 10Jeena Huneidi) [02:43:00] (03PS10) 10Jeena Huneidi: [DNM] This is a test [blubber-doc/example/helloworldoid] (kubernetes-tutorial) - 10https://gerrit.wikimedia.org/r/612410 [02:43:44] 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T263182 (10ppelberg) [02:45:04] 10Release-Engineering-Team (Logspam), 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), and 2 others: Call to undefined method MediaWiki\Extension\DiscussionTools\HeadingItem::addWarning() - https://phabricator.wikimedia.org/T267035 (10ppelberg) 05Ope... [06:14:18] 10Continuous-Integration-Config, 10Math, 10Platform Engineering, 10Platform Engineering Roadmap Decision Making: Enable mediawiki-quibble-apitests-vendor-docker for extension Math - https://phabricator.wikimedia.org/T254031 (10Physikerwelt) @Jdforrester-WMF do you see a way forward here? [06:20:51] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid and other remaining services to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10Physikerwelt) What remains to be done here? [06:21:10] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid and other remaining services to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10Physikerwelt) p:05Triage→03Medium [06:52:08] 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T263182 (10Nikerabbit) [09:53:40] 10Project-Admins, 10MediaWiki-extensions-Maintenance, 10WMDE-Technical-Wishes-Maintenance, 10WMDE-Technical-Wishes-Team, and 2 others: Archive DeepCat and CatGraph related code and boards - https://phabricator.wikimedia.org/T243543 (10thiemowmde) [09:53:50] 10Project-Admins, 10MediaWiki-extensions-Maintenance, 10WMDE-Technical-Wishes-Maintenance, 10WMDE-Technical-Wishes-Team, and 2 others: Archive DeepCat and CatGraph related code and boards - https://phabricator.wikimedia.org/T243543 (10thiemowmde) [09:54:18] 10MediaWiki-Codesniffer: Forbid use of class ReflectionObject and suggest use of TestingAccessWrapper::newFromObject instead - https://phabricator.wikimedia.org/T266871 (10Umherirrender) 05Open→03Declined There are too much cases where the use of ReflectionClass is still valid and not possible to replace wit... [10:47:43] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10Aklapper) Patch has been merged; is there more to do here or can this task be resolved? Thanks! [10:55:31] (03CR) 10Hashar: [C: 03+2] Explicit registry for backends [integration/quibble] - 10https://gerrit.wikimedia.org/r/629086 (owner: 10Awight) [10:56:40] (03CR) 10Hashar: [C: 03+2] "The change entered gate-and-submit after I have +2ed parent change https://gerrit.wikimedia.org/r/c/integration/quibble/+/629086/3" [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:00:30] (03CR) 10Hashar: [C: 04-2] Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:14:03] (03CR) 10Hashar: [C: 04-2] "Will incorporate some bit from the child change, specially https://gerrit.wikimedia.org/r/c/integration/quibble/+/630843" (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:22:11] (03Merged) 10jenkins-bot: Explicit registry for backends [integration/quibble] - 10https://gerrit.wikimedia.org/r/629086 (owner: 10Awight) [11:22:13] (03CR) 10jerkins-bot: [V: 04-1] Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:24:46] (03CR) 10Kosta Harlan: "> Patch Set 22:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [11:25:01] (03CR) 10Kosta Harlan: "> Patch Set 22:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [11:26:50] 10Project-Admins, 10WMDE-Technical-Wishes-Maintenance, 10WMDE-Technical-Wishes-Team, 10Technical-Debt, 10User-thiemowmde: Archive DeepCat and CatGraph related code and boards - https://phabricator.wikimedia.org/T243543 (10thiemowmde) [11:32:06] (03CR) 10Awight: "> Not related to this change I'm sure, but when I run that I now get:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [11:49:13] (03PS6) 10Hashar: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:49:24] awight: kostajh sorry gotta lunch I am late today :-\ [11:49:25] (03CR) 10jerkins-bot: [V: 04-1] Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:49:33] and I broke the patch :-\\ [11:49:40] hashar: Thanks for the review, and the challenge ;-) [11:49:46] hashar: it's ok. We could chat here [11:49:54] when you're back [11:50:16] I thought I could squash a couple changes but obbviously failed since CI complains [11:51:08] stupid flake 8 [11:51:33] well having lunch now with my wife, laptop is on the table 8)) [11:51:50] (03PS7) 10Hashar: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:51:52] (03CR) 10jerkins-bot: [V: 04-1] Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:53:07] :( [11:54:35] (03PS8) 10Hashar: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:55:24] (03CR) 10jerkins-bot: [V: 04-1] Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:57:24] 10Diffusion, 10Phabricator, 10Security: Diffusion 'view raw file' policy and behavior is unclear and inconsistent - https://phabricator.wikimedia.org/T149152 (10Aklapper) >>! In T149152#2975095, @mmodell wrote: > unassigning. I won't work on this until I have security review. @mmodell: Was / should a securi... [11:58:42] (03PS9) 10Hashar: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [11:59:45] hashar: Your wife is giving very good debugging suggestions! [12:00:00] (03CR) 10Hashar: "Need rebase ;)" (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 (owner: 10Awight) [12:02:39] (03CR) 10Hashar: Implement webserver engines as subclasses (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [12:08:34] (03PS3) 10Awight: Different default ports for each backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 [12:08:45] (03CR) 10Awight: "PS 3: manual rebase" [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 (owner: 10Awight) [12:09:35] (03PS23) 10Awight: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [12:09:47] (03CR) 10Awight: "PS 23: manual rebase" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [12:19:14] 10Phabricator, 10WMF-Legal: Phabricator Macros and other media are to have clear copyright status - https://phabricator.wikimedia.org/T128771 (10valerio.bozzolan) >>! In T128771#3667998, @mmodell wrote: > * `Non-commercial use` - they are not in any way commercial. (Well, a CC BY-SA authorizes whatever purpos... [12:40:18] ok back [12:42:31] (03PS10) 10Hashar: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [12:44:05] (03CR) 10Hashar: [C: 03+1] "Good to me now, one might want to review the few changes I have introduced while squashing the child change. Will happilly +2 it." [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [13:22:49] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) >>! In T252914#6599688, @Aklapper wrote: > Patch has been merged; is there more to do here or can this task be resolved? Thanks! There is more to do [13:29:26] 10Project-Admins, 10Research: Archive Phabricator project #Research-Archive ? - https://phabricator.wikimedia.org/T265805 (10Aklapper) Hi #Research, any idea who could answer this or who's "in charge" of Phab tags in Research? (@leila?) Thanks in advance! [14:07:21] 10Project-Admins, 10Projects-Cleanup, 10Unofficial-Apps-Wikipedia-Windows-8: Archive unofficial-apps-wikipedia-windows-8 tag ? - https://phabricator.wikimedia.org/T259930 (10Aklapper) [14:10:37] 10Project-Admins, 10Projects-Cleanup: Archive unofficial-apps-wikipedia-windows-8 tag ? - https://phabricator.wikimedia.org/T259930 (10Aklapper) [14:14:13] 10Gerrit: Gerrit link to Sonar cloud reports are broken - https://phabricator.wikimedia.org/T267028 (10hashar) [14:19:54] 10Gerrit: Gerrit link to Sonar cloud reports are broken - https://phabricator.wikimedia.org/T267028 (10hashar) The javascript to craft the table report is in operations/puppet : `modules/gerrit/files/homedir/review_site/static/gerrit-theme.html`. I think the related code for sonarqube report is: ` lang=javascrip... [14:20:11] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit link to Sonar cloud reports are broken - https://phabricator.wikimedia.org/T267028 (10hashar) [15:07:53] (03CR) 10Awight: [C: 03+1] "Changes seem good!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [15:12:12] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit link to Sonar cloud reports are broken - https://phabricator.wikimedia.org/T267028 (10hashar) a:03hashar I think the report is crafted by https://github.com/kostajh/sonarqube... [15:20:00] (03CR) 10Hashar: [C: 03+2] "I note the integration-quibble-fullrun job now takes 22 minutes. It used to be around 11 if I remember properly. That could be due to vari" [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [15:22:39] kids time & [15:41:42] (03Merged) 10jenkins-bot: Implement webserver engines as subclasses [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [16:07:07] (03CR) 10Ahmon Dancy: [C: 03+1] Optimize submodules operations [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/635886 (owner: 10Dduvall) [16:11:24] (03PS4) 10Hashar: Different default ports for each backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 (owner: 10Awight) [16:11:51] (03CR) 10Hashar: [C: 03+2] "Fixed trivial conflict." [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 (owner: 10Awight) [16:13:14] 10Project-Admins, 10Research: Archive Phabricator project #Research-Archive ? - https://phabricator.wikimedia.org/T265805 (10leila) @Aklapper Please go ahead and archive Research-Archive and let me know if I should do it. To your broader point: we generally don't have people creating tickets for us, so we don... [16:31:00] (03CR) 10Hashar: "Progress! Some nitpicks here and there." (035 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [16:32:53] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Operations, 10serviceops: Make a way to build Scap .deb in Docker - https://phabricator.wikimedia.org/T265501 (10LarsWirzenius) I can't actually find the `package_builder` host and can't check if I have login access or the ability t... [16:35:39] (03Merged) 10jenkins-bot: Different default ports for each backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/630843 (owner: 10Awight) [16:40:32] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Tag Scap release 1.36.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T266676 (10LarsWirzenius) [18:18:00] 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T263182 (10DannyS712) Filed {T267146}, not sure if that should be a blocker [18:26:17] Daimona are you around? [18:26:42] Yep [18:27:13] Do you have some time to discuss T267074 [18:27:13] T267074: Tag, release, and use ObjectFactory 3.0.0 - https://phabricator.wikimedia.org/T267074 [18:27:22] (the parsoid phan patch) [18:28:47] I replied on gerrit, I don't see a clear way forward [18:29:26] would adding ObjectFactory to https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/parsoid/+/f0287cfc81987892d4d2b8a13b61d9209694a7d6/.phan/config.php#60 exclude it as needed? [18:29:50] I agree its a tricky situation [18:30:48] or, can we add the suppression for the entire parsoid repo just for a bit during the migration, and then remove it and suppress inline once Parsoid requires ObjectFactory 3? [18:40:29] These should be viable options [18:40:37] Let's try the former? [18:43:16] okay, will try [19:04:33] Daimona nope, that doesn't work, since it then creates `PhanUndeclaredClassMethod Call to method getObjectFromSpec from undeclared class \Wikimedia\ObjectFactory` errors [19:04:50] I think the best way is to disable it for the repo and enable it again in a few weeks [19:07:29] 10Continuous-Integration-Config: CI job mw-tools-codesniffer-mwcore-testrun fails on clean run - https://phabricator.wikimedia.org/T267150 (10Umherirrender) [19:09:05] (03CR) 10Umherirrender: FunctionCommentSniff: warn if returning void when not expected (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [19:12:05] You have to re-add the local version [19:13:31] 10Continuous-Integration-Config, 10PhabTaskGraph, 10Patch-For-Review: PhabTaskGraph extension cannot find phutil_library - https://phabricator.wikimedia.org/T202515 (10CCicalese_WMF) 05Open→03Resolved a:03CCicalese_WMF [19:14:13] (03PS9) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [19:14:23] (03CR) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [19:15:40] I don't know how to do that. I went with suppression for the repo, and will revert that as soon as possible [19:16:26] (03PS1) 10Lars Wirzenius: chore: clean up shell quoting, other things found by linters [tools/train-dev] - 10https://gerrit.wikimedia.org/r/638672 [19:16:49] Also, you were excluding the local copy [19:16:58] I'd rather go with a stable solution [19:17:04] Since it's actually fairly easy [19:17:36] Let me see [19:17:45] (03CR) 10jerkins-bot: [V: 04-1] FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [19:19:25] You need a $cfg['directory_list'][] = 'vendor/wikimedia/object-factory' [19:20:00] (03PS10) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [19:22:31] (03PS11) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) [19:23:29] And the file esclusion can be $cfg['exclude_file_list'][] = $IP . '/vendor/wikimedia/object-factory/src/ObjectFactory.php'; [19:23:57] Although not perfect, the regexp version should check that it's looking at the core version [19:24:22] (As a side note, it should probably use $VP rather than $IP . '/vendor', here and in other places) [19:25:28] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10Umherirrender) 05Open→03Resolved upstream reported - https://github.com/squizlabs/PHP_CodeSniffer/issues/3157 [19:33:40] Daimona it *finally* has V+2 with repo-wide suppression. I'll try to figure out the better way you suggested, but I have to go soon and phan *really* isn't something I know anything about, so if you have the time and are willing to try I'd be grateful [19:35:13] I've just replied on gerrit. Those are the relevant lines to add. I've verified that it passes locally with them. [19:44:29] Daimona oh, didn't realize you had already figured it out, thanks so much - updated the patch [19:44:45] (03PS1) 10Umherirrender: Move PropertyDocumentationSniff EmptySees check to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/638676 [19:48:56] (03CR) 10Umherirrender: FunctionCommentSniff: warn if returning void when not expected (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [19:50:58] (03CR) 10DannyS712: FunctionCommentSniff: warn if returning void when not expected (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [19:52:18] (03PS1) 10Umherirrender: Allow @inheritDoc to be valid documentation of class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/638679 (https://phabricator.wikimedia.org/T266741) [19:56:10] okay, Daimona now works! [19:56:24] (patch now works, not that Daimona as a person works :) [19:56:49] Noice [19:56:58] any chance you can +2 ? [19:57:03] Eheh I might need fixing as well [19:57:19] huh? Are you broken :) ? [19:58:47] We all are in our own ways. [19:59:21] Wise words [19:59:25] True. I have to go, but I hope you solve whatever is bugging you [19:59:51] Those lines of code were misplaced, looks good aside from this [20:00:17] Sure :) Nothing special bugging me though, fortunately :-) [20:11:25] (03CR) 10Awight: "> I note the integration-quibble-fullrun job now takes 22 minutes. It used to be around 11 if I remember properly. That could be due to va" [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [20:18:50] Daimona what does "virtual +2" mean? [20:38:13] (03CR) 10Hashar: "> Glad that you pointed this out! I checked a few other Quibble patches including the parent of this commit, and execution time for that " [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [20:38:39] 10Release-Engineering-Team, 10Scap, 10Performance-Team (Radar), 10Sustainability (Incident Followup): Localisation cache must be purged after or during train deploy, not (just) before - https://phabricator.wikimedia.org/T263872 (10Krinkle) p:05Triage→03Medium Came up again. What's the minimum we can do... [20:43:02] (03PS1) 10Awight: Mark private interfaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/638704 [20:44:20] (03CR) 10jerkins-bot: [V: 04-1] Mark private interfaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/638704 (owner: 10Awight) [20:46:52] (03PS1) 10Awight: Only the PHP webserver accepts a router [integration/quibble] - 10https://gerrit.wikimedia.org/r/638706 [20:47:04] awight: oh yeah so true ;) [20:48:11] (03CR) 10Hashar: [C: 03+2] Only the PHP webserver accepts a router [integration/quibble] - 10https://gerrit.wikimedia.org/r/638706 (owner: 10Awight) [20:50:11] (03CR) 10Awight: "> The last fast one was on October 20th. I think that is related to the slow IO issue T265615 / T266777" (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [20:50:25] 10Phabricator, 10Diffusion-Repository-Administrators: H367 is now probably obsolete - https://phabricator.wikimedia.org/T267168 (10Urbanecm) [20:53:39] (03CR) 10Hashar: "I am on it :) Still gathering metrics here and there to appropriately track the latency/delay that got introduced." [integration/quibble] - 10https://gerrit.wikimedia.org/r/628759 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [20:58:51] (03PS1) 10Awight: Cleanup: Give generic function a name [integration/quibble] - 10https://gerrit.wikimedia.org/r/638707 [21:00:21] hasharOut: I'm happy to squash these tiny fixups--they would make more sense as a feature branch :-) [21:02:47] (03PS2) 10Awight: Mark private interfaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/638704 [21:04:14] I so badly want to extract some more of the backends up to the container, but * want to see how the apache experiment goes first, and * want to be sure they aren't needed for more convenient local dev. [21:04:29] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Pipeline jobs freezing during teardown - https://phabricator.wikimedia.org/T267075 (10hashar) [21:05:16] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) [21:07:03] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Pipeline jobs freezing during teardown - https://phabricator.wikimedia.org/T267075 (10hashar) 05duplicate→03Resolved The instance got tuned to allow more IO. I have deleted the two other images that were on agent 1009 at 2020-11-03 08:55:01 and 20... [21:07:07] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Pipeline jobs freezing during teardown - https://phabricator.wikimedia.org/T267075 (10hashar) [21:07:11] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, and 2 others: Terminating MySQL takes several minutes in (Wikibase?) CI jobs - https://phabricator.wikimedia.org/T265615 (10hashar) [21:08:50] (03Merged) 10jenkins-bot: Only the PHP webserver accepts a router [integration/quibble] - 10https://gerrit.wikimedia.org/r/638706 (owner: 10Awight) [21:22:21] 10Phabricator: H367 is now probably obsolete - https://phabricator.wikimedia.org/T267168 (10Aklapper) [21:23:36] 10Phabricator: H367 is now probably obsolete - https://phabricator.wikimedia.org/T267168 (10Aklapper) The condition in H367 is `Author is any of Andrew` so I don't see how that's already covered by H356 which has only project tag conditions? [21:28:30] (03PS24) 10Awight: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:28:40] (03CR) 10jerkins-bot: [V: 04-1] Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:28:49] (03CR) 10Awight: Dockerfile launches external apache (035 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:29:24] (03PS25) 10Awight: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:33:05] hashar: Having that apache log after the test run is luxurious :-) The container is running well locally... [21:33:27] awight: yeah I have just mentionned that has a potential idea [21:33:41] I wish I could vote on my comments somehow, or maybe I should be more clear [21:33:43] eg: [21:33:49] "idea for future change: do X" [21:35:17] It turned out to be a one-liner, no problem this time! [21:36:30] I know what you mean, though. It's usually fine to work incrementally, but most of us tend to overcompensate in response to CR, treating everything as if it were a veto... [21:37:14] I expend a lot of redundant words every day trying to make it clear that e.g. typos are non-blocking. [21:38:01] Edits you've been making during to my patches are awesome, thanks for demonstrating this style of active review! [21:38:16] May it inspire me to be less lazy one day ;-) [21:39:33] Cool, I just got a 60 seconds elapsed time for core browser tests using apache, and 62s using built-in PHP. [21:39:46] In other words, no gain but also no regression. [21:40:09] Good starting point for experimenting with worker thread count, browser test paralellism, etc. [21:43:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10git-protocol-v2: Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) Found some more settings mentioned at http://gitblit.com/setup_scaling.html , they come... [21:44:22] awight: yeah good points [21:44:43] awight: I see a change as a feature branch, each patchsets iterating until perfection is reached ;] [21:45:37] awight: anyway sleep time! Don't overwork: ] [21:45:45] I like that Gerrit encourages the perfectionism. [21:46:18] but when small patches are orthogonal I'm tempted to isolate them. old habits... [21:46:24] +1 I'm done for the evening [21:46:39] Just ran a test at wdio.conf.js maxInstances=16 [21:46:42] Interesting! [21:47:21] Apache took it like a champ, but the tests themselves are nowhere near thread-safe. [21:48:16] The first problem I ran into is that we're logging in and out using a single account, so the session and shared state is unstable. [21:48:52] But it's exciting to be facing a new obstacle! [21:48:54] o/ [21:53:13] (03PS26) 10Awight: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:53:21] (03CR) 10Awight: Dockerfile launches external apache (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:53:31] (03CR) 10Awight: "PS 25: manual rebase" [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [21:55:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): integration-quibble-fullrun should use a tmpfs for the mysql database - https://phabricator.wikimedia.org/T267172 (10hashar) [22:00:11] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10hashar) I have further tweaked the Grafana dashboard ([[http...