[00:54:13] 10Release-Engineering-Team-TODO, 10Scap, 10User-brennen: Investigate scap cluster_ssh idling until pressing ENTER repeatedly - https://phabricator.wikimedia.org/T223287 (10thcipriani) Played with this a bit just now. Don't have permission to lsof or strace on the remote since the ssh process is all that's le... [01:00:43] (03PS1) 10Urbanecm: Add gate-and-submit-i18n for wikimedia-cz/web-* [integration/config] - 10https://gerrit.wikimedia.org/r/639644 (https://phabricator.wikimedia.org/T266572) [06:30:24] 10Continuous-Integration-Config, 10Math, 10Platform Engineering, 10Platform Engineering Roadmap Decision Making: Enable mediawiki-quibble-apitests-vendor-docker for extension Math - https://phabricator.wikimedia.org/T254031 (10Physikerwelt) 05Stalled→03Open a:03Jdforrester-WMF The API tests do no lon... [07:39:09] 10Gerrit: Gerrit is giving tips on how to write comments, make sure it does not send our comments to some third party - https://phabricator.wikimedia.org/T258102 (10Ceitqaim) Gerrit is giving tips on how to write comments, make sure it does not send our comments to some third party whole methods are here. You ca... [08:41:43] 10Gerrit: Showing Other navigation and ⧼global-links-menu⧽ in using HasSomeColours skin. - https://phabricator.wikimedia.org/T267386 (10Afewgoodman) [08:49:03] (03CR) 10Hashar: [C: 03+2] Add gate-and-submit-i18n for wikimedia-cz/web-* [integration/config] - 10https://gerrit.wikimedia.org/r/639644 (https://phabricator.wikimedia.org/T266572) (owner: 10Urbanecm) [08:50:10] (03Merged) 10jenkins-bot: Add gate-and-submit-i18n for wikimedia-cz/web-* [integration/config] - 10https://gerrit.wikimedia.org/r/639644 (https://phabricator.wikimedia.org/T266572) (owner: 10Urbanecm) [08:58:19] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Puppet failure on deployment-memc08.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T267388 (10hashar) [08:58:39] 10Beta-Cluster-Infrastructure: Puppet failures on many hosts - https://phabricator.wikimedia.org/T267006 (10hashar) [08:58:41] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Puppet failure on deployment-memc08.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T267388 (10hashar) [09:02:07] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Puppet failure on deployment-memc08.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T267388 (10hashar) 05Open→03Resolved a:03hashar Hiera a... [09:02:09] 10Beta-Cluster-Infrastructure: Puppet failures on many hosts - https://phabricator.wikimedia.org/T267006 (10hashar) [09:03:02] https://phabricator.wikimedia.org/T258102#6608088 spam, if someone wants to wave the magic wand [09:03:08] account is disabled [09:03:10] 10Beta-Cluster-Infrastructure: Puppet failures on many hosts - https://phabricator.wikimedia.org/T267006 (10hashar) [09:05:50] 10Beta-Cluster-Infrastructure: Puppet failures on many hosts - https://phabricator.wikimedia.org/T267006 (10hashar) The email notification had been broken and got fixed hence why we receive them again. For each affected host, one can look at the last few entries in the Puppet log (`sudo tail -n50 /var/log/puppe... [09:06:54] (03CR) 10Hashar: "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/639644 (https://phabricator.wikimedia.org/T266572) (owner: 10Urbanecm) [10:12:32] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Cleanup: Give generic function a name [integration/quibble] - 10https://gerrit.wikimedia.org/r/638707 (owner: 10Awight) [10:13:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Cleanup: fold short lines [integration/quibble] - 10https://gerrit.wikimedia.org/r/627493 (owner: 10Awight) [10:14:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members for zuul [integration/quibble] - 10https://gerrit.wikimedia.org/r/639464 (owner: 10Awight) [10:14:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members for util [integration/quibble] - 10https://gerrit.wikimedia.org/r/639463 (owner: 10Awight) [10:14:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members for mediawiki registry [integration/quibble] - 10https://gerrit.wikimedia.org/r/639462 (owner: 10Awight) [10:14:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members for gitchangedinhead [integration/quibble] - 10https://gerrit.wikimedia.org/r/639461 (owner: 10Awight) [10:15:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members in commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/639460 (owner: 10Awight) [10:15:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PEP 8: private members for cmd [integration/quibble] - 10https://gerrit.wikimedia.org/r/639459 (owner: 10Awight) [10:17:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "This is the first patch in a chain of patches that all do one thing: adding leading underscores to method names to mark them as private. I" [integration/quibble] - 10https://gerrit.wikimedia.org/r/639458 (owner: 10Awight) [10:34:50] (03Merged) 10jenkins-bot: Cleanup: Give generic function a name [integration/quibble] - 10https://gerrit.wikimedia.org/r/638707 (owner: 10Awight) [10:34:52] (03Merged) 10jenkins-bot: Cleanup: fold short lines [integration/quibble] - 10https://gerrit.wikimedia.org/r/627493 (owner: 10Awight) [10:51:10] 10Release-Engineering-Team-TODO, 10Scap, 10User-brennen: Investigate scap cluster_ssh idling until pressing ENTER repeatedly - https://phabricator.wikimedia.org/T223287 (10hashar) Yeah it is messy :\ scap uses `SetupTimeout` while the ssh config uses an upper case `O` for `Out`. But at least on Buster the... [13:43:00] (03CR) 10Hashar: "> Patch Set 1: Code-Review+1" [integration/quibble] - 10https://gerrit.wikimedia.org/r/639458 (owner: 10Awight) [13:43:05] (03CR) 10Hashar: [C: 03+2] PEP 8: private members for backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/639458 (owner: 10Awight) [13:46:13] (03CR) 10Hashar: [C: 03+2] "Oh they all got approved already. Thank you Thiemo and Adam!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/639458 (owner: 10Awight) [14:04:26] (03Merged) 10jenkins-bot: PEP 8: private members for backend [integration/quibble] - 10https://gerrit.wikimedia.org/r/639458 (owner: 10Awight) [14:04:27] (03Merged) 10jenkins-bot: PEP 8: private members for cmd [integration/quibble] - 10https://gerrit.wikimedia.org/r/639459 (owner: 10Awight) [14:06:39] (03Merged) 10jenkins-bot: PEP 8: private members in commands [integration/quibble] - 10https://gerrit.wikimedia.org/r/639460 (owner: 10Awight) [14:07:00] (03Merged) 10jenkins-bot: PEP 8: private members for gitchangedinhead [integration/quibble] - 10https://gerrit.wikimedia.org/r/639461 (owner: 10Awight) [14:07:02] (03Merged) 10jenkins-bot: PEP 8: private members for mediawiki registry [integration/quibble] - 10https://gerrit.wikimedia.org/r/639462 (owner: 10Awight) [14:07:04] (03Merged) 10jenkins-bot: PEP 8: private members for util [integration/quibble] - 10https://gerrit.wikimedia.org/r/639463 (owner: 10Awight) [14:07:07] (03Merged) 10jenkins-bot: PEP 8: private members for zuul [integration/quibble] - 10https://gerrit.wikimedia.org/r/639464 (owner: 10Awight) [16:12:08] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10thcipriani) a:05hashar→03dancy [16:15:19] 10Release-Engineering-Team-TODO, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10thcipriani) >>! In T263184#6606955, @hashar wrote: > If at all possible, can I get the train window at 14:00 local time (CET) which would be 13:00 UTC. That will... [16:15:57] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release, 10Train Deployments: 1.36.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T263186 (10thcipriani) p:05Triage→03Medium a:03hashar [16:17:43] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10thcipriani) p:05Triage→03Medium a:03mmodell [16:22:42] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release, 10Train Deployments: 1.36.0-wmf.22 deployment blockers - https://phabricator.wikimedia.org/T267415 (10thcipriani) p:05Triage→03Medium a:03dduvall [17:47:40] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10dduvall) [17:47:42] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with buildkit's llb.ExecOp.AddMount in aggregate images - https://phabricator.wikimedia.org/T267060 (10dduvall) 05Open→03Invalid This is akin to the experimental `RUN --mount` Dockerfile instr... [18:46:31] 10Phabricator: H367 is now probably obsolete - https://phabricator.wikimedia.org/T267168 (10Aklapper) 05Open→03Stalled Urbanecm: ? [18:49:41] 10Phabricator: H367 is now probably obsolete - https://phabricator.wikimedia.org/T267168 (10Urbanecm) @Aklapper I see. I was under the impression that it is related to Andrew's WMCS work, as it makes no sense to me to assign a WMCS tag to a task in any non-WMCS project. As such, I think the rules are de-facto re... [18:52:23] (03PS1) 10Physikerwelt: Revert "layout: [mediawiki/extensions/Math] Disable API tests, not passing yet" [integration/config] - 10https://gerrit.wikimedia.org/r/639651 (https://phabricator.wikimedia.org/T254031) [18:57:46] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10Ryasmeen) [18:58:08] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10Ryasmeen) [18:59:27] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10Ryasmeen) [20:10:07] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10thcipriani) Hrm, I can recreate this. The MediaWIki host seems to be running just fine afaict, but it takes some time for... [20:17:38] 10Release-Engineering-Team: quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10sbassett) [20:21:16] Hey all - I was going to sec-deploy https://gerrit.wikimedia.org/r/639652 and the related one for .14 but CI on those branches is throwing an unrelated error. This is a simple one-line s/text/escaped/ so I was wondering your thoughts on me just +2ing and deploying. I obviously really don't like overriding tests on prod branches. [20:21:41] ^ went to try and investigate, but https://meta.wikimedia.beta.wmflabs.org/wiki/ is giving "Error: 502, Next Hop Connection" [20:22:08] I'm seeing `Incompatible VMOD netmapper` in beta logstash [20:22:23] Interesting [20:22:34] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: MediaWiki beta varnish is down. - https://phabricator.wikimedia.org/T267439 (10thcipriani) [20:22:55] I guess ^ is the same thing? [20:27:12] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: MediaWiki beta varnish is down. - https://phabricator.wikimedia.org/T267439 (10thcipriani) Noticed that puppet stopped running on beta's `deployment-cache-text06` due to c871b021a44108bed44cd044f5177b075ecb322c After attempting a fix (live hack on dep... [20:27:52] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: MediaWiki beta varnish is down. - https://phabricator.wikimedia.org/T267439 (10thcipriani) p:05Triage→03Unbreak! beta down, setting to UBN [20:29:03] DannyS712: yeah, I was noticing some weirdness on that machien and ran into that problem [20:29:19] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10Reedy) [20:29:24] sbassett for the test failures, the only thing I can think of is that the use of $this->getMsg instead of wfMessage results in, down the line, accessing mediawikiservices [20:29:25] RequestContext::msg = `wfMessage( $key, ...$params )->setContext( $this )` [20:29:25] Message::setContext accesses RequestContext::getLanguage [20:29:25] RequestContext::getLanguage uses services (UserOptionsLookup, HookContainer, ContentLanguage, LanguageFactory) [20:30:15] thcipriani anything I can do to help? [20:30:59] been a while since I've even looked at this part of the stack [20:30:59] DannyS712 - I mean, I can try that, but that shouldn't really make a difference I don't think. [20:31:31] DannyS712: adding in anyone you think could be helpful would be good :) [20:31:51] I know nothing about varnish or puppet, so I don't know who would be helpful, sorry [20:32:10] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10Reedy) p:05Triag... [20:38:27] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10Reedy) 05Open→... [20:39:03] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10DannyS712) @Reedy... [20:39:03] Ok, I think Reedy found my dumb mistake. I picked to 1.35 branches instead of 1.36. Silly. [20:39:19] yeah, but Wikimedia\Services\ServiceContainer should still have existing in 1.35 though? [20:41:35] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10thcipriani) Now I would imagine it's *very* slow since I broke it: T267439 [20:43:16] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10Reedy) >>! In T26... [20:43:30] DannyS712: wmf/1.35.0-wmf.1[46] != REL1_35 [20:43:36] Remember we have branches of vendor too [20:44:09] It was a late addition/extraction in the REL1_35 release cycle [20:44:23] 10Release-Engineering-Team, 10CologneBlue, 10ci-test-error (WMF-deployed Build Failure): quibble-vendor-mysql-php72-docker error: Class 'Wikimedia\Services\ServiceContainer' not found in /workspace/src/includes/MediaWikiServices.php on line 163 - https://phabricator.wikimedia.org/T267437 (10DannyS712) >>! In... [20:44:32] oh, okay [20:45:08] There's possibly something funky going on with fallbacks etc [20:45:26] But as we're not supporting/using those branches, my care is near to zero for working out why it doesn't work :P [20:45:38] yeah, makes sense [20:52:53] (03CR) 10DannyS712: [C: 03+2] Move PropertyDocumentationSniff EmptySees check to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/638676 (owner: 10Umherirrender) [20:54:29] (03Merged) 10jenkins-bot: Move PropertyDocumentationSniff EmptySees check to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/638676 (owner: 10Umherirrender) [20:54:31] (03Merged) 10jenkins-bot: Allow @inheritDoc to be valid documentation of class properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/638679 (https://phabricator.wikimedia.org/T266741) (owner: 10Umherirrender) [21:03:34] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10User-Ryasmeen: MediaWiki beta varnish is down. - https://phabricator.wikimedia.org/T267439 (10thcipriani) 05Open→03Resolved a:03thcipriani Unbreaking puppet seems to have unleashed some interesting behavior: `varnish-modules` was removed, and... [21:21:03] (03CR) 10Urbanecm: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/639644 (https://phabricator.wikimedia.org/T266572) (owner: 10Urbanecm) [21:22:17] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team-TODO, 10Operations, 10Traffic: Beta cluster seems to be extremely slow for logged in user during page navigation - https://phabricator.wikimedia.org/T267435 (10thcipriani) I think the problem is somewhere in the varnish layers; however, I'm concedin... [21:55:26] 10MediaWiki-Codesniffer: Please teach PropertyDocumentation sniff about @inheritDoc - https://phabricator.wikimedia.org/T266741 (10Umherirrender) 05Open→03Resolved p:05Triage→03Medium a:03Umherirrender [22:11:13] (03PS1) 10Ebernhardson: Review access change [search/analytics-integration] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/639659 [22:11:54] (03CR) 10Ebernhardson: [C: 03+2] Review access change [search/analytics-integration] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/639659 (owner: 10Ebernhardson) [22:18:06] (03CR) 10Ebernhardson: [V: 03+2 C: 03+2] "The repository doesn't have CI, so there is no auto-merging happening. Reparenting this to search will give search members merge rights." [search/analytics-integration] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/639659 (owner: 10Ebernhardson) [22:18:54] hmm, apparently can create a repo but will need someone with different rights to apply the corrected access rights [22:47:43] 10VPS-project-codesearch: Remove Petition repo from wmf-deployed Codesearch preset - https://phabricator.wikimedia.org/T267450 (10Krinkle) [22:50:03] 10VPS-project-codesearch: Remove Petition repo from wmf-deployed Codesearch preset - https://phabricator.wikimedia.org/T267450 (10DannyS712) My understanding is that the "deployed" preset is based on the repositories listed in the make release tools (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools... [23:39:37] 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO, 10Code-Stewardship-Reviews: Code Stewardship Review: SpamBlacklist - https://phabricator.wikimedia.org/T224921 (10Krinkle) Still waiting for a code review 1+ year later at 10MediaWiki-Codesniffer: MediaWiki.Classes.UnsortedUseStatements.UnsortedUse gets confused about top level anonymous function use statements - https://phabricator.wikimedia.org/T265348 (10Umherirrender) Have tested with the new version 33.0.0 and it works. Can you update the patch set to see if it also works wit...