[00:18:28] <AndyRussG>	 hi! anyone have any thoughts on resetting my beta cluster password? aaargh can't find it, looks like I may not have put in my e-mail address on the account... apologies for the bother!
[00:18:45] <DannyS712>	 I can do that
[00:19:09] <DannyS712>	 assuming its your mediawiki account on the beta cluster that you are referring to AndyRussG
[00:20:10] <AndyRussG>	 DannyS712: hi! thanks so much! Actually it's "AGreen (WMF)"
[00:20:29] <AndyRussG>	 yes mediawiki account
[00:20:53] <AndyRussG>	 ah heh I thought you were asking if AndyRussG was my user name...
[00:21:09] <AndyRussG>	 (ahhh it's too late in the day for moar coffeeee)
[00:22:43] <DannyS712>	 there is an email account associated with that account (can I say what it is publically? Not sure what the confidentiality rules are for the beta cluster)
[00:26:42] <DannyS712>	 AndyRussG has confirmed that it is their email account, but the issue is https://phabricator.wikimedia.org/T212327
[00:27:05] <AndyRussG>	 DannyS712: :)
[00:27:26] <DannyS712>	 let me see if I can figure something out...
[00:28:09] <Reedy>	 AndyRussG: Do you not have shell access to beta?
[00:28:19] <Reedy>	 We can just give you it so you can change it yourself ;)
[00:28:50] <AndyRussG>	 Reedy: ahhh actually I do
[00:29:36] <Reedy>	 you should be able to do mwscript changePassword.php --wiki=metawiki
[00:29:44] <Reedy>	 Set something crappy, and then change it properly via the web interface
[00:29:53] <AndyRussG>	 DannyS712: Reedy: I should try that then, cool!
[00:30:13] <AndyRussG>	 not familiar with the password-storing-reseting aspects of MW, didn't notice there was a script for that 8p
[00:30:21] <AndyRussG>	 K lemme try then
[00:30:34] <DannyS712>	 um, oops, didn't see this and just reset the password
[00:30:39] <Reedy>	 heh
[00:30:43] <AndyRussG>	 DannyS712: ahhh heh okok
[00:30:50] <DannyS712>	 I've sent AndyRussG the password
[00:31:07] <AndyRussG>	 DannyS712 Reedy thanks so much and apologies for the bother!!!
[00:32:20] <DannyS712>	 !log dannys712@deployment-deploy01:~$ mwscript changePassword.php metawiki --user="AGreen (WMF)" --password=<redacted>
[00:32:22] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[00:32:56] <DannyS712>	 anything else?
[00:34:00] <DannyS712>	 hmm, https://sal.toolforge.org/log/D4yd03UBgTbpqNOm4KOR doesn't seem to have handled the <redacted> well
[00:34:51] <AndyRussG>	 DannyS712 all good here :) thx again
[00:35:14] <AndyRussG>	 heh yeah funny how the <redacted> looks there
[00:35:54] <DannyS712>	 oh lol its handled as raw html and added to the dom...
[00:42:33] <DannyS712>	 filed https://github.com/bd808/SAL/issues/10
[01:55:23] <DannyS712>	 James_F thanks for sending https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/641316 - I was about to do that. Does the core patch also come now, or do we wait until the vendor patch merges?
[02:00:57] <James_F>	 DannyS712: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/641317/ for the core patch. If you don't merge them together all CI is broken. Please leave vendor patches alone, they're very special.
[02:02:00] <DannyS712>	 for the other changes to core that should be done now that its at v.3, should those be done in the same patch as the upgrade or separately?
[02:02:26] <James_F>	 Separately, if possible.
[02:02:31] <DannyS712>	 okay, will do a follow-up
[02:02:45] <James_F>	 If the breaking change makes it impossible to do it distinctly, they'll have to be squashed, of course, but that's non-ideal.
[02:03:14] <DannyS712>	 it should be possible, the breaking change removed deprecated code that I don't thank was used anywhere, including in core
[02:03:21] * James_F nods.
[02:03:27] <James_F>	 Well, CI should tell us. :-)
[02:09:15] <James_F>	 DannyS712: Oh lovely, phan failure.
[02:09:37] <James_F>	 So some of the changes may be needed up-front after all. Oh well.
[02:09:40] <James_F>	 Feel free to fiddle!
[02:28:13] <DannyS712>	 thats a phan bug, will suppress inline
[03:22:30] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10Krinkle) Now fixed in master and included in wmf.18:  >>! In T267668#6626361, @gerritbot wrote: > [mediawiki/core@master] filerepo: remove re...
[03:30:41] <DannyS712>	 > Feel free to fiddle!
[03:30:41] <DannyS712>	 James_F suppressed the issues inline, now passes - if my changes are okay with you I think its ready to merge
[04:55:12] <James_F>	 DannyS712: Yeah, agreed, good to merge. If you're going to do it, C+2 the core patch first and then the vendor one, so that they ride the gate pipeline as a unit and don't break the world.
[05:01:32] <DannyS712>	 done x2
[06:57:50] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10Physikerwelt) @jeena thank you. So what needs to be done to deploy mathoid today? I have just checked...
[07:21:42] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10jeena) @Physikerwelt First, someone needs to merge this patchset, https://gerrit.wikimedia.org/r/c/ope...
[07:42:04] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services): Upgrade CI jobs for WMF-deployed projects from Node 10 to Node 14 LTS (tracking) - https://phabricator.wikimedia.org/T267890 (10Joe)
[07:42:06] <wikibugs>	 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO: Create WMF CI image for Node.js 14 - https://phabricator.wikimedia.org/T267888 (10Joe)
[08:04:42] <wikibugs>	 10Release-Engineering-Team, 10Wikidata, 10Documentation: Update links to doc.wikimedia.org - https://phabricator.wikimedia.org/T251259 (10WMDE-leszek) 05Open→03Resolved a:03WMDE-leszek I believe we're done here unless there is the evidence showing otherwise.
[08:14:30] <wikibugs>	 10Phabricator: Some folks cannot edit Phabricator projects for unclear reasons - https://phabricator.wikimedia.org/T268001 (10Aklapper)
[08:38:05] <wikibugs>	 10Release-Engineering-Team-TODO (201907), 10CirrusSearch, 10Discovery-Search (Current work), 10User-zeljkofilipin: The first Selenium test for WikibaseCirrusSearch - https://phabricator.wikimedia.org/T223774 (10Aklapper)
[08:38:28] <wikibugs>	 10Project-Admins, 10Discovery-Search (Current work): Do not dump WikibaseCirrusSearch codebase tasks into some #Discovery-Search team project tag only - https://phabricator.wikimedia.org/T263725 (10Aklapper) 05Open→03Resolved Thanks everyone! * Updated https://www.mediawiki.org/w/index.php?title=Extension:...
[10:41:11] <hashar>	 !log integration: removed /var/lib/dpkg/lock from integration-castor03
[10:41:13] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[11:46:47] <Nikerabbit>	 legoktm: codesearch seems to be down a lot... is it a resourcing issue?
[11:53:25] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10Physikerwelt) @jeena thank you. This was extremy helpful. Now I understand the process much better. Is...
[12:05:50] <wikibugs>	 (03PS1) 10WMDE-Fisch: Stop running Ruby selenium test for RevisionSlider [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247)
[12:12:37] <kostajh>	 hashar: sorry, just finished lunch. shall I join?
[12:12:51] <hashar>	 ahh
[12:12:57] <hashar>	 kostajh: going to head to lunch myself
[12:13:09] <hashar>	 clearly, we should push that meeting an hour later. 13:00 is a bit annoying ;]
[12:14:28] <kostajh>	 heh
[12:14:30] <kostajh>	 yep
[12:14:41] <kostajh>	 it's normally ok, but today is a bit unusual
[12:19:10] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Stop running Ruby selenium test for RevisionSlider [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247) (owner: 10WMDE-Fisch)
[12:54:22] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Congratulations!" [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247) (owner: 10WMDE-Fisch)
[12:55:36] <wikibugs>	 (03Merged) 10jenkins-bot: Stop running Ruby selenium test for RevisionSlider [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247) (owner: 10WMDE-Fisch)
[12:59:05] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10Lucas_Werkmeister_WMDE) T268012 and T268008 are two GrowthExperiments issues that are not fixed in wmf.18 as far as I’m aware. Both have fixe...
[12:59:55] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10kostajh) hi @dancy, we've backported a fix to wmf.16 but need https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/64129...
[13:42:09] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Use upstream Gerrit.war instead of building our own - https://phabricator.wikimedia.org/T268019 (10hashar)
[13:50:50] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Remove jsonevent-layout library from our Gerrit fork - https://phabricator.wikimedia.org/T268020 (10hashar)
[14:17:27] <wikibugs>	 (03CR) 10Hashar: "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247) (owner: 10WMDE-Fisch)
[15:05:09] <wikibugs>	 (03CR) 10WMDE-Fisch: "Thanks \o/" [integration/config] - 10https://gerrit.wikimedia.org/r/641415 (https://phabricator.wikimedia.org/T180247) (owner: 10WMDE-Fisch)
[15:07:12] <wikibugs>	 10phan, 10MediaWiki-Core-Testing, 10Patch-For-Review: Future of tests/phan in MW Core - https://phabricator.wikimedia.org/T267859 (10Daimona) a:03Daimona @EBernhardson @Legoktm Thank you for the input, I've nuked the directory. A quick and hacky [[https://codesearch.wmcloud.org/search/?q=tests%5C%2Fphan&i=...
[15:10:28] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Remove jsonevent-layout library from our Gerrit fork - https://phabricator.wikimedia.org/T268020 (10hashar) In `/var/log/gerrit` we have:  | delete_log | log4j.xml | gc_log | log4j.xml | gerrit.json | log4j.xml net.logstash.log4j.JSONEventLayoutV1 |...
[15:17:25] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Remove jsonevent-layout library from our Gerrit fork - https://phabricator.wikimedia.org/T268020 (10QChris) I briefly tested `log.jsonLogging` for the 3.2 upgrade. According to my notes, the format for `@timestamp` is slightly different (`Z` as timez...
[15:43:49] <hashar>	 qchris: thank you Christian :]
[15:44:40] <qchris>	 Not sure if it's helpful, but I figured I'll explain why that switch did not yet happen.
[15:44:59] <qchris>	 You're busy around Gerrit these days \o/
[15:51:33] <hashar>	 qchris: yeah I have added collection of Gerrit internal metrics with the hope it will help us figure out why it runs out of heap every few weeks
[15:52:01] <qchris>	 That looks great indeed!
[15:53:28] <hashar>	 qchris: as a result we have plenty of dashboards https://grafana.wikimedia.org/dashboards/f/5AnaHr2Mk/gerrit
[15:54:16] <qchris>	 Nice!
[15:56:39] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Remove jsonevent-layout library from our Gerrit fork - https://phabricator.wikimedia.org/T268020 (10hashar) And surely passing `-Dlog4j.configuration` disables the Gerrit builtin logs which have support for log.jsonLogging :-\ `   public static boole...
[15:57:05] <hashar>	 such a pity, gerrit programmaticly configure some loggers but they are not initialized when one specify a log4j config ;]
[15:57:20] <hashar>	 and I could not find a way to use their class from log4j.xml bah
[16:07:19] <qchris>	 As I said in the Phabricator comment ... Gerrit and logging is not the best match. I'd not waste time doing it inside of Gerrit :-)
[16:21:29] <hashar>	 qchris: I just thought it could be as simple as enabling a setting ;]
[16:21:37] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10dancy) @kostajh I will include https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/641294 in the group0 rollout.
[16:23:48] <hashar>	 qchris: I will go with shipping the .jar and using some class path hack. thx a lot!
[16:32:59] <dpifke>	 !log Un-cherry-picked Python 3 patches in beta, to prevent merge conflicts when they're merged in prod later today.  Should only affect deployment-webperf1[12].
[16:33:00] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[16:33:51] <dpifke>	 !log Cherry-picking https://gerrit.wikimedia.org/r/c/operations/puppet/+/633202 and https://gerrit.wikimedia.org/r/c/labs/private/+/635859 in beta.  Should only affect deployment-wpt01.
[16:33:53] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[17:36:44] <wikibugs>	 10phan, 10MediaWiki-Core-Testing, 10Patch-For-Review: Future of tests/phan in MW Core - https://phabricator.wikimedia.org/T267859 (10Jdforrester-WMF) 05Open→03Resolved
[17:49:19] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10Daimona)
[17:53:25] <wikibugs>	 (03PS1) 10Ragesoss: Remove maximum gem versions for http libraries [ruby/api] - 10https://gerrit.wikimedia.org/r/641466
[18:03:42] <DannyS712>	 thcipriani are you around?
[18:12:07] <legoktm>	 Nikerabbit: codesearch restarts every 24h to pick up any new repositories that may have been created, I suspect that the timing might just coincide more with your day than it used to. Also, we have way more repos now than we used to so downtimes are longer and more noticeable. 
[18:12:40] <legoktm>	 Nikerabbit: upstream has a PR open to allow hot reloading config, so new repos can be added without a restart...so I'm waiting on that rather than applying more bandaids
[18:12:55] <James_F>	 legoktm: Hasn't that PR been around for ages, unmerged?
[18:13:05] <James_F>	 Or is that the non-'master' branch request?
[18:13:07] <legoktm>	 there's a new one now
[18:13:12] <James_F>	 Aha.
[18:13:25] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Lucas_Werkmeister_WMDE)
[18:13:28] * James_F vaguely follows Hound stuff for codesearch whining purposes.
[18:13:34] <legoktm>	 https://github.com/hound-search/hound/pull/357
[18:14:00] <James_F>	 Thanks.
[18:16:37] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Jdforrester-WMF) Another one of these in WikiLambda change [[https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/6412...
[18:17:34] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10DannyS712) Could this have been caused by {T267859} ?
[18:18:24] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Jdforrester-WMF) It seems unlikely (that's not meant to be live), but the timing fits.
[18:20:22] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Daimona) >>! In T268055#6628277, @DannyS712 wrote: > Could this have been caused by {T267859} ?  Isn't it dead code?  Looking at the...
[18:24:37] <DannyS712>	 Daimona it looks like ^ is causing all phan test jobs to fail
[18:24:45] <wikibugs>	 10phan-taint-check-plugin, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Jdforrester-WMF) Joy, this seems entirely deterministic, and so now the whole of WikiLambda codebase is unmergeable. Joy.
[18:24:51] <Daimona>	 Noice
[18:25:07] <Daimona>	 I'm on it
[18:25:16] <DannyS712>	 thanks
[18:25:56] <Daimona>	 I'm a bit scared by the exception happening on line 404
[18:28:02] <Daimona>	 Aaaaand I can reproduce locally, so it should be easy
[18:28:24] <legoktm>	 famous last words
[18:30:13] <Daimona>	 It's SelectQueryBuilder line 755
[18:30:41] <Daimona>	 That $joinsName
[18:31:03] <Daimona>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/640667
[18:31:54] <Daimona>	 I'm going to send a fix against taint-check now, but I'll need someone to approve the release, then do the same with mw-phan, etc. Not really quick. So we might have to revert that patch for the time being
[18:32:15] <DannyS712>	 why does $joinsName break things?
[18:33:13] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10QChris) The link https://gerrit.wikimedia.org/r/p/mediawiki/extensions/AbuseFilter/+/dashboard/default:recent works for me and shows the dashboard. And https://gerrit.wikimedia.org/r/admin/re...
[18:35:17] <Daimona>	 It's not expecting a non-literal
[18:36:21] <DannyS712>	 oh. Would it work if the non-literal key was set separately ($arr[$joinsName] = $this->joinConds;) instead?
[18:36:49] <James_F>	 Daimona: So it's all Tim's fault? Get him! ;-)
[18:37:02] <Nikerabbit>	 legoktm: yeah but it seems to be down more then once a day... but prolly yeah the regular 24h seems to be around my morning
[18:37:58] <Daimona>	 Uh, yes, it might work that way
[18:38:10] <DannyS712>	 okay, lets see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/641304 passes the tests
[18:38:21] <legoktm>	 Nikerabbit: hmm, I will look into if it's crashing
[18:40:21] <wikibugs>	 10phan-taint-check-plugin, 10Patch-For-Review, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Daimona) a:03Daimona
[18:40:47] <Daimona>	 Fix is up, review appreciated :-)
[18:41:08] <Daimona>	 I forgot to update the changelog, but I've included a line in the release preparation commit
[18:42:16] <James_F>	 Daimona: Looks sane.
[18:43:17] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10Daimona) >>! In T268053#6628311, @QChris wrote: > @Daimona: Is the problem still reproducible for you or was this just some random hiccup?  Yes, still reproducible as described.  > If it stil...
[18:43:17] <James_F>	 Daimona: Do we normally remove the "UNRELEASED" section of the changelog for actual, you know, releases? I know we do for other libraries, but not sure about our process for phan.
[18:44:13] <Daimona>	 Oh, good point. Let me remove that
[18:44:49] <DannyS712>	 rather than an emergency release, can't we just fix the method in core? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/641304 passes phan tests
[18:45:22] <Daimona>	 We can (and should, and have to) fix the method in core, but I wouldn't really say this is an emergency release
[18:45:35] <James_F>	 DannyS712: We've not had a release since June.
[18:45:49] <James_F>	 A release every six months is reasonable, and has some other nice fixes in it.
[18:45:52] <James_F>	 But yeah, let's do both.
[18:45:59] <DannyS712>	 oh, nevermind then
[18:46:38] <Daimona>	 This release should unblock several other things, because it bumps phan to v3, plus some nice analysis of conditionals. It might bring issue with pass-by-ref, but you know how it goes, everything has its cost
[18:46:52] <James_F>	 Daimona: Want to write the LibUp config patch or should I? :-)\
[18:47:17] <Daimona>	 If it's just a matter of changing the JSON file, I can do that ;-)
[18:47:26] <James_F>	 It is. :-)
[18:47:28] <James_F>	 Well.
[18:47:29] <Daimona>	 Shall I tag the release?
[18:47:37] <James_F>	 Yes, that has to happen first.
[18:47:42] <James_F>	 Or you'll just break LibUp.
[18:47:44] <James_F>	 :-)
[18:48:24] <James_F>	 Also, hurrah for phan 3.
[18:48:36] <James_F>	 Oh.
[18:48:37] <James_F>	 Bugger.
[18:48:48] <James_F>	 We missed the README reference to phan 2.6.1.
[18:49:12] <wikibugs>	 10phan-taint-check-plugin, 10Patch-For-Review, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Ammarpad) >>! In T268055#6628291, @Daimona wrote: > Looking at the failure, seems like some code is using a no...
[18:49:59] <DannyS712>	 okay, looking at zuul https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/641486 will pass the phan tests, so I guess my fix works? I'll make a more informative commit message summary
[18:50:31] <James_F>	 DannyS712: Already edited.
[18:50:42] <DannyS712>	 oh, nevermind then
[18:50:55] <Daimona>	 Too late, Snake
[18:51:01] <Daimona>	 Release tagged
[18:51:03] <James_F>	 DannyS712: If you de-WIP I'll merge.
[18:51:17] <James_F>	 Daimona: Thank you.
[18:51:19] <DannyS712>	 done
[18:51:32] <Daimona>	 Now time to upgrade mw-phan...
[18:51:51] <James_F>	 Minor piece of work. ;-)
[18:52:04] <Daimona>	 Ohhhhhhhhhh gaaahd
[18:52:16] <Daimona>	 There's that thing with ConfigBuilder on master...
[18:52:44] <James_F>	 Oooooh.
[18:52:45] <James_F>	 Oops.
[18:52:51] * James_F forgot too.
[18:53:02] <James_F>	 Do we want to back it out and release that as 3.0.5?
[18:53:33] <James_F>	 Rather than rush a bodge to bridge?
[18:53:58] <Daimona>	 I'm cherry-picking to the stable branch
[18:54:04] <Daimona>	 So we can tag a release off that
[18:54:12] <James_F>	 Ack.
[18:54:37] <Daimona>	 Done, ouf.
[19:05:49] <Daimona>	 Sent everything against mw-phan and LibUp
[19:05:59] <Daimona>	 That's a total of 4 commits to merge
[19:06:13] <Daimona>	 I can tag a new release of mw-phan
[19:11:14] <James_F>	 Daimona: Shout when you've tagged mw-phan and I'll merge the LibUp one.
[19:15:08] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10QChris) After seeing T268009, that task indeed looks like the culprit for the behaviour described here. I'm afraid, it will have to wait until T268009 is fixed :-(
[19:15:52] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10QChris)
[19:26:00] <Daimona>	 Meh, quick and dirty reaction to the dashboard issue: https://app.unsee.cc/#jYBcG5Rw3FNzwaPG
[19:29:53] <Daimona>	 Anyhow, James_F: release tagged
[19:32:38] <James_F>	 Cool.
[19:33:21] <James_F>	 Daimona: Also, can you abandon https://gerrit.wikimedia.org/r/c/labs/libraryupgrader/config/+/590390 ? I can't
[19:34:48] <wikibugs>	 10phan-taint-check-plugin, 10Patch-For-Review, 10ci-test-error: Occasional phan-taint-check-plugin crashes with “Illegal offset type in isset or empty” - https://phabricator.wikimedia.org/T268055 (10Jdforrester-WMF) 05Open→03Resolved OK, @DannyS712's quick hack merged in core to unbreak the world, and ne...
[19:35:22] <Daimona>	 {{Done}}, thank you!
[19:36:35] <James_F>	 Hurrah all 'round.
[19:49:26] <Daimona>	 I'll keep an eye on LibUp, please do CC me if you see strange failures
[19:50:53] <wikibugs>	 10phan, 10phan-taint-check-plugin: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Daimona) >>! In T250170#6475412, @Jdforrester-WMF wrote: > Can we *please* get phan to 2.7.2 so we can finally bump composer/semver? We've been waiting for six months fo...
[19:50:58] <Daimona>	 And ^ is unblocked as well
[19:51:23] <wikibugs>	 (03PS3) 10Dduvall: experimental: flense command for aggregating blubber LLB graphs [blubber] - 10https://gerrit.wikimedia.org/r/640562
[19:52:38] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] experimental: flense command for aggregating blubber LLB graphs [blubber] - 10https://gerrit.wikimedia.org/r/640562 (owner: 10Dduvall)
[19:54:59] <wikibugs>	 10phan, 10MediaWiki-libs-Assert, 10Patch-For-Review: Create a phan plugin to handle the Assert library - https://phabricator.wikimedia.org/T226266 (10Jdforrester-WMF)
[19:56:58] <wikibugs>	 10Project-Admins, 10MediaWiki-Vendor, 10User-DannyS712: Create Phab project for wikimedia/assert library - https://phabricator.wikimedia.org/T251076 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF Works for me. Created as #mediawiki-libs-assert and have moved the three open tasks into it.
[19:57:54] <hashar>	 thcipriani: the magic command:  git -c url."https://gerrit.googlesource.com".insteadOf="$(dirname $(git config --get remote.origin.url))" submodule update --init
[19:57:57] <hashar>	 ;)
[19:58:14] <hashar>	 that grabs the core plugins from upstream instead of relying on relative urls
[20:01:08] <wikibugs>	 (03PS4) 10Dduvall: experimental: flense command for aggregating blubber LLB graphs [blubber] - 10https://gerrit.wikimedia.org/r/640562
[20:02:19] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] experimental: flense command for aggregating blubber LLB graphs [blubber] - 10https://gerrit.wikimedia.org/r/640562 (owner: 10Dduvall)
[20:03:11] <wikibugs>	 10phan, 10phan-taint-check-plugin: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Jdforrester-WMF) Yay.
[20:06:13] <wikibugs>	 10phan, 10phan-taint-check-plugin: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Jdforrester-WMF)
[20:06:28] <wikibugs>	 (03CR) 10AndyRussG: "Hi! This and the preceding one (Ia9baeffd) are ready for review." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG)
[20:31:12] <James_F>	 Ooh, that's a new one. "error: remote unpack failed: error Missing tree 42ec2840a99f9e73c57781e9ac77bf7ac153e104"
[20:32:12] <wikibugs>	 (03CR) 10Eileen: [C: 03+1] "This is working well for me" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG)
[20:32:32] <James_F>	 Went away on rebase. Meh. The ways of git are strange and twisted.
[20:32:49] <wikibugs>	 (03CR) 10Eileen: [C: 03+1] "Working well for me" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632171 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG)
[20:40:06] <wikibugs>	 (03CR) 10Kosta Harlan: Create fundraising-buster-php73-apache2-xdebug image (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG)
[20:56:17] <wikibugs>	 10Gerrit, 10Librarization, 10MediaWiki-libs-Assert, 10Wikimedia-GitHub: Move wikimedia/assert to gerrit or wikimedia's github account - https://phabricator.wikimedia.org/T114330 (10DannyS712)
[21:04:36] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10dancy) @kostajh https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/641294 is deployed to group0.    I hope to see some...
[21:07:36] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10kostajh) >>! In T263184#6628840, @dancy wrote: > @kostajh https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/641294 is...
[21:27:08] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10hashar) a:03hashar Yeah that is definitely related though we can't comment much about the issue right now.  I am definitely on it though.
[21:40:01] <wikibugs>	 10Gerrit, 10Release-Engineering-Team: Dashboards disappeared from gerrit - https://phabricator.wikimedia.org/T268053 (10hashar) 05Open→03Resolved Should be good now. I can browse https://gerrit.wikimedia.org/r/p/mediawiki/extensions/AbuseFilter/+/dashboard/default:recent while being logged out of Gerrit....
[21:57:32] <wikibugs>	 (03CR) 10Jforrester: "Do we actually want to allow v2.x at all? MW is /finally/ 1.5.2 now; let's jump all the way to 3.0.1?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy)
[21:58:51] <wikibugs>	 (03CR) 10Reedy: "> Patch Set 3:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy)
[22:15:49] <wikibugs>	 10Gerrit, 10Release-Engineering-Team (Development services): Remove jsonevent-layout library from our Gerrit fork - https://phabricator.wikimedia.org/T268020 (10thcipriani) >>! In T268020#6627706, @hashar wrote: > Thank you @QChris for your input, it is very helpful to have all the context.  My intent for this...
[22:39:24] <wikibugs>	 (03PS4) 10Reedy: Update composer/semver constraints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704
[22:39:30] <wikibugs>	 (03PS5) 10Reedy: Update composer/semver constraints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704
[22:42:44] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Update composer/semver constraints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy)
[22:43:21] <James_F>	 Reedy: Same on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/637050 ?
[22:43:25] <Reedy>	 Haha
[22:43:31] <Reedy>	 I was just looking at that for the same reason :)
[22:43:41] <Reedy>	 cause that ones commit summary is now wrong... :D
[22:48:05] <wikibugs>	 (03Merged) 10jenkins-bot: Update composer/semver constraints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636704 (owner: 10Reedy)
[22:48:26] <James_F>	 Indeed.
[22:48:27] <wikibugs>	 10LibUp: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Reedy)
[22:48:54] <James_F>	 Oh, meh, thanks Reedy. I guess Phab didn't accept my tab as selecting the project.
[22:49:02] <Reedy>	 heh
[22:56:02] <wikibugs>	 10MediaWiki-Codesniffer: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType - https://phabricator.wikimedia.org/T268087 (10Umherirrender)
[23:05:57] <wikibugs>	 10MediaWiki-Codesniffer: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType - https://phabricator.wikimedia.org/T268087 (10Umherirrender) Should be checked as well: `MediaWiki.Commenting.FunctionDocumentation.NotPunctuationReturnType`/`MediaWiki.Commenting.FunctionDocumentation.NotPu...
[23:07:40] <wikibugs>	 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.18 deployment blockers - https://phabricator.wikimedia.org/T263184 (10Tgr) >>! In T263184#6628846, @kostajh wrote: > @dancy the patch attached to that task would fix the problem, I think (cc @Tgr and @Catrope to...
[23:11:32] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Math, 10Mathoid: Migrate mathoid to use PipelineLib - https://phabricator.wikimedia.org/T261809 (10jeena) @Physikerwelt Happy to help. Here is the documentation for doing deployments of kubernetes serv...