[00:57:23] 10phan, 10phan-taint-check-plugin, 10Parsoid, 10MW-1.35-release: phan/phan-taint-check-plugin issues on Parsoid/REL1_35 - https://phabricator.wikimedia.org/T268860 (10Reedy) [00:58:36] 10phan, 10phan-taint-check-plugin, 10Parsoid, 10MW-1.35-release: phan/phan-taint-check-plugin issues on Parsoid/REL1_35 - https://phabricator.wikimedia.org/T268860 (10Reedy) [07:47:19] good morning [07:51:43] morning - hope you had a good thanksgiving [10:05:06] (03PS1) 10JMeybohm: helm-linter: Update helm and components, add helm3 [integration/config] - 10https://gerrit.wikimedia.org/r/643907 (https://phabricator.wikimedia.org/T251305) [10:05:08] (03PS1) 10JMeybohm: jjb: update job to releng/helm-linter:0.2.11 [integration/config] - 10https://gerrit.wikimedia.org/r/643908 (https://phabricator.wikimedia.org/T251305) [10:08:32] 10phan, 10phan-taint-check-plugin, 10Parsoid, 10MW-1.35-release: phan/phan-taint-check-plugin issues on Parsoid/REL1_35 - https://phabricator.wikimedia.org/T268860 (10Daimona) [10:08:46] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10phan-taint-check-plugin, 10Quibble, and 2 others: phan-taint-check-plugin: Undefined constant 'ast\AST_LIST' - https://phabricator.wikimedia.org/T263500 (10Daimona) [10:57:25] (03PS2) 10JMeybohm: helm-linter: Update helm and components, add helm3 [integration/config] - 10https://gerrit.wikimedia.org/r/643907 (https://phabricator.wikimedia.org/T251305) [10:57:27] (03PS2) 10JMeybohm: jjb: update job to releng/helm-linter:0.2.11 [integration/config] - 10https://gerrit.wikimedia.org/r/643908 (https://phabricator.wikimedia.org/T251305) [12:17:16] (03PS1) 10Hnowlan: Add similar-users repo to pipeline and publish. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) [12:18:59] (03PS2) 10Hnowlan: Add similar-users repo to pipeline and publish. Dependent on repo move requent currently under way. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) [12:19:59] (03CR) 10jerkins-bot: [V: 04-1] Add similar-users repo to pipeline and publish. Dependent on repo move requent currently under way. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [12:23:26] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) p:05Triage→03Lowest [12:47:16] (03PS3) 10Hnowlan: Add similar-users repo to pipeline and publish. Dependent on repo move request currently under way. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) [12:48:45] (03CR) 10jerkins-bot: [V: 04-1] Add similar-users repo to pipeline and publish. Dependent on repo move request currently under way. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [15:20:50] 10phan, 10phan-taint-check-plugin: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Umherirrender) 05Resolved→03Open This is about phan in the config, not in taint-check (even there are bundled) On update should be suppressed - PhanParamNameIndicat... [15:34:19] (03CR) 10Hashar: [C: 03+2] helm-linter: Update helm and components, add helm3 [integration/config] - 10https://gerrit.wikimedia.org/r/643907 (https://phabricator.wikimedia.org/T251305) (owner: 10JMeybohm) [15:35:59] (03Merged) 10jenkins-bot: helm-linter: Update helm and components, add helm3 [integration/config] - 10https://gerrit.wikimedia.org/r/643907 (https://phabricator.wikimedia.org/T251305) (owner: 10JMeybohm) [15:42:32] (03CR) 10Hashar: "And it fails to build: Error: repo "https://kubernetes-charts-incubator.storage.googleapis.com" is no longer available; try "https://cha" [integration/config] - 10https://gerrit.wikimedia.org/r/643907 (https://phabricator.wikimedia.org/T251305) (owner: 10JMeybohm) [15:43:39] arg... [15:43:49] Sure...everything is deprecated there now [15:47:48] jayme: sorry should have noticed that change earlier ;D [15:48:13] guess you will want to provide custom config files [15:48:18] or have the helm3 package updated [15:48:55] the add repo stuff is in helm-linter Dockerfile. We don't provide any config via packaging [15:49:09] I'll fix that in a sec [15:54:06] great [15:59:24] (03PS1) 10JMeybohm: helm-linter: Fix incubator helm repository [integration/config] - 10https://gerrit.wikimedia.org/r/643970 [15:59:42] hashar: I think I don't need to bump the changelog, right? [15:59:54] hmm [15:59:55] ni [15:59:56] no [16:00:03] ok, cool [16:00:10] well you could and indicate the previous failed, but since it failed it never got build so ... [16:00:15] it is fine as is [16:00:34] (03CR) 10Hashar: [C: 03+2] helm-linter: Fix incubator helm repository [integration/config] - 10https://gerrit.wikimedia.org/r/643970 (owner: 10JMeybohm) [16:01:43] (03Merged) 10jenkins-bot: helm-linter: Fix incubator helm repository [integration/config] - 10https://gerrit.wikimedia.org/r/643970 (owner: 10JMeybohm) [16:04:41] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Daimona) >>! In T250170#6653022, @Umherirrender wrote: > This is about phan in the config, not in taint-check (even there are bundled) Oh, right,... [16:08:29] !log Successfully tagged docker-registry.discovery.wmnet/releng/helm-linter:0.2.11 for jayme / T251305 [16:08:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:08:33] T251305: Migrate to helm v3 - https://phabricator.wikimedia.org/T251305 [16:08:44] jayme: I have updated the jenkins ojb to use the new image [16:09:55] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Umherirrender) >>! In T250170#6653052, @Daimona wrote: >>>! In T250170#6653022, @Umherirrender wrote: >> This is about phan in the config, not in t... [16:10:37] hashar: great, thanks! [16:11:14] jayme: and we have another repo that uses charts https://gerrit.wikimedia.org/g/releng/local-charts for local development tooling [16:11:23] but I guess the current job is tied to the other repo and require some entry point [16:11:34] but that is a different topic really [16:15:00] Ah, did not know about that. Feel free to ping me somewhere if you want to push those charts to https://helm-charts.wikimedia.org/incubator or https://helm-charts.wikimedia.org/releng or whatever [16:16:39] jayme: no idea, will keep that in mind and poke the relevant releng people about it ;) [16:16:44] they might be published somewhere already [16:16:54] I felt like adding a CI job to validate those might be a good thing [16:17:09] anyway, I am off, going to take care of the kids [16:17:36] Fine as well. Tbh I'm not sure if we support different credentials for different repos currently which would probably be kind of a blocker [16:17:44] o/ have a nice weekend [16:20:10] 10phan-taint-check-plugin: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Umherirrender) [16:22:56] jayme: thx you too! [16:32:57] 10phan-taint-check-plugin: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Umherirrender) [16:33:01] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), 10Patch-For-Review: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Umherirrender) [16:40:48] 10phan, 10phan-taint-check-plugin, 10Patch-For-Review: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan - https://phabricator.wikimedia.org/T250170 (10Daimona) >>! In T250170#6653056, @Umherirrender wrote: >>>! In T250170#6653052, @Daimona wrote: >>>>! In T250170#6653022, @Umherirrender wrote: > I... [16:54:15] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), 10Patch-For-Review: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Umherirrender) ` 13:49:09 includes/GlobalFunctions.... [16:58:30] 10phan-taint-check-plugin: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Daimona) a:03Daimona > It is possible that taint is not assume the corret type here with the array plus? It is possible, both areas (foreach loops and type inference) were touch... [17:08:24] 10phan-taint-check-plugin: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Umherirrender) Not sure if related, but also related to types: `Language.php` > Expected an object instance when accessing an instance property, but saw an expression $ts with typ... [18:30:59] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), 10Patch-For-Review: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Umherirrender) ` 13:49:09 includes/jobqueue/utils/B... [18:54:38] greg-g, thcipriani hello! My account on phab has been disabled, I am continuing to work as a volunteer, could it please be enabled again? (not sure if this is you guys or andre) [18:54:41] thank you! [21:09:34] nuria: I can re-enable it, you'll need to login via your meta account [21:09:44] uh, wikitech, not meta :) [21:09:57] And I guess, it should be delinked from your mediawiki WMF account, and re-linked to your personal (if possible) [21:18:49] 10Phabricator: Reactivate nuria's Phabricator account - https://phabricator.wikimedia.org/T268895 (10Nintendofan885) [21:28:36] 10Phabricator: Reactivate nuria's Phabricator account - https://phabricator.wikimedia.org/T268895 (10Reedy) I've reactivated @Nuria. She should be able to login via her Wikitech account. She needs to go to https://phabricator.wikimedia.org/settings/user/Nuria/page/external/ unlink her WMF account, and optionall... [21:46:31] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [services/similar-users] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/643988 [21:46:33] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [services/similar-users] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/643988 (owner: 10QChris) [21:47:04] (03PS1) 10QChris: Import done. Revoke import grants [services/similar-users] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/643989 [21:47:06] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [services/similar-users] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/643989 (owner: 10QChris) [22:38:46] 10Phabricator: Reactivate nuria's Phabricator account - https://phabricator.wikimedia.org/T268895 (10Nuria) Super thanks! [22:39:59] 10Phabricator: Reactivate nuria's Phabricator account - https://phabricator.wikimedia.org/T268895 (10Nuria) Done both things, many thanks @Reedy [22:40:20] 10Phabricator: Reactivate nuria's Phabricator account - https://phabricator.wikimedia.org/T268895 (10Nuria) 05Open→03Resolved [22:51:34] 10phan-taint-check-plugin: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Daimona) Opened https://github.com/phan/phan/issues/4271 for the original issue. Checking the others... [22:56:10] 10phan-taint-check-plugin: Run phan's test suite as part of CI - https://phabricator.wikimedia.org/T268903 (10Daimona) [23:04:54] (03PS1) 10Zoranzoki21: Enable CI for the mediawiki/extensions/EncryptedUploads repository [integration/config] - 10https://gerrit.wikimedia.org/r/643991