[00:28:19] 10Project-Admins, 10Platform Engineering, 10User-DannyS712: Create #mediawiki-actions component - https://phabricator.wikimedia.org/T268386 (10Krinkle) I think this project as proposed might be too generic. Apart from a very basic set of interfaces and wiring, the Action system isn't much, and also doesn't h... [03:34:16] (03PS10) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [03:34:23] (03PS7) 10DannyS712: Add AssertionOrderSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) [07:55:38] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10hashar) [08:06:44] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10hashar) I have manually edit /etc/puppet/puppet.conf to point to the generic puppet master: `puppetmaster.cloudinfra.wmflabs.org`... [08:12:17] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10hashar) There is something broken with the Puppet master configuration for [[https://horizon.wikimedia.org/project/instances/367e9... [08:27:55] (03CR) 10Ammarpad: [C: 03+1] Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [08:40:17] 10Project-Admins: Project (+workboard) for Koninklijke Bibliotheek (National Library of The Netherlands) - https://phabricator.wikimedia.org/T268222 (10Aklapper) [08:40:23] 10Project-Admins: Tag:#KB-TeamWiki - https://phabricator.wikimedia.org/T268224 (10Aklapper) [08:54:26] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10MoritzMuehlenhoff) mwdebug1003 is working just fine in my tests, both for var... [08:56:31] kostajh: lmk if you get a chance to look at the quibble patch again. Otherwise, I might just merge it--victimless crime ;-) [08:56:51] (03CR) 10Hashar: [C: 03+1] "Looks all fine to me. Thank you !" [integration/config] - 10https://gerrit.wikimedia.org/r/644044 (https://phabricator.wikimedia.org/T268931) (owner: 10Reedy) [08:59:17] (03CR) 10Hashar: [C: 03+2] docker: Update Rust to 1.48.0 [integration/config] - 10https://gerrit.wikimedia.org/r/643997 (owner: 10Legoktm) [08:59:33] awight: hey! nothing's changed since last review, right? I think it was OK then, we wanted to trim the boilerplate config code but we could do that later also [08:59:59] kostajh: I managed to do that--maybe too aggressively. [09:00:37] awight: hmm, where? PS29 (what I reviewed) looks the same as PS32 except for commit message [09:00:37] (03Merged) 10jenkins-bot: docker: Update Rust to 1.48.0 [integration/config] - 10https://gerrit.wikimedia.org/r/643997 (owner: 10Legoktm) [09:03:03] kostajh: PS29 is where I trimmed the config files, fwiw: https://gerrit.wikimedia.org/r/c/integration/quibble/+/516729/28..29 [09:03:42] awight: ah, right [09:04:02] Oops, and there's one more prerequisite: https://gerrit.wikimedia.org/r/c/integration/quibble/+/640432 [09:04:19] yep [09:04:24] (03CR) 10Kosta Harlan: [C: 03+2] Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [09:05:40] Great, thanks. My next step is to port this to integration-config, there are some notes in our etherpad if you're curious. [09:06:20] We'll enable the job for the quibble repo only, to track elapsed time and stability. [09:10:23] (03CR) 10Kosta Harlan: [C: 03+2] Adapt API URL to the current webserver [integration/quibble] - 10https://gerrit.wikimedia.org/r/640432 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [09:11:00] awight: sounds good [09:13:27] (03CR) 10Hashar: [C: 03+2] "Jobs updated:" [integration/config] - 10https://gerrit.wikimedia.org/r/643998 (owner: 10Legoktm) [09:14:53] (03Merged) 10jenkins-bot: jjb: Bump Rust images for 1.48.0 [integration/config] - 10https://gerrit.wikimedia.org/r/643998 (owner: 10Legoktm) [09:18:16] (03PS1) 10Kosta Harlan: Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) [09:19:05] (03Abandoned) 10Kosta Harlan: Move LocalSettings.php out of the way before running unit tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/636430 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:19:28] (03CR) 10jerkins-bot: [V: 04-1] Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:19:42] awight: I forgot to say. \o/ \o/ \o/ thank you for moving that quibble + httpd patch forward :) very cool to see it finally merged [09:20:29] kostajh: +1 It's exciting to be at a point where we can easily experiment with parallel wdio, for example. [09:21:36] (03PS2) 10Kosta Harlan: Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) [09:22:18] (03PS3) 10Kosta Harlan: Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) [09:23:31] (03CR) 10jerkins-bot: [V: 04-1] Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:27:22] (03PS4) 10Kosta Harlan: Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) [09:27:52] (03PS1) 10Kosta Harlan: Exclude bin and venv from flake8 [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 [09:32:52] (03PS1) 10Kosta Harlan: [black] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [09:32:54] (03PS1) 10Kosta Harlan: [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 [09:33:21] (03Merged) 10jenkins-bot: Adapt API URL to the current webserver [integration/quibble] - 10https://gerrit.wikimedia.org/r/640432 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [09:33:22] (03Merged) 10jenkins-bot: Dockerfile launches external apache [integration/quibble] - 10https://gerrit.wikimedia.org/r/516729 (https://phabricator.wikimedia.org/T225218) (owner: 10Kosta Harlan) [09:33:54] (03PS2) 10Kosta Harlan: [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 [09:34:02] (03CR) 10jerkins-bot: [V: 04-1] [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 (owner: 10Kosta Harlan) [09:34:15] (03CR) 10jerkins-bot: [V: 04-1] [black] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:34:37] (03CR) 10jerkins-bot: [V: 04-1] [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 (owner: 10Kosta Harlan) [09:37:53] (03PS2) 10Kosta Harlan: [black] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [09:37:55] (03PS3) 10Kosta Harlan: [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 [09:38:02] (03CR) 10jerkins-bot: [V: 04-1] [black] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:38:03] (03CR) 10jerkins-bot: [V: 04-1] [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 (owner: 10Kosta Harlan) [09:40:07] (03CR) 10Awight: [C: 03+2] "Great!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [09:41:21] (03CR) 10Awight: Exclude bin and venv from flake8 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [09:42:05] (03CR) 10Kosta Harlan: "If you think this is a good idea, let me know, and I can recreate this stack of patches with the latest code. We would then need a quick +" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:43:26] (03CR) 10Kosta Harlan: Exclude bin and venv from flake8 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [09:44:13] (03CR) 10Awight: [C: 03+1] "lgtm, but I'll wait for a consensus about whether to use black in this repo." (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 (owner: 10Kosta Harlan) [09:47:36] (03CR) 10Awight: Exclude bin and venv from flake8 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [09:51:28] (03CR) 10Awight: [C: 03+1] "I like the idea and the output looks good. Just one question inline, is the tool incompatible with 79-character line length?" (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:52:58] (03CR) 10Awight: [C: 03+1] "Seems that black can be configured with an alternative line-length." [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:54:01] (03CR) 10Kosta Harlan: [black] Reformat files with black (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:55:15] (03CR) 10Kosta Harlan: "> Patch Set 2:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:57:11] (03Abandoned) 10Kosta Harlan: Exclude bin and venv from flake8 [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [09:57:15] (03CR) 10Kosta Harlan: Exclude bin and venv from flake8 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [10:02:53] (03CR) 10Awight: Exclude bin and venv from flake8 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644177 (owner: 10Kosta Harlan) [10:04:16] (03Merged) 10jenkins-bot: Run phpunit-unit before MediaWiki install [integration/quibble] - 10https://gerrit.wikimedia.org/r/644174 (https://phabricator.wikimedia.org/T266441) (owner: 10Kosta Harlan) [10:17:49] (03PS1) 10Gilles: Add contractor Noam Rosenthal to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/644185 [11:33:39] (03PS4) 10Hnowlan: Add similar-users repo to pipeline and publish. [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) [12:55:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10SRE-tools, and 2 others: debmonitor: enhance filtering options for packages - https://phabricator.wikimedia.org/T261207 (10hashar) @Volans @akosia... [14:15:26] (03CR) 10Hashar: [C: 03+2] Add contractor Noam Rosenthal to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/644185 (owner: 10Gilles) [14:16:40] (03Merged) 10jenkins-bot: Add contractor Noam Rosenthal to CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/644185 (owner: 10Gilles) [14:17:59] (03CR) 10Hashar: [C: 03+2] "Already deployed on Friday but I forgot to CR+2 it" [integration/config] - 10https://gerrit.wikimedia.org/r/643908 (https://phabricator.wikimedia.org/T251305) (owner: 10JMeybohm) [14:18:32] (03CR) 10Hashar: "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/644185 (owner: 10Gilles) [14:19:17] (03Merged) 10jenkins-bot: jjb: update job to releng/helm-linter:0.2.11 [integration/config] - 10https://gerrit.wikimedia.org/r/643908 (https://phabricator.wikimedia.org/T251305) (owner: 10JMeybohm) [14:20:09] (03Abandoned) 10Hashar: Add ansible-lint to be run via tox [tools/train-dev] - 10https://gerrit.wikimedia.org/r/620950 (https://phabricator.wikimedia.org/T259586) (owner: 10Hashar) [14:20:53] (03PS1) 10Hashar: Revert "Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox" [integration/config] - 10https://gerrit.wikimedia.org/r/644208 [14:21:01] (03PS2) 10Hashar: Revert "Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox" [integration/config] - 10https://gerrit.wikimedia.org/r/644208 [14:21:53] (03CR) 10Hashar: [C: 03+2] Revert "Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox" [integration/config] - 10https://gerrit.wikimedia.org/r/644208 (owner: 10Hashar) [14:23:13] (03Merged) 10jenkins-bot: Revert "Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox" [integration/config] - 10https://gerrit.wikimedia.org/r/644208 (owner: 10Hashar) [14:28:07] (03CR) 10Hashar: [C: 04-1] "I am not sure I understand the intent of this change. There should always be a job in the "test" pipeline which is the one used when a pat" (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/643378 (https://phabricator.wikimedia.org/T265504) (owner: 10Mstyles) [14:30:09] (03CR) 10Hashar: [C: 04-1] "integration/composer.git is no more used by CI. We now use the upstream .phar which is downloaded/checked when we build our CI images." [integration/composer] - 10https://gerrit.wikimedia.org/r/640572 (owner: 10Reedy) [14:30:38] 10Continuous-Integration-Infrastructure: Stop using integration/composer and then archive the repo - https://phabricator.wikimedia.org/T249949 (10hashar) [14:43:15] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10Dzahn) >>! In T268964#6654787, @hashar wrote: > I have manually edit /etc/puppet/puppet.conf to point to the generic puppet master... [14:46:45] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10Dzahn) It was previously broken by others trying to change puppet masters, apparently. [14:54:54] 10Phabricator, 10Release-Engineering-Team (Development services): phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10Dzahn) a:03Dzahn [14:55:07] 10Phabricator: phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10Dzahn) [15:06:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) [15:07:12] 10Phabricator: phabricator-stage-1001.devtools.eqiad1.wikimedia.cloud fails puppet - https://phabricator.wikimedia.org/T268964 (10hashar) It was broken due to some certificate issue. I tried switching to `puppetmaster.cloudinfra.wmflabs.org` cause that sometimes fix the cert. Puppet eventually set back the prev... [15:13:09] (03PS2) 10Addshore: Added initial configuration for wikibase-release-prototype [integration/config] - 10https://gerrit.wikimedia.org/r/643742 (owner: 10WMDE-leszek) [15:20:40] (03CR) 10Addshore: [C: 03+2] "JJB already done." [integration/config] - 10https://gerrit.wikimedia.org/r/643742 (owner: 10WMDE-leszek) [15:22:00] (03Merged) 10jenkins-bot: Added initial configuration for wikibase-release-prototype [integration/config] - 10https://gerrit.wikimedia.org/r/643742 (owner: 10WMDE-leszek) [15:22:20] !log reload zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/643742 [15:22:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:12:19] o/ I have some questions about pipeline-lib: I'm just trying to get a bit of a feel for the scope of it. Is it possible / is there any intention to allow outputs that are not docker images? I saw in the reference documentation the publish step refers to "artifacts". Is it only docker images and is the intention to keep it being only that? [16:17:52] (03PS1) 10Umherirrender: Check object and object[] on union type and after fixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644275 [16:24:03] (03PS5) 10Jforrester: layout: [mediawiki/services/similar-users] Install pipeline/publish CI [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [16:25:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Check object and object[] on union type and after fixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644275 (owner: 10Umherirrender) [16:27:29] (03Merged) 10jenkins-bot: Check object and object[] on union type and after fixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644275 (owner: 10Umherirrender) [16:28:05] (03PS6) 10Jforrester: layout: [mediawiki/services/similar-users] Install pipeline/publish CI [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [16:28:29] (03CR) 10Jforrester: [C: 03+2] layout: [mediawiki/services/similar-users] Install pipeline/publish CI [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [16:29:50] (03Merged) 10jenkins-bot: layout: [mediawiki/services/similar-users] Install pipeline/publish CI [integration/config] - 10https://gerrit.wikimedia.org/r/643926 (https://phabricator.wikimedia.org/T268839) (owner: 10Hnowlan) [16:30:18] !log Zuul: [mediawiki/services/similar-users] Install pipeline/publish CI T268839 [16:30:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:30:22] T268839: Move Similarusers repo out of Github and into Gerrit - https://phabricator.wikimedia.org/T268839 [17:19:11] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268831 (10Lucas_Werkmeister_WMDE) a:03Lucas_Werkmeister_WMDE [17:40:26] 10Beta-Cluster-Infrastructure, 10Developer Productivity, 10Patch-For-Review, 10Puppet: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 (10hashar) Based on `dmesg` the oom hasn't happened since beginning of October so that is an improvement. Some request... [17:42:08] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO, 10Code-Stewardship-Reviews: deployment-prep: Code stewardship request - https://phabricator.wikimedia.org/T215217 (10dpifke) >>! In T215217#6651450, @jcrespo wrote: > I know this is an ongoing issue, b... [17:52:08] (03PS1) 10Umherirrender: Check for object and object[] on @var docs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644296 [17:52:57] (03PS1) 10Lars Wirzenius: feat: add train-dev subcommands reset, copy, and deploy [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 [17:59:35] (03Abandoned) 10Mstyles: remove test stage [integration/config] - 10https://gerrit.wikimedia.org/r/643378 (https://phabricator.wikimedia.org/T265504) (owner: 10Mstyles) [18:11:12] (03PS1) 10Lucas Werkmeister (WMDE): Fix rule name in HISTORY.md [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644301 [18:22:16] (03PS1) 10Clarakosi: Sync WikimediaApiPortalOAuth template with rest of WMF production [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) [18:34:12] (03CR) 10Dduvall: "Not ready to merge this but opening up for review/comments." [blubber] - 10https://gerrit.wikimedia.org/r/640562 (owner: 10Dduvall) [18:37:31] tarrow: hi! re: pipelinelib and artifacts, we sort of left it open to allow for different kinds of artifacts but the primary target has always been container images [18:38:18] the biggest blocker to allowing for different kinds of artifacts is that we don't really have a place to put them [18:39:49] what's the use case? [18:45:03] 10MediaWiki-Codesniffer, 10Wikidata, 10Patch-For-Review, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268831 (10Lucas_Werkmeister_WMDE) [18:50:32] (03CR) 10Jforrester: [C: 03+2] Sync WikimediaApiPortalOAuth template with rest of WMF production [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [18:52:14] (03CR) 10Clarakosi: [C: 04-1] "We'll deploy this tomorrow as part of a knowledge sharing session" [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [18:53:43] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [18:54:14] (03CR) 10Jforrester: [C: 03+2] Fix rule name in HISTORY.md [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644301 (owner: 10Lucas Werkmeister (WMDE)) [18:55:46] (03Merged) 10jenkins-bot: Fix rule name in HISTORY.md [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644301 (owner: 10Lucas Werkmeister (WMDE)) [18:55:59] (03CR) 10Clarakosi: [C: 03+1] "Actually sorry I was thinking of another patch in mediawiki-config. Ignore my last message" [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [19:07:53] (03CR) 10Jforrester: [C: 03+2] "No worries. :-)" [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [19:09:20] (03Merged) 10jenkins-bot: Sync WikimediaApiPortalOAuth template with rest of WMF production [integration/config] - 10https://gerrit.wikimedia.org/r/644302 (https://phabricator.wikimedia.org/T262495) (owner: 10Clarakosi) [19:11:13] !log Zuul: [mediawiki/extensions/WikimediaApiPortalOAuth] Mark as in-prod and enable coverage reports T262495 [19:11:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:11:17] T262495: Deploy WikimediaApiPortalOAuth extension to api.wikimedia.org - https://phabricator.wikimedia.org/T262495 [19:15:13] 10Beta-Cluster-Infrastructure, 10Surveys: Survey on beta causes image misplacement - https://phabricator.wikimedia.org/T269025 (10AlexisJazz) [19:43:14] marxarelli: hey! so our possible use case is we want to formalise the release of wikibase and it's sister services; in addition to releasing Wikibase docker images we'd also want to release tarballs [19:46:57] so we're looking at having some environment where we can periodically build a bundle of Wikibase + the queryservice etc.. and run tests against it before then creating "a release" which would be some artifacts that we can be fairly confident are all compatible [19:47:56] (03CR) 10Jeena Huneidi: "If I recall from last week, this patch was intended to remove the test step from a repo that has no tests. Its sole purpose is to build a " [integration/config] - 10https://gerrit.wikimedia.org/r/643378 (https://phabricator.wikimedia.org/T265504) (owner: 10Mstyles) [19:58:35] (03CR) 10Legoktm: "Maybe we can split this up a bit? First get the php80 base image, then the composer-package* jobs so we can start testing libraries, then " [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [20:16:25] (03CR) 10Jforrester: [C: 04-2] "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [20:24:13] 10Beta-Cluster-Infrastructure, 10Surveys: Survey on beta causes image misplacement - https://phabricator.wikimedia.org/T269025 (10Aklapper) [20:27:20] 10Beta-Cluster-Infrastructure: Survey on beta causes image misplacement - https://phabricator.wikimedia.org/T269025 (10Aklapper) [20:28:24] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.wmnet for hosts: ` deploy1002.eqiad.wmnet ` The log... [20:31:28] legoktm: If you can work out why sury's PHP 8 is still beta3 and not the release that'd be wonderful. [20:31:43] (03CR) 10Thcipriani: [V: 03+2 C: 03+2] Allow Trusted-Contributors to rebase others' patches [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/583133 (https://phabricator.wikimedia.org/T239543) (owner: 10DannyS712) [20:35:20] Oh, hmm, https://launchpad.net/~ondrej/+archive/ubuntu/php/+build/20340079 failed? [20:40:39] (03CR) 10Hashar: [C: 04-1] "The resulting image will not work cause it does not have php. What I did for maven was to provide a scratch image that has the maven pack" (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/634811 (owner: 10Jforrester) [20:41:57] James_F: https://github.com/oerdnj/deb.sury.org/issues/1487 [20:42:23] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.wmnet for hosts: ` deploy2002.codfw.wmnet ` The log... [20:43:07] (03CR) 10Jforrester: dockerfiles: Provide composer, to replace composer-php70 (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/634811 (owner: 10Jforrester) [20:43:19] legoktm: Ah, thanks. [20:44:46] (03CR) 10Hashar: [C: 03+1] "This change can be extracted from the chain and get rebuild right now. It is a standalone one." [integration/config] - 10https://gerrit.wikimedia.org/r/634812 (owner: 10Jforrester) [20:45:23] James_F: anyways, for libraries and PHP extensions I think the beta3 will be good enough to get started [20:45:58] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Code Health), 10Release-Engineering-Team-TODO, 10Code-Stewardship-Reviews: deployment-prep: Code stewardship request - https://phabricator.wikimedia.org/T215217 (10bd808) >>! In T215217#6656571, @dpifke wrote: > Cloud folks: it'd be cool if there w... [20:49:43] (03PS3) 10Jforrester: dockerfiles: [phpmetrics] Switch parent image composer-php70 to composer-php72 [integration/config] - 10https://gerrit.wikimedia.org/r/634812 [20:49:45] (03PS3) 10Jforrester: dockerfiles: Provide composer, to replace composer-php70 [integration/config] - 10https://gerrit.wikimedia.org/r/634811 [20:49:47] (03PS3) 10Jforrester: dockerfiles: [composer-php*] Switch from composer-php70 to use composer [integration/config] - 10https://gerrit.wikimedia.org/r/634813 [20:49:49] (03PS3) 10Jforrester: dockerfiles: [composer-package*] Switch from composer-php70 to use composer [integration/config] - 10https://gerrit.wikimedia.org/r/634814 [20:49:51] (03PS3) 10Jforrester: dockerfiles: [quibble*] Switch from composer-php70 to use composer [integration/config] - 10https://gerrit.wikimedia.org/r/634815 [20:49:53] (03PS3) 10Jforrester: dockerfiles: Drop composer-package-php70, unused [integration/config] - 10https://gerrit.wikimedia.org/r/634816 [20:49:57] (03PS3) 10Jforrester: dockerfiles: Drop composer-php70, unused [integration/config] - 10https://gerrit.wikimedia.org/r/634817 [20:49:59] (03PS3) 10Jforrester: dockerfiles: Drop php70, unused [integration/config] - 10https://gerrit.wikimedia.org/r/634818 [20:50:01] (03PS3) 10Jforrester: dockerfiles: Drop php71, unused [integration/config] - 10https://gerrit.wikimedia.org/r/634819 [20:50:03] (03PS1) 10Jforrester: jjb: Upgrade use of phpmetrics image to PHP 7.2-variant [integration/config] - 10https://gerrit.wikimedia.org/r/644324 [20:50:15] legoktm: I suppose. The lack of php-ast for php8 is more of an issue, and blocks use in half our libraries though. [20:50:54] (03CR) 10Jforrester: "> Patch Set 2: Code-Review+1" [integration/config] - 10https://gerrit.wikimedia.org/r/634812 (owner: 10Jforrester) [20:52:08] I thought most libraries use the polyfill? [20:52:20] I'm not sure "most" do. [20:52:26] Maybe some. [20:53:30] I suppose we could make do with the polyfill and people accept the slowness. [20:54:07] I say this because I know libup doesn't install php-ast, or at least it has the wrong version installed [20:55:04] Yeah. [20:55:09] Eh. [20:55:22] Well, we could land my patch as-is, if we're OK with no-ast and beta. [20:55:34] Want me to edit it to say as much? [20:56:17] Then we can add php8 as an experimental job to everything. [20:57:43] (03PS2) 10Jforrester: [WIP] dockerfiles: Provide PHP8.0 images [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) [20:58:35] (03PS3) 10Jforrester: dockerfiles: Provide PHP8.0 images [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) [20:59:07] legoktm: Let's JFDI? [20:59:16] (He says as he runs away to a meeting.) [21:00:07] James_F: πŸ‘ [21:00:35] legoktm: Want to do the honours? :-) [21:00:41] Sure [21:01:08] (03CR) 10DannyS712: [C: 03+1] Check for object and object[] on @var docs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644296 (owner: 10Umherirrender) [21:17:44] (03CR) 10Legoktm: [C: 03+2] dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:18:22] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['deploy2002.codfw.wmnet'] ` and were **ALL** successful. [21:19:04] (03CR) 10Legoktm: [C: 03+2] "." [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:20:05] (03Merged) 10jenkins-bot: dockerfiles: Provide PHP8.0 images [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:27:03] !log building php8.0 images https://gerrit.wikimedia.org/r/643777 [21:27:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:27:35] ughhh [21:28:06] -rw-r--r-- 1 hashar wikidev 370575 Nov 30 09:10 /tmp/docker-pkg-build.log [21:29:15] (asking a root for deletion) [21:29:15] 10Release-Engineering-Team, 10MediaWiki-User-management, 10MediaWiki-extensions-FlaggedRevs, 10Regression, 10User-DannyS712: Pending changes: autoreview randomly fails - https://phabricator.wikimedia.org/T233561 (10Zache) Does this still exist or was this solved too when [[phab:T237191]] was fixed? (by... [21:29:28] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Zache) Does this still exist or was this solved too when [[phab:T237191]] was fixed? (by https://gerrit.wikime... [21:31:03] really building it now [21:32:13] (03CR) 10Daimona Eaytoy: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:36:45] (03CR) 10Legoktm: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:38:41] (03CR) 10Daimona Eaytoy: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:40:33] (03CR) 10Jforrester: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:47:19] (03CR) 10Daimona Eaytoy: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [21:49:58] (03PS1) 10Legoktm: Adjust PHP 8.0 packages to be installed, skip those that aren't ready yet [integration/config] - 10https://gerrit.wikimedia.org/r/644334 [21:51:22] James_F: ^ [21:51:34] the images built fine, that's just some cleanup to make the images smaller [22:03:19] (03PS1) 10Legoktm: Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 [22:03:39] (03CR) 10Legoktm: dockerfiles: Provide PHP8.0 images (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/643777 (https://phabricator.wikimedia.org/T250298) (owner: 10Jforrester) [22:04:56] (03CR) 10Jforrester: [C: 03+1] Adjust PHP 8.0 packages to be installed, skip those that aren't ready yet [integration/config] - 10https://gerrit.wikimedia.org/r/644334 (owner: 10Legoktm) [22:04:59] legoktm: Aha, interesting. [22:05:10] (03CR) 10Daimona Eaytoy: [C: 03+1] Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 (owner: 10Legoktm) [22:06:23] legoktm: We'll want that in composer-php80 too won't we? [22:07:43] the other composer-php7X images don't seem to have it [22:08:16] Oh, right, I wimped out and didn't bother. :-) [22:08:35] I'm testing locally. If they work I'll C+2 and deploy. [22:10:51] (03CR) 10DannyS712: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/644216 (https://phabricator.wikimedia.org/T260862) (owner: 10DannyS712) [22:11:17] James_F any chance you have a few minutes to review ^ ? [22:13:06] (03CR) 10Jforrester: "After this change, composer-package-php80 still doesn't have the AST module loaded." [integration/config] - 10https://gerrit.wikimedia.org/r/644342 (owner: 10Legoktm) [22:13:25] oh [22:13:41] because I commented out php-ast in php80 [22:14:06] we really should just maintain our own php-ast package... /me grumbles [22:14:10] Hah, it's unavailable but builds the arch? [22:14:24] legoktm: If you and Daimona want to take that on… :-) [22:14:57] (03CR) 10Jforrester: [C: 03+2] Move GlobalWatchlist extension to wikimedia-deployed section [integration/config] - 10https://gerrit.wikimedia.org/r/644216 (https://phabricator.wikimedia.org/T260862) (owner: 10DannyS712) [22:15:10] DannyS712: Sure. [22:15:12] each PHP extension has two parts, a .so file with the actual built stuff, and a .ini config file that says to load the .so. We relied on the php-ast package to install the .ini file and then we'd overwrite the .so file [22:15:42] but I disabled the php-ast package because it hasn't been rebuilt for php8.0 yet so it ends up pulling in older php versions... [22:15:48] we really should just maintain our own php-ast package <-- Well, this might be a good idea [22:16:40] (03Merged) 10jenkins-bot: Move GlobalWatchlist extension to wikimedia-deployed section [integration/config] - 10https://gerrit.wikimedia.org/r/644216 (https://phabricator.wikimedia.org/T260862) (owner: 10DannyS712) [22:16:48] Or maybe we should take over the 'real' package so that it actually works? ;-) [22:17:21] !log Zuul: [mediawiki/extensions/GlobalWatchlist] Move to Wikimedia-deployed section T260862 [22:17:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:17:24] T260862: Deploy GlobalWatchlist extension to production (Meta only) - https://phabricator.wikimedia.org/T260862 [22:17:33] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Tgr) This is caused by `$wgGroupPermissions` being incorrect and that patch only touched `$wgFlaggedRevsAutopro... [22:17:39] the real package is fine, it's just that we want newer versions faster than Debian stable releases [22:18:03] a project for another week [22:18:47] As I said, actually works by keeping up with the real world of what devs need. [22:18:54] * James_F is opinionated. [22:19:06] thanks James_F [22:19:14] DannyS712: Happy to help. [22:19:22] hiya marxarelli [22:19:42] i have a build step in a node based project that uses blubber [22:20:12] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/eventstreams/+/refs/heads/master/ui/ [22:20:30] basically i need to run npm install && npm run biuld [22:20:35] inside of a sub directory in my project [22:20:48] i can get the npm install part to work, since i can easily copy package.json using requirements in blubber [22:20:50] but [22:21:09] i need all the files in the ui/ dir to exist in order to run npm run build [22:21:13] but they don't [22:21:26] the Dockerfile that blubber creates doesn't seem to copy directories if i put them in requirements [22:21:43] and now that i've looked into it, i don't know how the main repo source files even get added into the image at all [22:22:09] when I add 'ls' commands to various steps, all I see are e.g. package.json files [22:22:11] and node_modules [22:22:13] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) I used `httpbb` to run all the tests for appservers we have on mwdebug... [22:22:15] after npm install [22:24:53] legoktm: Should we leave php-ast "live" in the php80 image but with a comment that it doesn't work? [22:25:06] (03PS2) 10Legoktm: Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 [22:25:18] James_F: try PS2? [22:25:31] Oh, right, yeah, that should work. [22:27:23] do you already have a jjb/zuul patch for jobs or not? [22:27:34] I want to start with non-voting jobs for the PHP extensions [22:31:52] (03PS2) 10Jforrester: Adjust PHP 8.0 packages to be installed, skip those that aren't ready yet [integration/config] - 10https://gerrit.wikimedia.org/r/644334 (owner: 10Legoktm) [22:31:55] (03PS3) 10Jforrester: Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 (owner: 10Legoktm) [22:32:13] legoktm: No, go ahead. I'll merge and deploy. [22:32:17] (Tested and working great.) [22:32:26] (03CR) 10Jforrester: [C: 03+2] Adjust PHP 8.0 packages to be installed, skip those that aren't ready yet [integration/config] - 10https://gerrit.wikimedia.org/r/644334 (owner: 10Legoktm) [22:32:31] (03CR) 10Jforrester: [C: 03+2] Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 (owner: 10Legoktm) [22:33:06] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) [22:33:49] (03Merged) 10jenkins-bot: Adjust PHP 8.0 packages to be installed, skip those that aren't ready yet [integration/config] - 10https://gerrit.wikimedia.org/r/644334 (owner: 10Legoktm) [22:33:51] (03Merged) 10jenkins-bot: Build php-ast 1.0.10 for PHP 8.0 [integration/config] - 10https://gerrit.wikimedia.org/r/644342 (owner: 10Legoktm) [22:34:13] ottomata: Andrew, please file in a task for your issue cause I don't think anyone with knowledge is around at this time :] [22:34:31] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) [22:34:43] !log Docker: Bumping new PHP 8.0 images for leanness and AST-worthiness. [22:34:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:35:05] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Tidy up references to REL1_34 when it is EOL - https://phabricator.wikimedia.org/T268931 (10Reedy) [22:35:08] 10MediaWiki-Releasing, 10MW-1.34-release: Formally EOL REL1_34 - https://phabricator.wikimedia.org/T267491 (10Reedy) 05Openβ†’03Resolved Sent [22:35:35] ottomata: at least there is a bunch of documentation on the wiki. So maybe you could find something helpful at https://wikitech.wikimedia.org/wiki/Blubber/Tutorial/HelloNode [22:36:30] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) [22:36:46] (03PS5) 10Jforrester: layout/jjb: REL1_34 is EOL, remove CI [integration/config] - 10https://gerrit.wikimedia.org/r/644044 (https://phabricator.wikimedia.org/T268931) (owner: 10Reedy) [22:36:47] ottomata: and probably the UI should be a different repo than the service. But I digress :] [22:40:09] Where do we pull xdebug from? [22:40:30] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) As per T243847#6567940, I wanted... [22:41:15] (Which is another way of saying "how quick would it be to upgrade?") [22:41:39] Daimona: Probably Debian main? [22:41:42] So "forever". [22:41:53] (03CR) 10Jforrester: [C: 03+2] layout/jjb: REL1_34 is EOL, remove CI [integration/config] - 10https://gerrit.wikimedia.org/r/644044 (https://phabricator.wikimedia.org/T268931) (owner: 10Reedy) [22:42:14] Oh :-[ [22:43:08] (03Merged) 10jenkins-bot: layout/jjb: REL1_34 is EOL, remove CI [integration/config] - 10https://gerrit.wikimedia.org/r/644044 (https://phabricator.wikimedia.org/T268931) (owner: 10Reedy) [22:43:39] And BTW, I've just realized that xdebug 3 is the only version supported on PHP 8 [22:44:14] (At least in theory, according to https://xdebug.org/docs/compat#supported-versions ) [22:45:28] Oh fun. [22:45:40] That'll be a great migration to have to push through alongside everything else. [22:46:38] We might as well just try and see what happens with xdebug 2.x on PHP 8 [22:47:55] Daimona: we get our PHP packages from https://deb.sury.org/ which is also the same person who does them in Debian, but generally deb.sury.org has the latest version faster [22:48:12] of course with PHP 8.0 there's going to be lag as all the build issues are figured out and extensions updated [22:48:40] Ahhh sury. Gotcha, thank you [22:50:52] Uh yes, probably. xDebug should be independent though, as 3.0 should work with PHP 7 as well [22:51:09] ottomata: [22:51:09] it looks like he built php8.0-xdebug for Ubuntu but not yet Debian [22:51:13] ottomata: hey :) [22:51:13] so I assume it's coming soon [22:51:18] catching up... [22:51:36] Oh, but wait. Seems like php-pcov is available from sury?! [22:53:10] yes but it too is missing php8.0 [22:54:39] ottomata: ok, so eventsreams/ui is a subproject and you want to build an image using blubber that includes `npm run build` as a build step? [22:54:48] Yeah, but I was specifically looking at PHP 7 now, as we're still running coverage on 7.2 I believe [22:55:39] then yes [22:57:31] marxarelli: exactly [22:57:36] but i need to run it from within the ui/ dirr [22:57:36] !log jjb: Updated all 197 (!) jobs that referred to REL1_34 for T268931 [22:57:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:57:39] T268931: Tidy up references to REL1_34 when it is EOL - https://phabricator.wikimedia.org/T268931 [22:57:39] or do npm --prefix ui/ [22:57:56] but whenever i try that, i get errors about the ui/ dir not existing [22:58:02] even if i add it to requirements [22:58:13] does dockerfile COPY work with dirs? [22:59:28] is your blubber file uploaded anywhere? [22:59:30] Daimona: also did you see https://github.com/Daimona/demo/pull/1 ? [22:59:32] ottomata: you can copy directories, sure. it seems this is a whole separate subproject though [22:59:34] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Tidy up references to REL1_34 when it is EOL - https://phabricator.wikimedia.org/T268931 (10Jdforrester-WMF) Done? [22:59:41] and we implemented something to handle that a while back [22:59:46] oh ya? [23:00:06] legoktm: Erm, actually no. Somehow I didn't get any notification?! [23:00:27] ottomata: https://wikitech.wikimedia.org/wiki/PipelineLib [23:00:47] (03PS1) 10Legoktm: Add experimental php-compile-php80-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/644354 [23:01:14] it involves some setup in integration/config, but once that's there, you can define the workflows for your project/subprojects in a `.pipeline/config.yaml` in your project's root dir [23:01:43] ah, so i just need to switch from old blubber only .pipeline to a pipelinelib based config.yaml [23:01:44] it includes the ability to define separate workflows for subdirectories within the same project [23:02:14] (03PS16) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [23:02:23] (03CR) 10jerkins-bot: [V: 04-1] dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [23:02:24] ok cool, i haven't touched the build process since i set it up with blubber years ago, so i'll try to migrate to this and see how it goes [23:03:12] i'm not sure we have documentation specific to handling subprojects, but the support is there [23:03:57] basically you would just define a pipeline specific to that subproject and set the `directory` appropriately in `.pipeline/config.yaml` https://wikitech.wikimedia.org/wiki/PipelineLib/Reference#Pipelines [23:04:19] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Legoktm) Is pcov as accurate as xdebug? I... [23:04:20] annoyingly, there's still a little bit to do in `integration/config` but not too much [23:04:30] and we can help with that part (and other parts) [23:05:20] (03CR) 10Legoktm: [C: 03+2] Add experimental php-compile-php80-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/644354 (owner: 10Legoktm) [23:05:24] in addition to setting `directory`, you might want a separate blubber config just for that subproject, so things don't get too cluttered [23:05:48] (03PS17) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [23:06:29] ok thanks marxarelli i will give it a try tomorrrow [23:06:34] thanks for the advice! [23:06:37] ottomata: re: "we can help" "we" being longma and i :) [23:06:37] (03Merged) 10jenkins-bot: Add experimental php-compile-php80-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/644354 (owner: 10Legoktm) [23:06:43] for sure! [23:07:07] :) [23:07:19] !log deploying https://gerrit.wikimedia.org/r/644354 [23:07:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:07:36] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) >>! In T234020#6657625, @Legoktm... [23:08:25] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['deploy1002.eqiad.wmnet'] ` Of which those **FAILED**: ` ['deploy1002.eqiad.wmn... [23:08:56] legoktm: Oops, permissions fail. :-( [23:09:04] yeah, fixing [23:09:14] It'd be really nice if copy copied the damn +x bit. [23:10:00] (03PS1) 10Legoktm: Make run.sh scripts in PHP 8.0 images executable [integration/config] - 10https://gerrit.wikimedia.org/r/644355 [23:10:29] (03CR) 10Legoktm: [C: 03+2] Make run.sh scripts in PHP 8.0 images executable [integration/config] - 10https://gerrit.wikimedia.org/r/644355 (owner: 10Legoktm) [23:10:53] (03PS1) 10Legoktm: jjb: Bump php80-compile image version [integration/config] - 10https://gerrit.wikimedia.org/r/644356 [23:11:43] (03Merged) 10jenkins-bot: Make run.sh scripts in PHP 8.0 images executable [integration/config] - 10https://gerrit.wikimedia.org/r/644355 (owner: 10Legoktm) [23:12:12] !log rebuilding docker iamges for https://gerrit.wikimedia.org/r/644355 [23:12:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:14:05] iamges indeed. [23:14:13] oops [23:14:17] * James_F grins. [23:14:22] It's typo-central here todat. [23:14:45] (Was that typo an accident? Was it sarcastically intentional? You decide!) [23:16:08] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Operations, and 2 others: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI - https://phabricator.wikimedia.org/T243847 (10Daimona) 05Openβ†’03Invalid We can pul... [23:16:10] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) [23:19:11] BTW legoktm: I thought I had read something somewhere. I guess this is what you might have seen with phpdbg? https://github.com/krakjoe/pcov#differences-in-reporting [23:22:14] legoktm: So we'll enable PHP8 as voting for wmerrors and excimer? [23:22:57] Daimona: I think I read it in a blog post, but that's the gist of it [23:23:25] Yeah, well, that would indeed be a problem anyway [23:23:56] or maybe it was Derick's Twitter, I forget [23:24:27] James_F: yeah, I was going to play with wikidiff2 first, because that build failure isn't real [23:25:19] Cool, will leave you to it. [23:31:57] it's set to fail if the major version is not PHP 7 [23:31:59] * legoktm grumbles [23:32:05] Helpful. [23:32:12] I suppose this was a 5->7 migration thing. [23:39:53] yeah [23:40:03] probably would've been better to disallow 5 but oh well [23:43:37] (03PS1) 10Legoktm: Run PHP 8.0 tests for excimer and wmerrors PHP extensions as voting [integration/config] - 10https://gerrit.wikimedia.org/r/644361 [23:43:59] (03CR) 10Legoktm: [C: 03+2] jjb: Bump php80-compile image version [integration/config] - 10https://gerrit.wikimedia.org/r/644356 (owner: 10Legoktm) [23:45:23] (03Merged) 10jenkins-bot: jjb: Bump php80-compile image version [integration/config] - 10https://gerrit.wikimedia.org/r/644356 (owner: 10Legoktm) [23:45:43] (03CR) 10Legoktm: [C: 03+2] Run PHP 8.0 tests for excimer and wmerrors PHP extensions as voting [integration/config] - 10https://gerrit.wikimedia.org/r/644361 (owner: 10Legoktm) [23:46:54] (03Merged) 10jenkins-bot: Run PHP 8.0 tests for excimer and wmerrors PHP extensions as voting [integration/config] - 10https://gerrit.wikimedia.org/r/644361 (owner: 10Legoktm) [23:47:11] !log deploying https://gerrit.wikimedia.org/r/644361 [23:47:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:47:25] halfway there