[00:03:56] 10MediaWiki-Releasing: Formally EOL REL1_34 - https://phabricator.wikimedia.org/T267491 (10Reedy) https://lists.wikimedia.org/pipermail/mediawiki-announce/2020-November/000266.html [00:04:51] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown: Tidy up references to REL1_34 when it is EOL - https://phabricator.wikimedia.org/T268931 (10Reedy) >>! In T268931#6657621, @Jdforrester-WMF wrote: > Done? Probably, yeah. I've archived #mw-1.34-release and #mw-1.34-notes https://lists.wikimedia... [00:17:40] (03PS1) 10Legoktm: docker: Switch back to Daimona's repo for phan-taint-check demo [integration/config] - 10https://gerrit.wikimedia.org/r/644367 [00:17:42] (03PS1) 10Legoktm: jjb: Bump mediawiki-phan-taint-check-demo image to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/644368 [00:58:47] legoktm: Were you going to add a php80 job for the various libraries? [01:00:05] I was and then I got distracted by something else [01:00:10] Ha. [01:01:03] so I haven't made any progress on that yet [01:01:30] I'll do the easy ones. [01:05:00] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch - https://phabricator.wikimedia.org/T269058 (10freephile) [01:09:41] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch - https://phabricator.wikimedia.org/T269058 (10Legoktm) 05Openβ†’03Declined Not sure where the 2.6k number is coming from, but it really does have too many matches: ` user@dev /t/core> grep "namespace" -R . | wc -l 14945 ` If you want to do... [01:15:10] (03PS1) 10Jforrester: dockerfiles: [quibble-stretch-php80] Fix version number for consistency [integration/config] - 10https://gerrit.wikimedia.org/r/644376 [01:15:12] (03PS1) 10Jforrester: jjb: Provide PHP 8.0 variants of jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644377 (https://phabricator.wikimedia.org/T250298) [01:15:14] (03PS1) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 [01:15:16] (03PS1) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for Parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/644379 [01:15:18] (03PS1) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for MediaWiki itself [integration/config] - 10https://gerrit.wikimedia.org/r/644380 [01:15:20] (03PS1) 10Jforrester: Zuul: Provide experimental PHP 8.0 jobs for MediaWiki things [integration/config] - 10https://gerrit.wikimedia.org/r/644381 [01:16:13] (03CR) 10Jforrester: [C: 03+2] "Whoops." [integration/config] - 10https://gerrit.wikimedia.org/r/644376 (owner: 10Jforrester) [01:16:42] (03CR) 10jerkins-bot: [V: 04-1] Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 (owner: 10Jforrester) [01:16:58] (03CR) 10jerkins-bot: [V: 04-1] Zuul: Provide experimental PHP 8.0 job for Parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/644379 (owner: 10Jforrester) [01:17:03] (03CR) 10jerkins-bot: [V: 04-1] Zuul: Provide experimental PHP 8.0 jobs for MediaWiki things [integration/config] - 10https://gerrit.wikimedia.org/r/644381 (owner: 10Jforrester) [01:17:06] (03CR) 10jerkins-bot: [V: 04-1] Zuul: Provide experimental PHP 8.0 job for MediaWiki itself [integration/config] - 10https://gerrit.wikimedia.org/r/644380 (owner: 10Jforrester) [01:17:36] (03Merged) 10jenkins-bot: dockerfiles: [quibble-stretch-php80] Fix version number for consistency [integration/config] - 10https://gerrit.wikimedia.org/r/644376 (owner: 10Jforrester) [01:18:09] !log Docker: Pushing correct version number of new quibble-strech-php80 image [01:18:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:26:05] (03PS2) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 [01:26:07] (03PS2) 10Jforrester: jjb: Provide PHP 8.0 variants of jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644377 (https://phabricator.wikimedia.org/T250298) [01:26:09] (03PS2) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for Parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/644379 [01:26:11] (03PS2) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for MediaWiki itself [integration/config] - 10https://gerrit.wikimedia.org/r/644380 [01:26:13] (03PS2) 10Jforrester: Zuul: Provide experimental PHP 8.0 jobs for MediaWiki things [integration/config] - 10https://gerrit.wikimedia.org/r/644381 [01:26:15] (03PS1) 10Jforrester: jjb: Provide PHP 8.0 variants of core composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644382 [01:33:15] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/644382 (owner: 10Jforrester) [01:34:30] (03Merged) 10jenkins-bot: jjb: Provide PHP 8.0 variants of core composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644382 (owner: 10Jforrester) [01:35:08] (03PS3) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 [01:35:10] (03PS3) 10Jforrester: jjb: Provide PHP 8.0 variants of jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644377 (https://phabricator.wikimedia.org/T250298) [01:35:12] (03PS3) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for Parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/644379 [01:35:14] (03PS3) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for MediaWiki itself [integration/config] - 10https://gerrit.wikimedia.org/r/644380 [01:35:16] (03PS3) 10Jforrester: Zuul: Provide experimental PHP 8.0 jobs for MediaWiki things [integration/config] - 10https://gerrit.wikimedia.org/r/644381 [01:38:14] (03CR) 10Jforrester: [C: 03+2] Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 (owner: 10Jforrester) [01:39:28] (03Merged) 10jenkins-bot: Zuul: Provide experimental PHP 8.0 job for libraries [integration/config] - 10https://gerrit.wikimedia.org/r/644378 (owner: 10Jforrester) [01:40:51] !log Zuul: Provide experimental PHP 8.0 job for libraries [01:40:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:44:36] (03CR) 10Jforrester: "check experimental" [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [01:46:19] Oh oops. [01:53:38] (03PS4) 10Jforrester: jjb: Provide PHP 8.0 variants of jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644377 (https://phabricator.wikimedia.org/T250298) [01:53:40] (03PS4) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for Parsoid [integration/config] - 10https://gerrit.wikimedia.org/r/644379 [01:53:42] (03PS4) 10Jforrester: Zuul: Provide experimental PHP 8.0 job for MediaWiki itself [integration/config] - 10https://gerrit.wikimedia.org/r/644380 [01:53:44] (03PS4) 10Jforrester: Zuul: Provide experimental PHP 8.0 jobs for MediaWiki things [integration/config] - 10https://gerrit.wikimedia.org/r/644381 [01:53:48] (03PS1) 10Jforrester: dockerfiles: Provide composer-test-php74 and composer-test-php80 [integration/config] - 10https://gerrit.wikimedia.org/r/644385 [01:53:50] (03PS1) 10Jforrester: jjb: Correct image version for composer-php74-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/644386 [01:54:49] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Provide composer-test-php74 and composer-test-php80 [integration/config] - 10https://gerrit.wikimedia.org/r/644385 (owner: 10Jforrester) [01:56:05] (03Merged) 10jenkins-bot: dockerfiles: Provide composer-test-php74 and composer-test-php80 [integration/config] - 10https://gerrit.wikimedia.org/r/644385 (owner: 10Jforrester) [01:56:32] !log Docker: Providing composer-test-php74 and composer-test-php80 [01:56:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:59:58] (03CR) 10Jforrester: "check experimental" [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [02:02:58] * James_F sighs. [02:04:00] contint1001 thinks it's build and published composer-test-php80 and composer-test-php74 but CI is getting 'manifest unknown'. [02:21:27] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/644386 (owner: 10Jforrester) [02:22:39] (03Merged) 10jenkins-bot: jjb: Correct image version for composer-php74-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/644386 (owner: 10Jforrester) [03:06:24] 10Gerrit, 10OOUI, 10OOjs, 10OOjs-Router: Re-parent the OOjs repos so that regular `wmf` LDAP users can merge code - https://phabricator.wikimedia.org/T215449 (10Krinkle) [03:06:30] 10Continuous-Integration-Infrastructure, 10Continuous-Integration-Scaling, 10OOjs, 10WorkType-NewFunctionality: Provide the Chrome binary on the nodepool servers so OOjs, VE core can use it in testing - https://phabricator.wikimedia.org/T128090 (10Krinkle) [03:07:15] 10Continuous-Integration-Infrastructure, 10Continuous-Integration-Scaling, 10OOjs: Provide the Chrome binary on the nodepool servers so OOjs, VE core can use it in testing - https://phabricator.wikimedia.org/T128090 (10Krinkle) [03:07:23] 10Continuous-Integration-Scaling, 10OOjs: Migrate OOjs npm CI job to Nodepool - https://phabricator.wikimedia.org/T128089 (10Krinkle) [04:38:37] 10Release-Engineering-Team, 10MediaWiki-User-management, 10MediaWiki-extensions-FlaggedRevs, 10Regression, 10User-DannyS712: Pending changes: autoreview randomly fails - https://phabricator.wikimedia.org/T233561 (10Benica11) >>! In T233561#6657357, @Zache wrote: > Does this still exist or was this solved... [05:20:19] James_F: in the past it used to be that if something tried to pull an image before it got pushed, it would be negatively cached in varnish or smth, don't remember if that got fixed or not [05:20:31] I see the images in https://dockerregistry.toolforge.org/ [05:20:55] * James_F tries again, then. [05:21:06] (03CR) 10Jforrester: "check experimental" [integration/docroot] - 10https://gerrit.wikimedia.org/r/637750 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [05:21:41] Nope, still. [05:21:52] Maybe the status is cached somewhere CI-specific? [05:22:07] Though off the top of my head I didn't think we had such a cache. [05:24:04] `docker images | grep composer-test-php` on contint2001 shows the images as known and existing locally. [05:24:30] But on contint1001 it's not returning? [05:25:03] Aha. [05:25:16] Yeah, it returned eventually, and 1001 doesn't know about them, for some reason. [05:25:27] James_F: I found your problem [05:25:32] 0.1.0 vs 0.0.1 [05:25:50] Ooooh. [05:25:52] Duh. [05:25:56] * James_F is a fool. [05:26:05] it happens to the best of us :) [05:27:37] (03PS1) 10Jforrester: jjb: Correct image version for composer-php74,80-docker jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644396 [05:28:47] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/644396 (owner: 10Jforrester) [05:28:52] let me find my script to trigger jobs for all the libraries... [05:29:07] "composer/semver 1.5.0 requires php ^5.3.2 || ^7.0 -> your PHP version (8.0.0) does not satisfy that requirement" [05:29:24] Well, that one's getting fixed soonish, which is good. [05:29:45] Fancy, a script? I was going to do it manually. [05:29:51] (03Merged) 10jenkins-bot: jjb: Correct image version for composer-php74,80-docker jobs [integration/config] - 10https://gerrit.wikimedia.org/r/644396 (owner: 10Jforrester) [05:32:24] Apparently composer/semver 3.0.0 was the first version that shipped with PHP8 support. [05:34:17] James_F: legoktm@contint2001:~$ zuul-test-repo file:/home/legoktm/libs.txt experimental [05:34:26] and libs.txt comes from copy/pasting from https://libraryupgrader2.wmcloud.org/r [05:35:20] Huh, neat. [05:35:51] I can tell you the relevant repos from `grep zuul/layout.yaml` ;-) [05:36:02] also [05:36:03] 21:35:25 - Installation request for ockcyp/covers-validator 1.3.0 -> satisfiable by ockcyp/covers-validator[v1.3.0]. [05:36:03] 21:35:25 - ockcyp/covers-validator v1.3.0 requires php ^7.0 -> your PHP version (8.0.0) does not satisfy that requirement. [05:36:12] Fun. [05:36:26] 1.3.0 is the new one, isn't it? [05:36:35] So we need upstream to release one that works in 8.0 first. [05:36:35] Joy. [05:36:53] looks like 1.3.1 [05:37:02] Ah, no, 1.3.1 just released with 1.3.1 [05:37:04] https://github.com/oradwell/covers-validator/pull/30 [05:37:08] Err. With 8.0.0 [05:37:08] Yeah. [05:37:33] So still waiting on upstream perhaps? [05:37:54] We really need a Phab task for "general repo clean-up and maintenance". [05:38:25] s/task/tag/ [05:38:32] Clearly I'm tired and should stop. [05:39:08] James_F: 21:38:58 <+wikibugs> (PS1) Legoktm: Bump ockcyp/covers-validator to 1.3.1 for PHP 8.0 support [labs/libraryupgrader/config] - https://gerrit.wikimedia.org/r/644397 [05:39:38] If only that reported in here, the most relevant channel. ;-) [05:40:15] another thing to fix [05:43:26] legoktm: Oooh, thanks for fixing my broken empty-eslint-rule patch. [05:44:33] Oh, I see, you just split the patch. :-) I hope it works. [05:51:52] it looked safe enough to me [05:52:00] and worst case if it breaks everything jenkins will reject it [05:52:14] Yeah, I was just worried about obliterating real data, hence the tests. [06:03:00] https://gerrit.wikimedia.org/r/q/hashtag:%22c%253Bockcyp%252Fcovers-validator%253D1.3.1%22+(status:open%20OR%20status:merged) [06:03:35] The https://gerrit.wikimedia.org/r/q/hashtag:%22c%253Bockcyp%252Fcovers-validator%253D1.3.0%22+(status:open%20OR%20status:merged) run was from just two weeks ago. [06:04:10] Indeed, many of those commits were caught by your experimental run. [06:05:13] Time for a new CodeSniffer release? [06:09:40] (03PS1) 10Jforrester: Zuul: Make PHP74 voting for composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644404 [08:04:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10kostajh) >>! In T234020#6657575, @Daimona... [08:17:45] 10Phabricator: The monthly run of the Phab community metrics script failed with an error. - https://phabricator.wikimedia.org/T269076 (10ArielGlenn) [08:18:56] 10Phabricator: The monthly run of the Phab community metrics script failed with an error. - https://phabricator.wikimedia.org/T269076 (10ArielGlenn) Note that email was still sent out. I don't know if this means that the script was rerun in the meantime or what. [08:37:08] 10Continuous-Integration-Config, 10Wikimedia-General-or-Unknown: Tidy up references to REL1_34 when it is EOL - https://phabricator.wikimedia.org/T268931 (10hashar) 05Openβ†’03Resolved Thanks for the cleanup! [09:18:31] (03PS1) 10Urbanecm: Review access change [wikimedia-cz] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/644222 [09:19:10] (03CR) 10Hashar: [V: 03+2 C: 03+2] "Thanks!" [wikimedia-cz] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/644222 (owner: 10Urbanecm) [09:45:17] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseLexeme: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268829 (10Silvan_WMDE) a:03Silvan_WMDE [09:51:01] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseLexemeCirrusSearch: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268830 (10Tonina_Zhelyazkova_WMDE) a:03Tonina_Zhelyazkova_WMDE [09:59:32] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch (as it has more than 5000 matches) - https://phabricator.wikimedia.org/T269058 (10Aklapper) [10:15:20] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to phpdbg or pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) >>! In T234020#6658340, @kostajh... [10:16:53] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch (as it has more than 5000 matches) - https://phabricator.wikimedia.org/T269058 (10hashar) On the first search it queries https://codesearch.wmcloud.org/core/api/v1/search?stats=fosho&repos=*&rng=:20&q=namespace&files=&i=nope and the response ha... [10:39:06] 10Release-Engineering-Team, 10MediaWiki-User-management, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10MBH) I have written a bot that reviews revisions that wasn't autoreviewed due to this bug. It did many reviews... [10:48:22] 10Gerrit: Reviewer-bot does not add reviewers when leaving initial WIP mode - https://phabricator.wikimedia.org/T267787 (10hashar) > it seems that new users on Gerrit by default have the option `Set new changes to "work in progress" by default` on. The behavior can be set on a per project basis via `change.work... [10:48:51] 10Gerrit: Reviewer-bot does not add reviewers when leaving initial WIP mode - https://phabricator.wikimedia.org/T267787 (10hashar) p:05Triageβ†’03Low [10:56:06] (03PS1) 10Alexandros Kosiaris: apertium: Add it to the pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/644479 (https://phabricator.wikimedia.org/T255672) [10:58:33] (03CR) 10Hashar: [C: 03+2] "https://gerrit.wikimedia.org/r/c/mediawiki/services/apertium/+/639161" [integration/config] - 10https://gerrit.wikimedia.org/r/644479 (https://phabricator.wikimedia.org/T255672) (owner: 10Alexandros Kosiaris) [10:59:35] (03Merged) 10jenkins-bot: apertium: Add it to the pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/644479 (https://phabricator.wikimedia.org/T255672) (owner: 10Alexandros Kosiaris) [11:35:01] (03PS18) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [11:39:47] (03PS1) 10Awight: [WIP] CI image for quibble serving from apache [integration/config] - 10https://gerrit.wikimedia.org/r/644485 (https://phabricator.wikimedia.org/T225218) [11:39:51] (03PS19) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [11:40:58] (03CR) 10jerkins-bot: [V: 04-1] [WIP] CI image for quibble serving from apache [integration/config] - 10https://gerrit.wikimedia.org/r/644485 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [12:00:34] awight / hashar meeting today? [12:02:56] kostajh: Yes! [12:03:10] kostajh: yeah sorry ;) [12:03:17] this time I managed to have lunch at noon! [12:03:23] hehe [12:03:25] alright on my way [12:42:56] (03CR) 10Hashar: [C: 04-1] "I welcome black as an extra formatted, though I am always worried about opinionated style checkers. We had a bad precedent with jshint for" (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [14:24:34] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch (as it has more than 5000 matches) - https://phabricator.wikimedia.org/T269058 (10freephile) I'm OK with this being declined but I would expect it not to have a limit really. Shouldn't a search tool just page results? E.g. What if you wanted t... [14:55:22] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Tonina_Zhelyazkova_WMDE) [15:16:16] (03PS1) 10Tchanders: make-release: Start branching IPInfo extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/644538 (https://phabricator.wikimedia.org/T260599) [15:18:15] (03CR) 10DannyS712: [C: 03+1] make-release: Start branching IPInfo extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/644538 (https://phabricator.wikimedia.org/T260599) (owner: 10Tchanders) [15:21:38] (03PS2) 10Jforrester: Zuul: Make PHP74 voting for composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644404 [15:21:40] (03PS1) 10Jforrester: Zuul: Restore comment to composer-test-package-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644539 [15:35:36] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseCirrusSearch: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268828 (10ItamarWMDE) a:03ItamarWMDE [15:55:06] 10Phabricator, 10Patch-For-Review: The monthly run of the Phab community metrics script failed with an error. - https://phabricator.wikimedia.org/T269076 (10Aklapper) Daniel pointed out https://unix.stackexchange.com/questions/89712/how-to-convert-floating-point-number-to-integer as another option [16:08:56] (03CR) 10Jforrester: [C: 03+2] Zuul: Make PHP74 voting for composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644404 (owner: 10Jforrester) [16:09:00] (03CR) 10Jforrester: [C: 03+2] Zuul: Restore comment to composer-test-package-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644539 (owner: 10Jforrester) [16:10:17] (03Merged) 10jenkins-bot: Zuul: Restore comment to composer-test-package-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644539 (owner: 10Jforrester) [16:10:28] (03Merged) 10jenkins-bot: Zuul: Make PHP74 voting for composer-test-php72-or-later [integration/config] - 10https://gerrit.wikimedia.org/r/644404 (owner: 10Jforrester) [16:12:26] !log Zuul: Make PHP74 voting for composer-test-php72-or-later [16:12:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:13:24] hi marxarelli I'm trying to understand pipelinelib and how to build static assetts in a subdir [16:13:58] from what I can tell, i can define multiple pipelines with different `directory` settings, but it looks like each pipeline results in a different image? [16:14:02] i want to build one image [16:14:21] but i need to run multiple build steps to do so [16:17:29] btw, it'd be really helpful if comment docs were added to the example config.yaml files, e.g. https://wikitech.wikimedia.org/wiki/PipelineLib/Concepts [16:17:40] i have no idea why there are 2 publish stages in that example [16:18:01] a 'best practices' would be good too, all of the examples across the docs are very different [16:18:23] also longma ^^ :) [16:22:22] (03PS1) 10Ahmon Dancy: Remove unused Go files [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644557 [16:26:29] 10Project-Admins, 10Platform Engineering, 10User-DannyS712: Create #mediawiki-namespaces - https://phabricator.wikimedia.org/T249998 (10Pchelolo) For #platform_engineering it doesn't really matter. We will not be using this tag in our processes - namespaces is not really a component, it's a concept, so I don... [16:28:49] (03PS1) 10Jforrester: dockerfiles: [php80] Update to final 8.0.0 release and cascade [integration/config] - 10https://gerrit.wikimedia.org/r/644558 [16:28:51] (03PS1) 10Jforrester: jjb: Update php80 jobs for new 8.0.0 image version [integration/config] - 10https://gerrit.wikimedia.org/r/644559 [16:30:35] (03PS1) 10Ahmon Dancy: Only run sshfs_keygen.sh during 'make mount' [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 [16:35:13] (03PS2) 10Ahmon Dancy: Only run sshfs_keygen.sh during 'make mount' [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 [16:35:42] 10Project-Admins: Create "Documentation-Review" project - https://phabricator.wikimedia.org/T268738 (10Aklapper) [16:38:01] 10Project-Admins: Create "Documentation-Review" project - https://phabricator.wikimedia.org/T268738 (10Aklapper) 05Openβ†’03Resolved Requested public project #documentation-review-board has been created: https://phabricator.wikimedia.org/project/view/5093/ Interested people are welcome to join the project as... [16:41:49] 10MediaWiki-Codesniffer, 10Wikidata, 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Patch-For-Review, and 2 others: WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268831 (10Lucas_Werkmeister_WMDE) [16:41:55] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Lucas_Werkmeister_WMDE) [16:42:19] 10MediaWiki-Codesniffer, 10Wikidata, 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Patch-For-Review, and 2 others: WikibaseQualityConstraints: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268831 (10Lucas_Werkmeister_WMDE) 05Openβ†’03Resolved [16:42:29] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Lucas_Werkmeister_WMDE) [16:43:10] 10MediaWiki-Codesniffer, 10Wikidata, 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseLexeme: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268829 (10Lucas_Werkmeister_WMDE) 05Ope... [16:52:23] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Product-Infrastructure-Team-Backlog, 10Services: Enable codehealth pipeline for more node services maintained by Product Infrastructure - https://phabricator.wikimedia.org/T240989 (10MSantos) [16:52:58] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Product-Infrastructure-Team-Backlog, 10Services: Enable codehealth pipeline for more node services maintained by Product Infrastructure - https://phabricator.wikimedia.org/T240989 (10MSantos) [17:00:12] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Wikibase: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268827 (10Lucas_Werkmeister_WMDE) a:03Lucas_Werkmeister_WMDE [17:00:18] hmm i might have finally got it to work without pipelinelib [17:00:21] https://gerrit.wikimedia.org/r/c/mediawiki/services/eventstreams/+/644568 [17:00:28] dunno why i couldln't get that to work yesterday? [17:00:39] mabye COPY for a directory needs a trailing / [17:00:39] ? [17:05:44] ottomata: hey. just starting my day and catching up [17:06:16] re "from what I can tell, i can define multiple pipelines with different `directory` settings, but it looks like each pipeline results in a different image?" you can build/run/publish as many images in a single pipeline as you like [17:06:47] right now the assumption is that a single pipeline will deal with a single subdir/subproject [17:07:15] but we could easily add a `directory` field to the stage configuration to change that behavior [17:08:20] re "a 'best practices' would be good too, all of the examples across the docs are very different" did you take a look at the user guides and tutorials? those are probably the best of the documentation. that concepts article was sadly a little neglected in the doc rewrite [17:09:23] yes i looked at them all, its just a little hard to tell what is best [17:09:44] e.g. it took me a while that the how to node part wanted me to define a blubber variant called npm-run [17:09:56] depends on your use case :) [17:09:56] but then I also need a publish pipeline...or stage [17:10:03] but yeah, there are many it seems [17:10:05] and ihad to combinie that tutorial with the concepts example [17:10:30] and, it looks like my blubber only appoarch doesn't work after all [17:10:32] it works locally [17:10:34] buut fails in jenkins [17:10:44] i tried to do it with a npm postinstall [17:10:46] that's odd [17:10:53] https://integration.wikimedia.org/ci/blue/organizations/jenkins/service-pipeline-test-and-publish/detail/service-pipeline-test-and-publish/1610/pipeline/ [17:10:56] sh: 1: vue-cli-service: not found [17:11:05] https://gerrit.wikimedia.org/r/c/mediawiki/services/eventstreams/+/644568 [17:11:08] let me take a look [17:12:18] locally it does [17:12:22] > eventstreams-ui@0.1.0 build /srv/service/ui [17:12:22] > vue-cli-service build [17:12:23] - Building for production... [17:12:43] i'm a little confused about what you're trying to do. do you want to build and package up `ui/` in its own image, or include it (with a build step) in an image for the entire project? [17:13:19] i want one image [17:13:27] the same image i've always built [17:13:35] i just need to also build ui/dist static assets [17:13:37] as part of the build [17:13:55] so, incldue it with a build step [17:14:36] i see. i misunderstood then. i thought `ui/` was a subproject needing its own pipeline with build and publish steps [17:14:53] which is why i recommended you define a pipeline just for that [17:14:56] makes more sense now [17:15:00] ah ya makes sense [17:15:08] yeah just need one image with an extra build step [17:15:11] that isn't yet working [17:16:32] i'll checkout your patch and take a look [17:16:37] thank youUuuuU :) [17:23:52] 10VPS-project-Codesearch: Unable to search 'namespace' in CodeSearch (as it has more than 5000 matches) - https://phabricator.wikimedia.org/T269058 (10Legoktm) >>! In T269058#6659808, @freephile wrote: > I'm OK with this being declined but I would expect it not to have a limit really. Shouldn't a search tool jus... [17:27:14] hm, zuul/jenkins-bot(?) hasn’t auto-merged this change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexemeCirrusSearch/+/644533 [17:27:19] not sure if there’s a reason for it or if it’s a bug [17:28:16] Lucas_WMDE: The gate V+2 is on PS2. [17:28:27] ah [17:28:31] Lucas_WMDE: Comment on the patch and it'll spot your existing C+2 and re-run the gate. [17:28:56] it looks like the PS3 gate-and-submit is still running [17:28:59] so I’ll just wait for that to finish [17:29:04] I didn’t notice that two builds had started [17:29:06] thanks! [17:30:51] ottomata: is the postinstall something you'd prefer to do or is that a workaround? [17:35:02] (03CR) 10Jeena Huneidi: [C: 04-1] "This would cause multiple keys to be generated if mounting multiple directories." [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 (owner: 10Ahmon Dancy) [17:37:21] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Lucas_Werkmeister_WMDE) [17:37:26] (03CR) 10Ahmon Dancy: "> Patch Set 2: Code-Review-1" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 (owner: 10Ahmon Dancy) [17:38:15] 10MediaWiki-Codesniffer, 10Wikidata, 10Patch-For-Review, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): WikibaseLexemeCirrusSearch: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268830 (10Lucas_Werkmeister_WMDE) 05Openβ†’03Resolved [17:38:18] marxarelli: i'm fine with that [17:38:25] (03CR) 10Jeena Huneidi: [C: 03+1] "Actually I realized if the key doesn't exist it doesn't make one, whoops! Let me try this out" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 (owner: 10Ahmon Dancy) [17:39:41] marxarelli: its actually the cleanest of any of the approaches i've tried :) [17:39:47] ottomata: i'm asking because you might be able to do it a different way [17:39:47] but i don't really have much of a preference [17:39:58] i'm all ears :) [17:40:10] i have no idea why your patch failed in jenkins though [17:40:16] it works fine for me as well [17:40:18] 10Project-Admins, 10dawiki, 10User-DannyS712: Archive #dawiki? - https://phabricator.wikimedia.org/T256052 (10Aklapper) No reply, and @SimmeD was last active in 2018. I guess we should archive #dawiki. [17:40:36] marxarelli: i dunno why it failed locally yesterday. do yo know if Dockerfile COPY for a directory requires the arg to have a trailing / ? [17:40:38] but i think a slight better way would be to use the generic `builder` config [17:40:48] i think requirerments with just ./ui failed, but ./ui/ succeded [17:40:53] 10phan-taint-check-plugin, 10Patch-For-Review: Add a convenient way to represent taintedness of variadic params - https://phabricator.wikimedia.org/T257191 (10Daimona) a:03Daimona [17:40:55] marxarelli: i tried that a bit [17:40:56] which executes after all other builders (node, python, etc.) [17:41:06] oh in htte same build variant? [17:41:09] i tried to make another variant [17:41:38] aside q: the only docs for blubber stuff like builder i could find are in thte openapi-spec [17:41:38] right, same variant [17:41:42] is that the best place to look? [17:41:46] https://github.com/wikimedia/blubber/blob/master/api/openapi-spec/blubberoid.yaml [17:42:18] marxarelli: i should add ./ui/ to builder requirements? [17:42:19] https://wikitech.wikimedia.org/wiki/Blubber/User_Guide [17:42:32] https://www.irccloud.com/pastebin/msW2JJGU/ [17:42:59] i'm thinking we need to refactor how builders are defined with a more explicit ordering [17:43:10] yeah that is very confusing [17:43:26] marxarelli: can i do [17:43:27] command: [npm run build-ui] [17:43:27] ? [17:43:33] people are starting to use these tools more and the edges are showing :) [17:43:53] it is a little nicer to use npm --prefix i think [17:43:55] than sh and cd [17:43:57] if it works [17:43:57] if you have a script in the root package.json for that, it would work [17:44:04] that's fine [17:44:12] i'm not that fluent in node/npm :) [17:44:47] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] "This one looks ok to me. There's stuff we'll want to add to this once other things need to support buster, but we can do that down the ro" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632171 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [17:44:57] ok trying that [17:45:16] marxarelli: do I need to list package.json again? [17:45:21] in builder requiremnets? [17:45:30] the root one? [17:45:36] yes [17:45:40] no, you don't [17:45:44] it is where build-ui is defined [17:45:45] ok [17:48:39] marxarelli: in Dockerfile [17:48:39] i get [17:48:42] RUN mkdir -p "ui/" [17:48:42] COPY --chown=65533:65533 ["ui", "ui/"] [17:48:43] RUN npm run build-ui [17:48:45] is that right? [17:48:52] will that put ui into ui/uiu [17:48:55] ui/ui [17:48:55] ? [17:49:09] i'm getting [17:49:15] npm ERR! enoent ENOENT: no such file or directory, open '/srv/service/ui/package.json' [17:59:36] ottomata: re "will that put ui into ui/uiu" oddly, no. with COPY docker only ever copies the contents of directories [17:59:57] it's working ok for me :( [18:00:09] did you remove your `postinstall` hook? [18:06:23] yes [18:06:29] OH [18:06:30] no [18:06:32] maybe tha'ts it [18:06:33] oops [18:07:01] https://gerrit.wikimedia.org/r/c/mediawiki/services/eventstreams/+/644574 [18:07:04] 10Scap: Applying security patches should give some output - https://phabricator.wikimedia.org/T269153 (10hashar) [18:10:25] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10TechCom: Create WikiTeq group on Gerrit - https://phabricator.wikimedia.org/T267213 (10tosfos) Thanks @daniel ! And I agree with everything in your comment. We aren't seeking +2 on mediawiki. We're just asking for a Gerrit group so that we can do a b... [18:10:32] thank you! merged, fingers crossed [18:11:05] no problem! [18:18:01] woohoo [18:18:02] trying it [18:18:03] 2020-12-01-181032-production [18:23:37] yahoo! [18:23:37] https://stream-beta.wmflabs.org/v2/ui/#/ [18:23:47] nice! [18:24:30] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Services, 10Product-Infrastructure-Team-Backlog (Kanban): Enable codehealth pipeline for more node services maintained by Product Infrastructure - https://phabricator.wikimedia.org/T240989 (10sdkim) [19:34:01] (03CR) 10Ahmon Dancy: [C: 04-1] feat: add train-dev subcommands reset, copy, and deploy (033 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 (owner: 10Lars Wirzenius) [20:11:58] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) [20:16:12] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) @jijiki The issue with "mysql-client" not existing on buster has been fixed by using default-mysql-client. This was noop on stret... [20:17:58] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) [20:27:42] twentyafterfour: so eventually I am back :] [20:28:02] seems 1.36.0-wmf.20 is all fine so far, at least no major issue seems to have occurred \o/ [20:28:12] will push to group1 tomorrow afternoon [20:28:36] hashar: πŸ‘ [20:28:51] so business as usual really :-] [20:29:56] meanwhileGerrit has cut 3.3.0 https://www.gerritcodereview.com/3.3.html#330 [20:30:52] (03CR) 10Jeena Huneidi: "Sorry, I didn't explain this very well in my quick reply on IRC. This local-charts POC hasn't had much attention since we decided to go wi" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644557 (owner: 10Ahmon Dancy) [20:31:12] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Upgrade Gerrit to 3.3 - https://phabricator.wikimedia.org/T262241 (10hashar) [20:31:31] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Upgrade Gerrit to 3.3 - https://phabricator.wikimedia.org/T262241 (10hashar) 3.3.0 has been released https://www.gerritcodereview.com/3.3.html [20:35:38] (03CR) 10Ahmon Dancy: "> Patch Set 1:" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644557 (owner: 10Ahmon Dancy) [20:59:24] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) As @hashar pointed out there is also T257317 which is describing exactly this issue and I can simply quote Jaime: "scap syncroniz... [21:06:52] (03CR) 10Jeena Huneidi: "> Patch Set 1:" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644557 (owner: 10Ahmon Dancy) [21:12:05] 10Scap: scap deploy --init on deployment server fails on first puppet run - https://phabricator.wikimedia.org/T257317 (10Dzahn) Same issue here when trying to setup deploy1002 the successor of deploy1001: T265963#6660917 And same suggestion how to fix that Jaime made above. scap sync should be allowed but scap... [21:14:21] (03CR) 10Jeena Huneidi: [V: 03+2 C: 03+2] "LGTM" [releng/local-charts] - 10https://gerrit.wikimedia.org/r/644560 (owner: 10Ahmon Dancy) [21:17:17] 10Release-Engineering-Team, 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10ops-monitoring-bot) Icinga downtime for 40 days, 0:00:00 set by dzahn@cumin1001 on 1 host(s) and their services with reason: new_install... [21:35:19] The error I was getting with quibble-apache was simply because the base images were still using the deployed (non-apache) quibble source. I'm rebuilding the whole chain locally... [21:37:11] (03CR) 10Brennen Bearnes: "Hey Andy - I think this basically looks ok, and I tested the build process (at least locally). Is this in a state that you'd like deploye" (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [21:43:17] (03CR) 10AndyRussG: "> Hey Andy - I think this basically looks ok, and I tested the build process (at least locally). Is this in a state that you'd like deplo" (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [21:44:54] (03CR) 10AndyRussG: Create fundraising-buster-php73-apache2-xdebug image (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [22:28:36] (03CR) 10Awight: "The rsyslog.conf is inspiring, thanks for sharing an example of how to do this! I'll be sure to follow future episodes of deep-production" (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [22:37:43] (03CR) 10Awight: "> Patch Set 12:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/632173 (https://phabricator.wikimedia.org/T262976) (owner: 10AndyRussG) [22:40:55] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10dduvall) [22:41:17] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review: Refactor PipelineLib to allow for alternate docker image pusher - https://phabricator.wikimedia.org/T265177 (10dduvall) 05Stalledβ†’03Resolved a:03dduvall [22:41:51] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review: Refactor PipelineLib to allow for alternate docker image pusher - https://phabricator.wikimedia.org/T265177 (10dduvall) [22:41:55] 10Phabricator, 10Wikibase-Containers, 10Wikidata, 10Regression: Can't do shallow clone from phabricator - https://phabricator.wikimedia.org/T240862 (10dduvall) 05Openβ†’03Resolved