[07:55:34] (03PS1) 10Legoktm: jjb: Enable concurrency for 'mediawiki-i18n-check-docker' job [integration/config] - 10https://gerrit.wikimedia.org/r/646574 [07:59:43] (03CR) 10Legoktm: [C: 03+2] jjb: Enable concurrency for 'mediawiki-i18n-check-docker' job [integration/config] - 10https://gerrit.wikimedia.org/r/646574 (owner: 10Legoktm) [08:01:47] (03Merged) 10jenkins-bot: jjb: Enable concurrency for 'mediawiki-i18n-check-docker' job [integration/config] - 10https://gerrit.wikimedia.org/r/646574 (owner: 10Legoktm) [08:59:18] 10phan, 10PHP 8.0 support, 10Release: Release a version of mediawiki-phan-config that is compatible with PHP 8.0 - https://phabricator.wikimedia.org/T269495 (10Legoktm) Thank you! [09:55:22] (03CR) 10Hashar: [C: 04-1] "It will not keep track of errors properly since sh.git throws an exception which is not caught in the code. So on the first patch failing" (034 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/645369 (owner: 10Lars Wirzenius) [10:23:55] 10Phabricator (Upstream), 10I18n, 10Upstream: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10hashar) 05Declined→03Open a:03hashar @Aklapper that is a valid defect imho, notably once the transla... [10:46:00] (03CR) 10Hashar: [C: 03+2] fab: Add --info to the docker build step so it's not so lonely [integration/config] - 10https://gerrit.wikimedia.org/r/645466 (owner: 10Jforrester) [10:47:34] (03Merged) 10jenkins-bot: fab: Add --info to the docker build step so it's not so lonely [integration/config] - 10https://gerrit.wikimedia.org/r/645466 (owner: 10Jforrester) [10:51:09] 10Phabricator, 10I18n: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10Aklapper) [removing uninvolved subscriber] [11:10:05] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Lucas_Werkmeister_WMDE) [11:10:40] 10MediaWiki-Codesniffer, 10Wikidata, 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Patch-For-Review, and 2 others: Wikibase: Replace wikibase-codesniffer with mediawiki-codesniffer v33 - https://phabricator.wikimedia.org/T268827 (10Lucas_Werkmeister_WMDE) 05Open→03Resolved [11:24:11] 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6669424, @akosiaris wrote: > @kostajh, @MGerlach I 've gone ahead... [11:25:18] 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6669463, @akosiaris wrote: > Btw, if the service is going to reach... [11:25:41] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Lucas_Werkmeister_WMDE) Well, the first... [11:58:25] 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6672750, @kostajh wrote: >>>! In T265893#6669424, @akosiaris wrote:... [11:59:00] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) [13:28:30] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services): Upgrade Jenkins to 2.263.1 - https://phabricator.wikimedia.org/T269352 (10hashar) 05Open→03Resolved a:03hashar I have upgraded the CI Jenkins instances. [13:39:21] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) [13:40:43] 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6672752, @kostajh wrote: >>>! In T265893#6669463, @akosiaris wrote:... [13:53:31] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T263186 (10hashar) When the revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/645312 is merged by CI, I will prom... [14:20:15] 10Phabricator, 10I18n: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10Nikerabbit) (Regular) translation updates are coming soon. [14:25:41] stderr: 'fatal: unable to access 'https://gerrit.wikimedia.org/r/mediawiki/extensions/CirrusSearch/': The requested URL returned error: 502' [14:25:55] (Didn't find a task, maybe temporary) [14:27:21] (03PS1) 10Hashar: jjb: remove maintenance-sample-workspace-sizes [integration/config] - 10https://gerrit.wikimedia.org/r/646683 (https://phabricator.wikimedia.org/T266769) [14:31:23] 10Release-Engineering-Team (Deployment services), 10Scap: scap php -l does not show which file has an issue - https://phabricator.wikimedia.org/T269586 (10hashar) [14:36:21] Nikerabbit: yeah that was https://phabricator.wikimedia.org/T246763 [14:37:27] why is the task resolved then? [14:37:40] no idea [14:39:06] Nikerabbit: I guess because had the time we had no metrics / monitoring in place to assert what is going on in Apache / Gerrit http server [14:57:23] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T263186 (10hashar) 05Open→03Resolved [14:59:36] 10Phabricator, 10I18n: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10Nikerabbit) ` [wmf/stable b6bdf95] Localisation updates from https://translatewiki.net. 66 files changed, 1785 insertions(+), 1567... [15:04:41] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10hashar) I have rolled 1.36.0-wmf.20 on all wikis over the last hour. There was an issue with ParserOutput serialization but that h... [15:27:56] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Jdforrester-WMF) >>! In T266823#6672755... [15:30:58] 10Phabricator, 10I18n: Translation of phabricator iwas not deployed correctly in Brazilian Portuguese - https://phabricator.wikimedia.org/T248902 (10Aklapper) 05Open→03Resolved Today :) Sorry that this took longer. [15:38:59] 10phan-taint-check-plugin: Create a web demo for phan taint-check - https://phabricator.wikimedia.org/T257301 (10Aklapper) [15:48:10] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests (auth-related project) [integration/config] - 10https://gerrit.wikimedia.org/r/646741 [15:49:13] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests (auth-related project) [integration/config] - 10https://gerrit.wikimedia.org/r/646741 (owner: 10Jforrester) [15:49:44] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/646741 [15:52:08] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/646741 (owner: 10Jforrester) [15:53:15] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests [integration/config] - 10https://gerrit.wikimedia.org/r/646741 (owner: 10Jforrester) [15:53:23] !log Zuul: [mediawiki/extensions/LDAPAuthorization] Disable selenium tests [15:53:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:07:05] (03CR) 10Jforrester: [C: 03+1] Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [16:24:07] 10Release-Engineering-Team (Logspam), 10GlobalUsage, 10MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), 10Patch-For-Review, and 2 others: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds - https://phabricator.wikimedia.org/T263601 (10Umherirrender) 05Open→03Resolved a:03Umherirrender [16:31:34] 10Release-Engineering-Team, 10WVUI, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10thcipriani) +1 to filing an issue with [[ https://github.com/google/gitiles/blob/master/Documentation/markdown.md | upstream ]]. We... [16:34:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Oh, I forgot about this. I would love to merge this. Just have some minor suggestions to be considered." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [16:47:49] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Scap, 10Operations: Scap: Standardize git version - https://phabricator.wikimedia.org/T179353 (10thcipriani) [16:48:21] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Operations, 10Patch-For-Review, 10git-protocol-v2: Upgrade git fleet wide to git 2.20 - https://phabricator.wikimedia.org/T262244 (10thcipriani) [16:50:34] (03PS7) 10Umherirrender: Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) [16:50:45] (03CR) 10Umherirrender: Remove semicolon in UnusedUseStatementSniff (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [16:54:59] 10Release-Engineering-Team-TODO, 10WVUI, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10thcipriani) [16:55:37] (03CR) 10jerkins-bot: [V: 04-1] Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [17:07:31] 10Phabricator: Allow others than admins to edit forms - https://phabricator.wikimedia.org/T181031 (10epriestley) I'm happy to take a look at this if someone with access has a chance to figure out where it isn't working on your end -- my expectation is that it's supposed to work, but I could definitely have overl... [17:52:01] does anyone remember any recent changes to the CI config that could have caused https://phabricator.wikimedia.org/T269608 ? [17:59:08] no but I saw "Exception: FlaggablePageView has no context article!" in a patch for CX [17:59:39] so also FlaggedRevs is broken [18:00:11] yeah, that’s the same error we get [18:00:30] if it affects Wikibase-unrelated repos that’s probably enough to bump it to UBN…? [18:05:47] hrm, I don't know of any changes that might have caused this offhand. I would be surprised if this was the jenkins upgrade. [18:06:34] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream: Duplicated 'should should' in Phabricator:arcanist-core english messages sent for translation - https://phabricator.wikimedia.org/T201138 (10thcipriani) >>! In T201138#6148259, @Nikerabbit wrote: > My expectation is that Release Engineering up... [18:07:11] * thcipriani looks for CI changes today [18:08:54] core has bunch of changes that could cause it, wondering [18:10:01] but I can still reproduce the error locally with older core [18:10:47] oh [18:11:13] well, tests for me locally are broken completely, but a different reason I think (some phpunit version change?) [18:13:17] hah, I was looking if I could watch for $wgTitle assignments, and the relevant StackOverflow question happens to be by tgr ^^ https://stackoverflow.com/questions/14900850/break-on-property-change-in-xdebug [18:14:14] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Legoktm) >>! In T266823#6672755, @Lucas... [18:14:16] Lucas_WMDE: Can you replicate with an old version of Wikibase? Wondering if something merged today somehow but shouldn't have. [18:14:28] yes, older version of WIkibase still gets the error as well [18:14:34] as does older version of FlaggedRevs [18:14:39] Hmm. [18:14:42] and all my other git repos should be outdated anyways [18:14:44] it’s weird [18:14:49] Very odd. :-( [18:15:04] We didn't change jobs or images. [18:15:56] hm [18:16:19] that makes the jenkins upgrade sound even less likely as the cause [18:16:29] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Jdforrester-WMF) The "correct" way to d... [18:16:58] hrm, is it possible there's something cached locally that makes failures persist on older versions? [18:17:01] Yeah, unless the reload magically updated some cached jobs into the way they were meant to have been running for hours/days? [18:17:42] hrm [18:18:21] I suppose we could test that [18:18:41] But that'd be very odd. [18:18:42] find a patchset that merged and re run tests on it? [18:18:46] Yaeh. [18:19:18] Running recheck on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/645098 [18:19:25] +1 [18:19:30] heh, was just about to do the same: +1 [18:19:31] (It successfully merged five hours ago.) [18:20:07] https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/50981/console [18:22:46] I’m also watching https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/50985/console, to see if skipping the hook in FlaggedRevs works [18:26:54] Lucas_WMDE: I foolishly would hope that FR would have integration tests that would fail if you do that, but… [18:29:06] looks like the recheck is showing some errors in the Database group [18:30:08] drat, and my change has them too [18:30:18] * James_F sighs. [18:32:05] I’m guessing there’s more than one FlaggedRevs hook that needs this singleton which can’t be initialized without $wgTitle [18:32:13] wait...which recheck? this one hasn't hit that part yet...https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/50981/console ? [18:32:23] …981 yes [18:32:45] on my end it’s hit “PHPUnit extensions suite (with database)” and there are some Es in the sea of dots [18:33:04] (no detailed error messages yet, it’s still running. 29%) [18:33:22] ah, gotcha, yeah, I was waiting for the report [18:33:28] ah ok [18:34:16] but, yeah, you're right, I don't see the Es for the last passing one [18:38:16] ok, so, looking at the cache directory that CI uses, there are a few things that have been updated since the last success. Not sure which of these would matter... [18:39:46] hm, this change seems to fix the error as far as Wikibase is concerned https://gist.github.com/lucaswerkmeister/1c8890983c70a6e29f8c81c43323347c [18:39:58] (though the same was true of my FlaggedRevs change, locally) [18:40:14] it makes some sense that we should set wgRequest if we’re setting wgTitle, but I have no idea if that could explain the test failures even in CX [18:42:08] the recheck finished and the test failures look like they’re the same [18:43:25] and my disable-FlaggedRevs-hook change has fewer failures, but still some (looks like BeforePageDisplay is the next hook that pulls in the singleton) [18:45:16] meanwhile, this HtmlPageLinkRendererEndHookHandlerTest failure looks totally unrelated to FlaggedRevs, and doesn’t fail locally :| [18:47:37] I’m looking at https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/50991/console now [19:01:22] so, what the CI check tells us is something either changed in the CI environment or something changed in the repos that this repo depends on (since a "recheck" still clones the current head of all the dependant repos). Here's a list of all the changes in the time window we're looking at: https://phabricator.wikimedia.org/T269608#6674229 [19:06:35] Yeah. [19:13:36] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Build single version MediaWiki image from wmf branch using only PipelineLib/Blubber - https://phabricator.wikimedia.org/T269617 (10dduvall) [19:14:27] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Configure Zuul to trigger PipelineLib based pipelines during gate-and-submit for a few MW components - https://phabricator.wikimedia.org/T262460 (10dduvall) [19:14:29] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Build single version MediaWiki image from wmf branch using only PipelineLib/Blubber - https://phabricator.wikimedia.org/T269617 (10dduvall) [19:14:31] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Create an experimental wmf release branch for a handful of MW extensions and skins - https://phabricator.wikimedia.org/T262458 (10dduvall) [19:15:10] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Create an experimental wmf release branch for a handful of MW extensions and skins - https://phabricator.wikimedia.org/T262458 (10dduvall) 05Open→03Invalid [19:15:12] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10dduvall) [19:33:25] (03PS2) 10Hashar: jjb: disable maintenance-sample-workspace-sizes [integration/config] - 10https://gerrit.wikimedia.org/r/646683 (https://phabricator.wikimedia.org/T266769) [19:34:50] (03CR) 10Ahmon Dancy: [C: 03+2] jjb: disable maintenance-sample-workspace-sizes [integration/config] - 10https://gerrit.wikimedia.org/r/646683 (https://phabricator.wikimedia.org/T266769) (owner: 10Hashar) [19:36:16] (03Merged) 10jenkins-bot: jjb: disable maintenance-sample-workspace-sizes [integration/config] - 10https://gerrit.wikimedia.org/r/646683 (https://phabricator.wikimedia.org/T266769) (owner: 10Hashar) [20:37:19] 10Release-Engineering-Team (Logspam), 10Readers-Web-Backlog, 10JavaScript, 10MediaWiki-Interface (jQuery-Tablesorter), 10Wikimedia-production-error: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting) / Uncaught TypeError: Cannot... - https://phabricator.wikimedia.org/T265503 [21:12:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Technical-Debt: Clear /srv/.git on contint1001; move integration.wikimedia.org doc... - https://phabricator.wikimedia.org/T149924 [22:42:17] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10User-dancy: Collect samples of workspace sizes on integration-agent-docker-* nodes - https://phabricator.wikimedia.org/T258626 (10thcipriani) [22:42:19] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Consider phasing out maintenance-sample-workspace-sizes - https://phabricator.wikimedia.org/T266769 (10thcipriani) 05Open→03Resolved a:03hashar [22:51:54] marxarelli: I just ran head first into T263597 again and then found gilles having a similar issue in T269215. I have time to write patches for Blubber to make this build -> copy + build functionality possible if you have a bit of time to help me figure out what the design of the solution should be. [22:51:55] T269215: Blubber "copies" and "builder command" steps should run in the opposite order - https://phabricator.wikimedia.org/T269215 [22:51:55] T263597: Allow use of copied artifacts in subsequent build step - https://phabricator.wikimedia.org/T263597