[00:00:46] bd808: i like your proposal [00:01:10] marxarelli: sweet. I'll try to figure out how to do it then :) [00:02:06] I had an idea of a nasty hack to work around it, but that just blew up too because I can't find a base image for Buster that has the backports repo enabled to get npm from. :/ [00:02:15] i was also thinking of refactoring `builder` into `builders` with requirements/command pair that are explicitly ordered, but i think those two changes are orthogonal, so have at it and i'll build on top of your change [00:02:33] *pairs* [00:04:37] (03PS1) 10Legoktm: zuul: Restore PHP 8.0 tests for wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/646868 [00:06:05] marxarelli: ah, is the "builders" idea related to T201875? [00:06:05] T201875: Allow new blubber builders to be implemented in yaml - https://phabricator.wikimedia.org/T201875 [00:08:30] sort of [00:09:03] that's more a way of extending the functionality from some external configuration [00:09:16] *nod* [00:10:38] but this would 1) make ordering more explicit, 2) allow multiple builder commands without having to do `command: [sh, -c ...]`, 3) allow separate sets of requirements for each of those commands, 4) pave the way for simpler reimplementation of the python/node builders (they could be represented as generic builders internally [00:11:10] bd808: i left a comment about implementation thoughts for your change. i think it may be super easy? :) [00:11:23] if `ArtifactsConfig` can be reused [00:16:23] but let me know if you want to pair on it [00:17:48] marxarelli: thanks for the notes. I'll take a look and reach out if I get lost. I think I looked at this before and thought that it wouldn't be too hard to implement, but that was several months ago. :) [00:18:44] bd808: sounds good. looking forward to the feature! [00:19:25] longma and dancy have been hacking on blubber lately too, so if i'm not available they should be able to help as well [01:01:54] 10Release-Engineering-Team (Deployment services), 10Scap: scap php -l does not show which file has an issue - https://phabricator.wikimedia.org/T269586 (10thcipriani) [01:01:57] 10Scap: Linting phase in scap doesn't show which file caused the error - https://phabricator.wikimedia.org/T198423 (10thcipriani) [02:42:16] (03CR) 10Jforrester: [C: 03+2] zuul: Restore PHP 8.0 tests for wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/646868 (owner: 10Legoktm) [02:43:30] (03Merged) 10jenkins-bot: zuul: Restore PHP 8.0 tests for wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/646868 (owner: 10Legoktm) [02:43:43] !log Zuul: [mediawiki/php/wikidiff2] Make PHP 8.0 tests voting T269052 [02:43:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:43:46] T269052: wikidiff2 isn't compatible with PHP 8.0 - https://phabricator.wikimedia.org/T269052 [02:48:59] legoktm: Can I wheedle a build from you? https://phabricator.wikimedia.org/T269052#6675269 :-) [03:12:23] legoktm: Also https://gerrit.wikimedia.org/r/c/mediawiki/services/citoid/+/646877 looks like LibUp has a bug in the npm audit stuff somehwere. [05:19:37] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Operations, 10User-DannyS712: Beta cluster logstash down - https://phabricator.wikimedia.org/T268200 (10DannyS712) p:05Triage→03High a:05herron→03None Reset assignee since it was automatically set when @herron closed as resolved, but the... [05:37:58] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10DannyS712) I've filed {T269650} and {T269651} - should either be a train blocker for this week, and/or prompt... [05:41:05] James_F: ty for the deploy. I'll do the wikidiff2 release tomorrow [05:41:20] That citoid patch is wild [05:50:35] Of course. Thanks. And yeah, very odd. [05:52:36] James_F does https://phabricator.wikimedia.org/T269650 warrant a rollback out of the normal schedule? [05:53:23] I just realized that it means that Special:EntityData is effectively broken for all senses, and logstash only had a few errors because it was only tried with a few different senses [05:53:31] Possibly? Hashar’s call I think. Or whomever is on train. [05:53:48] But WL isn’t really a primary service in the same way as other things. 🤷🏽‍♂️ [05:54:06] WL? [06:05:37] https://news.ycombinator.com/item?id=25338983 looks like Travis is officially dead :( [06:07:31] (03PS1) 10Prod: Run phan for mediawiki/extensions/ParserMigration [integration/config] - 10https://gerrit.wikimedia.org/r/646900 [06:22:56] (03PS2) 10Prod: Run phan for mediawiki/extensions/WatchSubpages [integration/config] - 10https://gerrit.wikimedia.org/r/646900 [07:35:29] 10Release-Engineering-Team (Kanban), 10Quibble, 10Patch-For-Review: Error: 1071 Specified key was too long; max key length is 767 bytes - https://phabricator.wikimedia.org/T193222 (10Nikerabbit) > I don't think MediaWiki enforces anything, hence some extension might fail to install when MySQL uses `utf8mb4,... [07:37:44] 10Release-Engineering-Team (Kanban), 10Quibble, 10Patch-For-Review: Error: 1071 Specified key was too long; max key length is 767 bytes - https://phabricator.wikimedia.org/T193222 (10Nikerabbit) [09:51:40] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream: Duplicated 'should should' in Phabricator:arcanist-core english messages sent for translation - https://phabricator.wikimedia.org/T201138 (10Aklapper) Zero results for `"should should"` when grep'ing the upstream codebase, but it's unclear to... [09:52:14] (03PS2) 10Hashar: Add rename-project plugin @ a880148 [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/630548 (https://phabricator.wikimedia.org/T201953) [10:06:33] (03CR) 10Awight: "This is ready for review. It works locally, but I'm not sure about the wiring." [integration/config] - 10https://gerrit.wikimedia.org/r/630164 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [10:10:36] (03CR) 10Awight: "Huge mistake: I somehow failed to rename directories after borrowing the base machinery." [integration/config] - 10https://gerrit.wikimedia.org/r/630164 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [10:14:06] (03Abandoned) 10Awight: [WIP] Apache service for Quibble [integration/config] - 10https://gerrit.wikimedia.org/r/630164 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [10:15:14] (03CR) 10Awight: "This is the active patch: https://gerrit.wikimedia.org/r/c/integration/config/+/644485" [integration/config] - 10https://gerrit.wikimedia.org/r/630164 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [10:17:40] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10Lucas_Werkmeister_WMDE) >>! In T264801#6675430, @DannyS712 wrote: > I've filed {T269650}, {T269651}, and {T26... [10:26:13] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release: Tag Scap release 1.36.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T266676 (10jijiki) [10:26:18] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops, 10User-jijiki: Deploy Scap version 3.16.0-1 - https://phabricator.wikimedia.org/T268634 (10jijiki) 05Open→03Resolved a:03jijiki [10:38:24] (03CR) 10Daimona Eaytoy: [C: 03+1] docker: Switch back to Daimona's repo for phan-taint-check demo [integration/config] - 10https://gerrit.wikimedia.org/r/644367 (owner: 10Legoktm) [10:41:21] (03CR) 10Hashar: [C: 04-1] "As I understand it the job triggers after a merge is done on mediawiki/tools/phan/SecurityCheckPlugin BUT then build and deploy from the g" [integration/config] - 10https://gerrit.wikimedia.org/r/644367 (owner: 10Legoktm) [10:50:03] (03CR) 10Matěj Suchánek: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [10:50:10] (03CR) 10Hashar: "We should use a job template to avoid copy pasting the jobs. That makes maintenance easier." (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester) [10:50:16] (03CR) 10Hashar: [C: 04-1] jjb: Provide PHP 7.3 and 7.4 version of PHPUnit coverage publish job [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester) [10:55:19] (03CR) 10Hashar: [C: 03+2] "Indeed, thank you :)" [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [10:56:40] (03Merged) 10jenkins-bot: Add Echo as phan dependency for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [10:59:33] (03CR) 10Hashar: "Deployed, you can comment 'recheck' on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/640408 ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [11:24:12] (03Abandoned) 10Hashar: fab: tail docker-pkg-build log [integration/config] - 10https://gerrit.wikimedia.org/r/620721 (owner: 10Hashar) [11:30:08] (03CR) 10Matěj Suchánek: "> Patch Set 4:" [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [12:06:07] (03CR) 10Kosta Harlan: [C: 03+1] Image for quibble serving from apache [integration/config] - 10https://gerrit.wikimedia.org/r/644485 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [12:06:11] (03CR) 10Daimona Eaytoy: Add Echo as phan dependency for AbuseFilter (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/645359 (owner: 10Matěj Suchánek) [12:13:20] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) [12:13:37] (03PS1) 10Daimona Eaytoy: layout: [mediawiki/extensions/AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 [12:14:33] (03PS2) 10Daimona Eaytoy: layout: [mediawiki/extensions/AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 [12:15:58] (03CR) 10jerkins-bot: [V: 04-1] layout: [mediawiki/extensions/AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 (owner: 10Daimona Eaytoy) [12:16:59] (03PS3) 10Daimona Eaytoy: layout: [AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 [12:18:17] (03CR) 10jerkins-bot: [V: 04-1] layout: [AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 (owner: 10Daimona Eaytoy) [12:20:22] (03PS4) 10Daimona Eaytoy: layout: [AbuseFilter] Move Echo to phan_dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/646979 [12:34:09] o/ I backported a patch to 1.36.0-wmf.20 and deployed it but I see that 1.36.0-wmf.21 was cut so I cherry-picked it on the .21 branch as well, should I just +2 my patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/646779) as I can't see the php-1.36.0-wmf.21 folder [12:34:25] on the deployment host [12:37:19] I +2ed the patch, please let me know if I need to do something [12:41:00] (03PS3) 10Kosta Harlan: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [12:41:07] (03Abandoned) 10Kosta Harlan: [black] Add tox.ini entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/644179 (owner: 10Kosta Harlan) [12:41:22] (03CR) 10Kosta Harlan: Reformat files with black (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [12:42:05] (03CR) 10Kosta Harlan: Reformat files with black (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [12:42:09] kostajh: :] [12:42:25] dcausse: yeah should be +2ed [12:42:36] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [12:42:51] dcausse: as you found out wmf.21 has been cut, that is done automatically over the night. But it will only be fetched on the deployment server later on [12:43:20] hashar / awight btw: https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame [12:44:07] (03PS5) 10Daimona Eaytoy: Move Echo to phan_dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/646979 [12:44:27] kostajh: nice trick [12:45:29] I still dislikes the arbitrary opinions it is taking much like I hated jshint hehe :] [12:47:42] oh hey, there's also a block-level disable pragma, so we could skip the Xvfb arguments for example. [12:48:21] Although, formatting already revealed a bug in the code, maybe it's worth the potential inconvenience to just go post-opinion. [12:48:30] Do you know how to work around the CI build error? [12:53:18] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release: Tag Scap release 1.36.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T266676 (10LarsWirzenius) 05Open→03Resolved This is done now. [12:53:38] (03CR) 10Hashar: [C: 03+2] Move Echo to phan_dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/646979 (owner: 10Daimona Eaytoy) [12:55:01] (03Merged) 10jenkins-bot: Move Echo to phan_dependencies for AbuseFilter [integration/config] - 10https://gerrit.wikimedia.org/r/646979 (owner: 10Daimona Eaytoy) [12:55:51] (03CR) 10Hashar: "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/646979 (owner: 10Daimona Eaytoy) [12:59:38] kostajh: I think something is wrong with the block where deps are declared. Maybe delete "testenv:" so that the [black] block looks like [flake8]? [13:00:35] (03PS4) 10Kosta Harlan: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [13:01:08] awight: thanks, I'm not sure that was it, but changed it anyway. It looks like we have to tell flake8 to ignore a few more rules because of the shorter line length [13:01:44] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [13:01:52] hashar: in the meeting with awight, we looked over the integration/config patch to build quibble-apache (looks good to me) and I think you will write a job to add apache to quibble full run? [13:03:07] awight: ah right, black needs python >= 3.6 [13:03:12] So it fails to install on 3.5. [13:04:24] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services), 10Patch-For-Review: Switch Jenkins servers to Java 11 - https://phabricator.wikimedia.org/T269354 (10hashar) [13:04:33] (03PS5) 10Kosta Harlan: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [13:05:48] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [13:11:22] (03PS1) 10Lars Wirzenius: fix: specify which code template to use in subplot [tools/scap] - 10https://gerrit.wikimedia.org/r/646985 [13:12:52] (03PS6) 10Kosta Harlan: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [13:14:43] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [13:15:17] (03CR) 10Lars Wirzenius: [C: 03+2] "Self-reviewing obvious and necessary fix." [tools/scap] - 10https://gerrit.wikimedia.org/r/646985 (owner: 10Lars Wirzenius) [13:16:15] (03PS7) 10Kosta Harlan: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 [13:16:17] (03PS20) 10Daimona Eaytoy: dockerfiles: coverage: add pcov, use it if we're on PHPUnit 8+ [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) [13:18:19] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [13:21:25] awight: OK I give up for now, if you have ideas please let me know [13:54:12] (03PS1) 10Lars Wirzenius: chore: format all code with Black, require it in the future [tools/scap] - 10https://gerrit.wikimedia.org/r/646991 [14:06:13] kostajh: true I forgot about building the CI job sorry :/ [14:07:07] hashar: No rush, the patch to create the image is still pending review anyway! [14:08:01] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Patch-For-Review, 10Technical-Debt: Move integration/docroot.git deployment to scap - https://phabricator.wikimedia.org/T256005 (10hashar) [14:08:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Operations, 10Patch-For-Review: scap configuration in puppet defaults to forge the git repo name with 'mediawiki/services/' - https://phabricator.wikimedia.org/T257413 (10hashar) ... [14:11:01] (03PS1) 10Awight: [WIP] experimenting with test failures [integration/quibble] - 10https://gerrit.wikimedia.org/r/646995 [14:11:25] kostajh: It might be worth creating a Phabricator task for the `black` work, so there are breadcrumbs left behind. [14:12:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] experimenting with test failures [integration/quibble] - 10https://gerrit.wikimedia.org/r/646995 (owner: 10Awight) [14:23:43] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) [14:38:14] (03CR) 10Awight: "I was able to reproduce the failure locally," [integration/quibble] - 10https://gerrit.wikimedia.org/r/646995 (owner: 10Awight) [14:38:56] (03Abandoned) 10Hashar: build: boilerplate for web tests [integration/docroot] - 10https://gerrit.wikimedia.org/r/623574 (owner: 10Hashar) [14:43:29] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s, 10Performance-Team (Radar): Experiment with generating json config - https://phabricator.wikimedia.org/T267057 (10thcipriani) p:05Triage→03Medium [14:48:21] (03Abandoned) 10Awight: [WIP] experimenting with test failures [integration/quibble] - 10https://gerrit.wikimedia.org/r/646995 (owner: 10Awight) [14:50:11] (03PS8) 10Awight: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [14:51:49] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [14:53:48] (03PS9) 10Awight: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [15:15:23] (03PS10) 10Awight: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [15:18:26] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10hashar) [15:19:41] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream: Duplicated 'should should' in Phabricator:arcanist-core english messages sent for translation - https://phabricator.wikimedia.org/T201138 (10Nikerabbit) We just pull from the wmf/stable branch of https://phabricator.wikimedia.org/source/phabri... [15:34:56] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops, 10User-jijiki: Deploy Scap version 3.16.0-1 - https://phabricator.wikimedia.org/T268634 (10jijiki) 05Resolved→03Open @Urbanecm reported that scap is throwing some warnings: ` 15:27:45 WARNING - Duplicate plugin named CheckoutMediaWiki, skipping.... [15:34:58] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release: Tag Scap release 1.36.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T266676 (10jijiki) [15:35:29] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops, 10User-jijiki: Deploy Scap version 3.16.0-1 - https://phabricator.wikimedia.org/T268634 (10jijiki) p:05Triage→03High [15:44:28] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T263186 (10daniel) [16:04:18] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops, 10User-jijiki: Deploy Scap version 3.16.0-1 - https://phabricator.wikimedia.org/T268634 (10LarsWirzenius) p:05High→03Medium This is due to {T248490}, and it's harmless. mediawiki-config contains a bunch of plugins for Scap, and they've been includ... [16:29:07] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Zuul: CI / Zuul not processing changes - https://phabricator.wikimedia.org/T246973 (10thcipriani) 05Open→03Resolved If the problem here w... [17:03:05] (03CR) 10Jforrester: "> Do we actually need to generate coverage with 7.3 / 7.4?" [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester) [17:03:47] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release: Tag Scap release 1.36.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T266676 (10LarsWirzenius) [17:03:53] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops, 10User-jijiki: Deploy Scap version 3.16.0-1 - https://phabricator.wikimedia.org/T268634 (10LarsWirzenius) 05Open→03Resolved mediawiki-config has dropped tthe plugins. Issue should be resolvedd. [17:10:10] (03PS1) 10Hashar: dockerfiles: bazelisk a wrapper for Bazel [integration/config] - 10https://gerrit.wikimedia.org/r/647023 [17:12:53] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Parsoid, 10Patch-For-Review, 10User-brennen: mediawiki-vendor submodule doesn't get automatically bumped on release branches - https://phabricator.wikimedia.org/T259832 (10cscott) 05Open... [17:18:14] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Platform Engineering (Icebox): Audit all existing code to ensure that any extension currently or previously adding blobs to ExternalStore has been registering a reference in the text table (and fix up if ... - https://phabricator.wikimedia.org/T106388 [17:25:52] 10Release-Engineering-Team, 10serviceops, 10Security, 10cloud-services-team (Kanban): Implement SSH CA (certificate authority) for host keys? - https://phabricator.wikimedia.org/T268344 (10Andrew) p:05Triage→03Low Patches welcome! This isn't something we're likely to have time for anytime soon. [17:31:06] 10MediaWiki-Releasing, 10AbuseFilter (Overhaul-2020), 10MW-1.36-release, 10Patch-For-Review: Bundle AbuseFilter extension with MediaWiki - https://phabricator.wikimedia.org/T191740 (10Daimona) [17:44:55] 10Phabricator, 10Patch-For-Review: Allow video embeds in formats other than OGV (e.g. WEBM) - https://phabricator.wikimedia.org/T215360 (10mmodell) I'm in favor of this change. [17:46:12] (03PS3) 10Jforrester: Zuul: [mediawiki/extensions/WatchSubpages] Run phan [integration/config] - 10https://gerrit.wikimedia.org/r/646900 (owner: 10Prod) [17:46:17] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/WatchSubpages] Run phan [integration/config] - 10https://gerrit.wikimedia.org/r/646900 (owner: 10Prod) [17:47:30] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WatchSubpages] Run phan [integration/config] - 10https://gerrit.wikimedia.org/r/646900 (owner: 10Prod) [17:47:48] !log Zuul: [mediawiki/extensions/WatchSubpages] Run phan [17:47:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:49:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Quibble, 10EngProd-Virtual-Hackathon: Feature request: Evaluate "require" field from "extension.json" in automated test environment - https://phabricator.wikimedia.org/T185736 (10thcipriani) a:03has... [17:52:59] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki Train Development Environment: Make train-dev be able to test changes to mediawiki-config - https://phabricator.wikimedia.org/T269691 (10LarsWirzenius) [17:54:34] 10Phabricator, 10User-Kizule: Phabricator does not show videos in webm format as embedded - https://phabricator.wikimedia.org/T244162 (10mmodell) @dzahn: I think my objection was misguided. I'd like to fix the phabricator storage issues but for now objection retracted. [17:59:59] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10mmodell) I think we have referrer logs on the phabricator server but they aren't retained for very long and they aren't currently analyzed. [18:01:05] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services): releng/phpmetrics should use composer.json / composer.lock - https://phabricator.wikimedia.org/T269203 (10hashar) [18:42:21] !log Cleaning up some of my cherry-picks in beta puppet. [18:42:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:27:55] (03CR) 10Legoktm: [C: 03+2] Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [19:29:36] (03CR) 10jerkins-bot: [V: 04-1] Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [19:40:53] (03CR) 10Legoktm: "Using the latest PHP version is always preferred just because it tends to be faster..." [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester) [19:50:29] (03CR) 10DannyS712: "Doesn't support php8:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [19:54:24] (03CR) 10Hashar: [C: 04-1] "That makes sense :-] So that boils down to using a job-template to avoid the copy paste and I guess we are set after that!" [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester) [20:42:55] I don't know where to say it but I get this error uploading some large svg files in phabricator: "Exception: No configured storage engine can store this file. See "Configuring File Storage" in the documentation for information on configuring storage engines." [20:59:34] (03PS1) 10Dduvall: Allow user-defined build context and excludes [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 [21:04:06] Amir1: file a bug in Phabricator? ;) [21:05:15] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar: Create initial production MW-land images with blubber - https://phabricator.wikimedia.org/T238773 (10thcipriani) [21:11:21] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10thcipriani) [21:11:24] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Sketch MediaWiki production image composition and workflows - https://phabricator.wikimedia.org/T259817 (10thcipriani) [21:11:28] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar, 10Epic: Get production MW-land images built and published - https://phabricator.wikimedia.org/T238771 (10thcipriani) [21:17:06] legoktm: I uploaded it to people.wikimedia.org and I'm reaaly done for the day, will file it tomorrow [21:18:23] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Convert static mediawiki configuration to form more suitable for containers - https://phabricator.wikimedia.org/T263166 (10thcipriani) [21:18:26] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Sketch MediaWiki production image composition and workflows - https://phabricator.wikimedia.org/T259817 (10thcipriani) [21:19:01] 10Release-Engineering-Team (Logspam), 10Wikimedia-General-or-Unknown, 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-error, 10Wikimedia-production-error: Occasional "Cannot access the database: Unknown error" in Wikimedia production - https://phabricator.wikimedia.org/T268715 (10Clara... [21:21:33] :)) [21:22:18] 10Release-Engineering-Team, 10MediaWiki-extensions-OAuth, 10Platform Team Workboards (Clinic Duty Team), 10ci-test-error (WMF-deployed Build Failure): Invalid timestamp/Failed asserting that $timestamp1 is identical to $timestamp2 - https://phabricator.wikimedia.org/T269502 (10Clarakosi) [21:23:48] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Convert static mediawiki configuration to form more suitable for containers - https://phabricator.wikimedia.org/T263166 (10thcipriani) Removed from the {T238770} task tree as this doesn't nece... [21:23:49] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647066 (owner: 10DannyS712) [21:24:44] (03CR) 10DannyS712: "needed for php8 support, since 0.10.4 requires phan/phan 3.0.3 which requires php ^7.2.0" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647066 (owner: 10DannyS712) [21:26:18] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Investigate/trace rebuildLocalisationCache process for MW containerization - https://phabricator.wikimedia.org/T260827 (10thcipriani) [21:26:21] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Sketch MediaWiki production image composition and workflows - https://phabricator.wikimedia.org/T259817 (10thcipriani) [21:26:23] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar, 10Epic: Deploy MediaWiki to Wikimedia production in containers - https://phabricator.wikimedia.org/T238770 (10thcipriani) [21:26:29] legoktm would you mind reviewing https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/647066 ^ unbreaks master tests for codesniffer, since php8 is now voting [21:27:21] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.5 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647066 (owner: 10DannyS712) [21:27:30] (03PS11) 10DannyS712: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 [21:27:34] thanks [21:27:54] (03CR) 10Legoktm: [C: 03+2] "..." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [21:28:01] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10thcipriani) [21:28:03] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Author a presentation to showcase MW image build pipeline idea - https://phabricator.wikimedia.org/T262455 (10thcipriani) [21:28:07] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Sketch MediaWiki production image composition and workflows - https://phabricator.wikimedia.org/T259817 (10thcipriani) [21:28:23] (03PS8) 10DannyS712: Add AssertionOrderSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) [21:28:33] DannyS712: thanks for catching that [21:28:56] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Run stress tests on docker images infrastructure - https://phabricator.wikimedia.org/T264209 (10thcipriani) [21:28:58] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Sketch MediaWiki production image composition and workflows - https://phabricator.wikimedia.org/T259817 (10thcipriani) [21:29:00] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar, 10Epic: Deploy MediaWiki to Wikimedia production in containers - https://phabricator.wikimedia.org/T238770 (10thcipriani) [21:29:01] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.5 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647066 (owner: 10DannyS712) [21:29:30] (03Merged) 10jenkins-bot: Move all PHPUnit sniffs from the `Usage` group to a new PHPUnit group [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/599482 (owner: 10DannyS712) [21:33:43] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Configure Zuul to trigger PipelineLib based pipelines during gate-and-submit for a few MW components - https://phabricator.wikimedia.org/T262460 (10thcipriani) [21:33:45] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Build single version MediaWiki image from wmf branch using only PipelineLib/Blubber - https://phabricator.wikimedia.org/T269617 (10thcipriani) [21:33:47] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review: Refactor PipelineLib to allow for alternate docker image pusher - https://phabricator.wikimedia.org/T265177 (10thcipriani) [21:33:49] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Experiment with PipelineLib/Blubber driven MediaWiki container image pipeline - https://phabricator.wikimedia.org/T260828 (10thcipriani) [21:34:39] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops-radar, 10Epic: Deploy MediaWiki to Wikimedia production in containers - https://phabricator.wikimedia.org/T238770 (10thcipriani) [21:34:51] (03PS8) 10Umherirrender: Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) [21:35:08] (03PS2) 10Umherirrender: Check for object and object[] on @var docs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/644296 [21:35:11] (03PS2) 10Brennen Bearnes: Add --verbose flag to eventlogging image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/610194 (https://phabricator.wikimedia.org/T257378) (owner: 10Dbarratt) [21:37:47] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar: Add production config injection - https://phabricator.wikimedia.org/T238775 (10thcipriani) [21:37:49] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MW-on-K8s: Convert static mediawiki configuration to form more suitable for containers - https://phabricator.wikimedia.org/T263166 (10thcipriani) [21:38:04] (03CR) 10Brennen Bearnes: [V: 04-1 C: 04-1] "I've added the necessary bump to the changelog." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/610194 (https://phabricator.wikimedia.org/T257378) (owner: 10Dbarratt) [21:39:35] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops-radar: Add production config injection - https://phabricator.wikimedia.org/T238775 (10thcipriani) [21:39:37] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar: Create initial production MW-land images with blubber - https://phabricator.wikimedia.org/T238773 (10thcipriani) [21:39:39] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops-radar: Add production config injection - https://phabricator.wikimedia.org/T238775 (10thcipriani) [21:42:18] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): l10n process for MW containerization - https://phabricator.wikimedia.org/T260827 (10thcipriani) [21:45:43] (03CR) 10Brennen Bearnes: [V: 04-1 C: 04-1] "For clarity, it looks like the eventlogging image build is broken generally - not specific to this change." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/610194 (https://phabricator.wikimedia.org/T257378) (owner: 10Dbarratt) [21:52:15] (03CR) 10Brennen Bearnes: "> btw, I think this would be a good time to migrate to XDebug 3." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/640567 (owner: 10Brennen Bearnes) [21:57:39] [22:20:57] 10Continuous-Integration-Config, 10MW-1.35-release: Add PHP 8.0 non voting jobs to 1.35 - https://phabricator.wikimedia.org/T269714 (10Reedy) [22:57:55] (03PS1) 10Jforrester: Zuul: [labs/tools/stewardbots] Disable PHP 8.0 tests, not passing [integration/config] - 10https://gerrit.wikimedia.org/r/647105 [23:03:22] (03CR) 10Jforrester: [C: 03+2] Zuul: [labs/tools/stewardbots] Disable PHP 8.0 tests, not passing [integration/config] - 10https://gerrit.wikimedia.org/r/647105 (owner: 10Jforrester) [23:04:57] (03Merged) 10jenkins-bot: Zuul: [labs/tools/stewardbots] Disable PHP 8.0 tests, not passing [integration/config] - 10https://gerrit.wikimedia.org/r/647105 (owner: 10Jforrester) [23:05:39] !log Zuul: [labs/tools/stewardbots] Disable PHP 8.0 tests, not passing [23:05:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:27:24] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712) [23:55:37] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712) [23:56:21] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff against assertTrue( true ) - https://phabricator.wikimedia.org/T268509 (10DannyS712) a:03DannyS712