[00:25:36] <James_F>	 Daimona: OK if I alter https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/647091/ to only set WRITE_OLD for now, and set WRITE_BOTH for Beta Cluster?
[00:26:13] <Daimona>	 As a test? Sure
[00:26:22] <wikibugs>	 (03PS21) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:27:54] <James_F>	 Daimona: I'll wait for the backport window to be over.
[00:28:33] <Daimona>	 Sure, no worries, and thank you. Of note, this is also not going to have any effect in prod until next week
[00:28:59] <wikibugs>	 (03PS22) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:29:18] <James_F>	 No, indeed, but running the script in Beta Cluster today and feeling confident that we can run it later would be good.
[00:29:24] <James_F>	 Given the impending no-deploy time.
[00:31:07] <wikibugs>	 (03PS23) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[00:33:27] <wikibugs>	 (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712)
[00:39:18] <wikibugs>	 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) a:03DannyS712
[00:41:35] <Daimona>	 James_F: Oh, right. Perhaps it can be backported, then? So we can run it this week, and there's more time to fix errors etc.?
[00:43:10] <James_F>	 Daimona: Nah, it's fine, we can wait a bit.
[00:43:18] <James_F>	 Daimona: We'll know today if it works.
[00:43:22] <Daimona>	 Sure
[00:43:57] <James_F>	 legoktm: CI builds its images from the Wikimedia apt repo with the version of wikidiff2 there in it. Not sure how we can move CI forwards neatly without changing the version new appservers would also get?
[00:45:49] <legoktm>	 the new version only matters for PHP 8.0 and we get those packages from sury, not our apt repo
[00:45:57] <legoktm>	 and sury doesn't even have wikidiff2
[00:45:58] <James_F>	 Oh, point.
[00:46:12] <James_F>	 But where do we get wikidiff2 from for that?
[00:46:30] <James_F>	 Or do we just silently not have that module on those images and I've never noticed?
[00:46:30] <legoktm>	 it just isn't installed, any tests that might require it (I doubt there are any) just skip
[00:46:34] <legoktm>	 yep
[00:46:36] <James_F>	 Ha.
[00:46:43] <James_F>	 Well, that makes that part of life easier. :-)
[01:12:40] <James_F>	 Daimona: Good news. Found a bug.
[01:13:29] <Daimona>	 Lovely.
[01:13:30] <Reedy>	 Just one?
[01:13:42] <James_F>	 Reedy: So far. PHP has the habit of exiting on errors. ;-)
[01:13:47] <DannyS712>	 for the record, fixing T268200 might help with finding more
[01:13:48] <stashbot>	 T268200: Beta cluster logstash down - https://phabricator.wikimedia.org/T268200
[01:13:49] <Daimona>	 Reedy: That's the good news
[01:13:58] * James_F grins.
[01:15:24] <Daimona>	 "All supported databases have substring functions that behave the same for positive $startPosition and non-negative $length, but behaviors differ when given 0 or negative $startPosition or negative $length. The simplest solution to that is to just forbid those values."
[01:15:35] <Daimona>	 Yay...
[01:16:15] <James_F>	 Gotta love MW.
[01:16:26] <James_F>	 Not sure why, but it's the law. You *have* to.
[01:17:14] <Daimona>	 Welp, seems like we cannot get the starting segment of a string with our DBAL
[01:18:50] <Daimona>	 I'm not really sure there's a solution, because we need that in the UPDATE clause. Unless we want to replace a single mass-update with $batchSize different updates, of course
[01:19:06] <James_F>	 Eurgh.
[01:19:11] <James_F>	 I guess we're going to have to?
[01:19:22] <Daimona>	 No, let's fix the DBAL
[01:19:29] <James_F>	 Or we can patch MW to allow it temporarily in mysql and then ban it again?
[01:19:42] <James_F>	 OK, yeah, we can permanently fix it, but that's $EFFORT. ;-)
[01:19:55] <Daimona>	 Yeah I'd have to quantify the $effort there
[01:20:10] <Daimona>	 (Which is not quite easy when it's 2:20AM eheh)
[01:20:19] <James_F>	 No rush.
[01:21:50] <Daimona>	 And actually, wait. That line was introduced when we were still supporting Oracle and MSSQL
[01:22:11] <Daimona>	 So perhaps we can just remove it if the 3 remainings DBMSs work fine with zeros
[01:22:35] <James_F>	 If.
[01:28:13] <Daimona>	 So, MySQL wants 1 as start position
[01:28:33] <Daimona>	 Same for Postgres
[01:29:13] <Daimona>	 And SQLite too
[01:29:24] <wikibugs>	 (03PS1) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597)
[01:30:26] <James_F>	 Oh, OK, that's not too bad then.
[01:30:40] <James_F>	 How good is our test suite for DBAL stuff?
[01:31:07] <Daimona>	 And so, after matlab and lua, here's another situation where things can be 1-based
[01:31:18] <James_F>	 Tsk.
[01:31:21] <James_F>	 :-)
[01:31:27] <Daimona>	 I think the tests might as well be fine, it's just the error message that might be improved a bit
[01:31:44] <Daimona>	 Like: "String indexes are 1-based" if the start pos is 0
[01:32:06] <Daimona>	 Well, anyway, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/647121
[01:35:30] <Daimona>	 And https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647122 is for the error
[01:40:17] <wikibugs>	 (03CR) 10BryanDavis: "marxarelli: this is working with my blubber.yaml and outputs the Dockerfile I hoped for. I need to write some more tests and update the op" [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[01:42:57] <Daimona>	 Well, time to go. James_F: thank you for running the script, I'm curious to see how many bugs are yet to be found :-)
[01:45:25] * James_F grins.
[01:51:05] <wikibugs>	 (03CR) 10BryanDavis: builder: support cross variant copying for builder.requirements (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[02:34:19] <wikibugs>	 (03PS3) 10Reedy: Bump composer/semver versions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068)
[02:34:44] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] Bump composer/semver versions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[02:36:25] <wikibugs>	 (03Merged) 10jenkins-bot: Bump composer/semver versions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[02:52:33] <wikibugs>	 (03CR) 10Reedy: Bump composer/semver versions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[02:53:21] <wikibugs>	 (03CR) 10Jforrester: Bump composer/semver versions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[02:55:06] <wikibugs>	 (03CR) 10Reedy: Bump composer/semver versions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[03:01:36] <wikibugs>	 (03CR) 10Jforrester: Bump composer/semver versions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647076 (https://phabricator.wikimedia.org/T269068) (owner: 10Reedy)
[03:07:35] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Platform Team Workboards (Green), 10Release, 10Train Deployments: Old revision warning box is added twice on page view if old rev served from cache - https://phabricator.wikimedia.org/T269727 (10Pchelolo)
[03:08:18] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Platform Team Workboards (Green), 10Release, 10Train Deployments: Old revision warning box is added twice on page view if old rev served from cache - https://phabricator.wikimedia.org/T269727 (10Pchelolo)
[03:24:41] <DannyS712>	 James_F if you have a minute, would you mind reviewing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/647079/ ?
[03:50:19] <James_F>	 DannyS712: Done.
[03:54:01] <DannyS712>	 thanks so much - I'll test again once it merges
[03:55:04] <DannyS712>	 also, anything I can review for you?
[05:41:53] <wikibugs>	 (03PS2) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597)
[05:54:32] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-Parser, 10Patch-For-Review, 10Platform Team Workboards (Green), 10Regression: Old revision warning box is added twice on page view if old rev served from cache - https://phabricator.wikimedia.org/T269727 (10DannyS712)
[07:44:41] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Looks fine when I compare it with what I wrote in T252914#6142288. Also, nothing is found in the test run, which is good, I think." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712)
[08:21:51] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I think I find a small issue in the auto-fix. Looks really good otherwise." (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712)
[08:42:21] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): "Looks good, but …" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[08:49:39] <wikibugs>	 (03PS4) 10Hashar: jjb: Provide PHP 7.3 and 7.4 version of PHPUnit coverage publish job [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester)
[08:49:41] <wikibugs>	 (03PS1) 10Hashar: jjb: use same image in coverage publish job [integration/config] - 10https://gerrit.wikimedia.org/r/647194
[08:51:24] <wikibugs>	 (03CR) 10Hashar: "I have changed it to a job template. In order to rely on a single image, I have introduced an intermediate step that replaces releng/php72" (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester)
[08:52:07] <wikibugs>	 (03CR) 10Hashar: "Makes it possible to use a single docker image variable when the job is converted to a job template with  https://gerrit.wikimedia.org/r/c" [integration/config] - 10https://gerrit.wikimedia.org/r/647194 (owner: 10Hashar)
[08:52:25] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I love it! Thanks for the update. I think I will merge this within the next days when nobody objects." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender)
[08:56:11] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "Lets do it!  The first use case will be for a new job that solely triggers on integration/quibble changes and would thus have the latest c" [integration/config] - 10https://gerrit.wikimedia.org/r/644485 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight)
[08:57:58] <wikibugs>	 (03Merged) 10jenkins-bot: Image for quibble serving from apache [integration/config] - 10https://gerrit.wikimedia.org/r/644485 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight)
[09:16:03] <wikibugs>	 (03CR) 10Kosta Harlan: [C: 03+1] "Changes in PS8-PS-10 look good to me, thanks Adam!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan)
[09:30:37] <wikibugs>	 (03PS1) 10Hashar: (DO NOT SUBMIT) [integration/config] - 10https://gerrit.wikimedia.org/r/647199
[09:33:22] <wikibugs>	 (03CR) 10Awight: Reformat files with black (034 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan)
[09:34:15] <hashar>	 kostajh: awight: in case one of you is around. I have tried to build the quibble-apache image and it is missing a php.ini file for COPY ./php-fpm/php.ini /etc/php/7.2/fpm/php.ini
[09:35:36] <hashar>	 Oh 
[09:35:41] <hashar>	 I can just grab it from quibble it seems
[09:37:59] <wikibugs>	 (03CR) 10Kosta Harlan: [C: 03+1] Reformat files with black (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan)
[09:38:11] <wikibugs>	 (03PS1) 10Hashar: dockerfiles: quibble-apache missed php.ini file [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218)
[09:39:13] <wikibugs>	 (03CR) 10Hashar: [C: 03+1] "Copied from integration/quibble . It was not added in the previous chance since we had .gitignore igoring '*.ini'.   The image builds now " [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[09:43:11] <wikibugs>	 (03CR) 10Awight: "Nice find!" [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[09:44:08] <hashar>	 awight: mind +2ing it?  I will build the container
[09:44:15] <hashar>	 it managed to build locally at lesat!
[09:47:18] <wikibugs>	 (03PS1) 10Thiemo Kreuz (WMDE): Avoid slow strcasecmp() where not necessary [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647205
[09:48:36] <wikibugs>	 (03PS11) 10Awight: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan)
[09:48:38] <wikibugs>	 (03PS1) 10Awight: Subprocess argument fixes [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206
[09:49:07] <awight>	 hashar: Looks like I don't have CR+2 in integration/config.  Probably for the better ;-)
[09:49:18] <wikibugs>	 (03CR) 10Awight: [C: 03+1] "Would merge if I could!" [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[09:51:31] <wikibugs>	 (03CR) 10Awight: Reformat files with black (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan)
[09:51:33] <wikibugs>	 (03CR) 10Kosta Harlan: [C: 03+1] dockerfiles: quibble-apache missed php.ini file [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[10:03:58] <wikibugs>	 (03CR) 10Ammarpad: [C: 03+1] Avoid slow strcasecmp() where not necessary [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647205 (owner: 10Thiemo Kreuz (WMDE))
[10:21:03] <hashar>	 awight: :D
[10:21:17] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] dockerfiles: quibble-apache missed php.ini file [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[10:22:37] <wikibugs>	 (03Merged) 10jenkins-bot: dockerfiles: quibble-apache missed php.ini file [integration/config] - 10https://gerrit.wikimedia.org/r/647202 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[10:22:59] <hashar>	 and it fails :/
[10:22:59] <hashar>	 https://phabricator.wikimedia.org/P13536
[10:23:13] <hashar>	 INFO:backend.DevWebServer:Starting external webserver
[10:23:18] <hashar>	 	  File "/usr/local/lib/python3.5/dist-packages/quibble/backend.py", line 393, in start
[10:23:19] <hashar>	 	    server_cmd,
[10:23:19] <hashar>	 	UnboundLocalError: local variable 'server_cmd' referenced before assignment
[10:23:19] <hashar>	 hehe
[10:23:34] <hashar>	 cause well that is using quibble 0.0.45
[10:26:22] <jbond42>	 hashar: can you let me know a good time to merge https://gerrit.wikimedia.org/r/c/integration/config/+/645143 and the associated puppet change
[10:28:17] <hashar>	 !log Successfully tagged docker-registry.discovery.wmnet/releng/quibble-apache:0.0.1  T225218
[10:28:20] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[10:28:20] <stashbot>	 T225218: Consider httpd for quibble instead of php built-in server - https://phabricator.wikimedia.org/T225218
[10:28:39] <hashar>	 jbond42: oh yeah forgot about this one
[10:29:03] <hashar>	 jbond42: the image rebuild is merely to have the parallel_spec gem to be preinstalled in the image isn't it ?
[10:29:14] <jbond42>	 yes exactly
[10:29:25] <hashar>	 so yeah lets do that ;]
[10:29:33] <jbond42>	 ok cool ill merge the puppet one now
[10:30:27] <jbond42>	 ok thats merged
[10:31:35] <wikibugs>	 (03CR) 10Hashar: "Deployed and a first run is https://integration.wikimedia.org/ci/job/integration-quibble-apache-fullrun/1/   There is certainly going to n" [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (owner: 10Hashar)
[10:31:41] <hashar>	 jbond42: rebuilding ;)
[10:31:49] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] dockerfiles/operations-puppet: add parallel_spec to Rakefile [integration/config] - 10https://gerrit.wikimedia.org/r/645143 (owner: 10Jbond)
[10:31:55] <jbond42>	 hashar: great thanks <3
[10:32:34] <hashar>	 jbond42: possibly we could even split the job and have the   profile specs to be run in a standalone job
[10:32:57] <wikibugs>	 (03Merged) 10jenkins-bot: dockerfiles/operations-puppet: add parallel_spec to Rakefile [integration/config] - 10https://gerrit.wikimedia.org/r/645143 (owner: 10Jbond)
[10:33:03] <hashar>	 but that means parallelism of all the rake tasks would be configured in the CI config instead of via the Rakefile so it is probably counterintuitive for most folks
[10:33:32] <jbond42>	 hashar: i think im going to see about having some type of goal for next Q to take a good look at CI for the puppet repo
[10:33:52] <jbond42>	 i think there is alrready some stuff we can do in rake to help inprove
[10:35:00] <jbond42>	 i.e. we currently do modeules.each {|modules| system("cd #{modules}; rake parallel_spec")`
[10:35:23] <jbond42>	 changing the to use parallel_spec directly instead of spawning rake for every module will help
[10:35:43] <hashar>	 most probably yeah
[10:36:00] <jbond42>	 also useing parallel_spec will also mean we can (in theory) add additional cores to help 
[10:46:54] <wikibugs>	 (03PS2) 10Hashar: Quibble full run with Apache [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218)
[10:48:01] <wikibugs>	 (03CR) 10Hashar: "I have made the job to just run api-testing, qunit and selenium stages.  An example run is ongoing at: https://integration.wikimedia.org/c" [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[10:48:29] <hashar>	 awight: kostajh: the quibble apache fullrun is running at https://integration.wikimedia.org/ci/job/integration-quibble-apache-fullrun/3/console :]  Only running qunit/api-testing/selenium though
[10:48:34] <hashar>	 we will see how it behaves
[10:50:12] <wikibugs>	 (03PS1) 10Hashar: jjb: use operations-puppet 0.8.0 for parallel_spec [integration/config] - 10https://gerrit.wikimedia.org/r/647213
[10:50:19] <hashar>	 jbond42: Successfully tagged docker-registry.discovery.wmnet/releng/operations-puppet:0.8.0 
[10:50:36] <jbond42>	 hashar: thanks ill kick of a run now to test
[10:50:45] <hashar>	 jbond42: we need to update the jenkins job
[10:51:42] <jbond42>	 hashar: oh yes i can do that now
[10:51:54] <wikibugs>	 (03CR) 10Hashar: [C: 03+2] "operations-puppet-tests-buster-docker updated :)" [integration/config] - 10https://gerrit.wikimedia.org/r/647213 (owner: 10Hashar)
[10:51:59] <hashar>	 jbond42: done :]
[10:52:03] <jbond42>	 :) thanks
[10:52:41] <hashar>	 argh
[10:53:03] <hashar>	 jbond42: I haven't seen the time, I have to rush to school to get my kids.  Should I roll it back  or is that going to work ? 
[10:53:04] <hashar>	 ;)
[10:53:06] <hashar>	 sorry
[10:53:41] <wikibugs>	 (03Merged) 10jenkins-bot: jjb: use operations-puppet 0.8.0 for parallel_spec [integration/config] - 10https://gerrit.wikimedia.org/r/647213 (owner: 10Hashar)
[10:53:42] <jbond42>	 do you have 60secs for the job to complete :)
[10:53:46] <hashar>	 yes
[10:53:47] <hashar>	 :)
[10:54:30] <hashar>	 I should really migrate all that crap to use scap instead
[10:54:46] <kostajh>	 awight: did you test qunit with the apache backend? I didn't, and I see the job that hashar crafted is failing
[10:54:52] <kostajh>	 hashar: thanks for making the job :) 
[10:54:58] <hashar>	 jbond42: looks good ;)
[10:55:09] <jbond42>	 yes looks good to me thx
[10:55:17] <hashar>	 \o/
[10:56:15] <hashar>	 kostajh: yeah 00:03:04.359 09 12 2020 10:50:10.151:WARN [middleware:karma]: Invalid file type (), defaulting to js.
[10:56:17] <hashar>	 :\
[10:56:30] <hashar>	 or something else really
[10:56:43] <hashar>	 anyway kids time and lunch etc. Be back later 
[11:05:03] <awight>	 kostajh: I don't remember testing qunit specifically /o\
[11:06:28] <awight>	 The correct URL does get wired into the qunit config.  I wonder...
[11:10:12] <awight>	 Seems like chrome-headless is the first thing to crash, with a "script error"?
[11:14:10] <awight>	 +1 I can reproduce the error locally.
[11:17:06] <awight>	 https://integration.wikimedia.org/ci/job/integration-quibble-apache-fullrun/3/artifact/log/apache-access.log , doesn't this have to be "/w/index.php" in CI?
[11:20:00] <awight>	 Well the regular job has the same line: 10:57:19 INFO:backend.PhpWebserver:[Wed Dec  9 09:57:19 2020] 127.0.0.1:48210 [200]: //index.php?title=Special:JavaScriptTest/qunit/export
[11:38:19] <hasharLunch>	 awight: maybe we are ùissing some env variables
[11:39:11] <hasharLunch>	 or something is off in the apache conf.  Guess one can spawn quibble with -c bash    and then look at Special:JavaScriptTest in a browser
[11:39:17] <hasharLunch>	 maybe it dies with a fatal error
[11:40:15] <awight>	 I'm pretty suspicious of the missing /wiki vs /w distinction, but the browser tests work...
[11:41:34] <awight>	 hasharLunch: Nice tip, thanks!
[11:42:21] <hasharLunch>	 the sscript error might just be chromium <script> loading an empty page
[11:43:30] <hasharLunch>	 https://phabricator.wikimedia.org/search/query/dVNc_EE3PX_P/#R has plenty of hits
[11:45:07] <hasharLunch>	 and we are missing the php error log
[12:59:46] <awight>	 The qunit error is just > file_put_contents(/en.l10n.php): failed to open stream
[13:01:22] <awight>	 So it was hashar's first guess, TMPDIR is not set for the server.
[13:04:26] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10Pchelolo) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/647081 - is fixing T269727, which is pretty bad....
[13:04:36] <awight>	 But now I don't understand why the browser tests work.
[13:07:50] <awight>	 well, -e TMPDIR=/tmp was enough to get qunit passing.
[13:17:53] <awight>	 quibble does this during initialization: os.environ['TMPDIR'] = tempfile.gettempdir()
[13:18:14] <awight>	 That will be set in the php standalone server environment
[13:24:38] <wikibugs>	 (03CR) 10Awight: "Works for me, with this one change (inline)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar)
[14:00:56] <wikibugs>	 (03CR) 10DannyS712: [C: 04-1] New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[14:13:25] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap: scap uses unsafe YAML loading of data - https://phabricator.wikimedia.org/T261307 (10Ramtin0071) 05Open→03Resolved a:03Alexia
[14:14:10] <Nikerabbit>	 ^^^
[14:16:18] <DannyS712>	 disabling that account...
[14:16:59] <DannyS712>	 and now cleaning up...
[14:17:18] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap: scap uses unsafe YAML loading of data - https://phabricator.wikimedia.org/T261307 (10DannyS712) 05Resolved→03Open a:05Alexia→03None
[14:22:53] <DannyS712>	 Nikerabbit do you want me to add you to acl*userdisable so you can disable such accounts in the future?
[14:23:37] <wikibugs>	 10Phabricator, 10Tools: Publicly log account bans made using the phab-ban tool - https://phabricator.wikimedia.org/T200856 (10DannyS712) Disabled https://phabricator.wikimedia.org/p/Ramtin0071/ for vandalism
[14:26:21] <Nikerabbit>	 DannyS712: hmm probably not. would be just happy to report if I know what's the best way to do that
[14:35:49] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry)
[14:36:20] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) All done except announcement/notes to the team!
[14:41:58] <liw>	 DannyS712, thank you
[14:50:47] <wikibugs>	 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10akosiaris) >>! In T265893#6672750, @kostajh wrote: >>>! In T265893#6669424, @akosiaris wrot...
[15:10:01] <wikibugs>	 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10akosiaris) >>! In T265893#6672752, @kostajh wrote: >>>! In T265893#6669463, @akosiaris wrot...
[15:24:56] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki Train Development Environment: Change train-dev to notice if the train-dev image isn't there when starting - https://phabricator.wikimedia.org/T269759 (10LarsWirzenius)
[15:33:34] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Operations, 10Release Pipeline, and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10Jdforrester-WMF)
[15:43:20] <wikibugs>	 (03CR) 10Jforrester: "Thanks! But we should add PHP 8.0 now that we're there. ;-)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/628589 (owner: 10Jforrester)
[15:44:07] <wikibugs>	 (03CR) 10Jforrester: [C: 03+1] "Very nice." [integration/config] - 10https://gerrit.wikimedia.org/r/647194 (owner: 10Hashar)
[15:47:29] <wikibugs>	 (03PS4) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509)
[15:47:36] <wikibugs>	 (03CR) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[15:48:55] <wikibugs>	 (03PS3) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertCount [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762)
[15:48:59] <wikibugs>	 (03CR) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertCount (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712)
[15:50:13] <Daimona>	 James_F: Did the script really finish without errors this time? :-O
[15:50:26] <James_F>	 Daimona: Yup, on all wikis.
[15:50:42] <James_F>	 Daimona: I lost track, did you register it to auto-run or do we need to do that in a patch?
[15:50:59] <Daimona>	 You mean in the update.php script?
[15:51:29] <James_F>	 Yeah.
[15:52:18] <Daimona>	 Apparently yes, this time I did add it
[15:53:11] <Daimona>	 Well, guess we'll see what happens in a few week once it's run in production
[15:53:42] <Daimona>	 A day may come when the scripts run with no errors in production, but it is not this day.
[15:55:31] * James_F nods.
[15:56:25] <wikibugs>	 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: wmde / WikibaseCodeSniffer tests fail on master - https://phabricator.wikimedia.org/T250973 (10DannyS712) > Stop using wmde/WikibaseCodeSniffer and instead just use mediawiki/codesniffer directly from upstream Appears to already be in progress at {T26...
[15:57:17] <wikibugs>	 (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287) (owner: 10DannyS712)
[15:58:33] <wikibugs>	 (03PS1) 10Dan Shick: changed Wikibase homepage based on my own recent updates to old & new sites [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271
[15:58:35] <wikibugs>	 (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick)
[16:01:07] <wikibugs>	 (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647286 (https://phabricator.wikimedia.org/T265741) (owner: 10DannyS712)
[16:03:13] <wikibugs>	 (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] changed Wikibase homepage based on my own recent updates to old & new sites (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick)
[16:03:20] <wikibugs>	 (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647287 (https://phabricator.wikimedia.org/T265742) (owner: 10DannyS712)
[16:14:44] <wikibugs>	 10MediaWiki-Codesniffer, 10Patch-For-Review: Disallow multi class property declaration with code sniff - https://phabricator.wikimedia.org/T268287 (10DannyS712) Patch sent given lack of objections
[16:16:19] <wikibugs>	 10MediaWiki-Codesniffer, 10Patch-For-Review: ParenthesesAroundKeywordSniff leaves extraneous whitespace - https://phabricator.wikimedia.org/T265741 (10DannyS712) Patch sent based on changes in task description
[16:17:10] <wikibugs>	 10MediaWiki-Codesniffer, 10Patch-For-Review: PHPUnitAssertEqualsSniff leaves extraneous whitespace - https://phabricator.wikimedia.org/T265742 (10DannyS712) Patch sent based on changes in task description
[16:17:43] <wikibugs>	 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper)
[16:18:22] <wikibugs>	 10MediaWiki-Codesniffer: Suggestion to add rule for sniffing phpDoc ref tags - https://phabricator.wikimedia.org/T208448 (10DannyS712) 05Open→03Declined Should be covered by existing sniffs now, per above
[16:19:41] <wikibugs>	 (03PS8) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674)
[16:21:28] <wikibugs>	 (03PS9) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674)
[16:22:00] <wikibugs>	 (03PS10) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674)
[16:27:16] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[16:27:19] <wikibugs>	 10MediaWiki-Codesniffer: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints - https://phabricator.wikimedia.org/T258925 (10DannyS712) Some thoughts: * `array` types should still have documentation for what it is an array of * unless **all** parameters...
[16:27:22] <wikibugs>	 10MediaWiki-Codesniffer: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints - https://phabricator.wikimedia.org/T258925 (10DannyS712) p:05Triage→03Low
[16:28:45] <wikibugs>	 (03PS24) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958)
[16:29:18] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): New sniff: MediaWiki.PHPUnit.AssertCount (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712)
[16:29:56] <wikibugs>	 (03CR) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[16:30:14] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "A very enthusiastic vote from my side. :-)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287) (owner: 10DannyS712)
[16:30:43] <wikibugs>	 (03PS5) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509)
[16:34:38] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Ok. A test case would be nice, but it might not be that easy to add one, because we usually don't test an individual sniff without the oth" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647287 (https://phabricator.wikimedia.org/T265742) (owner: 10DannyS712)
[16:34:45] <wikibugs>	 (03CR) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertCount (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712)
[16:35:57] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Thanks for the quick update!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712)
[16:37:36] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] New sniff: MediaWiki.PHPUnit.AssertCount (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647070 (https://phabricator.wikimedia.org/T242762) (owner: 10DannyS712)
[16:50:17] <wikibugs>	 (03CR) 10DannyS712: [C: 03+1] Avoid slow strcasecmp() where not necessary [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647205 (owner: 10Thiemo Kreuz (WMDE))
[17:09:20] <wikibugs>	 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) @akosiaris my preference is to use the existing workflow on stats machines to auto...
[17:26:08] <wikibugs>	 (03PS3) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597)
[17:27:00] <wikibugs>	 10Release-Engineering-Team-TODO, 10WVUI, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10nnikkhoui) Cool thanks for the input guys! I've filed an issue upstream. I'm not sure about using `blocknote`, im giving it a...
[17:27:13] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[17:31:00] <wikibugs>	 (03PS4) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597)
[17:38:36] <wikibugs>	 (03PS5) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597)
[17:46:29] <wikibugs>	 10Continuous-Integration-Config: composer-package-php72-docker runs with xdebug enabled - https://phabricator.wikimedia.org/T269489 (10Daimona) An interesting side effect of this: phan restarts itself if xdebug is enabled, but in doing so, it seems to pick PHP 7.3 in the php74 image, see https://integration.wiki...
[17:50:09] <wikibugs>	 (03CR) 10BryanDavis: builder: support cross variant copying for builder.requirements (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[18:12:05] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Icinga downtime for 4:00:00 set by dzahn@cumin1001 on 1 h...
[18:19:18] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin100...
[18:51:49] <wikibugs>	 (03CR) 10Umherirrender: Enable `PSR2.Classes.PropertyDeclaration.Multiple` (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287) (owner: 10DannyS712)
[18:53:12] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+1] Add more tags to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712)
[19:03:03] <wikibugs>	 (03PS3) 10DannyS712: Enable `PSR2.Classes.PropertyDeclaration.Multiple` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287)
[19:03:22] <wikibugs>	 (03CR) 10DannyS712: Enable `PSR2.Classes.PropertyDeclaration.Multiple` (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287) (owner: 10DannyS712)
[19:07:09] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+1] Enable `PSR2.Classes.PropertyDeclaration.Multiple` (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647085 (https://phabricator.wikimedia.org/T268287) (owner: 10DannyS712)
[19:12:17] <wikibugs>	 (03CR) 10Umherirrender: [C: 03+1] "I always like it when sniffs understand every legal syntax which describe/acts the same, but for the is_null sniff there is also no case-i" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647205 (owner: 10Thiemo Kreuz (WMDE))
[19:25:17] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2243.codfw.wmnet']...
[19:29:18] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Math, and 3 others: Move math related repositories from GitHub(?) to gerrit - https://phabricator.wikimedia.org/T249908 (10hashar) 05Open→03Resolved I think...
[19:29:47] <wikibugs>	 10Continuous-Integration-Config: composer-package-php74-docker actually runs PHP 7.3 - https://phabricator.wikimedia.org/T269790 (10Daimona)
[19:30:36] <wikibugs>	 10Continuous-Integration-Config: composer-package-php74-docker actually runs PHP 7.3 - https://phabricator.wikimedia.org/T269790 (10Daimona) p:05Triage→03High Boldly triaging as high, this might be problematic.
[19:34:58] <wikibugs>	 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services): composer-package-php74-docker actually runs PHP 7.3 - https://phabricator.wikimedia.org/T269790 (10hashar) a:03hashar Indeed, the image inherits from the php73 one: `name=dockerfiles/composer-package-php74/Dockerfile.templat...
[19:37:33] <wikibugs>	 (03PS1) 10Hashar: dockerfiles: use proper php in composer-package-php74 [integration/config] - 10https://gerrit.wikimedia.org/r/647343 (https://phabricator.wikimedia.org/T269790)
[19:38:22] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10Pchelolo)
[19:38:32] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-Parser, 10MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), 10Platform Team Workboards (Green), 10Regression: Old revision warning box is added twice on page view if old rev served from cache - https://phabricator.wikimedia.org/T269727 (...
[19:40:24] <wikibugs>	 (03PS1) 10Hashar: jjb: switch composer-package jobs to actually use php74 [integration/config] - 10https://gerrit.wikimedia.org/r/647346 (https://phabricator.wikimedia.org/T269790)
[19:47:15] <wikibugs>	 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-Graph, 10Wikimedia-production-error: TypeError: field is not a function. (In 'field(g[i])', 'field' is undefined) in partition - https://phabricator.wikimedia.org/T269694 (10Krinkle)
[19:47:50] <legoktm>	 heh
[19:48:02] <legoktm>	 we used to have that jjb macro that would test that php --version actually returned the version we wanted
[19:51:05] <hashar>	 legoktm: yeah from when we add multiple php installed and relied on PHP_BIN , but that is no more the case there
[19:51:17] <hashar>	 I thought about adding a buildtime RUN php --version | check command
[19:51:31] <hashar>	 but in this case I guess the check would have been copied as is and still would have looked for php73
[19:51:53] <hashar>	 typos typos :-\
[19:52:05] <wikibugs>	 10Release-Engineering-Team (Logspam), 10MassMessage, 10MediaWiki-ContentHandler, 10MediaWiki-Page-editing, and 2 others: ParameterTypeException when `diff`ing invalid MassMessageListContent - https://phabricator.wikimedia.org/T269403 (10Krinkle)
[19:53:41] <legoktm>	 indeed :p
[19:54:13] <legoktm>	 just running php --version in run.sh would be helpful though
[20:03:00] <hashar>	 possibly yeah.  Anyway I am off to dinner and bed. It has been a long day
[20:26:59] <wikibugs>	 (03CR) 10Dduvall: "I'm really excited about this feature. I have some concerns about the current implementation's behavior and efficiency. Comments inline." (038 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[20:27:10] <wikibugs>	 (03CR) 10Dduvall: [C: 04-1] builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[20:44:58] <wikibugs>	 10MediaWiki-Codesniffer: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints - https://phabricator.wikimedia.org/T258925 (10Tgr) >>! In T258925#6679731, @DannyS712 wrote: > `array` types should still have documentation for what it is an array of  We ac...
[21:01:33] <wikibugs>	 10Release-Engineering-Team, 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10Tgr) Maybe the service could just regularly query the datasets and compare them to local on...
[21:07:38] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10LucasWerkmeister) Not sure if it’s serious enough to be a train blocker but this seems to be a visual regress...
[21:10:35] <wikibugs>	 (03CR) 10BryanDavis: [C: 04-1] "I'll start working on fixups. :)" (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)
[21:27:26] <wikibugs>	 10Gerrit: Evaluate Gerrit's zuul-results-summary plugin - https://phabricator.wikimedia.org/T269803 (10QChris)
[21:28:07] <wikibugs>	 10Gerrit: Evaluate Gerrit's zuul-results-summary plugin - https://phabricator.wikimedia.org/T269803 (10QChris) Not sure if we want to have that plugin or even look into it. I guess with the GitLab switch on the horizon, the answer is a “No”.  (But the post on the repo-discuss mailing list looked innocent enough...
[21:28:26] <wikibugs>	 10MediaWiki-Codesniffer: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints - https://phabricator.wikimedia.org/T258925 (10DannyS712) >>! In T258925#6680511, @Tgr wrote: >>>! In T258925#6679731, @DannyS712 wrote: >> `array` types should still have doc...
[21:48:00] <wikibugs>	 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10thcipriani)
[22:01:55] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin100...
[22:15:02] <wikibugs>	 (03CR) 10Jeena Huneidi: "Haven't tested yet but it looks good to me. I'm wondering if it's worth it to edit the systemtests to include this." (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall)
[22:16:55] <wikibugs>	 (03PS1) 10QChris: Allow “Gerrit Managers” to import history [wikimedia-it/wordpress-betheme-child-theme-for-wmit] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647368
[22:16:57] <wikibugs>	 (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [wikimedia-it/wordpress-betheme-child-theme-for-wmit] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647368 (owner: 10QChris)
[22:18:07] <wikibugs>	 (03PS1) 10QChris: Import done. Revoke import grants [wikimedia-it/wordpress-betheme-child-theme-for-wmit] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647370
[22:18:09] <wikibugs>	 (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [wikimedia-it/wordpress-betheme-child-theme-for-wmit] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647370 (owner: 10QChris)
[22:49:06] <wikibugs>	 10Phabricator, 10Patch-For-Review: Allow video embeds in formats other than OGV (e.g. WEBM) - https://phabricator.wikimedia.org/T215360 (10Dzahn) config change has been applied in prod by puppet.  please confirm?:)
[23:11:18] <wikibugs>	 10Phabricator: Allow video embeds in formats other than OGV (e.g. WEBM) - https://phabricator.wikimedia.org/T215360 (10Dzahn) @matmarex @mmodell Looks like webm gets embedded now in the ticket description :)
[23:13:00] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2243.codfw.wmnet']...
[23:15:43] <wikibugs>	 10Phabricator: Allow video embeds in formats other than OGV (e.g. WEBM) - https://phabricator.wikimedia.org/T215360 (10matmarex) Thanks!
[23:16:25] <wikibugs>	 10Phabricator: Allow video embeds in formats other than OGV (e.g. WEBM) - https://phabricator.wikimedia.org/T215360 (10mmodell) 05Open→03Resolved awesome!
[23:20:45] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn)
[23:24:42] <wikibugs>	 (03CR) 10Daimona Eaytoy: [C: 03+1] dockerfiles: use proper php in composer-package-php74 [integration/config] - 10https://gerrit.wikimedia.org/r/647343 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar)
[23:24:57] <wikibugs>	 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) >>! In T245757#6645352, @jijiki wrote: > @Dzahn @hnowlan After discuss...
[23:28:18] <wikibugs>	 10Phabricator, 10I18n, 10Patch-For-Review: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10mmodell) The phabricator translation infrastructure was not built with much understanding of how translatewik...
[23:34:18] <wikibugs>	 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10mmodell)
[23:53:54] <wikibugs>	 (03CR) 10Dduvall: [C: 04-1] builder: support cross variant copying for builder.requirements (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)