[00:01:37] (03CR) 10Dduvall: "I'll implement a system test!" (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall) [00:13:00] (03PS6) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [00:17:21] 10phan-taint-check-plugin: Investigate running taint-check with analyze-twice - https://phabricator.wikimedia.org/T269816 (10Daimona) [00:22:22] (03CR) 10BryanDavis: [C: 04-1] "I have some more bits to update based on the feedback on PS5, but I wanted to get this up so that Dan can take a look at the bits I have d" (035 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [00:41:51] (03CR) 10Jeena Huneidi: Allow user-defined build context and excludes (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall) [00:46:26] (03CR) 10BryanDavis: [C: 04-1] builder: support cross variant copying for builder.requirements (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [04:18:04] 10Release-Engineering-Team, 10MediaWiki-extensions-OAuth, 10Platform Team Workboards (Clinic Duty Team), 10ci-test-error (WMF-deployed Build Failure): Invalid timestamp/Failed asserting that $timestamp1 is identical to $timestamp2 - https://phabricator.wikimedia.org/T269502 (10tstarling) Setting the expiry... [04:33:28] (03PS7) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [04:34:26] (03CR) 10jerkins-bot: [V: 04-1] builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [04:40:46] (03CR) 10BryanDavis: "Ugh. The test failure is because I used a golang 1.13 library feature. I will amend with something that works in older versions of golang." (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [04:43:53] (03PS8) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [05:30:37] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10KartikMistry) [07:44:40] (03PS1) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [07:44:42] (03PS1) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [07:48:02] (03CR) 10jerkins-bot: [V: 04-1] Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 (owner: 10Gergő Tisza) [07:48:05] (03CR) 10jerkins-bot: [V: 04-1] Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [08:03:39] (03PS2) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [08:03:41] (03PS2) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [08:07:35] (03CR) 10jerkins-bot: [V: 04-1] Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [08:07:50] (03CR) 10jerkins-bot: [V: 04-1] Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 (owner: 10Gergő Tisza) [08:24:51] (03CR) 10Kosta Harlan: Add Gerrit report format (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [08:36:55] (03CR) 10Gergő Tisza: Add Gerrit report format (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [08:44:40] (03PS3) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [08:44:42] (03PS3) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [08:47:49] (03CR) 10jerkins-bot: [V: 04-1] Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 (owner: 10Gergő Tisza) [08:47:57] (03CR) 10jerkins-bot: [V: 04-1] Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [08:54:14] :ooo [09:03:27] (03PS4) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [09:03:29] (03PS4) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [09:06:52] (03CR) 10jerkins-bot: [V: 04-1] Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [09:07:31] (03CR) 10jerkins-bot: [V: 04-1] Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 (owner: 10Gergő Tisza) [09:25:38] (03CR) 10Legoktm: "> Patch Set 1: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/644367 (owner: 10Legoktm) [09:28:17] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10Lucas_Werkmeister_WMDE) [09:43:05] hashar: I found the glitch, and left a comment on your jjb config... [09:45:47] awight: great! :] [09:50:54] awight: I messed a bit with it yesterday but my local setup was screwed up [09:51:22] eventually I got the quibble-apache container running locally only to have it fail cause it comes with Quibble 0.0.45 . After that I gave up since I had call all the evening [09:52:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Create a runbook for switching CI master - https://phabricator.wikimedia.org/T256396 (10hashar) [09:55:00] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Create a runbook for switching CI master - https://phabricator.wikimedia.org/T256396 (10hashar) Tyler bootstrapped https://www.mediawiki.org/wiki/Continuous_integration/Data_center_switch and I have edited... [10:00:46] hashar: ooh yeah, that's right. You'll have to build a local quibble-stretch base image hacked to use quibble's master branch. [10:06:20] (03CR) 10Hashar: [C: 03+2] "I was too late for me to handle the build / job refresh yesterday night :)" [integration/config] - 10https://gerrit.wikimedia.org/r/647343 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar) [10:07:44] (03Merged) 10jenkins-bot: dockerfiles: use proper php in composer-package-php74 [integration/config] - 10https://gerrit.wikimedia.org/r/647343 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar) [10:10:03] awight: I have found your comment. Any idea why TMPDIR is required or why lack of it causes the qunit export to fail? [10:10:13] yes [10:10:38] hashar: It's because of a custom line quibble includes in LocalSettings.php [10:10:45] stupid quibble [10:10:52] :joy: [10:11:10] quibble/cmd.py: os.environ['TMPDIR'] = tempfile.gettempdir() [10:11:10] quibble/mediawiki/local_settings.php:$wgCacheDirectory = getenv( 'TMPDIR' ); [10:11:24] OH [10:11:28] exactly, you beat me to it :-) [10:11:29] yeah I got it now [10:11:35] so the idea is that [10:11:46] python tempfile.gettempdir does grab the config all properly [10:12:06] I mean, the python function lookups well known env variable and eventually fallback to a "sane" /tmp [10:12:23] but our php files directly lookup TMPDIR and does not benefit from the python magic [10:13:02] Yeah I guess my suggestion introduces some tech debt by creating two diferent code paths for how to find a temp dir. [10:13:06] so maybe we can replace that getenv( 'TMPDIR' ) and have Quibble to emit the actual path it looked up [10:13:37] hmm. yes [10:13:41] that's a great idea [10:14:10] I was thinking that apache needs to "know" at container start time, but this is all internal to Mediawiki, so yeah we have control. [10:14:38] hashar: I'll write that patch, one moment please... [10:15:10] hmm we might have the same problem with MW_LOG_DIR and WORKSPACE. [10:15:17] (03CR) 10Hashar: [C: 03+2] "Jobs updated:" [integration/config] - 10https://gerrit.wikimedia.org/r/647346 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar) [10:15:23] and MW_INSTALL_PATH [10:16:44] (03Merged) 10jenkins-bot: jjb: switch composer-package jobs to actually use php74 [integration/config] - 10https://gerrit.wikimedia.org/r/647346 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar) [10:18:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Patch-For-Review: composer-package-php74-docker actually runs PHP 7.3 - https://phabricator.wikimedia.org/T269790 (10hashar) 05Open→03Resolved Done. That was caused by a typo, the php74 based image inherited from `php7... [10:18:14] awight: possibly yeah [10:18:44] at least you found the root cause (lack of TMPDIR) which is like 80% of the job done! [10:18:50] 10Release-Engineering-Team-TODO, 10WVUI, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Upstream, 10Vue.js: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10Aklapper) [10:21:03] awight: I don't think MW_LOG_DIR and WORKSPACE are an issue [10:21:18] (03CR) 10Hashar: Quibble full run with Apache (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar) [10:22:00] hmm or maybe they are bah [10:22:39] looks like we would need a bunch of refactoring :-\ [10:23:00] I'm noticing the same thing... [10:23:56] They all derive from WORKSPACE, though. [10:24:21] We could just let docker pass that one environment variable through, then everything else is calculated. [10:24:47] (ah not TMPDIR) [10:25:49] Is there a use case for --log-dir, btw? [10:33:53] (never mind) [10:35:16] ouch: includes/libs/filebackend/fsfile/TempFSFile.php: $tmpDir = array_map( 'getenv', [ 'TMPDIR', 'TMP', 'TEMP' ] ); [10:36:56] ;D [10:37:26] --log-dir well hmm it is a bit of cumbersome [10:37:58] the idea I think is that when running locally it is ./log and on docker it is /log [10:38:08] I was looking for fat to trim, but it's beside the point. Fine like it is. [10:38:43] I guess we should get Quibble to determine the variables and output the local_settings.php hardcoding all the settings [10:38:57] instead of having some magic lookups and conditionals in local_settings.php [10:39:10] as you pointed out, it works fine with the php built in server when it is spawned by quibble [10:39:18] and would work if Apache was spawned by quibble [10:39:27] +1 I'm writing a gross patch now [10:39:33] I guess that is the limitation of using env variable [10:39:41] they are great but can end up being annoying [10:39:53] I am about to escape for lunch with kids, will catch up in a couple hours [10:39:56] one sure thing [10:40:01] you found the root cause and that is great! [10:40:05] o/ :-) [10:40:59] hopefully we get the apache full run job running, polish up a bit the container / quibble code, get bandit checker in and we can cut a new release next week for christmas :] [10:41:17] s/christmas/end of year holidays/ [10:46:50] (03CR) 10Hashar: "I like the https://wikiba.se/ portal. Then it is up to Wikibase owner to determine which landing page should be pointed at when ones brows" (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [10:47:14] kids duty! [10:58:19] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10MoritzMuehlenhoff) >>! In T245757#6680909, @Dzahn wrote: >>>! In T245757#6645... [11:01:06] 10Release-Engineering-Team (Logspam), 10MassMessage, 10MediaWiki-ContentHandler, 10MediaWiki-Page-editing, and 2 others: ParameterTypeException when `diff`ing invalid MassMessageListContent - https://phabricator.wikimedia.org/T269403 (10Legoktm) ` 15:52:35 that bug looks like EditPage is not che... [11:06:59] (03CR) 10Dan Shick: "> Patch Set 1:" (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [11:31:29] 10Release-Engineering-Team-TODO, 10User-DannyS712, 10ci-test-error: Scap plugins in operations/mediawiki-config don't pass tox, so CI is disabled - https://phabricator.wikimedia.org/T248040 (10LarsWirzenius) [11:31:34] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Wikimedia-Site-requests: Move scap plugins from mediawiki-config repo to scap repo - https://phabricator.wikimedia.org/T248490 (10LarsWirzenius) 05Open→03Resolved Done earlier this week. [11:46:10] (03PS1) 10Lucas Werkmeister (WMDE): Use Special:MyLanguage for all links to wikis [integration/docroot] - 10https://gerrit.wikimedia.org/r/647669 [11:46:35] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] changed Wikibase homepage based on my own recent updates to old & new sites (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [12:24:02] hashar*Lunch: I tried the "safe" way and it's really ugly: if getenv then putenv for each parameter. But I (surprisingly?) prefer the crazy rewrite way, getting rid of all the fallback logic in quibble/mediawiki/local_settings.php . [12:25:23] That file is rewritten on every install, so should be valid for the lifetime of the container / local script run. Nothing needs to be calculated at runtime, or am I missing something? [12:27:34] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) To clarify what I'm proposing: > Then, a request from stats machine to... [12:32:38] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10Lucas_Werkmeister_WMDE) [12:34:15] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6669424, @akosiaris wrote: > @kostajh, @MGerlach I 've... [12:44:31] (03CR) 10Awight: [C: 03+1] "This patch itself is good, but depends on one more tweak to Quibble, handling TMPDIR internally." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar) [12:47:35] 10Phabricator: Allow others than admins to edit forms - https://phabricator.wikimedia.org/T181031 (10MarcoAurelio) >>! In T181031#6673833, @epriestley wrote: > I'm happy to take a look at this if someone with access has a chance to figure out where it isn't working on your end -- my expectation is that it's supp... [13:22:52] (03PS1) 10Awight: Installer hardcodes paths [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) [13:23:06] (03CR) 10Awight: [C: 03+1] "See I16a6bfb0dc7bffab5777b16b4a70dc7543b9902b" [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar) [13:27:07] (03CR) 10jerkins-bot: [V: 04-1] Installer hardcodes paths [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [13:29:31] (03CR) 10Awight: Installer hardcodes paths (034 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [13:30:29] (03PS2) 10Awight: Installer hardcodes paths [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) [13:41:17] (03CR) 10Awight: "check experimental" [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [13:51:02] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10akosiaris) >>! In T265893#6681979, @kostajh wrote: >>>! In T265893#6669424, @ako... [13:54:46] hasharLunch: I guess I can't set off an experimental quibble build yet? [13:55:01] ... ah I'll rebuild the job in the Jenkins UI. [14:02:24] awight: yeah I have deployed the job but not the zuul config part [14:04:24] hashar: Well if it's easy, I have a quibble patch to run against that job... I tried to figure out the ZUUL_* magic and failed. [14:06:11] the ZUUL_ env variable are just for cloning / fetching / checkout the git repos patches [14:08:14] right, I was hoping to rebuild the experimental job to try it against my quibble fix. But couldn't get the jenkins build parameters. [14:09:00] ah [14:09:12] so on the job page https://integration.wikimedia.org/ci/job/integration-quibble-apache-fullrun/ [14:09:19] use "Build with parameters" [14:09:43] +1 following so far [14:10:02] You can see my last attempt here, https://integration.wikimedia.org/ci/view/CI/job/integration-quibble-apache-fullrun/7/console [14:10:07] then file in: ZUUL_URL: https://gerrit.wikimedia.org/r ZUUL_PROJET: integration/quibble ZUUL_REF: /refs/changes/YY/XXXXYY ZUUL_BRANCH: master [14:10:31] which would fetch the change directly from gerrit [14:10:35] instead of the zuul merger [14:11:12] 00:00:05.988 fatal: remote error: access denied or repository not exported: /integration/quibble/integration/quibble ;) [14:11:18] I tried that in https://integration.wikimedia.org/ci/view/CI/job/integration-quibble-apache-fullrun/5/console [14:11:24] 14:56:59 + git fetch --quiet --update-head-ok --depth 2 https://gerrit.wikimedia.org/r/integration/quibble +refs/zuul/master/Z025e19e491d7452a9c611d053d60b806:refs/zuul/master/Z025e19e491d7452a9c611d053d60b806 [14:11:28] 14:56:59 fatal: Couldn't find remote ref refs/zuul/master/Z025e19e491d7452a9c611d053d60b806 [14:11:45] it fetches from ${ZUUL_URL}/${ZUUL_PROJECT}" [14:12:07] and those refs/zuul/.... references are only on the zuul-merger process [14:12:36] which would point to a merge commit of your change against the tip of branch. That is volalite / keeps changing so that is never send to Gerrit itself [14:12:46] <_< [14:12:59] Thank you, makes sense! [14:13:02] Lemme try this again. [14:14:11] 10Continuous-Integration-Config, 10Code-Health, 10Discovery-Search (Current work), 10Patch-For-Review: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 (10Gehel) [14:14:13] grr > A change ref has the format refs/changes/X/Y/Z where X is the last two digits of the change number, Y is the entire change number, and Z is the patch set. [14:14:39] my bad sorry ;D [14:15:09] Great, it's running now :-) [14:17:38] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Hosting wikibase release tarballs on releases.wikimedia.org - https://phabricator.wikimedia.org/T268345 (10thcipriani) p:05Triage→03Medium [14:18:50] 15:18:38 [0-0] PASSED in chrome - /tests/selenium/wdio-mediawiki/specs/BlankPage.js [14:19:12] * awight weeps with happiness [14:26:57] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10akosiaris) >>! In T265893#6681943, @kostajh wrote: > To clarify what I'm proposi... [14:27:07] (03CR) 10Hashar: [C: 03+2] "It might break something eventually but I can't find what. Guess we will figure it out if that happens ;)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [14:29:39] awight: seems like the job with quibble-apachec ontainer is fine and we can get it deployed? This way we can just check experimental [14:33:30] hashar: Sounds perfect to me. There was still a test failure, but seems limited rather than systematic. [14:34:14] (03CR) 10Hashar: "There are a few thing we should check regarding postre and how xvfb is run. Nice find!" (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [14:34:22] deploying the job so [14:35:45] (03CR) 10Hashar: [C: 03+2] "After discussion with Adam, TMPDIR will be set from Quibble. The job will fail until we enhance Quibble with all the prerequisite but th" [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar) [14:37:14] (03Merged) 10jenkins-bot: Quibble full run with Apache [integration/config] - 10https://gerrit.wikimedia.org/r/647199 (https://phabricator.wikimedia.org/T225218) (owner: 10Hashar) [14:38:27] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Hosting wikibase release tarballs on releases.wikimedia.org - https://phabricator.wikimedia.org/T268345 (10jbond) [14:38:42] awight: deployed! [14:45:42] The logs look good, https://integration.wikimedia.org/ci/job/integration-quibble-apache-fullrun/8/artifact/log/apache-access.log [14:46:22] Exciting mw-error log that might explain the test failure, > Error 1213: Deadlock found when trying to get lock; try restarting transaction [14:46:46] nit [14:46:48] nice [14:46:58] though we are missing the php-fpm ones :] [14:49:07] hashar: (taking note!) [14:51:38] (03Merged) 10jenkins-bot: Installer hardcodes paths [integration/quibble] - 10https://gerrit.wikimedia.org/r/647704 (https://phabricator.wikimedia.org/T225218) (owner: 10Awight) [15:21:24] (03CR) 10Hashar: [C: 04-1] "I will split the postgres part in a different change and fix it up and rebase your change on top of it." (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [15:21:31] kids time bis [15:56:38] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) >>! In T245757#6681662, @MoritzMuehlenhoff wrote: > ffmpeg -i Wall_of... [15:57:27] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) [16:04:22] (03CR) 10Awight: "> I will split the postgres part in a different change and fix it up and rebase your change on top of it." [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [16:32:27] (03CR) 10Awight: Subprocess argument fixes (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [16:35:09] (03CR) 10Dduvall: Allow user-defined build context and excludes (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall) [17:01:23] (03PS9) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [17:08:28] (03PS10) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [17:10:31] (03CR) 10BryanDavis: "I think I have addressed all of your feedback Dan. Take a look and see if you agree or if you can see some more things that might need twe" (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [17:25:34] (03CR) 10Jforrester: "Oops, thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/647343 (https://phabricator.wikimedia.org/T269790) (owner: 10Hashar) [17:37:41] (03PS11) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [17:48:53] (03PS12) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [17:58:55] (03PS2) 10Dduvall: Allow user-defined build context and excludes [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 [18:04:15] (03PS1) 10Hashar: Enhance options passing for pg_virtualenv [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 [18:05:04] (03CR) 10Hashar: [C: 04-1] Subprocess argument fixes (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [18:05:28] (03PS13) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [18:05:30] (03PS1) 10BryanDavis: Fix Makefile syntax for running linter & legacy errors [blubber] - 10https://gerrit.wikimedia.org/r/647755 [18:09:08] (03PS2) 10Hashar: Fix Xvfb arguments [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [18:14:36] (03PS5) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [18:14:38] (03PS5) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [18:18:16] (03CR) 10jerkins-bot: [V: 04-1] Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10Gergő Tisza) [18:18:51] (03CR) 10jerkins-bot: [V: 04-1] Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 (owner: 10Gergő Tisza) [18:19:41] (03PS12) 10Hashar: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [18:49:46] (03CR) 10Awight: [C: 03+2] "Thanks for the thorough follow-up!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [18:52:58] (03CR) 10Awight: [C: 03+2] Enhance options passing for pg_virtualenv (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 (owner: 10Hashar) [18:55:40] (03PS6) 10Gergő Tisza: Add Gerrit report format [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 [18:55:42] (03PS6) 10Gergő Tisza: Add fix reporting to Gerrit robot comment reporter [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647595 [18:55:44] (03CR) 10Zoranzoki21: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/647634 (owner: 10Zoranzoki21) [18:56:09] (03PS3) 10Zoranzoki21: Add UploadWizard as dependency of the EncryptedUploads extension [integration/config] - 10https://gerrit.wikimedia.org/r/647634 [18:56:11] awight: ;] [19:00:53] (03CR) 10Zoranzoki21: "This should resolve failing tests https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EncryptedUploads/+/644025" [integration/config] - 10https://gerrit.wikimedia.org/r/647634 (owner: 10Zoranzoki21) [19:01:19] (03CR) 10Hashar: [C: 03+2] Add UploadWizard as dependency of the EncryptedUploads extension [integration/config] - 10https://gerrit.wikimedia.org/r/647634 (owner: 10Zoranzoki21) [19:03:09] (03Merged) 10jenkins-bot: Add UploadWizard as dependency of the EncryptedUploads extension [integration/config] - 10https://gerrit.wikimedia.org/r/647634 (owner: 10Zoranzoki21) [19:11:39] (03CR) 10Awight: [C: 04-1] "Something's broken here, the linter isn't actually doing anything:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [19:14:15] (03CR) 10Awight: [C: 03+2] Enhance options passing for pg_virtualenv (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 (owner: 10Hashar) [19:21:49] (03Merged) 10jenkins-bot: Enhance options passing for pg_virtualenv [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 (owner: 10Hashar) [19:21:51] (03Merged) 10jenkins-bot: Fix Xvfb arguments [integration/quibble] - 10https://gerrit.wikimedia.org/r/647206 (owner: 10Awight) [19:26:02] (03CR) 10Awight: [C: 04-1] Reformat files with black (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [19:30:18] (03CR) 10Hashar: "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/647634 (owner: 10Zoranzoki21) [19:30:28] (03PS13) 10Awight: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [19:33:11] (03CR) 10Awight: [C: 03+1] "Looks like it's running now. PS 13 adds the "# fmt: off" directives." [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [19:34:31] (03PS1) 10Hashar: shared: clear out proper env variable in test [integration/docroot] - 10https://gerrit.wikimedia.org/r/647767 [19:54:52] (03CR) 10Dduvall: [C: 04-1] "It's looking very close to +2-able. I have some questions about the need for the sentinel value." (035 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [19:56:23] (03CR) 10Dduvall: [C: 04-1] builder: support cross variant copying for builder.requirements (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [20:03:19] (03CR) 10jerkins-bot: [V: 04-1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [20:06:57] Krinkle: Think it's OK for me to cut a less.php release? [20:21:20] James_F: I think so. Let me know if you need anything [20:21:37] (03CR) 10Ahmon Dancy: [C: 03+1] chore: format all code with Black, require it in the future [tools/scap] - 10https://gerrit.wikimedia.org/r/646991 (owner: 10Lars Wirzenius) [20:24:13] (03CR) 10Hashar: [C: 03+2] changed Wikibase homepage based on my own recent updates to old & new sites (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [20:25:29] (03Merged) 10jenkins-bot: changed Wikibase homepage based on my own recent updates to old & new sites [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [20:29:55] (03CR) 10Hashar: "Deployed and I have purged https://doc.wikimedia.org/ from the frontend caches :]" [integration/docroot] - 10https://gerrit.wikimedia.org/r/647271 (owner: 10Dan Shick) [20:31:11] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10kostajh) >>! In T265893#6682244, @akosiaris wrote: >>>! In T265893#6681943, @kos... [20:33:20] (03CR) 10Hashar: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [20:37:31] (03CR) 10Hashar: Enhance options passing for pg_virtualenv (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 (owner: 10Hashar) [20:45:32] 10phan-taint-check-plugin: Investigate running taint-check with analyze-twice - https://phabricator.wikimedia.org/T269816 (10Umherirrender) the taint-check slows down phan a bit, I am not sure how much it is for twice analyze `analyze-twice` is CLI only and cannot be set in the config (okay, you can set `__anal... [20:56:56] 10phan-taint-check-plugin: taint-check: Handle PassByRefs before calling this method - https://phabricator.wikimedia.org/T269888 (10Umherirrender) [20:59:22] 10phan-taint-check-plugin: taint-check: Unexpected argument count for SecurityCheck-LikelyFalsePositive warning from analye phase - https://phabricator.wikimedia.org/T269890 (10Umherirrender) [21:36:36] 10Phabricator: Phabricator keeps displaying my account as a "shadow" member of milestones after leaving parent project - https://phabricator.wikimedia.org/T269893 (10MarcoAurelio) [21:40:05] 10Phabricator: Phabricator keeps displaying my account as a "shadow" member of milestones after leaving parent project - https://phabricator.wikimedia.org/T269893 (10mmodell) Membership in a project is stored in phabricator using the "edges" schema which involves storing two records for each membership. One rec... [21:45:34] (03CR) 10Jeena Huneidi: [C: 03+2] "LGTM!" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall) [21:46:43] (03Merged) 10jenkins-bot: Allow user-defined build context and excludes [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/647058 (owner: 10Dduvall) [21:56:12] 10Phabricator (Upstream), 10Upstream: It's not possible to remove oneself from Phabricator project milestone - https://phabricator.wikimedia.org/T261642 (10mmodell) [21:56:14] 10Phabricator: Phabricator keeps displaying my account as a "shadow" member of milestones after leaving parent project - https://phabricator.wikimedia.org/T269893 (10mmodell) [22:00:27] 10Release-Engineering-Team-TODO, 10WVUI, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Upstream, 10Vue.js: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10nnikkhoui) @thcipriani what do you think about enabling `markdown.namedanchors` [[ https://gerrit.googlesource.c... [22:07:47] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Experiment with marge-bot on gitlab-test - https://phabricator.wikimedia.org/T262619 (10thcipriani) 05Open→03Resolved Deployed marge bot, shows... [22:08:43] (03CR) 10Awight: Enhance options passing for pg_virtualenv (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/647754 (owner: 10Hashar) [22:09:04] 10Release-Engineering-Team (CI & Testing services), 10GitLab, 10GitLab-Test, 10User-brennen: Proof of concept for cross-repo dependencies - https://phabricator.wikimedia.org/T262618 (10thcipriani) p:05Triage→03Low a:05brennen→03None [22:10:19] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10GitLab, 10GitLab-Test, 10User-brennen: Document GitLab code review workflows - https://phabricator.wikimedia.org/T263668 (10brennen) 05Open→03Resolved More work to be done, but this is off to a start that will likely become self-sustain... [22:12:53] 10phan-taint-check-plugin: False positives with methods taking string|Message - https://phabricator.wikimedia.org/T269895 (10Daimona) [22:34:14] 10phan-taint-check-plugin: Investigate running taint-check with analyze-twice - https://phabricator.wikimedia.org/T269816 (10Daimona) >>! In T269816#6683486, @Umherirrender wrote: > the taint-check slows down phan a bit, I am not sure how much it is for twice analyze I do expect a slowdown, but I think it's als... [22:41:36] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T264801 (10mmodell) [22:46:42] 10phan-taint-check-plugin, 10Patch-For-Review: taint-check: Handle PassByRefs before calling this method - https://phabricator.wikimedia.org/T269888 (10Daimona) a:03Daimona [23:03:45] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Better way to restrict credentials available to pipelinelib - https://phabricator.wikimedia.org/T267699 (10jeena) We've decided to take multiple steps to restrict credentials usage in Jenkins: # Create a whitelist of credentials for usage in test pi... [23:04:56] 10LibUp: Update libup's canary repositories list - https://phabricator.wikimedia.org/T269899 (10Legoktm) [23:07:28] 10phan-taint-check-plugin, 10Patch-For-Review: taint-check: Unexpected argument count for SecurityCheck-LikelyFalsePositive warning from analye phase - https://phabricator.wikimedia.org/T269890 (10Daimona) a:03Daimona [23:09:29] 10LibUp: Update libup's canary repositories list - https://phabricator.wikimedia.org/T269899 (10Daimona) If you add AbuseFilter, I should be able to react to any issue quite quickly (hopefully). [23:25:39] (03CR) 10Dduvall: [C: 03+2] "Oy! Thanks for finding this." [blubber] - 10https://gerrit.wikimedia.org/r/647755 (owner: 10BryanDavis) [23:28:07] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Pass allowed credentials parameters to pipeline builder via jjb job templates - https://phabricator.wikimedia.org/T269900 (10jeena) [23:29:15] (03Merged) 10jenkins-bot: Fix Makefile syntax for running linter & legacy errors [blubber] - 10https://gerrit.wikimedia.org/r/647755 (owner: 10BryanDavis) [23:29:58] (03PS14) 10BryanDavis: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) [23:36:05] (03CR) 10BryanDavis: builder: support cross variant copying for builder.requirements (036 comments) [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [23:37:51] marxarelli: I was cursing you after your last round of feedback, but I think I managed to rip out a lot of code as a result of staring at it a bit longer. :) [23:40:13] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Allow overrides to pipeline builder for passing allowed credentials list - https://phabricator.wikimedia.org/T269902 (10jeena) [23:40:29] 10phan-taint-check-plugin: False positives due to arraay keys and values being mixed together - https://phabricator.wikimedia.org/T269903 (10Daimona) [23:43:34] bd808: haha. i'll take a look [23:45:33] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Release Pipeline, 10WVUI, 10Vue.js (Vue.js-Search): Add ability to use ssh-key credentials in pipelinelib pipelines - https://phabricator.wikimedia.org/T267702 (10jeena) [23:45:55] bd808: btw, the reason i'm being picky about your patch is that i think we can build off it to simplify the other builders (python/node) :) [23:46:17] yeah, I kind of thought that would a logical follow up :) [23:50:42] bd808: gah. running into a validation error when i omit destination. i do think we need to remove the requiredwith validator from ArtifactsConfig.Destination [23:51:00] i'll do that and rebase your patch [23:52:41] 10LibUp: Update libup's canary repositories list - https://phabricator.wikimedia.org/T269899 (10Jdforrester-WMF) How about we add AbuseFilter and UploadWizard, and drop Linter and MassMessage? [23:53:25] bd808: actually, there's no reason to wait. we can merge your patch and follow up with making destination optional (default to source) [23:56:39] (03CR) 10Dduvall: [C: 03+2] "Thanks again, Bryan! We'll be able to build on this to simplify the other builders." [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis) [23:58:41] marxarelli: nice. I wrote a long ass comment about that validator, but then worked around it and deleted the comment. :) [23:59:12] :) [23:59:15] It wasn't completely clear to me how ArtifactsConfig.Merge would need to change with the validator removed [23:59:49] (03Merged) 10jenkins-bot: builder: support cross variant copying for builder.requirements [blubber] - 10https://gerrit.wikimedia.org/r/647120 (https://phabricator.wikimedia.org/T263597) (owner: 10BryanDavis)