[00:00:13] i think we just set destination to source if the former is empty [00:00:18] in Merge that is [00:00:43] marxarelli: so does pipelinelib make the new blubberoid "live" once the post-merge stuff completes? [00:01:05] and yeah, setting Destination = Source sounds like it should work [00:02:00] bd808: not quite. it takes a +2 on deployment-charts and a deploy. but we're getting closer to CD thanks to longma [00:02:47] * bd808 welcomes our emerging CD overlords [00:02:54] if we can figure out a reliable/secure way to go from the +2 to a helmfile apply... [00:03:31] too soon... i've been watching the Heaven's Gate doc on HBO :) [00:03:57] those shoes were left behind quite a while ago... [00:06:03] heheh [00:25:21] (03PS1) 10Dduvall: Make copies and requirements destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 [00:26:05] bd808: feel free to brutalize me in review :) [00:27:50] 10phan-taint-check-plugin, 10Patch-For-Review: False positives due to array keys and values being mixed together - https://phabricator.wikimedia.org/T269903 (10Daimona) [00:34:13] (03CR) 10BryanDavis: Make copies and requirements destination optional (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [02:11:51] 10Release-Engineering-Team, 10MediaWiki-extensions-OAuth, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Platform Team Workboards (Clinic Duty Team), 10ci-test-error (WMF-deployed Build Failure): Invalid timestamp/Failed asserting that $timestamp1 is identical to... - https://phabricator.wikimedia.org/T269502 [02:38:29] 10Continuous-Integration-Config: Restrict Jenkins credentials based on use by jobs - https://phabricator.wikimedia.org/T269910 (10jeena) [02:40:44] 10Release-Engineering-Team (Pipeline), 10Release Pipeline: Better way to restrict credentials available to pipelinelib - https://phabricator.wikimedia.org/T267699 (10jeena) [02:40:46] 10Continuous-Integration-Config: Restrict Jenkins credentials based on use by jobs - https://phabricator.wikimedia.org/T269910 (10jeena) [04:48:24] 10phan-taint-check-plugin, 10Patch-For-Review: taint-check: Unexpected argument count for SecurityCheck-LikelyFalsePositive warning from analyze phase - https://phabricator.wikimedia.org/T269890 (10DannyS712) [04:54:44] (03CR) 10DannyS712: Add Gerrit report format (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10GergΕ‘ Tisza) [04:56:51] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10DannyS712) >>! In T246674#6326093, @thiemowmde wrote: > I'm still not really sure if it's a good idea to //block// people from using assertEm... [06:51:33] (03PS1) 10Legoktm: [WIP] Initial commit [integration/utils-rs] - 10https://gerrit.wikimedia.org/r/647995 [06:52:44] (03PS1) 10Legoktm: zuul: Configure rust-test for integration/utils-rs repository [integration/config] - 10https://gerrit.wikimedia.org/r/647996 [06:54:05] (03CR) 10jerkins-bot: [V: 04-1] zuul: Configure rust-test for integration/utils-rs repository [integration/config] - 10https://gerrit.wikimedia.org/r/647996 (owner: 10Legoktm) [09:05:59] (03CR) 10Kosta Harlan: [C: 03+1] Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [09:07:01] 10Project-Admins, 10Inuka-Team: Clean up open #New-Readers tasks in Phabricator - https://phabricator.wikimedia.org/T251706 (10Aklapper) (Note to myself: Updated [meta:Template:Communications](https://meta.wikimedia.org/w/index.php?title=Template%3ACommunications&type=revision&diff=20789670&oldid=19861272) whi... [09:19:43] (03CR) 10Kosta Harlan: [C: 04-1] Add Gerrit report format (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647594 (owner: 10GergΕ‘ Tisza) [13:17:48] hashar: is there a recommended way in CI to deal with tests needing a large amount of data? what i'm working on currently needs about 1.5G compressed / 4.3G uncompressed, and downloading it from the net for each run doesn't seem desirable [13:25:29] kormat: that sounds overkill? ;) [13:26:06] I would need a whole lot more context [13:26:09] hashar: it's 2 tarballs of mariadb binaries πŸ€·β€β™€οΈ [13:26:25] the context is https://phabricator.wikimedia.org/T265266 [13:26:25] but in short if that is too large maybe the test material can be reduced to a smaller set [13:26:44] else we can always move those to a dedicated set of instances and attach them to jenkins. That is the case for the puppet compiler [13:26:53] notably cause it has a bunch of facts that come from production [13:28:21] (03PS3) 10Lars Wirzenius: feat: add train-dev subcommands reset, copy, and deploy [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 [13:28:23] (03PS1) 10Lars Wirzenius: indent [tools/train-dev] - 10https://gerrit.wikimedia.org/r/648225 [13:28:25] (03PS1) 10Lars Wirzenius: ops [tools/train-dev] - 10https://gerrit.wikimedia.org/r/648226 [13:28:57] (03PS4) 10Lars Wirzenius: feat: add train-dev subcommands reset, copy, and deploy [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 [13:37:55] 10phan-taint-check-plugin, 10Patch-For-Review: False positives due to array keys and values being mixed together - https://phabricator.wikimedia.org/T269903 (10Daimona) Note to self: array offsets might be affected by the same problem. [13:38:59] hashar: with some overhead, and caching the result somewhere inside WMF, i could probably shave about 500M off the compressed size, but that's about it [13:39:22] basically get the tarballs, unpack, remove things that aren't strictly necessary, and re-pack [13:39:36] but the bulk of the data is just the actual mariadb binaries [13:43:39] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10thiemowmde) See, I'm not sure about this "can". Do we need to force people to be more specific, when assertEmpty works just fine [in so many... [13:45:06] (03Abandoned) 10Lars Wirzenius: ops [tools/train-dev] - 10https://gerrit.wikimedia.org/r/648226 (owner: 10Lars Wirzenius) [13:45:16] (03Abandoned) 10Lars Wirzenius: indent [tools/train-dev] - 10https://gerrit.wikimedia.org/r/648225 (owner: 10Lars Wirzenius) [14:27:38] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki Train Development Environment: Change train-dev to notice if the train-dev image isn't there when starting - https://phabricator.wikimedia.org/T269759 (10LarsWirzenius) p:05Triageβ†’03Medium [14:28:11] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Change deploy-promote to check previous groups have been promoted to - https://phabricator.wikimedia.org/T269242 (10LarsWirzenius) p:05Triageβ†’03Medium [14:28:48] 10Scap: Scap .deb build patches bin/scap for hashbang - https://phabricator.wikimedia.org/T268349 (10LarsWirzenius) p:05Triageβ†’03Medium [15:58:32] (03CR) 10Ahmon Dancy: [C: 03+2] feat: add train-dev subcommands reset, copy, and deploy [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 (owner: 10Lars Wirzenius) [16:10:35] (03CR) 10Ahmon Dancy: [V: 03+2 C: 03+2] feat: add train-dev subcommands reset, copy, and deploy [tools/train-dev] - 10https://gerrit.wikimedia.org/r/644297 (owner: 10Lars Wirzenius) [16:30:30] 10phan-taint-check-plugin, 10Patch-For-Review: Array shapes not tracked when linking parameters to methods - https://phabricator.wikimedia.org/T269903 (10Daimona) [16:45:02] (03CR) 10Dduvall: [C: 04-1] Make copies and requirements destination optional (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [16:50:23] 10phan-taint-check-plugin: Taintedness is incorrectly overridden for static props - https://phabricator.wikimedia.org/T269944 (10Daimona) [16:52:05] 10phan-taint-check-plugin: Taintedness is incorrectly overridden for static props - https://phabricator.wikimedia.org/T269944 (10Daimona) Or even better, we might set $override on a per-object (rather than per-node) basis. https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/SecurityCheckPlugin/+/645111 already... [17:03:24] (03PS2) 10Dduvall: Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 [17:04:45] (03CR) 10Dduvall: Make artifact destination optional (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [17:06:11] (03PS3) 10Dduvall: Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 [17:06:31] (03PS4) 10Dduvall: Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 [17:07:12] (03CR) 10Dduvall: "Sorry for the noise. I forgot to `:w` my copies.go changes :)" [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [17:20:18] 10Continuous-Integration-Config, 10Performance-Team: Include paratest runner with stock MediaWiki - https://phabricator.wikimedia.org/T269894 (10thcipriani) Adding @kostajh per @hashar 's suggestion [17:46:14] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [18:05:26] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [18:39:18] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [18:41:12] (03PS1) 10Dduvall: Expose Jenkins environment variables and job parameters [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 [18:49:00] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [18:59:22] (03CR) 10Ahmon Dancy: [C: 03+1] "Looks reasonable to me." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 (owner: 10Dduvall) [19:02:22] (03CR) 10Ahmon Dancy: [C: 03+1] Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [19:13:14] (03PS2) 10Dduvall: Expose Jenkins environment variables and job parameters [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 [19:18:04] (03CR) 10Dduvall: [C: 03+1] "The systemtest failed for me at `env + params`. It seems `env` is not a normal Groovy Map and doesn't implement `plus`. I've refactored to" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 (owner: 10Dduvall) [19:18:25] 10Release-Engineering-Team, 10WVUI, 10Release Pipeline (Blubber): Use npm version 6.x on blubber-generated docker images - https://phabricator.wikimedia.org/T269957 (10nnikkhoui) [19:18:46] (03CR) 10Dduvall: [C: 04-1] "And now I'm getting another failure due to env. :(" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 (owner: 10Dduvall) [19:26:21] Krinkle: Ping re. https://github.com/wikimedia/less.php/pull/54 :-) [19:28:00] why are some libraries on github instead of gerrit? [19:29:09] afaik this is the only one, [19:29:14] it's a fork from another project [19:29:47] isn't our eslint config also on github? [19:32:09] Yes, all our CI tools live on GitHub. [19:32:20] Because they're part of a wider CI universe that lives on GitHub. [19:32:43] except phpcs and taint check? [19:33:15] Yes, sorry, CI-on-the-Web, not OMG-please-stop-using-PHP. [19:33:38] ah [19:33:44] PHP CI is less of a community and more of a support group. [19:38:03] unrelated: https://performance.wikimedia.org/xhgui/waterfall shows an error - is there already a bug report for this? No idea what component it is from [19:39:12] Probably the #WikimediaDebug component? Perf team, either way. [19:41:05] !bash PHP CI is less of a community and more of a support group. [19:41:09] legoktm: Stored quip at https://bash.toolforge.org/quip/mUpSU3YBhxWNv8gIRHj2 [19:41:33] legoktm: Ha. :-) [19:43:35] xD [20:37:51] 10phan-taint-check-plugin: Add a convenient way to represent taintedness of variadic params - https://phabricator.wikimedia.org/T257191 (10Daimona) 05Openβ†’03Resolved [20:38:26] 10phan-taint-check-plugin: taint-check: Unexpected argument count for SecurityCheck-LikelyFalsePositive warning from analyze phase - https://phabricator.wikimedia.org/T269890 (10Daimona) 05Openβ†’03Resolved [20:38:35] 10phan-taint-check-plugin: Fix caused-by lines in phan-taint-check - https://phabricator.wikimedia.org/T203652 (10Daimona) 05Openβ†’03Resolved a:03Bawolff [20:38:37] 10phan-taint-check-plugin: taint-check: Handle PassByRefs before calling this method - https://phabricator.wikimedia.org/T269888 (10Daimona) 05Openβ†’03Resolved [20:52:47] (03CR) 10BryanDavis: [C: 03+1] Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [20:59:14] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), and 2 others: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Daimona) [20:59:21] 10phan-taint-check-plugin, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): taint-check has trouble for taintedness of unknown array keys and reports possible false positives - https://phabricator.wikimedia.org/T268905 (10Daimona) 05Openβ†’03Resolved [21:06:47] (03PS3) 10Dduvall: Expose Jenkins job parameters and Git checkout info [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 [21:07:22] (03CR) 10jerkins-bot: [V: 04-1] Expose Jenkins job parameters and Git checkout info [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 (owner: 10Dduvall) [21:08:52] (03PS4) 10Dduvall: Expose Jenkins job parameters and Git checkout info [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/648320 [21:17:56] (03CR) 10Ahmon Dancy: [C: 03+2] Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [21:21:35] (03Merged) 10jenkins-bot: Make artifact destination optional [blubber] - 10https://gerrit.wikimedia.org/r/647852 (owner: 10Dduvall) [21:32:12] !log deploying blubberoid:2020-12-11-212149-production (refs https://gerrit.wikimedia.org/r/c/blubber/+/647120 and T263597) [21:32:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:32:15] T263597: Allow use of copied artifacts in subsequent build step - https://phabricator.wikimedia.org/T263597 [21:32:22] bd808: ^ [21:32:58] marxarelli: \o/ thanks! [21:37:21] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), and 2 others: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Daimona) [21:37:30] 10phan-taint-check-plugin, 10Patch-For-Review, 10Upstream: taint-check fails on array-plus and assumed int|float type - https://phabricator.wikimedia.org/T268891 (10Daimona) 05Openβ†’03Stalled Stalled because the remaining issue should be resolved upstream. [21:43:59] bd808: np! deployed [21:44:09] thanks for the contribution! [21:45:43] 10Continuous-Integration-Infrastructure, 10Operations, 10Wikimedia-Apache-configuration, 10Patch-For-Review: Apache slash expansion should not redirect from HTTPS to HTTP - https://phabricator.wikimedia.org/T95164 (10hashar) `DirectorySlash` redirecting to http instead of canonical https is #upstream Apach... [21:45:45] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: doc.wikimedia.org urls without trailing slash respond with HTTP 403 Forbidden - https://phabricator.wikimedia.org/T213509 (10hashar) > The rewrite of requests lacking a trialling slash is handled by mod_dir Dire... [21:50:58] bd808: ugh. somethings wrong [21:52:20] !log rolling back blubberoid:2020-12-11-212149-production [21:52:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:52:46] something's not right with the COPY from the builder requirements [21:52:58] time to implement some more high-level tests i think [21:54:03] marxarelli: :( Is it the destination being a file and not a dir? [21:54:25] more round trip tests with complex config would probably be good [21:55:50] it's not dealing with copies of subdirectories into a destination dir correctly [21:56:06] it doesn't help that docker is completely absurd in its logic around directories [21:56:25] that sounds like a missing trailing / somewhere [21:56:30] sorry, i should have tested this more thoroughly [22:05:47] bd808: i think i'll have to take a closer look at this on monday [22:06:24] marxarelli: sounds good. Let me know if you need help making test cases or anything [22:06:33] i'm testing with a new blubber.yaml for blubberoid [22:06:37] https://www.irccloud.com/pastebin/LfMxDDLZ/ [22:07:11] the old version (currently deployed) of blubberoid gives me [22:07:15] https://www.irccloud.com/pastebin/Y96gq2NQ/ [22:07:37] the latest master gives me [22:07:39] https://www.irccloud.com/pastebin/A3LBKt2L/ [22:08:04] building the latter results in all the subdirectory contents being under ./ [22:08:46] yeah, that's bugs in my code then. It's being too aggressive in collapsing copy from local [22:09:35] It need to check for the trailing / on the from [22:09:47] I bet I can fix this over the weekend [22:10:01] i think it's more than that. docker is really non-obvious when it comes to directories and dealing with contents vs. the directory itself [22:10:32] which, iirc, is why we had the mkdirs and separate copy instructions [22:10:42] i should have left better comments :) [22:10:46] for myself and others [22:12:07] I think it is basically the same problem I worked around with https://github.com/wikimedia/blubber/blob/master/config/requirements.go#L61-L64 but on the source file side [22:13:13] but you may be right that it would work differently if the dest dirs were made first. Docker does have "interesting" copy semantics [22:14:16] 10phan-taint-check-plugin, 10Patch-For-Review: Taintedness is incorrectly overridden for static props - https://phabricator.wikimedia.org/T269944 (10Daimona) a:03Daimona The issue is already resolved on master with [[https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/SecurityCheckPlugin/+/645111 | r645111... [22:14:42] from the docs "If is a directory, the entire contents of the directory are copied, including filesystem metadata. Note The directory itself is not copied, just its contents." [22:14:49] so dumb [22:16:41] i wonder if it acts differently when copying from another image [22:17:00] but yeah, i'll have to look more closely on monday [22:18:07] One thing I changed from macros.SyncFiles was consolidating the files from the local by destination. And this really looks like badly choosing the destination [22:34:55] 10phan-taint-check-plugin: Continue tracking array shapes after the first unknown key is found - https://phabricator.wikimedia.org/T269974 (10Daimona) [22:38:15] 10phan-taint-check-plugin: Print the whole shape with @phan-debug-var-taintedness - https://phabricator.wikimedia.org/T269975 (10Daimona) [22:39:14] marxarelli: I think I see what I messed up. I think the problem is in NewFromShort(). I'm doing a path.Dir() that is messing things up for that input. [22:40:47] sometimes the path.Dir() is needed and sometimes it is not. I need to trace through the legacy macro more to understand when each is approriate [22:50:28] (03PS1) 10BryanDavis: requirements: Fix regression in short form handling [blubber] - 10https://gerrit.wikimedia.org/r/648362 (https://phabricator.wikimedia.org/T263597) [22:50:33] marxarelli: ^ [23:08:28] 10phan-taint-check-plugin, 10Patch-For-Review: Print the whole shape with @phan-debug-var-taintedness - https://phabricator.wikimedia.org/T269975 (10Daimona) a:03Daimona [23:08:33] 10Release-Engineering-Team, 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM - https://phabricator.wikimedia.org/T247653 (10Dzahn) [23:10:50] 10Release-Engineering-Team (Kanban), 10Operations, 10serviceops, 10vm-requests: eqiad: 1 VM request for doc.wikimedia.org - https://phabricator.wikimedia.org/T211974 (10Dzahn) Now doc1002 should be created (T269977) to buster (T247653). And we should also make doc2001 in codfw. [23:22:09] 10Release-Engineering-Team, 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM - https://phabricator.wikimedia.org/T247653 (10Dzahn) [23:33:55] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki appservers to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) I ran all httpbb appserver tests on mwdebug1003: ` [deploy1001:~] $...