[00:00:06] (03CR) 10Jforrester: [C: 04-1] "This isn't working, for some reason." [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [00:09:36] (03PS4) 10Jforrester: jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image [integration/config] - 10https://gerrit.wikimedia.org/r/649988 [00:09:38] (03PS1) 10Jforrester: jjb: Drop parsoidsvc-deploy-composer-testonly-php72-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/649994 [00:10:22] (03CR) 10Jforrester: [C: 03+2] jjb: Drop parsoidsvc-deploy-composer-testonly-php72-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/649994 (owner: 10Jforrester) [00:10:36] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Urbanecm_WMF) 05Open→03Resolved This one is done. [00:11:43] (03Merged) 10jenkins-bot: jjb: Drop parsoidsvc-deploy-composer-testonly-php72-docker, unused [integration/config] - 10https://gerrit.wikimedia.org/r/649994 (owner: 10Jforrester) [00:15:29] (03CR) 10Jforrester: [C: 04-1] jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [00:18:43] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] "Looks ok, builds locally. Will need a followup patch in core." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/644935 (owner: 10Ahmon Dancy) [00:37:12] 10Beta-Cluster-Infrastructure, 10Parsoid: beta: broken puppet deployment-parsoid11; Server Error; deployment-puppetdb03.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T270355 (10Dzahn) [01:08:39] 10Gerrit, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Password Reset Request - https://phabricator.wikimedia.org/T270357 (10bd808) Gerrit uses the same password as Wikitech. You can use https://wikitech.wikimedia.org/wiki/Special:PasswordReset to send yourself a password recovery email. Your u... [01:16:57] 10Gerrit, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Password Reset Request - https://phabricator.wikimedia.org/T270357 (10jaredblumer) Got it! Thank you so much. [01:17:58] 10Gerrit, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Password Reset Request - https://phabricator.wikimedia.org/T270357 (10jaredblumer) 05Open→03Resolved [01:26:24] 10Phabricator, 10I18n, 10Patch-For-Review: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10mmodell) I think this should be fixed now. @hashar or @Verdy_p can you confirm? [01:27:48] 10MediaWiki-Codesniffer: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) I figured out how to replace the in_array and array_key_exists, but for `strpos` there is a third parameter, the offset, that if present wouldn'... [01:34:57] (03CR) 10Ammarpad: "> Patch Set 5:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712) [01:36:13] (03CR) 10DannyS712: "> Patch Set 5:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712) [01:38:32] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [01:39:46] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) a:03DannyS712 [01:43:15] (03CR) 10Jforrester: [C: 03+1] New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [01:46:02] (03PS3) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [01:46:07] (03CR) 10DannyS712: "PS3: Added assertIsInt( strpos() ) -> assertStringContainsString" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [01:50:52] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) Patch covers: * `assertTrue` and `assertFalse` with `array_key_exists` or `in_array` (for `in_array`,... [01:59:34] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Etonkovidova) >>! In T270165#6697371, @Urbanecm_WMF wrote: > This one is done. @Urbanecm_WMF - The task is closed without enabling Growth features? [03:24:48] hi. Any chance anyone wants to review https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649916 ? It'll be fun - happy holidays! [03:24:52] :) [03:43:05] !log Updating dev-images docker-pkg files on primary contint for fundraising buster base and php7.2-dba inclusion [03:43:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:54:57] 10Gerrit, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Password Reset Request - https://phabricator.wikimedia.org/T270357 (10Aklapper) 05Resolved→03Invalid [08:38:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I can see both arguments. Sure, it does not really make a difference which of the two styles is used. Both have the same effect. But isn't" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712) [08:50:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Uh, I like the implementation very much. It looks clean and fast (lots of early returns). It's super helpful that everything is auto-fixab" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [09:12:13] 10Continuous-Integration-Config: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 (10Nikerabbit) [09:33:57] 10Gerrit, 10wikitech.wikimedia.org: Can't login into Gerrit with a Wikimedia Developer account with non-unique email address - https://phabricator.wikimedia.org/T270233 (10hashar) Gerrit does the mapping between its internal account and the LDAP account using the LDAP `cn` field normalized to lower case. The e... [11:15:50] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10TechCom: Create WikiTeq group on Gerrit - https://phabricator.wikimedia.org/T267213 (10Kizule) 05Resolved→03Open @tstarling Thank you! [[ https://www.mediawiki.org/wiki/Extension:PreferencesList | mediawiki/extensions/PreferencesList ]] should be... [11:16:45] (03PS1) 10Zoranzoki21: Review access change [extensions/PreferencesList] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/649920 [11:17:42] (03PS2) 10Zoranzoki21: Add access for WikiTeq group [extensions/PreferencesList] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/649920 (https://phabricator.wikimedia.org/T267213) [11:23:04] Am I right in remembering that somewhere we make mediawiki docker images right now? (not the docker hub ones) [11:23:40] addshore: dev images maybe? [11:24:05] there is https://gerrit.wikimedia.org/r/q/project:releng%252Fdev-images [11:24:28] though I think it only ships the environment, not the actual code [11:24:39] we once had a pipeline config to generate a docker image with mediawiki/core code in it [11:25:10] that run after each merged but that kind of overloaded the docker registry with bunch of images that nobody uses so that got disabled [11:31:41] 10Phabricator, 10I18n, 10Patch-For-Review: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10hashar) 05Open→03Resolved Yes that works! Thank you so much for deploying the fix @mmodell :] [11:33:19] hashar: aaah, that last one you talk about it probably the one i remember [11:33:23] tarrow: ^^ [11:34:47] https://gerrit.wikimedia.org/g/releng/dev-images/+/refs/heads/master :) [11:35:33] and the list can be found through https://dockerregistry.toolforge.org/ under the namespace 'dev/' [11:35:55] there are the CI Quibble images as well addshore though well they are intended for CI consumption [11:36:34] lunch time [12:06:26] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Urbanecm_WMF) >>! In T270165#6697529, @Etonkovidova wrote: >>>! In T270165#6697371, @Urbanecm_WMF wrote: >> This one is done. > > @Urbanecm_WMF - The task is clo... [12:11:47] (03CR) 10Tim Starling: [C: 03+2] Add access for WikiTeq group [extensions/PreferencesList] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/649920 (https://phabricator.wikimedia.org/T267213) (owner: 10Zoranzoki21) [12:12:19] (03CR) 10Tim Starling: [V: 03+2 C: 03+2] Add access for WikiTeq group [extensions/PreferencesList] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/649920 (https://phabricator.wikimedia.org/T267213) (owner: 10Zoranzoki21) [12:50:19] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Tobi_WMDE_SW) [14:11:19] 10Release-Engineering-Team, 10Gerrit-Privilege-Requests, 10TechCom: Create WikiTeq group on Gerrit - https://phabricator.wikimedia.org/T267213 (10Kizule) 05Open→03Resolved Patch merged, everything should be really okay now. [14:24:01] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10Xqt) [14:45:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Patch-For-Review: Provide python 3.8 in CI test images - https://phabricator.wikimedia.org/T268850 (10hashar) [14:45:45] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10hashar) [14:46:07] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10hashar) We don't have Python 3.8 on the CI infrastructure yet. [15:02:56] (03CR) 10Daimona Eaytoy: [C: 04-1] "I'm not convinced by a few things:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [15:19:48] (03PS4) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [15:20:11] 10commit-message-validator: commit-message-validator prints a weird error message "Expected at least 3 lines" - https://phabricator.wikimedia.org/T257107 (10Xqt) It happend again: https://gerrit.wikimedia.org/r/c/pywikibot/core/+/647602 [15:22:17] (03CR) 10DannyS712: "> Patch Set 3: Code-Review-1" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [15:29:38] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > First and foremost, contrary to T253618#6697500, the third argument to is_array cannot be ignored:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [15:31:57] Daimona are you around to discuss ^ a bit? [15:32:48] Sort of [15:34:04] for the issue with in_array, if there is no third parameter (it it is set and false) can assertContainsEqual be used? assertContains calls the TraversableContainsIdentical constraint (https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/Constraint/Traversable/TraversableContainsIdentical.php) and assertContainsEqual calls the [15:34:05] TraversableContainsEqual constraint (https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/Constraint/Traversable/TraversableContainsEqual.php) with the difference being the use of string equality [15:36:39] 10MediaWiki-Codesniffer, 10phan: Consider replacing complex or non-style-related PHPCS sniffs with one or more phan plugins - https://phabricator.wikimedia.org/T270398 (10Daimona) [15:37:12] Oh, yes, I think assertContainsEqual might be good [15:38:01] Why is Phan unhappy again: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/88734/console ? [15:41:47] Likely some annotation added in mw core [15:43:10] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10Xqt) >>! In T270389#6698477, @hashar wrote: > We don't have Python 3.8 on the CI infrastructure yet. Oh. :'-( [15:43:35] I'm not sure the usage of RawApiMessages is correct in https://gerrit.wikimedia.org/g/mediawiki/extensions/Translate/+/609ae6147cb42ed92d14c28b1bc4d919d50e613c/TranslateHooks.php#1137 [15:43:47] I think the issue can be suppressed, it's a known false positive. It's already fixed on taint-check master, the fix is hopefully going to be released soon [15:44:06] ok, what's the estimate for soon? [15:44:44] The usage seems correct AFAICS [15:45:13] I don't see other examples passing localised messages to it [15:45:38] Soon = whenever https://gerrit.wikimedia.org/r/c/mediawiki/tools/phan/+/649367 is merged [15:46:00] But you can just add, at line 1136: // @phan-suppress-next-line SecurityCheck-DoubleEscaped [15:46:42] Ah, I meant "correct" as in "no double escaping takes place there" [16:07:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Patch-For-Review, 10Sustainability (Incident Followup): Add option in Scap to restart php-fpm for emergency deployments, and skip depoolin... - https://phabricator.wikimedia.org/T243009 [16:20:10] 10MediaWiki-Codesniffer, 10phan: Consider replacing complex or non-style-related PHPCS sniffs with one or more phan plugins - https://phabricator.wikimedia.org/T270398 (10Daimona) Here are some examples of sniffs that might be migrated. I might write a POC if I find some time in the next couple of days: - Unu... [16:21:44] (03PS1) 10Reedy: Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) [16:22:44] (03CR) 10jerkins-bot: [V: 04-1] Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) (owner: 10Reedy) [16:23:45] ffs [16:25:27] (03PS1) 10Reedy: Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 [16:26:17] (03PS1) 10Reedy: Use php-parallel-lint/php-parallel-lint 1.2.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650169 [16:26:22] (03CR) 10jerkins-bot: [V: 04-1] Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 (owner: 10Reedy) [16:27:15] (03PS2) 10Reedy: Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 [16:27:25] (03CR) 10jerkins-bot: [V: 04-1] Use php-parallel-lint/php-parallel-lint 1.2.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650169 (owner: 10Reedy) [16:28:15] (03CR) 10DannyS712: "Fails on PHP8 due to older version of codesniffer - bumping at https://gerrit.wikimedia.org/r/c/mediawiki/tools/release/+/650186" [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) (owner: 10Reedy) [16:28:32] (03CR) 10jerkins-bot: [V: 04-1] Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 (owner: 10Reedy) [16:30:07] It's a long way to the top... [16:40:01] (03PS3) 10Reedy: Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 [16:40:03] (03PS2) 10Reedy: Use php-parallel-lint/php-parallel-lint 1.2.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650169 [16:40:09] (03PS2) 10Reedy: Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) [16:41:35] (03CR) 10jerkins-bot: [V: 04-1] Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) (owner: 10Reedy) [16:41:43] (03CR) 10jerkins-bot: [V: 04-1] Use mediawiki/mediawiki-codesniffer 34.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650168 (owner: 10Reedy) [16:41:45] (03CR) 10jerkins-bot: [V: 04-1] Use php-parallel-lint/php-parallel-lint 1.2.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650169 (owner: 10Reedy) [16:42:33] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Failure is unrelated (phpunit, will fix in followup)" [tools/release] - 10https://gerrit.wikimedia.org/r/650168 (owner: 10Reedy) [16:44:16] (03PS5) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [16:44:21] (03PS1) 10Reedy: Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 [16:44:34] Daimona ^^^ now using assertContainsEquals - would you mind taking another look? [16:45:26] (03CR) 10jerkins-bot: [V: 04-1] Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:45:38] I will [16:46:11] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Let's force this one too..." [tools/release] - 10https://gerrit.wikimedia.org/r/650169 (owner: 10Reedy) [16:46:13] (03CR) 10DannyS712: "> Patch Set 4: Code-Review-1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [16:46:16] thanks [16:46:44] (03PS2) 10Reedy: Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 [16:48:00] (03CR) 10jerkins-bot: [V: 04-1] Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:49:45] Seems fine, still needs exclusion from non-test files [16:50:06] (03PS3) 10Reedy: Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 [16:51:41] (03CR) 10Reedy: "Remnants were left around in phpunit.xml.dist ;)" [tools/release] - 10https://gerrit.wikimedia.org/r/563492 (https://phabricator.wikimedia.org/T222829) (owner: 10Jforrester) [16:51:57] (03CR) 10Reedy: [C: 03+2] Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:52:13] (03PS3) 10Reedy: Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) [16:52:17] (03CR) 10Reedy: [C: 03+2] Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) (owner: 10Reedy) [16:54:00] (03Merged) 10jenkins-bot: Allow phpunit/phpunit ~9.5 for PHP 8.0 [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:54:10] (03CR) 10Daimona Eaytoy: Allow phpunit/phpunit ~9.5 for PHP 8.0 (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:54:20] (03Merged) 10jenkins-bot: Start branching StopForumSpam [tools/release] - 10https://gerrit.wikimedia.org/r/650167 (https://phabricator.wikimedia.org/T181217) (owner: 10Reedy) [16:54:26] (03CR) 10Reedy: "Yeah, doing that next :D" [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:54:53] (03CR) 10Daimona Eaytoy: "> Patch Set 3:" [tools/release] - 10https://gerrit.wikimedia.org/r/650173 (owner: 10Reedy) [16:57:58] (03PS1) 10Reedy: Remove phpunit testing, no phpunit tests exist [tools/release] - 10https://gerrit.wikimedia.org/r/650176 [16:58:00] (03PS1) 10Reedy: Don't run phpcs on make-release/mediawiki-* [tools/release] - 10https://gerrit.wikimedia.org/r/650177 [16:58:14] (03CR) 10Reedy: [C: 03+2] Remove phpunit testing, no phpunit tests exist [tools/release] - 10https://gerrit.wikimedia.org/r/650176 (owner: 10Reedy) [16:58:31] (03CR) 10Reedy: [C: 03+2] Don't run phpcs on make-release/mediawiki-* [tools/release] - 10https://gerrit.wikimedia.org/r/650177 (owner: 10Reedy) [16:59:52] (03Merged) 10jenkins-bot: Remove phpunit testing, no phpunit tests exist [tools/release] - 10https://gerrit.wikimedia.org/r/650176 (owner: 10Reedy) [17:00:02] (03Merged) 10jenkins-bot: Don't run phpcs on make-release/mediawiki-* [tools/release] - 10https://gerrit.wikimedia.org/r/650177 (owner: 10Reedy) [17:05:46] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10hashar) Sorry my comment was a bit short. The idea is to get python 3.8 packaged T24195, I guess we should also... [17:09:19] (03CR) 10Daimona Eaytoy: "(Copying my comment here: the part about assertContainsEqual seems fine, but it still needs exclusion from non-test files)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [17:18:32] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Pywikibot, 10Pywikibot-tests: Enable Pywikibot fasttest with Python 3.8 / Python 3.9 - https://phabricator.wikimedia.org/T270389 (10Xqt) I think T241195 was meant. Anyway thank you all for your job for this matter. Probably I Need further help... [17:19:49] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [17:20:10] (03CR) 10DannyS712: "> Patch Set 5:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [17:24:00] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [17:24:52] (03PS3) 10DannyS712: Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 [17:30:27] (03CR) 10Daimona Eaytoy: "Missed one" (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [17:33:45] (03PS4) 10DannyS712: Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 [17:33:48] (03CR) 10DannyS712: Add PHPUnitTestTrait for checking if a file is a test (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [17:35:25] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [17:36:35] (03PS5) 10DannyS712: Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 [17:56:20] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) [17:59:46] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) @mmodell is enabling e-mail notifications easy, or hard? 😬 [18:01:09] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) [18:11:49] !log Fixing some merge conflicts in beta puppet (so that upstream can sync again). [18:11:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:13:08] 10Phabricator (Upstream), 10Upstream, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10Aklapper) p:05Triage→03Low See https://phabricator.wikimedia.org/settings/panel/emailpreferences/ for what is possible... [18:18:01] !log Doing the same in beta puppet-private. [18:18:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:25:35] (03CR) 10Ahmon Dancy: [V: 03+2 C: 03+2] Update Mediawiki Chart [releng/local-charts] - 10https://gerrit.wikimedia.org/r/649458 (owner: 10Jeena Huneidi) [18:25:37] FYI, Puppet in beta hasn't been able to sync for a couple of weeks now, so even if I did the above 100% correctly, there's a good chance some recent changes from prod may have side effects. [18:26:24] I tagged the state of both repos before and after with snapshot-. [18:32:43] !log Restart puppetdb on deployment-puppetdb03 (T248041) [18:32:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:32:46] T248041: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 [18:36:13] 10Phabricator (Upstream), 10Upstream, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) @Aklapper but that page is for my preferences, right? I think sending e-mail notification to the user that w... [18:36:32] dpifke: thank you! [18:37:10] and that puppetdb03 we should get it resized [18:37:53] 10Continuous-Integration-Config: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 (10Jdforrester-WMF) a:03Jdforrester-WMF [18:38:13] np. And agreed. Someone was working on it at some point, I think - I seem to recall a puppetdb04 instance. [18:43:12] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI [integration/config] - 10https://gerrit.wikimedia.org/r/650223 (https://phabricator.wikimedia.org/T270369) [18:44:35] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI [integration/config] - 10https://gerrit.wikimedia.org/r/650223 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [18:44:51] (03CR) 10Daimona Eaytoy: [C: 03+2] Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [18:46:28] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI [integration/config] - 10https://gerrit.wikimedia.org/r/650223 (https://phabricator.wikimedia.org/T270369) [18:46:30] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install phan CI [integration/config] - 10https://gerrit.wikimedia.org/r/650225 (https://phabricator.wikimedia.org/T270369) [18:47:02] (03Merged) 10jenkins-bot: Add PHPUnitTestTrait for checking if a file is a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [18:47:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Technical-Debt: Clear /srv/.git on contint1001; move integration.wikimedia.org doc... - https://phabricator.wikimedia.org/T149924 [18:49:20] hashar: BTW, I'm sure I'm being an idiot, but I can't work out why https://gerrit.wikimedia.org/r/c/integration/config/+/649988 doesn't work… [18:49:22] 10Phabricator (Upstream), 10Upstream, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10Dzahn) I would think this is the "Other badge activity not listed above occurs." under the Badges section in the settings l... [18:50:12] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI [integration/config] - 10https://gerrit.wikimedia.org/r/650223 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [18:50:37] (03PS6) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [18:51:20] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI [integration/config] - 10https://gerrit.wikimedia.org/r/650223 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [18:51:52] !log Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Install CI T270369 [18:51:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:51:56] T270369: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 [18:52:47] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Quota-requests): Request increased quota for Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10hashar) [18:53:08] 10Beta-Cluster-Infrastructure, 10Developer Productivity, 10Patch-For-Review, 10Puppet: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 (10hashar) [18:53:11] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Quota-requests): Request increased quota for Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10hashar) [18:53:37] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Quota-requests): Request increased RAM for deployment-puppetdb03 in deployment-prep Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10hashar) [18:54:16] 10Beta-Cluster-Infrastructure, 10Developer Productivity, 10Patch-For-Review, 10Puppet: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 (10hashar) > The deployment-puppetdb03 instance has just 2 GB of memory, I guess we can get it resized to a slightly... [18:56:08] (03PS7) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [19:00:44] Daimona ^ updated as requested to only apply to tests [19:02:24] (03PS3) 10Umherirrender: Add more tags to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712) [19:02:27] (03CR) 10Umherirrender: [C: 03+2] Add more tags to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712) [19:04:11] (03Merged) 10jenkins-bot: Add more tags to EmptyTagSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647072 (https://phabricator.wikimedia.org/T252914) (owner: 10DannyS712) [19:06:01] James_F: sorry was completing some migration and now having dinner. I have opened the link , will check later [19:09:37] (03PS9) 10Umherirrender: Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) [19:09:40] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Switch quibble to composer [integration/config] - 10https://gerrit.wikimedia.org/r/650233 (https://phabricator.wikimedia.org/T270369) [19:09:50] hasharDinner: Of course. :-) [19:10:48] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) 05Open→03Resolved [19:13:27] 10Gerrit, 10wikitech.wikimedia.org: Can't login into Gerrit with a Wikimedia Developer account with non-unique email address - https://phabricator.wikimedia.org/T270233 (10Tgr) >>! In T270233#6697881, @hashar wrote: > For the wiki bot accounts, I guess one can use an email alias by appending to their mailbox n... [19:13:32] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Switch quibble to composer [integration/config] - 10https://gerrit.wikimedia.org/r/650233 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [19:15:12] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Switch quibble to composer [integration/config] - 10https://gerrit.wikimedia.org/r/650233 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [19:16:59] !log Zuul: [mediawiki/extensions/WikibaseStatementUpdater] Switch quibble to composer T270369 [19:17:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:17:02] T270369: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 [19:17:41] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10cloud-services-team (Kanban): Request increased RAM for deployment-puppetdb03 in deployment-prep Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10bd808) [19:18:03] (03CR) 10Daimona Eaytoy: "Belatedly, AssertCountSniff should use this as well, would you mind creating a commit?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650187 (owner: 10DannyS712) [19:20:58] (03CR) 10Jforrester: [C: 04-1] "First time use of the job shows it's apparently not working, whoops." [integration/config] - 10https://gerrit.wikimedia.org/r/650225 (https://phabricator.wikimedia.org/T270369) (owner: 10Jforrester) [19:23:28] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:25:26] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Urbanecm_WMF) @Etonkovidova They were enabled few minutes ago anyway :). [19:31:05] (03CR) 10Daimona Eaytoy: "Same for the other sniff" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:32:41] (03CR) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:36:03] (03CR) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:37:48] (03CR) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:42:47] (03CR) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:43:34] (03CR) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [19:47:19] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Peachey88) [19:50:15] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Etonkovidova) >>! In T270165#6699484, @Urbanecm_WMF wrote: > @Etonkovidova They were enabled few minutes ago anyway :). Thanks! Listing here what's missing in `b... [19:54:25] 10Gerrit, 10MediaWiki-Gerrit-Group-Requests: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Legoktm) 05Open→03Resolved a:03Legoktm Done. [19:58:23] Tchanders and whoever is responsible for ipinfo - tried to enable the preference on beta enwiki: [19:58:23] [X9u4MqwQBHcAABdVVN8AAACA] /wiki/Special:Preferences Wikimedia\Rdbms\DBTransactionSizeError from line 1663 of /srv/mediawiki/php-master/includes/libs/rdbms/loadbalancer/LoadBalancer.php: Transaction spent 3.6547169685364 second(s) in writes, exceeding the limit of 3 [19:58:51] and beta logstash is still down [20:02:48] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Mainframe98) >>! In T258227#6689092, @Daimona wrote: > Copying my comment from gerrit: > >> I am counting 346 issues for MW core,... [20:02:52] DannyS712: Thanks - I'm not sure what's happening there. The preference worked fine for me, so I wonder if it's definitely related? [20:03:43] not sure [20:04:55] I wanted to try out the rest modules - is there a rest version of ApiHelp? https://meta.wikimedia.beta.wmflabs.org/api/rest_v1/#/ doesn't show the ipinfo modules [20:07:09] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Urbanecm_WMF) >>! In T270165#6699570, @Etonkovidova wrote: >>>! In T270165#6699484, @Urbanecm_WMF wrote: >> @Etonkovidova They were enabled few minutes ago anyway... [20:08:38] DannyS712: No there isn't yet - we should add that. Until then, I guess the best place to look is extension.json [20:08:41] (03CR) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [20:09:19] DannyS712: Were you able to enable the preference or is it still not working? [20:09:28] it enabled [20:10:38] Daimona I don't really understand dynamic properties - would you be willing to amend my patch with what you were thinking? [20:11:43] James_F: found it :) [20:11:49] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Daimona) >>! In T258227#6699590, @Mainframe98 wrote: > The original intention of the task has to do with preventing a check against... [20:12:21] DannyS712: It's just to say: add a property to $phpcsFile, even if the class doesn't define it. Which is kind of a hack, but not even that much. [20:12:32] Can't do it now, sorry [20:14:44] (03CR) 10Daimona Eaytoy: [C: 04-1] New sniff: MediaWiki.PHPUnit.SpecificAssertions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [20:17:44] (03CR) 10Hashar: [C: 04-1] "It fails cause {docker_image} is parsed by YAML as a map. That should be quoted to be interpreted as a string which is then processed by " (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [20:18:33] James_F: https://gerrit.wikimedia.org/r/c/integration/config/+/649988/4/jjb/parsoidsvc.yaml#34 totally non obvious bug. I could not spot it before dinner but as I picked up my laptop the fault just flashed at me :] [20:19:09] hashar: OFFS. Thank you. :-) [20:19:39] hashar: Also, it turns out all the non-php72 phan jobs don't work (but have never been used until now), so that's my next thing to fix. :-) [20:20:21] those tiny bugs are the worse [20:20:39] I once spend two hours figure out why PHP code failed [20:20:42] s/:/;/ [20:22:27] (03PS5) 10Jforrester: jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image [integration/config] - 10https://gerrit.wikimedia.org/r/649988 [20:22:41] (03PS6) 10Jforrester: jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image [integration/config] - 10https://gerrit.wikimedia.org/r/649988 [20:23:58] (03CR) 10Jforrester: jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [20:24:29] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [20:25:53] (03Merged) 10jenkins-bot: jjb: [wikipeg-special-node10-plus-php72-composer-docker] Use same image [integration/config] - 10https://gerrit.wikimedia.org/r/649988 (owner: 10Jforrester) [20:26:38] hashar: But thank you massively, that's a huge help. [20:26:49] super happy to help [20:27:06] and the job templates I was advocating for are very nice when we generate jobs for multiple php versions [20:27:25] I should look for a way to define the php / docker image mapping somewhere up in the stack maybe [20:27:32] not sure it is actually doable [20:28:11] Not for the jobs with special builds, no. [20:28:29] Unless we made super-images with all versions of PHP, and set which version to use via an environmental variable? [20:28:38] That could work… [20:29:35] yeah that is what we used previously [20:29:48] we have that for releng/tox (multiple pythons) [20:30:19] maybe we can move back to use a PHP env var again, specially given php7+ Debianpackages are now co installables [20:32:04] (03PS3) 10Jforrester: jjb: Provide PHP 8.0 variants of OOUI and Wikipeg jobs [integration/config] - 10https://gerrit.wikimedia.org/r/649989 [20:32:23] (03CR) 10Jforrester: [C: 03+2] jjb: Provide PHP 8.0 variants of OOUI and Wikipeg jobs [integration/config] - 10https://gerrit.wikimedia.org/r/649989 (owner: 10Jforrester) [20:32:30] (03PS3) 10Jforrester: Zuul: Add experimental PHP 8.0 jobs for OOUI and Wikipeg [integration/config] - 10https://gerrit.wikimedia.org/r/649990 [20:32:44] (03CR) 10Jforrester: [C: 03+2] Zuul: Add experimental PHP 8.0 jobs for OOUI and Wikipeg [integration/config] - 10https://gerrit.wikimedia.org/r/649990 (owner: 10Jforrester) [20:34:04] (03Merged) 10jenkins-bot: jjb: Provide PHP 8.0 variants of OOUI and Wikipeg jobs [integration/config] - 10https://gerrit.wikimedia.org/r/649989 (owner: 10Jforrester) [20:34:06] (03Merged) 10jenkins-bot: Zuul: Add experimental PHP 8.0 jobs for OOUI and Wikipeg [integration/config] - 10https://gerrit.wikimedia.org/r/649990 (owner: 10Jforrester) [20:34:42] !log Zuul: Add experimental PHP 8.0 jobs for OOUI and Wikipeg [20:34:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:39:03] (03PS1) 10Jforrester: Zuul: [wikipeg] Make PHP 8.0 job required [integration/config] - 10https://gerrit.wikimedia.org/r/650250 (https://phabricator.wikimedia.org/T269720) [20:39:18] (03CR) 10Jforrester: [C: 03+2] Zuul: [wikipeg] Make PHP 8.0 job required [integration/config] - 10https://gerrit.wikimedia.org/r/650250 (https://phabricator.wikimedia.org/T269720) (owner: 10Jforrester) [20:40:36] (03Merged) 10jenkins-bot: Zuul: [wikipeg] Make PHP 8.0 job required [integration/config] - 10https://gerrit.wikimedia.org/r/650250 (https://phabricator.wikimedia.org/T269720) (owner: 10Jforrester) [20:46:03] (03PS1) 10Jforrester: Zuul: [ooui] Make PHP 8.0 jobs required [integration/config] - 10https://gerrit.wikimedia.org/r/650252 [20:46:05] (03PS1) 10Jforrester: jjb: Drop ooui-special-node10-plus-php72-composer-docker, now unused [integration/config] - 10https://gerrit.wikimedia.org/r/650253 [20:48:16] (03CR) 10Jforrester: [C: 03+2] Zuul: [ooui] Make PHP 8.0 jobs required [integration/config] - 10https://gerrit.wikimedia.org/r/650252 (owner: 10Jforrester) [20:48:32] (03CR) 10Jforrester: [C: 03+2] jjb: Drop ooui-special-node10-plus-php72-composer-docker, now unused [integration/config] - 10https://gerrit.wikimedia.org/r/650253 (owner: 10Jforrester) [20:49:39] (03Merged) 10jenkins-bot: Zuul: [ooui] Make PHP 8.0 jobs required [integration/config] - 10https://gerrit.wikimedia.org/r/650252 (owner: 10Jforrester) [20:49:54] (03Merged) 10jenkins-bot: jjb: Drop ooui-special-node10-plus-php72-composer-docker, now unused [integration/config] - 10https://gerrit.wikimedia.org/r/650253 (owner: 10Jforrester) [20:50:53] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Tgr) 05Resolved→03Open RESTBase errors should only happen when you create articles with VE (and only until the next RESTBase deployment). [20:51:41] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Urbanecm) Restbase was deployed few minutes ago, @Tgr. [20:55:41] (03PS1) 10Jforrester: Zuul: [wikipeg] Run the composer-test-package suite [integration/config] - 10https://gerrit.wikimedia.org/r/650257 (https://phabricator.wikimedia.org/T269720) [20:55:50] (03CR) 10Jforrester: [C: 03+2] Zuul: [wikipeg] Run the composer-test-package suite [integration/config] - 10https://gerrit.wikimedia.org/r/650257 (https://phabricator.wikimedia.org/T269720) (owner: 10Jforrester) [20:56:33] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.22 deployment blockers - https://phabricator.wikimedia.org/T267415 (10dduvall) 05Open→03Resolved [20:57:16] (03Merged) 10jenkins-bot: Zuul: [wikipeg] Run the composer-test-package suite [integration/config] - 10https://gerrit.wikimedia.org/r/650257 (https://phabricator.wikimedia.org/T269720) (owner: 10Jforrester) [20:59:06] !log Zuul: [wikipeg] Run the composer-test-package suite T269720 [20:59:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:59:12] T269720: Add PHP 8.0 support to WikiPEG - https://phabricator.wikimedia.org/T269720 [21:44:59] (03PS1) 10Dduvall: Refactor other builder types to use RequirementsConfig [blubber] - 10https://gerrit.wikimedia.org/r/650266 [21:49:04] (03PS2) 10Dduvall: Refactor other builder types to use RequirementsConfig [blubber] - 10https://gerrit.wikimedia.org/r/650266 [21:57:52] 10Continuous-Integration-Config, 10Patch-For-Review: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 (10Jdforrester-WMF) So this is done except for phan, which will need some work, I'm afraid. I'll probably work on it next week. [22:24:56] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Tgr) 05Open→03Resolved Not sure how I ended up reopening this, I was only trying to comment. [22:58:33] 22:55:53 git.exc.GitCommandError: Cmd('git') failed due to: exit code(128) [22:58:33] 22:55:53 cmdline: git fetch --tags -v origin [22:58:33] 22:55:53 stderr: 'fatal: unable to access 'https://gerrit.wikimedia.org/r/mediawiki/core/': The requested URL returned error: 502' [22:58:36] * Reedy cries a little [23:06:07] (03PS1) 10Reedy: When updating git submodules also do --recursive [tools/release] - 10https://gerrit.wikimedia.org/r/650282 [23:06:55] (03PS2) 10Reedy: makerelease2.py: When updating git submodules also do --recursive [tools/release] - 10https://gerrit.wikimedia.org/r/650282 [23:07:00] (03CR) 10Reedy: [C: 03+2] makerelease2.py: When updating git submodules also do --recursive [tools/release] - 10https://gerrit.wikimedia.org/r/650282 (owner: 10Reedy) [23:08:26] (03Merged) 10jenkins-bot: makerelease2.py: When updating git submodules also do --recursive [tools/release] - 10https://gerrit.wikimedia.org/r/650282 (owner: 10Reedy) [23:10:39] (03CR) 10Jeena Huneidi: "Deployed to production" [blubber] - 10https://gerrit.wikimedia.org/r/649738 (https://phabricator.wikimedia.org/T270207) (owner: 10Legoktm) [23:21:17] Reedy: we should pass --recursive to the git submodule foreach ones too [23:21:38] aha, probably, ja :) [23:22:48] (03CR) 10DannyS712: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (owner: 10DannyS712) [23:25:28] (03CR) 10Jforrester: "The linked task is about Phabricator task auto-creation?" [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (owner: 10DannyS712) [23:26:56] (03CR) 10DannyS712: "> Patch Set 2:" [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (owner: 10DannyS712) [23:36:37] (03PS3) 10Jforrester: Add Gerrit maintenance bot to whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (https://phabricator.wikimedia.org/T253439) (owner: 10DannyS712) [23:38:20] (03CR) 10Jforrester: [C: 03+2] Add Gerrit maintenance bot to whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (https://phabricator.wikimedia.org/T253439) (owner: 10DannyS712) [23:40:00] (03Merged) 10jenkins-bot: Add Gerrit maintenance bot to whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/650194 (https://phabricator.wikimedia.org/T253439) (owner: 10DannyS712) [23:41:06] !log Zuul: Add Gerrit maintenance bot to whitelist T253439 [23:41:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:41:09] T253439: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 [23:48:28] (03PS1) 10Reedy: More recursiveness [tools/release] - 10https://gerrit.wikimedia.org/r/650301 [23:48:54] (03CR) 10Legoktm: [C: 03+2] More recursiveness [tools/release] - 10https://gerrit.wikimedia.org/r/650301 (owner: 10Reedy) [23:50:42] (03Merged) 10jenkins-bot: More recursiveness [tools/release] - 10https://gerrit.wikimedia.org/r/650301 (owner: 10Reedy) [23:51:49] 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263805 (10Reedy) 05Open→03Resolved p:05Triage→03Medium a:03Reedy [23:51:52] 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263805 (10Reedy)