[00:04:21] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-Docker, 10Patch-For-Review, 10User-brennen: Set up distribution of MediaWiki-Docker CLI - https://phabricator.wikimedia.org/T250241 (10RLazarus) [00:18:31] 10Gerrit, 10Operations: Gerrit is OOMing - https://phabricator.wikimedia.org/T270451 (10Legoktm) p:05Triage→03Unbreak! [00:19:02] thcipriani: ^^ that time of the month again [00:19:20] legoktm: oh good. [00:22:07] well. better today than tomorrow during git gc [00:25:04] Reedy should the EditPage fix in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650296/3 be a part of 1.35.1 so that anyone who wants to run tests on it themselves starts with passing tests? [00:25:08] thcipriani: I feel like this comes up every time, but we don't have monitoring for Gerrit's memory usage? or is it just not working? [00:25:34] DannyS712: No [00:25:42] it's a phpcs fail [00:25:56] we don't run phpcs against all of MW core [00:26:27] 10MediaWiki-Releasing, 10Security: Obtain CVEs for 1.31.11/1.35.1 security releases - https://phabricator.wikimedia.org/T263809 (10Reedy) [00:26:56] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263802 (10Reedy) [00:27:05] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263803 (10Reedy) [00:27:27] 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263806 (10Reedy) [00:27:34] 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263807 (10Reedy) [00:27:42] 10MediaWiki-Releasing, 10Security: Tag 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263808 (10Reedy) [00:30:05] legoktm: we have a monitoring of https://gerrit.wikimedia.org/r/plugins/healthcheck/Documentation/index.html but we start to hit parallel stop-the-world GC events degrading performance before that explodes [00:32:10] hm [00:32:35] 10MediaWiki-Releasing, 10Security: Tag 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263808 (10Reedy) 05Open→03Resolved a:03Reedy [00:32:38] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263802 (10Reedy) [00:34:07] this would probably be the metric to add alerting on: https://grafana.wikimedia.org/d/Bw2mQ3iWz/javamelody?viewPanel=14&orgId=1 [00:35:19] that's typically in the 10s of milliseconds, once it's above 100ms that typically is enough impact for people to notice slowness [00:39:51] I notice when people start complaining about 502s when CI tries to clone [01:12:46] 10MediaWiki-Releasing: Add more sanity checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Legoktm) [01:33:29] 10Gerrit, 10Operations: Gerrit is OOMing - https://phabricator.wikimedia.org/T270451 (10ops-monitoring-bot) Icinga downtime set by legoktm@cumin1001 for 0:10:00 1 host(s) and their services with reason: OOM ` gerrit1001.wikimedia.org ` [01:35:11] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263803 (10DannyS712) [02:53:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM - https://phabricator.wikimedia.org/T247653 (10Dzahn) [02:53:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM - https://phabricator.wikimedia.org/T247653 (10Dzahn) [02:53:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM - https://phabricator.wikimedia.org/T247653 (10Dzahn) a:03Dzahn [02:54:02] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) [03:16:42] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263802 (10Reedy) [03:16:45] 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: Update HISTORY in master after 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263807 (10Reedy) 05Open→03Resolved a:03Reedy [03:18:33] 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263806 (10Reedy) 05Open→03Resolved a:03Reedy [03:18:36] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263802 (10Reedy) [03:18:49] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263802 (10Reedy) [03:18:52] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263803 (10Reedy) 05Open→03Resolved a:03Reedy [04:05:14] DannyS712: Thanks for all your help. [05:23:31] 10Gerrit, 10Operations: Gerrit is OOMing - https://phabricator.wikimedia.org/T270451 (10Legoktm) 05Open→03Resolved a:03Legoktm {F33951320} Will file a follow-up for better monitoring. [05:30:46] Hi folks, I'm seeing gerrit errors on this patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650396/1 [05:31:04] and zuul doesn't seem to pick it up [05:32:53] Every time I load the patch in the gerrit UI it pops up with [05:33:10] Error 500 (Server Error): Internal server error [05:33:19] I think that's https://phabricator.wikimedia.org/T270451 [05:33:23] Endpoint: /changes/*~*/revisions/*/files [05:33:23] gerrit is unhappy atm [05:33:32] ahh, the OOMing [05:34:32] k, pretty sure none of the 1.35.1 patches are actually urgent for the locked-down 'wiki' i'm trying to apply this to [05:34:40] heh [05:34:53] yeah, I don't imagine so offhand [05:34:53] looks like all the tricksiness needs at least an account [05:35:12] I can leave this for the morning [05:35:30] thanks! [05:38:01] legoktm: ^ is that related? or just more gerrit isssues [05:49:50] 10Beta-Cluster-Infrastructure, 10Parsoid, 10Wikimedia-Site-requests, 10Platform Team Workboards (Green): Enable parsoid extension in beta cluster - https://phabricator.wikimedia.org/T270440 (10Reedy) [06:06:34] uhh I'm skeptical but let me see [06:08:49] > Error in GET /r/changes/mediawiki%2Fcore~650396/revisions/1/files: missing_object [CONTEXT project="mediawiki/core" ] [06:09:45] ejegg: it seems to be on just your change, let me file a phab task and leave it for someone from releng who'll be more familiar with Gerrit to look at it [06:10:10] oh thanks legoktm ! [06:11:00] missing_object, huh? maybe I need to check all those submodule pointers [06:12:17] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396 "missing_object" - https://phabricator.wikimedia.org/T270472 (10Legoktm) [06:12:29] I don't know what it actually means, as far as I can tell that's the full error message [06:12:39] k, those are all pointing to real, merged commits [06:12:50] actually wait [06:12:57] java.util.concurrent.ExecutionException: org.eclipse.jgit.errors.MissingObjectException: Missing blob be668dfac285b80062cf4a2fb9ffd9e7489fe966 [06:13:03] hmm? [06:13:53] dunno what that's a pointer to [06:14:34] no idea - I can't find it locally [06:14:36] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Legoktm) [06:15:00] would it be truly missing then? :p [06:15:41] heh, I guess the question is who's looking for it [06:16:42] I don't see anything else in logstash that might be useful [06:17:19] https://logstash.wikimedia.org/app/kibana#/dashboard/AW1f-0k0ZKA7RpirlnKV?_g=h@97fe121&_a=h@873ccb6 there's a Gerrit dashboard if you want to peek yourself [06:23:28] James_F help with what? [06:26:52] thanks legoktm - I'll take another look in the morning [07:11:12] (03PS1) 10Legoktm: make-release: Lint PHP and JSON files as an extra sanity check [tools/release] - 10https://gerrit.wikimedia.org/r/650410 (https://phabricator.wikimedia.org/T270452) [07:12:27] (03CR) 10Legoktm: "This added a little more than a minute of runtime when I tested it against 1.35.1." [tools/release] - 10https://gerrit.wikimedia.org/r/650410 (https://phabricator.wikimedia.org/T270452) (owner: 10Legoktm) [07:14:14] Reedy: do you have docker installed on the machine you make releases on? [07:27:01] (03PS2) 10Legoktm: Configure pipeline for mediawiki/libs/Shellbox [integration/config] - 10https://gerrit.wikimedia.org/r/649745 [07:27:53] (03CR) 10Legoktm: [C: 03+2] Configure pipeline for mediawiki/libs/Shellbox [integration/config] - 10https://gerrit.wikimedia.org/r/649745 (owner: 10Legoktm) [07:29:24] (03Merged) 10jenkins-bot: Configure pipeline for mediawiki/libs/Shellbox [integration/config] - 10https://gerrit.wikimedia.org/r/649745 (owner: 10Legoktm) [07:37:22] !log reloaded zuul for https://gerrit.wikimedia.org/r/649745 [07:37:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:03:00] 10Continuous-Integration-Config, 10Code-Health, 10Discovery-Search (Current work), 10Patch-For-Review: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 (10Gehel) I've create a [[ https://docs.google.com/document/d/1g7opvXdWDW... [08:10:20] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Mainframe98) >>! In T258227#6699609, @Daimona wrote: >> Other patterns I've seen are `if ( $varThatMightBeNull )`, (where varThatMi... [08:18:54] 10Phabricator: Document account requirements to edit Phabricator projects (maybe that's #Trusted-Contributors now? Or also #WMF-NDA?) - https://phabricator.wikimedia.org/T268001 (10mmodell) @aklapper: that doesn't refer to a specific form, it means that there are no forms where that user satisfies the form "visi... [08:57:19] gehel: je voulais t'appeler pour java 8/11 et sonar:sonar . Le doc https://docs.google.com/document/d/1g7opvXdWDWgOCnbMX9eYIVCSXYDiMpScy072LN1-AhI/edit semble répondre à toutes les questions que j'avais hier soir :] [08:57:59] hashar: cool! fais-moi signe si il y a encore des bouts qui ne sont pas clairs [08:58:20] je suis dedans ce matin, on verra ce que j'ai d'ici cette après midi :] [08:58:42] il y a sans doute une craquée de trucs qu'on peut simplifier dans la configuration actuelle. En particulier, avoir la même config pour tous les projects. [08:59:06] clairement oui :] [08:59:58] et problablement ajouté un tutorial pour java sous https://www.mediawiki.org/wiki/Continuous_integration/Tutorials [09:08:46] 10Continuous-Integration-Config, 10Patch-For-Review: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 (10Nikerabbit) Thanks! I hope I am not making this unnecessary complicated. [10:17:24] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 2 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10hashar) [10:51:09] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Technical-Debt: Clear /srv/.git on contint1001; move integration.wikimedia.org doc... - https://phabricator.wikimedia.org/T149924 [11:17:54] 10Release-Engineering-Team (Pipeline), 10CX-cxserver, 10serviceops, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Migrate apertium to the deployment pipeline - https://phabricator.wikimedia.org/T255672 (10Pginer-WMF) 05Open→03Resolved [11:17:59] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Operations, 10Release Pipeline, and 2 others: Migrate production services to kubernetes using the pipeline - https://phabricator.wikimedia.org/T198901 (10Pginer-WMF) [12:31:35] (03PS1) 10Hashar: jjb: Sonar requires java11 in java8 site-publish jobs [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) [12:32:57] (03CR) 10Hashar: "I went back and forth, but it seems the easiest is just to use the releng/sonar-scanner image in the site-publish job. That is the same im" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [12:33:29] gehel: je crois que ça devrait le faire en utilisant l'image releng/sonar-scanner quand on invoque "mvn sonar:sonar" ^ :] [12:33:41] on peut en discuter par vidéo quand tu seras de retour [12:44:41] (03PS1) 10Thiemo Kreuz (WMDE): Rewrite EmptyTag sniff for performance [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650489 [12:47:58] (03CR) 10jerkins-bot: [V: 04-1] Rewrite EmptyTag sniff for performance [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650489 (owner: 10Thiemo Kreuz (WMDE)) [12:57:21] hashar: je suis chez la pédiatre pour le contrôle des 2 ans. De retour bientôt [12:58:03] gehel: prend tout ton temps. Je suis calé bien au chaud près du poele :] [13:02:21] (03PS3) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:02:26] (03CR) 10Daimona Eaytoy: "Amended" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:05:04] (03CR) 10jerkins-bot: [V: 04-1] Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:09:57] (03PS4) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:13:21] (03CR) 10jerkins-bot: [V: 04-1] Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:14:35] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Daimona) What I meant is adding a list of types that are forbidden in conditionals (can be e.g. `[ 'string', 'null', 'object', 'arr... [13:15:44] (03CR) 10Lars Wirzenius: "Right. I'm going to have to address this more deeply and add test cases for the various failure possibilities and as such, this is too big" [tools/scap] - 10https://gerrit.wikimedia.org/r/645369 (owner: 10Lars Wirzenius) [13:15:47] (03Abandoned) 10Lars Wirzenius: fix: handle errors from testing, applying individual patches [tools/scap] - 10https://gerrit.wikimedia.org/r/645369 (owner: 10Lars Wirzenius) [13:19:08] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10MediaWiki Train Development Environment, and 3 others: Create a development & testing environment for scap + train deployments - https://phabricator.wikimedia.org/T255695 (10LarsWirze... [13:20:06] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki Train Development Environment: Make a way to test Scap in train-dev - https://phabricator.wikimedia.org/T265502 (10LarsWirzenius) 05Open→03Resolved This is done using new `train-dev` subcommands. [13:20:37] (03PS5) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:22:35] (03PS2) 10Thiemo Kreuz (WMDE): Rewrite EmptyTag sniff for performance [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650489 [13:24:34] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-backport-deployments: Cancel EU BACKPORT window on Tuesdays when train is run from the EU - https://phabricator.wikimedia.org/T254745 (10LarsWirzenius) Not sure if this is needed anymore. The Tuesday parts of the train don't seem to b... [13:25:39] hashar: je suis de retour et Augustin est à la sieste. On se fait un call quand tu veux [13:25:52] je choppe mes écouteurs [13:26:06] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap: Format Scap source code with black - https://phabricator.wikimedia.org/T252399 (10LarsWirzenius) 05Open→03Resolved a:03LarsWirzenius This is implemented now. [13:27:58] hashar: zut, Augustin ne dort pas tout à fait. 5 minutes... [13:28:17] 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Scap: Prepare Scap release 1.15.0 with current changes - https://phabricator.wikimedia.org/T253996 (10LarsWirzenius) [13:28:18] heheh ;) [13:28:22] 10Beta-Cluster-Infrastructure: Updating Scap on beta cluster hosts with cumin fails - https://phabricator.wikimedia.org/T254786 (10LarsWirzenius) 05Open→03Resolved a:03LarsWirzenius The https://wikitech.wikimedia.org/wiki/Cumin page now has this example that I've used succesfully: `O{project:deployment-pr... [13:32:51] (03PS6) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [13:59:56] (03CR) 10Gehel: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [14:19:38] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10EngProd-Virtual-Hackathon, 10Python3-Porting: Fix Scap test suite problems under Python 3 - https://phabricator.wikimedia.org/T246025 (10LarsWirzenius) [14:37:14] (03PS1) 10Gehel: Simplification of java-codehealth job. [integration/config] - 10https://gerrit.wikimedia.org/r/650509 [14:46:28] (03CR) 10Hashar: [C: 03+2] "Paired with Guillaume. I guess the idea was to have another job for post merge analysis which would pass different parameter to sonar:son" [integration/config] - 10https://gerrit.wikimedia.org/r/650509 (owner: 10Gehel) [14:47:50] (03Merged) 10jenkins-bot: Simplification of java-codehealth job. [integration/config] - 10https://gerrit.wikimedia.org/r/650509 (owner: 10Gehel) [14:52:01] !log Updating https://integration.wikimedia.org/ci/job/wikidata-query-flink-swift-plugin-maven-java8-docker-site-publish/ to run sonar with Java 11 (build remains on Java 8) T264873 [14:52:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:52:07] T264873: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 [14:52:13] running at https://integration.wikimedia.org/ci/job/wikidata-query-flink-swift-plugin-maven-java8-docker-site-publish/4/console [14:52:19] and fails grr [14:53:22] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) Redoing the merge locally and then squashing in the vendor / composer.lock update seems to have made gerrit happy with the change. I don't see any difference between PS1 and... [14:59:49] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) Oops, I spoke too soon. The first time I looked at PS2 in the gerrit UI it loaded correctly and showed the list of changed files, though zuul didn't seem to pick it up for t... [14:59:50] (03CR) 10Hashar: "I have updated solely the flink site-publish job and ran it, it passed: https://integration.wikimedia.org/ci/job/wikidata-query-flink-swif" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [15:06:17] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Sebastian_Berlin-WMSE) I'd like to have project creation rights for @WMSE-project-start-bot. It's a bot that we use to set up projects for a new year. All projects are subprojects to... [15:11:39] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Aklapper) 05Stalled→03Open I've added @WMSE-project-start-bot [15:11:58] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Aklapper) 05Open→03Stalled [15:14:45] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) Seems to be complaining about the same missing blob: https://logstash.wikimedia.org/app/kibana#/dashboard/AW1f-0k0ZKA7RpirlnKV?_g=() I've tried searching for that blob loca... [15:17:32] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) I've forgotten where this script comes from, but this is the one I use: ` #!/bin/bash searchfor=$1 startpoints="master" # branch names or HEAD or whatever git rev-... [15:26:41] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) So I found a ***commit*** matching that sha1. It's a submodule commit for CategoryTree: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/07df2a859666f4e4... [15:32:50] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) Thanks for the sleuthing @thcipriani ! So CategoryTree is included in the submodules for base REL1_35, but we removed it after forking off fundraising/REL1_35. In the 1.35.... [15:56:13] <_joe_> hi there, I want to enable the pipeline for a project in CI [15:56:20] <_joe_> what needs to be done? [15:56:31] <_joe_> I already have a patch adding the .pipeline directory [15:56:47] <_joe_> https://gerrit.wikimedia.org/r/c/mediawiki/libs/Shellbox/+/649651/ [15:58:09] <_joe_> uh nevermind, it's already setup [15:58:22] <_joe_> then I guess I just need to remove the rest of the CI clutter [16:07:42] (03CR) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [16:08:44] 10Gerrit, 10Release-Engineering-Team: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) I do see it getting removed: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/619814 It seems like that should cause a merge conflict so having to resolve on merging... [16:09:08] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) [16:16:41] (03CR) 10Daimona Eaytoy: Make use of PHPUnitTestTrait in more sniffs (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [16:52:20] (03CR) 10Gehel: [C: 03+1] "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [16:54:46] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) @thcipriani in your test case does the foo branch still have a 'sub' section in its .gitmodules? In looking for a workaround, we found... [16:58:42] tyler's new avatar is so close to ariel's that I'm getting confused when reading phab comments :) [17:07:32] (03CR) 10Hashar: "Yeah :( At least the job no more fails so there is some progress!" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [17:07:52] (03PS2) 10Hashar: jjb: Sonar requires java11 in java8 site-publish jobs [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) [17:09:24] (03CR) 10Hashar: jjb: Sonar requires java11 in java8 site-publish jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [17:11:15] greg-g: one of the many services I offer [17:19:13] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10Ejegg) now reloading that workaround patch in gerrit is giving me the 500 error again. I swear it loaded the c... [17:30:19] (03CR) 10Hashar: [C: 03+2] "All jobs passed! :]" [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [17:31:38] (03Merged) 10jenkins-bot: jjb: Sonar requires java11 in java8 site-publish jobs [integration/config] - 10https://gerrit.wikimedia.org/r/650487 (https://phabricator.wikimedia.org/T264873) (owner: 10Hashar) [17:38:23] (03PS7) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 [17:39:02] (03CR) 10DannyS712: [C: 03+1] "Modifications by @Daimona look good to me" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [17:56:59] (03CR) 10Daimona Eaytoy: [C: 03+1] Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [18:08:08] (03CR) 10Hashar: "check experimental" [integration/quibble] - 10https://gerrit.wikimedia.org/r/645142 (owner: 10Hashar) [18:38:14] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Operations, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10RLazarus) [18:49:58] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) Interestingly if you load: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650524 it's fine, but https://gerrit.wikimedia.org/r/c... [18:50:43] (03CR) 10Ahmon Dancy: [C: 04-1] Refactor other builder types to use RequirementsConfig (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/650266 (owner: 10Dduvall) [18:53:56] (03CR) 10Dduvall: [C: 04-1] Refactor other builder types to use RequirementsConfig (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/650266 (owner: 10Dduvall) [18:57:52] 10Gerrit, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) >>! In T270472#6702234, @thcipriani wrote: > This is maybe a UI problem in gerrit... I was able to recreate this using the example... [19:07:47] (03PS3) 10Dduvall: Refactor other builder types to use RequirementsConfig [blubber] - 10https://gerrit.wikimedia.org/r/650266 [19:08:17] (03CR) 10Dduvall: [C: 03+1] Refactor other builder types to use RequirementsConfig (033 comments) [blubber] - 10https://gerrit.wikimedia.org/r/650266 (owner: 10Dduvall) [19:10:57] (03CR) 10Ahmon Dancy: [C: 03+1] Refactor other builder types to use RequirementsConfig [blubber] - 10https://gerrit.wikimedia.org/r/650266 (owner: 10Dduvall) [19:41:12] 10Continuous-Integration-Config, 10Patch-For-Review: Add CI for mediawiki/extensions/WikibaseStatementUpdater - https://phabricator.wikimedia.org/T270369 (10Jdforrester-WMF) >>! In T270369#6700910, @Nikerabbit wrote: > Thanks! I hope I am not making this unnecessary complicated. We'd have hit the the moment w... [19:41:47] (03CR) 10Jforrester: [C: 03+1] "Letting Reedy decide on C+2ing, given he's the one actually affected by this in practice." [tools/release] - 10https://gerrit.wikimedia.org/r/650410 (https://phabricator.wikimedia.org/T270452) (owner: 10Legoktm) [20:11:26] 10Gerrit, 10Release-Engineering-Team: Improve monitoring of Gerrit's memory usage - https://phabricator.wikimedia.org/T270521 (10Legoktm) [20:21:51] (03PS1) 10Umherirrender: Rewrite ParenthesesAroundKeywordSniff to fix whitespace handling [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650595 (https://phabricator.wikimedia.org/T265741) [20:22:46] (03CR) 10Umherirrender: "Created a alternative implementation: Ic2a9bec74df5ba0c85118c8b483c5a2fb0641f12" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647286 (https://phabricator.wikimedia.org/T265741) (owner: 10DannyS712) [20:33:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10thcipriani) [20:33:42] 10Gerrit, 10Release-Engineering-Team-TODO: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) [20:48:49] 10Gerrit, 10Release-Engineering-Team-TODO: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) Filed upstream as: https://bugs.chromium.org/p/gerrit/issues/detail?id=13845 There is a (possibly related) issue of zuul refusing to test this merge commit: {T270... [20:48:58] 10Gerrit, 10Release-Engineering-Team-TODO: Gerrit errors on change #650396, missing blob - https://phabricator.wikimedia.org/T270472 (10thcipriani) p:05Triage→03Medium [20:59:25] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10thcipriani) well. Recheck isn't working due to gerrit st... [21:01:19] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [skins/GuMaxDD] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/650602 [21:01:21] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [skins/GuMaxDD] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/650602 (owner: 10QChris) [21:01:26] (03PS1) 10QChris: Import done. Revoke import grants [skins/GuMaxDD] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/650603 [21:01:28] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [skins/GuMaxDD] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/650603 (owner: 10QChris) [21:03:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10hashar) My comment on https://gerrit.wikimedia.org/r/c/m... [21:07:46] (03PS1) 10Umherirrender: Require @return on doc block when return type hint is used [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650605 [21:08:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10hashar) And the winner is @thcipriani ! If I send a comm... [21:09:31] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10hashar) p:05Triage→03High [21:12:15] (03CR) 10DannyS712: "I suggest keeping T250958 in mind when adding to FunctionCommentSniff" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650605 (owner: 10Umherirrender) [21:28:21] (03CR) 10Umherirrender: "> Patch Set 1:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650605 (owner: 10Umherirrender) [21:36:27] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Split up FunctionCommentSniff - https://phabricator.wikimedia.org/T250958 (10Umherirrender) `DocumentationTypeTrait` was created in https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/644296 to share code with `PropertyDocumentationSni... [21:38:28] (03CR) 10DannyS712: [C: 03+2] Require @return on doc block when return type hint is used [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650605 (owner: 10Umherirrender) [21:39:21] (03PS25) 10DannyS712: FunctionCommentSniff: Move some sniffs to new separate sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/595737 (https://phabricator.wikimedia.org/T250958) [21:39:43] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Split up FunctionCommentSniff - https://phabricator.wikimedia.org/T250958 (10DannyS712) >>! In T250958#6702656, @Umherirrender wrote: > `DocumentationTypeTrait` was created in https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/644296... [21:40:47] (03Merged) 10jenkins-bot: Require @return on doc block when return type hint is used [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650605 (owner: 10Umherirrender) [21:42:14] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Zuul not running tests for gerrit change 650524 - https://phabricator.wikimedia.org/T270524 (10hashar) Seems the Java objet is CommentAdded... [21:58:19] 10Beta-Cluster-Infrastructure, 10Growth-Team (Current Sprint), 10User-Urbanecm: Create beta bnwiki - https://phabricator.wikimedia.org/T270165 (10Etonkovidova) Checked - it seems that Help module is missing. SE module works correctly. [22:38:55] hashar: Did you see https://gerrit.wikimedia.org/r/c/integration/config/+/645467/1#message-f251019591a3ae30cb7859af04bb1fe11eede389 ? [22:40:10] James_F: YES [22:40:33] James_F: should have replied to ack it. It is in my inbox of stuff to process. I guess after the break in january [22:40:58] or maybe next week depending on who is around from SRE :] [22:41:06] thank you so much for working on all the bits ! [22:41:43] hashar: Of course. :-) I just didn't want to throw the switch, increase CI load by 20%, and then have people complain at you for everything being slow. :-) [22:42:15] hashar: But note that SRE have buster for prod traffic live *now* (on one server), so waiting until January isn't great. :-( [22:42:30] (03CR) 10Hashar: "Thanks to have prepared all the steps leading to this, much appreciated. Not sure about the load that will add to CI and we could surely" [integration/config] - 10https://gerrit.wikimedia.org/r/645467 (https://phabricator.wikimedia.org/T252434) (owner: 10Jforrester) [22:42:41] James_F: yeah as usual [22:42:56] prod first, ci eventually when we noticed then maybe deployment-prep :] [22:43:02] hashar: Of course, "theoretically" buster will make no impact, and after a day of testing you can delete the stretch php72 images and just run buster-php72. [22:43:08] * James_F grins. [22:43:09] Yeah. [22:43:11] ;D [22:43:30] but, we got the php7.2 package for buster so that is great :] [22:43:42] and yeah probably we should just move from stretch to buster [22:43:47] Once buster-php72 works, I can replace the php73, 74 and 80 images with buster ones, and we can delete stretch entirely from CI. [22:43:51] but there are a bunch of side effects such as a newer chromium [22:43:55] * James_F is optimistic. [22:44:09] But I've got a very boring Christmas stuck in SF, so… ;-) [22:44:41] also quibble runs with a newer python [22:44:50] and not sure which mariadb is in the images [22:44:54] devil is in the details :] [22:45:01] Probably 10.4 like ships with buster. [22:45:04] * James_F nods. [22:45:08] Have fun. ;-) [22:45:10] yeah [22:45:23] I am there next week at least :-] [22:45:40] have a good week-end, I was about to leave. See you soon [23:35:38] (03PS1) 10Dduvall: Allow users to provide fetch options [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/650619 [23:37:41] (03CR) 10Dduvall: [C: 03+2] Allow users to provide fetch options [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/650619 (owner: 10Dduvall) [23:38:42] (03Merged) 10jenkins-bot: Allow users to provide fetch options [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/650619 (owner: 10Dduvall) [23:44:39] 10Release-Engineering-Team-TODO, 10WVUI, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), and 2 others: Modify readme.md for gerrit markdown - https://phabricator.wikimedia.org/T269300 (10Dzahn) @nnikkhoui Deployed in gerrit/gitiles config.