[00:00:52] Reedy: Now now, it's not the time to re-brand MediaWiki, however accurate that term is. [00:06:54] 10LibUp, 10Patch-For-Review, 10User-DannyS712: LibUp should remove empty `rules` from eslint - https://phabricator.wikimedia.org/T267178 (10Legoktm) 05Open→03Resolved a:03Jdforrester-WMF [00:07:54] lolol [00:08:06] Reedy: yep, looks like that's exactly what it was [00:09:00] ejegg: If you file a task I might have a look over Christmas? [00:09:35] But the civicrm image is a bit of the CI Depths of Doom™ that I've not explored [00:13:41] Reedy: Your cherry-picks have indeed broken zuul-cloner. [00:14:02] stupid thing [00:14:18] I think we're going to need to force-merge the pimple one. [00:14:32] And then remove the formal Depends-On: from the less one. [00:14:44] occasionally it'd be useful to be able to easily delete gerrit changes [00:14:47] You've managed to get CI into an inconsistent state. Well done. ;-) [00:17:40] Reedy James_F would you mind looking at why https://gerrit.wikimedia.org/r/c/mediawiki/core/+/651612 isn't merging? [00:17:48] Read up 5 lines [00:17:55] Indeed. [00:17:56] oh oops [00:18:00] Reedy screwed up. :-) [00:18:06] Well, kinda [00:18:09] But also, gerrit is stupid [00:18:15] gerrit/zuul/whatever [00:18:25] Top tip: Never ever ever make cherry-picks of unmerged vendor patches, you'll break the universe. [00:18:49] * Reedy uses the submit hammer [00:18:59] Reedy: Grump whilst you can. GitLab has no usable cross-repo dependency resolution for CI at all. [00:19:15] So we'll need to write everything to be double-forwards/backwards-compatible. [00:19:25] why does core even use pimple [00:19:25] Epic make work ahoy. [00:19:39] legoktm: Indeed, deleting it before 1.36 is an ambition. [00:19:52] * James_F will use the secret "because we say so" part of the deprecation policy. [00:20:05] https://gerrit.wikimedia.org/g/mediawiki/core/+/ed4835f9a456abcc09ebf8240d2b0471864c6579/tests/phpunit/MediaWikiTestCaseTrait.php#68 is the only thing that uses it [00:20:08] DannyS712: No pressure on you re-writing Flow to not use it, hmm? ;-) [00:20:09] I think lego's question is literally why is the... [00:20:10] legoktm: Yeah. [00:20:10] Yes, that [00:20:14] unless I'm missing something [00:20:19] legoktm: "Because it's there", AFAICS. [00:20:25] git rm tests/phpunit/MediaWikiTestCaseTrait.php [00:20:26] it's just in tests? so...we can just get rid of it [00:20:31] git commit -a -m "shit test is shit" [00:20:38] I guess we could delete that use and move the dependency into Flow itself? [00:21:06] tbh I didn't realize someone added it to core, it was originally just in Flow [00:21:20] Yeah. [00:21:42] 89a66d44607 [00:21:47] * James_F blames Reedy . [00:22:21] But how did it get used in the first place? [00:22:36] Tim, I think [00:22:39] Oh, was this back when we briefly tested core with vendor and not composer? Oops. But that'd explain it. [00:22:47] https://github.com/wikimedia/mediawiki/blame/master/tests/phpunit/MediaWikiTestCaseTrait.php#L6 [00:22:56] https://github.com/wikimedia/mediawiki/blame/master/tests/phpunit/MediaWikiTestCaseTrait.php#L70 [00:24:23] for the createSimpleObjectFactory, https://gerrit.wikimedia.org/r/c/mediawiki/libs/ObjectFactory/+/642445 means we won't need to actually have a service locator and can just use `new ObjectFactory( [] )` [00:24:49] anyone want to review that? [00:25:57] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Shellbox, and 2 others: Setup Git repo and CI for shellbox - https://phabricator.wikimedia.org/T263295 (10Legoktm) [00:26:45] * James_F was intentionally leaving that to the Platform tea,. [00:26:59] It's in their review queue. [00:29:47] the object factory patch? [00:30:02] Yes. [00:30:03] I guess I'll wait for the platform tea[m] then [00:31:23] Do we have a task for moving everything to phpunit 9.5? [00:31:42] Ah, there's T243600 [00:31:45] T243600: Preparation for the PHPUnit 9 upgrade - https://phabricator.wikimedia.org/T243600 [00:39:16] legoktm: How much will you cry if we switch all repos to 8.5||9.5 for phpunit? [00:39:42] I forget if I accidentally broke that in libup or not [00:39:56] Ha. Add a test and find out. [00:43:03] (03PS10) 10DannyS712: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 [00:48:02] thanks James_F! I think we've answered our own questions with some test commits. We'll sort out the civicrm-side scripts, then later push up a revision to the civicrm CI dockerfile removing the redundant step [00:48:15] ejegg: Nice. [00:48:35] ejegg: Please ping me if you need something deployed in CI/etc. [00:48:47] rockin, will do [01:34:47] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Reedy) What happened with this... As far as I can see, only #mediawiki-extensions-orphanedtalkpages has `composer phan` Do we need to do something to get this added? And do MW core manually? [01:36:24] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Jdforrester-WMF) Huh, yeah, I thought this was going to work. [01:37:10] 10LibUp, 10phan: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Jdforrester-WMF) 05Resolved→03Open [01:39:10] legoktm: Oops. :-) [01:40:08] uhhh [01:40:26] dang it even had tests and everything [01:40:33] oh I know why [01:40:41] Ye. [01:40:46] Tests of the function. [01:40:50] Not tests that the function was called. [01:41:03] https://gerrit.wikimedia.org/r/c/labs/libraryupgrader/+/651663 [01:42:53] hah [01:43:11] :) [01:46:05] Let's hope that doesn't break the world, given I wrote it six months ago. [01:46:37] brb looking at planets [01:47:33] 10LibUp, 10phan, 10Patch-For-Review: Add "composer phan" type command to composer.json - https://phabricator.wikimedia.org/T253477 (10Jdforrester-WMF) 05Open→03Resolved [01:59:54] 10LibUp: Add a list of failing repos or an indicator in lists for failing repos on libup web - https://phabricator.wikimedia.org/T268254 (10Legoktm) 05Open→03Resolved a:03Legoktm I fixed this as part of https://gerrit.wikimedia.org/r/651662 I forgot that `data.get_errors()` returned a generator, not a lis... [02:04:17] 10LibUp: Move libup data storage into mysql - https://phabricator.wikimedia.org/T241035 (10Legoktm) Also need to migrate: * Run logs and status * npm/composer vulnerability reports [02:18:24] Reedy: It passes! Gosh. [02:18:42] Which are we surprised by? [02:18:54] The dbal one. [02:18:57] Finally. [02:18:57] heh [02:28:57] Reedy: Also, observe my phan command addition actually working now: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/651672 [02:29:29] We really need some fixers for the phan tools. [02:33:22] would be cool if some of the stuff could be automated [02:33:28] Yeah. [02:33:42] Especially removing the "this suppression is no longer needed" ones. [02:34:34] 10LibUp, 10phan, 10phan-taint-check-plugin: Have some fixers for Phan issues so that LibUp patches aren't so much work for humans - https://phabricator.wikimedia.org/T270751 (10Jdforrester-WMF) [02:34:36] There. [02:41:20] James_F thanks for the speedy review [02:42:36] DannyS712: Always. [02:45:17] in that case, would you mind looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/651220/ ? [02:45:42] you can confirm its currently broken on the beta cluster - https://meta.wikimedia.beta.wmflabs.org/wiki/Special:GlobalWatchlistSettings [02:49:00] or for something a lot simpler https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/651601/2 [02:50:33] thanks so much [04:20:03] The main reason libup hasn't done phan stuff yet is because it requires cloning core...which I've avoided until now but still doable [04:35:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10incubator.wikimedia.org, 10I18n: Allow creating an independent "incubator wiki" instead of hosting all new wikis in one Incubator wiki with prefixes - https://phabricator.wikimedia.org/T228745 (10Ninjastrikers) >>! In T228... [05:13:46] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [05:22:13] ^^^ doesn't appear to be running tests [05:27:14] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Operations, 10observability, 10User-DannyS712: Beta cluster logstash down - https://phabricator.wikimedia.org/T268200 (10colewhite) >>! In T268200#6709451, @DannyS712 wrote: > > I'm still not seeing any mediawiki debug logs though (`type: "med... [05:55:24] I see stuff running [05:55:28] Just very slow/backlogged [06:31:41] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Operations, 10observability, 10User-DannyS712: Beta cluster logstash down - https://phabricator.wikimedia.org/T268200 (10DannyS712) >>! In T268200#6709792, @colewhite wrote: >>>! In T268200#6709451, @DannyS712 wrote: >> >> I'm still not seeing... [07:13:02] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [08:04:25] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [08:05:59] (03Merged) 10jenkins-bot: Remove semicolon in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/639887 (https://phabricator.wikimedia.org/T265740) (owner: 10Umherirrender) [08:38:16] (03PS4) 10Gehel: Align analytics and WDQS release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651540 [09:00:58] (03CR) 10Gehel: Align analytics and WDQS release builds. (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [10:15:02] (03PS1) 10Gehel: Extract an email publisher for analytics builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651755 [10:22:51] (03PS2) 10Gehel: Extract an email publisher for analytics and wikidata release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651755 [10:24:21] (03PS3) 10Gehel: Extract publishers for analytics and wikidata release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651755 [10:50:26] (03PS1) 10Gehel: Standardize on using maven-release-docker for all releases. [integration/config] - 10https://gerrit.wikimedia.org/r/651759 [10:51:38] (03CR) 10jerkins-bot: [V: 04-1] Standardize on using maven-release-docker for all releases. [integration/config] - 10https://gerrit.wikimedia.org/r/651759 (owner: 10Gehel) [10:53:52] (03CR) 10Giuseppe Lavagetto: "> Patch Set 1: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/651167 (owner: 10Giuseppe Lavagetto) [10:59:54] (03PS2) 10Gehel: Standardize on using maven-release-docker for all releases. [integration/config] - 10https://gerrit.wikimedia.org/r/651759 [11:08:58] gehel: :]] [11:59:40] (03CR) 10Lars Wirzenius: "> Patch Set 1: Code-Review+1" [tools/scap] - 10https://gerrit.wikimedia.org/r/651567 (owner: 10Lars Wirzenius) [12:11:48] 10Phabricator (Upstream), 10Upstream, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) Ah, sorry, I thought it was clear this is about awarding badges to users. (Tasks don't have badges, but toke... [13:43:03] gehel: Iam going to process your chain of changes ;) [13:50:45] (03PS5) 10Hashar: Align analytics and WDQS release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [13:52:06] (03CR) 10Hashar: "I have fixed some extra indentation and added a lot more information in the commit message." [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [13:59:59] (03PS4) 10Hashar: Extract publishers for analytics and wikidata release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651755 (owner: 10Gehel) [14:38:46] (03CR) 10Gehel: "lgtm" [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [14:38:59] (03CR) 10Gehel: [C: 03+1] Align analytics and WDQS release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [14:39:30] (03CR) 10Gehel: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/651755 (owner: 10Gehel) [14:40:11] hashar: si tu veux merger quelques config JJB, je suis part là pour encore 1h ou 2 [14:40:27] gehel: ouep. Avec Google Meet ? [14:46:02] hashar: https://meet.google.com/tmy-ehaj-xdt [14:46:32] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10git-protocol-v2: Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) There seems to be a memory leak with jetty sessions: {P13625} There is really no reaso... [15:02:51] (03CR) 10Hashar: "Jobs updated:" [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [15:08:20] (03CR) 10Hashar: [C: 03+2] Align analytics and WDQS release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [15:09:37] (03Merged) 10jenkins-bot: Align analytics and WDQS release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651540 (owner: 10Gehel) [15:14:58] (03CR) 10Hashar: [C: 03+2] "Paired with Guillaume. I have updated analytics-refinery-update-jars-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/651755 (owner: 10Gehel) [15:16:08] (03Merged) 10jenkins-bot: Extract publishers for analytics and wikidata release builds. [integration/config] - 10https://gerrit.wikimedia.org/r/651755 (owner: 10Gehel) [15:16:46] (03CR) 10Hashar: "I might introduce another change to just rename the job, that will make this change diff cleaner :) There is a trivial merge conflict due" [integration/config] - 10https://gerrit.wikimedia.org/r/651759 (owner: 10Gehel) [15:21:29] (03PS1) 10Gehel: Maven release jobs are no longer parameterized on git user. [integration/config] - 10https://gerrit.wikimedia.org/r/651777 [15:21:42] (03CR) 10jerkins-bot: [V: 04-1] Maven release jobs are no longer parameterized on git user. [integration/config] - 10https://gerrit.wikimedia.org/r/651777 (owner: 10Gehel) [15:24:00] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: selenium-daily-beta-MediaWiki Jenkins job fails with `Autoblocked because your IP address was recently used by "JonelleMaier71"` - https://phabricator.wikimedia.org/T250166 (10zeljkofili... [15:24:54] 10Beta-Cluster-Infrastructure, 10Beta-Cluster-reproducible, 10User-Ryasmeen, 10User-zeljkofilipin: Beta Cluster is down - https://phabricator.wikimedia.org/T267551 (10zeljkofilipin) [15:26:05] (03PS1) 10Hashar: jjb: move {name}-maven-release-docker to job-templates [integration/config] - 10https://gerrit.wikimedia.org/r/651779 [15:26:11] 10Beta-Cluster-Infrastructure, 10MediaWiki-Core-Testing, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, and 3 others: Login to at least en.wikipedia.beta.wmflabs.org and commons.wikimedia.beta.wmflabs.org sometimes fails with `There seems to... - https://phabricator.wikimedia.org/T243123 [15:26:27] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Quality-and-Test-Engineering-Team (QTE), and 2 others: selenium-daily-* Jenkins jobs fail with `fatal: Refusing... - https://phabricator.wikimedia.org/T256759 [15:29:57] CI seems a bit backlogged atm :/ [15:31:56] https://integration.wikimedia.org/zuul/ is pretty quiet [15:32:08] https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&from=now-1h&to=now [15:32:34] a lot in queued which should be presumably running due to having the workers... [15:32:45] 10Continuous-Integration-Config, 10Toolhub, 10translatewiki.net, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Add Toolhub to translatewiki.net - https://phabricator.wikimedia.org/T269469 (10abi_) [15:33:07] 10Continuous-Integration-Config, 10Toolhub, 10translatewiki.net, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Add Toolhub to translatewiki.net - https://phabricator.wikimedia.org/T269469 (10abi_) Toolhub is now available on Translatewiki.net for translation: https://translatewiki... [15:33:47] (03PS1) 10Gehel: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 [15:34:12] (03PS2) 10Gehel: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 [15:35:43] cdanis: Reedy checking [15:35:54] 10Continuous-Integration-Config, 10Toolhub, 10translatewiki.net, 10Language-Team (Language-2020-October-December), 10Patch-For-Review: Add Toolhub to translatewiki.net - https://phabricator.wikimedia.org/T269469 (10abi_) [15:36:33] cdanis: Reedy: it is busy doing bunch of merges [15:37:10] (03PS3) 10Gehel: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 [15:37:34] (03CR) 10jerkins-bot: [V: 04-1] Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [15:38:07] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [15:40:55] cdanis: Reedy: CI was simply busy processing a large chunk of changes send to operations/puppet [15:41:58] (03PS4) 10Gehel: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 [15:42:20] (03CR) 10jerkins-bot: [V: 04-1] Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [15:46:06] (03PS3) 10Hashar: Standardize on using maven-release-docker for all releases. [integration/config] - 10https://gerrit.wikimedia.org/r/651759 (owner: 10Gehel) [15:46:08] No way of easily telling that tough... [15:48:49] (03CR) 10Hashar: [C: 03+2] jjb: move {name}-maven-release-docker to job-templates [integration/config] - 10https://gerrit.wikimedia.org/r/651779 (owner: 10Hashar) [15:50:21] 10MediaWiki-Codesniffer, 10Patch-For-Review: UnusedUseStatementSniff leaves behind semicolons - https://phabricator.wikimedia.org/T265740 (10Umherirrender) 05Open→03Resolved p:05Triage→03Low a:03Umherirrender [15:50:50] (03Merged) 10jenkins-bot: jjb: move {name}-maven-release-docker to job-templates [integration/config] - 10https://gerrit.wikimedia.org/r/651779 (owner: 10Hashar) [15:53:12] (03CR) 10Hashar: [C: 03+2] "I have manually renamed the job using the web UI to keep the build history." [integration/config] - 10https://gerrit.wikimedia.org/r/651759 (owner: 10Gehel) [15:53:31] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Operations, 10observability, 10User-DannyS712: Beta cluster logstash down - https://phabricator.wikimedia.org/T268200 (10colewhite) >>! In T268200#6709830, @DannyS712 wrote: > Indeed! But, looking at the errors dashboard (https://logstash-beta.... [15:54:31] (03Merged) 10jenkins-bot: Standardize on using maven-release-docker for all releases. [integration/config] - 10https://gerrit.wikimedia.org/r/651759 (owner: 10Gehel) [15:54:56] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [16:22:22] (03PS1) 10Gehel: Remove dependency on Maven binaries and wrapper script. [integration/config] - 10https://gerrit.wikimedia.org/r/651791 [16:22:45] (03CR) 10jerkins-bot: [V: 04-1] Remove dependency on Maven binaries and wrapper script. [integration/config] - 10https://gerrit.wikimedia.org/r/651791 (owner: 10Gehel) [16:23:16] (03PS2) 10Hashar: Maven release jobs are no longer parameterized on git user. [integration/config] - 10https://gerrit.wikimedia.org/r/651777 (owner: 10Gehel) [16:26:43] (03CR) 10Hashar: [C: 03+2] "Noop in JJB well done!" [integration/config] - 10https://gerrit.wikimedia.org/r/651777 (owner: 10Gehel) [16:26:58] (03CR) 10Gehel: [C: 04-1] "needs more testing" [integration/config] - 10https://gerrit.wikimedia.org/r/651791 (owner: 10Gehel) [16:28:06] (03Merged) 10jenkins-bot: Maven release jobs are no longer parameterized on git user. [integration/config] - 10https://gerrit.wikimedia.org/r/651777 (owner: 10Gehel) [16:40:43] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10cloud-services-team (Kanban): Request increased RAM for deployment-puppetdb03 in deployment-prep Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10Andrew) a:03nskaggs [16:44:14] (03PS2) 10Gehel: Remove dependency on Maven binaries and wrapper script. [integration/config] - 10https://gerrit.wikimedia.org/r/651791 [16:44:33] (03CR) 10jerkins-bot: [V: 04-1] Remove dependency on Maven binaries and wrapper script. [integration/config] - 10https://gerrit.wikimedia.org/r/651791 (owner: 10Gehel) [16:46:21] (03PS5) 10Hashar: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [16:52:12] (03CR) 10Nray: [V: 03+2 C: 03+2] Edit Repo Config - rebase if necessary [wvui] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651219 (owner: 10DannyS712) [16:56:01] (03PS6) 10Hashar: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [16:56:10] (03CR) 10Hashar: Add the maven-release job to search and discovery projects. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [16:56:25] 10LibUp, 10phan, 10phan-taint-check-plugin, 10Upstream: Have some fixers for Phan issues so that LibUp patches aren't so much work for humans - https://phabricator.wikimedia.org/T270751 (10Daimona) This is probably quite complex in most cases. There are just a handful of issues that can be safely fixed aut... [16:57:34] (03CR) 10Hashar: [C: 03+2] "Paired it with Guillaume. That is so nice!!! Jobs created:" [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [16:59:03] (03Merged) 10jenkins-bot: Add the maven-release job to search and discovery projects. [integration/config] - 10https://gerrit.wikimedia.org/r/651782 (owner: 10Gehel) [17:49:08] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10cloud-services-team (Kanban): Request increased RAM for deployment-puppetdb03 in deployment-prep Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10nskaggs) This was discussed and approved in the 2020-12-23 meeting. [18:07:54] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10incubator.wikimedia.org, 10I18n: Allow creating an independent "incubator wiki" instead of hosting all new wikis in one Incubator wiki with prefixes - https://phabricator.wikimedia.org/T228745 (10Yupik) >>! In T228745#6707... [18:24:46] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Language-strategy, 10incubator.wikimedia.org, and 2 others: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Amire80) [18:25:30] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10incubator.wikimedia.org, 10I18n: Allow creating an independent "incubator wiki" instead of hosting all new wikis in one Incubator wiki with prefixes - https://phabricator.wikimedia.org/T228745 (10Amire80) [18:40:47] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10incubator.wikimedia.org, 10I18n: Allow creating an independent "incubator wiki" instead of hosting all new wikis in one Incubator wiki with prefixes - https://phabricator.wikimedia.org/T228745 (10Amire80) >>! In T228745#67... [18:42:04] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10incubator.wikimedia.org, 10I18n: Allow creating an independent "incubator wiki" instead of hosting all new wikis in one Incubator wiki with prefixes - https://phabricator.wikimedia.org/T228745 (10C933103) > and this must b... [18:53:44] 10Beta-Cluster-Infrastructure, 10Developer Productivity, 10Patch-For-Review, 10Puppet: puppetdb on deployment-puppetdb03 keeps getting OOMKilled - https://phabricator.wikimedia.org/T248041 (10nskaggs) [18:53:59] 10Beta-Cluster-Infrastructure, 10Cloud-VPS, 10cloud-services-team (Kanban): Request increased RAM for deployment-puppetdb03 in deployment-prep Cloud VPS project - https://phabricator.wikimedia.org/T270420 (10nskaggs) 05Open→03Resolved Instance has been updated. [19:02:44] 10Release-Engineering-Team (Pipeline), 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Deployment Pipeline setup - https://phabricator.wikimedia.org/T265893 (10Etonkovidova) 05Open→03Resolved Checked [[ https://integration.wikimedia.or... [19:08:26] (03PS1) 10Legoktm: [operations/software/klaxon] Configure tox [integration/config] - 10https://gerrit.wikimedia.org/r/651819 [19:21:44] 10LibUp, 10phan, 10phan-taint-check-plugin, 10Upstream: Have some fixers for Phan issues so that LibUp patches aren't so much work for humans - https://phabricator.wikimedia.org/T270751 (10Legoktm) Would having libup automatically insert `// @phan-suppress-next-line {whatever}` comments be helpful? >>! In... [19:45:11] (03PS1) 10Jforrester: Zuul: [mediawiki/tools/dependency-analysis] Add composer test CI [integration/config] - 10https://gerrit.wikimedia.org/r/651826 [19:46:48] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/tools/dependency-analysis] Add composer test CI [integration/config] - 10https://gerrit.wikimedia.org/r/651826 (owner: 10Jforrester) [19:47:55] (03Merged) 10jenkins-bot: Zuul: [mediawiki/tools/dependency-analysis] Add composer test CI [integration/config] - 10https://gerrit.wikimedia.org/r/651826 (owner: 10Jforrester) [19:48:20] !log Zuul: [mediawiki/tools/dependency-analysis] Add composer test CI [19:48:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:33:04] 10LibUp: libup fails on npm audit fix not providing the actions key - https://phabricator.wikimedia.org/T269520 (10Legoktm) I've observed the `npm audit` endpoint regularly failing to return results, maybe we're hitting some limits or it's just buggy. We should probably just add a check `'actions' in audit` befo... [20:36:43] (03PS2) 10Legoktm: [operations/software/klaxon] Configure tox [integration/config] - 10https://gerrit.wikimedia.org/r/651819 (https://phabricator.wikimedia.org/T270790) [20:36:48] (03CR) 10CDanis: [C: 03+1] "thanks!!" [integration/config] - 10https://gerrit.wikimedia.org/r/651819 (https://phabricator.wikimedia.org/T270790) (owner: 10Legoktm) [20:37:07] (03CR) 10VolkerE: "@DannyS712 I like the idea, if I understand it correctly (w Nray's feedback). Do we have this enabled in other repos? If not, why?" [wvui] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651219 (owner: 10DannyS712) [20:37:16] (03PS3) 10Legoktm: [operations/software/klaxon] Configure tox [integration/config] - 10https://gerrit.wikimedia.org/r/651819 (https://phabricator.wikimedia.org/T270790) [20:37:21] (03CR) 10Legoktm: [C: 03+2] [operations/software/klaxon] Configure tox [integration/config] - 10https://gerrit.wikimedia.org/r/651819 (https://phabricator.wikimedia.org/T270790) (owner: 10Legoktm) [20:38:37] (03Merged) 10jenkins-bot: [operations/software/klaxon] Configure tox [integration/config] - 10https://gerrit.wikimedia.org/r/651819 (https://phabricator.wikimedia.org/T270790) (owner: 10Legoktm) [20:38:56] 10LibUp, 10phan, 10phan-taint-check-plugin, 10Upstream: Have some fixers for Phan issues so that LibUp patches aren't so much work for humans - https://phabricator.wikimedia.org/T270751 (10Daimona) >>! In T270751#6710832, @Legoktm wrote: > Would having libup automatically insert `// @phan-suppress-next-lin... [20:40:18] !log deploying https://gerrit.wikimedia.org/r/651819 [20:40:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:41:34] that's... odd [20:41:51] I feel like that is what `skip_missing_interpreters` is *for* [20:42:27] I think I used the wrong image [20:42:32] stretch instead of buster [20:43:36] James_F: it looks like tox-docker is still on stretch? [20:43:44] https://integration.wikimedia.org/ci/job/tox-docker/16039/console [20:44:39] Umm. [20:44:42] Didn't I switch? [20:45:06] I see it in git, but maybe not pushed to jenkins? [20:45:26] Maybe hashar over-wrote my jjb changes somehow? [20:45:35] It was definitely switched. [20:45:36] I manually checked each damn one. [20:45:48] https://integration.wikimedia.org/ci/job/tox-docker/jobConfigHistory/ [20:45:53] We could just rebuild jjb *, but if there are local hacks… [20:46:16] Huh. [20:46:20] local hacks? in wikimedia? [20:46:22] I guess I missed it somehow. [20:46:25] Reedy: Inorite. [20:46:58] I just pushed tox-docker for now [20:47:18] Yeah. Thanks. [20:47:20] Fixed? [20:47:44] yep [20:47:55] Grand. [20:51:23] legoktm: Note that the cumin jobs silently broke when I migrated them, so I migrated them back. [20:51:40] And all of the sub-images need migrating. I tried it with striker and that didn't work, in an odd way. :-( [20:51:51] I only pushed tox-docker [20:52:05] I can look into cumin later, we might want that one tested on both stretch & buster for a while [20:52:55] Ack. [20:59:07] 10LibUp, 10phan, 10phan-taint-check-plugin, 10Upstream: Have some fixers for Phan issues so that LibUp patches aren't so much work for humans - https://phabricator.wikimedia.org/T270751 (10Legoktm) >>! In T270751#6710959, @Daimona wrote: >>>! In T270751#6710832, @Legoktm wrote: >> Would having libup automa... [21:30:50] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [wikimedia/fundraising/crm/civiproxy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651841 [21:30:53] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [wikimedia/fundraising/crm/civiproxy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651841 (owner: 10QChris) [21:31:05] (03PS1) 10QChris: Import done. Revoke import grants [wikimedia/fundraising/crm/civiproxy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651842 [21:31:08] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [wikimedia/fundraising/crm/civiproxy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/651842 (owner: 10QChris) [22:59:27] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) [23:01:03] James_F: I filed https://phabricator.wikimedia.org/T270795 for cumin [23:01:29] I'm running it locally to see if I can get more useful output past the 20 minute timeout