[00:08:29] libup running against REL1_31 is *extremely* slow because there's no package-lock.json file. what a world we used to live in [00:13:17] https://libraryupgrader2.wmcloud.org/errors?branch=REL1_31 fwiw [04:54:09] 10Continuous-Integration-Config: Bundlesize should not be cause V-1 when size increases by a few bytes - https://phabricator.wikimedia.org/T270883 (10Ammarpad) It could even fail, and give V-1, when the change is so insignificant to the extent that we end up with strange error due to rounding, see {T268593}. I d... [05:13:44] 10LibUp, 10Front-end-Standards-Group: LibUp should automatically re-write .eslintrc.json files into the new .eslint.config.js format when using an appropriate (forthcoming) version of eslint - https://phabricator.wikimedia.org/T267941 (10Legoktm) 05Open→03Stalled Please unstall once this is ready for imple... [05:16:44] 10LibUp, 10MediaWiki-extensions-CentralNotice: libup does not commit proposed patch set to gerrit for repo CentralNotice - https://phabricator.wikimedia.org/T264234 (10Legoktm) 05Open→03Resolved a:03Legoktm I noticed this last night when debugging other stuff, the problem used to be that it would clone t... [05:18:47] 10LibUp, 10UI-Standardization: Auto re-configure stylelint to lint vue files too - https://phabricator.wikimedia.org/T264252 (10Legoktm) So is the proposal to have libup find stuff like https://codesearch.wmcloud.org/search/?q=%5C*%5C*%2F%5C*.%5C%7Bcss%2Cless%5C%7D&i=nope&files=&repos= and add `vue` unconditio... [05:21:34] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Legoktm) 05Open→03Stalled At this time LibUp is going to continue using the nodejs version in whichever apt packages are convenient. Given that this only an issue fo... [05:24:57] 10LibUp: Automatically clean up the parallel-lint command in composer.json files - https://phabricator.wikimedia.org/T266305 (10Legoktm) https://codesearch.wmcloud.org/search/?q=parallel-lint%20.&i=nope&files=%5Ecomposer.json%24&repos= There are also a few that don't exclude `node_modules`, though those might b... [05:32:02] 10LibUp: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Legoktm) The data gathering and upgrading phases are pretty linked, I think we should just add those two repos back to the config and let them fail at updating (or miraculously wo... [05:33:56] 10LibUp, 10Patch-For-Review: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Legoktm) 05Open→03Resolved a:03Legoktm Should show up in the next 24-48 hours. [05:35:02] 10LibUp: Move libup data storage into mysql - https://phabricator.wikimedia.org/T241035 (10Legoktm) 05Open→03Resolved a:03Legoktm [05:35:04] 10LibUp: libup2: Error 502: cannot see individual repository details - https://phabricator.wikimedia.org/T238136 (10Legoktm) [05:35:06] 10LibUp: libup move celery workers to another instance - https://phabricator.wikimedia.org/T228197 (10Legoktm) [05:47:12] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Legoktm) a:03Legoktm I took the long route on this and tried to refactor everything along the way...but I think it's paid off. Just about everything on the web interface https://libraryupgrader2.w... [05:48:07] 10LibUp: libup run of repo Popups fails on npm test with warnings - https://phabricator.wikimedia.org/T243788 (10Legoktm) [05:48:08] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Legoktm) [05:49:42] 10LibUp, 10WikibaseMediaInfo, 10Patch-For-Review: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies - https://phabricator.wikimedia.org/T243787 (10Legoktm) >>! In T243787#6309557, @matthiasmullie wrote: > That said, if it's causing issues elsewhere, we can pin it to a spe... [05:55:47] 10LibUp: libup should set warnings to off in .eslintrc.json when using maxWarnings: 0 - https://phabricator.wikimedia.org/T263922 (10Legoktm) https://codesearch.wmcloud.org/search/?q=maxWarnings&i=nope&files=Gruntfile.js&repos= looks like just two repos have this option right now. [06:01:40] 10LibUp: 502 Bad Gateway on https://libraryupgrader2.wmcloud.org/ - https://phabricator.wikimedia.org/T262228 (10Legoktm) 05Open→03Resolved [06:04:28] 10LibUp: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Legoktm) >>! In T262221#6441331, @Esanders wrote: > Specifically, since ESLint 7.0, configs can now set which extensions should be linted, so it doesn't need to... [06:14:32] 10LibUp: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Legoktm) Hmm, https://github.com/wikimedia/eslint-config-wikimedia/pull/318#issuecomment-692089763 isn't in a release version yet - is that a prerequisite for d... [06:21:50] 10LibUp, 10phan: Teach LibUp how to migrate to new phan using ConfigBuilder - https://phabricator.wikimedia.org/T254571 (10Legoktm) @Daimona: is this ready to be implemented with the current version of mediawiki-phan-config? What's the minimum version that phan needs to be at before this can be used? [06:37:37] 10Continuous-Integration-Config, 10LibUp, 10Composer, 10Security: Investigate switching PHP security checks to use packagist's new API endpoint - https://phabricator.wikimedia.org/T258291 (10Legoktm) 05Open→03Declined The endpoint doesn't actually do what we need... :( [06:44:30] 10LibUp: libup sometimes cannot update to eslint-config-wikimedia because new errors not added to .eslintrc.json as warning - https://phabricator.wikimedia.org/T262450 (10Legoktm) How are we supposed to figure out which file it should be disabled in? Should we just add it to the closest `.eslintrc.json` and hope... [06:46:46] 10LibUp: libup fails to update eslint-config-wikimedia to 0.17.0 due to old eslint - https://phabricator.wikimedia.org/T261520 (10Legoktm) I believe this is taken care of now that we manually force the bumping of eslint, is that correct? [06:51:24] 10LibUp, 10Patch-For-Review: Puppetize setup on upgrader-06.wmflabs - https://phabricator.wikimedia.org/T173478 (10Legoktm) 05Open→03Resolved Pretty sure this was all finished. [07:03:48] 10LibUp: libraryupgrader web ui should mark libs also as "Wikimedia-deployed" - https://phabricator.wikimedia.org/T256635 (10Legoktm) It would be really nice if this could be implemented by adding to https://gerrit.wikimedia.org/r/plugins/gitiles/integration/utils/+/refs/heads/master/wikimediaci_utils/__init__.p... [07:04:52] 10LibUp: Keep the list of packages in libup web when clone fails - https://phabricator.wikimedia.org/T255183 (10Legoktm) 05Open→03Resolved a:03Legoktm This is not a problem in the new database backend because we just won't replace the existing dependency list if the clone fails. [07:07:10] 10LibUp: implement php security scanning in libup - https://phabricator.wikimedia.org/T228108 (10Legoktm) 05Stalled→03Resolved a:03Legoktm Said case appeared: https://libraryupgrader2.wmcloud.org/vulns/composer [07:08:35] 10LibUp: Make a bot to bump our trivial-but-with-security-warnings Ruby CI dependency chain - https://phabricator.wikimedia.org/T181576 (10Legoktm) Is this still needed? For what it's worth, adding a new language/package manager should be much easier now... [07:16:32] 10LibUp: Why libup does not run update of jakub-onderka/php-console-highlighter and mediawiki/minus-x as bundle? - https://phabricator.wikimedia.org/T243862 (10Legoktm) 05Open→03Resolved a:03Legoktm The new configuration system has weights will allow for making sure this happens. Each update in the config... [07:19:22] 10LibUp: libup: Add some form of monitoring or a status page - https://phabricator.wikimedia.org/T229519 (10Legoktm) 05Open→03Resolved a:03Legoktm I'm OK with what's been added so far. We don't monitor the ssh-agent because I don't want the web server to have access to it at all. [07:23:34] 10LibUp: libup move celery workers to another instance - https://phabricator.wikimedia.org/T228197 (10Legoktm) 05Stalled→03Declined {F33977278} This really isn't an issue anymore. [07:23:48] 10LibUp: When bumping devDeps but everything already passes, add a positive message - https://phabricator.wikimedia.org/T195934 (10Legoktm) I don't know what to do with this request. [09:15:44] 10Gerrit, 10Upstream: Use user-select: none for line numbers in Gitiles - https://phabricator.wikimedia.org/T188172 (10Nikerabbit) I cannot reproduce. Fixed? [09:17:23] 10Gerrit: Gitiles does not provide raw view of the file for copy-pasting - https://phabricator.wikimedia.org/T270903 (10Nikerabbit) [09:48:05] 10Gerrit: Gitiles does not provide raw view of the file for copy-pasting (txt download is base64 encoded) - https://phabricator.wikimedia.org/T270903 (10Aklapper) [09:51:19] 10Gerrit, 10Upstream: Use user-select: none for line numbers in Gitiles - https://phabricator.wikimedia.org/T188172 (10Aklapper) 05Open→03Resolved Indeed, this looks fixed [11:16:17] (03PS1) 10Majavah: New sniff: `MissingControlStructureBetweenBracketsSniff` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) [11:16:54] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-Majavah: Create PHPCS/ESLint rule to disallow `if else` blocks with an unnamed block likely intended as `else` - https://phabricator.wikimedia.org/T186939 (10Majavah) a:03Majavah [13:31:07] 10phabricator maintenance bot, 10Wikibugs: Don't notify actions by @Phabricator_maintenance - https://phabricator.wikimedia.org/T141570 (10Nintendofan885) [13:32:15] 10Phabricator, 10phabricator maintenance bot: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [13:32:46] 10Phabricator (Upstream), 10phabricator maintenance bot, 10Upstream: Need a way to disable web notifications from certain accounts (phabricator_maintenance) - https://phabricator.wikimedia.org/T142918 (10Nintendofan885) [13:35:53] 10Phabricator, 10phabricator maintenance bot: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [14:13:38] 10LibUp, 10Documentation: Document weight - https://phabricator.wikimedia.org/T270908 (10Reedy) [14:49:16] 10LibUp, 10Documentation: Document weight - https://phabricator.wikimedia.org/T270908 (10Reedy) [15:34:52] 10Phabricator: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [15:35:53] 10Phabricator (Upstream), 10Upstream: Need a way to disable web notifications from certain accounts (phabricator_maintenance) - https://phabricator.wikimedia.org/T142918 (10Nintendofan885) [15:36:03] 10Phabricator: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [16:10:05] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Aklapper) >>! In T108586#6711982, @Ladsgroup wrote: > @Aklapper Hey, is it fine if we move the group 4 herald rules to maintenance bot? Is there any general info av... [17:18:45] 10Beta-Cluster-Infrastructure, 10Wikidata, 10Wikidata-Campsite, 10Regression, and 2 others: A revision of https://wikidata.beta.wmflabs.org/wiki/Q64 consistently doesn't load on beta wikidata - https://phabricator.wikimedia.org/T249018 (10Majavah) I can't reproduce this anymore - can this be closed? [17:26:39] (03PS2) 10Majavah: New sniff: `MissingControlStructureBetweenBracketsSniff` [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) [20:27:56] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Umherirrender) The extra {} are not used on mediawiki code style (at least on single tags) and therefor not detected as valid tag. [20:34:46] (03CR) 10DannyS712: ""ControlStructure" is just a fancy way of saying "else" in this case, right? Since the sniff's full name already includes ControlStructure" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [20:35:23] (03PS1) 10Umherirrender: Handle possible whitespace on license names [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652409 [20:36:00] (03CR) 10DannyS712: New sniff: `MissingControlStructureBetweenBracketsSniff` (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [20:38:44] 10MediaWiki-Codesniffer: phpcs ObjectTypeHintParam is incorrect. - https://phabricator.wikimedia.org/T269332 (10Umherirrender) Various extensions get fixed in the past weeks https://codesearch.wmcloud.org/search/?q=ObjectTypeHint&i=nope&files=&repos= Some libs are not fixable, because there are valid use cases... [20:42:01] (03CR) 10DannyS712: [C: 03+1] Handle possible whitespace on license names [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652409 (owner: 10Umherirrender) [20:45:29] (03CR) 10Majavah: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [21:05:10] (03PS1) 10Umherirrender: Allow parenthesis as punction on @var types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652414 (https://phabricator.wikimedia.org/T268087) [21:05:36] 10MediaWiki-Codesniffer, 10Patch-For-Review: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType - https://phabricator.wikimedia.org/T268087 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [21:08:56] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10User-DannyS712: Create sniff for `match` errors in PHP 8.0 - https://phabricator.wikimedia.org/T267689 (10Umherirrender) `php -l`/parallel-lint would fail when running with php8 - but the newer versions are not running as part of the normal pipeline and in the pa... [21:47:16] (03PS1) 10Umherirrender: Forbid compact() as opposite of forbidden extract() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 [21:50:20] (03CR) 10Umherirrender: "Usage:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 (owner: 10Umherirrender) [21:56:29] (03CR) 10DannyS712: [C: 03+1] Forbid compact() as opposite of forbidden extract() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652415 (owner: 10Umherirrender) [22:11:01] (03CR) 10Hashar: [C: 04-1] "doc1001 is still on Debian Stretch with php7.0. Guess we can look at moving it to php 7.2 like the MediaWiki app servers or align it with " [integration/docroot] - 10https://gerrit.wikimedia.org/r/651195 (owner: 10Jforrester) [22:12:33] 10phan-taint-check-plugin: taint-check does not support compact() - https://phabricator.wikimedia.org/T270927 (10Umherirrender) [22:32:16] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Upstream: Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) a:03hashar