[00:01:33] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: Enable seccheck for MW core - https://phabricator.wikimedia.org/T231311 (10Jdforrester-WMF) Do we want to keep this open for the tree of sub-tasks? [00:15:44] (03CR) 10Jforrester: [C: 03+2] "Deployed, repo has been fixed by volans." [integration/config] - 10https://gerrit.wikimedia.org/r/651293 (owner: 10Jforrester) [00:17:41] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [00:25:29] (03CR) 10jerkins-bot: [V: 04-1] jjb: Switch cumin jobs from tox to tox-buster image [integration/config] - 10https://gerrit.wikimedia.org/r/651293 (owner: 10Jforrester) [00:25:42] Huh. [00:26:51] (03CR) 10Jforrester: [C: 03+2] "…" [integration/config] - 10https://gerrit.wikimedia.org/r/651293 (owner: 10Jforrester) [00:29:11] (03Merged) 10jenkins-bot: jjb: Switch cumin jobs from tox to tox-buster image [integration/config] - 10https://gerrit.wikimedia.org/r/651293 (owner: 10Jforrester) [00:52:03] 10LibUp: Have LibUp track (but not try to upgrade) mediawiki/core and mediawiki/vendor - https://phabricator.wikimedia.org/T268086 (10Jdforrester-WMF) Thanks! [01:00:19] (03PS1) 10Jforrester: dockerfiles: [tox-censorshipmonitoring] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652636 [01:00:21] (03PS1) 10Jforrester: jjb: [censorshipmonitoring-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652637 [01:01:34] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [tox-censorshipmonitoring] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652636 (owner: 10Jforrester) [01:02:50] (03Merged) 10jenkins-bot: dockerfiles: [tox-censorshipmonitoring] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652636 (owner: 10Jforrester) [01:04:41] !log Docker: Building and publishing tox-censorshipmonitoring:0.1.1 [01:04:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:10:03] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Jdforrester-WMF) Oops, yeah, a number of changes were done blindly because "all repos have version xyz now", and now we support branches those assumptions aren't safe… [01:12:00] 10LibUp, 10Patch-For-Review: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Jdforrester-WMF) >>! In T262221#6713442, @Legoktm wrote: > Hmm, https://github.com/wikimedia/eslint-config-wikimedia/pull/318#issuecomment... [01:13:11] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/652637 (owner: 10Jforrester) [01:14:33] (03Merged) 10jenkins-bot: jjb: [censorshipmonitoring-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652637 (owner: 10Jforrester) [01:17:32] (03PS1) 10Jforrester: dockerfiles: [tox-conftool] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652640 [01:17:34] (03PS1) 10Jforrester: jjb: [conftool-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652641 [01:17:57] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [tox-conftool] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652640 (owner: 10Jforrester) [01:19:20] (03Merged) 10jenkins-bot: dockerfiles: [tox-conftool] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652640 (owner: 10Jforrester) [01:19:41] !log Docker: Building and publishing tox-conftool:0.4.1 [01:19:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:25:08] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/652641 (owner: 10Jforrester) [01:26:35] (03Merged) 10jenkins-bot: jjb: [conftool-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652641 (owner: 10Jforrester) [01:34:53] (03PS1) 10Jforrester: dockerfiles: [tox-eventlogging] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652642 [01:34:55] (03PS1) 10Jforrester: jjb: [eventlogging-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652643 [01:34:57] (03PS1) 10Jforrester: dockerfiles: [tox-homer] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652644 [01:34:59] (03PS1) 10Jforrester: jjb: Migrate homer jobs to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652645 [01:35:08] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [tox-eventlogging] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652642 (owner: 10Jforrester) [01:36:18] (03Merged) 10jenkins-bot: dockerfiles: [tox-eventlogging] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652642 (owner: 10Jforrester) [01:36:37] !log Docker: Building and publishing tox-eventlogging:0.4.1 [01:36:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:41:22] * James_F sighs at FR-tech DoSing CI. [01:42:21] that's... quite a chain [01:42:27] Yeah. [01:42:49] I'm just switching stretch-based tox jobs over to buster, nothing urgent, but… [01:43:31] (03CR) 10Jforrester: [C: 03+2] jjb: [eventlogging-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652643 (owner: 10Jforrester) [01:44:44] (03Merged) 10jenkins-bot: jjb: [eventlogging-tox-docker] Migrate to buster-based image [integration/config] - 10https://gerrit.wikimedia.org/r/652643 (owner: 10Jforrester) [01:45:06] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [tox-homer] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652644 (owner: 10Jforrester) [01:46:17] (03Merged) 10jenkins-bot: dockerfiles: [tox-homer] Migrate to tox-buster [integration/config] - 10https://gerrit.wikimedia.org/r/652644 (owner: 10Jforrester) [01:47:18] !log Docker: Building and publishing tox-homer:0.1.1 [01:47:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:16:19] (03CR) 10Jforrester: [C: 04-1] "T270969" [integration/config] - 10https://gerrit.wikimedia.org/r/652645 (owner: 10Jforrester) [02:18:59] 10LibUp: When bumping devDeps but everything already passes, add a positive message - https://phabricator.wikimedia.org/T195934 (10Jdforrester-WMF) >>! In T195934#6713476, @Legoktm wrote: > I don't know what to do with this request. Something like "Your code is already conformant, well done!"? Eh. [02:49:42] 10LibUp: Automatically clean up the parallel-lint command in composer.json files - https://phabricator.wikimedia.org/T266305 (10Jdforrester-WMF) Sounds good. [02:52:06] 10LibUp: Make a bot to bump our trivial-but-with-security-warnings Ruby CI dependency chain - https://phabricator.wikimedia.org/T181576 (10Jdforrester-WMF) Given https://codesearch.wmcloud.org/search/?q=gem&i=nope&files=Gemfile&repos= I guess we can skip? Eh. [03:01:40] 10LibUp: Update ockcyp/covers-validator - https://phabricator.wikimedia.org/T270863 (10Jdforrester-WMF) 05Open→03Resolved a:03Reedy [06:15:27] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [06:57:01] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Testing: Coverage report wrongly marks some lines of a multi-line function call as uncovered - https://phabricator.wikimedia.org/T205812 (10Krinkle) 05Open→03Resolved a:03Krinkle [06:57:39] 10Gerrit: Gerrit is giving tips on how to write comments, make sure it does not send our comments to some third party - https://phabricator.wikimedia.org/T258102 (10Lillianooper) On this blog, people write many types of comments, some comments base on information, some are promotional or some are based on links,... [07:27:03] (03PS1) 10BrandonXLF: Adds Tests for Extension:TemplateScripts [integration/config] - 10https://gerrit.wikimedia.org/r/652665 [07:28:38] (03PS2) 10BrandonXLF: Add Tests for Extension:TemplateScripts [integration/config] - 10https://gerrit.wikimedia.org/r/652665 [07:33:33] ^disabled the phab spammer [08:40:12] follow up to that: phab admins, please remove https://phabricator.wikimedia.org/T258102#6715205, thanks [09:02:54] Majavah, p858snake: done [09:03:02] thanks legoktm [09:04:38] i find it hilarious they keep targeting the same task with that same spam [09:06:41] honeypots are nice [09:12:41] 10LibUp: Make a bot to bump our trivial-but-with-security-warnings Ruby CI dependency chain - https://phabricator.wikimedia.org/T181576 (10Legoktm) 05Open→03Declined Yeah, not worth it for 6 repos (minus the ones that are using it for puppet stuff). [09:55:58] I think my biggest fear is that the REL1_31 libup patches are going to fail jenkins for tons of unrelated reasons [10:03:28] 10phan-taint-check-plugin, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05): taint-check 3.1.0 showing more issues from type SecurityCheck-OTHER - https://phabricator.wikimedia.org/T268920 (10Daimona) 05Open→03Resolved a:03Umherirrender [10:03:32] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), and 2 others: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Daimona) [10:06:37] 10LibUp, 10Patch-For-Review: libup could remove eslint.options.extensions from Gruntfile.js for newer eslint-config-wikimedia - https://phabricator.wikimedia.org/T262221 (10Legoktm) 05Open→03Resolved a:03Legoktm [10:11:57] (03CR) 10Umherirrender: [C: 03+2] Make use of PHPUnitTestTrait in more sniffs (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [10:13:27] (03Merged) 10jenkins-bot: Make use of PHPUnitTestTrait in more sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650189 (owner: 10DannyS712) [10:15:05] 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10Security-Team, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), and 2 others: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Umherirrender) 05Open→03Resolved [10:15:08] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing: Configure CI to run phan-taint-check-plugin for MediaWiki core - https://phabricator.wikimedia.org/T203630 (10Umherirrender) [10:15:11] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: Enable seccheck for MW core - https://phabricator.wikimedia.org/T231311 (10Umherirrender) [11:11:44] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: Enable seccheck for MW core - https://phabricator.wikimedia.org/T231311 (10Umherirrender) >>! In T231311#6715024, @Jdforrester-WMF wrote: > Do we want to... [11:16:49] 10Release-Engineering-Team, 10Wikimedia-Site-requests: Temporarily change logo on the Finnish Wikipedia - https://phabricator.wikimedia.org/T270974 (10Majavah) Tagging RelEng since due to the holiday deployment freeze it's up to them to decide if this can be done. [11:19:17] hi releng - can T270974 be actioned during the holiday deployment freezes? [11:19:17] T270974: Temporarily change logo on the Finnish Wikipedia - https://phabricator.wikimedia.org/T270974 [11:20:00] 10Release-Engineering-Team, 10Wikimedia-Site-requests: Temporarily change logo on the Finnish Wikipedia - https://phabricator.wikimedia.org/T270974 (10RhinosF1) >>! In T270974#6715299, @Majavah wrote: > Tagging RelEng since due to the holiday deployment freeze it's up to them to decide if this can be done. Th... [11:20:25] Majavah: next window would be Monday anyway and it should be over then [11:20:36] As Friday-Sunday are naturally no deploys [11:21:43] RhinosF1: I'm aware but as fiwiki hit 500k earlier this week I think next monday would be too late [11:21:55] Oh [11:22:32] that's why I'm asking if it can be done today even if we're on holiday freeze as I think that's relatively low risk [11:22:36] Fair enough [11:22:41] Should be low risk [11:22:52] But it's as much a normal break as a holiday [11:23:45] has someone made a patch? [11:23:50] I can if it can be deployed [11:26:48] it's hard for me to make a recommendation/suggestion that said deployment is safe if there's no patch to review :p [11:27:08] if we're just swapping a PNG I think that's fine [11:29:45] Should be just swapping a png ye [11:45:39] legoktm: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/652687 and https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/652688 [11:48:08] Majavah: looks sane to me, and I'm happy to sync it out later today (after I sleep and wake up) if no one else objects [11:48:32] thanks a lot! [11:50:10] 10Release-Engineering-Team, 10Wikimedia-Site-requests, 10Patch-For-Review: Temporarily change logo on the Finnish Wikipedia - https://phabricator.wikimedia.org/T270974 (10Legoktm) The patches look reasonably safe to me, I'm happy to sync them out later today (after I sleep and wake up) if no one else objects... [12:07:18] the full libup run is starting now [12:14:44] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05): Enable seccheck for MW core - https://phabricator.wikimedia.org/T231311 (10Daimona) 05Open→03Resolved a:03Umherirrender >>! In T231311#6715288, @Umherirrender wrote: >>>!... [12:14:47] 10Continuous-Integration-Config, 10phan-taint-check-plugin, 10MediaWiki-Core-Testing, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05): Enable seccheck for MW core - https://phabricator.wikimedia.org/T231311 (10Daimona) [12:17:18] fyi if something goes wrong with libup, it can be emergency disabled: https://gerrit.wikimedia.org/r/plugins/gitiles/labs/libraryupgrader/config/+/refs/heads/master/README [13:38:31] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Aklapper) @Legoktm: Hmm, what exactly is this task stalled on (["If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not... [13:46:14] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phpunit-patch-coverage, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Daimona) [13:48:11] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10phpunit-patch-coverage, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Daimona) p:05Triage→03High FTR, the outdated reports are going... [13:52:00] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Aklapper) Maybe moving some actions to an external place might be workaround to improve performance, but does this potentially complicate making/reverting changes (w... [16:29:55] 10Continuous-Integration-Config, 10Project-Admins: Publish Mirage - https://phabricator.wikimedia.org/T270979 (10Mainframe98) [17:10:03] 10Continuous-Integration-Config, 10Project-Admins: Publish Mirage - https://phabricator.wikimedia.org/T270979 (10Aklapper) Requested public project #MediaWiki-skins-Mirage has been created: https://phabricator.wikimedia.org/tag/mediawiki-skins-mirage/ Interested people are welcome to join the project as {icon... [17:10:11] 10Continuous-Integration-Config, 10Project-Admins: Publish Mirage - https://phabricator.wikimedia.org/T270979 (10Aklapper) [17:10:26] 10Continuous-Integration-Config, 10Project-Admins: Publish Mirage skin - https://phabricator.wikimedia.org/T270979 (10Aklapper) [18:21:21] 10Project-Admins, 10Wikimedia-Extension-setup: "Wikimedia-Extension-setup" and "Wikimedia-Site-Requests" projects overlap - Archive Wikimedia-Extension-setup - https://phabricator.wikimedia.org/T230194 (10Aklapper) p:05Triage→03Low a:03Aklapper [18:22:38] 10Project-Admins, 10Wikimedia-Extension-setup: "Wikimedia-Extension-setup" and "Wikimedia-Site-Requests" projects overlap - Archive Wikimedia-Extension-setup - https://phabricator.wikimedia.org/T230194 (10Aklapper) Eh, though https://phabricator.wikimedia.org/T177471#3660245 ... [18:38:14] 10Project-Admins: Discussing #Wikimedia-Site-requests after #Wiki-Setup creation - https://phabricator.wikimedia.org/T177471 (10Aklapper) Coming here from {T230194}. Current situation: * Top-level parent project #wikimedia-site-requests exists. It has one subproject called #Wiki-Setup. ** #Wiki-Setup has [four m... [19:46:14] (03PS1) 10Mainframe98: zuul: Add CI for the Mirage skin [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) [19:50:00] 10Continuous-Integration-Config, 10Project-Admins, 10MediaWiki-skins-Mirage, 10Patch-For-Review: Publish Mirage skin - https://phabricator.wikimedia.org/T270979 (10Mainframe98) [21:02:29] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Regression, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Krinkle) Indeed, these aren't meant to be enabled for non-master commits. I'm... [22:42:16] (03CR) 10DannyS712: [C: 03+1] "Given the time of year going to wait a bit before merging in case some others didn't have a chance to see this" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [23:59:08] (03CR) 10Jforrester: [C: 03+1] "Seems reasonable. Would like others' views, too." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [23:59:54] (03CR) 10Jforrester: zuul: Add CI for the Mirage skin (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) (owner: 10Mainframe98)