[00:00:39] (03PS3) 10Jforrester: zuul: [mediawiki/extensions/TemplateScripts] Add the full usual CI [integration/config] - 10https://gerrit.wikimedia.org/r/652665 (owner: 10BrandonXLF) [00:00:43] (03CR) 10Jforrester: [C: 03+2] zuul: [mediawiki/extensions/TemplateScripts] Add the full usual CI [integration/config] - 10https://gerrit.wikimedia.org/r/652665 (owner: 10BrandonXLF) [00:01:34] (03PS8) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [00:01:46] (03PS9) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [00:01:58] (03Merged) 10jenkins-bot: zuul: [mediawiki/extensions/TemplateScripts] Add the full usual CI [integration/config] - 10https://gerrit.wikimedia.org/r/652665 (owner: 10BrandonXLF) [00:02:17] (03CR) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [00:02:41] (03PS6) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) [00:03:08] (03PS7) 10DannyS712: New sniff: MediaWiki.PHPUnit.AssertTrue.LiteralTrue [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) [00:03:12] (03CR) 10DannyS712: "updated to use PHPUnitTestTrait" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/647071 (https://phabricator.wikimedia.org/T268509) (owner: 10DannyS712) [00:04:17] James_F I see you're going around reviewing stuff - anything of yours that needs review? [00:32:43] DannyS712: Not right now, but thank you. [04:20:49] 10LibUp, 10Page-Previews, 10Readers-Web-Backlog (Tracking): Update nvm for libup to match CI - https://phabricator.wikimedia.org/T264328 (10Legoktm) >>! In T264328#6715362, @Aklapper wrote: > @Legoktm: Hmm, what exactly is this task stalled on (["If a report is waiting for further input (e.g. from its report... [04:31:37] 10Continuous-Integration-Config: mwext-phpunit-coverage-docker-publish job should only run on patches to the master branch - https://phabricator.wikimedia.org/T270986 (10Legoktm) p:05Triage→03High [04:39:24] 10LibUp: Libup should mention failing eslint rules when adding profiles like wikimedia/mediawiki - https://phabricator.wikimedia.org/T267236 (10Legoktm) a:03Legoktm This is happening a bunch on REL branches, so I'll work on this very soon. [04:42:08] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Regression, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Legoktm) [04:42:11] 10Continuous-Integration-Config: mwext-phpunit-coverage-docker-publish job should only run on patches to the master branch - https://phabricator.wikimedia.org/T270986 (10Legoktm) [04:42:32] 10LibUp, 10Patch-For-Review: Add support for MW branches to LibUp - https://phabricator.wikimedia.org/T236071 (10Legoktm) 05Open→03Resolved It's happening \o/ [04:42:35] 10LibUp, 10MW-1.31-release, 10Patch-For-Review: Bump PHPCS version in REL1_31 extensions - https://phabricator.wikimedia.org/T236070 (10Legoktm) [04:42:37] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10PHP 7.3 support: Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches - https://phabricator.wikimedia.org/T233759 (10Legoktm) [04:43:53] 10LibUp, 10MW-1.31-release, 10Patch-For-Review: Bump PHPCS version in REL1_31 extensions - https://phabricator.wikimedia.org/T236070 (10Legoktm) https://libraryupgrader2.wmcloud.org/library/composer/mediawiki/mediawiki-codesniffer?branch=REL1_31 Currently in progress... I think we might also need a wikibase... [04:45:33] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Regression, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Legoktm) The job is named `mwext-phpunit-coverage-docker-publish`, and the zuu... [04:46:14] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Regression, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Legoktm) Oh, maybe the earlier mutex rule is overriding that? `lang=yaml #... [04:47:11] (03PS1) 10Legoktm: Only run mwext coverage jobs on master patches, really [integration/config] - 10https://gerrit.wikimedia.org/r/652923 (https://phabricator.wikimedia.org/T270976) [07:26:59] legoktm: can you push the fiwiki logo change at some point? [08:39:57] Majavah: yep, let's do that now [08:40:52] sure [09:00:59] 10Release-Engineering-Team, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Majavah: Temporarily change logo on the Finnish Wikipedia - https://phabricator.wikimedia.org/T270974 (10Majavah) 05Open→03Resolved p:05Triage→03High a:03Majavah done, I'll coordinate with fiwiki community to revert... [09:54:51] (03CR) 10Mainframe98: zuul: Add CI for the Mirage skin (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) (owner: 10Mainframe98) [14:27:31] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Ladsgroup) >>! In T108586#6715389, @Aklapper wrote: > Maybe moving some actions to an external place might be workaround to improve performance, but does this potent... [14:35:31] Amir1: can we automate these dba replies too? https://phabricator.wikimedia.org/T268458#6644801 [14:35:55] automated answers to automated tasks [14:36:25] I mean if DBAs are fine with it, that's a one-line change :D [14:36:31] 10MediaWiki-Codesniffer: MediaWiki.Classes.UnsortedUseStatements.UnsortedUse gets confused about top level anonymous function use statements - https://phabricator.wikimedia.org/T265348 (10Umherirrender) 05Open→03Resolved It is already merged [14:41:14] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.PHP71NullableDocOptionalArg too strict? - https://phabricator.wikimedia.org/T242641 (10Umherirrender) 05Open→03Resolved Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/598053 which is part of 32.0.0 [14:45:41] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10PHP 7.3 support: Update mediawiki/mediawiki-codesniffer for php7.3 support in release branches - https://phabricator.wikimedia.org/T233759 (10Umherirrender) 05Open→03Resolved Work in progress, some repos still missing, but bot/libup is running,... [14:50:34] 10MediaWiki-Codesniffer: Enforce presence of @license tag - https://phabricator.wikimedia.org/T215011 (10Umherirrender) 05Open→03Resolved Fixed with https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/603495 as optional sniff which needs config to act [14:53:36] 10MediaWiki-Codesniffer, 10Code-Health: Create a policy on importing global classes - https://phabricator.wikimedia.org/T223646 (10Umherirrender) This seems fixed with https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/603496 as optional sniff to include in the extensions config if the extensions w... [14:57:56] 10MediaWiki-Codesniffer: Review proposed PHPCS 3.5.0 upstream changes - https://phabricator.wikimedia.org/T229040 (10Umherirrender) I am not sure if there is need to look at https://github.com/PHPCSStandards/PHPCSUtils for ourer standards or for new ones. There could be some nice sniffs or helper classes, but t... [15:03:24] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10Release: Release MediaWiki CodeSniffer 34.0.0 - https://phabricator.wikimedia.org/T269464 (10Umherirrender) [15:03:27] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10Umherirrender) 05Open→03Resolved Ev... [15:03:54] 10MediaWiki-Codesniffer, 10Wikidata, 10Wikidata-Campsite: wmde / WikibaseCodeSniffer tests fail on master - https://phabricator.wikimedia.org/T250973 (10Umherirrender) 05Open→03Resolved Most work is done: T266823 More should be done on the issue tracker on github if needed [15:09:21] 10MediaWiki-Codesniffer, 10Code-Health, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22): Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Umherirrender) 05Open→03Resolved the codesniffer part was done with T169168 and with the new hook system in... [15:14:12] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for unneeded __construct functions - https://phabricator.wikimedia.org/T242402 (10Umherirrender) There is a `Generic.CodeAnalysis.UselessOverridingMethod` which is disabled due to some false positives Have not tested if it would catch all the examples fro... [15:16:31] 10MediaWiki-Codesniffer: Add or enable rule for spaces inside index brackets - https://phabricator.wikimedia.org/T195123 (10Umherirrender) [15:16:36] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Umherirrender) [16:17:59] 10Project-Admins, 10Maps: Create an #OSM tag to identify tasks with OpenStreetMap relevance - https://phabricator.wikimedia.org/T207017 (10Aklapper) 05Open→03Declined Thanks a lot for the input, very appreciated! I'm going to boldly decline this. [16:49:34] 10Phabricator: Allow others than admins to edit forms - https://phabricator.wikimedia.org/T181031 (10Aklapper) Thanks - this is "our fault". On https://phabricator.wikimedia.org/applications/edit/PhabricatorHeraldApplication/ , `Can Configure Application` is set to `Administrators`. Changing that would likely fi... [16:53:50] 10Project-Admins: New project: Wiki-Techstorm-2021 - https://phabricator.wikimedia.org/T268223 (10Aklapper) @Ecritures: Could you please answer the questions in my last comment? Thanks in advance! [16:54:50] 10Project-Admins, 10User-DannyS712: Cleaning up #mediawiki-general - https://phabricator.wikimedia.org/T249999 (10Aklapper) [16:54:52] 10Project-Admins, 10User-DannyS712: Create #mediawiki-actions component - https://phabricator.wikimedia.org/T268386 (10Aklapper) [16:54:54] 10Project-Admins, 10User-DannyS712: Create #mediawiki-namespaces - https://phabricator.wikimedia.org/T249998 (10Aklapper) [17:00:25] 10Project-Admins, 10WMF-Communications, 10Voice & Tone: Create tag for "Voice & Tone" and sufficiently explain what it is meant for - https://phabricator.wikimedia.org/T107593 (10Aklapper) > we reached out to Comms (who we have worked with on voice and tone within UI and other messaging before) to work on th... [17:42:27] (03CR) 10Jforrester: zuul: Add CI for the Mirage skin (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) (owner: 10Mainframe98) [17:58:39] (03PS1) 10Jforrester: zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/653121 (https://phabricator.wikimedia.org/T251967) [17:59:42] (03CR) 10jerkins-bot: [V: 04-1] zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/653121 (https://phabricator.wikimedia.org/T251967) (owner: 10Jforrester) [18:01:08] (03PS2) 10Jforrester: zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/653121 (https://phabricator.wikimedia.org/T251967) [18:10:49] (03CR) 10Jforrester: [C: 03+2] zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/653121 (https://phabricator.wikimedia.org/T251967) (owner: 10Jforrester) [18:12:08] (03Merged) 10jenkins-bot: zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/653121 (https://phabricator.wikimedia.org/T251967) (owner: 10Jforrester) [18:13:33] !log zuul: [mediawiki/extensions/AbuseFilter] Make sqlite tests voting T251967 [18:13:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:13:37] T251967: quibble-vendor-sqlite-php72-docker is broken by AbuseFilter - https://phabricator.wikimedia.org/T251967 [18:23:02] (03CR) 10Jforrester: [C: 03+2] "Let's try this." [integration/config] - 10https://gerrit.wikimedia.org/r/652923 (https://phabricator.wikimedia.org/T270976) (owner: 10Legoktm) [18:24:22] (03Merged) 10jenkins-bot: Only run mwext coverage jobs on master patches, really [integration/config] - 10https://gerrit.wikimedia.org/r/652923 (https://phabricator.wikimedia.org/T270976) (owner: 10Legoktm) [18:26:19] !log zuul: Try in a second way to only run mwext coverage jobs on master T270976 [18:26:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:26:22] T270976: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 [18:47:34] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review, 10Regression, 10Test-Coverage: Patches against release branches generate coverage that is published to doc.wikimedia.org - https://phabricator.wikimedia.org/T270976 (10Jdforrester-WMF) 05Open→03Resolved a:03Legoktm OK,... [19:32:29] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Jdforrester-WMF) a:05Esanders→03None [21:39:35] 10Phabricator: Cannot get list of repos via Conduit: "Query (of class \"PhabricatorRepositoryQuery\") overheated: examined more than 1,010 raw rows without finding 101 visible objects." - https://phabricator.wikimedia.org/T271004 (10Aklapper) [21:39:51] 10Phabricator: Cannot get list of repos via Conduit: "Query (of class \"PhabricatorRepositoryQuery\") overheated: examined more than 1,010 raw rows without finding 101 visible objects." - https://phabricator.wikimedia.org/T271004 (10Aklapper)