[00:04:13] 10MediaWiki-Codesniffer, 10Code-Health: Create a policy on importing global classes - https://phabricator.wikimedia.org/T223646 (10DannyS712) >>! In T223646#6715984, @Umherirrender wrote: > This seems fixed with https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/603496 as optional sniff to include... [01:17:51] (03CR) 10Umherirrender: "This change is ready for review." [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [01:18:06] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Edit Repo Config [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [01:18:24] (03CR) 10Umherirrender: [C: 03+1] "I am not allow to submit on this repo" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [01:33:47] (03CR) 10DannyS712: "> Patch Set 1: -Verified Code-Review+1" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [01:39:15] (03CR) 10Umherirrender: [C: 03+1] "> Patch Set 1:" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [02:26:02] (03CR) 10DannyS712: "> Patch Set 1:" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [03:52:47] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Tgr) It's not extra, the two have different meaning: * https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#41-making-inheritance-explicit-using-the-inheritdoc-tag * h... [09:26:13] (03PS2) 10Umherirrender: Edit Repo Config [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 [09:26:43] (03CR) 10Umherirrender: "> Patch Set 1:" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [10:25:33] (03PS2) 10Mainframe98: zuul: Add CI for the Mirage skin [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) [10:25:41] (03PS3) 10Mainframe98: zuul: Add CI for the Mirage skin [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) [17:05:21] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Umherirrender) From that text the `{@inheritDoc}` only "inherit the Description of a super-element", that does not include @param or @return and therefore it seems okay to raise an error abou... [17:32:47] 10LibUp, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: libup should set warnings to off in .eslintrc.json when using maxWarnings: 0 - https://phabricator.wikimedia.org/T263922 (10Physikerwelt) max warnings 0 --> error = warning this did never made sense to me:-) As it has been merged for P... [18:33:35] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Tgr) `@param` and `@return` are always inherited unless overridden. `@inheritDoc` is a no-op that basically serves as a comment saying "documentation inherited intentionally"; instead of comp... [19:11:42] (03CR) 10Jforrester: [C: 03+2] zuul: Add CI for the Mirage skin [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) (owner: 10Mainframe98) [19:13:06] (03Merged) 10jenkins-bot: zuul: Add CI for the Mirage skin [integration/config] - 10https://gerrit.wikimedia.org/r/652801 (https://phabricator.wikimedia.org/T270979) (owner: 10Mainframe98) [19:13:39] !log Zuul: Add CI for the Mirage skin T270979 [19:13:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:13:44] T270979: Publish Mirage skin - https://phabricator.wikimedia.org/T270979 [19:16:50] (03CR) 10Jforrester: "What's the task for the repo being archived? Clearly most of the steps haven't been taken." [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender) [19:35:25] (03CR) 10Umherirrender: "> Patch Set 2:" [services/trending-edits] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/653154 (owner: 10Umherirrender)