[00:30:01] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Gerrit-Privilege-Requests: Requesting a service account with only access to Gerrit for fundraising deployment tools - https://phabricator.wikimedia.org/T271151 (10thcipriani) 05Open→03Reso... [00:58:08] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) @hashar I created new buster VMs... [01:01:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Operations, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) Ah, I was just on the "next" depl... [01:24:49] 10LibUp: libup web could show if interaction is needed on vulnerabilities for npm / composer - https://phabricator.wikimedia.org/T271286 (10Umherirrender) [01:31:34] 10LibUp, 10Phabricator, 10Wikimedia-General-or-Unknown: Create a release monitoring bot for Phabricator - https://phabricator.wikimedia.org/T205365 (10Legoktm) [01:31:36] 10LibUp, 10Phabricator-Bot-Requests: Create Phabricator bot for LibUp - https://phabricator.wikimedia.org/T271229 (10Legoktm) [02:03:14] 10LibUp: libup web could show if interaction is needed on vulnerabilities for npm / composer - https://phabricator.wikimedia.org/T271286 (10Legoktm) > By the way: A empy https://libraryupgrader2.wmcloud.org/vulns/composer gives a server error Ugh, that was a bug. Fixed for now, but I had to delete all the compo... [07:56:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Allow @uses on FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654526 (owner: 10Umherirrender) [07:58:57] (03Merged) 10jenkins-bot: Allow @uses on FunctionAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654526 (owner: 10Umherirrender) [08:00:04] Project mwcore-phpunit-coverage-master build #1137: 04FAILURE in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1137/ [09:52:07] 10Continuous-Integration-Config, 10Code-Health, 10Discovery-Search (Current work), 10Patch-For-Review: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 (10Gehel) After doing [[ https://gerrit.wikimedia.org/r/q/topic:%2522java... [10:06:08] (03PS1) 10Hashar: Explicitly require python 3.5 or later [integration/quibble] - 10https://gerrit.wikimedia.org/r/654595 [10:06:10] (03PS1) 10Hashar: Run flake8 against all support python versions [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 [10:07:02] (03PS2) 10Hashar: Explicitly require python 3.5 or later [integration/quibble] - 10https://gerrit.wikimedia.org/r/654595 [10:07:04] (03PS2) 10Hashar: Run flake8 against all support python versions [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 [10:09:36] (03PS1) 10Hashar: Add python3.8 testing and mark it as supported [integration/quibble] - 10https://gerrit.wikimedia.org/r/654599 [10:12:33] 10Continuous-Integration-Config, 10Toolhub, 10translatewiki.net, 10Language-Team (Language-2021-January-March): Add Toolhub to translatewiki.net - https://phabricator.wikimedia.org/T269469 (10hashar) Well done @abi_ ! [10:20:32] (03CR) 10jerkins-bot: [V: 04-1] Run flake8 against all support python versions [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 (owner: 10Hashar) [10:20:44] of course it dies :\ [10:43:55] (03CR) 10Hashar: "recheck due to a race condition in upstream test tests/api-testing/REST/UserContributions.js" [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 (owner: 10Hashar) [10:49:26] (03CR) 10Hashar: "That is on my radar and I would like to get it included for the next release. My only concern is that one would need to have python 3.6 i" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [10:49:46] lunchhhh [12:14:42] (03CR) 10Awight: [C: 03+2] "Futuristic!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/654599 (owner: 10Hashar) [12:16:02] (03CR) 10Awight: [C: 03+2] Explicitly require python 3.5 or later [integration/quibble] - 10https://gerrit.wikimedia.org/r/654595 (owner: 10Hashar) [12:17:59] (03CR) 10Awight: [C: 03+2] Mute CloneMapper when running browser tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/645142 (owner: 10Hashar) [12:19:36] (03CR) 10Awight: [C: 03+2] Run flake8 against all support python versions (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 (owner: 10Hashar) [12:43:27] (03Merged) 10jenkins-bot: Explicitly require python 3.5 or later [integration/quibble] - 10https://gerrit.wikimedia.org/r/654595 (owner: 10Hashar) [12:43:29] (03Merged) 10jenkins-bot: Mute CloneMapper when running browser tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/645142 (owner: 10Hashar) [12:43:48] (03Merged) 10jenkins-bot: Run flake8 against all support python versions [integration/quibble] - 10https://gerrit.wikimedia.org/r/654596 (owner: 10Hashar) [12:46:29] (03Merged) 10jenkins-bot: Add python3.8 testing and mark it as supported [integration/quibble] - 10https://gerrit.wikimedia.org/r/654599 (owner: 10Hashar) [12:53:42] awight: thanks :] [12:54:00] will look at rebasing Kosta change about `black` on top of that [13:53:57] 10phan-taint-check-plugin, 10Technical-blog-posts: Story idea for Blog: Automatic security analysis for PHP code - https://phabricator.wikimedia.org/T268652 (10Daimona) >>! In T268652#6723809, @srodlund wrote: > @Daimona Just touching base to see how you are progressing on this. Let me know if I can be of any... [14:04:55] hasharLunch: +1 the black style should be re-run rather than conflict-resolved, of course. [14:31:34] 10Phabricator (Upstream), 10Upstream: Add a close button to "Your browser timezone setting differs from the timezone setting in your profile, click to reconcile." popup - https://phabricator.wikimedia.org/T160866 (10Base) Since the upsteam issue does not seem to be moving anywhere can we just fix this with som... [14:48:41] 10Project-Admins, 10Operations: Rename #Operations Phab project to #SRE - https://phabricator.wikimedia.org/T258305 (10Aklapper) [14:49:12] 10Project-Admins, 10SRE: Rename #Operations Phab project to #SRE - https://phabricator.wikimedia.org/T258305 (10Aklapper) 05Open→03Resolved [14:49:26] 10Project-Admins, 10SRE: Rename #Operations Phab project to #SRE - https://phabricator.wikimedia.org/T258305 (10Aklapper) a:03Aklapper https://phabricator.wikimedia.org/project/manage/1025/#73438 [16:50:52] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T267419 (10thcipriani) p:05Triage→03Medium a:03LarsWirzenius [17:00:43] 10Project-Admins, 10SRE: Rename #Operations Phab project to #SRE - https://phabricator.wikimedia.org/T258305 (10hashar) antoine-approve [17:26:06] (03CR) 10Daimona Eaytoy: [C: 03+1] "Seems sane. Unsure about the assumption that "} {" is a missing else (as opposed to just complaining about consecutive brackets), but it s" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652397 (https://phabricator.wikimedia.org/T186939) (owner: 10Majavah) [17:28:19] (03CR) 10Daimona Eaytoy: [C: 03+1] Forbid use of super global $_FILES [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654302 (owner: 10Umherirrender) [17:29:10] (03CR) 10Daimona Eaytoy: [C: 03+1] Handle possible whitespace on license names [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652409 (owner: 10Umherirrender) [17:31:44] 10Project-Admins, 10SRE: Rename #Operations Phab project to #SRE - https://phabricator.wikimedia.org/T258305 (10Legoktm) Please make sure to update #wikibugs configuration when renaming Phabricator projects. [17:37:38] (03CR) 10Daimona Eaytoy: [C: 04-1] "Should now be updated to use PHPUnitTestTrait, so we can avoid scanning all T_STRING tokens on non-test files." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [17:42:27] 10Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), 10Parsoid: Undeploy ParsoidBatchAPI from the Wikimedia cluster - https://phabricator.wikimedia.org/T242430 (10Jdforrester-WMF) [18:00:54] 10Continuous-Integration-Config: CI vulnerability scanning for fundraising gerrit projects - https://phabricator.wikimedia.org/T271352 (10Jgreen) [18:01:12] 10Continuous-Integration-Config: CI vulnerability scanning for fundraising gerrit projects - https://phabricator.wikimedia.org/T271352 (10Jgreen) [18:02:53] 10Continuous-Integration-Config: CI vulnerability scanning for fundraising gerrit projects - https://phabricator.wikimedia.org/T271352 (10Legoktm) a:03Legoktm [18:19:00] 10Release-Engineering-Team, 10WVUI, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js (Vue.js-Search): Use npm version 6.x in WVUI images - https://phabricator.wikimedia.org/T269762 (10MBinder_WMF) [18:22:48] 10Release-Engineering-Team, 10WVUI, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js (Vue.js-Search): Use npm version 6.x in WVUI images - https://phabricator.wikimedia.org/T269762 (10nnikkhoui) [18:32:56] (03PS14) 10Hashar: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [18:33:31] !log Doing a test run in beta of the scap commands I'm going to run in today's backport window to roll out profiler changes. [18:33:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:35:07] (03CR) 10Hashar: Reformat files with black (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [18:35:43] (03CR) 10Hashar: "PS14 rebased. I will send another patchset with black reformatting everything with a line-length of 79." [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [18:40:12] So it looks like `scap sync-file $dir` doesn't delete files on the target hosts. What's the correct way to roll out a mw-config change that involves file removal? [18:57:24] Project beta-scap-eqiad build #332796: 04FAILURE in 0.89 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/332796/ [18:58:57] > owner is "thcipriani"; reason is "test" (duration: 00m 00s) [18:59:04] ^ beta-scap-eqiad failure my fault [19:07:26] dpifke: Reading the scap source e.g. here, https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/scap/+/refs/heads/master/scap/tasks.py#51 , sync-file will delete files at the end the run. Can I ask which file wasn't deleted? [19:08:10] I think it was a problem with the beta environment, not with scap itself. [19:09:09] dpifke: I see, like the sync job crashed? [19:09:27] "Host key verification failed" talking to deploy-mediawiki-09. [19:09:50] I started over again and it did the correct thing with deploy-mediawiki-07. [19:10:55] Nice. I'm glad I know the answer now, anyway! [19:17:17] Yippee, build fixed! [19:17:17] Project beta-scap-eqiad build #332797: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/332797/ [19:36:57] !log Cherry-picking https://gerrit.wikimedia.org/r/c/operations/puppet/+/620729 in beta puppet. [19:36:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:43:23] (03CR) 10Hashar: Reformat files with black (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [19:44:36] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-Graph, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'type' of undefined at axis_def - https://phabricator.wikimedia.org/T270508 (10MusikAnimal) [20:00:04] Project mwcore-phpunit-coverage-master build #1138: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1138/ [20:10:27] (03PS15) 10Hashar: Reformat files with black [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [20:13:51] (03CR) 10Hashar: [C: 03+1] "So flake8 now just ignores E203 (on top of its default ignores)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/644178 (owner: 10Kosta Harlan) [23:12:12] legoktm: fyi, I fiddled a bit with https://github.com/wikimedia/request-timeout (disable issues/projects/actions tabs, disable gh deploy packages/environments in sidebar, description, alias name) [23:13:01] is a manual replication start always needed btw, or was it to fix/expedite something? [23:13:04] Krinkle: thanks, we really need some kind of checklist or script for each library [23:13:42] no, normally the GH repo is created first, so on the next push of the Gerrit repo it automatically replicates. But I guess T.im forgot that step and I didn't want to push a dummy commit to the repo so I replicated it manually [23:14:31] I see. OK [23:14:45] so normally you do need to manually create it, but then replication will get picked up on the next commit automatically [23:14:58] even if the gh repo is created late/afterward, right? [23:15:03] yeah [23:15:48] https://www.mediawiki.org/wiki/Manual:Developing_libraries is mostly a checklist [23:15:52] but I guess missing some steps [23:18:01] https://www.mediawiki.org/wiki/Developers/Maintainers#Libraries_deployed_with_MediaWiki_at_Wikimedia_Foundation [23:18:05] that list is complete as of Dec 2020 [23:18:14] went through it all and centralised the information there