[00:58:42] (03CR) 10DannyS712: [C: 03+2] Fix performance bottleneck in PHPUnit assert sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654797 (owner: 10Thiemo Kreuz (WMDE)) [00:58:49] (03PS12) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [00:59:22] (03PS13) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [00:59:39] (03CR) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [01:00:18] (03Merged) 10jenkins-bot: Fix performance bottleneck in PHPUnit assert sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654797 (owner: 10Thiemo Kreuz (WMDE)) [01:01:05] (03CR) 10jerkins-bot: [V: 04-1] Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) (owner: 10DannyS712) [01:01:25] (03PS14) 10DannyS712: Create PHPUnitAssertEmpty sniff to warn against using assertEmpty [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591242 (https://phabricator.wikimedia.org/T246674) [01:08:19] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:09:38] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:09:46] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:10:18] (03CR) 10DannyS712: [C: 03+2] Update error message about "object" type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654807 (https://phabricator.wikimedia.org/T269332) (owner: 10Thiemo Kreuz (WMDE)) [01:10:57] (03CR) 10DannyS712: [C: 03+2] Improve doc of ExtendClassUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654738 (owner: 10Ammarpad) [01:11:46] (03Merged) 10jenkins-bot: Update error message about "object" type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654807 (https://phabricator.wikimedia.org/T269332) (owner: 10Thiemo Kreuz (WMDE)) [01:12:10] (03Merged) 10jenkins-bot: Improve doc of ExtendClassUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654738 (owner: 10Ammarpad) [01:12:36] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) >>! In T271392#6729157, @Jdforrester-WMF wrote: > Seems reasonable to me. I'd like to also get in: > * https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesni... [01:14:38] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:15:22] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:15:49] 10MediaWiki-Codesniffer: phpcs ObjectTypeHintParam is incorrect. - https://phabricator.wikimedia.org/T269332 (10DannyS712) 05Open→03Resolved a:03thiemowmde [01:17:00] (03PS10) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [01:18:37] (03CR) 10jerkins-bot: [V: 04-1] New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [01:21:48] (03PS11) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [01:22:00] (03PS12) 10DannyS712: New sniff: MediaWiki.PHPUnit.SpecificAssertions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) [03:43:48] (03PS1) 10Jforrester: Zuul: [mediawiki/libs/Equivset] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655185 (https://phabricator.wikimedia.org/T271575) [04:27:11] 10phan: Phan shouldn't throw PhanUndeclaredMethod on a method we just method_exists()'ed on - https://phabricator.wikimedia.org/T271609 (10Jdforrester-WMF) [04:28:41] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/libs/Equivset] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655185 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [04:28:50] (03PS1) 10Jforrester: Zuul: [mediawiki/libs/RemexHtml] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655186 (https://phabricator.wikimedia.org/T271575) [04:29:05] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/libs/RemexHtml] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655186 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [04:29:59] (03CR) 10Jforrester: [V: 03+2 C: 03+2] Indicate that the repo is archived [php/tidy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647080 (owner: 10MaxSem) [04:30:02] (03Merged) 10jenkins-bot: Zuul: [mediawiki/libs/Equivset] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655185 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [04:30:24] (03Merged) 10jenkins-bot: Zuul: [mediawiki/libs/RemexHtml] Enable PHP 8.0 jobs, now passing [integration/config] - 10https://gerrit.wikimedia.org/r/655186 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [04:30:50] !log Zuul: [mediawiki/libs/Equivset] Enable PHP 8.0 jobs, now passing T271575 [04:30:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:30:54] T271575: Test (and pass) all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 [04:30:55] !log Zuul: [mediawiki/libs/RemexHtml] Enable PHP 8.0 jobs, now passing T271575 [04:30:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [05:05:08] any ideas why abuse filter thinks page_id during deletion? but only some of the time? https://wikimania.wikimedia.org/wiki/Special:AbuseLog?wpSearchUser=DannyS712 [07:42:13] (03CR) 10DannyS712: "@Jdforrester needs manual `submit` too" [php/tidy] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/647080 (owner: 10MaxSem) [10:20:03] (03PS2) 10Umherirrender: Allow parenthesis as punction on @var types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652414 (https://phabricator.wikimedia.org/T268087) [10:20:19] (03CR) 10Umherirrender: "Rebased (conflict in tests only)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652414 (https://phabricator.wikimedia.org/T268087) (owner: 10Umherirrender) [10:28:30] (03CR) 10DannyS712: [C: 03+1] Allow parenthesis as punction on @var types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/652414 (https://phabricator.wikimedia.org/T268087) (owner: 10Umherirrender) [10:33:48] (03PS1) 10Umherirrender: Check @param/@return on files ending in Test.php [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655188 [11:05:29] (03PS2) 10Umherirrender: Check @param/@return on files ending in Test.php [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655188 (https://phabricator.wikimedia.org/T238572) [11:13:45] 10phan: Phan shouldn't throw PhanUndeclaredMethod on a method we just method_exists()'ed on - https://phabricator.wikimedia.org/T271609 (10Umherirrender) In most cases `is_callable` does not result in an issue, while `method_exists` does [11:21:00] 10phan, 10Upstream: Phan shouldn't throw PhanUndeclaredMethod on a method we just method_exists()'ed on - https://phabricator.wikimedia.org/T271609 (10Daimona) Yeah, this is a known issue, see https://github.com/phan/phan/issues/1204 and https://github.com/phan/phan/issues/2628. Similar cases with `defined()`... [17:40:15] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) Alright... basically https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Webrequest : Log into Hive on `stat1007`, then `use wmf` DB. Tasks that must ha... [20:00:04] Project mwcore-phpunit-coverage-master build #1144: 04FAILURE in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1144/ [20:02:04] lol, timeout [21:29:12] lol [22:57:53] time to write more tests! [23:17:41] it's always a good moment to write more tests [23:25:43] our tests take too long to run already